Complex classes like MediawikiApi often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MediawikiApi, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
27 | class MediawikiApi implements MediawikiApiInterface, LoggerAwareInterface { |
||
28 | |||
29 | /** |
||
30 | * @var ClientInterface|null Should be accessed through getClient |
||
31 | */ |
||
32 | private $client = null; |
||
33 | |||
34 | /** |
||
35 | * @var bool|string |
||
36 | */ |
||
37 | private $isLoggedIn; |
||
38 | |||
39 | /** |
||
40 | * @var MediawikiSession |
||
41 | */ |
||
42 | private $session; |
||
43 | |||
44 | /** |
||
45 | * @var string |
||
46 | */ |
||
47 | private $version; |
||
48 | |||
49 | /** |
||
50 | * @var LoggerInterface |
||
51 | */ |
||
52 | private $logger; |
||
53 | |||
54 | /** |
||
55 | * @var string |
||
56 | */ |
||
57 | private $apiUrl; |
||
58 | |||
59 | /** |
||
60 | * @since 2.0 |
||
61 | * |
||
62 | * @param string $apiEndpoint e.g. https://en.wikipedia.org/w/api.php |
||
63 | * |
||
64 | * @return self returns a MediawikiApi instance using $apiEndpoint |
||
65 | */ |
||
66 | public static function newFromApiEndpoint( $apiEndpoint ) { |
||
69 | |||
70 | /** |
||
71 | * Create a new MediawikiApi object from a URL to any page in a MediaWiki website. |
||
72 | * |
||
73 | * @since 2.0 |
||
74 | * @see https://en.wikipedia.org/wiki/Really_Simple_Discovery |
||
75 | * |
||
76 | * @param string $url e.g. https://en.wikipedia.org OR https://de.wikipedia.org/wiki/Berlin |
||
77 | * @return self returns a MediawikiApi instance using the apiEndpoint provided by the RSD |
||
78 | * file accessible on all Mediawiki pages |
||
79 | * @throws RsdException If the RSD URL could not be found in the page's HTML. |
||
80 | */ |
||
81 | 3 | public static function newFromPage( $url ) { |
|
113 | |||
114 | /** |
||
115 | * @param string $apiUrl The API Url |
||
116 | * @param ClientInterface|null $client Guzzle Client |
||
117 | * @param MediawikiSession|null $session Inject a custom session here |
||
118 | */ |
||
119 | 24 | public function __construct( $apiUrl, ClientInterface $client = null, |
|
134 | |||
135 | /** |
||
136 | * Get the API URL (the URL to which API requests are sent, usually ending in api.php). |
||
137 | * This is useful if you've created this object via MediawikiApi::newFromPage(). |
||
138 | * |
||
139 | * @since 2.3 |
||
140 | * |
||
141 | * @return string The API URL. |
||
142 | */ |
||
143 | public function getApiUrl() { |
||
146 | |||
147 | /** |
||
148 | * @return ClientInterface |
||
149 | */ |
||
150 | 21 | private function getClient() { |
|
158 | |||
159 | /** |
||
160 | * Sets a logger instance on the object |
||
161 | * |
||
162 | * @since 1.1 |
||
163 | * |
||
164 | * @param LoggerInterface $logger |
||
165 | * |
||
166 | * @return null |
||
167 | */ |
||
168 | public function setLogger( LoggerInterface $logger ) { |
||
172 | |||
173 | /** |
||
174 | * @since 2.0 |
||
175 | * |
||
176 | * @param Request $request |
||
177 | * |
||
178 | * @return PromiseInterface |
||
179 | * Normally promising an array, though can be mixed (json_decode result) |
||
180 | * Can throw UsageExceptions or RejectionExceptions |
||
181 | */ |
||
182 | 1 | public function getRequestAsync( Request $request ) { |
|
193 | |||
194 | /** |
||
195 | * @since 2.0 |
||
196 | * |
||
197 | * @param Request $request |
||
198 | * |
||
199 | * @return PromiseInterface |
||
200 | * Normally promising an array, though can be mixed (json_decode result) |
||
201 | * Can throw UsageExceptions or RejectionExceptions |
||
202 | */ |
||
203 | 1 | public function postRequestAsync( Request $request ) { |
|
214 | |||
215 | /** |
||
216 | * @since 0.2 |
||
217 | * |
||
218 | * @param Request $request |
||
219 | * |
||
220 | * @return mixed Normally an array |
||
221 | */ |
||
222 | 9 | public function getRequest( Request $request ) { |
|
231 | |||
232 | /** |
||
233 | * @since 0.2 |
||
234 | * |
||
235 | * @param Request $request |
||
236 | * |
||
237 | * @return mixed Normally an array |
||
238 | */ |
||
239 | 10 | public function postRequest( Request $request ) { |
|
248 | |||
249 | /** |
||
250 | * @param ResponseInterface $response |
||
251 | * |
||
252 | * @return mixed |
||
253 | * @throws UsageException |
||
254 | */ |
||
255 | 21 | private function decodeResponse( ResponseInterface $response ) { |
|
263 | |||
264 | /** |
||
265 | * @param Request $request |
||
266 | * |
||
267 | * @return string |
||
268 | */ |
||
269 | 9 | private function getPostRequestEncoding( Request $request ) { |
|
277 | |||
278 | /** |
||
279 | * @param Request $request |
||
280 | * @param string $paramsKey either 'query' or 'multipart' |
||
281 | * |
||
282 | * @throws RequestException |
||
283 | * |
||
284 | * @return array as needed by ClientInterface::get and ClientInterface::post |
||
285 | */ |
||
286 | 21 | private function getClientRequestOptions( Request $request, $paramsKey ) { |
|
298 | |||
299 | /** |
||
300 | * @param array $params |
||
301 | * |
||
302 | * @return array |
||
303 | */ |
||
304 | 1 | private function encodeMultipartParams( $params ) { |
|
318 | |||
319 | /** |
||
320 | * @return array |
||
321 | */ |
||
322 | 17 | private function getDefaultHeaders() { |
|
327 | |||
328 | 17 | private function getUserAgent() { |
|
335 | |||
336 | /** |
||
337 | * @param $result |
||
338 | */ |
||
339 | 17 | private function logWarnings( $result ) { |
|
352 | |||
353 | /** |
||
354 | * @param array $result |
||
355 | * |
||
356 | * @throws UsageException |
||
357 | */ |
||
358 | 17 | private function throwUsageExceptions( $result ) { |
|
367 | |||
368 | /** |
||
369 | * @since 0.1 |
||
370 | * |
||
371 | * @return bool|string false or the name of the current user |
||
372 | */ |
||
373 | 17 | public function isLoggedin() { |
|
376 | |||
377 | /** |
||
378 | * @since 0.1 |
||
379 | * |
||
380 | * @param ApiUser $apiUser |
||
381 | * |
||
382 | * @throws UsageException |
||
383 | * @return bool success |
||
384 | */ |
||
385 | 2 | public function login( ApiUser $apiUser ) { |
|
403 | |||
404 | /** |
||
405 | * @param ApiUser $apiUser |
||
406 | * |
||
407 | * @return string[] |
||
408 | */ |
||
409 | 2 | private function getLoginParams( ApiUser $apiUser ) { |
|
420 | |||
421 | /** |
||
422 | * @param array $result |
||
423 | * |
||
424 | * @throws UsageException |
||
425 | */ |
||
426 | 1 | private function throwLoginUsageException( $result ) { |
|
437 | |||
438 | /** |
||
439 | * @since 0.1 |
||
440 | * |
||
441 | * @return bool success |
||
442 | */ |
||
443 | 2 | public function logout() { |
|
453 | |||
454 | /** |
||
455 | * @since 0.1 |
||
456 | * |
||
457 | * @param string $type |
||
458 | * |
||
459 | * @return string |
||
460 | */ |
||
461 | 2 | public function getToken( $type = 'csrf' ) { |
|
464 | |||
465 | /** |
||
466 | * @since 0.1 |
||
467 | * |
||
468 | * Clears all tokens stored by the api |
||
469 | */ |
||
470 | 1 | public function clearTokens() { |
|
473 | |||
474 | /** |
||
475 | * @return string |
||
476 | */ |
||
477 | 4 | public function getVersion() { |
|
492 | |||
493 | } |
||
494 |