addiks / symfony_rdm

Tests/Mapping/Drivers/MappingXmlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingXmlDriver;

Spacing +2 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
 
         $this->mappingDriver = new MappingXmlDriver(
             $this->fileLocator,
-            realpath(__DIR__ . "/../../../Resources/mapping-schema.v1.xsd")
+            realpath(__DIR__."/../../../Resources/mapping-schema.v1.xsd")
         );
     }
 
@@ -52,7 +52,7 @@ 
     public function shouldReadMappingData()
     {
         /** @var string $mappingFilePath */
-        $mappingFilePath = __DIR__ . "/EntityExample.orm.xml";
+        $mappingFilePath = __DIR__."/EntityExample.orm.xml";
 
         $expectedMapping = new EntityMapping(EntityExample::class, [
             'foo' => new ServiceMapping('some_service', false, "in file '{$mappingFilePath}'"),

Tests/Mapping/Drivers/MappingYamlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingYamlDriver;

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     public function shouldReadMappingData()
     {
         /** @var string $mappingFilePath */
-        $mappingFilePath = __DIR__ . "/EntityExample.orm.yml";
+        $mappingFilePath = __DIR__."/EntityExample.orm.yml";
 
         $expectedMapping = new EntityMapping(EntityExample::class, [
             'foo' => new ServiceMapping('some_service', false, "in file '{$mappingFilePath}'"),

Tests/ValueResolver/ChoiceValueResolverTest.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
 use Addiks\RDMBundle\Mapping\ServiceMapping;
-use Addiks\RDMBundle\Mapping\MappingInterface;
 
 final class ChoiceValueResolverTest extends TestCase
 {

ValueResolver/ChoiceValueResolver.php

Indentation +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
                     $choiceMapping,
                     $entity,
                     [] # <= I'm not sure how this parameter should be handled correctly in the future,
-                       #    but with the current supported features it *should* be irrelevant.
+                        #    but with the current supported features it *should* be irrelevant.
                 );
 
                 if ($choiceValue === $valueFromEntityField) {

Mapping/ChoiceMapping.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     ) {
         if (!$determinatorColumn instanceof Column) {
             $determinatorColumn = new Column(
-                (string)$determinatorColumn,
+                (string) $determinatorColumn,
                 Type::getType('string'),
                 [
                     'notnull' => false,

Mapping/Drivers/MappingAnnotationDriver.php

Spacing +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
                 $column->type = 'string';
                 $column->length = 255;
                 $column->unique = false;
-                $column->nullable = (bool)$annotation->nullable;
+                $column->nullable = (bool) $annotation->nullable;
             }
 
             $dbalColumn = new DBALColumn(

Tests/Mapping/Drivers/MappingAnnotationDriverTest.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
         ];
 
         $this->annotationReader->method('getPropertyAnnotations')->will($this->returnCallback(
-            function (ReflectionProperty $propertyReflection) use ($annotationMap) {
+            function(ReflectionProperty $propertyReflection) use ($annotationMap) {
                 if (isset($annotationMap[$propertyReflection->getName()])) {
                     return $annotationMap[$propertyReflection->getName()];
                 } else {

Tests/Symfony/FormType/ServiceFormTypeTest.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
         $modelTransformer = null;
 
         $builder->expects($this->once())->method('addModelTransformer')->will($this->returnCallback(
-            function ($calledModelTransformer) use (&$modelTransformer) {
+            function($calledModelTransformer) use (&$modelTransformer) {
                 $modelTransformer = $calledModelTransformer;
             }
         ));