addiks / symfony_rdm

DataLoader/SimpleSelectDataLoader.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function loadDBALDataForEntity($entity, EntityManagerInterface $entityManager): array
     {
@@ -163,7 +163,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function storeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 use PDO;
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
-use Doctrine\ORM\Proxy\Proxy;
 
 /**
  * A very simple loader that just executes one simple select statement for every entity to load the data for.

Doctrine/EventListener.php

Unused Use Statements -3 removed lines

@@ -23,9 +23,6 @@
 use Doctrine\ORM\UnitOfWork;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Schema\Column;
-use Doctrine\Common\EventArgs;
-use Doctrine\Common\Persistence\ObjectManager;
-use Doctrine\ORM\Event\OnFlushEventArgs;
 use Doctrine\ORM\Event\PostFlushEventArgs;
 use Doctrine\ORM\Proxy\Proxy;
 

Exception/FailedRDMAssertionException.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 namespace Addiks\RDMBundle\Exception;
 
 use ErrorException;
-use ReflectionProperty;
 use ReflectionClass;
 use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;
 

Spacing +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
         $actualDescription = null;
 
         if (is_object($actualService)) {
-            $actualDescription = get_class($actualService) . '#' . spl_object_hash($actualService);
+            $actualDescription = get_class($actualService).'#'.spl_object_hash($actualService);
 
         } else {
             $actualDescription = gettype($actualService);
@@ -70,7 +70,7 @@ 
         $expectedDescription = null;
 
         if (is_object($expectedService)) {
-            $expectedDescription = get_class($expectedService) . '#' . spl_object_hash($expectedService);
+            $expectedDescription = get_class($expectedService).'#'.spl_object_hash($expectedService);
 
         } else {
             $expectedDescription = gettype($expectedService);

Hydration/EntityHydrator.php

Unused Use Statements -3 removed lines

@@ -13,13 +13,10 @@
 use ReflectionClass;
 use ReflectionProperty;
 use Doctrine\Common\Util\ClassUtils;
-use Doctrine\DBAL\Schema\Column;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Addiks\RDMBundle\Mapping\EntityMappingInterface;
 use Addiks\RDMBundle\Mapping\MappingInterface;
-use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Addiks\RDMBundle\Hydration\EntityHydratorInterface;
-use Addiks\RDMBundle\Exception\FailedRDMAssertionException;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
 use Addiks\RDMBundle\DataLoader\DataLoaderInterface;
 use Doctrine\ORM\EntityManagerInterface;

Mapping/Drivers/MappingPHPDriver.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 
                 (
                     /**
-                     * @param mixed $rdmMapping
+                     * @param string $rdmMapping
                      */
                     function (&$rdmMapping) use ($mappingFile): void {
                         /** @psalm-suppress UnresolvableInclude */

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
-use Addiks\RDMBundle\Mapping\Annotation\RDMAnnotationInterface;
 use Addiks\RDMBundle\Mapping\EntityMappingInterface;
 
 final class MappingPHPDriver implements MappingDriverInterface

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
                     /**
                      * @param mixed $rdmMapping
                      */
-                    function (&$rdmMapping) use ($mappingFile): void {
+                    function(&$rdmMapping) use ($mappingFile): void {
                         /** @psalm-suppress UnresolvableInclude */
                         include $mappingFile;
                     }

Mapping/Drivers/MappingXmlDriver.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
-use Addiks\RDMBundle\Exception\InvalidMappingException;
 use DOMAttr;
 use Doctrine\DBAL\Schema\Column;
 use Doctrine\DBAL\Types\Type;

Spacing +13 added lines, -13 removed lines

@@ -80,7 +80,7 @@ 
                     /** @var DOMNode $serviceNode */
 
                     /** @var string $fieldName */
-                    $fieldName = (string)$serviceNode->attributes->getNamedItem("field")->nodeValue;
+                    $fieldName = (string) $serviceNode->attributes->getNamedItem("field")->nodeValue;
 
                     $fieldMappings[$fieldName] = $this->readService($serviceNode, $mappingFile);
                 }
@@ -89,7 +89,7 @@ 
                     /** @var DOMNode $choiceNode */
 
                     /** @var string $fieldName */
-                    $fieldName = (string)$choiceNode->attributes->getNamedItem("field")->nodeValue;
+                    $fieldName = (string) $choiceNode->attributes->getNamedItem("field")->nodeValue;
 
                     $fieldMappings[$fieldName] = $this->readChoice($choiceNode, $mappingFile, $fieldName);
                 }
@@ -111,7 +111,7 @@ 
         $column = $defaultColumnName;
 
         if (!is_null($choiceNode->attributes->getNamedItem("column"))) {
-            $column = (string)$choiceNode->attributes->getNamedItem("column")->nodeValue;
+            $column = (string) $choiceNode->attributes->getNamedItem("column")->nodeValue;
         }
 
         /** @var array<MappingInterface> $choiceMappings */
@@ -129,11 +129,11 @@ 
 
             if ($optionNode instanceof DOMNode) {
                 /** @var mixed $nodeName */
-                $nodeName = $optionNode->namespaceURI . ":" . $optionNode->localName;
+                $nodeName = $optionNode->namespaceURI.":".$optionNode->localName;
 
-                if ($nodeName === self::RDM_SCHEMA_URI . ":option") {
+                if ($nodeName === self::RDM_SCHEMA_URI.":option") {
                     /** @var string $determinator */
-                    $determinator = (string)$optionNode->attributes->getNamedItem("name")->nodeValue;
+                    $determinator = (string) $optionNode->attributes->getNamedItem("name")->nodeValue;
 
                     /** @var DOMNode $optionMappingNode */
                     $optionMappingNode = $optionNode->firstChild;
@@ -142,10 +142,10 @@ 
                         $optionMappingNode = $optionMappingNode->nextSibling;
                     }
 
-                    if ($optionMappingNode->nodeName === $optionMappingNode->prefix . ":service") {
+                    if ($optionMappingNode->nodeName === $optionMappingNode->prefix.":service") {
                         $choiceMappings[$determinator] = $this->readService($optionMappingNode, $mappingFile);
 
-                    } elseif ($optionMappingNode->nodeName === $optionMappingNode->prefix . ":choice") {
+                    } elseif ($optionMappingNode->nodeName === $optionMappingNode->prefix.":choice") {
                         $choiceMappings[$determinator] = $this->readChoice($optionMappingNode, $mappingFile, sprintf(
                             "%s_%s",
                             $defaultColumnName,
@@ -153,7 +153,7 @@ 
                         ));
                     }
 
-                } elseif ($nodeName === self::DOCTRINE_SCHEMA_URI . ":field") {
+                } elseif ($nodeName === self::DOCTRINE_SCHEMA_URI.":field") {
                     $column = $this->readDoctrineField($optionNode);
                 }
             }
@@ -175,10 +175,10 @@ 
         }
 
         /** @var string $serviceId */
-        $serviceId = (string)$serviceNode->attributes->getNamedItem("id")->nodeValue;
+        $serviceId = (string) $serviceNode->attributes->getNamedItem("id")->nodeValue;
 
         if (!is_bool($lax)) {
-            $lax = (strtolower((string)$lax) === 'true');
+            $lax = (strtolower((string) $lax) === 'true');
         }
 
         return new ServiceMapping($serviceId, $lax, sprintf(
@@ -212,7 +212,7 @@ 
         foreach ($fieldNode->attributes as $key => $attribute) {
             /** @var DOMAttr $attribute */
 
-            $attributeValue = (string)$attribute->nodeValue;
+            $attributeValue = (string) $attribute->nodeValue;
 
             if ($key === 'name') {
                 $columnName = $attributeValue;
@@ -226,7 +226,7 @@ 
                     $attributeValue = ($attributeValue === 'false');
                 }
 
-                $attributes[$keyMap[$key]] = (string)$attribute->nodeValue;
+                $attributes[$keyMap[$key]] = (string) $attribute->nodeValue;
             }
         }
 

Mapping/Drivers/MappingYamlDriver.php

Unused Use Statements -2 removed lines

@@ -19,8 +19,6 @@
 use Addiks\RDMBundle\Mapping\EntityMapping;
 use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
-use Doctrine\DBAL\Schema\Column;
-use Doctrine\DBAL\Types\Type;
 
 final class MappingYamlDriver implements MappingDriverInterface
 {

Spacing +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
         $determinatorColumnName = $fieldName;
 
         if ($choiceYaml['column']) {
-            $determinatorColumnName = (string)$choiceYaml['column'];
+            $determinatorColumnName = (string) $choiceYaml['column'];
         }
 
         foreach ($choiceYaml['choices'] as $determinator => $choiceYaml) {

Symfony/FormType/ServiceFormType.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 
             $builder->addModelTransformer(new CallbackTransformer(
                 /**
-                 * @param object $service
+                 * @param FormBuilderInterface $service
                  */
                 function ($service) use ($container, $options): ?string {
                     /** @var ?string $serviceId */

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use Symfony\Component\OptionsResolver\OptionsResolverInterface;
 use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\Form\FormConfigBuilder;
 use Symfony\Component\Form\FormConfigBuilderInterface;
 use Symfony\Component\Form\CallbackTransformer;
 use Symfony\Component\OptionsResolver\OptionsResolver;

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
                 /**
                  * @param object $service
                  */
-                function ($service) use ($container, $options): ?string {
+                function($service) use ($container, $options): ?string {
                     /** @var ?string $serviceId */
                     $serviceId = null;
 
@@ -66,7 +66,7 @@ 
                 /**
                  * @return ?object
                  */
-                function (string $serviceId) use ($container) {
+                function(string $serviceId) use ($container) {
                     /** @var ?object $service */
                     $service = null;
 

Tests/DataLoader/ChoosingDataLoaderFactoryTest.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\DataLoader\ChoosingDataLoaderFactory;
-use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Addiks\RDMBundle\DataLoader\DataLoaderInterface;