Conditions | 2 |
Paths | 1 |
Total Lines | 105 |
Code Lines | 77 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
59 | public function shouldReadAnnotations() |
||
60 | { |
||
61 | $someAnnotationA = new Service(); |
||
62 | $someAnnotationA->id = "some_service"; |
||
63 | $someAnnotationA->field = "foo"; |
||
64 | |||
65 | $someAnnotationB = new Service(); |
||
66 | $someAnnotationB->id = "other_service"; |
||
67 | $someAnnotationB->field = "bar"; |
||
68 | $someAnnotationB->lax = true; |
||
69 | |||
70 | $someAnnotationC = new Choice(); |
||
71 | $someAnnotationC->column = "baz_column"; |
||
72 | $someAnnotationC->nullable = true; |
||
73 | $someAnnotationC->choices = [ |
||
74 | 'foo' => $someAnnotationA, |
||
75 | 'bar' => $someAnnotationB, |
||
76 | ]; |
||
77 | |||
78 | $someAnnotationD = new Choice(); |
||
79 | $someAnnotationD->column = "faz_column"; |
||
80 | $someAnnotationD->nullable = false; |
||
81 | $someAnnotationD->choices = [ |
||
82 | 'foo' => $someAnnotationA, |
||
83 | 'bar' => $someAnnotationB, |
||
84 | ]; |
||
85 | |||
86 | $someAnnotationF = new ORMColumn(); |
||
87 | $someAnnotationF->name = "someField"; |
||
88 | $someAnnotationF->length = 12; |
||
89 | |||
90 | $someAnnotationE = new Obj(); |
||
91 | $someAnnotationE->{"class"} = ValueObjectExample::class; |
||
92 | $someAnnotationE->fields = [ |
||
93 | 'foo' => $someAnnotationA, |
||
94 | 'bar' => $someAnnotationF, |
||
95 | ]; |
||
96 | |||
97 | $someAnnotationG = new Arr(); |
||
98 | $someAnnotationG->entries = [ |
||
99 | 'foo' => $someAnnotationA, |
||
100 | 'bar' => $someAnnotationF, |
||
101 | ]; |
||
102 | |||
103 | /** @var string $entityClass */ |
||
104 | $entityClass = EntityExample::class; |
||
105 | |||
106 | /** @var array<MappingInterface> $expectedFieldMappings */ |
||
107 | $expectedFieldMappings = [ |
||
108 | 'foo' => new ServiceMapping("some_service", false, "in entity '{$entityClass}' on field 'foo'"), |
||
109 | 'bar' => new ServiceMapping("other_service", true, "in entity '{$entityClass}' on field 'bar'"), |
||
110 | 'baz' => new ChoiceMapping('baz_column', [ |
||
111 | 'foo' => new ServiceMapping("some_service", false, "in entity '{$entityClass}' on field 'baz'"), |
||
112 | 'bar' => new ServiceMapping("other_service", true, "in entity '{$entityClass}' on field 'baz'"), |
||
113 | ], "in entity 'Addiks\RDMBundle\Tests\Hydration\EntityExample' on field 'baz'"), |
||
114 | 'faz' => new ChoiceMapping(new DBALColumn('faz_column', Type::getType('string'), [ |
||
115 | 'notnull' => true, |
||
116 | 'length' => 255, |
||
117 | ]), [ |
||
118 | 'foo' => new ServiceMapping("some_service", false, "in entity '{$entityClass}' on field 'faz'"), |
||
119 | 'bar' => new ServiceMapping("other_service", true, "in entity '{$entityClass}' on field 'faz'"), |
||
120 | ], "in entity 'Addiks\RDMBundle\Tests\Hydration\EntityExample' on field 'faz'"), |
||
121 | 'boo' => new ObjectMapping(ValueObjectExample::class, [ |
||
122 | 'foo' => new ServiceMapping("some_service", false, "in entity '{$entityClass}' on field 'boo->foo'"), |
||
123 | 'bar' => new FieldMapping(new DBALColumn('someField', Type::getType('string'), [ |
||
124 | 'notnull' => true, |
||
125 | 'precision' => 0, |
||
126 | 'length' => 12, |
||
127 | ]), "in entity '{$entityClass}' on field 'boo->bar'"), |
||
128 | ], "in entity 'Addiks\RDMBundle\Tests\Hydration\EntityExample' on field 'boo'"), |
||
129 | 'arr' => new ArrayMapping([ |
||
130 | 'foo' => new ServiceMapping("some_service", false, "in entity '{$entityClass}' on field 'arr->foo'"), |
||
131 | 'bar' => new FieldMapping(new DBALColumn('someField', Type::getType('string'), [ |
||
132 | 'notnull' => true, |
||
133 | 'precision' => 0, |
||
134 | 'length' => 12, |
||
135 | ]), "in entity '{$entityClass}' on field 'arr->bar'"), |
||
136 | ], "in entity 'Addiks\RDMBundle\Tests\Hydration\EntityExample' on field 'arr'") |
||
137 | ]; |
||
138 | |||
139 | /** @var array<array<Service>> $annotationMap */ |
||
140 | $annotationMap = [ |
||
141 | 'foo' => [$someAnnotationA], |
||
142 | 'bar' => [$someAnnotationB], |
||
143 | 'baz' => [$someAnnotationC], |
||
144 | 'faz' => [$someAnnotationD], |
||
145 | 'boo' => [$someAnnotationE], |
||
146 | 'arr' => [$someAnnotationG], |
||
147 | ]; |
||
148 | |||
149 | $this->annotationReader->method('getPropertyAnnotations')->will($this->returnCallback( |
||
150 | function (ReflectionProperty $propertyReflection) use ($annotationMap) { |
||
151 | if (isset($annotationMap[$propertyReflection->getName()])) { |
||
152 | return $annotationMap[$propertyReflection->getName()]; |
||
153 | } else { |
||
154 | return []; |
||
155 | } |
||
156 | } |
||
157 | )); |
||
158 | |||
159 | /** @var EntityMapping $actualMapping */ |
||
160 | $actualMapping = $this->mappingDriver->loadRDMMetadataForClass(EntityExample::class); |
||
161 | |||
162 | $this->assertEquals($expectedFieldMappings, $actualMapping->getFieldMappings()); |
||
163 | } |
||
164 | |||
166 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..