Addiks\RDMBundle\Exception\FailedRDMAssertionException

Complexity

Total Complexity

6

Size/Duplication

Total Lines	75
Duplicated Lines	16 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

81.48%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getType()	0	4	1
A	getParameters()	0	4	1
B	expectedDifferentService()	12	38	3

<?php
/**
 * Copyright (C) 2018 Gerrit Addiks.
 * This package (including this file) was released under the terms of the GPL-3.0.
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
 * @license GPL-3.0
 * @author Gerrit Addiks <gerrit@addiks.de>
 */

namespace Addiks\RDMBundle\Exception;

use ErrorException;
use ReflectionClass;
use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;

final class FailedRDMAssertionException extends ErrorException implements FailedRDMAssertionExceptionInterface

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: __toString, getCode, getFile, getLine, getMessage, getPrevious, getTrace, getTraceAsString

{

    /**
     * @var string
     */
    private $type;

    /**
     * @var array<mixed>
     */
    private $parameters;

    public function __construct(string $message, string $type, array $parameters)
    {
        parent::__construct($message);

        $this->type = $type;
        $this->parameters = $parameters;
    }

    public function getType(): string
    {
        return $this->type;
    }

    public function getParameters(): array
    {
        return $this->parameters;
    }

    /**
     * @param mixed $expectedService
     * @param mixed $actualService
     */
    public static function expectedDifferentService(
        string $serviceId,
        ReflectionClass $classReflection,
        $expectedService,
        $actualService
    ): FailedRDMAssertionException {
        /** @var string $actualDescription */
        $actualDescription = null;

$actualDescription is not used, you could remove the assignment.

        if (is_object($actualService)) {

This code seems to be duplicated across your project.

            $actualDescription = get_class($actualService) . '#' . spl_object_hash($actualService);

        } else {
            $actualDescription = gettype($actualService);
        }

        /** @var string $expectedDescription */
        $expectedDescription = null;

$expectedDescription is not used, you could remove the assignment.

        if (is_object($expectedService)) {

This code seems to be duplicated across your project.

            $expectedDescription = get_class($expectedService) . '#' . spl_object_hash($expectedService);

        } else {
            $expectedDescription = gettype($expectedService);
        }

        return new self(
            sprintf(
                "Expected service %s (%s) on entity %s, was %s instead!",
                $serviceId,
                $expectedDescription,
                $classReflection->getName(),

Consider using $classReflection->name. There is an issue with getName() and APC-enabled PHP versions.

                $actualDescription
            ),
            "EXPECTED_DIFFERENT_SERVICE",
            [$serviceId, $expectedService, $actualService]
        );
    }

}