addiks / symfony_rdm

Tests/Mapping/Drivers/MappingPHPDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Addiks\RDMBundle\Mapping\Drivers\MappingPHPDriver;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;

Tests/Mapping/Drivers/MappingXmlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingXmlDriver;

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
             'bar' => new ServiceMapping($this->container, 'other_service', false, "in file '{$mappingFilePath}'"),
             'baz' => new ChoiceMapping('baz_column', [
                 'lorem' => new ServiceMapping($this->container, "lorem_service", false, "in file '{$mappingFilePath}'"),
-                'ipsum' => new ServiceMapping($this->container, "ipsum_service", true,  "in file '{$mappingFilePath}'"),
+                'ipsum' => new ServiceMapping($this->container, "ipsum_service", true, "in file '{$mappingFilePath}'"),
             ], "in file '{$mappingFilePath}'"),
             'faz' => new ChoiceMapping(new Column("faz_column", Type::getType('string'), ['notnull' => true]), [
                 'lorem' => new ServiceMapping($this->container, "lorem_service", false, "in file '{$mappingFilePath}'"),

Tests/Mapping/Drivers/MappingYamlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingYamlDriver;

DependencyInjection/AddiksRDMExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }

DataLoader/SimpleSelectDataLoader.php

Doc Comments +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function loadDBALDataForEntity($entity, EntityManagerInterface $entityManager): array
     {
@@ -160,7 +160,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function storeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {
@@ -197,7 +197,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function removeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {

Tests/ValueObjectExample.php

Doc Comments +3 added lines

@@ -59,6 +59,9 @@
         return [$this->scalarValue, $this->lorem, $this->dolor];
     }
 
+    /**
+     * @param string $amet
+     */
     public function setAmet($amet)
     {
         $this->amet = $amet;

Tests/Mapping/Drivers/MappingAnnotationDriverTest.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use Doctrine\DBAL\Schema\Column as DBALColumn;
 use Doctrine\DBAL\Types\Type;
 use Addiks\RDMBundle\Mapping\MappingInterface;
-use Addiks\RDMBundle\Mapping\Annotation\Obj;
 use Addiks\RDMBundle\Tests\ValueObjectExample;
 use Addiks\RDMBundle\Mapping\ObjectMapping;
 use Doctrine\ORM\Mapping\Column as ORMColumn;

Mapping/ChoiceMapping.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Doctrine\DBAL\Schema\Column;
 use Doctrine\DBAL\Types\Type;
-use Doctrine\DBAL\Types\TextType;
 use Addiks\RDMBundle\Exception\InvalidMappingException;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;

Indentation +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
             $choiceValue = $choiceMapping->resolveValue(
                 $context,
                 [] # <= I'm not sure how this parameter should be handled correctly in the future,
-                   #    but with the current supported features it *should* be irrelevant.
+                    #    but with the current supported features it *should* be irrelevant.
             );
 
             if ($choiceValue === $valueFromEntityField) {

Tests/DataLoader/SimpleSelectDataLoaderTest.php

Unused Use Statements -2 removed lines

@@ -12,7 +12,6 @@ 
 
 use Addiks\RDMBundle\DataLoader\SimpleSelectDataLoader;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
-use Addiks\RDMBundle\Mapping\EntityMapping;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
@@ -23,7 +22,6 @@ 
 use Doctrine\ORM\Query\Expr;
 use Doctrine\DBAL\Driver\Statement;
 use PHPUnit\Framework\TestCase;
-use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Doctrine\ORM\UnitOfWork;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 use Addiks\RDMBundle\Mapping\MappingInterface;