addiks / symfony_rdm

Tests/Mapping/Drivers/MappingPHPDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Addiks\RDMBundle\Mapping\Drivers\MappingPHPDriver;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;

Tests/Mapping/Drivers/MappingXmlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingXmlDriver;

Spacing +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
             'bar' => new ServiceMapping('other_service', false, "in file '{$mappingFilePath}'"),
             'baz' => new ChoiceMapping('baz_column', [
                 'lorem' => new ServiceMapping("lorem_service", false, "in file '{$mappingFilePath}'"),
-                'ipsum' => new ServiceMapping("ipsum_service", true,  "in file '{$mappingFilePath}'"),
+                'ipsum' => new ServiceMapping("ipsum_service", true, "in file '{$mappingFilePath}'"),
             ], "in file '{$mappingFilePath}'"),
             'faz' => new ChoiceMapping(new Column("faz_column", Type::getType('string'), ['notnull' => true]), [
                 'lorem' => new ServiceMapping("lorem_service", false, "in file '{$mappingFilePath}'"),
@@ -129,7 +129,7 @@ 
                 new CallDefinition("createValueObject", "@value_object.factory", [
                     new ChoiceMapping('baz_column', [
                         'lorem' => new ServiceMapping("lorem_service", false, "in file '{$mappingFilePath}'"),
-                        'ipsum' => new ServiceMapping("ipsum_service", true,  "in file '{$mappingFilePath}'"),
+                        'ipsum' => new ServiceMapping("ipsum_service", true, "in file '{$mappingFilePath}'"),
                     ], "in file '{$mappingFilePath}'")
                 ])
             ),

Tests/Mapping/Drivers/MappingYamlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingYamlDriver;

Tests/ValueResolver/ChoiceValueResolverTest.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
 use Addiks\RDMBundle\Mapping\ServiceMapping;
-use Addiks\RDMBundle\Mapping\MappingInterface;
 
 final class ChoiceValueResolverTest extends TestCase
 {

ValueResolver/ChoiceValueResolver.php

Indentation +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
                     $choiceMapping,
                     $entity,
                     [] # <= I'm not sure how this parameter should be handled correctly in the future,
-                       #    but with the current supported features it *should* be irrelevant.
+                        #    but with the current supported features it *should* be irrelevant.
                 );
 
                 if ($choiceValue === $valueFromEntityField) {

DependencyInjection/AddiksRDMExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }

Tests/Hydration/EntityHydratorTest.php

Unused Use Statements -5 removed lines

@@ -13,18 +13,13 @@
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Hydration\EntityHydrator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use ErrorException;
 use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Addiks\RDMBundle\Mapping\EntityMapping;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
-use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;
 use Addiks\RDMBundle\DataLoader\DataLoaderInterface;
 use Doctrine\ORM\EntityManagerInterface;
-use Addiks\RDMBundle\Mapping\EntityMappingInterface;
-use Addiks\RDMBundle\Mapping\MappingInterface;
 
 final class EntityHydratorTest extends TestCase
 {

DataLoader/SimpleSelectDataLoader.php

Doc Comments +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function loadDBALDataForEntity($entity, EntityManagerInterface $entityManager): array
     {
@@ -160,7 +160,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function storeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {
@@ -197,7 +197,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function removeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {

Tests/DataLoader/SimpleSelectDataLoaderTest.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use Doctrine\ORM\Query\Expr;
 use Doctrine\DBAL\Driver\Statement;
 use PHPUnit\Framework\TestCase;
-use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Doctrine\ORM\UnitOfWork;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 

Spacing +1 added lines, -1 removed lines

@@ -219,7 +219,7 @@
         $this->valueResolver->method("revertValue")->will($this->returnValueMap([
             [$this->mappings['foo'], $entity, "some_ipsum_service", ["foo_column" => "ipsum"]],
             [$this->mappings['bar'], $entity, "some_dolor_service", ["bar_column" => "dolor"]],
-            [$this->mappings['faz'], $entity, $fazService,          ["faz_column" => "sit"]],
+            [$this->mappings['faz'], $entity, $fazService, ["faz_column" => "sit"]],
         ]));
 
         $this->connection->expects($this->once())->method("update")->with(