EntityHydratorTest::shouldAssertHydrationUsingValueResolvers() - Code Metrics - Inspection of "more tests and fixes; raised MSI to 86%" - addiks/symfony_rdm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 63fe9e...7c1db9 )

by Gerrit

created 2018-02-18 09:12 UTC

shouldAssertHydrationUsingValueResolvers() B

↳ Parent: EntityHydratorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.9713
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	0

<?php
/**
 * Copyright (C) 2018 Gerrit Addiks.
 * This package (including this file) was released under the terms of the GPL-3.0.
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
 * @license GPL-3.0
 * @author Gerrit Addiks <[email protected]>
 */

namespace Addiks\RDMBundle\Tests\Hydration;

use PHPUnit\Framework\TestCase;
use Addiks\RDMBundle\Hydration\EntityHydrator;
use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
use Addiks\RDMBundle\Mapping\Annotation\Service;
use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
use Addiks\RDMBundle\Tests\Hydration\EntityExample;
use ErrorException;
use Addiks\RDMBundle\Mapping\ServiceMapping;
use Addiks\RDMBundle\Mapping\EntityMapping;
use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;
use Addiks\RDMBundle\DataLoader\DataLoaderInterface;
use Doctrine\ORM\EntityManagerInterface;
use Addiks\RDMBundle\Mapping\EntityMappingInterface;
use Addiks\RDMBundle\Mapping\MappingInterface;

final class EntityHydratorTest extends TestCase
{

    /**
     * @var EntityHydrator
     */
    private $hydrator;

    /**
     * @var ValueResolverInterface
     */
    private $valueResolver;

    /**
     * @var MappingDriverInterface
     */
    private $mappingDriver;

    /**
     * @var DataLoaderInterface
     */
    private $dbalDataLoader;

    public function setUp()

    {
        $this->valueResolver = $this->createMock(ValueResolverInterface::class);

        $this->mappingDriver = $this->createMock(MappingDriverInterface::class);

        $this->dbalDataLoader = $this->createMock(DataLoaderInterface::class);


        $this->hydrator = new EntityHydrator(
            $this->valueResolver,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->mappingDriver,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->dbalDataLoader
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    /**
     * @test
     */
    public function shouldHydrateAnEntityWithServices()
    {
        $fooMapping = new ServiceMapping("the_foo_service");
        $barMapping = new ServiceMapping("another_bar_service");
        $fazMapping = new ServiceMapping("a_private_property_service");

        $this->mappingDriver->method("loadRDMMetadataForClass")->willReturn(

            new EntityMapping(EntityExample::class, [
                'foo' => $fooMapping,
                'bar' => $barMapping,
                'faz' => $fazMapping
            ])
        );

        $serviceA = new ServiceExample("SomeService", 123);
        $serviceB = new ServiceExample("AnotherService", 456);
        $serviceC = new ServiceExample("PrivateService", 789);

        $entity = new EntityExample();

        $this->valueResolver->method("resolveValue")->will($this->returnValueMap([

            [$fooMapping, $entity, [], $serviceA],
            [$barMapping, $entity, [], $serviceB],
            [$fazMapping, $entity, [], $serviceC],
        ]));

        $this->hydrator->hydrateEntity($entity, $this->createMock(EntityManagerInterface::class));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertEquals($serviceA, $entity->foo);
        $this->assertEquals($serviceB, $entity->bar);
        $this->assertEquals($serviceC, $entity->getFaz());
    }

    /**
     * @test
     */
    public function shouldAssertHydrationUsingValueResolvers()
    {
        $fazMapping = new ServiceMapping("the_faz_service");

        /** @var ServiceExample $fooService */
        $fazService = $this->createMock(ServiceExample::class);

        $entity = new EntityExample(null, null, null, $fazService);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->mappingDriver->method("loadRDMMetadataForClass")->willReturn(

            new EntityMapping(EntityExample::class, [
                'faz' => $fazMapping,
            ])
        );

        $this->valueResolver->expects($this->once())->method("assertValue")->with(

            $this->equalTo($fazMapping),
            $this->equalTo($entity),
            $this->equalTo([]),
            $this->equalTo($fazService)
        );

        $this->hydrator->assertHydrationOnEntity($entity, $this->createMock(EntityManagerInterface::class));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

}


1		<?php
2		/**
3		* Copyright (C) 2018 Gerrit Addiks.
4		* This package (including this file) was released under the terms of the GPL-3.0.
5		* You should have received a copy of the GNU General Public License along with this program.
6		* If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
7		* @license GPL-3.0
8		* @author Gerrit Addiks <[email protected]>
9		*/
10
11		namespace Addiks\RDMBundle\Tests\Hydration;
12
13		use PHPUnit\Framework\TestCase;
14		use Addiks\RDMBundle\Hydration\EntityHydrator;
15		use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
16		use Addiks\RDMBundle\Mapping\Annotation\Service;
17		use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
18		use Addiks\RDMBundle\Tests\Hydration\EntityExample;
19		use ErrorException;
20		use Addiks\RDMBundle\Mapping\ServiceMapping;
21		use Addiks\RDMBundle\Mapping\EntityMapping;
22		use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
23		use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;
24		use Addiks\RDMBundle\DataLoader\DataLoaderInterface;
25		use Doctrine\ORM\EntityManagerInterface;
26		use Addiks\RDMBundle\Mapping\EntityMappingInterface;
27		use Addiks\RDMBundle\Mapping\MappingInterface;
28
29		final class EntityHydratorTest extends TestCase
30		{
31
32		/**
33		* @var EntityHydrator
34		*/
35		private $hydrator;
36
37		/**
38		* @var ValueResolverInterface
39		*/
40		private $valueResolver;
41
42		/**
43		* @var MappingDriverInterface
44		*/
45		private $mappingDriver;
46
47		/**
48		* @var DataLoaderInterface
49		*/
50		private $dbalDataLoader;
51
52	View Code Duplication	public function setUp()
		0 ignored issues – show Duplication introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$this->valueResolver = $this->createMock(ValueResolverInterface::class);
		0 ignored issues – show Documentation Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report It seems like `$this->createMock(\Addik...solverInterface::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Addiks\RDMBundle\...ValueResolverInterface>` of property `$valueResolver`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
55		$this->mappingDriver = $this->createMock(MappingDriverInterface::class);
		0 ignored issues – show Documentation Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report It seems like `$this->createMock(\Addik...DriverInterface::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Addiks\RDMBundle\...MappingDriverInterface>` of property `$mappingDriver`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
56		$this->dbalDataLoader = $this->createMock(DataLoaderInterface::class);
		0 ignored issues – show Documentation Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report It seems like `$this->createMock(\Addik...LoaderInterface::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Addiks\RDMBundle\...er\DataLoaderInterface>` of property `$dbalDataLoader`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
57
58		$this->hydrator = new EntityHydrator(
59		$this->valueResolver,
		0 ignored issues – show Documentation introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report `$this->valueResolver` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\...ValueResolverInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60		$this->mappingDriver,
		0 ignored issues – show Documentation introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report `$this->mappingDriver` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\...MappingDriverInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61		$this->dbalDataLoader
		0 ignored issues – show Documentation introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report `$this->dbalDataLoader` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\...er\DataLoaderInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62		);
63		}
64
65		/**
66		* @test
67		*/
68		public function shouldHydrateAnEntityWithServices()
69		{
70		$fooMapping = new ServiceMapping("the_foo_service");
71		$barMapping = new ServiceMapping("another_bar_service");
72		$fazMapping = new ServiceMapping("a_private_property_service");
73
74		$this->mappingDriver->method("loadRDMMetadataForClass")->willReturn(
		0 ignored issues – show Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Addiks\RDMBundle\...MappingDriverInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
75		new EntityMapping(EntityExample::class, [
76		'foo' => $fooMapping,
77		'bar' => $barMapping,
78		'faz' => $fazMapping
79		])
80		);
81
82		$serviceA = new ServiceExample("SomeService", 123);
83		$serviceB = new ServiceExample("AnotherService", 456);
84		$serviceC = new ServiceExample("PrivateService", 789);
85
86		$entity = new EntityExample();
87
88		$this->valueResolver->method("resolveValue")->will($this->returnValueMap([
		0 ignored issues – show Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Addiks\RDMBundle\...ValueResolverInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
89		[$fooMapping, $entity, [], $serviceA],
90		[$barMapping, $entity, [], $serviceB],
91		[$fazMapping, $entity, [], $serviceC],
92		]));
93
94		$this->hydrator->hydrateEntity($entity, $this->createMock(EntityManagerInterface::class));
		0 ignored issues – show Documentation introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report `$this->createMock(\Doctr...anagerInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
95
96		$this->assertEquals($serviceA, $entity->foo);
97		$this->assertEquals($serviceB, $entity->bar);
98		$this->assertEquals($serviceC, $entity->getFaz());
99		}
100
101		/**
102		* @test
103		*/
104		public function shouldAssertHydrationUsingValueResolvers()
105		{
106		$fazMapping = new ServiceMapping("the_faz_service");
107
108		/** @var ServiceExample $fooService */
109		$fazService = $this->createMock(ServiceExample::class);
110
111		$entity = new EntityExample(null, null, null, $fazService);
		0 ignored issues – show Documentation introduced 2018-02-18 09:14 UTC by Report Bug Copy Issue Report `$fazService` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Addiks\RDMBu...dration\ServiceExample>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
112
113		$this->mappingDriver->method("loadRDMMetadataForClass")->willReturn(
		0 ignored issues – show Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Addiks\RDMBundle\...MappingDriverInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
114		new EntityMapping(EntityExample::class, [
115		'faz' => $fazMapping,
116		])
117		);
118
119		$this->valueResolver->expects($this->once())->method("assertValue")->with(
		0 ignored issues – show Bug introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report The method `expects()` does not seem to exist on `object<Addiks\RDMBundle\...ValueResolverInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
120		$this->equalTo($fazMapping),
121		$this->equalTo($entity),
122		$this->equalTo([]),
123		$this->equalTo($fazService)
124		);
125
126		$this->hydrator->assertHydrationOnEntity($entity, $this->createMock(EntityManagerInterface::class));
		0 ignored issues – show Documentation introduced 2018-02-17 13:30 UTC by Report Bug Copy Issue Report `$this->createMock(\Doctr...anagerInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
127		}
128
129		}
130

addiks / symfony_rdm

Push — master ( 63fe9e...7c1db9 )

shouldAssertHydrationUsingValueResolvers() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like