ArgumentCallFactoryTest::dataProviderForShouldCreateCallArgumentFromArray() - Code Metrics - Inspection of "changed syntax for additional arguments and fixed..." - addiks/symfony_generics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 928c25...8579cb )

by Gerrit

created 2019-12-17 17:17 UTC

dataProviderForShouldCreateCallArgumentFromArray() B

↳ Parent: ArgumentCallFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	72
rs	8.6109
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Copyright (C) 2017  Gerrit Addiks.
 * This package (including this file) was released under the terms of the GPL-3.0.
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
 * @license GPL-3.0
 * @author Gerrit Addiks <[email protected]>
 */

namespace Addiks\SymfonyGenerics\Tests\Unit\Arguments\ArgumentFactory;

use PHPUnit\Framework\TestCase;
use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ArgumentCallFactory;
use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ArgumentFactory;
use InvalidArgumentException;
use Addiks\SymfonyGenerics\Arguments\ArgumentCall;
use Addiks\SymfonyGenerics\Arguments\Argument;
use Addiks\SymfonyGenerics\Services\ArgumentCompilerInterface;

final class ArgumentCallFactoryTest extends TestCase
{

    /**
     * @var ArgumentCallFactory
     */
    private $factory;

    /**
     * @var ArgumentCompilerInterface
     */
    private $argumentCompiler;

    /**
     * @var ArgumentFactory
     */
    private $argumentFactory;

    public function setUp()
    {
        $this->argumentCompiler = $this->createMock(ArgumentCompilerInterface::class);

        $this->argumentFactory = $this->createMock(ArgumentFactory::class);


        $this->factory = new ArgumentCallFactory($this->argumentCompiler, $this->argumentFactory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldKnowIfUnderstandString
     */
    public function shouldKnowIfUnderstandString(bool $expectedResult, string $source)
    {
        /** @var bool $actualResult */
        $actualResult = $this->factory->understandsString($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldKnowIfUnderstandString()
    {
        return array(
            [true, 'a::b'],
            [true, 'foo::bar'],
            [true, 'foo::bar(baz)'],
            [false, '::b'],
            [false, 'a::'],
            [false, '::'],
            [false, ''],
        );
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldKnowIfUnderstandArray
     */
    public function shouldKnowIfUnderstandArray(bool $expectedResult, array $source)
    {
        /** @var bool $actualResult */
        $actualResult = $this->factory->understandsArray($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldKnowIfUnderstandArray()
    {
        return array(
            [true,  ['callee' => 'foo', 'method' => 'bar']],
            [true,  ['callee' => 'foo', 'method' => 'bar', 'arguments' => []]],
            [false, ['method' => 'bar']],
            [false, ['callee' => 'foo']],
        );
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldCreateCallArgumentFromString
     */
    public function shouldCreateCallArgumentFromString(
        ?ArgumentCall $expectedResult,
        string $source,
        bool $shouldRejectCreation
    ) {
        if ($shouldRejectCreation) {
            $this->expectException(InvalidArgumentException::class);

        } else {
            $this->argumentFactory->method('createArgumentFromString')->willReturn($this->createMock(Argument::class));

        }

        $actualResult = $this->factory->createArgumentFromString($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldCreateCallArgumentFromString(): array
    {
        return array(
            [
                new ArgumentCall(
                    $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'someMethod',
                    []
                ),
                'some-callee::someMethod',
                false
            ],
            [
                new ArgumentCall(
                    $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'someMethod',
                    [
                        $this->createMock(Argument::class),
                        $this->createMock(Argument::class)
                    ]
                ),
                'some-callee::someMethod(a, b)',
                false
            ],
            [null, 'a::', true],
            [null, '::b', true],
            [null, '::', true],
        );
    }

    /**
     * @test
     */
    public function shouldCreateArgumentsFromArgumentsInString()
    {
        $this->argumentFactory->expects($this->exactly(3))->method('createArgumentFromString')->withConsecutive(

            [$this->equalTo('a')],
            [$this->equalTo('b')],
            [$this->equalTo('some-callee')]
        )->willReturn($this->createMock(Argument::class));
        $this->factory->createArgumentFromString('some-callee::someMethod(a, b)');
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldCreateCallArgumentFromArray
     */
    public function shouldCreateCallArgumentFromArray(
        $expectedResult,
        array $source,
        bool $shouldRejectCreation
    ) {
        if ($shouldRejectCreation) {
            $this->expectException(InvalidArgumentException::class);

        } else {
            $this->argumentFactory->method('createArgumentFromString')->willReturn($this->createMock(Argument::class));

            $this->argumentFactory->method('createArgumentFromArray')->willReturn($this->createMock(Argument::class));

        }

        $actualResult = $this->factory->createArgumentFromArray($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldCreateCallArgumentFromArray(): array
    {
        return array(
            [null, [], true],
            [null, ['method' => 'foo'], true],
            [null, ['callee' => 'bar'], true],
            [new ArgumentCall(
                $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'someMethod',
                []
            ), [
                'callee' => 'some-callee',
                'method' => 'someMethod'
            ], false],
            [new ArgumentCall(
                $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'someMethod',
                []
            ), [
                'callee' => ['some-callee'],
                'method' => 'someMethod'
            ], false],
            [new ArgumentCall(
                $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'someMethod',
                [
                    $this->createMock(Argument::class),
                    $this->createMock(Argument::class)
                ]
            ), [
                'callee' => 'some-callee',
                'method' => 'someMethod',
                'arguments' => [
                    'foo',
                    'bar'
                ]
            ], false],
            [new ArgumentCall(
                $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'someMethod', [
                    $this->createMock(Argument::class),
                    $this->createMock(Argument::class)
                ]
            ), [
                'callee' => ['some-callee'],
                'method' => 'someMethod',
                'arguments' => [
                    'foo',
                    'bar'
                ]
            ], false],
            [new ArgumentCall(
                $this->createMock(ArgumentCompilerInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->createMock(Argument::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'someMethod', [
                    $this->createMock(Argument::class),
                    $this->createMock(Argument::class)
                ]
            ), [
                'callee' => 'some-callee',
                'method' => 'someMethod',
                'arguments' => [
                    ['foo'],
                    ['bar']
                ]
            ], false],
        );
    }

}


1			<?php
2			/**
3			* Copyright (C) 2017 Gerrit Addiks.
4			* This package (including this file) was released under the terms of the GPL-3.0.
5			* You should have received a copy of the GNU General Public License along with this program.
6			* If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
7			* @license GPL-3.0
8			* @author Gerrit Addiks <[email protected]>
9			*/
10
11			namespace Addiks\SymfonyGenerics\Tests\Unit\Arguments\ArgumentFactory;
12
13			use PHPUnit\Framework\TestCase;
14			use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ArgumentCallFactory;
15			use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ArgumentFactory;
16			use InvalidArgumentException;
17			use Addiks\SymfonyGenerics\Arguments\ArgumentCall;
18			use Addiks\SymfonyGenerics\Arguments\Argument;
19			use Addiks\SymfonyGenerics\Services\ArgumentCompilerInterface;
20
21			final class ArgumentCallFactoryTest extends TestCase
22			{
23
24			/**
25			* @var ArgumentCallFactory
26			*/
27			private $factory;
28
29			/**
30			* @var ArgumentCompilerInterface
31			*/
32			private $argumentCompiler;
33
34			/**
35			* @var ArgumentFactory
36			*/
37			private $argumentFactory;
38
39			public function setUp()
40			{

addiks / symfony_generics

Push — master ( 928c25...8579cb )

dataProviderForShouldCreateCallArgumentFromArray() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like