ServiceArgumentFactoryTest::shouldKnowIfUnderstandString() - Code Metrics - Inspection of "new arguments structure is now fully unit tested" - addiks/symfony_generics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 918acc...2e1e94 )

by Gerrit

created 2019-05-13 19:42 UTC

shouldKnowIfUnderstandString() A

↳ Parent: ServiceArgumentFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php
/**
 * Copyright (C) 2017  Gerrit Addiks.
 * This package (including this file) was released under the terms of the GPL-3.0.
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
 * @license GPL-3.0
 * @author Gerrit Addiks <[email protected]>
 */

namespace Addiks\SymfonyGenerics\Arguments\ArgumentFactory;

use PHPUnit\Framework\TestCase;
use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ServiceArgumentFactory;
use Psr\Container\ContainerInterface;
use InvalidArgumentException;
use Addiks\SymfonyGenerics\Arguments\ServiceArgument;
use Addiks\SymfonyGenerics\Arguments\LiteralArgument;

final class ServiceArgumentFactoryTest extends TestCase
{

    /**
     * @var ServiceArgumentFactory
     */
    private $factory;

    /**
     * @var ContainerInterface
     */
    private $container;

    public function setUp()
    {
        $this->container = $this->createMock(ContainerInterface::class);


        $this->factory = new ServiceArgumentFactory($this->container);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldKnowIfUnderstandString
     */
    public function shouldKnowIfUnderstandString(bool $expectedResult, string $source)
    {
        /** @var bool $actualResult */
        $actualResult = $this->factory->understandsString($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldKnowIfUnderstandString()
    {
        return array(
            [true, "@foo"],
            [true, "@f"],
            [false, "@"],
            [false, "foo"],
        );
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldKnowIfUnderstandArray
     */
    public function shouldKnowIfUnderstandArray(bool $expectedResult, array $source)
    {
        /** @var bool $actualResult */
        $actualResult = $this->factory->understandsArray($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldKnowIfUnderstandArray()
    {
        return array(
            [true, ["service-id" => 'foo']],
            [false, ["foo"]],
            [false, ["service-id" => null]],
        );
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldCreateArgumentFromString
     */
    public function shouldCreateArgumentFromString($expectedResult, string $source, bool $expectException)
    {
        if ($expectException) {
            $this->expectException(InvalidArgumentException::class);
        }

        /** @var bool $actualResult */
        $actualResult = $this->factory->createArgumentFromString($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldCreateArgumentFromString()
    {
        $this->setUp();

        return array(
            [new ServiceArgument($this->container, new LiteralArgument('foo')), "@foo", false],
            [new ServiceArgument($this->container, new LiteralArgument('f')), "@f", false],
            [null, "@", true],
        );
    }

    /**
     * @test
     * @dataProvider dataProviderForShouldCreateArgumentFromArray
     */
    public function shouldCreateArgumentFromArray($expectedResult, array $source, bool $expectException)
    {
        if ($expectException) {
            $this->expectException(InvalidArgumentException::class);
        }

        /** @var bool $actualResult */
        $actualResult = $this->factory->createArgumentFromArray($source);

        $this->assertEquals($expectedResult, $actualResult);
    }

    public function dataProviderForShouldCreateArgumentFromArray()
    {
        $this->setUp();

        return array(
            [new ServiceArgument($this->container, new LiteralArgument('foo')), ["service-id" => 'foo'], false],
            [new ServiceArgument($this->container, new LiteralArgument('f')), ["service-id" => 'f'], false],
            [null, ["service-id" => null], true],
            [null, ["service-id"], true],
        );
    }

}


1			<?php
2			/**
3			* Copyright (C) 2017 Gerrit Addiks.
4			* This package (including this file) was released under the terms of the GPL-3.0.
5			* You should have received a copy of the GNU General Public License along with this program.
6			* If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
7			* @license GPL-3.0
8			* @author Gerrit Addiks <[email protected]>
9			*/
10
11			namespace Addiks\SymfonyGenerics\Arguments\ArgumentFactory;
12
13			use PHPUnit\Framework\TestCase;
14			use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ServiceArgumentFactory;
15			use Psr\Container\ContainerInterface;
16			use InvalidArgumentException;
17			use Addiks\SymfonyGenerics\Arguments\ServiceArgument;
18			use Addiks\SymfonyGenerics\Arguments\LiteralArgument;
19
20			final class ServiceArgumentFactoryTest extends TestCase
21			{
22
23			/**
24			* @var ServiceArgumentFactory
25			*/
26			private $factory;
27
28			/**
29			* @var ContainerInterface
30			*/
31			private $container;
32
33			public function setUp()
34			{
35			$this->container = $this->createMock(ContainerInterface::class);
			0 ignored issues – show Documentation Bug introduced 2019-05-13 19:44 UTC by Report Bug Copy Issue Report It seems like `$this->createMock(\Psr\C...tainerInterface::class)` of type `object<PHPUnit\Framework\MockObject\MockObject>` is incompatible with the declared type `object<Psr\Container\ContainerInterface>` of property `$container`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
36
37			$this->factory = new ServiceArgumentFactory($this->container);
			0 ignored issues – show Documentation introduced 2019-05-13 19:44 UTC by Report Bug Copy Issue Report `$this->container` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Container\ContainerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38			}
39
40			/**
41			* @test
42			* @dataProvider dataProviderForShouldKnowIfUnderstandString
43			*/
44			public function shouldKnowIfUnderstandString(bool $expectedResult, string $source)
45			{
46			/** @var bool $actualResult */
47			$actualResult = $this->factory->understandsString($source);
48
49			$this->assertEquals($expectedResult, $actualResult);
50			}
51
52			public function dataProviderForShouldKnowIfUnderstandString()
53			{
54			return array(
55			[true, "@foo"],
56			[true, "@f"],
57			[false, "@"],
58			[false, "foo"],
59			);
60			}
61
62			/**
63			* @test
64			* @dataProvider dataProviderForShouldKnowIfUnderstandArray
65			*/
66			public function shouldKnowIfUnderstandArray(bool $expectedResult, array $source)
67			{
68			/** @var bool $actualResult */
69			$actualResult = $this->factory->understandsArray($source);
70
71			$this->assertEquals($expectedResult, $actualResult);
72			}
73
74			public function dataProviderForShouldKnowIfUnderstandArray()
75			{
76			return array(
77			[true, ["service-id" => 'foo']],
78			[false, ["foo"]],
79			[false, ["service-id" => null]],
80			);
81			}
82
83			/**
84			* @test
85			* @dataProvider dataProviderForShouldCreateArgumentFromString
86			*/
87			public function shouldCreateArgumentFromString($expectedResult, string $source, bool $expectException)
88			{
89			if ($expectException) {
90			$this->expectException(InvalidArgumentException::class);
91			}
92
93			/** @var bool $actualResult */
94			$actualResult = $this->factory->createArgumentFromString($source);
95
96			$this->assertEquals($expectedResult, $actualResult);
97			}
98
99			public function dataProviderForShouldCreateArgumentFromString()
100			{
101			$this->setUp();
102
103			return array(
104			[new ServiceArgument($this->container, new LiteralArgument('foo')), "@foo", false],
105			[new ServiceArgument($this->container, new LiteralArgument('f')), "@f", false],
106			[null, "@", true],
107			);
108			}
109
110			/**
111			* @test
112			* @dataProvider dataProviderForShouldCreateArgumentFromArray
113			*/
114			public function shouldCreateArgumentFromArray($expectedResult, array $source, bool $expectException)
115			{
116			if ($expectException) {
117			$this->expectException(InvalidArgumentException::class);
118			}
119
120			/** @var bool $actualResult */
121			$actualResult = $this->factory->createArgumentFromArray($source);
122
123			$this->assertEquals($expectedResult, $actualResult);
124			}
125
126			public function dataProviderForShouldCreateArgumentFromArray()
127			{
128			$this->setUp();
129
130			return array(
131			[new ServiceArgument($this->container, new LiteralArgument('foo')), ["service-id" => 'foo'], false],
132			[new ServiceArgument($this->container, new LiteralArgument('f')), ["service-id" => 'f'], false],
133			[null, ["service-id" => null], true],
134			[null, ["service-id"], true],
135			);
136			}
137
138			}
139

addiks / symfony_generics

Push — master ( 918acc...2e1e94 )

shouldKnowIfUnderstandString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like