1
|
|
|
<?php |
2
|
|
|
/** |
3
|
|
|
* Copyright (C) 2017 Gerrit Addiks. |
4
|
|
|
* This package (including this file) was released under the terms of the GPL-3.0. |
5
|
|
|
* You should have received a copy of the GNU General Public License along with this program. |
6
|
|
|
* If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy. |
7
|
|
|
* @license GPL-3.0 |
8
|
|
|
* @author Gerrit Addiks <[email protected]> |
9
|
|
|
*/ |
10
|
|
|
|
11
|
|
|
namespace Addiks\SymfonyGenerics\Tests\Unit\Controllers; |
12
|
|
|
|
13
|
|
|
use PHPUnit\Framework\TestCase; |
14
|
|
|
use Addiks\SymfonyGenerics\Controllers\GenericExceptionResponseController; |
15
|
|
|
use Addiks\SymfonyGenerics\Controllers\ControllerHelperInterface; |
16
|
|
|
use Serializable; |
17
|
|
|
use Symfony\Component\HttpFoundation\Response; |
18
|
|
|
use InvalidArgumentException; |
19
|
|
|
use DivisionByZeroError; |
20
|
|
|
use Addiks\SymfonyGenerics\Services\ArgumentCompilerInterface; |
21
|
|
|
use Symfony\Component\HttpFoundation\Request; |
22
|
|
|
use Symfony\Component\HttpFoundation\RedirectResponse; |
23
|
|
|
|
24
|
|
|
final class GenericExceptionResponseControllerTest extends TestCase |
25
|
|
|
{ |
26
|
|
|
|
27
|
|
|
/** |
28
|
|
|
* @var GenericExceptionResponseController |
29
|
|
|
*/ |
30
|
|
|
private $controller; |
31
|
|
|
|
32
|
|
|
/** |
33
|
|
|
* @var ControllerHelperInterface |
34
|
|
|
*/ |
35
|
|
|
private $controllerHelper; |
36
|
|
|
|
37
|
|
|
/** |
38
|
|
|
* @var Serializable |
39
|
|
|
*/ |
40
|
|
|
private $innerController; |
41
|
|
|
|
42
|
|
|
/** |
43
|
|
|
* @var ArgumentCompilerInterface |
44
|
|
|
*/ |
45
|
|
|
private $argumentBuilder; |
46
|
|
|
|
47
|
|
|
public function setUp() |
48
|
|
|
{ |
49
|
|
|
$this->controllerHelper = $this->createMock(ControllerHelperInterface::class); |
|
|
|
|
50
|
|
|
$this->innerController = $this->createMock(Serializable::class); |
|
|
|
|
51
|
|
|
$this->argumentBuilder = $this->createMock(ArgumentCompilerInterface::class); |
|
|
|
|
52
|
|
|
} |
53
|
|
|
|
54
|
|
|
/** |
55
|
|
|
* @test |
56
|
|
|
*/ |
57
|
|
|
public function shouldexecuteInnerControllerSafely() |
58
|
|
|
{ |
59
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
60
|
|
|
'inner-controller' => $this->innerController, |
61
|
|
|
'inner-controller-method' => "serialize", |
62
|
|
|
]); |
63
|
|
|
|
64
|
|
|
$this->innerController->method("serialize")->willReturn(new Response("foo", 205)); |
65
|
|
|
|
66
|
|
|
/** @var Request $request */ |
67
|
|
|
$request = $this->createMock(Request::class); |
68
|
|
|
|
69
|
|
|
/** @var Response $response */ |
70
|
|
|
$response = $controller->executeInnerControllerSafely($request); |
71
|
|
|
|
72
|
|
|
$this->assertEquals("foo", $response->getContent()); |
73
|
|
|
$this->assertEquals(205, $response->getStatusCode()); |
74
|
|
|
} |
75
|
|
|
|
76
|
|
|
/** |
77
|
|
|
* @test |
78
|
|
|
*/ |
79
|
|
View Code Duplication |
public function shouldOverrideSuccessResponse() |
|
|
|
|
80
|
|
|
{ |
81
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
82
|
|
|
'inner-controller' => $this->innerController, |
83
|
|
|
'inner-controller-method' => "serialize", |
84
|
|
|
'success-response' => "Some success!", |
85
|
|
|
'success-response-code' => 234, |
86
|
|
|
]); |
87
|
|
|
|
88
|
|
|
$this->innerController->method("serialize")->willReturn(new Response("foo", 205)); |
89
|
|
|
|
90
|
|
|
/** @var Request $request */ |
91
|
|
|
$request = $this->createMock(Request::class); |
92
|
|
|
|
93
|
|
|
/** @var Response $response */ |
94
|
|
|
$response = $controller->executeInnerControllerSafely($request); |
95
|
|
|
|
96
|
|
|
$this->assertEquals("Some success!", $response->getContent()); |
97
|
|
|
$this->assertEquals(234, $response->getStatusCode()); |
98
|
|
|
} |
99
|
|
|
|
100
|
|
|
/** |
101
|
|
|
* @test |
102
|
|
|
*/ |
103
|
|
View Code Duplication |
public function shouldOverrideSuccessResponseWithDefaultResponseCode() |
|
|
|
|
104
|
|
|
{ |
105
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
106
|
|
|
'inner-controller' => $this->innerController, |
107
|
|
|
'inner-controller-method' => "serialize", |
108
|
|
|
'success-response' => "Some success!", |
109
|
|
|
]); |
110
|
|
|
|
111
|
|
|
$this->innerController->method("serialize")->willReturn(new Response("foo", 205)); |
112
|
|
|
|
113
|
|
|
/** @var Request $request */ |
114
|
|
|
$request = $this->createMock(Request::class); |
115
|
|
|
|
116
|
|
|
/** @var Response $response */ |
117
|
|
|
$response = $controller->executeInnerControllerSafely($request); |
118
|
|
|
|
119
|
|
|
$this->assertEquals("Some success!", $response->getContent()); |
120
|
|
|
$this->assertEquals(200, $response->getStatusCode()); |
121
|
|
|
} |
122
|
|
|
|
123
|
|
|
/** |
124
|
|
|
* @test |
125
|
|
|
*/ |
126
|
|
|
public function shouldTriggerSuccessFlashMessage() |
127
|
|
|
{ |
128
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
129
|
|
|
'inner-controller' => $this->innerController, |
130
|
|
|
'inner-controller-method' => "serialize", |
131
|
|
|
'success-flash-message' => 'Some Success Message!' |
132
|
|
|
]); |
133
|
|
|
|
134
|
|
|
$this->controllerHelper->expects($this->once())->method('addFlashMessage')->with( |
|
|
|
|
135
|
|
|
$this->equalTo('Some Success Message!'), |
136
|
|
|
$this->equalTo('success') |
137
|
|
|
); |
138
|
|
|
|
139
|
|
|
$this->innerController->method("serialize")->willReturn(new Response("foo", 200)); |
140
|
|
|
|
141
|
|
|
/** @var Request $request */ |
142
|
|
|
$request = $this->createMock(Request::class); |
143
|
|
|
|
144
|
|
|
$controller->executeInnerControllerSafely($request); |
145
|
|
|
} |
146
|
|
|
|
147
|
|
|
/** |
148
|
|
|
* @test |
149
|
|
|
*/ |
150
|
|
|
public function shouldAddFlashMessageUponException() |
151
|
|
|
{ |
152
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
153
|
|
|
'inner-controller' => $this->innerController, |
154
|
|
|
'inner-controller-method' => "serialize", |
155
|
|
|
'exception-responses' => [ |
156
|
|
|
InvalidArgumentException::class => [ |
157
|
|
|
'flash-type' => 'danger', |
158
|
|
|
'flash-message' => 'Something happened: %s' |
159
|
|
|
] |
160
|
|
|
] |
161
|
|
|
]); |
162
|
|
|
|
163
|
|
|
$this->innerController->method("serialize")->will($this->returnCallback( |
164
|
|
|
function () { |
165
|
|
|
throw new InvalidArgumentException("Lorem ipsum!"); |
166
|
|
|
} |
167
|
|
|
)); |
168
|
|
|
|
169
|
|
|
$this->controllerHelper->expects($this->once())->method('handleException'); |
|
|
|
|
170
|
|
|
$this->controllerHelper->expects($this->once())->method('addFlashMessage')->with( |
|
|
|
|
171
|
|
|
$this->equalTo('Something happened: Lorem ipsum!'), |
172
|
|
|
$this->equalTo('danger') |
173
|
|
|
); |
174
|
|
|
|
175
|
|
|
/** @var Request $request */ |
176
|
|
|
$request = $this->createMock(Request::class); |
177
|
|
|
|
178
|
|
|
/** @var Response $response */ |
179
|
|
|
$response = $controller->executeInnerControllerSafely($request); |
180
|
|
|
|
181
|
|
|
$this->assertEquals("Lorem ipsum!", $response->getContent()); |
182
|
|
|
$this->assertEquals(500, $response->getStatusCode()); |
183
|
|
|
} |
184
|
|
|
|
185
|
|
|
/** |
186
|
|
|
* @test |
187
|
|
|
*/ |
188
|
|
|
public function shouldForwardThrowExceptionIfNotHandled() |
189
|
|
|
{ |
190
|
|
|
/** @var mixed $controller */ |
191
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
192
|
|
|
'inner-controller' => $this->innerController, |
193
|
|
|
'inner-controller-method' => "serialize", |
194
|
|
|
]); |
195
|
|
|
|
196
|
|
|
$this->innerController->method("serialize")->will($this->returnCallback( |
197
|
|
|
function () { |
198
|
|
|
throw new InvalidArgumentException("Lorem ipsum!"); |
199
|
|
|
} |
200
|
|
|
)); |
201
|
|
|
|
202
|
|
|
$this->expectException(InvalidArgumentException::class); |
203
|
|
|
|
204
|
|
|
/** @var Request $request */ |
205
|
|
|
$request = $this->createMock(Request::class); |
206
|
|
|
|
207
|
|
|
$controller->executeInnerControllerSafely($request); |
208
|
|
|
} |
209
|
|
|
|
210
|
|
|
/** |
211
|
|
|
* @test |
212
|
|
|
*/ |
213
|
|
|
public function shouldThrowExceptionIfInnerControllerDidNotReturnAResponse() |
214
|
|
|
{ |
215
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
216
|
|
|
'inner-controller' => $this->innerController, |
217
|
|
|
'inner-controller-method' => "serialize", |
218
|
|
|
]); |
219
|
|
|
|
220
|
|
|
$this->expectException(InvalidArgumentException::class); |
221
|
|
|
|
222
|
|
|
/** @var Request $request */ |
223
|
|
|
$request = $this->createMock(Request::class); |
224
|
|
|
|
225
|
|
|
$controller->executeInnerControllerSafely($request); |
226
|
|
|
} |
227
|
|
|
|
228
|
|
|
/** |
229
|
|
|
* @test |
230
|
|
|
*/ |
231
|
|
|
public function shouldThrowExceptionIfHandledExceptionClassIsNotException() |
232
|
|
|
{ |
233
|
|
|
$this->expectException(InvalidArgumentException::class); |
234
|
|
|
|
235
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
|
|
|
|
236
|
|
|
'inner-controller' => $this->innerController, |
237
|
|
|
'inner-controller-method' => "serialize", |
238
|
|
|
'exception-responses' => [ |
239
|
|
|
"TotallyNotAnException" => [ |
240
|
|
|
'flash-type' => 'danger', |
241
|
|
|
'flash-message' => 'Something happened: %s' |
242
|
|
|
] |
243
|
|
|
] |
244
|
|
|
]); |
245
|
|
|
} |
246
|
|
|
|
247
|
|
|
/** |
248
|
|
|
* @test |
249
|
|
|
*/ |
250
|
|
|
public function shouldNotHandleThrowables() |
251
|
|
|
{ |
252
|
|
|
$this->expectException(DivisionByZeroError::class); |
253
|
|
|
|
254
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
255
|
|
|
'inner-controller' => $this->innerController, |
256
|
|
|
'inner-controller-method' => "serialize", |
257
|
|
|
'exception-responses' => [ |
258
|
|
|
DivisionByZeroError::class => [ |
259
|
|
|
'flash-type' => 'danger', |
260
|
|
|
'flash-message' => 'Something happened: %s' |
261
|
|
|
] |
262
|
|
|
] |
263
|
|
|
]); |
264
|
|
|
|
265
|
|
|
$this->innerController->method("serialize")->will($this->returnCallback( |
266
|
|
|
function () { |
267
|
|
|
throw new DivisionByZeroError("Lorem ipsum"); |
|
|
|
|
268
|
|
|
} |
269
|
|
|
)); |
270
|
|
|
|
271
|
|
|
/** @var Request $request */ |
272
|
|
|
$request = $this->createMock(Request::class); |
273
|
|
|
|
274
|
|
|
/** @var Response $response */ |
275
|
|
|
$response = $controller->executeInnerControllerSafely($request); |
276
|
|
|
|
277
|
|
|
$this->assertEquals("Lorem ipsum", $response->getContent()); |
278
|
|
|
} |
279
|
|
|
|
280
|
|
|
/** |
281
|
|
|
* @test |
282
|
|
|
*/ |
283
|
|
View Code Duplication |
public function shouldRejectNonObjectInnerController() |
|
|
|
|
284
|
|
|
{ |
285
|
|
|
$this->expectException(InvalidArgumentException::class); |
286
|
|
|
|
287
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
|
|
|
|
288
|
|
|
'inner-controller' => false, |
289
|
|
|
'inner-controller-method' => "serialize", |
290
|
|
|
]); |
291
|
|
|
} |
292
|
|
|
|
293
|
|
|
/** |
294
|
|
|
* @test |
295
|
|
|
*/ |
296
|
|
View Code Duplication |
public function shouldRejectControllerBeingCalledAgain() |
|
|
|
|
297
|
|
|
{ |
298
|
|
|
$this->expectException(InvalidArgumentException::class); |
299
|
|
|
|
300
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
301
|
|
|
'inner-controller' => $this->innerController, |
302
|
|
|
'inner-controller-method' => "serialize", |
303
|
|
|
]); |
304
|
|
|
|
305
|
|
|
$controller->__construct($this->controllerHelper, $this->argumentBuilder, [ |
306
|
|
|
'inner-controller' => $this->innerController, |
307
|
|
|
'inner-controller-method' => "serialize", |
308
|
|
|
]); |
309
|
|
|
} |
310
|
|
|
|
311
|
|
|
/** |
312
|
|
|
* @test |
313
|
|
|
*/ |
314
|
|
View Code Duplication |
public function shouldRejectNonArrayGivenAsInnerControllerArguments() |
|
|
|
|
315
|
|
|
{ |
316
|
|
|
$this->expectException(InvalidArgumentException::class); |
317
|
|
|
|
318
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
|
|
|
|
319
|
|
|
'inner-controller' => $this->innerController, |
320
|
|
|
'inner-controller-method' => "serialize", |
321
|
|
|
'arguments' => "Lorem ipsum", |
322
|
|
|
]); |
323
|
|
|
} |
324
|
|
|
|
325
|
|
|
/** |
326
|
|
|
* @test |
327
|
|
|
*/ |
328
|
|
View Code Duplication |
public function shouldRedirectFromException() |
|
|
|
|
329
|
|
|
{ |
330
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
331
|
|
|
'inner-controller' => $this->innerController, |
332
|
|
|
'inner-controller-method' => "serialize", |
333
|
|
|
'exception-responses' => [ |
334
|
|
|
InvalidArgumentException::class => [ |
335
|
|
|
'redirect-route' => 'some_redirect_route', |
336
|
|
|
'redirect-route-parameters' => [ |
337
|
|
|
'foo' => 'bar' |
338
|
|
|
] |
339
|
|
|
] |
340
|
|
|
] |
341
|
|
|
]); |
342
|
|
|
|
343
|
|
|
$this->innerController->method("serialize")->will($this->returnCallback( |
344
|
|
|
function () { |
345
|
|
|
throw new InvalidArgumentException("Lorem ipsum!"); |
346
|
|
|
} |
347
|
|
|
)); |
348
|
|
|
|
349
|
|
|
/** @var RedirectResponse $redirectResponse */ |
350
|
|
|
$redirectResponse = $this->createMock(RedirectResponse::class); |
351
|
|
|
|
352
|
|
|
$this->controllerHelper->expects($this->once())->method('handleException'); |
|
|
|
|
353
|
|
|
$this->controllerHelper->expects($this->once())->method('redirectToRoute')->with( |
|
|
|
|
354
|
|
|
$this->equalTo('some_redirect_route'), |
355
|
|
|
$this->equalTo([]), |
356
|
|
|
$this->equalTo(301) |
357
|
|
|
)->willReturn($redirectResponse); |
358
|
|
|
|
359
|
|
|
/** @var Request $request */ |
360
|
|
|
$request = $this->createMock(Request::class); |
361
|
|
|
|
362
|
|
|
/** @var Response $response */ |
363
|
|
|
$response = $controller->executeInnerControllerSafely($request); |
364
|
|
|
|
365
|
|
|
$this->assertSame($redirectResponse, $response); |
366
|
|
|
} |
367
|
|
|
|
368
|
|
|
/** |
369
|
|
|
* @test |
370
|
|
|
*/ |
371
|
|
View Code Duplication |
public function shouldBeCallableByInvokingController() |
|
|
|
|
372
|
|
|
{ |
373
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
374
|
|
|
'inner-controller' => $this->innerController, |
375
|
|
|
'inner-controller-method' => "serialize", |
376
|
|
|
'exception-responses' => [ |
377
|
|
|
InvalidArgumentException::class => [ |
378
|
|
|
'redirect-route' => 'some_redirect_route', |
379
|
|
|
'redirect-route-parameters' => [ |
380
|
|
|
'foo' => 'bar' |
381
|
|
|
] |
382
|
|
|
] |
383
|
|
|
] |
384
|
|
|
]); |
385
|
|
|
|
386
|
|
|
$this->innerController->method("serialize")->will($this->returnCallback( |
387
|
|
|
function () { |
388
|
|
|
throw new InvalidArgumentException("Lorem ipsum!"); |
389
|
|
|
} |
390
|
|
|
)); |
391
|
|
|
|
392
|
|
|
/** @var RedirectResponse $redirectResponse */ |
393
|
|
|
$redirectResponse = $this->createMock(RedirectResponse::class); |
394
|
|
|
|
395
|
|
|
$this->controllerHelper->expects($this->once())->method('handleException'); |
|
|
|
|
396
|
|
|
$this->controllerHelper->expects($this->once())->method('redirectToRoute')->with( |
|
|
|
|
397
|
|
|
$this->equalTo('some_redirect_route'), |
398
|
|
|
$this->equalTo([]), |
399
|
|
|
$this->equalTo(301) |
400
|
|
|
)->willReturn($redirectResponse); |
401
|
|
|
|
402
|
|
|
/** @var Request $request */ |
403
|
|
|
$request = $this->createMock(Request::class); |
404
|
|
|
|
405
|
|
|
$this->controllerHelper->method('getCurrentRequest')->willReturn($request); |
|
|
|
|
406
|
|
|
|
407
|
|
|
/** @var Response $response */ |
408
|
|
|
$response = $controller(); |
409
|
|
|
|
410
|
|
|
$this->assertSame($redirectResponse, $response); |
411
|
|
|
} |
412
|
|
|
|
413
|
|
|
/** |
414
|
|
|
* @test |
415
|
|
|
*/ |
416
|
|
|
public function shouldRejectCallWithoutRequest() |
417
|
|
|
{ |
418
|
|
|
$this->expectException(InvalidArgumentException::class); |
419
|
|
|
|
420
|
|
|
$controller = new GenericExceptionResponseController($this->controllerHelper, $this->argumentBuilder, [ |
421
|
|
|
'inner-controller' => $this->innerController, |
422
|
|
|
'inner-controller-method' => "serialize", |
423
|
|
|
]); |
424
|
|
|
|
425
|
|
|
$this->controllerHelper->method('getCurrentRequest')->willReturn(null); |
|
|
|
|
426
|
|
|
|
427
|
|
|
$controller(); |
428
|
|
|
} |
429
|
|
|
|
430
|
|
|
} |
431
|
|
|
|
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..