RequestFileArgumentFactory - Code Metrics - Inspection of "improved tests yet again" - addiks/symfony_generics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8e04a1...918acc )

by Gerrit

created 2019-05-12 16:42 UTC

RequestFileArgumentFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	2
dl	0
loc	53
ccs	20
cts	20
cp	1
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	understandsString()	4	2
A	understandsArray()	4	3
A	createArgumentFromString()	14	2
A	createArgumentFromArray()	13	2

<?php
/**
 * Copyright (C) 2018 Gerrit Addiks.
 * This package (including this file) was released under the terms of the GPL-3.0.
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
 *
 * @license GPL-3.0
 *
 * @author Gerrit Addiks <[email protected]>
 */

namespace Addiks\SymfonyGenerics\Arguments\ArgumentFactory;

use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ArgumentFactory;
use Addiks\SymfonyGenerics\Arguments\Argument;
use Addiks\SymfonyGenerics\Arguments\RequestFileArgument;
use Symfony\Component\HttpFoundation\RequestStack;
use Webmozart\Assert\Assert;

final class RequestFileArgumentFactory implements ArgumentFactory
{

    /**
     * @var RequestStack
     */
    private $requestStack;

    public function __construct(RequestStack $requestStack)
    {
        $this->requestStack = $requestStack;
    }

    public function understandsString(string $source): bool
    {
        return strpos($source, '$files.') === 0 && strlen($source) > 7;
    }

    public function understandsArray(array $source): bool
    {
        return isset($source['key']) && isset($source['type']) && $source['type'] === 'request-file';
    }

    public function createArgumentFromString(string $source): Argument
    {
        Assert::startsWith($source, '$files.');

        if (substr_count($source, '.') > 1) {
            [, $key, $property] = explode(".", $source);
function someFunction() {
    $x = 5;
    echo $x;
}

        } else {
            $property = 'content';
            [, $key] = explode(".", $source);
        }

        return new RequestFileArgument($this->requestStack, $key, $property);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function createArgumentFromArray(array $source): Argument
    {
        Assert::keyExists($source, 'key');

        /** @var string $property */
        $property = 'content';

        if (isset($source['property'])) {
            $property = $source['property'];
        }

        return new RequestFileArgument($this->requestStack, $source['key'], $property);
    }

}


1		<?php
2		/**
3		* Copyright (C) 2018 Gerrit Addiks.
4		* This package (including this file) was released under the terms of the GPL-3.0.
5		* You should have received a copy of the GNU General Public License along with this program.
6		* If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
7		*
8		* @license GPL-3.0
9		*
10		* @author Gerrit Addiks <[email protected]>
11		*/
12
13		namespace Addiks\SymfonyGenerics\Arguments\ArgumentFactory;
14
15		use Addiks\SymfonyGenerics\Arguments\ArgumentFactory\ArgumentFactory;
16		use Addiks\SymfonyGenerics\Arguments\Argument;
17		use Addiks\SymfonyGenerics\Arguments\RequestFileArgument;
18		use Symfony\Component\HttpFoundation\RequestStack;
19		use Webmozart\Assert\Assert;
20
21		final class RequestFileArgumentFactory implements ArgumentFactory
22		{
23
24		/**
25		* @var RequestStack
26		*/
27		private $requestStack;
28
29	25	public function __construct(RequestStack $requestStack)
30		{
31	25	$this->requestStack = $requestStack;
32	25	}
33
34	6	public function understandsString(string $source): bool
35		{
36	6	return strpos($source, '$files.') === 0 && strlen($source) > 7;
37		}
38
39	7	public function understandsArray(array $source): bool
40		{
41	7	return isset($source['key']) && isset($source['type']) && $source['type'] === 'request-file';
42		}
43
44	6	public function createArgumentFromString(string $source): Argument
45		{
46	6	Assert::startsWith($source, '$files.');
47
48	4	if (substr_count($source, '.') > 1) {
49	2	[, $key, $property] = explode(".", $source);
		0 ignored issues – show Bug introduced 2019-05-05 21:29 UTC by Report Bug Copy Issue Report The variable `$key` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2019-05-12 16:44 UTC by Report Bug Copy Issue Report The variable `$property` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
50
51		} else {
52	2	$property = 'content';
53	2	[, $key] = explode(".", $source);
54		}
55
56	4	return new RequestFileArgument($this->requestStack, $key, $property);
		0 ignored issues – show Bug introduced 2019-05-12 16:44 UTC by Report Bug Copy Issue Report The variable `$property` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
57		}
58
59	6	public function createArgumentFromArray(array $source): Argument
60		{
61	6	Assert::keyExists($source, 'key');
62
63		/** @var string $property */
64	4	$property = 'content';
65
66	4	if (isset($source['property'])) {
67	2	$property = $source['property'];
68		}
69
70	4	return new RequestFileArgument($this->requestStack, $source['key'], $property);
71		}
72
73		}
74

addiks / symfony_generics

Push — master ( 8e04a1...918acc )

RequestFileArgumentFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like