adamjakab / SuiteCRM

modules/ModuleBuilder/views/view.relationship.php

Braces +10 added lines, -7 removed lines

@@ -120,8 +120,9 @@ 
                 
         $cardinality = array ( MB_ONETOONE => translate ( 'LBL_ONETOONE' ) , MB_ONETOMANY => translate ( 'LBL_ONETOMANY' ) , MB_MANYTOONE=> translate ( 'LBL_MANYTOONE' ), MB_MANYTOMANY => translate ( 'LBL_MANYTOMANY' ), ) ;
         
-        if (!$this->fromModuleBuilder)
-            unset($cardinality[MB_MANYTOONE]);
+        if (!$this->fromModuleBuilder) {
+                    unset($cardinality[MB_MANYTOONE]);
+        }
             
         $relationships = $module->getRelationships () ;
         
@@ -136,7 +137,7 @@ 
 	            $definition['lhs_label'] = isset($modStrings[$relationship->getTitleKey()])?$modStrings[$relationship->getTitleKey()] : $relationship->lhs_module;
 	            $modStrings = return_module_language( $selected_lang, $relationship->lhs_module, true ) ;
 	    		$definition['rhs_label'] = isset($modStrings[$relationship->getTitleKey(true)])?$modStrings[$relationship->getTitleKey(true)] : $relationship->rhs_module ;
-			}else{
+			} else{
 				#30624
 				if(!empty($_REQUEST['rhs_module'])){
 					$definition['rhs_label'] = $_REQUEST['rhs_module'];
@@ -254,12 +255,14 @@ 
                     }
                     $this->smarty->assign ( 'relationship_role_column_enum', $validRoleColumnFields ) ;
                 }
-                if (! empty ( $relationship->relationship_role_column_value ))
-                    $this->smarty->assign ( 'relationship_role_column_value', $relationship->relationship_role_column_value ) ;
+                if (! empty ( $relationship->relationship_role_column_value )) {
+                                    $this->smarty->assign ( 'relationship_role_column_value', $relationship->relationship_role_column_value ) ;
+                }
                 break ;
             case MB_MANYTOMANY :
-                if (! empty ( $relationship->relationship_role_column_value ))
-                    $this->smarty->assign ( 'relationship_role_column_value', $relationship->relationship_role_column_value ) ;
+                if (! empty ( $relationship->relationship_role_column_value )) {
+                                    $this->smarty->assign ( 'relationship_role_column_value', $relationship->relationship_role_column_value ) ;
+                }
                 break ;
         }
         

modules/ModuleBuilder/views/view.popupview.php

Braces +6 added lines, -4 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -125,7 +126,7 @@ 
 
             $ViewLabel = ($this->editLayout == MB_POPUPLIST) ? 'LBL_POPUPLISTVIEW' : 'LBL_POPUPSEARCH';
             $ajax->addCrumb ( translate ($ViewLabel, 'ModuleBuilder' ), '' ) ;
-        }else{
+        } else{
             $ajax->addCrumb ( translate($this->editModule), 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '")' ) ;
             $ajax->addCrumb ( translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&view_module=' . $this->editModule . '")');
             $ajax->addCrumb ( translate('LBL_POPUP', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=popup&view_module=' . $this->editModule . '")' );
@@ -184,8 +185,9 @@ 
 
 
         $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
-        if (isset($this->searchlayout))
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+        if (isset($this->searchlayout)) {
+                    $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+        }
 
         $buttons = array ( ) ;
         if (! $this->fromModuleBuilder)

modules/ModuleBuilder/views/view.resetmodule.php

Braces +21 added lines, -13 removed lines

@@ -95,20 +95,25 @@ 
     {
         $out = "<script>ajaxStatus.flashStatus(SUGAR.language.get('app_strings', 'LBL_REQUEST_PROCESSED'), 2000);</script>";
         
-        if (!empty($_REQUEST['relationships']))
-            $out .= $this->removeCustomRelationships();
+        if (!empty($_REQUEST['relationships'])) {
+                    $out .= $this->removeCustomRelationships();
+        }
             
-        if (!empty($_REQUEST['fields']))
-            $out .= $this->removeCustomFields();
+        if (!empty($_REQUEST['fields'])) {
+                    $out .= $this->removeCustomFields();
+        }
             
-        if (!empty($_REQUEST['layouts']))
-            $out .= $this->removeCustomLayouts();
+        if (!empty($_REQUEST['layouts'])) {
+                    $out .= $this->removeCustomLayouts();
+        }
 			
-		if (!empty($_REQUEST['labels']))
-            $out .= $this->removeCustomLabels();
+		if (!empty($_REQUEST['labels'])) {
+		            $out .= $this->removeCustomLabels();
+		}
 			
-		if (!empty($_REQUEST['extensions']))
-            $out .= $this->removeCustomExtensions();	
+		if (!empty($_REQUEST['extensions'])) {
+		            $out .= $this->removeCustomExtensions();
+		}
 			
         
         $out .= "Complete!";
@@ -209,8 +214,9 @@ 
                 $out .= "Removed relationship $relationshipName<br/>";
             }
         }
-        if ($madeChanges)
-           $relationships->save () ;
+        if ($madeChanges) {
+                   $relationships->save () ;
+        }
         
         return $out;
     }
@@ -222,7 +228,9 @@ 
         if (is_dir($languageDir)) {
             $files = scandir($languageDir);
             foreach ($files as $langFile) {
-                if (substr($langFile, 0 ,1) == '.') continue;
+                if (substr($langFile, 0 ,1) == '.') {
+                    continue;
+                }
 				$language = substr($langFile, 0, strlen($langFile) - 9);
 				unlink($languageDir . "/" . $langFile);
 				

modules/ModuleBuilder/views/view.package.php

Braces +7 added lines, -5 removed lines

@@ -73,8 +73,7 @@ 
 			$ajax->addCrumb($GLOBALS['mod_strings']['LBL_PACKAGE_LIST'],'');
  			$ajax->addSection('center', $GLOBALS['mod_strings']['LBL_PACKAGE_LIST'], $smarty->fetch('modules/ModuleBuilder/tpls/wizard.tpl'));
 			echo $ajax->getJavascript();
- 		}
- 		else {
+ 		} else {
  			
  			$name = (!empty($_REQUEST['package']))?$_REQUEST['package']:'';
 			$mb->getPackage($name);
@@ -114,11 +113,14 @@ 
 
 	 		$ajax = new AjaxCompose();
 	 		$ajax->addCrumb($GLOBALS['mod_strings']['LBL_MODULEBUILDER'], 'ModuleBuilder.getContent("module=ModuleBuilder&action=package")');
-			if(empty($name))$name = $mod_strings['LBL_NEW_PACKAGE'];
+			if(empty($name)) {
+			    $name = $mod_strings['LBL_NEW_PACKAGE'];
+			}
 	 		$ajax->addCrumb($name,'');
 	 		$html=$smarty->fetch('modules/ModuleBuilder/tpls/MBPackage/package.tpl');
-	 		if(!empty($_REQUEST['action']) && $_REQUEST['action']=='SavePackage')
-	 			$html.="<script>ModuleBuilder.treeRefresh('ModuleBuilder')</script>";
+	 		if(!empty($_REQUEST['action']) && $_REQUEST['action']=='SavePackage') {
+	 			 			$html.="<script>ModuleBuilder.treeRefresh('ModuleBuilder')</script>";
+	 		}
 	 		$ajax->addSection('center', translate('LBL_SECTION_PACKAGE', 'ModuleBuilder'), $html);
 			echo $ajax->getJavascript();
  		}

modules/ModuleBuilder/views/view.wizard.php

Braces +9 added lines, -6 removed lines

@@ -54,8 +54,9 @@ 
 
 	function __construct()
 	{
-		if ( isset ( $_REQUEST [ 'view' ] ) )
-			$this->view = $_REQUEST [ 'view' ] ;
+		if ( isset ( $_REQUEST [ 'view' ] ) ) {
+					$this->view = $_REQUEST [ 'view' ] ;
+		}
 
 		$this->editModule = (! empty ( $_REQUEST [ 'view_module' ] ) ) ? $_REQUEST [ 'view_module' ] : null ;
 		$this->buttons = array(); // initialize so that modules without subpanels for example don't result in this being unset and causing problems in the smarty->assign
@@ -114,8 +115,9 @@ 
 			$this->question = translate('LBL_QUESTION_EDIT') ;
 			$this->title = translate( 'LBL_STUDIO' );
 			global $current_user;
-			if (is_admin($current_user))
-				$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
+			if (is_admin($current_user)) {
+							$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
+			}
 
 			$this->help = 'studioHelp' ;
 		} else
@@ -177,10 +179,11 @@ 
 					$this->title = translate( 'LBL_EDIT' ) . " " . $module->name ;
 					$this->help = 'moduleHelp' ;
 					global $current_user;
-					if (is_admin($current_user))
-                        $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" " 
+					if (is_admin($current_user)) {
+					                        $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" " 
                         . "onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=resetmodule&view_module=$this->editModule');\" value=\"" 
                         . translate( 'LBL_RESET_MODULE' ) . '">' ;
+					}
 			}
 		}
 	}

modules/ModuleBuilder/views/view.dropdown.php

Braces +12 added lines, -9 removed lines

@@ -134,27 +134,30 @@
 			
 			// handle the case where we've saved a dropdown in one language, and now attempt to edit it for another language. The $name exists, but $my_list_strings[$name] doesn't
             // for now, we just treat it as if it was new. A better approach might be to use the first language version as a template for future languages
-            if (!isset($my_list_strings[$name]))
-                $my_list_strings[$name] = array () ;
+            if (!isset($my_list_strings[$name])) {
+                            $my_list_strings[$name] = array () ;
+            }
  
 			$selected_dropdown = (!empty($vardef['options']) && !empty($my_list_strings[$vardef['options']])) ? $my_list_strings[$vardef['options']] : $my_list_strings[$name];
 			$smarty->assign('ul_list', 'list = '.$json->encode(array_keys($selected_dropdown)));
 			$smarty->assign('dropdown_name', (!empty($vardef['options']) ? $vardef['options'] : $_REQUEST['dropdown_name']));
 			$smarty->assign('name', $_REQUEST['dropdown_name']);
 			$smarty->assign('options', $selected_dropdown);
-		}else{
+		} else{
 			$smarty->assign('ul_list', 'list = {}');
 			//we should try to find a name for this dropdown based on the field name.
 			$pre_pop_name = '';
-			if(!empty($_REQUEST['field']))
-				$pre_pop_name = $_REQUEST['field'];
+			if(!empty($_REQUEST['field'])) {
+							$pre_pop_name = $_REQUEST['field'];
+			}
 			//ensure this dropdown name does not already exist
 			$use_name = $pre_pop_name.'_list';
 			for($i = 0; $i < 100; $i++){
-				if(empty($my_list_strings[$use_name]))
-					break;
-				else
-					$use_name = $pre_pop_name.'_'.$i;
+				if(empty($my_list_strings[$use_name])) {
+									break;
+				} else {
+									$use_name = $pre_pop_name.'_'.$i;
+				}
 			}
 			$smarty->assign('prepopulated_name', $use_name);
 		}

modules/ModuleBuilder/views/view.listview.php

Braces +17 added lines, -11 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -115,8 +116,9 @@ 
         			MB_LISTVIEW => 'LBL_LISTVIEW' ,
         			) ;
         $translatedViewType = '' ;
-		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) )
-			$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) ) {
+					$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+		}
 		$this->translatedViewType = $translatedViewType;
 
         if ($this->fromModuleBuilder)
@@ -131,8 +133,9 @@ 
                 {
                     $subpanelLabel = $this->subpanelLabel;
                     // If the subpanel title has changed, use that for the label instead
-                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] )
-                        $subpanelLabel = $_REQUEST['subpanel_title'];
+                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] ) {
+                                            $subpanelLabel = $_REQUEST['subpanel_title'];
+                    }
 
                     $ajax->addCrumb( $subpanelLabel, '' );
                     $this->translatedViewType = $subpanelLabel . "&nbsp;" . translate("LBL_SUBPANEL", "ModuleBuilder");
@@ -158,8 +161,9 @@ 
                 {
                     $subpanelLabel = $this->subpanelLabel;
                     // If the subpanel title has changed, use that for the label instead
-                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] )
-                        $subpanelLabel = $_REQUEST['subpanel_title'];
+                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] ) {
+                                            $subpanelLabel = $_REQUEST['subpanel_title'];
+                    }
 
                     $ajax->addCrumb( $subpanelLabel, '' );
                     $this->translatedViewType = $subpanelLabel . "&nbsp;" . translate("LBL_SUBPANEL", "ModuleBuilder");
@@ -241,12 +245,14 @@ 
         $history = $parser->getHistory () ;
 
         $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
-        if ($this->subpanel)
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->subpanel}\")" ;
+        if ($this->subpanel) {
+                    $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->subpanel}\")" ;
+        }
 
         $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"\")'";
-        if ($this->subpanel)
-            $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"{$this->subpanel}\")'";
+        if ($this->subpanel) {
+                    $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"{$this->subpanel}\")'";
+        }
 
         $buttons = array ( ) ;
         $buttons [] = array ( 'id' =>'savebtn', 'name' => 'savebtn' , 'image' => $imageSave , 'text' => (! $this->fromModuleBuilder)?$GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVEPUBLISH' ]: $GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVE' ], 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");if (countListFields()==0) ModuleBuilder.layoutValidation.popup() ; else ModuleBuilder.handleSave(\"edittabs\" )'" ) ;

modules/ModuleBuilder/views/view.dashlet.php

Braces +16 added lines, -12 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,10 +53,11 @@ 
     {
         $this->editModule = $_REQUEST [ 'view_module' ] ;
         $this->editLayout = $_REQUEST [ 'view' ] ;
-        if(isset ( $_REQUEST [ 'view_package' ] ) && ! empty ( $_REQUEST [ 'view_package' ] ))
-            $this->editPackage = $_REQUEST [ 'view_package' ];
-        else
-            $this->editPackage = null;
+        if(isset ( $_REQUEST [ 'view_package' ] ) && ! empty ( $_REQUEST [ 'view_package' ] )) {
+                    $this->editPackage = $_REQUEST [ 'view_package' ];
+        } else {
+                    $this->editPackage = null;
+        }
 
         $this->fromModuleBuilder = isset ( $_REQUEST [ 'MB' ] ) || (isset($_REQUEST['view_package']) && $_REQUEST['view_package'] && $_REQUEST['view_package'] != 'studio') ;
 
@@ -121,7 +123,7 @@ 
 
             $ViewLabel = ($this->editLayout == MB_DASHLET) ? 'LBL_DASHLETLISTVIEW' : 'LBL_DASHLETSEARCHVIEW';
             $ajax->addCrumb ( translate ($ViewLabel, 'ModuleBuilder' ), '' ) ;
-        }else{
+        } else{
             $ajax->addCrumb ( translate($this->editModule), 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '")' ) ;
             $ajax->addCrumb ( translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&view_module=' . $this->editModule . '")');
             $ajax->addCrumb ( translate('LBL_DASHLET', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=dashlet&view_module=' . $this->editModule . '")' );
@@ -182,8 +184,9 @@ 
 
 
         $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
-        if (isset($this->searchlayout))
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+        if (isset($this->searchlayout)) {
+                    $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+        }
 
         $buttons = array ( ) ;
         if (! $this->fromModuleBuilder)
@@ -221,10 +224,11 @@ 
     {
         global $app_list_strings ;
 
-        if ($this->fromModuleBuilder)
-            $title = $this->editModule ;
-        else
-            $title =  $app_list_strings [ 'moduleList' ] [ $this->editModule ] ;
+        if ($this->fromModuleBuilder) {
+                    $title = $this->editModule ;
+        } else {
+                    $title =  $app_list_strings [ 'moduleList' ] [ $this->editModule ] ;
+        }
         
         return $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_EDIT' ] . ':&nbsp;' . $title ;
     }

modules/ModuleBuilder/views/view.history.php

Braces +4 added lines, -3 removed lines

@@ -103,8 +103,9 @@ 
         {
             $dbDate = $timedate->fromTimestamp($ts)->asDb();
             $displayTS = $timedate->to_display_date_time ( $dbDate ) ;
-            if ($page * $this->pageSize + $i + 1 == $count)
-                $displayTS = translate("LBL_MB_DEFAULT_LAYOUT");
+            if ($page * $this->pageSize + $i + 1 == $count) {
+                            $displayTS = translate("LBL_MB_DEFAULT_LAYOUT");
+            }
             $snapshots [ $ts ] = $displayTS ;
             $ts = $this->history->getNext () ;
         }
@@ -151,7 +152,7 @@ 
         {
         	require_once ("modules/ModuleBuilder/views/view.dashlet.php") ;
         	$view = new ViewDashlet ( ) ;
-        }  else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
+        } else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
         {
         	require_once ("modules/ModuleBuilder/views/view.popupview.php") ;
         	$view = new ViewPopupview ( ) ;