adamjakab / SuiteCRM

modules/AOS_PDF_Templates/sendEmail.php

Braces +5 added lines, -4 removed lines

@@ -44,10 +44,11 @@
 		$email->type = "draft";
 		$email->status = "draft";
 	
-		if(!empty($module->billing_contact_id) && $module->billing_contact_id!="")
-            $contact_id = $module->billing_contact_id;
-        else if(!empty($module->contact_id) && $module->contact_id!="")
-            $contact_id = $module->contact_id;
+		if(!empty($module->billing_contact_id) && $module->billing_contact_id!="") {
+		            $contact_id = $module->billing_contact_id;
+		} else if(!empty($module->contact_id) && $module->contact_id!="") {
+                    $contact_id = $module->contact_id;
+        }
 
             require_once('modules/Contacts/Contact.php');
             $contact = new Contact;

modules/AOW_WorkFlow/aow_utils.php

Braces +69 added lines, -43 removed lines

@@ -47,7 +47,9 @@ 
             } //End loop.
 
             foreach($unset as $name){
-                if(isset($fields[$name])) unset( $fields[$name]);
+                if(isset($fields[$name])) {
+                    unset( $fields[$name]);
+                }
             }
 
         }
@@ -124,7 +126,7 @@ 
                 if(isset($arr['vname']) && $arr['vname'] != '') {
                     $label = $rel_module_label . ' : ' . translate($arr['vname'], $mod->module_dir);
                     $module_label = trim(translate($arr['vname'],$mod->module_dir),':');
-                }else {
+                } else {
                     $label = $rel_module_label . ' : '. $name;
                     $module_label = $name;
                 }
@@ -175,7 +177,9 @@ 
                         $sort_fields[$name] = $relModuleName.' : '. $name;
                     }
                     if($arr['type'] == 'relate' && isset($arr['id_name']) && $arr['id_name'] != ''){
-                        if(isset($fields[$arr['id_name']])) unset( $fields[$arr['id_name']]);
+                        if(isset($fields[$arr['id_name']])) {
+                            unset( $fields[$arr['id_name']]);
+                        }
                     }
                 }
             } //End loop.
@@ -269,7 +273,9 @@ 
             $vardef['type'] = 'varchar';
         }
 
-        if(isset($vardef['precision'])) unset($vardef['precision']);
+        if(isset($vardef['precision'])) {
+            unset($vardef['precision']);
+        }
 
         //$vardef['precision'] = $locale->getPrecedentPreference('default_currency_significant_digits', $current_user);
 
@@ -308,8 +314,9 @@ 
         // remove the special text entry field function 'getEmailAddressWidget'
         if ( isset($vardef['function'])
             && ( $vardef['function'] == 'getEmailAddressWidget'
-                || $vardef['function']['name'] == 'getEmailAddressWidget' ) )
-            unset($vardef['function']);
+                || $vardef['function']['name'] == 'getEmailAddressWidget' ) ) {
+                    unset($vardef['function']);
+        }
 
         if(isset($vardef['name']) && ($vardef['name'] == 'date_entered' || $vardef['name'] == 'date_modified')){
             $vardef['name'] = 'aow_temp_date';
@@ -334,8 +341,9 @@ 
         }
 
         // hack to disable one of the js calls in this control
-        if ( isset($vardef['function']) && ( $vardef['function'] == 'getCurrencyDropDown' || $vardef['function']['name'] == 'getCurrencyDropDown' ) )
-            $contents .= "{literal}<script>function CurrencyConvertAll() { return; }</script>{/literal}";
+        if ( isset($vardef['function']) && ( $vardef['function'] == 'getCurrencyDropDown' || $vardef['function']['name'] == 'getCurrencyDropDown' ) ) {
+                    $contents .= "{literal}<script>function CurrencyConvertAll() { return; }</script>{/literal}";
+        }
 
         // Save it to the cache file
         if($fh = @sugar_fopen($file, 'w')) {
@@ -361,8 +369,7 @@ 
     $t23 = strpos($time_format, '23') !== false ? '%H' : '%I';
     if(!isset($match[2]) || $match[2] == '') {
         $ss->assign('CALENDAR_FORMAT', $date_format . ' ' . $t23 . $time_separator . "%M");
-    }
-    else {
+    } else {
         $pm = $match[2] == "pm" ? "%P" : "%p";
         $ss->assign('CALENDAR_FORMAT', $date_format . ' ' . $t23 . $time_separator . "%M" . $pm);
     }
@@ -371,8 +378,9 @@ 
 
     // populate the fieldlist from the vardefs
     $fieldlist = array();
-    if ( !isset($focus) || !($focus instanceof SugarBean) )
-        require_once($beanFiles[$beanList[$module]]);
+    if ( !isset($focus) || !($focus instanceof SugarBean) ) {
+            require_once($beanFiles[$beanList[$module]]);
+    }
     $focus = new $beanList[$module];
     // create the dropdowns for the parent type fields
     $vardefFields = $focus->getFieldDefinitions();
@@ -382,14 +390,17 @@ 
     foreach ( $vardefFields as $name => $properties ) {
         $fieldlist[$name] = $properties;
         // fill in enums
-        if(isset($fieldlist[$name]['options']) && is_string($fieldlist[$name]['options']) && isset($app_list_strings[$fieldlist[$name]['options']]))
-            $fieldlist[$name]['options'] = $app_list_strings[$fieldlist[$name]['options']];
+        if(isset($fieldlist[$name]['options']) && is_string($fieldlist[$name]['options']) && isset($app_list_strings[$fieldlist[$name]['options']])) {
+                    $fieldlist[$name]['options'] = $app_list_strings[$fieldlist[$name]['options']];
+        }
         // Bug 32626: fall back on checking the mod_strings if not in the app_list_strings
-        elseif(isset($fieldlist[$name]['options']) && is_string($fieldlist[$name]['options']) && isset($mod_strings[$fieldlist[$name]['options']]))
-            $fieldlist[$name]['options'] = $mod_strings[$fieldlist[$name]['options']];
+        elseif(isset($fieldlist[$name]['options']) && is_string($fieldlist[$name]['options']) && isset($mod_strings[$fieldlist[$name]['options']])) {
+                    $fieldlist[$name]['options'] = $mod_strings[$fieldlist[$name]['options']];
+        }
         // Bug 22730: make sure all enums have the ability to select blank as the default value.
-        if(!isset($fieldlist[$name]['options']['']))
-            $fieldlist[$name]['options'][''] = '';
+        if(!isset($fieldlist[$name]['options'][''])) {
+                    $fieldlist[$name]['options'][''] = '';
+        }
     }
 
     // fill in function return values
@@ -399,8 +410,9 @@ 
         {
             $function = $fieldlist[$fieldname]['function']['name'];
             // include various functions required in the various vardefs
-            if ( isset($fieldlist[$fieldname]['function']['include']) && is_file($fieldlist[$fieldname]['function']['include']))
-                require_once($fieldlist[$fieldname]['function']['include']);
+            if ( isset($fieldlist[$fieldname]['function']['include']) && is_file($fieldlist[$fieldname]['function']['include'])) {
+                            require_once($fieldlist[$fieldname]['function']['include']);
+            }
             $_REQUEST[$fieldname] = $value;
             $value = $function($focus, $fieldname, $value, $view);
 
@@ -456,9 +468,11 @@ 
         $value = $focus->convertField($value, $fieldlist[$fieldname]);
         if(!empty($params['date_format']) && isset($params['date_format'])){
             $convert_format = "Y-m-d H:i:s";
-            if($fieldlist[$fieldname]['type'] == 'date') $convert_format = "Y-m-d";
+            if($fieldlist[$fieldname]['type'] == 'date') {
+                $convert_format = "Y-m-d";
+            }
             $fieldlist[$fieldname]['value'] = $timedate->to_display($value, $convert_format, $params['date_format']);
-        }else{
+        } else{
             $fieldlist[$fieldname]['value'] = $timedate->to_display_date_time($value, true, true);
         }
         $fieldlist[$fieldname]['name'] = $aow_field;
@@ -519,7 +533,9 @@ 
 
     $value = json_decode(html_entity_decode_utf8($value), true);
 
-    if(!file_exists('modules/AOBH_BusinessHours/AOBH_BusinessHours.php')) unset($app_list_strings['aow_date_type_list']['business_hours']);
+    if(!file_exists('modules/AOBH_BusinessHours/AOBH_BusinessHours.php')) {
+        unset($app_list_strings['aow_date_type_list']['business_hours']);
+    }
 
     $field = '';
 
@@ -527,11 +543,12 @@ 
         $field .= "<select type='text' name='$aow_field".'[0]'."' id='$aow_field".'[0]'."' title='' tabindex='116'>". getDateFields($module, $view, $value[0], $field_option) ."</select>&nbsp;&nbsp;";
         $field .= "<select type='text' name='$aow_field".'[1]'."' id='$aow_field".'[1]'."' onchange='date_field_change(\"$aow_field\")'  title='' tabindex='116'>". get_select_options_with_id($app_list_strings['aow_date_operator'], $value[1]) ."</select>&nbsp;";
         $display = 'none';
-        if($value[1] == 'plus' || $value[1] == 'minus') $display = '';
+        if($value[1] == 'plus' || $value[1] == 'minus') {
+            $display = '';
+        }
         $field .= "<input  type='text' style='width:40px; display:$display' name='$aow_field".'[2]'."' id='$aow_field".'[2]'."' title='' value='$value[2]' tabindex='116'>&nbsp;";
         $field .= "<select type='text' style='display:$display' name='$aow_field".'[3]'."' id='$aow_field".'[3]'."' title='' tabindex='116'>". get_select_options_with_id($app_list_strings['aow_date_type_list'], $value[3]) ."</select>";
-    }
-    else {
+    } else {
         $field = getDateFields($module, $view, $value[0], $field_option).' '.$app_list_strings['aow_date_operator'][$value[1]];
         if($value[1] == 'plus' || $value[1] == 'minus'){
             $field .= ' '.$value[2].' '.$app_list_strings['aow_date_type_list'][$value[3]];
@@ -547,7 +564,9 @@ 
 
     $fields = $app_list_strings['aow_date_options'];
 
-    if(!$field_option) unset($fields['field']);
+    if(!$field_option) {
+        unset($fields['field']);
+    }
 
     if ($module != '') {
         if(isset($beanList[$module]) && $beanList[$module]){
@@ -580,8 +599,7 @@ 
 
     if(!file_exists('modules/SecurityGroups/SecurityGroup.php')){
         unset($app_list_strings['aow_assign_options']['security_group']);
-    }
-    else{
+    } else{
         $securityGroups = get_bean_select_array(true, 'SecurityGroup','name', '','name',true);
     }
 
@@ -591,17 +609,19 @@ 
         $field .= "<select type='text' name='$aow_field".'[0]'."' id='$aow_field".'[0]'."' onchange='assign_field_change(\"$aow_field\")' title='' tabindex='116'>". get_select_options_with_id($app_list_strings['aow_assign_options'], $value[0]) ."</select>&nbsp;&nbsp;";
         if(!file_exists('modules/SecurityGroups/SecurityGroup.php')){
             $field .= "<input type='hidden' name='$aow_field".'[1]'."' id='$aow_field".'[1]'."' value=''  />";
-        }
-        else {
+        } else {
             $display = 'none';
-            if($value[0] == 'security_group') $display = '';
+            if($value[0] == 'security_group') {
+                $display = '';
+            }
             $field .= "<select type='text' style='display:$display' name='$aow_field".'[1]'."' id='$aow_field".'[1]'."' title='' tabindex='116'>". get_select_options_with_id($securityGroups, $value[1]) ."</select>&nbsp;&nbsp;";
         }
         $display = 'none';
-        if($value[0] == 'role' || $value[0] == 'security_group') $display = '';
+        if($value[0] == 'role' || $value[0] == 'security_group') {
+            $display = '';
+        }
         $field .= "<select type='text' style='display:$display' name='$aow_field".'[2]'."' id='$aow_field".'[2]'."' title='' tabindex='116'>". get_select_options_with_id($roles, $value[2]) ."</select>&nbsp;&nbsp;";
-    }
-    else {
+    } else {
         $field = $app_list_strings['aow_assign_options'][$value[1]];
     }
     return $field;
@@ -616,8 +636,7 @@ 
             $option .= '<option value="'.$key.'" selected>'.$value.'</option>';
         } else if($selected_value == $key) {
             $option .= '<option value="'.$key.'" selected>'.$value.'</option>';
-        }
-        else {
+        } else {
             $option .= '<option value="'.$key.'">'.$value.'</option>';
         }
     }
@@ -644,8 +663,7 @@ 
         if(!empty($users[$key])) {
             return $users[$key];
         }
-    }
-    else if (is_file($file)){
+    } else if (is_file($file)){
         require_once($file);
         if(isset($lastUser['User']) && $lastUser['User'] != '') {
             $users_by_key = array_flip($users); // now keys are values
@@ -706,7 +724,9 @@ 
             $mod = new $beanList[$module]();
 
             foreach($mod->get_related_fields() as $field){
-                if(isset($field['link'])) $checked_link[] = $field['link'];
+                if(isset($field['link'])) {
+                    $checked_link[] = $field['link'];
+                }
                 if(!isset($field['module']) || !in_array($field['module'],$emailableModules) || (isset($field['dbType']) && $field['dbType'] == "id")){
                     continue;
                 }
@@ -749,7 +769,9 @@ 
     switch($bean->field_defs[$field]['type']) {
         case 'datetime':
         case 'datetimecombo':
-            if(empty($value)) break;
+            if(empty($value)) {
+                break;
+            }
             if ($value == 'NULL') {
                 $value = '';
                 break;
@@ -760,7 +782,9 @@ 
             }
             break;
         case 'date':
-            if(empty($value)) break;
+            if(empty($value)) {
+                break;
+            }
             if ($value == 'NULL') {
                 $value = '';
                 break;
@@ -771,7 +795,9 @@ 
             }
             break;
         case 'time':
-            if(empty($value)) break;
+            if(empty($value)) {
+                break;
+            }
             if ($value == 'NULL') {
                 $value = '';
                 break;

modules/Charts/Dashlets/MyPipelineBySalesStageDashlet/MyPipelineBySalesStageDashlet.php

Braces +21 added lines, -15 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -62,12 +64,15 @@ 
     {
         global $timedate;
 
-        if(empty($options['mypbss_date_start']))
-            $options['mypbss_date_start'] = $timedate->nowDbDate();
-        if(empty($options['mypbss_date_end']))
-            $options['mypbss_date_end'] = $timedate->asDbDate($timedate->getNow()->modify("+6 months"));
-        if(empty($options['title']))
-            $options['title'] = translate('LBL_MY_PIPELINE_FORM_TITLE', 'Home');
+        if(empty($options['mypbss_date_start'])) {
+                    $options['mypbss_date_start'] = $timedate->nowDbDate();
+        }
+        if(empty($options['mypbss_date_end'])) {
+                    $options['mypbss_date_end'] = $timedate->asDbDate($timedate->getNow()->modify("+6 months"));
+        }
+        if(empty($options['title'])) {
+                    $options['title'] = translate('LBL_MY_PIPELINE_FORM_TITLE', 'Home');
+        }
 
         parent::__construct($id,$options);
     }
@@ -80,11 +85,12 @@ 
         global $app_list_strings;
 
         $selected_datax = array();
-        if (count($this->mypbss_sales_stages) > 0)
-            foreach ($this->mypbss_sales_stages as $key)
+        if (count($this->mypbss_sales_stages) > 0) {
+                    foreach ($this->mypbss_sales_stages as $key)
                 $selected_datax[] = $key;
-        else
-            $selected_datax = array_keys($app_list_strings['sales_stage_dom']);
+        } else {
+                    $selected_datax = array_keys($app_list_strings['sales_stage_dom']);
+        }
 
         $this->_searchFields['mypbss_sales_stages']['options'] = $app_list_strings['sales_stage_dom'];
         $this->_searchFields['mypbss_sales_stages']['input_name0'] = $selected_datax;
@@ -316,8 +322,7 @@ 
                 $datax[$key] = $app_list_strings['sales_stage_dom'][$key];
                 array_push($selected_datax, $key);
             }
-        }
-        else {
+        } else {
             $datax = $app_list_strings['sales_stage_dom'];
             $selected_datax = array_keys($app_list_strings['sales_stage_dom']);
         }
@@ -391,8 +396,9 @@ 
             " AND opportunities.date_closed >= ". db_convert("'".$this->mypbss_date_start."'",'date').
             " AND opportunities.date_closed <= ".db_convert("'".$this->mypbss_date_end."'",'date') .
             " AND opportunities.assigned_user_id = users.id  AND opportunities.deleted=0 ";
-        if ( count($this->mypbss_sales_stages) > 0 )
-            $query .= " AND opportunities.sales_stage IN ('" . implode("','",$this->mypbss_sales_stages) . "') ";
+        if ( count($this->mypbss_sales_stages) > 0 ) {
+                    $query .= " AND opportunities.sales_stage IN ('" . implode("','",$this->mypbss_sales_stages) . "') ";
+        }
         $query .= " GROUP BY opportunities.sales_stage ,users.user_name,opportunities.assigned_user_id";
 
         return $query;

modules/Charts/Dashlets/OutcomeByMonthDashlet/OutcomeByMonthDashlet.php

Braces +18 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -66,11 +68,13 @@ 
     {
         global $timedate;
 
-        if(empty($options['obm_date_start']))
-            $options['obm_date_start'] = $timedate->nowDbDate();
+        if(empty($options['obm_date_start'])) {
+                    $options['obm_date_start'] = $timedate->nowDbDate();
+        }
 
-        if(empty($options['obm_date_end']))
-            $options['obm_date_end'] = $timedate->asDbDate($timedate->getNow()->modify("+6 months"));
+        if(empty($options['obm_date_end'])) {
+                    $options['obm_date_end'] = $timedate->asDbDate($timedate->getNow()->modify("+6 months"));
+        }
 
         parent::__construct($id,$options);
     }
@@ -80,8 +84,9 @@ 
      */
     public function displayOptions()
     {
-        if (!isset($this->obm_ids) || count($this->obm_ids) == 0)
-            $this->_searchFields['obm_ids']['input_name0'] = array_keys(get_user_array(false));
+        if (!isset($this->obm_ids) || count($this->obm_ids) == 0) {
+                    $this->_searchFields['obm_ids']['input_name0'] = array_keys(get_user_array(false));
+        }
 
         return parent::displayOptions();
     }
@@ -247,8 +252,9 @@ 
         $query .= " WHERE opportunities.date_closed >= ".db_convert("'".$this->obm_date_start."'",'date') .
             " AND opportunities.date_closed <= ".db_convert("'".$this->obm_date_end."'",'date') .
             " AND opportunities.deleted=0";
-        if (count($this->obm_ids) > 0)
-            $query .= " AND opportunities.assigned_user_id IN ('" . implode("','",$this->obm_ids) . "')";
+        if (count($this->obm_ids) > 0) {
+                    $query .= " AND opportunities.assigned_user_id IN ('" . implode("','",$this->obm_ids) . "')";
+        }
         $query .= " GROUP BY sales_stage,".
             db_convert('opportunities.date_closed','date_format',array("'%Y-%m'"),array("'YYYY-MM'")) .
             " ORDER BY m";
@@ -274,8 +280,9 @@ 
                 $chart['labels'][] = $key;
                 $chart['data'][] = array();
             }
-            if(!in_array($stage,$chart['key']))
-                $chart['key'][] = $stage;
+            if(!in_array($stage,$chart['key'])) {
+                            $chart['key'][] = $stage;
+            }
 
             $formattedFloat = (float)number_format((float)$i["total"], 2, '.', '');
             $chart['data'][count($chart['data'])-1][] = $formattedFloat;

modules/Charts/Dashlets/OpportunitiesByLeadSourceDashlet/OpportunitiesByLeadSourceDashlet.php

Braces +19 added lines, -13 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -62,17 +64,19 @@ 
         global $app_list_strings;
 
         $selected_datax = array();
-        if (!empty($this->pbls_lead_sources) && sizeof($this->pbls_lead_sources) > 0)
-            foreach ($this->pbls_lead_sources as $key)
+        if (!empty($this->pbls_lead_sources) && sizeof($this->pbls_lead_sources) > 0) {
+                    foreach ($this->pbls_lead_sources as $key)
                 $selected_datax[] = $key;
-        else
-            $selected_datax = array_keys($app_list_strings['lead_source_dom']);
+        } else {
+                    $selected_datax = array_keys($app_list_strings['lead_source_dom']);
+        }
 
         $this->_searchFields['pbls_lead_sources']['options'] = array_filter($app_list_strings['lead_source_dom']);
         $this->_searchFields['pbls_lead_sources']['input_name0'] = $selected_datax;
 
-        if (!isset($this->pbls_ids) || count($this->pbls_ids) == 0)
-            $this->_searchFields['pbls_ids']['input_name0'] = array_keys(get_user_array(false));
+        if (!isset($this->pbls_ids) || count($this->pbls_ids) == 0) {
+                    $this->_searchFields['pbls_ids']['input_name0'] = array_keys(get_user_array(false));
+        }
 
         return parent::displayOptions();
     }
@@ -241,12 +245,14 @@ 
         $query = "SELECT lead_source,sum(amount_usdollar/1000) as total,count(*) as opp_count ".
             "FROM opportunities ";
         $query .= "WHERE opportunities.deleted=0 ";
-        if ( count($this->pbls_ids) > 0 )
-            $query .= "AND opportunities.assigned_user_id IN ('".implode("','",$this->pbls_ids)."') ";
-        if ( count($this->pbls_lead_sources) > 0 )
-            $query .= "AND opportunities.lead_source IN ('".implode("','",$this->pbls_lead_sources)."') ";
-        else
-            $query .= "AND opportunities.lead_source IN ('".implode("','",array_keys($GLOBALS['app_list_strings']['lead_source_dom']))."') ";
+        if ( count($this->pbls_ids) > 0 ) {
+                    $query .= "AND opportunities.assigned_user_id IN ('".implode("','",$this->pbls_ids)."') ";
+        }
+        if ( count($this->pbls_lead_sources) > 0 ) {
+                    $query .= "AND opportunities.lead_source IN ('".implode("','",$this->pbls_lead_sources)."') ";
+        } else {
+                    $query .= "AND opportunities.lead_source IN ('".implode("','",array_keys($GLOBALS['app_list_strings']['lead_source_dom']))."') ";
+        }
         $query .= "GROUP BY lead_source ORDER BY total DESC";
 
         return $query;

modules/Charts/Dashlets/OpportunitiesByLeadSourceByOutcomeDashlet/OpportunitiesByLeadSourceByOutcomeDashlet.php

Braces +25 added lines, -17 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,17 +63,19 @@ 
         global $app_list_strings;
 
         $selected_datax = array();
-        if (!empty($this->lsbo_lead_sources) && sizeof($this->lsbo_lead_sources) > 0)
-            foreach ($this->lsbo_lead_sources as $key)
+        if (!empty($this->lsbo_lead_sources) && sizeof($this->lsbo_lead_sources) > 0) {
+                    foreach ($this->lsbo_lead_sources as $key)
                 $selected_datax[] = $key;
-        else
-            $selected_datax = array_keys($app_list_strings['lead_source_dom']);
+        } else {
+                    $selected_datax = array_keys($app_list_strings['lead_source_dom']);
+        }
 
         $this->_searchFields['lsbo_lead_sources']['options'] = array_filter($app_list_strings['lead_source_dom']);
         $this->_searchFields['lsbo_lead_sources']['input_name0'] = $selected_datax;
 
-        if (!isset($this->lsbo_ids) || count($this->lsbo_ids) == 0)
-            $this->_searchFields['lsbo_ids']['input_name0'] = array_keys(get_user_array(false));
+        if (!isset($this->lsbo_ids) || count($this->lsbo_ids) == 0) {
+                    $this->_searchFields['lsbo_ids']['input_name0'] = array_keys(get_user_array(false));
+        }
 
         return parent::displayOptions();
     }
@@ -131,8 +135,9 @@ 
 
 
         $url_params = array();
-        if ( count($this->lsbo_ids) > 0 )
-            $url_params['assigned_user_id'] = array_values($this->lsbo_ids);
+        if ( count($this->lsbo_ids) > 0 ) {
+                    $url_params['assigned_user_id'] = array_values($this->lsbo_ids);
+        }
 
 
         $data = $this->getChartData($this->constructQuery());
@@ -253,12 +258,14 @@ 
         $query = "SELECT lead_source,sales_stage,sum(amount_usdollar/1000) as total, ".
             "count(*) as opp_count FROM opportunities ";
         $query .= " WHERE opportunities.deleted=0 ";
-        if ( count($this->lsbo_ids) > 0 )
-            $query .= "AND opportunities.assigned_user_id IN ('".implode("','",$this->lsbo_ids)."') ";
-        if ( count($this->lsbo_lead_sources) > 0 )
-            $query .= "AND opportunities.lead_source IN ('".implode("','",$this->lsbo_lead_sources)."') ";
-        else
-            $query .= "AND opportunities.lead_source IN ('".implode("','",array_keys($GLOBALS['app_list_strings']['lead_source_dom']))."') ";
+        if ( count($this->lsbo_ids) > 0 ) {
+                    $query .= "AND opportunities.assigned_user_id IN ('".implode("','",$this->lsbo_ids)."') ";
+        }
+        if ( count($this->lsbo_lead_sources) > 0 ) {
+                    $query .= "AND opportunities.lead_source IN ('".implode("','",$this->lsbo_lead_sources)."') ";
+        } else {
+                    $query .= "AND opportunities.lead_source IN ('".implode("','",array_keys($GLOBALS['app_list_strings']['lead_source_dom']))."') ";
+        }
         $query .= " GROUP BY sales_stage,lead_source ORDER BY lead_source,sales_stage";
 
         return $query;
@@ -282,8 +289,9 @@ 
                 $chart['labels'][] = $key;
                 $chart['data'][] = array();
             }
-            if(!in_array($stage,$chart['key']))
-                $chart['key'][] = $stage;
+            if(!in_array($stage,$chart['key'])) {
+                            $chart['key'][] = $stage;
+            }
 
             $formattedFloat = (float)number_format((float)$i["total"], 2, '.', '');
             $chart['data'][count($chart['data'])-1][] = $formattedFloat;

modules/Charts/Dashlets/CampaignROIChartDashlet/CampaignROIChartDashlet.php

Braces +27 added lines, -19 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -60,11 +62,12 @@ 
         $this->getSeedBean()->disable_row_level_security = false;
 
         $campaigns = $this->getSeedBean()->get_full_list("","");
-        if ( $campaigns != null )
-            foreach ($campaigns as $c)
+        if ( $campaigns != null ) {
+                    foreach ($campaigns as $c)
                 $this->_searchFields['campaign_id']['options'][$c->id] = $c->name;
-        else
-            $this->_searchFields['campaign_id']['options'] = array();
+        } else {
+                    $this->_searchFields['campaign_id']['options'] = array();
+        }
 
         return parent::displayOptions();
     }
@@ -234,7 +237,9 @@ 
 
         $opp_result=$focus->db->query($opp_query);
         $opp_data=$focus->db->fetchByAssoc($opp_result);
-        if (empty($opp_data['total_value'])) $opp_data['total_value']=0;
+        if (empty($opp_data['total_value'])) {
+            $opp_data['total_value']=0;
+        }
 
         $chartData['Total Value']= $opp_data['total_value'];
 
@@ -252,7 +257,7 @@ 
         if (empty($opp_data1['revenue'])){
             $opp_data1[$mod_strings['LBL_ROI_CHART_REVENUE']] = 0;
             unset($opp_data1['revenue']);
-        }else{
+        } else{
             $opp_data1[$mod_strings['LBL_ROI_CHART_REVENUE']] = $opp_data1['revenue'];
             unset($opp_data1['revenue']);
             $not_empty = true;
@@ -269,18 +274,21 @@ 
         $camp_data1=$focus->db->fetchByAssoc($camp_result1);
 
 
-        if (empty($camp_data1['investment']))
-            $camp_data1['investment'] = 0;
-        else
-            $not_empty = true;
-        if (empty($camp_data1['budget']))
-            $camp_data1['budget'] = 0;
-        else
-            $not_empty = true;
-        if (empty($camp_data1['expected_revenue']))
-            $camp_data1['expected_revenue'] = 0;
-        else
-            $not_empty = true;
+        if (empty($camp_data1['investment'])) {
+                    $camp_data1['investment'] = 0;
+        } else {
+                    $not_empty = true;
+        }
+        if (empty($camp_data1['budget'])) {
+                    $camp_data1['budget'] = 0;
+        } else {
+                    $not_empty = true;
+        }
+        if (empty($camp_data1['expected_revenue'])) {
+                    $camp_data1['expected_revenue'] = 0;
+        } else {
+                    $not_empty = true;
+        }
 
         $chartData['Investment']= $camp_data1['investment'];
         $chartData['Budget']= $camp_data1['budget'];

modules/Administration/SupportPortal.php

Braces +19 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,7 +55,9 @@ 
 
 switch ($_REQUEST['view']) {
 	case "support_portal":
-		if (!is_admin($current_user)) sugar_die("Unauthorized access to administration.");
+		if (!is_admin($current_user)) {
+		    sugar_die("Unauthorized access to administration.");
+		}
 		$GLOBALS['log']->info("Administration SupportPortal");
 
 		$iframe_url = add_http("www.sugarcrm.com/network/redirect.php?tmpl=network");
@@ -83,14 +87,18 @@ 
 		$send_key = isset($_REQUEST['key']) ? $_REQUEST['key'] : "";
 		$send_anchor = '';
 		// awu: Fixes the ProjectTasks pluralization issue -- must fix in later versions.
-		if ($send_module == 'ProjectTasks')
-			$send_module = 'ProjectTask';
-        if ($send_module == 'ProductCatalog')
-                $send_module = 'ProductTemplates';
-        if ($send_module == 'TargetLists')
-                $send_module = 'ProspectLists';
-        if ($send_module == 'Targets')
-                $send_module = 'Prospects';                            
+		if ($send_module == 'ProjectTasks') {
+					$send_module = 'ProjectTask';
+		}
+        if ($send_module == 'ProductCatalog') {
+                        $send_module = 'ProductTemplates';
+        }
+        if ($send_module == 'TargetLists') {
+                        $send_module = 'ProspectLists';
+        }
+        if ($send_module == 'Targets') {
+                        $send_module = 'Prospects';
+        }
 		// FG - Bug 39819 - Check for custom help files
 		$helpPath = 'modules/'.$send_module.'/language/'.$send_lang.'.help.'.$send_action.'.html';
 		if (sugar_is_file("custom/" . $helpPath)) {
@@ -205,7 +213,7 @@ 
 								$send_anchor = $map['anchor'];
 							}
 						}
-					}else{
+					} else{
 						$send_module = $map['name'];
 						if(!empty($map['anchor'])){
 								$send_anchor = $map['anchor'];

modules/Administration/DiagnosticRun.php

Braces +74 added lines, -50 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -47,7 +49,9 @@ 
 global $current_user;
 
 
-if (!is_admin($current_user)) sugar_die("Unauthorized access to administration.");
+if (!is_admin($current_user)) {
+    sugar_die("Unauthorized access to administration.");
+}
 if (isset($GLOBALS['sugar_config']['hide_admin_diagnostics']) && $GLOBALS['sugar_config']['hide_admin_diagnostics'])
 {
     sugar_die("Unauthorized access to diagnostic tool.");
@@ -131,9 +135,9 @@ 
     global $currentitems;
 
     $currentitems++;
-    if($currentitems == $totalitems)
-      update_progress_bar("diagnostic", 100, 100);
-    else
+    if($currentitems == $totalitems) {
+          update_progress_bar("diagnostic", 100, 100);
+    } else
     {
       $progress_bar_percent += ($itemweight / $GLOBALS['totalweight'] * 100);
       update_progress_bar("diagnostic", $progress_bar_percent, 100);
@@ -214,18 +218,21 @@ 
 			//perform this check when counter is set to two, which means it is on the 'value' column
 			if($counter == 2) {
 				//if the previous "name" column value was set to smtppass, set replace_val to true
-				if(strcmp($row[$counter - 1], "smtppass") == 0  )
-					$replace_val = true;
+				if(strcmp($row[$counter - 1], "smtppass") == 0  ) {
+									$replace_val = true;
+				}
 
 				//if the previous "name" column value was set to smtppass,
 				//and the "category" value set to ldap, set replace_val to true
-				if (strcmp($row[$counter - 2], "ldap") == 0 && strcmp($row[$counter - 1], "admin_password") == 0)
-					$replace_val = true;
+				if (strcmp($row[$counter - 2], "ldap") == 0 && strcmp($row[$counter - 1], "admin_password") == 0) {
+									$replace_val = true;
+				}
 
 				//if the previous "name" column value was set to password,
 				//and the "category" value set to proxy, set replace_val to true
-				if(strcmp($row[$counter - 2], "proxy") == 0 && strcmp($row[$counter - 1], "password") == 0 )
-					$replace_val = true;
+				if(strcmp($row[$counter - 2], "proxy") == 0 && strcmp($row[$counter - 1], "password") == 0 ) {
+									$replace_val = true;
+				}
 			}
 
 			if($replace_val) {
@@ -245,8 +252,9 @@ 
 // Deletes the directory recursively
 function deleteDir($dir)
 {
-   if (substr($dir, strlen($dir)-1, 1) != '/')
-       $dir .= '/';
+   if (substr($dir, strlen($dir)-1, 1) != '/') {
+          $dir .= '/';
+   }
 
    if ($handle = opendir($dir))
    {
@@ -256,21 +264,23 @@ 
            {
                if (is_dir($dir.$obj))
                {
-                   if (!deleteDir($dir.$obj))
-                       return false;
-               }
-               elseif (is_file($dir.$obj))
+                   if (!deleteDir($dir.$obj)) {
+                                          return false;
+                   }
+               } elseif (is_file($dir.$obj))
                {
-                   if (!unlink($dir.$obj))
-                       return false;
+                   if (!unlink($dir.$obj)) {
+                                          return false;
+                   }
                }
            }
        }
 
        closedir($handle);
 
-       if (!@rmdir($dir))
-           return false;
+       if (!@rmdir($dir)) {
+                  return false;
+       }
        return true;
    }
    return false;
@@ -301,10 +311,11 @@ 
 
 
 	//determine if files.md5 exists or not
-	if(file_exists('files.md5'))
-		$skip_md5_diff = false;
-	else
-		$skip_md5_diff = true;
+	if(file_exists('files.md5')) {
+			$skip_md5_diff = false;
+	} else {
+			$skip_md5_diff = true;
+	}
 
 	// array of all tables that we need to pull rows from below
 	$getDumpsFrom = array('config' => 'config',
@@ -392,8 +403,9 @@ 
 
 
     //create directory for table definitions
-    if($getschema)
-      $tablesSchemaDir = create_cache_directory("diagnostic/".$sod_guid."/diagnostic".$curdatetime."/{$db->dbName}/TableSchema/");
+    if($getschema) {
+          $tablesSchemaDir = create_cache_directory("diagnostic/".$sod_guid."/diagnostic".$curdatetime."/{$db->dbName}/TableSchema/");
+    }
 
     //make sure they checked the box to get basic info
     if($getinfo)
@@ -547,13 +559,13 @@ 
 		if(!isset($beanFiles[$beanz]))
 		{
 			echo "<font color=orange>NO! --- ".$beanz." is not an index in \$beanFiles</font><br>";
-		}
-		else
+		} else
 		{
-			if(file_exists($beanFiles[$beanz]))
-				echo "<font color=green>YES --- ".$beanz." file \"".$beanFiles[$beanz]."\" exists</font><br>";
-			else
-				echo "<font color=red>NO! --- ".$beanz." file \"".$beanFiles[$beanz]."\" does NOT exist</font><br>";
+			if(file_exists($beanFiles[$beanz])) {
+							echo "<font color=green>YES --- ".$beanz." file \"".$beanFiles[$beanz]."\" exists</font><br>";
+			} else {
+							echo "<font color=red>NO! --- ".$beanz." file \"".$beanFiles[$beanz]."\" does NOT exist</font><br>";
+			}
 		}
 	}
 
@@ -589,8 +601,9 @@ 
 	global $curdatetime;
 	global $skip_md5_diff;
 	global $sod_guid;
-	if(file_exists('files.md5'))
-        include( 'files.md5');
+	if(file_exists('files.md5')) {
+	        include( 'files.md5');
+	}
 	//create dir for md5s
 	$md5_directory = create_cache_directory("diagnostic/".$sod_guid."/diagnostic".$curdatetime."/md5/");
 
@@ -598,15 +611,17 @@ 
 	if(!$skip_md5_diff)
 	{
 		//make sure the files.md5
-		if($filesmd5)
-			if(!copy('files.md5', $md5_directory."files.md5"))
+		if($filesmd5) {
+					if(!copy('files.md5', $md5_directory."files.md5"))
 				echo "Couldn't copy files.md5 to ".$md5_directory."<br>Skipping md5 checks.<br>";
+		}
 	}
 
 	$md5_string_calculated = generateMD5array('./');
 
-	if($md5calculated)
-		write_array_to_file('md5_string_calculated', $md5_string_calculated, $md5_directory."md5_array_calculated.php");
+	if($md5calculated) {
+			write_array_to_file('md5_string_calculated', $md5_string_calculated, $md5_directory."md5_array_calculated.php");
+	}
 
 
 	//if the files.md5 didn't exist, we can't do this
@@ -668,8 +683,9 @@ 
 
     foreach($tables as $t) {
 	$name = $t;
-	if ( $name == "does_not_exist" )
-	  continue;
+	if ( $name == "does_not_exist" ) {
+		  continue;
+	}
 	$comment = $comments[$t];
 	echo "<h2>Table: $t</h2>
 		<p><i>{$comment}</i></p>";
@@ -686,8 +702,9 @@ 
 
 	foreach($fields[$t] as $k => $v) {
 	  // we only care about physical tables ('source' can be 'non-db' or 'nondb' or 'function' )
-	  if ( isset( $v[ 'source' ] ))
-	    continue;
+	  if ( isset( $v[ 'source' ] )) {
+	  	    continue;
+	  }
 	  $columnname = $v[ 'name' ];
 	  $columntype = $v[ 'type' ];
 	  $columndbtype = $v[ 'dbType' ];
@@ -695,13 +712,20 @@ 
 	  $columncomment = $v[ 'comment' ];
 	  $columnrequired = $v[ 'required' ];
 
-	  if ( empty( $columnlen ) ) $columnlen = '<i>n/a</i>';
-	  if ( empty( $columncomment ) ) $columncomment = '<i>(none)</i>';
-	  if ( !empty( $columndbtype ) ) $columntype = $columndbtype;
-	  if ( empty( $columnrequired ) || ( $columnrequired == false ))
-	    $columndisplayrequired = 'no';
-	  else
-	    $columndisplayrequired = 'yes';
+	  if ( empty( $columnlen ) ) {
+	      $columnlen = '<i>n/a</i>';
+	  }
+	  if ( empty( $columncomment ) ) {
+	      $columncomment = '<i>(none)</i>';
+	  }
+	  if ( !empty( $columndbtype ) ) {
+	      $columntype = $columndbtype;
+	  }
+	  if ( empty( $columnrequired ) || ( $columnrequired == false )) {
+	  	    $columndisplayrequired = 'no';
+	  } else {
+	  	    $columndisplayrequired = 'yes';
+	  }
 
 	  echo '<TR BGCOLOR="#FFFFFF" ALIGN=left>
 			<TD ALIGN=left class=\"tabDetailViewDF\">'.$columnname.'</TD>