adamjakab / SuiteCRM

include/generic/SugarWidgets/SugarWidgetFieldmultienum.php

Spacing +10 added lines, -10 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -42,22 +42,22 @@ 
 
 class SugarWidgetFieldMultiEnum extends SugarWidgetFieldEnum {
 	public function queryFilternot_one_of(&$layout_def) {
-		$arr = array ();
+		$arr = array();
 		foreach ($layout_def['input_name0'] as $value) {
 			array_push($arr, "'".$GLOBALS['db']->quote($value)."'");
 		}
 	    $reporter = $this->layout_manager->getAttribute("reporter");
 
-    	$col_name = $this->_get_column_select($layout_def) . " NOT LIKE " ;
+    	$col_name = $this->_get_column_select($layout_def)." NOT LIKE ";
     	$arr_count = count($arr);
     	$query = "";
-    	foreach($arr as $key=>$val) {
+    	foreach ($arr as $key=>$val) {
     		$query .= $col_name;
 			$value = preg_replace("/^'/", "'%", $val, 1);
 			$value = preg_replace("/'$/", "%'", $value, 1);
 			$query .= $value;
 			if ($key != ($arr_count - 1))
-    			$query.= " OR " ;	
+    			$query .= " OR ";	
     	}
 		return '('.$query.')';        
 	}
@@ -66,24 +66,24 @@ 
         //Fix for inaccurate filtering of contacts in Contacts dashlet on multiselects.
         $arr = array();
         foreach ($layout_def['input_name0'] as $value) {
-            if($value != ""){
+            if ($value != "") {
                 array_push($arr, "'".$GLOBALS['db']->quote($value)."'");
-            }else{
+            } else {
                 array_push($arr, "'^^'");
             }
         }
 	    $reporter = $this->layout_manager->getAttribute("reporter");
 
-    	$col_name = $this->_get_column_select($layout_def) . " LIKE " ;
+    	$col_name = $this->_get_column_select($layout_def)." LIKE ";
     	$arr_count = count($arr);
     	$query = "";
-    	foreach($arr as $key=>$val) {
+    	foreach ($arr as $key=>$val) {
     		$query .= $col_name;
 			$value = preg_replace("/^'/", "'%", $val, 1);
 			$value = preg_replace("/'$/", "%'", $value, 1);
 			$query .= $value;
 			if ($key != ($arr_count - 1))
-    			$query.= " OR " ;	
+    			$query .= " OR ";	
     	}
 		return '('.$query.')';        
 	}

include/generic/SugarWidgets/SugarWidgetFieldvarchar.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -77,15 +77,15 @@ 
  
  function queryFilterone_of(&$layout_def)
  {
-    foreach($layout_def['input_name0'] as $key => $value) {
+    foreach ($layout_def['input_name0'] as $key => $value) {
         $layout_def['input_name0'][$key] = $GLOBALS['db']->quote($value); 
     }
-    return $this->_get_column_select($layout_def) . " IN ('" . implode("','", $layout_def['input_name0']) . "')\n";
+    return $this->_get_column_select($layout_def)." IN ('".implode("','", $layout_def['input_name0'])."')\n";
  }
   
  function displayInput(&$layout_def) 
  {
- 		$str = '<input type="text" size="20" value="' . $layout_def['input_name0'] . '" name="' . $layout_def['name'] . '">';
+ 		$str = '<input type="text" size="20" value="'.$layout_def['input_name0'].'" name="'.$layout_def['name'].'">';
  		return $str;
  }
 }

include/generic/SugarWidgets/SugarWidgetFielddate.php

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,9 +46,9 @@ 
     {
         global $timedate;
         // i guess qualifier and column_function are the same..
-        if (! empty($layout_def['column_function'])) {
+        if (!empty($layout_def['column_function'])) {
             $func_name = 'displayList'.$layout_def['column_function'];
-            if ( method_exists($this,$func_name)) {
+            if (method_exists($this, $func_name)) {
                 $display = $this->$func_name($layout_def);
                 return $display;
             }

include/generic/SugarWidgets/SugarWidget.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -77,7 +77,7 @@ 
 	 * This is a utility function to set the id for a widget
 	 * @param id String value to set the widget's unique id
 	 */
-	public function setWidgetId($id='') {
+	public function setWidgetId($id = '') {
 		$this->widget_id = $id;
 	}
 
@@ -103,11 +103,11 @@ 
     */
     protected function getTruncatedColumnAlias($column_name)
     {
-	  	if(empty($column_name) || !is_string($column_name) || strlen($column_name) < 28)
+	  	if (empty($column_name) || !is_string($column_name) || strlen($column_name) < 28)
 	  	{
 	  	   return $column_name;
 	  	}
-	    return strtoupper(substr($column_name,0,22) . substr(md5(strtolower($column_name)), 0, 6));
+	    return strtoupper(substr($column_name, 0, 22).substr(md5(strtolower($column_name)), 0, 6));
     }
 }
 

include/generic/SugarWidgets/SugarWidgetFieldfloat.php

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,7 +46,7 @@ 
  	
     $vardef = $this->getVardef($layout_def);
 
-    if ( isset($vardef['precision']) ) {
+    if (isset($vardef['precision'])) {
         $precision = $vardef['precision'];
     } else {
         $precision = null;
@@ -80,7 +80,7 @@ 
 
  function queryFilterBetween(&$layout_def)
  {
-	return $this->_get_column_select($layout_def)." BETWEEN ".$GLOBALS['db']->quote(unformat_number($layout_def['input_name0'])). " AND " . $GLOBALS['db']->quote(unformat_number($layout_def['input_name1'])) . "\n";
+	return $this->_get_column_select($layout_def)." BETWEEN ".$GLOBALS['db']->quote(unformat_number($layout_def['input_name0']))." AND ".$GLOBALS['db']->quote(unformat_number($layout_def['input_name1']))."\n";
  }
 
 

include/generic/SugarWidgets/SugarWidgetFieldsingleenum.php

Spacing +7 added lines, -7 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,17 +46,17 @@ 
     function displayInput(&$layout_def) {
         global $app_list_strings;
 
-        if(!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
-            if ( is_array($layout_def['options']) ) {
+        if (!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
+            if (is_array($layout_def['options'])) {
                 $ops = $layout_def['options'];
             }
-            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){ 
+            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])) { 
             	$ops = $app_list_strings[$layout_def['options']];
-                if(array_key_exists('', $app_list_strings[$layout_def['options']])) {
+                if (array_key_exists('', $app_list_strings[$layout_def['options']])) {
              	   unset($ops['']);
 	            }
             }
-            else{
+            else {
             	$ops = array();
             }
         }
@@ -64,7 +64,7 @@ 
             $ops = $app_list_strings[$layout_def['options']];
         }
         
-        $str = '<select name="' . $layout_def['name'] . '">';
+        $str = '<select name="'.$layout_def['name'].'">';
         $str .= get_select_options_with_id($ops, $layout_def['input_name0']);
         $str .= '</select>';
         return $str;

include/generic/SugarWidgets/SugarWidgetReportField.php

Spacing +47 added lines, -47 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,7 +61,7 @@ 
 
 	function  getSubClass($layout_def)
 	{
-		if (! empty($layout_def['type']))
+		if (!empty($layout_def['type']))
 		{
 
 			if ($layout_def['type'] == 'time') {
@@ -80,11 +80,11 @@ 
  {
         $obj = $this->getSubClass($layout_def);
 
-        $context = $this->layout_manager->getAttribute('context');//_ppd($context);
+        $context = $this->layout_manager->getAttribute('context'); //_ppd($context);
         $func_name = 'display'.$context;
 
 
-        if ( ! empty($context) && method_exists($obj,$func_name))
+        if (!empty($context) && method_exists($obj, $func_name))
         {
                 return  $obj->$func_name($layout_def);
         } else
@@ -96,20 +96,20 @@ 
  function _get_column_select_special($layout_def)
  {
  		$alias = '';
-		 if ( ! empty($layout_def['table_alias']))
+		 if (!empty($layout_def['table_alias']))
 		 {
 			$alias = $layout_def['table_alias'];
 		 }
 
-    if ($layout_def['name'] == 'weighted_sum' )
+    if ($layout_def['name'] == 'weighted_sum')
     {
-        return sprintf("SUM(%s * %s * 0.01)", $this->reporter->db->convert("$alias.probability","IFNULL", array(0)),
-            $this->reporter->db->convert("$alias.amount_usdollar","IFNULL", array(0)));
+        return sprintf("SUM(%s * %s * 0.01)", $this->reporter->db->convert("$alias.probability", "IFNULL", array(0)),
+            $this->reporter->db->convert("$alias.amount_usdollar", "IFNULL", array(0)));
 	}
-    if ($layout_def['name'] == 'weighted_amount' )
+    if ($layout_def['name'] == 'weighted_amount')
     {
-        return sprintf("AVG(%s * %s * 0.01)", $this->reporter->db->convert("$alias.probability","IFNULL", array(0)),
-            $this->reporter->db->convert("$alias.amount_usdollar","IFNULL", array(0)));
+        return sprintf("AVG(%s * %s * 0.01)", $this->reporter->db->convert("$alias.probability", "IFNULL", array(0)),
+            $this->reporter->db->convert("$alias.amount_usdollar", "IFNULL", array(0)));
 	}
  }
 
@@ -120,15 +120,15 @@ 
  		$reportAlias = array();
  	}
 
-	if ( ! empty($layout_def['table_alias'])) {
+	if (!empty($layout_def['table_alias'])) {
 		$alias = $layout_def['table_alias'].".".$layout_def['name'];
-	} else if (! empty($layout_def['name'])) {
+	} else if (!empty($layout_def['name'])) {
 		$alias = $layout_def['name'];
 	} else {
 		$alias = "*";
 	}
 
-	if ( ! empty($layout_def['group_function']) )
+	if (!empty($layout_def['group_function']))
 	{
     	if ($layout_def['name'] == 'weighted_sum' || $layout_def['name'] == 'weighted_amount')
     	{
@@ -153,7 +153,7 @@ 
             if ($layout_def['group_function'] != 'avg') {
                 $alias = "{$layout_def['group_function']}($alias/{$query})*{$currency->conversion_rate}";
             } else {
-                $alias = $this->reporter->db->convert("$alias/$query", "AVG") . " * {$currency->conversion_rate}";
+                $alias = $this->reporter->db->convert("$alias/$query", "AVG")." * {$currency->conversion_rate}";
             }
         } else {
             // We need to use convert() for AVG because of Oracle
@@ -184,7 +184,7 @@ 
  function queryOrderBy($layout_def)
  {
      $field_def = array();
-	if(!empty($this->reporter->all_fields[$layout_def['column_key']])) $field_def = $this->reporter->all_fields[$layout_def['column_key']];
+	if (!empty($this->reporter->all_fields[$layout_def['column_key']])) $field_def = $this->reporter->all_fields[$layout_def['column_key']];
 
     if (!empty($layout_def['group_function']))
     {
@@ -193,8 +193,8 @@ 
     elseif (!empty($field_def['sort_on']))
 	{
 			$order_by = $layout_def['table_alias'].".".$field_def['sort_on'];
-            if(!empty($field_def['sort_on2']))
-                $order_by .= ', ' . $layout_def['table_alias'].".".$field_def['sort_on2'];
+            if (!empty($field_def['sort_on2']))
+                $order_by .= ', '.$layout_def['table_alias'].".".$field_def['sort_on2'];
     }
 	else {
 		$order_by = $this->_get_column_alias($layout_def)." \n";
@@ -203,10 +203,10 @@ 
      //use sugar db function convert on order by string to convert to varchar.  This is mainly for db's
      //that do not allow sorting on clob/text fields
     if ($this->reporter->db->isTextType($this->reporter->db->getFieldType($field_def))) {
-        $order_by = $this->reporter->db->convert($order_by,'text2char', array(10000)); // array(10000) is for db2 only
+        $order_by = $this->reporter->db->convert($order_by, 'text2char', array(10000)); // array(10000) is for db2 only
     }
 
-			if ( empty($layout_def['sort_dir']) || $layout_def['sort_dir'] == 'a')
+			if (empty($layout_def['sort_dir']) || $layout_def['sort_dir'] == 'a')
 			{
 				return $order_by." ASC";
 			} else {
@@ -223,27 +223,27 @@ 
 
 	function displayHeaderCell($layout_def)
 	{
-				global $start_link_wrapper,$end_link_wrapper;
+				global $start_link_wrapper, $end_link_wrapper;
 
 
                 // don't show sort links if name isn't defined
                 $no_sort = $this->layout_manager->getAttribute('no_sort');
-                if(empty($layout_def['name']) || ! empty($no_sort) || ! empty($layout_def['no_sort']))
+                if (empty($layout_def['name']) || !empty($no_sort) || !empty($layout_def['no_sort']))
                 {
                         return $layout_def['label'];
                 }
 
 
 
-                $sort_by ='';
-                if ( ! empty($layout_def['table_key']) && ! empty($layout_def['name']) ) {
-                	if (! empty($layout_def['group_function']) && $layout_def['group_function'] == 'count') {
+                $sort_by = '';
+                if (!empty($layout_def['table_key']) && !empty($layout_def['name'])) {
+                	if (!empty($layout_def['group_function']) && $layout_def['group_function'] == 'count') {
                         $sort_by = $layout_def['table_key'].":".'count';
                 	} else {
                     	$sort_by = $layout_def['table_key'].":".$layout_def['name'];
-                        if ( ! empty($layout_def['column_function'])) {
+                        if (!empty($layout_def['column_function'])) {
                         	$sort_by .= ':'.$layout_def['column_function'];
-                		} else if ( ! empty($layout_def['group_function']) ) {
+                		} else if (!empty($layout_def['group_function'])) {
                         	$sort_by .= ':'.$layout_def['group_function'];
                 		}
                 	}
@@ -251,12 +251,12 @@ 
                 	return $this->displayHeaderCellPlain($layout_def);
                 }
 
-                $start = empty($start_link_wrapper) ? '': $start_link_wrapper;
-				$end = empty($end_link_wrapper) ? '': $end_link_wrapper;
+                $start = empty($start_link_wrapper) ? '' : $start_link_wrapper;
+				$end = empty($end_link_wrapper) ? '' : $end_link_wrapper;
 
                 // unable to retrieve the vardef here, exclude columns of type clob/text from being sortable
 
-                if(!in_array($layout_def['name'], array('description', 'account_description', 'lead_source_description', 'status_description', 'to_addrs', 'cc_addrs', 'bcc_addrs', 'work_log', 'objective', 'resolution'))) {
+                if (!in_array($layout_def['name'], array('description', 'account_description', 'lead_source_description', 'status_description', 'to_addrs', 'cc_addrs', 'bcc_addrs', 'work_log', 'objective', 'resolution'))) {
                     $header_cell = "<a class=\"listViewThLinkS1\" href=\"".$start.$sort_by.$end."\">";
                     $header_cell .= $this->displayHeaderCellPlain($layout_def);
                     $objListView = new ListView();
@@ -276,7 +276,7 @@ 
         	$context = $this->layout_manager->getAttribute('context');
        	 	$func_name = 'query'.$context;
 
-        	if ( ! empty($context) && method_exists($obj,$func_name))
+        	if (!empty($context) && method_exists($obj, $func_name))
        		 {
                		 return  $obj->$func_name($layout_def);
         	} else
@@ -296,44 +296,44 @@ 
 
      // Bug: 44605
      // this comment is being added to trigger the upgrade package
-        if ( ! empty($layout_def['group_function']) && $layout_def['group_function']=='count')
+        if (!empty($layout_def['group_function']) && $layout_def['group_function'] == 'count')
         {
-                return $layout_def['table_alias'] . '__count';
+                return $layout_def['table_alias'].'__count';
         }
 
-        if ( ! empty($layout_def['table_alias']))
+        if (!empty($layout_def['table_alias']))
         {
-                array_push($alias_arr,$layout_def['table_alias']);
+                array_push($alias_arr, $layout_def['table_alias']);
         }
 
-        if ( ! empty($layout_def['group_function']) && $layout_def['group_function'] != 'weighted_amount' && $layout_def['group_function'] != 'weighted_sum')
+        if (!empty($layout_def['group_function']) && $layout_def['group_function'] != 'weighted_amount' && $layout_def['group_function'] != 'weighted_sum')
         {
-                array_push($alias_arr,$layout_def['group_function']);
-        } else if ( ! empty($layout_def['column_function']))
+                array_push($alias_arr, $layout_def['group_function']);
+        } else if (!empty($layout_def['column_function']))
         {
-                array_push($alias_arr,$layout_def['column_function']);
-        } else if ( ! empty($layout_def['qualifier']))
+                array_push($alias_arr, $layout_def['column_function']);
+        } else if (!empty($layout_def['qualifier']))
         {
-                array_push($alias_arr,$layout_def['qualifier']);
+                array_push($alias_arr, $layout_def['qualifier']);
         }
 
-        if ( ! empty($layout_def['name']))
+        if (!empty($layout_def['name']))
         {
-                array_push($alias_arr,$layout_def['name']);
+                array_push($alias_arr, $layout_def['name']);
         }
 
 		global $used_aliases, $alias_map;
 
-        $alias = strtolower(implode("_",$alias_arr));
+        $alias = strtolower(implode("_", $alias_arr));
 
         $short_alias = $this->getTruncatedColumnAlias($alias);
 
-		if ( empty($used_aliases[$short_alias]))
+		if (empty($used_aliases[$short_alias]))
 		{
 			$alias_map[$alias] = $short_alias;
 		    $used_aliases[$short_alias] = 1;
           	return $short_alias;
-		} else if ( ! empty($alias_map[$alias]) )
+		} else if (!empty($alias_map[$alias]))
 		{
 			return $alias_map[$alias];
 		} else {
@@ -364,7 +364,7 @@ 
      /** @var $db DBManager */
      $db = $this->reporter->db;
      $column = $this->_get_column_select($layout_def);
-     return "(coalesce(" . $db->convert($column, "length") . ",0) > 0)\n";
+     return "(coalesce(".$db->convert($column, "length").",0) > 0)\n";
  }
 
 }

include/generic/SugarWidgets/SugarWidgetSubPanelTopCreateCampaignLogEntryButton.php

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,7 +46,7 @@ 
 {
     public function getWidgetId($buttonSuffix = true)
     {
-        return parent::getWidgetId() . '_select_button';
+        return parent::getWidgetId().'_select_button';
     }
 
     function display($widget_data)
@@ -59,7 +59,7 @@ 
 
         $this->title = $app_strings['LBL_SELECT_BUTTON_TITLE'];
         $this->value = $app_strings['LBL_SELECT_BUTTON_LABEL'];
-        $this->module = 'Campaigns';//'CampaignLog';
+        $this->module = 'Campaigns'; //'CampaignLog';
         $this->module_name = 'Campaigns';
 
 
@@ -68,52 +68,52 @@ 
 
 
         $focus = $widget_data['focus'];
-        if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
-            $button = ' <input type="button" name="' . $this->getWidgetId() . '" id="' . $this->getWidgetId() . '" class="button"' . "\n"
-            . ' title="' . $this->title . '"'
-            . ' value="' . $this->value . "\"\n"
+        if (ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)) {
+            $button = ' <input type="button" name="'.$this->getWidgetId().'" id="'.$this->getWidgetId().'" class="button"'."\n"
+            . ' title="'.$this->title.'"'
+            . ' value="'.$this->value."\"\n"
             .' disabled />';
             return $button;
         }
 
         //refresh the whole page after end of action?
         $refresh_page = 0;
-        if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
+        if (!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])) {
             $refresh_page = 1;
         }
 
         $subpanel_definition = $widget_data['subpanel_definition'];
         $button_definition = $subpanel_definition->get_buttons();
-        $subpanel_name = $this->module;    //"Campaigns";//$subpanel_definition->get_module_name();
+        $subpanel_name = $this->module; //"Campaigns";//$subpanel_definition->get_module_name();
         if (empty($this->module_name)) {
             $this->module_name = $subpanel_name;
         }
         $link_field_name = $subpanel_definition->get_data_source_name(true);
-        $popup_mode='multiselect';
-        if(isset($widget_data['mode'])){
-            $popup_mode=$widget_data['mode'];
+        $popup_mode = 'multiselect';
+        if (isset($widget_data['mode'])) {
+            $popup_mode = $widget_data['mode'];
         }
-        if(isset($widget_data['initial_filter_fields'])){
+        if (isset($widget_data['initial_filter_fields'])) {
             if (is_array($widget_data['initial_filter_fields'])) {
                 foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
                     if (isset($focus->$value) and !empty($focus->$value)) {
-                        $initial_filter.="&".$alias . '='.urlencode($focus->$value);
+                        $initial_filter .= "&".$alias.'='.urlencode($focus->$value);
                     }
                 }
             }
         }
-        $create="true";
-        if(isset($widget_data['create'])){
-            $create=$widget_data['create'];
+        $create = "true";
+        if (isset($widget_data['create'])) {
+            $create = $widget_data['create'];
         }
         $return_module = $_REQUEST['module'];
         $return_action = 'SubPanelViewer';
         $return_id = $_REQUEST['record'];
 
         //field_to_name_array
-        $fton_array= array('id' => 'subpanel_id');
-        if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
-            $fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
+        $fton_array = array('id' => 'subpanel_id');
+        if (isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])) {
+            $fton_array = array_merge($fton_array, $widget_data['field_to_name_array']);
         }
 
         $return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
@@ -132,20 +132,20 @@ 
         );
 
         if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
-            $popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
+            $popup_request_data['passthru_data'] = array_merge($popup_request_data['passthru_data'], $this->button_properties['add_to_passthru_data']);
         }
 
         if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
 
-            if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
-                $initial_filter = "&module_name=". urlencode($widget_data['module']);
+            if ($this->button_properties['add_to_passthru_data']['return_type'] == 'report') {
+                $initial_filter = "&module_name=".urlencode($widget_data['module']);
             }
         }
         $json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
-        return '<form action="index.php?module=CampaignLog&action=AddCampaignLog&type=contact">' . "\n"
-            . ' <input type="button" name="' . $this->getWidgetId() . '_select_button" id="' . $this->getWidgetId() . '" class="button"' . "\n"
-                . ' title="' . $this->title . '"'
-            . ' value="' . $this->value . "\"\n"
+        return '<form action="index.php?module=CampaignLog&action=AddCampaignLog&type=contact">'."\n"
+            . ' <input type="button" name="'.$this->getWidgetId().'_select_button" id="'.$this->getWidgetId().'" class="button"'."\n"
+                . ' title="'.$this->title.'"'
+            . ' value="'.$this->value."\"\n"
             . " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
     }
 }

include/generic/SugarWidgets/SugarWidgetFieldenum.php

Spacing +32 added lines, -32 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -48,13 +48,13 @@ 
     public function queryFilterEmpty($layout_def)
     {
         $column = $this->_get_column_select($layout_def);
-        return "(coalesce(" . $this->reporter->db->convert($column, "length") . ",0) = 0 OR $column = '^^')";
+        return "(coalesce(".$this->reporter->db->convert($column, "length").",0) = 0 OR $column = '^^')";
     }
 
     public function queryFilterNot_Empty($layout_def)
     {
         $column = $this->_get_column_select($layout_def);
-        return "(coalesce(" . $this->reporter->db->convert($column, "length") . ",0) > 0 AND $column != '^^' )\n";
+        return "(coalesce(".$this->reporter->db->convert($column, "length").",0) > 0 AND $column != '^^' )\n";
     }
 
     public function queryFilteris($layout_def) {
@@ -74,7 +74,7 @@ 
 	}
 
 	public function queryFilterone_of($layout_def) {
-		$arr = array ();
+		$arr = array();
 		foreach ($layout_def['input_name0'] as $value) {
 			$arr[] = $this->reporter->db->quoted($value);
 		}
@@ -83,7 +83,7 @@ 
 	}
 
 	public function queryFilternot_one_of($layout_def) {
-		$arr = array ();
+		$arr = array();
 		foreach ($layout_def['input_name0'] as $value) {
 			$arr[] = $this->reporter->db->quoted($value);
 		}
@@ -93,9 +93,9 @@ 
 	}
 
     function & displayList($layout_def) {
-        if(!empty($layout_def['column_key'])){
+        if (!empty($layout_def['column_key'])) {
             $field_def = $this->reporter->all_fields[$layout_def['column_key']];
-        }else if(!empty($layout_def['fields'])){
+        } else if (!empty($layout_def['fields'])) {
             $field_def = $layout_def['fields'];
         }
         $cell = $this->displayListPlain($layout_def);
@@ -114,11 +114,11 @@ 
                 $record = $layout_def['fields'][$key];
                 $field_name = $field_def['name'];
                 $field_type = $field_def['type'];
-                $div_id = $field_def['module'] ."&$record&$field_name";
-                $str = "<div id='$div_id'>" . $cell . "&nbsp;"
+                $div_id = $field_def['module']."&$record&$field_name";
+                $str = "<div id='$div_id'>".$cell."&nbsp;"
                      . SugarThemeRegistry::current()->getImage(
                         "edit_inline",
-                        "border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(" .
+                        "border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(".
                         "\"$div_id\",\"$cell\",\"$module\",\"$record\",\"$field_name\",\"$field_type\");'"
                        )
                      . "</div>";
@@ -127,25 +127,25 @@ 
         return $str;
     }
 	function & displayListPlain($layout_def) {
-		if(!empty($layout_def['column_key'])){
+		if (!empty($layout_def['column_key'])) {
 			$field_def = $this->reporter->all_fields[$layout_def['column_key']];
-		}else if(!empty($layout_def['fields'])){
+		} else if (!empty($layout_def['fields'])) {
 			$field_def = $layout_def['fields'];
 		}
 
-		if (!empty($layout_def['table_key'] ) &&( empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))){
+		if (!empty($layout_def['table_key']) && (empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))) {
 			$value = $this->_get_list_value($layout_def);
-		}else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
+		} else if (!empty($layout_def['name']) && !empty($layout_def['fields'])) {
 			$key = strtoupper($layout_def['name']);
 			$value = $layout_def['fields'][$key];
 		}
 		$cell = '';
 
-			if(isset($field_def['options'])){
+			if (isset($field_def['options'])) {
 				$cell = translate($field_def['options'], $field_def['module'], $value);
-			}else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
+			} else if (isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
 	            global $beanFiles;
-	            if(empty($beanFiles)) {
+	            if (empty($beanFiles)) {
 	                include('include/modules.php');
 	            }
 	            $bean_name = get_singular_bean_name($field_def['module']);
@@ -157,14 +157,14 @@ 
 
 			//#22632
 			$value = unencodeMultienum($value);
-			$cell=array();
-			foreach($value as $val){
-				$returnVal = translate($field_def['options'],$field_def['module'],$val);
-				if(!is_array($returnVal)){
-					array_push( $cell, translate($field_def['options'],$field_def['module'],$val));
+			$cell = array();
+			foreach ($value as $val) {
+				$returnVal = translate($field_def['options'], $field_def['module'], $val);
+				if (!is_array($returnVal)) {
+					array_push($cell, translate($field_def['options'], $field_def['module'], $val));
 				}
 			}
-			$cell = implode(", ",$cell);
+			$cell = implode(", ", $cell);
 		}
 		return $cell;
 	}
@@ -177,11 +177,11 @@ 
 			$order_by = $this->_get_column_select($layout_def);
 		}
 		$list = array();
-        if(isset($field_def['options'])) {
+        if (isset($field_def['options'])) {
 		    $list = translate($field_def['options'], $field_def['module']);
-        } elseif(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
+        } elseif (isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
 	        global $beanFiles;
-		    if(empty($beanFiles)) {
+		    if (empty($beanFiles)) {
 		        include('include/modules.php');
 		    }
 		    $bean_name = get_singular_bean_name($field_def['module']);
@@ -199,17 +199,17 @@ 
     public function displayInput($layout_def) {
         global $app_list_strings;
 
-        if(!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
-            if ( isset($layout_def['options']) &&  is_array($layout_def['options']) ) {
+        if (!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
+            if (isset($layout_def['options']) && is_array($layout_def['options'])) {
                 $ops = $layout_def['options'];
             }
-            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
+            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])) {
             	$ops = $app_list_strings[$layout_def['options']];
-                if(array_key_exists('', $app_list_strings[$layout_def['options']])) {
+                if (array_key_exists('', $app_list_strings[$layout_def['options']])) {
              	   unset($ops['']);
 	            }
             }
-            else{
+            else {
             	$ops = array();
             }
         }
@@ -217,7 +217,7 @@ 
             $ops = $app_list_strings[$layout_def['options']];
         }
 
-        $str = '<select multiple="true" size="3" name="' . $layout_def['name'] . '[]">';
+        $str = '<select multiple="true" size="3" name="'.$layout_def['name'].'[]">';
         $str .= get_select_options_with_id($ops, $layout_def['input_name0']);
         $str .= '</select>';
         return $str;