Test Failed
Push — CI ( 02428e...3e0292 )
by Adam
55:43
created
service/core/REST/SugarRestRSS.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -64,6 +64,9 @@
 block discarded – undo
64 64
 		$this->generateResponseFooter();
65 65
 	} // fn
66 66
 
67
+	/**
68
+	 * @param integer $count
69
+	 */
67 70
 	protected function generateResponseHeader($count)
68 71
 	{
69 72
 	    global $app_strings, $sugar_version, $sugar_flavor;
Please login to merge, or discard this patch.
service/core/SoapHelperWebService.php 1 patch
Doc Comments   +19 added lines, -5 removed lines patch added patch discarded remove patch
@@ -154,8 +154,8 @@  discard block
 block discarded – undo
154 154
  *
155 155
  * @param string $user_name -- The user name to create a session for
156 156
  * @param string $password -- The MD5 sum of the user's password
157
- * @return true -- If the session is created
158
- * @return false -- If the session is not created
157
+ * @return boolean|null -- If the session is created
158
+ * @return boolean|null -- If the session is not created
159 159
  */
160 160
 function validate_user($user_name, $password){
161 161
 	$GLOBALS['log']->info('Begin: SoapHelperWebServices->validate_user');
@@ -193,8 +193,8 @@  discard block
 block discarded – undo
193 193
 	 * Validate the provided session information is correct and current.  Load the session.
194 194
 	 *
195 195
 	 * @param String $session_id -- The session ID that was returned by a call to login.
196
-	 * @return true -- If the session is valid and loaded.
197
-	 * @return false -- if the session is not valid.
196
+	 * @return boolean -- If the session is valid and loaded.
197
+	 * @return boolean -- if the session is not valid.
198 198
 	 */
199 199
 	function validate_authenticated($session_id){
200 200
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->validate_authenticated');
@@ -303,6 +303,11 @@  discard block
 block discarded – undo
303 303
 		return true;
304 304
 	} // fn
305 305
 
306
+	/**
307
+	 * @param string $viewType
308
+	 * @param SoapError $errorObject
309
+	 * @param string $error_key
310
+	 */
306 311
 	function checkACLAccess($bean, $viewType, $errorObject, $error_key) {
307 312
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->checkACLAccess');
308 313
 		if(!$bean->ACLAccess($viewType)) {
@@ -316,6 +321,9 @@  discard block
 block discarded – undo
316 321
 		return true;
317 322
 	} // fn
318 323
 
324
+	/**
325
+	 * @param SoapError $errorObject
326
+	 */
319 327
 	function checkQuery($errorObject, $query, $order_by = '')
320 328
     {
321 329
         require_once 'include/SugarSQLValidate.php';
@@ -695,7 +703,7 @@  discard block
 block discarded – undo
695 703
 	 * @param Array $related_ids -- The array of ids for which we want to create relationships
696 704
 	 * @param Array $name_value_list -- The array of name value pair of additional attributes to be set when adding this relationship
697 705
 	 * @param int delete -- If 0 then add relationship else delete this relationship data
698
-	 * @return true on success, false on failure
706
+	 * @return boolean on success, false on failure
699 707
 	 */
700 708
 	function new_handle_set_relationship($module_name, $module_id, $link_field_name, $related_ids, $name_value_list, $delete) {
701 709
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->new_handle_set_relationship');
@@ -743,6 +751,9 @@  discard block
 block discarded – undo
743 751
 		}
744 752
 	}
745 753
 
754
+	/**
755
+	 * @param string $module_name
756
+	 */
746 757
 	function new_handle_set_entries($module_name, $name_value_lists, $select_fields = FALSE) {
747 758
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->new_handle_set_entries');
748 759
 		global $beanList, $beanFiles, $current_user, $app_list_strings;
@@ -907,6 +918,9 @@  discard block
 block discarded – undo
907 918
 	}
908 919
 
909 920
 
921
+	/**
922
+	 * @param string $module
923
+	 */
910 924
 	function get_return_module_fields($value, $module,$fields, $translate=true){
911 925
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->get_return_module_fields');
912 926
 		global $module_name;
Please login to merge, or discard this patch.
service/core/SugarRestService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,6 @@
 block discarded – undo
177 177
 	 * This function registers implementation class name and creates an instance of rest implementation class
178 178
 	 * it will be made on this class object
179 179
 	 *
180
-	 * @param String $implementationClass
181 180
 	 * @access public
182 181
 	 */
183 182
 	function registerImplClass($className){
Please login to merge, or discard this patch.
service/core/SugarWebServiceImpl.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
  *
74 74
  * @param String $session -- Session ID returned by a previous call to login.
75 75
  * @param String $module_name -- The name of the module to return records from.  This name should be the name the module was developed under (changing a tab name is studio does not affect the name that should be passed into this method)..
76
- * @param Array $ids -- An array of SugarBean IDs.
76
+ * @param string[] $ids -- An array of SugarBean IDs.
77 77
  * @param Array $select_fields -- A list of the fields to be included in the results. This optional parameter allows for only needed fields to be retrieved.
78 78
 * @param Array $link_name_to_fields_array -- A list of link_names and for each link_name, what fields value to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address')))
79 79
 * @return Array
Please login to merge, or discard this patch.
service/v3/SugarWebServiceImplv3.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -309,7 +309,7 @@
 block discarded – undo
309 309
      * Retrieve a list of recently viewed records by module.
310 310
      *
311 311
      * @param String $session -- Session ID returned by a previous call to login.
312
-     * @param String $modules -- An array of modules or 'Home' to indicate all.
312
+     * @param String $module_names -- An array of modules or 'Home' to indicate all.
313 313
      * @return Array The recently viewed records
314 314
      * @exception 'SoapFault' -- The SOAP error, if any
315 315
      */
Please login to merge, or discard this patch.
service/v3_1/SugarWebServiceImplv3_1.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     * @param String $id -- The SugarBean's ID value.
62 62
     * @param Array  $select_fields -- A list of the fields to be included in the results. This optional parameter allows for only needed fields to be retrieved.
63 63
     * @param Array $link_name_to_fields_array -- A list of link_names and for each link_name, what fields value to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address')))
64
-    * @param bool $trackView -- Should we track the record accessed.
64
+    * @param bool $track_view -- Should we track the record accessed.
65 65
     * @return Array
66 66
     *        'entry_list' -- Array - The records name value pair for the simple data types excluding link field data.
67 67
     *	     'relationship_list' -- Array - The records link field data. The example is if asked about accounts email address then return data would look like Array ( [0] => Array ( [name] => email_addresses [records] => Array ( [0] => Array ( [0] => Array ( [name] => id [value] => 3fb16797-8d90-0a94-ac12-490b63a6be67 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 1 ) ) [1] => Array ( [0] => Array ( [name] => id [value] => 403f8da1-214b-6a88-9cef-490b63d43566 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 0 ) ) ) ) )
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     * @param Array $ids -- An array of SugarBean IDs.
126 126
     * @param Array $select_fields -- A list of the fields to be included in the results. This optional parameter allows for only needed fields to be retrieved.
127 127
     * @param Array $link_name_to_fields_array -- A list of link_names and for each link_name, what fields value to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address')))
128
-    * @param bool $trackView -- Should we track the record accessed.
128
+    * @param bool $track_view -- Should we track the record accessed.
129 129
     * @return Array
130 130
     *        'entry_list' -- Array - The records name value pair for the simple data types excluding link field data.
131 131
     *	     'relationship_list' -- Array - The records link field data. The example is if asked about accounts email address then return data would look like Array ( [0] => Array ( [name] => email_addresses [records] => Array ( [0] => Array ( [0] => Array ( [name] => id [value] => 3fb16797-8d90-0a94-ac12-490b63a6be67 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 1 ) ) [1] => Array ( [0] => Array ( [name] => id [value] => 403f8da1-214b-6a88-9cef-490b63d43566 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 0 ) ) ) ) )
Please login to merge, or discard this patch.
service/v4/SugarWebServiceUtilv4.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	/**
144 144
 	 * Processes the filter_fields attribute to use with SugarBean::create_new_list_query()
145 145
 	 *
146
-	 * @param object $value SugarBean
146
+	 * @param SugarBean $value SugarBean
147 147
 	 * @param array $fields
148 148
 	 * @return array
149 149
 	 */
@@ -454,6 +454,12 @@  discard block
 block discarded – undo
454 454
 	}
455 455
 
456 456
 
457
+    /**
458
+     * @param string $login_error_key
459
+     * @param string $access_level
460
+     * @param string $module_access_level_error_key
461
+     * @param SoapError $errorObject
462
+     */
457 463
     function checkSessionAndModuleAccess($session, $login_error_key, $module_name, $access_level, $module_access_level_error_key, $errorObject)
458 464
     {
459 465
           if(isset($_REQUEST['oauth_token'])) {
Please login to merge, or discard this patch.
service/v4_1/SugarWebServiceImplv4_1.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
      * @param Array $related_module_link_name_to_fields_array - For every related bean returrned, specify link fields name to fields info for that bean to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address'))).
76 76
      * @param Number $deleted -- false if deleted records should not be include, true if deleted records should be included.
77 77
      * @param String $order_by -- field to order the result sets by
78
-     * @param Number $offset -- where to start in the return
78
+     * @param integer $offset -- where to start in the return
79 79
      * @param Number $limit -- number of results to return (defaults to all)
80 80
      * @return Array 'entry_list' -- Array - The records that were retrieved
81 81
      *               'relationship_list' -- Array - The records link field data. The example is if asked about accounts contacts email address then return data would look like Array ( [0] => Array ( [name] => email_addresses [records] => Array ( [0] => Array ( [0] => Array ( [name] => id [value] => 3fb16797-8d90-0a94-ac12-490b63a6be67 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 1 ) ) [1] => Array ( [0] => Array ( [name] => id [value] => 403f8da1-214b-6a88-9cef-490b63d43566 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 0 ) ) ) ) )
Please login to merge, or discard this patch.
service/v4_1/SugarWebServiceUtilv4_1.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
    	 * Validate the provided session information is correct and current.  Load the session.
46 46
    	 *
47 47
    	 * @param String $session_id -- The session ID that was returned by a call to login.
48
-   	 * @return true -- If the session is valid and loaded.
49
-   	 * @return false -- if the session is not valid.
48
+   	 * @return boolean -- If the session is valid and loaded.
49
+   	 * @return boolean -- if the session is not valid.
50 50
    	 */
51 51
    	function validate_authenticated($session_id)
52 52
     {
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
      * getRelationshipResults
104 104
      * Returns the
105 105
      *
106
-     * @param Mixed $bean The SugarBean instance to retrieve relationships from
106
+     * @param SugarBean $bean The SugarBean instance to retrieve relationships from
107 107
      * @param String $link_field_name The name of the relationship entry to fetch relationships for
108 108
      * @param Array $link_module_fields Array of fields of relationship entries to return
109 109
      * @param string $optional_where String containing an optional WHERE select clause
110 110
      * @param string $order_by String containing field to order results by
111
-     * @param Number $offset -- where to start in the return (defaults to 0)
111
+     * @param integer $offset -- where to start in the return (defaults to 0)
112 112
      * @param Number $limit -- number of results to return (defaults to all)
113 113
      * @return array|bool Returns an Array of relationship results; false if relationship could not be retrieved
114 114
      */
Please login to merge, or discard this patch.