Test Failed
Push — CI ( 02428e...3e0292 )
by Adam
55:43
created
install/TeamDemoData.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -180,6 +180,7 @@
 block discarded – undo
180 180
 	
181 181
 	/**
182 182
 	 * 
183
+	 * @param string $name
183 184
 	 */
184 185
 	function _quick_create($name)
185 186
 	{
Please login to merge, or discard this patch.
install/UserDemoData.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -64,6 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
 	/**
66 66
 	 * Constructor for creating user demo data
67
+	 * @param integer $seed_user
67 68
 	 */
68 69
 	function UserDemoData($seed_user, $large_scale_test = false)
69 70
 	{
@@ -163,6 +164,7 @@  discard block
 block discarded – undo
163 164
 
164 165
 	/**
165 166
 	 *
167
+	 * @param string $name
166 168
 	 */
167 169
 	function _quick_create_user($name)
168 170
 	{
Please login to merge, or discard this patch.
jssource/jsmin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
      * line and mult-line comments. Pass 2 performs some sanitation on each of the lines
14 14
      * and pass 3 works on stripping out unnecessary spaces.
15 15
      *
16
-     * @param string $js
17
-     * @param string $currentOptions
16
+     * @param string $text
17
+     * @param string $compression
18 18
      * @return void
19 19
      */
20 20
     private function __construct($text, $compression) {
Please login to merge, or discard this patch.
jssource/Minifier.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -361,6 +361,7 @@  discard block
 block discarded – undo
361 361
      * Pushes the index ahead to the next instance of the supplied string. If it is found the first character of the
362 362
      * string is returned.
363 363
      *
364
+     * @param string $string
364 365
      * @return string|false Returns the first character of the string if found, false otherwise.
365 366
      */
366 367
     protected function getNext($string)
@@ -449,6 +450,7 @@  discard block
 block discarded – undo
449 450
     /**
450 451
      * Checks to see if a character is alphanumeric.
451 452
      *
453
+     * @param string|false $char
452 454
      * @return bool
453 455
      */
454 456
     static protected function isAlphaNumeric($char)
Please login to merge, or discard this patch.
jssource/minify_utils.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -81,6 +81,10 @@  discard block
 block discarded – undo
81 81
      * and places the concatenated file in root directory
82 82
      * @from_path root directory where processing should take place
83 83
      */
84
+
85
+    /**
86
+     * @param string $from_path
87
+     */
84 88
     function ConcatenateFiles($from_path){
85 89
 
86 90
         // Minifying the group files takes a long time sometimes.
@@ -205,6 +209,9 @@  discard block
 block discarded – undo
205 209
 
206 210
     }
207 211
 
212
+    /**
213
+     * @param string $bu_path
214
+     */
208 215
     function create_backup_folder($bu_path){
209 216
         $bu_path = str_replace('\\', '/', $bu_path);
210 217
         //get path after root
@@ -244,6 +251,10 @@  discard block
 block discarded – undo
244 251
      * @from_path file name and path to be processed
245 252
      * @to_path file name and path to be  used to place newly compressed contents
246 253
      */
254
+
255
+    /**
256
+     * @param string $from_path
257
+     */
247 258
     function CompressFiles($from_path,$to_path){
248 259
     if(!defined('JSMIN_AS_LIB')){
249 260
         define('JSMIN_AS_LIB', true);
Please login to merge, or discard this patch.
ModuleInstall/ModuleInstaller.php 1 patch
Doc Comments   +24 added lines, -3 removed lines patch added patch discarded remove patch
@@ -82,6 +82,10 @@  discard block
 block discarded – undo
82 82
     *
83 83
     * Finally it runs over a list of defined tasks; then install_beans, then install_custom_fields, then clear the Vardefs, run a RepairAndClear, then finally call rebuild_relationships.
84 84
     */
85
+
86
+	/**
87
+	 * @param false|string $base_dir
88
+	 */
85 89
 	function install($base_dir, $is_upgrade = false, $previous_version = ''){
86 90
 		if(defined('TEMPLATE_URL'))SugarTemplateUtilities::disableCache();
87 91
         if ((defined('MODULE_INSTALLER_PACKAGE_SCAN') && MODULE_INSTALLER_PACKAGE_SCAN)
@@ -309,6 +313,7 @@  discard block
 block discarded – undo
309 313
 	 * Removes any files that were added by the loaded module. If the files already existed prior to install
310 314
 	 * it will be handled by copy_path with the uninstall parameter.
311 315
 	 *
316
+	 * @param string $backup_path
312 317
 	 */
313 318
 	function uninstall_new_files($cp, $backup_path){
314 319
 		$zip_files = $this->dir_get_files($cp['from'],$cp['from']);
@@ -1097,7 +1102,7 @@  discard block
 block discarded – undo
1097 1102
     /**
1098 1103
      * Check labels inside label files and remove them
1099 1104
      * 
1100
-     * @param $basePath - path to files with labels
1105
+     * @param string $basePath - path to files with labels
1101 1106
      * @param array $labelDefinitions - format like output from AbstractRelationship buildLabels()
1102 1107
      */
1103 1108
     public function uninstallLabels($basePath, $labelDefinitions)
@@ -1122,7 +1127,7 @@  discard block
 block discarded – undo
1122 1127
      * 
1123 1128
      * @param $uninstalLabes
1124 1129
      * @param $definition
1125
-     * @param $filename
1130
+     * @param string $filename
1126 1131
      */
1127 1132
     protected function uninstallLabel($uninstalLabes, $definition, $filename)
1128 1133
     {
@@ -1154,7 +1159,7 @@  discard block
 block discarded – undo
1154 1159
      * Save labels that not need be uninstalled at this case
1155 1160
      * 
1156 1161
      * @param $filename
1157
-     * @param $stringsName
1162
+     * @param string $stringsName
1158 1163
      * @param $strings
1159 1164
      */
1160 1165
     protected function saveContentToFile($filename, $stringsName, $strings)
@@ -1366,6 +1371,10 @@  discard block
 block discarded – undo
1366 1371
      * For each definition it calls db->createTableParams to build the relationships table if it does not exist,
1367 1372
      * and SugarBean::createRelationshipMeta to add the relationship into the 'relationships' table.
1368 1373
      */
1374
+
1375
+	/**
1376
+	 * @param string $file
1377
+	 */
1369 1378
 	function install_relationship($file)
1370 1379
 	{
1371 1380
 		$_REQUEST['moduleInstaller'] = true;
@@ -1791,6 +1800,10 @@  discard block
 block discarded – undo
1791 1800
      * custom/Extension/modules/$module/<path> (_override files last) and concatenates them to custom/modules/$module/<path>/<file>.
1792 1801
      * Then it does the same thing in custom/Extension/application/<path>, concatenating those files and copying the result to custom/application/<path>/<file>
1793 1802
      */
1803
+
1804
+	/**
1805
+	 * @param string $name
1806
+	 */
1794 1807
 	function merge_files($path, $name, $filter = '', $application = false){
1795 1808
 		if(!$application){
1796 1809
 		$GLOBALS['log']->debug( get_class($this)."->merge_files() : merging module files in custom/Extension/modules/<module>/$path to custom/modules/<module>/$path$name");
@@ -1988,6 +2001,11 @@  discard block
 block discarded – undo
1988 2001
 	}
1989 2002
 
1990 2003
 /* BEGIN - RESTORE POINT - by MR. MILK August 31, 2005 02:15:18 PM 	*/
2004
+/**
2005
+ * @param string $source
2006
+ * @param string $dest
2007
+ * @param string $backup_path
2008
+ */
1991 2009
 function copy_recursive_with_backup( $source, $dest, $backup_path, $uninstall=false ) {
1992 2010
 	if(is_file($source)) {
1993 2011
 	    if($uninstall) {
@@ -2510,6 +2528,9 @@  discard block
 block discarded – undo
2510 2528
 
2511 2529
 }
2512 2530
 
2531
+    /**
2532
+     * @param string $action
2533
+     */
2513 2534
     function UpdateSystemTabs($action, $installed_modules){
2514 2535
         require_once("modules/MySettings/TabController.php");
2515 2536
         $controller = new TabController();
Please login to merge, or discard this patch.
ModuleInstall/ModuleScanner.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -707,6 +707,7 @@
 block discarded – undo
707 707
 	/**
708 708
 	 *This function will scan the Manifest for disabled actions specified in $GLOBALS['sugar_config']['moduleInstaller']['disableActions']
709 709
 	 *if $GLOBALS['sugar_config']['moduleInstaller']['disableRestrictedCopy'] is set to false or not set it will call on scanCopy to ensure that it is not overriding files
710
+	 * @param string $manifestPath
710 711
 	 */
711 712
     public function scanManifest($manifestPath)
712 713
     {
Please login to merge, or discard this patch.
ModuleInstall/PackageManager/PackageController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
          * @param category_id   this is passed via POST and is the category id of the release we wish to download
146 146
          * @param package_id   this is passed via POST and is the package id of the release we wish to download
147 147
          * @param release_id   this is passed via POST and is the release id of the release we wish to download
148
-         * @return bool         true is successful in downloading, false otherwise
148
+         * @return boolean|null         true is successful in downloading, false otherwise
149 149
          */
150 150
         function download(){
151 151
             global $sugar_config;
@@ -345,8 +345,8 @@  discard block
 block discarded – undo
345 345
         /**
346 346
          * Remove metadata files such as foo-manifest
347 347
          * Enter description here ...
348
-         * @param unknown_type $file
349
-         * @param unknown_type $meta
348
+         * @param string $file
349
+         * @param string $meta
350 350
          */
351 351
         protected function rmMetaFile($file, $meta)
352 352
         {
Please login to merge, or discard this patch.
ModuleInstall/PackageManager/PackageManager.php 1 patch
Doc Comments   +20 added lines, -9 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 
134 134
     /**
135 135
      * Get a list of categories from the SugarDepot
136
-     * @param category_id   the category id of parent to obtain
136
+     * @param category_id   string category id of parent to obtain
137 137
      * @param filter        an array of filters to pass to limit the query
138 138
      * @return array        an array of categories for display on the client
139 139
      */
@@ -150,6 +150,9 @@  discard block
 block discarded – undo
150 150
         return $nodes;
151 151
     }
152 152
 
153
+    /**
154
+     * @param string $category_id
155
+     */
153 156
     function getPackages($category_id, $filter = array()){
154 157
         $nodes = array();
155 158
         $results = PackageManagerComm::getPackages($category_id, $filter);
@@ -182,10 +185,10 @@  discard block
 block discarded – undo
182 185
     /**
183 186
      * Retrieve the package as specified by the $id from the heartbeat server
184 187
      *
185
-     * @param category_id   the category_id to which the release belongs
186
-     * @param package_id    the package_id to which the release belongs
187
-     * @param release_id    the release_id to download
188
-     * @return filename - the path to which the zip file was saved
188
+     * @param category_id   string category_id to which the release belongs
189
+     * @param package_id    string package_id to which the release belongs
190
+     * @param release_id    string release_id to download
191
+     * @return string|null - the path to which the zip file was saved
189 192
      */
190 193
     public function download($category_id, $package_id, $release_id)
191 194
     {
@@ -207,8 +210,8 @@  discard block
 block discarded – undo
207 210
      * Given the Mambo username, password, and download key attempt to authenticate, if
208 211
      * successful then store these credentials
209 212
      *
210
-     * @param username      Mambo username
211
-     * @param password      Mambo password
213
+     * @param username      string username
214
+     * @param password      string password
212 215
      * @param systemname   the user's download key
213 216
      * @return              true if successful, false otherwise
214 217
      */
@@ -261,8 +264,8 @@  discard block
 block discarded – undo
261 264
     /**
262 265
      * Retrieve documentation for the given release or package
263 266
      *
264
-     * @param package_id	the specified package to retrieve documentation
265
-     * @param release_id	the specified release to retrieve documentation
267
+     * @param package_id	string specified package to retrieve documentation
268
+     * @param release_id	string specified release to retrieve documentation
266 269
      *
267 270
      * @return documents
268 271
      */
@@ -356,6 +359,9 @@  discard block
 block discarded – undo
356 359
 
357 360
     private $cleanUpDirs = array();
358 361
 
362
+    /**
363
+     * @param false|string $dir
364
+     */
359 365
     private function addToCleanup($dir)
360 366
     {
361 367
         if(empty($this->cleanUpDirs)) {
@@ -380,6 +386,11 @@  discard block
 block discarded – undo
380 386
         return( "$my_zip_dir/$file_in_zip" );
381 387
     }
382 388
 
389
+    /**
390
+     * @param string $zip_file
391
+     *
392
+     * @return string
393
+     */
383 394
     function extractManifest( $zip_file,$base_tmp_upgrade_dir ) {
384 395
         global $sugar_config;
385 396
         $base_upgrade_dir       = $this->upload_dir."/upgrades";
Please login to merge, or discard this patch.