adamjakab / SuiteCRM

include/generic/SugarWidgets/SugarWidgetSubPanelRelFieldEditButton.php

Indentation +12 added lines, -12 removed lines

@@ -45,14 +45,14 @@ 
 //TODO Rename this to edit link
 class SugarWidgetSubPanelRelFieldEditButton extends SugarWidgetField
 {
-	function displayHeaderCell(&$layout_def)
-	{
-		return ' ';
-	}
+    function displayHeaderCell(&$layout_def)
+    {
+        return ' ';
+    }
 
-	function displayList(&$layout_def)
-	{
-		die("<pre>" . print_r($layout_def, true) . "</pre>");
+    function displayList(&$layout_def)
+    {
+        die("<pre>" . print_r($layout_def, true) . "</pre>");
 
         $rel = $layout_def['linked_field'];
         $module = $layout_def['module'];
@@ -60,8 +60,8 @@ 
 
         global $app_strings;
 
-		$edit_icon_html = SugarThemeRegistry::current()->getImage( 'edit_inline',
-			'align="absmiddle" alt="' . $app_strings['LNK_EDIT'] . '" border="0"');
+        $edit_icon_html = SugarThemeRegistry::current()->getImage( 'edit_inline',
+            'align="absmiddle" alt="' . $app_strings['LNK_EDIT'] . '" border="0"');
 
         $script = "
         function editRel(name, id, module) {
@@ -89,9 +89,9 @@ 
 		}";
 
         return "<script>$script</script>"
-             . '<div onclick="editRel(\'p1_b1_accounts\', \'cac203f3-0380-495f-3231-4cf58f089f00\', \'Accounts\')">'
-             . $edit_icon_html . "</div>";
-	}
+                . '<div onclick="editRel(\'p1_b1_accounts\', \'cac203f3-0380-495f-3231-4cf58f089f00\', \'Accounts\')">'
+                . $edit_icon_html . "</div>";
+    }
 		
 }
 

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,7 +52,7 @@ 
 
 	function displayList(&$layout_def)
 	{
-		die("<pre>" . print_r($layout_def, true) . "</pre>");
+		die("<pre>".print_r($layout_def, true)."</pre>");
 
         $rel = $layout_def['linked_field'];
         $module = $layout_def['module'];
@@ -60,8 +60,8 @@ 
 
         global $app_strings;
 
-		$edit_icon_html = SugarThemeRegistry::current()->getImage( 'edit_inline',
-			'align="absmiddle" alt="' . $app_strings['LNK_EDIT'] . '" border="0"');
+		$edit_icon_html = SugarThemeRegistry::current()->getImage('edit_inline',
+			'align="absmiddle" alt="'.$app_strings['LNK_EDIT'].'" border="0"');
 
         $script = "
         function editRel(name, id, module) {
@@ -90,7 +90,7 @@ 
 
         return "<script>$script</script>"
              . '<div onclick="editRel(\'p1_b1_accounts\', \'cac203f3-0380-495f-3231-4cf58f089f00\', \'Accounts\')">'
-             . $edit_icon_html . "</div>";
+             . $edit_icon_html."</div>";
 	}
 		
 }

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelManageDelegatesButton.php

Indentation +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
         global $mod_strings;
         
         $button  = "<form id='ManageDelegatesForm' name='ManageDelegatesForm' method='post' action=''>";
-       // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
+        // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
         $button .= "<input id='Manage_Delegates' class='button' type='button' name='Manage_Delegates' onclick='manage_delegates()' value='".$mod_strings['LBL_MANAGE_DELEGATES']."'/>\n</form>";
         return $button;
     }

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelTopScheduleCallButton.php

Indentation +114 added lines, -114 removed lines

@@ -45,120 +45,120 @@
 
 class SugarWidgetSubPanelTopScheduleCallButton extends SugarWidgetSubPanelTopButtonQuickCreate
 {
-	function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
-	{
-		global $app_strings;
-		global $currentModule;
-
-		$this->module="Calls";
-		$this->subpanelDiv = "activities";
-
-		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
-		{
-			foreach($this->additional_form_fields as $key=>$value)
-			{
-				if(!empty($defines['focus']->$value))
-				{
-					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
-				{
-					$additionalFormFields[$key] = '';
-				}
-			}
-		}
-
-		if(!empty($this->module))
-		{
-			$defines['child_module_name'] = $this->module;
-		}
-		else
-		{
-			$defines['child_module_name'] = $defines['module'];
-		}
-
-		if(!empty($this->subpanelDiv))
-		{
-			$defines['subpanelDiv'] = $this->subpanelDiv;
-		}
-
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
-
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
-
-		//module_button is used to override the value of module name
-		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
-		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
-
-		if(isset($defines['focus']->name))
-		{
-			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
-		}
-
-		$button .= '<input type="hidden" name="to_pdf" value="true" />';
+    function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
+    {
+        global $app_strings;
+        global $currentModule;
+
+        $this->module="Calls";
+        $this->subpanelDiv = "activities";
+
+        // Create the additional form fields with real values if they were not passed in
+        if(empty($additionalFormFields) && $this->additional_form_fields)
+        {
+            foreach($this->additional_form_fields as $key=>$value)
+            {
+                if(!empty($defines['focus']->$value))
+                {
+                    $additionalFormFields[$key] = $defines['focus']->$value;
+                }
+                else
+                {
+                    $additionalFormFields[$key] = '';
+                }
+            }
+        }
+
+        if(!empty($this->module))
+        {
+            $defines['child_module_name'] = $this->module;
+        }
+        else
+        {
+            $defines['child_module_name'] = $defines['module'];
+        }
+
+        if(!empty($this->subpanelDiv))
+        {
+            $defines['subpanelDiv'] = $this->subpanelDiv;
+        }
+
+        $defines['parent_bean_name'] = get_class( $defines['focus']);
+
+        $form = 'form' . $defines['child_module_name'];
+        $button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+
+        //module_button is used to override the value of module name
+        $button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
+        $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
+
+        if(isset($defines['focus']->name))
+        {
+            $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
+        }
+
+        $button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
-		$button .= '<input type="hidden" name="record" value="" />';
-
-		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
-				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
-			}
-		}
-		if(empty($additionalFormFields['parent_name']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
-				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
-				$additionalFormFields['parent_name'] = $defines['focus']->name;
-			}
-		}
-		if(empty($additionalFormFields['parent_id']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
-				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
-				$additionalFormFields['parent_id'] = $defines['focus']->id;
-			}
-		}
-
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
-
-		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
-		{
-			if($key != 'action')
-			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
-			}
-		}
-		$button .= getVersionedScript('include/SugarFields/Fields/Datetimecombo/Datetimecombo.js')."\n";
-		return $button;
-	}
-
-	function display($defines, $additionalFormFields = null, $nonbutton = false)
-	{
-	    $focus = new Call;
-		if ( !$focus->ACLAccess('EditView') ) {
-		    return '';
-	    }
-
-		return parent::display($defines, $additionalFormFields);
-	}
+        $button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
+        $button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
+        $button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+        $button .= '<input type="hidden" name="record" value="" />';
+
+        // TODO: move this out and get $additionalFormFields working properly
+        if(empty($additionalFormFields['parent_type']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_type'] = 'Accounts';
+            }
+            else {
+                $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
+            }
+        }
+        if(empty($additionalFormFields['parent_name']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_name'] = $defines['focus']->account_name;
+                $additionalFormFields['account_name'] = $defines['focus']->account_name;
+            }
+            else {
+                $additionalFormFields['parent_name'] = $defines['focus']->name;
+            }
+        }
+        if(empty($additionalFormFields['parent_id']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_id'] = $defines['focus']->account_id;
+                $additionalFormFields['account_id'] = $defines['focus']->account_id;
+            }
+            else {
+                $additionalFormFields['parent_id'] = $defines['focus']->id;
+            }
+        }
+
+        $button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
+        $button .= '<input type="hidden" name="module" value="Home" />' . "\n";
+        $button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+
+        // fill in additional form fields for all but action
+        foreach($additionalFormFields as $key => $value)
+        {
+            if($key != 'action')
+            {
+                $button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+            }
+        }
+        $button .= getVersionedScript('include/SugarFields/Fields/Datetimecombo/Datetimecombo.js')."\n";
+        return $button;
+    }
+
+    function display($defines, $additionalFormFields = null, $nonbutton = false)
+    {
+        $focus = new Call;
+        if ( !$focus->ACLAccess('EditView') ) {
+            return '';
+        }
+
+        return parent::display($defines, $additionalFormFields);
+    }
 }
 ?>

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,15 +50,15 @@ 
 		global $app_strings;
 		global $currentModule;
 
-		$this->module="Calls";
+		$this->module = "Calls";
 		$this->subpanelDiv = "activities";
 
 		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
+		if (empty($additionalFormFields) && $this->additional_form_fields)
 		{
-			foreach($this->additional_form_fields as $key=>$value)
+			foreach ($this->additional_form_fields as $key=>$value)
 			{
-				if(!empty($defines['focus']->$value))
+				if (!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
 				}
@@ -69,7 +69,7 @@ 
 			}
 		}
 
-		if(!empty($this->module))
+		if (!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
 		}
@@ -78,45 +78,45 @@ 
 			$defines['child_module_name'] = $defines['module'];
 		}
 
-		if(!empty($this->subpanelDiv))
+		if (!empty($this->subpanelDiv))
 		{
 			$defines['subpanelDiv'] = $this->subpanelDiv;
 		}
 
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
+		$defines['parent_bean_name'] = get_class($defines['focus']);
 
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+		$form = 'form'.$defines['child_module_name'];
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.strtolower($defines['subpanelDiv']).'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
 
 		//module_button is used to override the value of module name
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
 
-		if(isset($defines['focus']->name))
+		if (isset($defines['focus']->name))
 		{
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
 		}
 
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
 		$button .= '<input type="hidden" name="record" value="" />';
 
 		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
+		if (empty($additionalFormFields['parent_type']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
 			}
 			else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
-		if(empty($additionalFormFields['parent_name']))
+		if (empty($additionalFormFields['parent_name']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
 			}
@@ -124,9 +124,9 @@ 
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
-		if(empty($additionalFormFields['parent_id']))
+		if (empty($additionalFormFields['parent_id']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
 			}
@@ -135,16 +135,16 @@ 
 			}
 		}
 
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
 
 		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
+		foreach ($additionalFormFields as $key => $value)
 		{
-			if($key != 'action')
+			if ($key != 'action')
 			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+				$button .= '<input type="hidden" name="'.$key.'" value="'.$value.'" />'."\n";
 			}
 		}
 		$button .= getVersionedScript('include/SugarFields/Fields/Datetimecombo/Datetimecombo.js')."\n";
@@ -154,7 +154,7 @@ 
 	function display($defines, $additionalFormFields = null, $nonbutton = false)
 	{
 	    $focus = new Call;
-		if ( !$focus->ACLAccess('EditView') ) {
+		if (!$focus->ACLAccess('EditView')) {
 		    return '';
 	    }
 

Braces +8 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,8 +63,7 @@ 
 				if(!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
+				} else
 				{
 					$additionalFormFields[$key] = '';
 				}
@@ -72,8 +73,7 @@ 
 		if(!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
-		}
-		else
+		} else
 		{
 			$defines['child_module_name'] = $defines['module'];
 		}
@@ -109,8 +109,7 @@ 
 		{
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
@@ -119,8 +118,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
@@ -129,8 +127,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_id'] = $defines['focus']->id;
 			}
 		}

include/generic/SugarWidgets/SugarWidgetSubPanelTopButtonQuickCreate.php

Indentation +128 added lines, -128 removed lines

@@ -47,103 +47,103 @@ 
 {
 
 
-	function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
-	{
-		global $app_strings;
-		global $currentModule;
-
-		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
-		{
-			foreach($this->additional_form_fields as $key=>$value)
-			{
-				if(!empty($defines['focus']->$value))
-				{
-					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
-				{
-					$additionalFormFields[$key] = '';
-				}
-			}
-		}
-
-		if(!empty($this->module))
-		{
-			$defines['child_module_name'] = $this->module;
-		}
-		else
-		{
-			$defines['child_module_name'] = $defines['module'];
-		}
-
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
-
-		$relationship_name = $this->get_subpanel_relationship_name($defines);
-
-		$form = 'form' . $relationship_name;
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . $defines['subpanel_definition']->name . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
-
-		//module_button is used to override the value of module name
-		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
-		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
-
-		if(isset($defines['focus']->name))
-		{
-			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
-			#26451,add these fields for custom one-to-many relate field.
+    function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
+    {
+        global $app_strings;
+        global $currentModule;
+
+        // Create the additional form fields with real values if they were not passed in
+        if(empty($additionalFormFields) && $this->additional_form_fields)
+        {
+            foreach($this->additional_form_fields as $key=>$value)
+            {
+                if(!empty($defines['focus']->$value))
+                {
+                    $additionalFormFields[$key] = $defines['focus']->$value;
+                }
+                else
+                {
+                    $additionalFormFields[$key] = '';
+                }
+            }
+        }
+
+        if(!empty($this->module))
+        {
+            $defines['child_module_name'] = $this->module;
+        }
+        else
+        {
+            $defines['child_module_name'] = $defines['module'];
+        }
+
+        $defines['parent_bean_name'] = get_class( $defines['focus']);
+
+        $relationship_name = $this->get_subpanel_relationship_name($defines);
+
+        $form = 'form' . $relationship_name;
+        $button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . $defines['subpanel_definition']->name . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+
+        //module_button is used to override the value of module name
+        $button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
+        $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
+
+        if(isset($defines['focus']->name))
+        {
+            $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
+            #26451,add these fields for custom one-to-many relate field.
             if(!empty($defines['child_module_name'])){
-            	$button .= "<input type='hidden' name='". $relationship_name ."_name' value='".$defines['focus']->name."'>";
-            	$childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
-            	if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
-            		$button .= "<input type='hidden' name='". $GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'] ."' value='".$defines['focus']->id."'>";
-            	}
+                $button .= "<input type='hidden' name='". $relationship_name ."_name' value='".$defines['focus']->name."'>";
+                $childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
+                if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
+                    $button .= "<input type='hidden' name='". $GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'] ."' value='".$defines['focus']->id."'>";
+                }
             }
             
             //Set the return_name form variable that will allow EditView2.php 
             $additionalFormFields['return_name'] = $defines['focus']->name;
-		}
+        }
 		
-		if(!empty($defines['view']))
-		$button .= '<input type="hidden" name="target_view" value="'. $defines['view'] . '" />';
-		$button .= '<input type="hidden" name="to_pdf" value="true" />';
+        if(!empty($defines['view']))
+        $button .= '<input type="hidden" name="target_view" value="'. $defines['view'] . '" />';
+        $button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
-		$button .= '<input type="hidden" name="return_relationship" value="' . $relationship_name . "\" />\n";
-		$button .= '<input type="hidden" name="record" value="" />';
-
-		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
-				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
-			}
-		}
-		if(empty($additionalFormFields['parent_name']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
-				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
-				$additionalFormFields['parent_name'] = $defines['focus']->name;
-			}
-		}
-		if(empty($additionalFormFields['parent_id']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
-				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
-				$additionalFormFields['parent_id'] = $defines['focus']->id;
-			}
-		}
+        $button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
+        $button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
+        $button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+        $button .= '<input type="hidden" name="return_relationship" value="' . $relationship_name . "\" />\n";
+        $button .= '<input type="hidden" name="record" value="" />';
+
+        // TODO: move this out and get $additionalFormFields working properly
+        if(empty($additionalFormFields['parent_type']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_type'] = 'Accounts';
+            }
+            else {
+                $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
+            }
+        }
+        if(empty($additionalFormFields['parent_name']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_name'] = $defines['focus']->account_name;
+                $additionalFormFields['account_name'] = $defines['focus']->account_name;
+            }
+            else {
+                $additionalFormFields['parent_name'] = $defines['focus']->name;
+            }
+        }
+        if(empty($additionalFormFields['parent_id']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_id'] = $defines['focus']->account_id;
+                $additionalFormFields['account_id'] = $defines['focus']->account_id;
+            }
+            else {
+                $additionalFormFields['parent_id'] = $defines['focus']->id;
+            }
+        }
 
         if(strtolower($defines['child_module_name']) =='contracts') {
             //set variables to account name, or parent account name
@@ -161,43 +161,43 @@ 
             }
         }
 
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
-
-		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
-		{
-			if($key != 'action')
-			{
-				$button .= '<input type="hidden" name="' . $key . '" value=\'' . $value . '\' />' . "\n";
-			}
-		}
-
-		return $button;
-	}
-
-	/**
-	 * get_subpanel_relationship_name
-	 * Get the relationship name based on the subapnel definition
-	 * @param mixed $defines The subpanel definition
-	 */
-	function get_subpanel_relationship_name($defines) {
-		 $relationship_name = '';
-		 if(!empty($defines)) {
-		 	$relationship_name = isset($defines['module']) ? $defines['module'] : '';
-	     	$dataSource = $defines['subpanel_definition']->get_data_source_name(true);
-         	if (!empty($dataSource)) {
-				$relationship_name = $dataSource;
-				//Try to set the relationship name to the real relationship, not the link.
-				if (!empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource])
-				 && !empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship']))
-				{
-					$relationship_name = $defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship'];
-				}
-			}
-		 }
-		 return $relationship_name;
-	}
+        $button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
+        $button .= '<input type="hidden" name="module" value="Home" />' . "\n";
+        $button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+
+        // fill in additional form fields for all but action
+        foreach($additionalFormFields as $key => $value)
+        {
+            if($key != 'action')
+            {
+                $button .= '<input type="hidden" name="' . $key . '" value=\'' . $value . '\' />' . "\n";
+            }
+        }
+
+        return $button;
+    }
+
+    /**
+     * get_subpanel_relationship_name
+     * Get the relationship name based on the subapnel definition
+     * @param mixed $defines The subpanel definition
+     */
+    function get_subpanel_relationship_name($defines) {
+            $relationship_name = '';
+            if(!empty($defines)) {
+                $relationship_name = isset($defines['module']) ? $defines['module'] : '';
+                $dataSource = $defines['subpanel_definition']->get_data_source_name(true);
+                if (!empty($dataSource)) {
+                $relationship_name = $dataSource;
+                //Try to set the relationship name to the real relationship, not the link.
+                if (!empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource])
+                 && !empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship']))
+                {
+                    $relationship_name = $defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship'];
+                }
+            }
+            }
+            return $relationship_name;
+    }
 }
 ?>

Spacing +42 added lines, -42 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,11 +53,11 @@ 
 		global $currentModule;
 
 		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
+		if (empty($additionalFormFields) && $this->additional_form_fields)
 		{
-			foreach($this->additional_form_fields as $key=>$value)
+			foreach ($this->additional_form_fields as $key=>$value)
 			{
-				if(!empty($defines['focus']->$value))
+				if (!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
 				}
@@ -68,7 +68,7 @@ 
 			}
 		}
 
-		if(!empty($this->module))
+		if (!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
 		}
@@ -77,26 +77,26 @@ 
 			$defines['child_module_name'] = $defines['module'];
 		}
 
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
+		$defines['parent_bean_name'] = get_class($defines['focus']);
 
 		$relationship_name = $this->get_subpanel_relationship_name($defines);
 
-		$form = 'form' . $relationship_name;
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . $defines['subpanel_definition']->name . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+		$form = 'form'.$relationship_name;
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.$defines['subpanel_definition']->name.'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
 
 		//module_button is used to override the value of module name
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
 
-		if(isset($defines['focus']->name))
+		if (isset($defines['focus']->name))
 		{
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
 			#26451,add these fields for custom one-to-many relate field.
-            if(!empty($defines['child_module_name'])){
-            	$button .= "<input type='hidden' name='". $relationship_name ."_name' value='".$defines['focus']->name."'>";
+            if (!empty($defines['child_module_name'])) {
+            	$button .= "<input type='hidden' name='".$relationship_name."_name' value='".$defines['focus']->name."'>";
             	$childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
-            	if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
-            		$button .= "<input type='hidden' name='". $GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'] ."' value='".$defines['focus']->id."'>";
+            	if (!empty($GLOBALS['dictionary'][$childFocusName]["fields"][$relationship_name.'_name']['id_name'])) {
+            		$button .= "<input type='hidden' name='".$GLOBALS['dictionary'][$childFocusName]["fields"][$relationship_name.'_name']['id_name']."' value='".$defines['focus']->id."'>";
             	}
             }
             
@@ -104,29 +104,29 @@ 
             $additionalFormFields['return_name'] = $defines['focus']->name;
 		}
 		
-		if(!empty($defines['view']))
-		$button .= '<input type="hidden" name="target_view" value="'. $defines['view'] . '" />';
+		if (!empty($defines['view']))
+		$button .= '<input type="hidden" name="target_view" value="'.$defines['view'].'" />';
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
-		$button .= '<input type="hidden" name="return_relationship" value="' . $relationship_name . "\" />\n";
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
+		$button .= '<input type="hidden" name="return_relationship" value="'.$relationship_name."\" />\n";
 		$button .= '<input type="hidden" name="record" value="" />';
 
 		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
+		if (empty($additionalFormFields['parent_type']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
 			}
 			else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
-		if(empty($additionalFormFields['parent_name']))
+		if (empty($additionalFormFields['parent_name']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
 			}
@@ -134,9 +134,9 @@ 
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
-		if(empty($additionalFormFields['parent_id']))
+		if (empty($additionalFormFields['parent_id']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
 			}
@@ -145,32 +145,32 @@ 
 			}
 		}
 
-        if(strtolower($defines['child_module_name']) =='contracts') {
+        if (strtolower($defines['child_module_name']) == 'contracts') {
             //set variables to account name, or parent account name
-            if(strtolower($defines['parent_bean_name']) == 'account' ){
+            if (strtolower($defines['parent_bean_name']) == 'account') {
                 //if account is parent bean, then get focus id/focus name
-                if(isset($defines['focus']->id))$additionalFormFields['account_id'] = $defines['focus']->id;
-                if(isset($defines['focus']->name))$additionalFormFields['account_name'] = $defines['focus']->name;
-            }elseif(strtolower($defines['parent_bean_name']) == 'quote' ){
+                if (isset($defines['focus']->id))$additionalFormFields['account_id'] = $defines['focus']->id;
+                if (isset($defines['focus']->name))$additionalFormFields['account_name'] = $defines['focus']->name;
+            }elseif (strtolower($defines['parent_bean_name']) == 'quote') {
                 //if quote is parent bean, then get billing_account_id/billing_account_name
-                if(isset($defines['focus']->billing_account_id))$additionalFormFields['account_id'] = $defines['focus']->billing_account_id;
-                if(isset($defines['focus']->billing_account_name))$additionalFormFields['account_name'] = $defines['focus']->billing_account_name;
-            }else{
-                if(isset($defines['focus']->account_id))$additionalFormFields['account_id'] = $defines['focus']->account_id;
-                if(isset($defines['focus']->account_name))$additionalFormFields['account_name'] = $defines['focus']->account_name;
+                if (isset($defines['focus']->billing_account_id))$additionalFormFields['account_id'] = $defines['focus']->billing_account_id;
+                if (isset($defines['focus']->billing_account_name))$additionalFormFields['account_name'] = $defines['focus']->billing_account_name;
+            } else {
+                if (isset($defines['focus']->account_id))$additionalFormFields['account_id'] = $defines['focus']->account_id;
+                if (isset($defines['focus']->account_name))$additionalFormFields['account_name'] = $defines['focus']->account_name;
             }
         }
 
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
 
 		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
+		foreach ($additionalFormFields as $key => $value)
 		{
-			if($key != 'action')
+			if ($key != 'action')
 			{
-				$button .= '<input type="hidden" name="' . $key . '" value=\'' . $value . '\' />' . "\n";
+				$button .= '<input type="hidden" name="'.$key.'" value=\''.$value.'\' />'."\n";
 			}
 		}
 
@@ -184,7 +184,7 @@ 
 	 */
 	function get_subpanel_relationship_name($defines) {
 		 $relationship_name = '';
-		 if(!empty($defines)) {
+		 if (!empty($defines)) {
 		 	$relationship_name = isset($defines['module']) ? $defines['module'] : '';
 	     	$dataSource = $defines['subpanel_definition']->get_data_source_name(true);
          	if (!empty($dataSource)) {

Braces +31 added lines, -21 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -60,8 +62,7 @@ 
 				if(!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
+				} else
 				{
 					$additionalFormFields[$key] = '';
 				}
@@ -71,8 +72,7 @@ 
 		if(!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
-		}
-		else
+		} else
 		{
 			$defines['child_module_name'] = $defines['module'];
 		}
@@ -104,8 +104,9 @@ 
             $additionalFormFields['return_name'] = $defines['focus']->name;
 		}
 		
-		if(!empty($defines['view']))
-		$button .= '<input type="hidden" name="target_view" value="'. $defines['view'] . '" />';
+		if(!empty($defines['view'])) {
+				$button .= '<input type="hidden" name="target_view" value="'. $defines['view'] . '" />';
+		}
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
 		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
@@ -119,8 +120,7 @@ 
 		{
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
@@ -129,8 +129,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
@@ -139,8 +138,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_id'] = $defines['focus']->id;
 			}
 		}
@@ -149,15 +147,27 @@ 
             //set variables to account name, or parent account name
             if(strtolower($defines['parent_bean_name']) == 'account' ){
                 //if account is parent bean, then get focus id/focus name
-                if(isset($defines['focus']->id))$additionalFormFields['account_id'] = $defines['focus']->id;
-                if(isset($defines['focus']->name))$additionalFormFields['account_name'] = $defines['focus']->name;
-            }elseif(strtolower($defines['parent_bean_name']) == 'quote' ){
+                if(isset($defines['focus']->id)) {
+                    $additionalFormFields['account_id'] = $defines['focus']->id;
+                }
+                if(isset($defines['focus']->name)) {
+                    $additionalFormFields['account_name'] = $defines['focus']->name;
+                }
+            } elseif(strtolower($defines['parent_bean_name']) == 'quote' ){
                 //if quote is parent bean, then get billing_account_id/billing_account_name
-                if(isset($defines['focus']->billing_account_id))$additionalFormFields['account_id'] = $defines['focus']->billing_account_id;
-                if(isset($defines['focus']->billing_account_name))$additionalFormFields['account_name'] = $defines['focus']->billing_account_name;
-            }else{
-                if(isset($defines['focus']->account_id))$additionalFormFields['account_id'] = $defines['focus']->account_id;
-                if(isset($defines['focus']->account_name))$additionalFormFields['account_name'] = $defines['focus']->account_name;
+                if(isset($defines['focus']->billing_account_id)) {
+                    $additionalFormFields['account_id'] = $defines['focus']->billing_account_id;
+                }
+                if(isset($defines['focus']->billing_account_name)) {
+                    $additionalFormFields['account_name'] = $defines['focus']->billing_account_name;
+                }
+            } else{
+                if(isset($defines['focus']->account_id)) {
+                    $additionalFormFields['account_id'] = $defines['focus']->account_id;
+                }
+                if(isset($defines['focus']->account_name)) {
+                    $additionalFormFields['account_name'] = $defines['focus']->account_name;
+                }
             }
         }
 

include/generic/SugarWidgets/SugarWidgetFieldint.php

Indentation +39 added lines, -39 removed lines

@@ -42,59 +42,59 @@
 
 class SugarWidgetFieldInt extends SugarWidgetReportField
 {
- function displayList($layout_def)
- {
+    function displayList($layout_def)
+    {
 
- 	return $this->displayListPlain($layout_def);
- }
+        return $this->displayListPlain($layout_def);
+    }
 
- function queryFilterEquals(&$layout_def)
- {
+    function queryFilterEquals(&$layout_def)
+    {
                 return $this->_get_column_select($layout_def)."= '".$GLOBALS['db']->quote($layout_def['input_name0'])."'\n";
- }
+    }
 
- function queryFilterNot_Equals(&$layout_def)
- {
+    function queryFilterNot_Equals(&$layout_def)
+    {
                 return $this->_get_column_select($layout_def)."!='".$GLOBALS['db']->quote($layout_def['input_name0'])."'\n";
- }
+    }
 
- function queryFilterGreater(&$layout_def)
- {
+    function queryFilterGreater(&$layout_def)
+    {
                 return $this->_get_column_select($layout_def)." > '".$GLOBALS['db']->quote($layout_def['input_name0'])."'\n";
- }
+    }
 
- function queryFilterLess(&$layout_def)
- {
+    function queryFilterLess(&$layout_def)
+    {
                 return $this->_get_column_select($layout_def)." < '".$GLOBALS['db']->quote($layout_def['input_name0'])."'\n";
- }
+    }
 
- function queryFilterBetween(&$layout_def)
- {
- 	             return $this->_get_column_select($layout_def)." BETWEEN '".$GLOBALS['db']->quote($layout_def['input_name0']). "' AND '" . $GLOBALS['db']->quote($layout_def['input_name1']) . "'\n";
- }
+    function queryFilterBetween(&$layout_def)
+    {
+                    return $this->_get_column_select($layout_def)." BETWEEN '".$GLOBALS['db']->quote($layout_def['input_name0']). "' AND '" . $GLOBALS['db']->quote($layout_def['input_name1']) . "'\n";
+    }
 
- function queryFilterStarts_With(&$layout_def)
- {
- 	return $this->queryFilterEquals($layout_def);
- }
+    function queryFilterStarts_With(&$layout_def)
+    {
+        return $this->queryFilterEquals($layout_def);
+    }
 
- function displayInput(&$layout_def)
- {
- 	 return '<input type="text" size="20" value="' . $layout_def['input_name0'] . '" name="' . $layout_def['name'] . '">';
+    function displayInput(&$layout_def)
+    {
+        return '<input type="text" size="20" value="' . $layout_def['input_name0'] . '" name="' . $layout_def['name'] . '">';
 
- }
+    }
  
- function display($layout_def)
- {
-	   //Bug40995
-	   if(isset($obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision']))
-	   {
-		   $precision=$obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision'];
-		   $layout_def['precision']=$precision;
-	   }
-	   //Bug40995
-       return parent::display($layout_def);
- } 
+    function display($layout_def)
+    {
+        //Bug40995
+        if(isset($obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision']))
+        {
+            $precision=$obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision'];
+            $layout_def['precision']=$precision;
+        }
+        //Bug40995
+        return parent::display($layout_def);
+    } 
 
 }
 

Spacing +6 added lines, -6 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -70,7 +70,7 @@ 
 
  function queryFilterBetween(&$layout_def)
  {
- 	             return $this->_get_column_select($layout_def)." BETWEEN '".$GLOBALS['db']->quote($layout_def['input_name0']). "' AND '" . $GLOBALS['db']->quote($layout_def['input_name1']) . "'\n";
+ 	             return $this->_get_column_select($layout_def)." BETWEEN '".$GLOBALS['db']->quote($layout_def['input_name0'])."' AND '".$GLOBALS['db']->quote($layout_def['input_name1'])."'\n";
  }
 
  function queryFilterStarts_With(&$layout_def)
@@ -80,17 +80,17 @@ 
 
  function displayInput(&$layout_def)
  {
- 	 return '<input type="text" size="20" value="' . $layout_def['input_name0'] . '" name="' . $layout_def['name'] . '">';
+ 	 return '<input type="text" size="20" value="'.$layout_def['input_name0'].'" name="'.$layout_def['name'].'">';
 
  }
  
  function display($layout_def)
  {
 	   //Bug40995
-	   if(isset($obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision']))
+	   if (isset($obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision']))
 	   {
-		   $precision=$obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision'];
-		   $layout_def['precision']=$precision;
+		   $precision = $obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision'];
+		   $layout_def['precision'] = $precision;
 	   }
 	   //Bug40995
        return parent::display($layout_def);

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelTopSummaryButton.php

Indentation +29 added lines, -29 removed lines

@@ -45,38 +45,38 @@
 
 class SugarWidgetSubPanelTopSummaryButton extends SugarWidgetSubPanelTopButton
 {
-	function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
-	{
+    function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
+    {
 		
 		
-		global $app_strings;
-		global $currentModule;
+        global $app_strings;
+        global $currentModule;
 
-		$popup_request_data = array(
-			'call_back_function' => 'set_return',
-			'form_name' => 'EditView',
-			'field_to_name_array' => array(),
-		);
+        $popup_request_data = array(
+            'call_back_function' => 'set_return',
+            'form_name' => 'EditView',
+            'field_to_name_array' => array(),
+        );
 
-		$json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
-		$title = $app_strings['LBL_ACCUMULATED_HISTORY_BUTTON_TITLE'];
-		//$accesskey = $app_strings['LBL_ACCUMULATED_HISTORY_BUTTON_KEY'];
-		$value = $app_strings['LBL_ACCUMULATED_HISTORY_BUTTON_LABEL'];
-		$module_name = 'Activities';
-		$id = $widget_data['focus']->id;
-		$initial_filter = "&record=$id&module_name=$currentModule";
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'detail', true)){
-			$temp =  '<input disabled type="button" name="summary_button" id="summary_button"'
-			. ' class="button"'
-			. ' title="' . $title . '"'
-			. ' value="' . $value . '"';
-			return $temp;
-		}
-		return '<input type="button" name="summary_button" id="summary_button"'
-			. ' class="button"'
-			. ' title="' . $title . '"'
-			. ' value="' . $value . '"'
-			. " onclick='open_popup(\"$module_name\",600,400,\"$initial_filter\",false,false,$json_encoded_php_array);' />\n";
-	}
+        $json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
+        $title = $app_strings['LBL_ACCUMULATED_HISTORY_BUTTON_TITLE'];
+        //$accesskey = $app_strings['LBL_ACCUMULATED_HISTORY_BUTTON_KEY'];
+        $value = $app_strings['LBL_ACCUMULATED_HISTORY_BUTTON_LABEL'];
+        $module_name = 'Activities';
+        $id = $widget_data['focus']->id;
+        $initial_filter = "&record=$id&module_name=$currentModule";
+        if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'detail', true)){
+            $temp =  '<input disabled type="button" name="summary_button" id="summary_button"'
+            . ' class="button"'
+            . ' title="' . $title . '"'
+            . ' value="' . $value . '"';
+            return $temp;
+        }
+        return '<input type="button" name="summary_button" id="summary_button"'
+            . ' class="button"'
+            . ' title="' . $title . '"'
+            . ' value="' . $value . '"'
+            . " onclick='open_popup(\"$module_name\",600,400,\"$initial_filter\",false,false,$json_encoded_php_array);' />\n";
+    }
 }
 ?>
\ No newline at end of file

Spacing +7 added lines, -7 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -65,17 +65,17 @@ 
 		$module_name = 'Activities';
 		$id = $widget_data['focus']->id;
 		$initial_filter = "&record=$id&module_name=$currentModule";
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'detail', true)){
-			$temp =  '<input disabled type="button" name="summary_button" id="summary_button"'
+		if (ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'detail', true)) {
+			$temp = '<input disabled type="button" name="summary_button" id="summary_button"'
 			. ' class="button"'
-			. ' title="' . $title . '"'
-			. ' value="' . $value . '"';
+			. ' title="'.$title.'"'
+			. ' value="'.$value.'"';
 			return $temp;
 		}
 		return '<input type="button" name="summary_button" id="summary_button"'
 			. ' class="button"'
-			. ' title="' . $title . '"'
-			. ' value="' . $value . '"'
+			. ' title="'.$title.'"'
+			. ' value="'.$value.'"'
 			. " onclick='open_popup(\"$module_name\",600,400,\"$initial_filter\",false,false,$json_encoded_php_array);' />\n";
 	}
 }

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetFielddatepicker.php

Indentation +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 
 class SugarWidgetFieldDatePicker extends SugarWidgetFieldDateTime
 {
-	function displayInput($layout_def)
+    function displayInput($layout_def)
     {
         global $timedate;
 

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelEmailLink.php

Braces +18 added lines, -7 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -62,14 +64,23 @@ 
 
 
 
-			if(isset($_REQUEST['action'])) $action = $_REQUEST['action'];
-			else $action = '';
+			if(isset($_REQUEST['action'])) {
+			    $action = $_REQUEST['action'];
+			} else {
+			    $action = '';
+			}
 
-			if(isset($_REQUEST['module'])) $module = $_REQUEST['module'];
-			else $module = '';
+			if(isset($_REQUEST['module'])) {
+			    $module = $_REQUEST['module'];
+			} else {
+			    $module = '';
+			}
 
-			if(isset($_REQUEST['record'])) $record = $_REQUEST['record'];
-			else $record = '';
+			if(isset($_REQUEST['record'])) {
+			    $record = $_REQUEST['record'];
+			} else {
+			    $record = '';
+			}
 
 			if (!empty($focus->name)) {
 				$name = $focus->name;

Indentation +58 added lines, -58 removed lines

@@ -45,62 +45,62 @@ 
 
 class SugarWidgetSubPanelEmailLink extends SugarWidgetField {
 
-	function displayList($layout_def) {
-		global $current_user;
-		global $beanList;
-		global $focus;
-		global $sugar_config;
-		global $locale;
-
-		if(isset($layout_def['varname'])) {
-			$key = strtoupper($layout_def['varname']);
-		} else {
-			$key = $this->_get_column_alias($layout_def);
-			$key = strtoupper($key);
-		}
-		$value = $layout_def['fields'][$key];
-
-
-
-			if(isset($_REQUEST['action'])) $action = $_REQUEST['action'];
-			else $action = '';
-
-			if(isset($_REQUEST['module'])) $module = $_REQUEST['module'];
-			else $module = '';
-
-			if(isset($_REQUEST['record'])) $record = $_REQUEST['record'];
-			else $record = '';
-
-			if (!empty($focus->name)) {
-				$name = $focus->name;
-			} else {
-				if( !empty($focus->first_name) && !empty($focus->last_name)) {
-					$name = $locale->getLocaleFormattedName($focus->first_name, $focus->last_name);
-					}
-				if(empty($name)) {
-					$name = '*';
-				}
-			}
-
-			$userPref = $current_user->getPreference('email_link_type');
-			$defaultPref = $sugar_config['email_default_client'];
-			if($userPref != '') {
-				$client = $userPref;
-			} else {
-				$client = $defaultPref;
-			}
-
-			if($client == 'sugar')
-			{
-			    $composeData = array(
-			        'load_id' => $layout_def['fields']['ID'],
+    function displayList($layout_def) {
+        global $current_user;
+        global $beanList;
+        global $focus;
+        global $sugar_config;
+        global $locale;
+
+        if(isset($layout_def['varname'])) {
+            $key = strtoupper($layout_def['varname']);
+        } else {
+            $key = $this->_get_column_alias($layout_def);
+            $key = strtoupper($key);
+        }
+        $value = $layout_def['fields'][$key];
+
+
+
+            if(isset($_REQUEST['action'])) $action = $_REQUEST['action'];
+            else $action = '';
+
+            if(isset($_REQUEST['module'])) $module = $_REQUEST['module'];
+            else $module = '';
+
+            if(isset($_REQUEST['record'])) $record = $_REQUEST['record'];
+            else $record = '';
+
+            if (!empty($focus->name)) {
+                $name = $focus->name;
+            } else {
+                if( !empty($focus->first_name) && !empty($focus->last_name)) {
+                    $name = $locale->getLocaleFormattedName($focus->first_name, $focus->last_name);
+                    }
+                if(empty($name)) {
+                    $name = '*';
+                }
+            }
+
+            $userPref = $current_user->getPreference('email_link_type');
+            $defaultPref = $sugar_config['email_default_client'];
+            if($userPref != '') {
+                $client = $userPref;
+            } else {
+                $client = $defaultPref;
+            }
+
+            if($client == 'sugar')
+            {
+                $composeData = array(
+                    'load_id' => $layout_def['fields']['ID'],
                     'load_module' => $this->layout_manager->defs['module_name'],
                     'parent_type' => $this->layout_manager->defs['module_name'],
                     'parent_id' => $layout_def['fields']['ID'],
-			        'return_module' => $module,
-			        'return_action' => $action,
-			        'return_id' => $record
-			    );
+                    'return_module' => $module,
+                    'return_action' => $action,
+                    'return_id' => $record
+                );
                 if(isset($layout_def['fields']['FULL_NAME'])){
                     $composeData['parent_name'] = $layout_def['fields']['FULL_NAME'];
                     $composeData['to_email_addrs'] = sprintf("%s <%s>", $layout_def['fields']['FULL_NAME'], $layout_def['fields']['EMAIL1']);
@@ -110,11 +110,11 @@ 
                 require_once('modules/Emails/EmailUI.php');
                 $emailUi = new EmailUI();
                 $link = $emailUi->populateComposeViewFields();
-			} else {
-				$link = '<a href="mailto:' . $value .'" >';
-			}
+            } else {
+                $link = '<a href="mailto:' . $value .'" >';
+            }
 
-			return $link.$value.'</a>';
+            return $link.$value.'</a>';
 
-	}
+    }
 } // end class def

Spacing +11 added lines, -11 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,7 +52,7 @@ 
 		global $sugar_config;
 		global $locale;
 
-		if(isset($layout_def['varname'])) {
+		if (isset($layout_def['varname'])) {
 			$key = strtoupper($layout_def['varname']);
 		} else {
 			$key = $this->_get_column_alias($layout_def);
@@ -62,35 +62,35 @@ 
 
 
 
-			if(isset($_REQUEST['action'])) $action = $_REQUEST['action'];
+			if (isset($_REQUEST['action'])) $action = $_REQUEST['action'];
 			else $action = '';
 
-			if(isset($_REQUEST['module'])) $module = $_REQUEST['module'];
+			if (isset($_REQUEST['module'])) $module = $_REQUEST['module'];
 			else $module = '';
 
-			if(isset($_REQUEST['record'])) $record = $_REQUEST['record'];
+			if (isset($_REQUEST['record'])) $record = $_REQUEST['record'];
 			else $record = '';
 
 			if (!empty($focus->name)) {
 				$name = $focus->name;
 			} else {
-				if( !empty($focus->first_name) && !empty($focus->last_name)) {
+				if (!empty($focus->first_name) && !empty($focus->last_name)) {
 					$name = $locale->getLocaleFormattedName($focus->first_name, $focus->last_name);
 					}
-				if(empty($name)) {
+				if (empty($name)) {
 					$name = '*';
 				}
 			}
 
 			$userPref = $current_user->getPreference('email_link_type');
 			$defaultPref = $sugar_config['email_default_client'];
-			if($userPref != '') {
+			if ($userPref != '') {
 				$client = $userPref;
 			} else {
 				$client = $defaultPref;
 			}
 
-			if($client == 'sugar')
+			if ($client == 'sugar')
 			{
 			    $composeData = array(
 			        'load_id' => $layout_def['fields']['ID'],
@@ -101,7 +101,7 @@ 
 			        'return_action' => $action,
 			        'return_id' => $record
 			    );
-                if(isset($layout_def['fields']['FULL_NAME'])){
+                if (isset($layout_def['fields']['FULL_NAME'])) {
                     $composeData['parent_name'] = $layout_def['fields']['FULL_NAME'];
                     $composeData['to_email_addrs'] = sprintf("%s <%s>", $layout_def['fields']['FULL_NAME'], $layout_def['fields']['EMAIL1']);
                 } else {
@@ -111,7 +111,7 @@ 
                 $emailUi = new EmailUI();
                 $link = $emailUi->populateComposeViewFields();
 			} else {
-				$link = '<a href="mailto:' . $value .'" >';
+				$link = '<a href="mailto:'.$value.'" >';
 			}
 
 			return $link.$value.'</a>';

include/generic/SugarWidgets/SugarWidgetSubPanelTopCreateTaskButton.php

Indentation +114 added lines, -114 removed lines

@@ -45,121 +45,121 @@
 
 class SugarWidgetSubPanelTopCreateTaskButton extends SugarWidgetSubPanelTopButtonQuickCreate
 {
-	function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
-	{
-		global $app_strings;
-		global $currentModule;
-
-		$this->module="Tasks";
-		$this->subpanelDiv = "activities";
-
-		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
-		{
-			foreach($this->additional_form_fields as $key=>$value)
-			{
-				if(!empty($defines['focus']->$value))
-				{
-					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
-				{
-					$additionalFormFields[$key] = '';
-				}
-			}
-		}
-
-		if(!empty($this->module))
-		{
-			$defines['child_module_name'] = $this->module;
-		}
-		else
-		{
-			$defines['child_module_name'] = $defines['module'];
-		}
-
-		if(empty($defines['subpanelDiv']))
-		{
-			$defines['subpanelDiv'] = $this->subpanelDiv;
-		}
-
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
-
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
-
-		//module_button is used to override the value of module name
-		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
-		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
-
-		if(isset($defines['focus']->name))
-		{
-			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
-		}
-
-		$button .= '<input type="hidden" name="to_pdf" value="true" />';
+    function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
+    {
+        global $app_strings;
+        global $currentModule;
+
+        $this->module="Tasks";
+        $this->subpanelDiv = "activities";
+
+        // Create the additional form fields with real values if they were not passed in
+        if(empty($additionalFormFields) && $this->additional_form_fields)
+        {
+            foreach($this->additional_form_fields as $key=>$value)
+            {
+                if(!empty($defines['focus']->$value))
+                {
+                    $additionalFormFields[$key] = $defines['focus']->$value;
+                }
+                else
+                {
+                    $additionalFormFields[$key] = '';
+                }
+            }
+        }
+
+        if(!empty($this->module))
+        {
+            $defines['child_module_name'] = $this->module;
+        }
+        else
+        {
+            $defines['child_module_name'] = $defines['module'];
+        }
+
+        if(empty($defines['subpanelDiv']))
+        {
+            $defines['subpanelDiv'] = $this->subpanelDiv;
+        }
+
+        $defines['parent_bean_name'] = get_class( $defines['focus']);
+
+        $form = 'form' . $defines['child_module_name'];
+        $button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+
+        //module_button is used to override the value of module name
+        $button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
+        $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
+
+        if(isset($defines['focus']->name))
+        {
+            $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
+        }
+
+        $button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
-		$button .= '<input type="hidden" name="record" value="" />';
-
-		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
-				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
-			}
-		}
-		if(empty($additionalFormFields['parent_name']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
-				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
-				$additionalFormFields['parent_name'] = $defines['focus']->name;
-			}
-		}
-		if(empty($additionalFormFields['parent_id']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
-				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
-				$additionalFormFields['parent_id'] = $defines['focus']->id;
-			}
-		}
-
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
-
-		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
-		{
-			if($key != 'action')
-			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
-			}
-		}
-
-		return $button;
-	}
-
-
-	function display($defines, $additionalFormFields = null, $nonbutton = false)
-	{
-	    $focus = new Task;
-		if ( !$focus->ACLAccess('EditView') ) {
-		    return '';
-	    }
+        $button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
+        $button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
+        $button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+        $button .= '<input type="hidden" name="record" value="" />';
+
+        // TODO: move this out and get $additionalFormFields working properly
+        if(empty($additionalFormFields['parent_type']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_type'] = 'Accounts';
+            }
+            else {
+                $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
+            }
+        }
+        if(empty($additionalFormFields['parent_name']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_name'] = $defines['focus']->account_name;
+                $additionalFormFields['account_name'] = $defines['focus']->account_name;
+            }
+            else {
+                $additionalFormFields['parent_name'] = $defines['focus']->name;
+            }
+        }
+        if(empty($additionalFormFields['parent_id']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_id'] = $defines['focus']->account_id;
+                $additionalFormFields['account_id'] = $defines['focus']->account_id;
+            }
+            else {
+                $additionalFormFields['parent_id'] = $defines['focus']->id;
+            }
+        }
+
+        $button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
+        $button .= '<input type="hidden" name="module" value="Home" />' . "\n";
+        $button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+
+        // fill in additional form fields for all but action
+        foreach($additionalFormFields as $key => $value)
+        {
+            if($key != 'action')
+            {
+                $button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+            }
+        }
+
+        return $button;
+    }
+
+
+    function display($defines, $additionalFormFields = null, $nonbutton = false)
+    {
+        $focus = new Task;
+        if ( !$focus->ACLAccess('EditView') ) {
+            return '';
+        }
 		
-		return parent::display($defines, $additionalFormFields);
-	}
+        return parent::display($defines, $additionalFormFields);
+    }
 }
 ?>

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,15 +50,15 @@ 
 		global $app_strings;
 		global $currentModule;
 
-		$this->module="Tasks";
+		$this->module = "Tasks";
 		$this->subpanelDiv = "activities";
 
 		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
+		if (empty($additionalFormFields) && $this->additional_form_fields)
 		{
-			foreach($this->additional_form_fields as $key=>$value)
+			foreach ($this->additional_form_fields as $key=>$value)
 			{
-				if(!empty($defines['focus']->$value))
+				if (!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
 				}
@@ -69,7 +69,7 @@ 
 			}
 		}
 
-		if(!empty($this->module))
+		if (!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
 		}
@@ -78,45 +78,45 @@ 
 			$defines['child_module_name'] = $defines['module'];
 		}
 
-		if(empty($defines['subpanelDiv']))
+		if (empty($defines['subpanelDiv']))
 		{
 			$defines['subpanelDiv'] = $this->subpanelDiv;
 		}
 
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
+		$defines['parent_bean_name'] = get_class($defines['focus']);
 
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+		$form = 'form'.$defines['child_module_name'];
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.strtolower($defines['subpanelDiv']).'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
 
 		//module_button is used to override the value of module name
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
 
-		if(isset($defines['focus']->name))
+		if (isset($defines['focus']->name))
 		{
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
 		}
 
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
 		$button .= '<input type="hidden" name="record" value="" />';
 
 		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
+		if (empty($additionalFormFields['parent_type']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
 			}
 			else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
-		if(empty($additionalFormFields['parent_name']))
+		if (empty($additionalFormFields['parent_name']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
 			}
@@ -124,9 +124,9 @@ 
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
-		if(empty($additionalFormFields['parent_id']))
+		if (empty($additionalFormFields['parent_id']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
 			}
@@ -135,16 +135,16 @@ 
 			}
 		}
 
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
 
 		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
+		foreach ($additionalFormFields as $key => $value)
 		{
-			if($key != 'action')
+			if ($key != 'action')
 			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+				$button .= '<input type="hidden" name="'.$key.'" value="'.$value.'" />'."\n";
 			}
 		}
 
@@ -155,7 +155,7 @@ 
 	function display($defines, $additionalFormFields = null, $nonbutton = false)
 	{
 	    $focus = new Task;
-		if ( !$focus->ACLAccess('EditView') ) {
+		if (!$focus->ACLAccess('EditView')) {
 		    return '';
 	    }
 		

Braces +8 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,8 +63,7 @@ 
 				if(!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
+				} else
 				{
 					$additionalFormFields[$key] = '';
 				}
@@ -72,8 +73,7 @@ 
 		if(!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
-		}
-		else
+		} else
 		{
 			$defines['child_module_name'] = $defines['module'];
 		}
@@ -109,8 +109,7 @@ 
 		{
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
@@ -119,8 +118,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
@@ -129,8 +127,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_id'] = $defines['focus']->id;
 			}
 		}