adamjakab / SuiteCRM

modules/UpgradeWizard/silentUpgrade_step1.php

Spacing +202 added lines, -202 removed lines

@@ -42,7 +42,7 @@ 
 //// php.exe -f silentUpgrade.php [Path to Upgrade Package zip] [Path to Log file] [Path to Instance]
 //// See below the Usage for more details.
 /////////////////////////////////////////////////////////////////////////////////////////
-ini_set('memory_limit',-1);
+ini_set('memory_limit', -1);
 ///////////////////////////////////////////////////////////////////////////////
 ////	UTILITIES THAT MUST BE LOCAL :(
 function prepSystemForUpgradeSilent() {
@@ -51,8 +51,8 @@ 
 	global $sugar_config;
 
 	// make sure dirs exist
-	foreach($subdirs as $subdir) {
-		if(!is_dir($sugar_config['upload_dir']."/upgrades/{$subdir}")) {
+	foreach ($subdirs as $subdir) {
+		if (!is_dir($sugar_config['upload_dir']."/upgrades/{$subdir}")) {
 	    	mkdir_recursive($sugar_config['upload_dir']."/upgrades/{$subdir}");
 		}
 	}
@@ -63,11 +63,11 @@ 
 	if ($current = @opendir($thedir)) {
 		while (false !== ($children = readdir($current))) {
 			if ($children != "." && $children != "..") {
-				if (is_dir($thedir . "/" . $children)) {
-					clearCacheSU($thedir . "/" . $children, $extension);
+				if (is_dir($thedir."/".$children)) {
+					clearCacheSU($thedir."/".$children, $extension);
 				}
-				elseif (is_file($thedir . "/" . $children) && substr_count($children, $extension)) {
-					unlink($thedir . "/" . $children);
+				elseif (is_file($thedir."/".$children) && substr_count($children, $extension)) {
+					unlink($thedir."/".$children);
 				}
 			}
 		}
@@ -75,34 +75,34 @@ 
  }
  //Bug 24890, 24892. default_permissions not written to config.php. Following function checks and if
  //no found then adds default_permissions to the config file.
- function checkConfigForPermissions(){
-     if(file_exists(getcwd().'/config.php')){
+ function checkConfigForPermissions() {
+     if (file_exists(getcwd().'/config.php')) {
          require(getcwd().'/config.php');
      }
      global $sugar_config;
-     if(!isset($sugar_config['default_permissions'])){
-             $sugar_config['default_permissions'] = array (
+     if (!isset($sugar_config['default_permissions'])) {
+             $sugar_config['default_permissions'] = array(
                      'dir_mode' => 02770,
                      'file_mode' => 0660,
                      'user' => '',
                      'group' => '',
              );
          ksort($sugar_config);
-         if(is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+         if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
         	//writing to the file
  		}
      }
 }
-function checkLoggerSettings(){
-	if(file_exists(getcwd().'/config.php')){
+function checkLoggerSettings() {
+	if (file_exists(getcwd().'/config.php')) {
          require(getcwd().'/config.php');
      }
     global $sugar_config;
-	if(!isset($sugar_config['logger'])){
-	    $sugar_config['logger'] =array (
+	if (!isset($sugar_config['logger'])) {
+	    $sugar_config['logger'] = array(
 			'level'=>'fatal',
 		    'file' =>
-		     array (
+		     array(
 		      'ext' => '.log',
 		      'name' => 'sugarcrm',
 		      'dateFormat' => '%c',
@@ -112,7 +112,7 @@ 
 		    ),
 		  );
 		 ksort($sugar_config);
-         if(is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+         if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
         	//writing to the file
  		}
 	 }
@@ -126,23 +126,23 @@ 
     if (!isset($sugar_config['lead_conv_activity_opt'])) {
         $sugar_config['lead_conv_activity_opt'] = 'copy';
         ksort($sugar_config);
-        if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+        if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
             //writing to the file
         }
     }
 }
 
-function checkResourceSettings(){
-	if(file_exists(getcwd().'/config.php')){
+function checkResourceSettings() {
+	if (file_exists(getcwd().'/config.php')) {
          require(getcwd().'/config.php');
      }
     global $sugar_config;
-	if(!isset($sugar_config['resource_management'])){
+	if (!isset($sugar_config['resource_management'])) {
 	  $sugar_config['resource_management'] =
-		  array (
+		  array(
 		    'special_query_limit' => 50000,
 		    'special_query_modules' =>
-		    array (
+		    array(
 		      0 => 'Reports',
 		      1 => 'Export',
 		      2 => 'Import',
@@ -152,23 +152,23 @@ 
 		    'default_limit' => 1000,
 		  );
 		 ksort($sugar_config);
-         if(is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+         if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
         	//writing to the file
  		}
 	}
 }
 
 
-function createMissingRels(){
-	$relForObjects = array('leads'=>'Leads','campaigns'=>'Campaigns','prospects'=>'Prospects');
-	foreach($relForObjects as $relObjName=>$relModName){
+function createMissingRels() {
+	$relForObjects = array('leads'=>'Leads', 'campaigns'=>'Campaigns', 'prospects'=>'Prospects');
+	foreach ($relForObjects as $relObjName=>$relModName) {
 		//assigned_user
 		$guid = create_guid();
 		$query = "SELECT id FROM relationships WHERE relationship_name = '{$relObjName}_assigned_user'";
-		$result= $GLOBALS['db']->query($query, true);
+		$result = $GLOBALS['db']->query($query, true);
 		$a = null;
 		$a = $GLOBALS['db']->fetchByAssoc($result);
-		if(!isset($a['id']) && empty($a['id']) ){
+		if (!isset($a['id']) && empty($a['id'])) {
 			$qRel = "INSERT INTO relationships (id,relationship_name, lhs_module, lhs_table, lhs_key, rhs_module, rhs_table, rhs_key, join_table, join_key_lhs, join_key_rhs, relationship_type, relationship_role_column, relationship_role_column_value, reverse, deleted)
 						VALUES ('{$guid}', '{$relObjName}_assigned_user','Users','users','id','{$relModName}','{$relObjName}','assigned_user_id',NULL,NULL,NULL,'one-to-many',NULL,NULL,'0','0')";
 			$GLOBALS['db']->query($qRel);
@@ -176,10 +176,10 @@ 
 		//modified_user
 		$guid = create_guid();
 		$query = "SELECT id FROM relationships WHERE relationship_name = '{$relObjName}_modified_user'";
-		$result= $GLOBALS['db']->query($query, true);
+		$result = $GLOBALS['db']->query($query, true);
 		$a = null;
 		$a = $GLOBALS['db']->fetchByAssoc($result);
-		if(!isset($a['id']) && empty($a['id']) ){
+		if (!isset($a['id']) && empty($a['id'])) {
 			$qRel = "INSERT INTO relationships (id,relationship_name, lhs_module, lhs_table, lhs_key, rhs_module, rhs_table, rhs_key, join_table, join_key_lhs, join_key_rhs, relationship_type, relationship_role_column, relationship_role_column_value, reverse, deleted)
 						VALUES ('{$guid}', '{$relObjName}_modified_user','Users','users','id','{$relModName}','{$relObjName}','modified_user_id',NULL,NULL,NULL,'one-to-many',NULL,NULL,'0','0')";
 			$GLOBALS['db']->query($qRel);
@@ -187,20 +187,20 @@ 
 		//created_by
 		$guid = create_guid();
 		$query = "SELECT id FROM relationships WHERE relationship_name = '{$relObjName}_created_by'";
-		$result= $GLOBALS['db']->query($query, true);
+		$result = $GLOBALS['db']->query($query, true);
 		$a = null;
 		$a = $GLOBALS['db']->fetchByAssoc($result);
-    	if(!isset($a['id']) && empty($a['id']) ){
+    	if (!isset($a['id']) && empty($a['id'])) {
 			$qRel = "INSERT INTO relationships (id,relationship_name, lhs_module, lhs_table, lhs_key, rhs_module, rhs_table, rhs_key, join_table, join_key_lhs, join_key_rhs, relationship_type, relationship_role_column, relationship_role_column_value, reverse, deleted)
 						VALUES ('{$guid}', '{$relObjName}_created_by','Users','users','id','{$relModName}','{$relObjName}','created_by',NULL,NULL,NULL,'one-to-many',NULL,NULL,'0','0')";
 			$GLOBALS['db']->query($qRel);
     	}
 		$guid = create_guid();
 		$query = "SELECT id FROM relationships WHERE relationship_name = '{$relObjName}_team'";
-		$result= $GLOBALS['db']->query($query, true);
+		$result = $GLOBALS['db']->query($query, true);
 		$a = null;
 		$a = $GLOBALS['db']->fetchByAssoc($result);
-		if(!isset($a['id']) && empty($a['id']) ){
+		if (!isset($a['id']) && empty($a['id'])) {
 			$qRel = "INSERT INTO relationships (id,relationship_name, lhs_module, lhs_table, lhs_key, rhs_module, rhs_table, rhs_key, join_table, join_key_lhs, join_key_rhs, relationship_type, relationship_role_column, relationship_role_column_value, reverse, deleted)
 							VALUES ('{$guid}', '{$relObjName}_team','Teams','teams','id','{$relModName}','{$relObjName}','team_id',NULL,NULL,NULL,'one-to-many',NULL,NULL,'0','0')";
 			$GLOBALS['db']->query($qRel);
@@ -209,10 +209,10 @@ 
 	//Also add tracker perf relationship
 	$guid = create_guid();
 	$query = "SELECT id FROM relationships WHERE relationship_name = 'tracker_monitor_id'";
-	$result= $GLOBALS['db']->query($query, true);
+	$result = $GLOBALS['db']->query($query, true);
 	$a = null;
 	$a = $GLOBALS['db']->fetchByAssoc($result);
-	if(!isset($a['id']) && empty($a['id']) ){
+	if (!isset($a['id']) && empty($a['id'])) {
 		$qRel = "INSERT INTO relationships (id,relationship_name, lhs_module, lhs_table, lhs_key, rhs_module, rhs_table, rhs_key, join_table, join_key_lhs, join_key_rhs, relationship_type, relationship_role_column, relationship_role_column_value, reverse, deleted)
 					VALUES ('{$guid}', 'tracker_monitor_id','TrackerPerfs','tracker_perf','monitor_id','Trackers','tracker','monitor_id',NULL,NULL,NULL,'one-to-many',NULL,NULL,'0','0')";
 		$GLOBALS['db']->query($qRel);
@@ -228,8 +228,8 @@ 
  */
 function merge_passwordsetting($sugar_config, $sugar_version) {
 
-     $passwordsetting_defaults = array (
-        'passwordsetting' => array (
+     $passwordsetting_defaults = array(
+        'passwordsetting' => array(
             'minpwdlength' => '',
             'maxpwdlength' => '',
             'oneupper' => '',
@@ -260,14 +260,14 @@ 
         ),
     );
 
-    $sugar_config = sugarArrayMerge($passwordsetting_defaults, $sugar_config );
+    $sugar_config = sugarArrayMerge($passwordsetting_defaults, $sugar_config);
 
     // need to override version with default no matter what
     $sugar_config['sugar_version'] = $sugar_version;
 
-    ksort( $sugar_config );
+    ksort($sugar_config);
 
-    if( write_array_to_file( "sugar_config", $sugar_config, "config.php" ) ){
+    if (write_array_to_file("sugar_config", $sugar_config, "config.php")) {
         return true;
     }
     else {
@@ -276,17 +276,17 @@ 
 }
 
 function addDefaultModuleRoles($defaultRoles = array()) {
-	foreach($defaultRoles as $roleName=>$role){
-        foreach($role as $category=>$actions){
-            foreach($actions as $name=>$access_override){
+	foreach ($defaultRoles as $roleName=>$role) {
+        foreach ($role as $category=>$actions) {
+            foreach ($actions as $name=>$access_override) {
                     $query = "SELECT * FROM acl_actions WHERE name='$name' AND category = '$category' AND acltype='$roleName' AND deleted=0 ";
 					$result = $GLOBALS['db']->query($query);
 					//only add if an action with that name and category don't exist
-					$row=$GLOBALS['db']->fetchByAssoc($result);
+					$row = $GLOBALS['db']->fetchByAssoc($result);
 					if ($row == null) {
 	                	$guid = create_guid();
 	                	$currdate = gmdate('Y-m-d H:i:s');
-	                	$query= "INSERT INTO acl_actions (id,date_entered,date_modified,modified_user_id,name,category,acltype,aclaccess,deleted ) VALUES ('$guid','$currdate','$currdate','1','$name','$category','$roleName','$access_override','0')";
+	                	$query = "INSERT INTO acl_actions (id,date_entered,date_modified,modified_user_id,name,category,acltype,aclaccess,deleted ) VALUES ('$guid','$currdate','$currdate','1','$name','$category','$roleName','$access_override','0')";
 						$GLOBALS['db']->query($query);
 	                }
             }
@@ -294,11 +294,11 @@ 
 	}
 }
 
-function verifyArguments($argv,$usage_regular){
+function verifyArguments($argv, $usage_regular) {
     $upgradeType = '';
     $cwd = getcwd(); // default to current, assumed to be in a valid SugarCRM root dir.
-    if(isset($argv[3])) {
-        if(is_dir($argv[3])) {
+    if (isset($argv[3])) {
+        if (is_dir($argv[3])) {
             $cwd = $argv[3];
             chdir($cwd);
         } else {
@@ -308,18 +308,18 @@ 
         }
     }
 
-    if(is_file("{$cwd}/include/entryPoint.php")) {
+    if (is_file("{$cwd}/include/entryPoint.php")) {
         //this should be a regular sugar install
         $upgradeType = constant('SUGARCRM_INSTALL');
         //check if this is a valid zip file
-        if(!is_file($argv[1])) { // valid zip?
+        if (!is_file($argv[1])) { // valid zip?
             echo "*******************************************************************************\n";
             echo "*** ERROR: First argument must be a full path to the patch file. Got [ {$argv[1]} ].\n";
             echo $usage_regular;
             echo "FAILURE\n";
             exit(1);
         }
-        if(count($argv) < 5) {
+        if (count($argv) < 5) {
             echo "*******************************************************************************\n";
             echo "*** ERROR: Missing required parameters.  Received ".count($argv)." argument(s), require 5.\n";
             echo $usage_regular;
@@ -333,7 +333,7 @@ 
         exit(1);
     }
 
-    if(isset($argv[7]) && file_exists($argv[7].'SugarTemplateUtilties.php')){
+    if (isset($argv[7]) && file_exists($argv[7].'SugarTemplateUtilties.php')) {
         require_once($argv[7].'SugarTemplateUtilties.php');
     }
 
@@ -342,7 +342,7 @@ 
 
 
 
-function threeWayMerge(){
+function threeWayMerge() {
 	//using threeway merge apis
 }
 
@@ -357,14 +357,14 @@ 
 //End of #52872
 
 // only run from command line
-if(isset($_SERVER['HTTP_USER_AGENT'])) {
-	fwrite(STDERR,'This utility may only be run from the command line or command prompt.');
+if (isset($_SERVER['HTTP_USER_AGENT'])) {
+	fwrite(STDERR, 'This utility may only be run from the command line or command prompt.');
 	exit(1);
 }
 //Clean_string cleans out any file  passed in as a parameter
 $_SERVER['PHP_SELF'] = 'silentUpgrade.php';
 
-$usage_regular =<<<eoq2
+$usage_regular = <<<eoq2
 Usage: php.exe -f silentUpgrade.php [upgradeZipFile] [logFile] [pathToSugarInstance] [admin-user]
 
 On Command Prompt Change directory to where silentUpgrade.php resides. Then type path to
@@ -386,7 +386,7 @@ 
 
 ///////////////////////////////////////////////////////////////////////////////
 ////	STANDARD REQUIRED SUGAR INCLUDES AND PRESETS
-if(!defined('sugarEntry')) define('sugarEntry', true);
+if (!defined('sugarEntry')) define('sugarEntry', true);
 
 $_SESSION = array();
 $_SESSION['schema_change'] = 'sugar'; // we force-run all SQL
@@ -403,13 +403,13 @@ 
 global $cwd;
 $cwd = getcwd(); // default to current, assumed to be in a valid SugarCRM root dir.
 
-$upgradeType = verifyArguments($argv,$usage_regular);
+$upgradeType = verifyArguments($argv, $usage_regular);
 
 ///////////////////////////////////////////////////////////////////////////////
 //////  Verify that all the arguments are appropriately placed////////////////
 
-$path			= $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
-$subdirs		= array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
+$path = $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
+$subdirs = array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
 
 //$_REQUEST['zip_from_dir'] = $zip_from_dir;
 
@@ -431,15 +431,15 @@ 
 $errors = array();
 
 
-if($upgradeType != constant('DCE_INSTANCE')) {
+if ($upgradeType != constant('DCE_INSTANCE')) {
 
-	ini_set('error_reporting',1);
+	ini_set('error_reporting', 1);
 	require_once('include/entryPoint.php');
 	require_once('include/SugarLogger/SugarLogger.php');
 	require_once('include/utils/zip_utils.php');
 
 
-if(!function_exists('sugar_cached'))
+if (!function_exists('sugar_cached'))
 {
     /**
      * sugar_cached
@@ -450,10 +450,10 @@ 
     function sugar_cached($file)
     {
         static $cdir = null;
-        if(empty($cdir) && !empty($GLOBALS['sugar_config']['cache_dir'])) {
+        if (empty($cdir) && !empty($GLOBALS['sugar_config']['cache_dir'])) {
             $cdir = rtrim($GLOBALS['sugar_config']['cache_dir'], '/\\');
         }
-        if(empty($cdir)) {
+        if (empty($cdir)) {
             $cdir = "cache";
         }
         return "$cdir/$file";
@@ -462,8 +462,8 @@ 
 
 	require('config.php');
 	//require_once('modules/UpgradeWizard/uw_utils.php'); // must upgrade UW first
-	if(isset($argv[3])) {
-		if(is_dir($argv[3])) {
+	if (isset($argv[3])) {
+		if (is_dir($argv[3])) {
 			$cwd = $argv[3];
 			chdir($cwd);
 		}
@@ -471,37 +471,37 @@ 
 
 	require_once("{$cwd}/sugar_version.php"); // provides $sugar_version & $sugar_flavor
 
-    $GLOBALS['log']	= LoggerManager::getLogger('SugarCRM');
-	$patchName		= basename($argv[1]);
-	$zip_from_dir	= substr($patchName, 0, strlen($patchName) - 4); // patch folder name (minus ".zip")
-	$path			= $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
+    $GLOBALS['log'] = LoggerManager::getLogger('SugarCRM');
+	$patchName = basename($argv[1]);
+	$zip_from_dir = substr($patchName, 0, strlen($patchName) - 4); // patch folder name (minus ".zip")
+	$path = $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
 
-    $db				= &DBManagerFactory::getInstance();
-	$UWstrings		= return_module_language('en_us', 'UpgradeWizard');
-	$adminStrings	= return_module_language('en_us', 'Administration');
+    $db = &DBManagerFactory::getInstance();
+	$UWstrings = return_module_language('en_us', 'UpgradeWizard');
+	$adminStrings = return_module_language('en_us', 'Administration');
     $app_list_strings = return_app_list_strings_language('en_us');
-	$mod_strings	= array_merge($adminStrings, $UWstrings);
-	$subdirs		= array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
+	$mod_strings = array_merge($adminStrings, $UWstrings);
+	$subdirs = array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
 	global $unzip_dir;
     $license_accepted = false;
-    if(isset($argv[5]) && (strtolower($argv[5])=='yes' || strtolower($argv[5])=='y')){
+    if (isset($argv[5]) && (strtolower($argv[5]) == 'yes' || strtolower($argv[5]) == 'y')) {
     	$license_accepted = true;
 	 }
 	//////////////////////////////////////////////////////////////////////////////
 	//Adding admin user to the silent upgrade
 
 	$current_user = new User();
-	if(isset($argv[4])) {
+	if (isset($argv[4])) {
 	   //if being used for internal upgrades avoid admin user verification
 	   $user_name = $argv[4];
-	   $q = "select id from users where user_name = '" . $user_name . "' and is_admin=1";
+	   $q = "select id from users where user_name = '".$user_name."' and is_admin=1";
 	   $result = $GLOBALS['db']->query($q, false);
 	   $logged_user = $GLOBALS['db']->fetchByAssoc($result);
-	   if(isset($logged_user['id']) && $logged_user['id'] != null){
+	   if (isset($logged_user['id']) && $logged_user['id'] != null) {
 		//do nothing
 	    $current_user->retrieve($logged_user['id']);
 	   }
-	   else{
+	   else {
 	   	echo "FAILURE: Not an admin user in users table. Please provide an admin user\n";
 		exit(1);
 	   }
@@ -533,18 +533,18 @@ 
 $_SESSION['unzip_dir'] = $unzip_dir;
 $_SESSION['install_file'] = $install_file;
 $_SESSION['zip_from_dir'] = $zip_from_dir;
-if(is_dir($unzip_dir.'/scripts'))
+if (is_dir($unzip_dir.'/scripts'))
 {
 	rmdir_recursive($unzip_dir.'/scripts');
 }
-if(is_file($unzip_dir.'/manifest.php'))
+if (is_file($unzip_dir.'/manifest.php'))
 {
 	rmdir_recursive($unzip_dir.'/manifest.php');
 }
 mkdir_recursive($unzip_dir);
-if(!is_dir($unzip_dir)) {
+if (!is_dir($unzip_dir)) {
 	echo "\n{$unzip_dir} is not an available directory\nFAILURE\n";
-	fwrite(STDERR,"\n{$unzip_dir} is not an available directory\nFAILURE\n");
+	fwrite(STDERR, "\n{$unzip_dir} is not an available directory\nFAILURE\n");
 	exit(1);
 }
 
@@ -561,7 +561,7 @@ 
 $uwFiles = findAllFiles("{$zipBasePath}/modules/UpgradeWizard", array());
 $destFiles = array();
 
-foreach($uwFiles as $uwFile) {
+foreach ($uwFiles as $uwFile) {
 	$destFile = str_replace($zipBasePath."/", '', $uwFile);
 	copy($uwFile, $destFile);
 }
@@ -570,17 +570,17 @@ 
 logThis("*** SILENT UPGRADE INITIATED.", $path);
 logThis("*** UpgradeWizard Upgraded  ", $path);
 
-if(function_exists('set_upgrade_vars')){
+if (function_exists('set_upgrade_vars')) {
 	set_upgrade_vars();
 }
 
-if($configOptions['db_type'] == 'mysql'){
+if ($configOptions['db_type'] == 'mysql') {
 	//Change the db wait_timeout for this session
 	$now_timeout = $db->getOne("select @@wait_timeout");
-	logThis('Wait Timeout before change ***** '.$now_timeout , $path);
+	logThis('Wait Timeout before change ***** '.$now_timeout, $path);
 	$db->query("set wait_timeout=28800");	
 	$now_timeout = $db->getOne("select @@wait_timeout");	
-	logThis('Wait Timeout after change ***** '.$now_timeout , $path);
+	logThis('Wait Timeout after change ***** '.$now_timeout, $path);
 }
 
 ////	END UPGRADE UPGRADEWIZARD
@@ -588,24 +588,24 @@ 
 
 ///////////////////////////////////////////////////////////////////////////////
 ////	MAKE SURE PATCH IS COMPATIBLE
-if(is_file("$unzip_dir/manifest.php")) {
+if (is_file("$unzip_dir/manifest.php")) {
 	// provides $manifest array
 	include("$unzip_dir/manifest.php");
-	if(!isset($manifest)) {
-		fwrite(STDERR,"\nThe patch did not contain a proper manifest.php file.  Cannot continue.\n\n");
+	if (!isset($manifest)) {
+		fwrite(STDERR, "\nThe patch did not contain a proper manifest.php file.  Cannot continue.\n\n");
 	    exit(1);
 	} else {
 		copy("$unzip_dir/manifest.php", $sugar_config['upload_dir']."/upgrades/patch/{$zip_from_dir}-manifest.php");
 
 		$error = validate_manifest($manifest);
-		if(!empty($error)) {
+		if (!empty($error)) {
 			$error = strip_tags(br2nl($error));
-			fwrite(STDERR,"\n{$error}\n\nFAILURE\n");
+			fwrite(STDERR, "\n{$error}\n\nFAILURE\n");
 			exit(1);
 		}
 	}
 } else {
-	fwrite(STDERR,"\nThe patch did not contain a proper manifest.php file.  Cannot continue.\n\n");
+	fwrite(STDERR, "\nThe patch did not contain a proper manifest.php file.  Cannot continue.\n\n");
 	exit(1);
 }
 
@@ -623,17 +623,17 @@ 
 ////	RUN SILENT UPGRADE
 ob_start();
 set_time_limit(0);
-if(file_exists('ModuleInstall/PackageManager/PackageManagerDisplay.php')) {
+if (file_exists('ModuleInstall/PackageManager/PackageManagerDisplay.php')) {
 	require_once('ModuleInstall/PackageManager/PackageManagerDisplay.php');
 }
 
 
 	//copy minimum required files including sugar_file_utils.php
-	if(file_exists("{$zipBasePath}/include/utils/sugar_file_utils.php")){
+	if (file_exists("{$zipBasePath}/include/utils/sugar_file_utils.php")) {
 		$destFile = clean_path(str_replace($zipBasePath, $cwd, "{$zipBasePath}/include/utils/sugar_file_utils.php"));
 		copy("{$zipBasePath}/include/utils/sugar_file_utils.php", $destFile);
 	}
-	if(file_exists('include/utils/sugar_file_utils.php')){
+	if (file_exists('include/utils/sugar_file_utils.php')) {
     	require_once('include/utils/sugar_file_utils.php');
     }
 
@@ -648,60 +648,60 @@ 
 }
 */
 //If version less than 500 then look for modules to be upgraded
-if(function_exists('set_upgrade_vars')){
+if (function_exists('set_upgrade_vars')) {
 	set_upgrade_vars();
 }
 //Initialize the session variables. If upgrade_progress.php is already created
 //look for session vars there and restore them
-if(function_exists('initialize_session_vars')){
+if (function_exists('initialize_session_vars')) {
 	initialize_session_vars();
 }
 
-if(!didThisStepRunBefore('preflight')){
-	set_upgrade_progress('preflight','in_progress');
+if (!didThisStepRunBefore('preflight')) {
+	set_upgrade_progress('preflight', 'in_progress');
 	//Quickcreatedefs on the basis of editviewdefs
     updateQuickCreateDefs();
-	set_upgrade_progress('preflight','done');
+	set_upgrade_progress('preflight', 'done');
 }
 ////////////////COMMIT PROCESS BEGINS///////////////////////////////////////////////////////////////
 ////	MAKE BACKUPS OF TARGET FILES
 
-if(!didThisStepRunBefore('commit')){
-	set_upgrade_progress('commit','in_progress','commit','in_progress');
-	if(!didThisStepRunBefore('commit','commitMakeBackupFiles')){
-		set_upgrade_progress('commit','in_progress','commitMakeBackupFiles','in_progress');
+if (!didThisStepRunBefore('commit')) {
+	set_upgrade_progress('commit', 'in_progress', 'commit', 'in_progress');
+	if (!didThisStepRunBefore('commit', 'commitMakeBackupFiles')) {
+		set_upgrade_progress('commit', 'in_progress', 'commitMakeBackupFiles', 'in_progress');
 		$errors = commitMakeBackupFiles($rest_dir, $install_file, $unzip_dir, $zip_from_dir, array());
-		set_upgrade_progress('commit','in_progress','commitMakeBackupFiles','done');
+		set_upgrade_progress('commit', 'in_progress', 'commitMakeBackupFiles', 'done');
 	}
 
 	//Need to make sure we have the matching copy of SetValueAction for static/instance method matching
-    if(file_exists("include/Expressions/Actions/SetValueAction.php")){
+    if (file_exists("include/Expressions/Actions/SetValueAction.php")) {
         require_once("include/Expressions/Actions/SetValueAction.php");
     }
 
 	///////////////////////////////////////////////////////////////////////////////
 	////	HANDLE PREINSTALL SCRIPTS
-	if(empty($errors)) {
+	if (empty($errors)) {
 		$file = "{$unzip_dir}/".constant('SUGARCRM_PRE_INSTALL_FILE');
 
-		if(is_file($file)) {
+		if (is_file($file)) {
 			include($file);
-			if(!didThisStepRunBefore('commit','pre_install')){
-				set_upgrade_progress('commit','in_progress','pre_install','in_progress');
+			if (!didThisStepRunBefore('commit', 'pre_install')) {
+				set_upgrade_progress('commit', 'in_progress', 'pre_install', 'in_progress');
 				pre_install();
-				set_upgrade_progress('commit','in_progress','pre_install','done');
+				set_upgrade_progress('commit', 'in_progress', 'pre_install', 'done');
 			}
 		}
 	}
 
 	//Clean smarty from cache
 	$cachedir = sugar_cached('smarty');
-	if(is_dir($cachedir)){
+	if (is_dir($cachedir)) {
 		$allModFiles = array();
-		$allModFiles = findAllFiles($cachedir,$allModFiles);
-	   foreach($allModFiles as $file){
+		$allModFiles = findAllFiles($cachedir, $allModFiles);
+	   foreach ($allModFiles as $file) {
 	       	//$file_md5_ref = str_replace(clean_path(getcwd()),'',$file);
-	       	if(file_exists($file)){
+	       	if (file_exists($file)) {
 				unlink($file);
 	       	}
 	   }
@@ -709,29 +709,29 @@ 
 
 		//Also add the three-way merge here. The idea is after the 451 html files have
 		//been converted run the 3-way merge. If 500 then just run the 3-way merge
-		if(file_exists('modules/UpgradeWizard/SugarMerge/SugarMerge.php')){
-		    set_upgrade_progress('end','in_progress','threewaymerge','in_progress');
+		if (file_exists('modules/UpgradeWizard/SugarMerge/SugarMerge.php')) {
+		    set_upgrade_progress('end', 'in_progress', 'threewaymerge', 'in_progress');
 		    require_once('modules/UpgradeWizard/SugarMerge/SugarMerge.php');
 		    $merger = new SugarMerge($zipBasePath);
 		    $merger->mergeAll();
-		    set_upgrade_progress('end','in_progress','threewaymerge','done');
+		    set_upgrade_progress('end', 'in_progress', 'threewaymerge', 'done');
 		}
 	///////////////////////////////////////////////////////////////////////////////
 	////	COPY NEW FILES INTO TARGET INSTANCE
 
-     if(!didThisStepRunBefore('commit','commitCopyNewFiles')){
-			set_upgrade_progress('commit','in_progress','commitCopyNewFiles','in_progress');
+     if (!didThisStepRunBefore('commit', 'commitCopyNewFiles')) {
+			set_upgrade_progress('commit', 'in_progress', 'commitCopyNewFiles', 'in_progress');
 			$split = commitCopyNewFiles($unzip_dir, $zip_from_dir);
 	 		$copiedFiles = $split['copiedFiles'];
 	 		$skippedFiles = $split['skippedFiles'];
-			set_upgrade_progress('commit','in_progress','commitCopyNewFiles','done');
+			set_upgrade_progress('commit', 'in_progress', 'commitCopyNewFiles', 'done');
 	 }
 	require_once(clean_path($unzip_dir.'/scripts/upgrade_utils.php'));
 	$new_sugar_version = getUpgradeVersion();
     $siv_varset_1 = setSilentUpgradeVar('origVersion', $sugar_version);
     $siv_varset_2 = setSilentUpgradeVar('destVersion', $new_sugar_version);
     $siv_write    = writeSilentUpgradeVars();
-    if(!$siv_varset_1 || !$siv_varset_2 || !$siv_write){
+    if (!$siv_varset_1 || !$siv_varset_2 || !$siv_write) {
         logThis("Error with silent upgrade variables: origVersion write success is ({$siv_varset_1}) ".
         		"-- destVersion write success is ({$siv_varset_2}) -- ".
         		"writeSilentUpgradeVars success is ({$siv_write}) -- ".
@@ -754,29 +754,29 @@ 
     }
 	///////////////////////////////////////////////////////////////////////////////
 	////	HANDLE POSTINSTALL SCRIPTS
-	if(empty($errors)) {
+	if (empty($errors)) {
 		logThis('Starting post_install()...', $path);
 
 		$trackerManager = TrackerManager::getInstance();
         $trackerManager->pause();
         $trackerManager->unsetMonitors();
 
-		if(!didThisStepRunBefore('commit','post_install')){
-			$file = "$unzip_dir/" . constant('SUGARCRM_POST_INSTALL_FILE');
-			if(is_file($file)) {
+		if (!didThisStepRunBefore('commit', 'post_install')) {
+			$file = "$unzip_dir/".constant('SUGARCRM_POST_INSTALL_FILE');
+			if (is_file($file)) {
 				//set_upgrade_progress('commit','in_progress','post_install','in_progress');
-				$progArray['post_install']='in_progress';
-				post_install_progress($progArray,'set');
+				$progArray['post_install'] = 'in_progress';
+				post_install_progress($progArray, 'set');
 				    global $moduleList;
 					include($file);
 					post_install();
 				// cn: only run conversion if admin selects "Sugar runs SQL"
-				if(!empty($_SESSION['allTables']) && $_SESSION['schema_change'] == 'sugar')
+				if (!empty($_SESSION['allTables']) && $_SESSION['schema_change'] == 'sugar')
 					executeConvertTablesSql($_SESSION['allTables']);
 				//set process to done
-				$progArray['post_install']='done';
+				$progArray['post_install'] = 'done';
 				//set_upgrade_progress('commit','in_progress','post_install','done');
-				post_install_progress($progArray,'set');
+				post_install_progress($progArray, 'set');
 			}
 		}
 	    //clean vardefs
@@ -807,19 +807,19 @@ 
 		require('config.php');
 		global $sugar_config;
 
-		if($ce_to_pro_ent){
-			if(isset($sugar_config['sugarbeet']))
+		if ($ce_to_pro_ent) {
+			if (isset($sugar_config['sugarbeet']))
 			{
 			    //$sugar_config['sugarbeet'] is only set in COMM
 			    unset($sugar_config['sugarbeet']);
 			}
-		    if(isset($sugar_config['disable_team_access_check']))
+		    if (isset($sugar_config['disable_team_access_check']))
 			{
 			    //$sugar_config['disable_team_access_check'] is a runtime configration,
 			    //no need to write to config.php
 			    unset($sugar_config['disable_team_access_check']);
 			}
-			if(!merge_passwordsetting($sugar_config, $sugar_version)) {
+			if (!merge_passwordsetting($sugar_config, $sugar_version)) {
 				logThis('*** ERROR: could not write config.php! - upgrade will fail!', $path);
 				$errors[] = 'Could not write config.php!';
 			}
@@ -829,7 +829,7 @@ 
 		logThis('Set default_theme to Sugar', $path);
 		$sugar_config['default_theme'] = 'Sugar';
 
-		if( !write_array_to_file( "sugar_config", $sugar_config, "config.php" ) ) {
+		if (!write_array_to_file("sugar_config", $sugar_config, "config.php")) {
             logThis('*** ERROR: could not write config.php! - upgrade will fail!', $path);
             $errors[] = 'Could not write config.php!';
         }
@@ -837,7 +837,7 @@ 
         logThis('Set default_max_tabs to 7', $path);
 		$sugar_config['default_max_tabs'] = '7';
 
-		if( !write_array_to_file( "sugar_config", $sugar_config, "config.php" ) ) {
+		if (!write_array_to_file("sugar_config", $sugar_config, "config.php")) {
             logThis('*** ERROR: could not write config.php! - upgrade will fail!', $path);
             $errors[] = 'Could not write config.php!';
         }
@@ -850,7 +850,7 @@ 
         logThis('Upgrade the sugar_version', $path);
         $sugar_config['sugar_version'] = $sugar_version;
 
-        if( !write_array_to_file( "sugar_config", $sugar_config, "config.php" ) ) {
+        if (!write_array_to_file("sugar_config", $sugar_config, "config.php")) {
             logThis('*** ERROR: could not write config.php! - upgrade will fail!', $path);
             $errors[] = 'Could not write config.php!';
         }
@@ -860,10 +860,10 @@ 
 
 	///////////////////////////////////////////////////////////////////////////////
 	////	REGISTER UPGRADE
-	if(empty($errors)) {
+	if (empty($errors)) {
 		logThis('Registering upgrade with UpgradeHistory', $path);
-		if(!didThisStepRunBefore('commit','upgradeHistory')){
-			set_upgrade_progress('commit','in_progress','upgradeHistory','in_progress');
+		if (!didThisStepRunBefore('commit', 'upgradeHistory')) {
+			set_upgrade_progress('commit', 'in_progress', 'upgradeHistory', 'in_progress');
 			$file_action = "copied";
 			// if error was encountered, script should have died before now
 			$new_upgrade = new UpgradeHistory();
@@ -876,26 +876,26 @@ 
 			$new_upgrade->status = "installed";
 			$new_upgrade->manifest = (!empty($_SESSION['install_manifest']) ? $_SESSION['install_manifest'] : '');
 
-			if($new_upgrade->description == null){
+			if ($new_upgrade->description == null) {
 				$new_upgrade->description = "Silent Upgrade was used to upgrade the instance";
 			}
-			else{
+			else {
 				$new_upgrade->description = $new_upgrade->description." Silent Upgrade was used to upgrade the instance.";
 			}
 		   $new_upgrade->save();
-		   set_upgrade_progress('commit','in_progress','upgradeHistory','done');
-		   set_upgrade_progress('commit','done','commit','done');
+		   set_upgrade_progress('commit', 'in_progress', 'upgradeHistory', 'done');
+		   set_upgrade_progress('commit', 'done', 'commit', 'done');
 		}
 	  }
 
 	//Clean modules from cache
 	    $cachedir = sugar_cached('smarty');
-		if(is_dir($cachedir)){
+		if (is_dir($cachedir)) {
 			$allModFiles = array();
-			$allModFiles = findAllFiles($cachedir,$allModFiles);
-		   foreach($allModFiles as $file){
+			$allModFiles = findAllFiles($cachedir, $allModFiles);
+		   foreach ($allModFiles as $file) {
 		       	//$file_md5_ref = str_replace(clean_path(getcwd()),'',$file);
-		       	if(file_exists($file)){
+		       	if (file_exists($file)) {
 					unlink($file);
 		       	}
 		   }
@@ -903,12 +903,12 @@ 
    //delete cache/modules before rebuilding the relations
    	//Clean modules from cache
    	    $cachedir = sugar_cached('modules');
-		if(is_dir($cachedir)){
+		if (is_dir($cachedir)) {
 			$allModFiles = array();
-			$allModFiles = findAllFiles($cachedir,$allModFiles);
-		   foreach($allModFiles as $file){
+			$allModFiles = findAllFiles($cachedir, $allModFiles);
+		   foreach ($allModFiles as $file) {
 		       	//$file_md5_ref = str_replace(clean_path(getcwd()),'',$file);
-		       	if(file_exists($file)){
+		       	if (file_exists($file)) {
 					unlink($file);
 		       	}
 		   }
@@ -916,21 +916,21 @@ 
 
 		//delete cache/themes
 		$cachedir = sugar_cached('themes');
-		if(is_dir($cachedir)){
+		if (is_dir($cachedir)) {
 			$allModFiles = array();
-			$allModFiles = findAllFiles($cachedir,$allModFiles);
-		   foreach($allModFiles as $file){
+			$allModFiles = findAllFiles($cachedir, $allModFiles);
+		   foreach ($allModFiles as $file) {
 		       	//$file_md5_ref = str_replace(clean_path(getcwd()),'',$file);
-		       	if(file_exists($file)){
+		       	if (file_exists($file)) {
 					unlink($file);
 		       	}
 		   }
 		}
 	ob_start();
-	if(!isset($_REQUEST['silent'])){
+	if (!isset($_REQUEST['silent'])) {
 		$_REQUEST['silent'] = true;
 	}
-	else if(isset($_REQUEST['silent']) && $_REQUEST['silent'] != true){
+	else if (isset($_REQUEST['silent']) && $_REQUEST['silent'] != true) {
 		$_REQUEST['silent'] = true;
 	}
 
@@ -942,36 +942,36 @@ 
     //fix_dropdown_list();
 }
 
-set_upgrade_progress('end','in_progress','end','in_progress');
+set_upgrade_progress('end', 'in_progress', 'end', 'in_progress');
 /////////////////////////Old Logger settings///////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////
 
-if(function_exists('deleteCache')){
-	set_upgrade_progress('end','in_progress','deleteCache','in_progress');
+if (function_exists('deleteCache')) {
+	set_upgrade_progress('end', 'in_progress', 'deleteCache', 'in_progress');
 	@deleteCache();
-	set_upgrade_progress('end','in_progress','deleteCache','done');
+	set_upgrade_progress('end', 'in_progress', 'deleteCache', 'done');
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 ////	HANDLE REMINDERS
-if(empty($errors)) {
+if (empty($errors)) {
 	commitHandleReminders($skippedFiles, $path);
 }
 
-if(file_exists(clean_path(getcwd()).'/original451files')){
+if (file_exists(clean_path(getcwd()).'/original451files')) {
 	rmdir_recursive(clean_path(getcwd()).'/original451files');
 }
 
 require_once('modules/Administration/Administration.php');
 $admin = new Administration();
-$admin->saveSetting('system','adminwizard',1);
+$admin->saveSetting('system', 'adminwizard', 1);
 
 
-if($ce_to_pro_ent)
+if ($ce_to_pro_ent)
 {
         //check to see if there are any new files that need to be added to systems tab
         //retrieve old modules list
-        logThis('check to see if new modules exist',$path);
+        logThis('check to see if new modules exist', $path);
         $oldModuleList = array();
         $newModuleList = array();
         include($argv[3].'/include/modules.php');
@@ -988,13 +988,13 @@ 
         $oldModuleList = $newTB->get_key_array($oldModuleList);
 
         //iterate through list and remove commonalities to get new modules
-        foreach ($newModuleList as $remove_mod){
-            if(in_array($remove_mod, $oldModuleList)){
+        foreach ($newModuleList as $remove_mod) {
+            if (in_array($remove_mod, $oldModuleList)) {
                 unset($newModuleList[$remove_mod]);
             }
         }
 
-        $must_have_modules= array(
+        $must_have_modules = array(
 			  'Activities'=>'Activities',
         	  'Calendar'=>'Calendar',
         	  'Reports' => 'Reports',
@@ -1004,42 +1004,42 @@ 
 			  'Contracts' => 'Contracts',
 			  'KBDocuments' => 'KBDocuments'
         );
-        $newModuleList = array_merge($newModuleList,$must_have_modules);
+        $newModuleList = array_merge($newModuleList, $must_have_modules);
 
         //new modules list now has left over modules which are new to this install, so lets add them to the system tabs
-        logThis('new modules to add are '.var_export($newModuleList,true),$path);
+        logThis('new modules to add are '.var_export($newModuleList, true), $path);
 
         //grab the existing system tabs
         $tabs = $newTB->get_system_tabs();
 
         //add the new tabs to the array
-        foreach($newModuleList as $nm ){
+        foreach ($newModuleList as $nm) {
           $tabs[$nm] = $nm;
         }
 
         //now assign the modules to system tabs
         $newTB->set_system_tabs($tabs);
-        logThis('module tabs updated',$path);
+        logThis('module tabs updated', $path);
 }
 
 //Also set the tracker settings if  flavor conversion ce->pro or ce->ent
-if(isset($_SESSION['current_db_version']) && isset($_SESSION['target_db_version'])){
+if (isset($_SESSION['current_db_version']) && isset($_SESSION['target_db_version'])) {
     if (version_compare($_SESSION['current_db_version'], $_SESSION['target_db_version'], '='))
     {
 	    $_REQUEST['upgradeWizard'] = true;
 	    ob_start();
 			include('include/Smarty/internals/core.write_file.php');
 		ob_end_clean();
-	 	$db =& DBManagerFactory::getInstance();
-		if($ce_to_pro_ent){
+	 	$db = & DBManagerFactory::getInstance();
+		if ($ce_to_pro_ent) {
 	        //Also set license information
 	        $admin = new Administration();
 			$category = 'license';
 			$value = 0;
 			$admin->saveSetting($category, 'users', $value);
-			$key = array('num_lic_oc','key','expire_date');
+			$key = array('num_lic_oc', 'key', 'expire_date');
 			$value = '';
-			foreach($key as $k){
+			foreach ($key as $k) {
 				$admin->saveSetting($category, $k, $value);
 			}
 		}
@@ -1050,8 +1050,8 @@ 
 	ob_end_clean();
 	logThis("**** Potential PHP generated error messages: {$phpErrors}", $path);
 
-	if(count($errors) > 0) {
-		foreach($errors as $error) {
+	if (count($errors) > 0) {
+		foreach ($errors as $error) {
 			logThis("****** SilentUpgrade ERROR: {$error}", $path);
 		}
 		echo "FAILED\n";
@@ -1072,18 +1072,18 @@ 
 {
 	$tableDictionaryExtDirs = array('custom/Extension/application/Ext/TableDictionary', 'custom/application/Ext/TableDictionary');
 
-	foreach($tableDictionaryExtDirs as $tableDictionaryExt)
+	foreach ($tableDictionaryExtDirs as $tableDictionaryExt)
 	{
 
-		if(is_dir($tableDictionaryExt) && is_writable($tableDictionaryExt)){
+		if (is_dir($tableDictionaryExt) && is_writable($tableDictionaryExt)) {
 			$dir = dir($tableDictionaryExt);
-			while(($entry = $dir->read()) !== false)
+			while (($entry = $dir->read()) !== false)
 			{
-				$entry = $tableDictionaryExt . '/' . $entry;
-				if(is_file($entry) && preg_match('/\.php$/i', $entry) && is_writeable($entry))
+				$entry = $tableDictionaryExt.'/'.$entry;
+				if (is_file($entry) && preg_match('/\.php$/i', $entry) && is_writeable($entry))
 				{
 
-						if(function_exists('sugar_fopen'))
+						if (function_exists('sugar_fopen'))
 						{
 							$fp = @sugar_fopen($entry, 'r');
 						} else {
@@ -1091,16 +1091,16 @@ 
 						}
 
 
-					    if($fp)
+					    if ($fp)
 				        {
 				             $altered = false;
 				             $contents = '';
 
-				             while($line = fgets($fp))
+				             while ($line = fgets($fp))
 						     {
-						    	if(preg_match('/\s*include\s*\(\s*[\'|\"](.*?)[\"|\']\s*\)\s*;/', $line, $match))
+						    	if (preg_match('/\s*include\s*\(\s*[\'|\"](.*?)[\"|\']\s*\)\s*;/', $line, $match))
 						    	{
-						    	   if(!file_exists($match[1]))
+						    	   if (!file_exists($match[1]))
 						    	   {
 						    	      $altered = true;
 						    	   } else {
@@ -1115,16 +1115,16 @@ 
 				        }
 
 
-					    if($altered)
+					    if ($altered)
 					    {
-							if(function_exists('sugar_fopen'))
+							if (function_exists('sugar_fopen'))
 							{
 								$fp = @sugar_fopen($entry, 'w');
 							} else {
 								$fp = fopen($entry, 'w');
 							}
 
-							if($fp && fwrite($fp, $contents))
+							if ($fp && fwrite($fp, $contents))
 							{
 								fclose($fp);
 							}

modules/UpgradeWizard/uw_emptyFunctions.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -44,7 +44,7 @@ 
 
 //empty function getJSPath().. there is some dependency in meta upgrade
 
-function getJSPath($file=''){
+function getJSPath($file = '') {
 	//nothing here fake function
 }
 ?>
\ No newline at end of file

modules/UpgradeWizard/systemCheckJson.php

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,25 +45,25 @@ 
  * Reserved. Contributor(s): ______________________________________..
  * *******************************************************************************/
 
-if(ob_get_level() < 1)
+if (ob_get_level() < 1)
 	ob_start();
 ob_implicit_flush(1);
 
 // load the generated persistence file if found
 $persistence = array();
-if(file_exists($persist = sugar_cached('/modules/UpgradeWizard/_persistence.php'))) {
+if (file_exists($persist = sugar_cached('/modules/UpgradeWizard/_persistence.php'))) {
 	require_once $persist;
 }
 require_once('modules/UpgradeWizard/uw_utils.php');
 
-switch($_REQUEST['systemCheckStep']) {
+switch ($_REQUEST['systemCheckStep']) {
 	case 'find_all_files':
 		ob_end_flush();
 		$persistence['files_to_check'] = getFilesForPermsCheck();
         break;
 
 	case 'check_found_files':
-		if(empty($persistence['files_to_check'])) {
+		if (empty($persistence['files_to_check'])) {
 			logThis('*** ERROR: could not find persistent array of files to check');
 			echo $mod_strings['ERR_UW_NO_FILES'];
 		} else {

modules/UpgradeWizard/silentUpgrade_step2.php

Spacing +79 added lines, -79 removed lines

@@ -42,40 +42,40 @@ 
 //// php.exe -f silentUpgrade.php [Path to Upgrade Package zip] [Path to Log file] [Path to Instance]
 //// See below the Usage for more details.
 /////////////////////////////////////////////////////////////////////////////////////////
-ini_set('memory_limit',-1);
+ini_set('memory_limit', -1);
 ///////////////////////////////////////////////////////////////////////////////
 ////	UTILITIES THAT MUST BE LOCAL :(
  //Bug 24890, 24892. default_permissions not written to config.php. Following function checks and if
  //no found then adds default_permissions to the config file.
- function checkConfigForPermissions(){
-     if(file_exists(getcwd().'/config.php')){
+ function checkConfigForPermissions() {
+     if (file_exists(getcwd().'/config.php')) {
          require(getcwd().'/config.php');
      }
      global $sugar_config;
-     if(!isset($sugar_config['default_permissions'])){
-             $sugar_config['default_permissions'] = array (
+     if (!isset($sugar_config['default_permissions'])) {
+             $sugar_config['default_permissions'] = array(
                      'dir_mode' => 02770,
                      'file_mode' => 0660,
                      'user' => '',
                      'group' => '',
              );
          ksort($sugar_config);
-         if(is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+         if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
         	//writing to the file
  		}
      }
 }
 
-function checkLoggerSettings(){
-	if(file_exists(getcwd().'/config.php')){
+function checkLoggerSettings() {
+	if (file_exists(getcwd().'/config.php')) {
          require(getcwd().'/config.php');
      }
     global $sugar_config;
-	if(!isset($sugar_config['logger'])){
-	    $sugar_config['logger'] =array (
+	if (!isset($sugar_config['logger'])) {
+	    $sugar_config['logger'] = array(
 			'level'=>'fatal',
 		    'file' =>
-		     array (
+		     array(
 		      'ext' => '.log',
 		      'name' => 'sugarcrm',
 		      'dateFormat' => '%c',
@@ -85,23 +85,23 @@ 
 		    ),
 		  );
 		 ksort($sugar_config);
-         if(is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+         if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
         	//writing to the file
  		}
 	 }
 }
 
-function checkResourceSettings(){
-	if(file_exists(getcwd().'/config.php')){
+function checkResourceSettings() {
+	if (file_exists(getcwd().'/config.php')) {
          require(getcwd().'/config.php');
      }
     global $sugar_config;
-	if(!isset($sugar_config['resource_management'])){
+	if (!isset($sugar_config['resource_management'])) {
 	  $sugar_config['resource_management'] =
-		  array (
+		  array(
 		    'special_query_limit' => 50000,
 		    'special_query_modules' =>
-		    array (
+		    array(
 		      0 => 'Reports',
 		      1 => 'Export',
 		      2 => 'Import',
@@ -111,18 +111,18 @@ 
 		    'default_limit' => 1000,
 		  );
 		 ksort($sugar_config);
-         if(is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config,'config.php')) {
+         if (is_writable('config.php') && write_array_to_file("sugar_config", $sugar_config, 'config.php')) {
         	//writing to the file
  		}
 	}
 }
 
 
-function verifyArguments($argv,$usage_regular){
+function verifyArguments($argv, $usage_regular) {
     $upgradeType = '';
     $cwd = getcwd(); // default to current, assumed to be in a valid SugarCRM root dir.
-    if(isset($argv[3])) {
-        if(is_dir($argv[3])) {
+    if (isset($argv[3])) {
+        if (is_dir($argv[3])) {
             $cwd = $argv[3];
             chdir($cwd);
         } else {
@@ -133,18 +133,18 @@ 
     }
 
     //check if this is an instance
-    if(is_file("{$cwd}/include/entryPoint.php")) {
+    if (is_file("{$cwd}/include/entryPoint.php")) {
         //this should be a regular sugar install
         $upgradeType = constant('SUGARCRM_INSTALL');
         //check if this is a valid zip file
-        if(!is_file($argv[1])) { // valid zip?
+        if (!is_file($argv[1])) { // valid zip?
             echo "*******************************************************************************\n";
             echo "*** ERROR: First argument must be a full path to the patch file. Got [ {$argv[1]} ].\n";
             echo $usage_regular;
             echo "FAILURE\n";
             exit(1);
         }
-        if(count($argv) < 5) {
+        if (count($argv) < 5) {
             echo "*******************************************************************************\n";
             echo "*** ERROR: Missing required parameters.  Received ".count($argv)." argument(s), require 5.\n";
             echo $usage_regular;
@@ -159,7 +159,7 @@ 
         exit(1);
     }
 
-    if(isset($argv[7]) && file_exists($argv[7].'SugarTemplateUtilties.php')){
+    if (isset($argv[7]) && file_exists($argv[7].'SugarTemplateUtilties.php')) {
         require_once($argv[7].'SugarTemplateUtilties.php');
     }
 
@@ -185,8 +185,8 @@ 
 //End of #52872
 
 // only run from command line
-if(isset($_SERVER['HTTP_USER_AGENT'])) {
-	fwrite(STDERR,'This utility may only be run from the command line or command prompt.');
+if (isset($_SERVER['HTTP_USER_AGENT'])) {
+	fwrite(STDERR, 'This utility may only be run from the command line or command prompt.');
 	exit(1);
 }
 //Clean_string cleans out any file  passed in as a parameter
@@ -195,7 +195,7 @@ 
 
 ///////////////////////////////////////////////////////////////////////////////
 ////	USAGE
-$usage_regular =<<<eoq2
+$usage_regular = <<<eoq2
 Usage: php.exe -f silentUpgrade.php [upgradeZipFile] [logFile] [pathToSugarInstance] [admin-user]
 
 On Command Prompt Change directory to where silentUpgrade.php resides. Then type path to
@@ -217,7 +217,7 @@ 
 
 ///////////////////////////////////////////////////////////////////////////////
 ////	STANDARD REQUIRED SUGAR INCLUDES AND PRESETS
-if(!defined('sugarEntry')) define('sugarEntry', true);
+if (!defined('sugarEntry')) define('sugarEntry', true);
 
 $_SESSION = array();
 $_SESSION['schema_change'] = 'sugar'; // we force-run all SQL
@@ -234,10 +234,10 @@ 
 global $cwd;
 $cwd = getcwd(); // default to current, assumed to be in a valid SugarCRM root dir.
 
-$upgradeType = verifyArguments($argv,$usage_regular);
+$upgradeType = verifyArguments($argv, $usage_regular);
 
-$path			= $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
-$subdirs		= array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
+$path = $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
+$subdirs = array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
 
 require_once('include/entryPoint.php');
 require_once('modules/UpgradeWizard/uw_utils.php');
@@ -249,8 +249,8 @@ 
 $errors = array();
 
 	require('config.php');
-	if(isset($argv[3])) {
-		if(is_dir($argv[3])) {
+	if (isset($argv[3])) {
+		if (is_dir($argv[3])) {
 			$cwd = $argv[3];
 			chdir($cwd);
 		}
@@ -261,36 +261,36 @@ 
 	global $sugar_config;
 	$configOptions = $sugar_config['dbconfig'];
 
-    $GLOBALS['log']	= LoggerManager::getLogger('SugarCRM');
-	$patchName		= basename($argv[1]);
-	$zip_from_dir	= substr($patchName, 0, strlen($patchName) - 4); // patch folder name (minus ".zip")
-	$path			= $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
-    $db				= &DBManagerFactory::getInstance();
-	$UWstrings		= return_module_language('en_us', 'UpgradeWizard', true);
-	$adminStrings	= return_module_language('en_us', 'Administration', true);
+    $GLOBALS['log'] = LoggerManager::getLogger('SugarCRM');
+	$patchName = basename($argv[1]);
+	$zip_from_dir = substr($patchName, 0, strlen($patchName) - 4); // patch folder name (minus ".zip")
+	$path = $argv[2]; // custom log file, if blank will use ./upgradeWizard.log
+    $db = &DBManagerFactory::getInstance();
+	$UWstrings = return_module_language('en_us', 'UpgradeWizard', true);
+	$adminStrings = return_module_language('en_us', 'Administration', true);
     $app_list_strings = return_app_list_strings_language('en_us');
-	$mod_strings	= array_merge($adminStrings, $UWstrings);
-	$subdirs		= array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
+	$mod_strings = array_merge($adminStrings, $UWstrings);
+	$subdirs = array('full', 'langpack', 'module', 'patch', 'theme', 'temp');
 	global $unzip_dir;
     $license_accepted = false;
-    if(isset($argv[5]) && (strtolower($argv[5])=='yes' || strtolower($argv[5])=='y')){
+    if (isset($argv[5]) && (strtolower($argv[5]) == 'yes' || strtolower($argv[5]) == 'y')) {
     	$license_accepted = true;
 	 }
 	//////////////////////////////////////////////////////////////////////////////
 	//Adding admin user to the silent upgrade
 
 	$current_user = new User();
-	if(isset($argv[4])) {
+	if (isset($argv[4])) {
 	   //if being used for internal upgrades avoid admin user verification
 	   $user_name = $argv[4];
-	   $q = "select id from users where user_name = '" . $user_name . "' and is_admin=1";
+	   $q = "select id from users where user_name = '".$user_name."' and is_admin=1";
 	   $result = $GLOBALS['db']->query($q, false);
 	   $logged_user = $GLOBALS['db']->fetchByAssoc($result);
-	   if(isset($logged_user['id']) && $logged_user['id'] != null){
+	   if (isset($logged_user['id']) && $logged_user['id'] != null) {
 		//do nothing
 	    $current_user->retrieve($logged_user['id']);
 	   }
-	   else{
+	   else {
 	   	echo "Not an admin user in users table. Please provide an admin user\n";
 		exit(1);
 	   }
@@ -314,8 +314,8 @@ 
 $_SESSION['zip_from_dir'] = $zip_from_dir;
 
 mkdir_recursive($unzip_dir);
-if(!is_dir($unzip_dir)) {
-	fwrite(STDERR,"\n{$unzip_dir} is not an available directory\nFAILURE\n");
+if (!is_dir($unzip_dir)) {
+	fwrite(STDERR, "\n{$unzip_dir} is not an available directory\nFAILURE\n");
     exit(1);
 }
 unzip($argv[1], $unzip_dir);
@@ -325,7 +325,7 @@ 
 ///////////////////////////////////////////////////////////////////////////////
 
 
-if(function_exists('set_upgrade_vars')){
+if (function_exists('set_upgrade_vars')) {
 	set_upgrade_vars();
 }
 
@@ -349,18 +349,18 @@ 
 upgrade_custom_relationships();
 
 logThis('Upgrading user preferences start .', $path);
-if(function_exists('upgradeUserPreferences')){
+if (function_exists('upgradeUserPreferences')) {
    upgradeUserPreferences();
 }
 logThis('Upgrading user preferences finish .', $path);
 
 // clear out the theme cache
-if(is_dir($GLOBALS['sugar_config']['cache_dir'].'themes')){
+if (is_dir($GLOBALS['sugar_config']['cache_dir'].'themes')) {
     $allModFiles = array();
-    $allModFiles = findAllFiles($GLOBALS['sugar_config']['cache_dir'].'themes',$allModFiles);
-    foreach($allModFiles as $file){
+    $allModFiles = findAllFiles($GLOBALS['sugar_config']['cache_dir'].'themes', $allModFiles);
+    foreach ($allModFiles as $file) {
         //$file_md5_ref = str_replace(clean_path(getcwd()),'',$file);
-        if(file_exists($file)){
+        if (file_exists($file)) {
             unlink($file);
         }
     }
@@ -372,7 +372,7 @@ 
 require_once('jssource/minify.php');
 
 //Add the cache cleaning here.
-if(function_exists('deleteCache'))
+if (function_exists('deleteCache'))
 {
 	logThis('Call deleteCache', $path);
 	@deleteCache();
@@ -411,35 +411,35 @@ 
 $rac->clearVardefs();
 $rac->rebuildExtensions();
 //bug: 44431 - defensive check to ensure the method exists since upgrades to 6.2.0 may not have this method define yet.
-if(method_exists($rac, 'clearExternalAPICache'))
+if (method_exists($rac, 'clearExternalAPICache'))
 {
     $rac->clearExternalAPICache();
 }
 
 $repairedTables = array();
 foreach ($beanFiles as $bean => $file) {
-	if(file_exists($file)){
+	if (file_exists($file)) {
 		unset($GLOBALS['dictionary'][$bean]);
 		require_once($file);
-		$focus = new $bean ();
-		if(empty($focus->table_name) || isset($repairedTables[$focus->table_name])) {
+		$focus = new $bean();
+		if (empty($focus->table_name) || isset($repairedTables[$focus->table_name])) {
 		   continue;
 		}
 
 		if (($focus instanceOf SugarBean)) {
-			if(!isset($repairedTables[$focus->table_name]))
+			if (!isset($repairedTables[$focus->table_name]))
 			{
 				$sql = $GLOBALS['db']->repairTable($focus, true);
-                if(trim($sql) != '')
+                if (trim($sql) != '')
                 {
-				    logThis('Running sql:' . $sql, $path);
+				    logThis('Running sql:'.$sql, $path);
                 }
 				$repairedTables[$focus->table_name] = true;
 			}
 
 			//Check to see if we need to create the audit table
-		    if($focus->is_AuditEnabled() && !$focus->db->tableExists($focus->get_audit_table_name())){
-               logThis('Creating audit table:' . $focus->get_audit_table_name(), $path);
+		    if ($focus->is_AuditEnabled() && !$focus->db->tableExists($focus->get_audit_table_name())) {
+               logThis('Creating audit table:'.$focus->get_audit_table_name(), $path);
 		       $focus->create_audit_table();
             }
 		}
@@ -451,14 +451,14 @@ 
 foreach ($dictionary as $meta) {
 	$tablename = $meta['table'];
 
-	if(isset($repairedTables[$tablename])) {
+	if (isset($repairedTables[$tablename])) {
 	   continue;
 	}
 
 	$fielddefs = $meta['fields'];
 	$indices = $meta['indices'];
 	$sql = $GLOBALS['db']->repairTableParams($tablename, $fielddefs, $indices, true);
-	if(!empty($sql)) {
+	if (!empty($sql)) {
 	    logThis($sql, $path);
 	    $repairedTables[$tablename] = true;
 	}
@@ -472,7 +472,7 @@ 
 logThis('End rebuild relationships.', $path);
 
 include("$unzip_dir/manifest.php");
-$ce_to_pro_ent = isset($manifest['name']) && ($manifest['name'] == 'SugarCE to SugarPro' || $manifest['name'] == 'SugarCE to SugarEnt'  || $manifest['name'] == 'SugarCE to SugarCorp' || $manifest['name'] == 'SugarCE to SugarUlt');
+$ce_to_pro_ent = isset($manifest['name']) && ($manifest['name'] == 'SugarCE to SugarPro' || $manifest['name'] == 'SugarCE to SugarEnt' || $manifest['name'] == 'SugarCE to SugarCorp' || $manifest['name'] == 'SugarCE to SugarUlt');
 $sugar_version = getSilentUpgradeVar('origVersion');
 if (!$sugar_version)
 {
@@ -481,15 +481,15 @@ 
 }
 
 
-if($ce_to_pro_ent) {
+if ($ce_to_pro_ent) {
 	//add the global team if it does not exist
 	$globalteam = new Team();
 	$globalteam->retrieve('1');
 	require_once($unzip_dir.'/'.$zip_from_dir.'/modules/Administration/language/en_us.lang.php');
-	if(isset($globalteam->name)){
+	if (isset($globalteam->name)) {
 		echo 'Global '.$mod_strings['LBL_UPGRADE_TEAM_EXISTS'].'<br>';
 		logThis(" Finish Building Global Team", $path);
-	}else{
+	} else {
 		$globalteam->create_team("Global", $mod_strings['LBL_GLOBAL_TEAM_DESC'], $globalteam->global_team);
 	}
 
@@ -506,7 +506,7 @@ 
         include('modules/Administration/upgradeTeams.php');
         logThis(" Finish modules/Administration/upgradeTeams.php", $path);
 
-    if(check_FTS()){
+    if (check_FTS()) {
     	$GLOBALS['db']->full_text_indexing_setup();
     }
 }
@@ -523,12 +523,12 @@ 
 
 
 //Unlink files that have been removed
-if(function_exists('unlinkUpgradeFiles'))
+if (function_exists('unlinkUpgradeFiles'))
 {
 	unlinkUpgradeFiles($sugar_version);
 }
 
-if(function_exists('rebuildSprites') && function_exists('imagecreatetruecolor'))
+if (function_exists('rebuildSprites') && function_exists('imagecreatetruecolor'))
 {
     rebuildSprites(true);
 }
@@ -541,8 +541,8 @@ 
 
 ///////////////////////////////////////////////////////////////////////////////
 ////	TAKE OUT TRASH
-if(empty($errors)) {
-	set_upgrade_progress('end','in_progress','unlinkingfiles','in_progress');
+if (empty($errors)) {
+	set_upgrade_progress('end', 'in_progress', 'unlinkingfiles', 'in_progress');
 	logThis('Taking out the trash, unlinking temp files.', $path);
 	unlinkUWTempFiles();
 	removeSilentUpgradeVarsCache();
@@ -556,8 +556,8 @@ 
 ob_end_clean();
 logThis("**** Potential PHP generated error messages: {$phpErrors}", $path);
 
-if(count($errors) > 0) {
-	foreach($errors as $error) {
+if (count($errors) > 0) {
+	foreach ($errors as $error) {
 		logThis("****** SilentUpgrade ERROR: {$error}", $path);
 	}
 	echo "FAILED\n";

modules/UpgradeWizard/preflightJson.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,19 +45,19 @@ 
  * Reserved. Contributor(s): ______________________________________..
  * *******************************************************************************/
 
-if(ob_get_level() < 1)
+if (ob_get_level() < 1)
 	ob_start();
 ob_implicit_flush(1);
 
 // load the generated persistence file if found
 $persistence = array();
-if(file_exists($persist = sugar_cached('/modules/UpgradeWizard/_persistence.php'))) {
+if (file_exists($persist = sugar_cached('/modules/UpgradeWizard/_persistence.php'))) {
 	require_once $persist;
 }
 require_once('modules/UpgradeWizard/uw_utils.php');
 require_once('include/utils/zip_utils.php');
 
-switch($_REQUEST['preflightStep']) {
+switch ($_REQUEST['preflightStep']) {
 	case 'find_upgrade_files':
 		logThis('preflightJson finding upgrade files');
 		ob_end_flush();

modules/UpgradeWizard/UploadFileCheck.php

Spacing +7 added lines, -7 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,13 +50,13 @@ 
 
 $json = getJSONobj();
 $file_name = $json->decode(html_entity_decode($_REQUEST['file_name']));
- if(isset($file_name['jsonObject']) && $file_name['jsonObject'] != null){
+ if (isset($file_name['jsonObject']) && $file_name['jsonObject'] != null) {
 	$file_name = $file_name['jsonObject'];
   }
 
 $filesize = '';
-if(file_exists($file_name)){
-    $filesize =filesize($file_name);
+if (file_exists($file_name)) {
+    $filesize = filesize($file_name);
 }
 
 
@@ -72,9 +72,9 @@ 
 //get the file size defined in php.ini
 //$uploadSizeIni = substr(ini_get("upload_max_filesize"), 0, strlen( ini_get("upload_max_filesize")) - 1);
 //$GLOBALS['log']->fatal('Upload php setting Size '.return_bytes(ini_get("upload_max_filesize")));
-if($filesize != null){
-	if(($filesize > return_bytes(ini_get("upload_max_filesize"))) || ($filesize > return_bytes(ini_get("post_max_size")))){
-		$response=$filesize;
+if ($filesize != null) {
+	if (($filesize > return_bytes(ini_get("upload_max_filesize"))) || ($filesize > return_bytes(ini_get("post_max_size")))) {
+		$response = $filesize;
 		//$response= "<script>alert('File size is bigger than the max_upload-size setting in php.ini. Upgrade attempt will fail. Increase the upload_max_size in php.ini to greater than ')</script>";
 	}
 }

modules/UpgradeWizard/upgradeTimeCounter.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -72,7 +72,7 @@ 
  }
 */
 
- $_SESSION['totalUpgradeTime'] = $_SESSION['totalUpgradeTime']+$_REQUEST['upgradeStepTime'];
+ $_SESSION['totalUpgradeTime'] = $_SESSION['totalUpgradeTime'] + $_REQUEST['upgradeStepTime'];
  $response = $_SESSION['totalUpgradeTime'];
 
 $GLOBALS['log']->fatal('TOTAL TIME .....'.$_SESSION['totalUpgradeTime']);

modules/UpgradeWizard/UpgradeRemoval.php

Spacing +12 added lines, -12 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -77,26 +77,26 @@ 
  * 
  * @param mixed $files 
  */
-public function processFilesToRemove($files=array())
+public function processFilesToRemove($files = array())
 {
-	if(empty($files) || !is_array($files))
+	if (empty($files) || !is_array($files))
 	{
 		return;
 	}	
 	
 	require_once('include/dir_inc.php');
 	
-	if(!file_exists('custom/backup'))
+	if (!file_exists('custom/backup'))
 	{
 	   mkdir_recursive('custom/backup');
 	}
 	
-	foreach($files as $file)
+	foreach ($files as $file)
 	{		
-		if(file_exists($file))
+		if (file_exists($file))
 		{
 			$this->backup($file);   
-			if(is_dir($file))
+			if (is_dir($file))
 			{
 			  rmdir_recursive($file);	
 			} else {
@@ -118,16 +118,16 @@ 
 	$basename = basename($file);
 	$basepath = str_replace($basename, '', $file);
 
-	if(!empty($basepath) && !file_exists('custom/backup/' . $basepath))
+	if (!empty($basepath) && !file_exists('custom/backup/'.$basepath))
 	{
-	   mkdir_recursive('custom/backup/' . $basepath);
+	   mkdir_recursive('custom/backup/'.$basepath);
 	}
 	
-	if(is_dir($file))
+	if (is_dir($file))
 	{
-    	copy_recursive($file, 'custom/backup/' . $file);	
+    	copy_recursive($file, 'custom/backup/'.$file);	
 	} else {
-		copy($file, 'custom/backup/' . $file);
+		copy($file, 'custom/backup/'.$file);
 	}
 }
 

modules/UpgradeWizard/silentUpgrade.php

Spacing +19 added lines, -19 removed lines

@@ -34,25 +34,25 @@ 
  * "Powered by SugarCRM".
  ********************************************************************************/
 
-function build_argument_string($arguments=array()) {
-   if(!is_array($arguments)) {
+function build_argument_string($arguments = array()) {
+   if (!is_array($arguments)) {
    	  return '';
    }
 
    $argument_string = '';
    $count = 0;
-   foreach($arguments as $arg) {
-   	   if($count != 0)
+   foreach ($arguments as $arg) {
+   	   if ($count != 0)
    	   {
    	   	  //If current directory or parent directory is specified, substitute with full path
-   	   	  if($arg == '.')
+   	   	  if ($arg == '.')
    	   	  {
    	   	  	 $arg = getcwd();
    	   	  } else if ($arg == '..') {
    	   	  	 $dir = getcwd();
 			 $arg = substr($dir, 0, strrpos($dir, DIRECTORY_SEPARATOR));
    	   	  }
-          $argument_string .= ' ' . escapeshellarg($arg);
+          $argument_string .= ' '.escapeshellarg($arg);
    	   }
    	   $count++;
    }
@@ -69,12 +69,12 @@ 
 
 $php_path = '';
 $run_dce_upgrade = false;
-if(isset($argv[3]) && is_dir($argv[3]) && file_exists($argv[3]."/ini_setup.php")) {
+if (isset($argv[3]) && is_dir($argv[3]) && file_exists($argv[3]."/ini_setup.php")) {
                 //this is a dce call, set the dce flag
                 chdir($argv[3]);
                 $run_dce_upgrade = true;
                 //set the php path if found
-                if(is_file($argv[7].'dce_config.php')){
+                if (is_file($argv[7].'dce_config.php')) {
                    include($argv[7].'dce_config.php');
                    $php_path = $dce_config['client_php_path'].'/';
                 }
@@ -82,34 +82,34 @@ 
 
 $php_file = $argv[0];
 $p_info = pathinfo($php_file);
-$php_dir = (isset($p_info['dirname']) && $p_info['dirname'] != '.') ?  $p_info['dirname'] . '/' : '';
+$php_dir = (isset($p_info['dirname']) && $p_info['dirname'] != '.') ? $p_info['dirname'].'/' : '';
 
-$step1 = $php_path."php -f {$php_dir}silentUpgrade_step1.php " . build_argument_string($argv);
+$step1 = $php_path."php -f {$php_dir}silentUpgrade_step1.php ".build_argument_string($argv);
 passthru($step1, $output);
-if($output != 0) {
+if ($output != 0) {
     echo "***************         step1 failed         ***************: $output\n";
 }
 $has_error = $output == 0 ? false : true;
 
-if(!$has_error) {
-	if($run_dce_upgrade) {
-		$step2 = $php_path."php -f {$php_dir}silentUpgrade_dce_step1.php " . build_argument_string($argv);
+if (!$has_error) {
+	if ($run_dce_upgrade) {
+		$step2 = $php_path."php -f {$php_dir}silentUpgrade_dce_step1.php ".build_argument_string($argv);
 		passthru($step2, $output);
 	} else {
-		$step2 = "php -f {$php_dir}silentUpgrade_step2.php " . build_argument_string($argv);
+		$step2 = "php -f {$php_dir}silentUpgrade_step2.php ".build_argument_string($argv);
 		passthru($step2, $output);
 	}
 }
 
-if($run_dce_upgrade) {
+if ($run_dce_upgrade) {
 	$has_error = $output == 0 ? false : true;
-	if(!$has_error) {
-	   $step3 = $php_path."php -f {$php_dir}silentUpgrade_dce_step2.php " . build_argument_string($argv);
+	if (!$has_error) {
+	   $step3 = $php_path."php -f {$php_dir}silentUpgrade_dce_step2.php ".build_argument_string($argv);
 	   passthru($step3, $output);
 	}
 }
 
-if($output != 0) {
+if ($output != 0) {
    echo "***************         silentupgrade failed         ***************: $output\n";
 }
 exit($output);