adamjakab / SuiteCRM

include/generic/SugarWidgets/SugarWidgetFielddatetime.php

Braces +12 added lines, -12 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -58,8 +60,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -81,7 +82,9 @@ 
 
 		$report_def_str = $json_obj->decode($this->reporter->report_def_str);
 
-		if(empty($report_def_str['assigned_user_id'])) return null;
+		if(empty($report_def_str['assigned_user_id'])) {
+		    return null;
+		}
 
 		$this->assigned_user = new User();
 		$this->assigned_user->retrieve($report_def_str['assigned_user_id']);
@@ -228,8 +231,7 @@ 
         if ($time=='start') {
             $begin_parts = explode(' ', $begin);
             $be = $begin_parts[0] . ' 00:00:00';
-        }
-        else if ($time=='end') {
+        } else if ($time=='end') {
             $begin_parts = explode(' ', $begin);
             $be = $begin_parts[0] . ' 23:59:59';
         } else {
@@ -529,12 +531,12 @@ 
         if (count(explode('-',$content)) == 2){
             return $content;
         // if date field
-        }elseif(substr_count($layout_def['type'], 'date') > 0){
+        } elseif(substr_count($layout_def['type'], 'date') > 0){
             // if date time field
             if(substr_count($layout_def['type'], 'time') > 0 && $this->get_time_part($content)!= false){
                 $td = $timedate->to_display_date_time($content);
                 return $td;
-            }else{// if date only field
+            } else{// if date only field
                 $td = $timedate->to_display_date($content, false); // Avoid PHP notice of returning by reference.
                 return $td;
             }
@@ -650,8 +652,7 @@ 
         if (empty($layout_def['sort_dir']) || $layout_def['sort_dir'] == 'a')
         {
             return $orderBy . " ASC\n";
-        }
-        else
+        } else
         {
             return $orderBy . " DESC\n";
         }
@@ -767,8 +768,7 @@ 
         if (empty($layout_def['sort_dir']) || $layout_def['sort_dir'] == 'a')
         {
             return $orderBy . " ASC\n";
-        }
-        else
+        } else
         {
             return $orderBy . " DESC\n";
         }

include/generic/SugarWidgets/SugarWidgetReportField.php

Braces +12 added lines, -10 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -66,8 +68,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -199,19 +200,20 @@ 
  function queryOrderBy($layout_def)
  {
      $field_def = array();
-	if(!empty($this->reporter->all_fields[$layout_def['column_key']])) $field_def = $this->reporter->all_fields[$layout_def['column_key']];
+	if(!empty($this->reporter->all_fields[$layout_def['column_key']])) {
+	    $field_def = $this->reporter->all_fields[$layout_def['column_key']];
+	}
 
     if (!empty($layout_def['group_function']))
     {
         $order_by = $this->_get_column_alias($layout_def);
-    }
-    elseif (!empty($field_def['sort_on']))
+    } elseif (!empty($field_def['sort_on']))
 	{
 			$order_by = $layout_def['table_alias'].".".$field_def['sort_on'];
-            if(!empty($field_def['sort_on2']))
-                $order_by .= ', ' . $layout_def['table_alias'].".".$field_def['sort_on2'];
-    }
-	else {
+            if(!empty($field_def['sort_on2'])) {
+                            $order_by .= ', ' . $layout_def['table_alias'].".".$field_def['sort_on2'];
+            }
+    } else {
 		$order_by = $this->_get_column_alias($layout_def)." \n";
 	}
 

include/generic/SugarWidgets/SugarWidgetFieldenum.php

Braces +11 added lines, -13 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,8 +54,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -110,7 +111,7 @@ 
     function & displayList($layout_def) {
         if(!empty($layout_def['column_key'])){
             $field_def = $this->reporter->all_fields[$layout_def['column_key']];
-        }else if(!empty($layout_def['fields'])){
+        } else if(!empty($layout_def['fields'])){
             $field_def = $layout_def['fields'];
         }
         $cell = $this->displayListPlain($layout_def);
@@ -144,13 +145,13 @@ 
 	function & displayListPlain($layout_def) {
 		if(!empty($layout_def['column_key'])){
 			$field_def = $this->reporter->all_fields[$layout_def['column_key']];
-		}else if(!empty($layout_def['fields'])){
+		} else if(!empty($layout_def['fields'])){
 			$field_def = $layout_def['fields'];
 		}
 
 		if (!empty($layout_def['table_key'] ) &&( empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))){
 			$value = $this->_get_list_value($layout_def);
-		}else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
+		} else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
 			$key = strtoupper($layout_def['name']);
 			$value = $layout_def['fields'][$key];
 		}
@@ -158,7 +159,7 @@ 
 
 			if(isset($field_def['options'])){
 				$cell = translate($field_def['options'], $field_def['module'], $value);
-			}else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
+			} else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
 	            global $beanFiles;
 	            if(empty($beanFiles)) {
 	                include('include/modules.php');
@@ -217,18 +218,15 @@ 
         if(!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
             if ( isset($layout_def['options']) &&  is_array($layout_def['options']) ) {
                 $ops = $layout_def['options'];
-            }
-            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
+            } elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
             	$ops = $app_list_strings[$layout_def['options']];
                 if(array_key_exists('', $app_list_strings[$layout_def['options']])) {
              	   unset($ops['']);
 	            }
-            }
-            else{
+            } else{
             	$ops = array();
             }
-        }
-        else {
+        } else {
             $ops = $app_list_strings[$layout_def['options']];
         }
 

include/generic/SugarWidgets/SugarWidgetFieldcurrency.php

Braces +17 added lines, -19 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -57,8 +59,7 @@ 
         if($current_user->getPreference('currency') )
         {
                 $global_currency_obj->retrieve($current_user->getPreference('currency'));
-        }
-        else
+        } else
         {
                 $global_currency_obj->retrieve('-99');
         }
@@ -81,8 +82,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -111,13 +111,13 @@ 
 
         if(!empty($layout_def['column_key'])){
             $field_def = $this->reporter->all_fields[$layout_def['column_key']];
-        }else if(!empty($layout_def['fields'])){
+        } else if(!empty($layout_def['fields'])){
             $field_def = $layout_def['fields'];
         }
         $record = '';
-        if ($layout_def['table_key'] == 'self' && isset($layout_def['fields']['PRIMARYID']))
-            $record = $layout_def['fields']['PRIMARYID'];
-        else if (isset($layout_def['fields'][strtoupper($layout_def['table_alias']."_id")])){
+        if ($layout_def['table_key'] == 'self' && isset($layout_def['fields']['PRIMARYID'])) {
+                    $record = $layout_def['fields']['PRIMARYID'];
+        } else if (isset($layout_def['fields'][strtoupper($layout_def['table_alias']."_id")])){
             $record = $layout_def['fields'][strtoupper($layout_def['table_alias']."_id")];
         }
         if (!empty($record)) {
@@ -133,9 +133,9 @@ 
             }
 	        $str .= "</div>";
 	        return $str;
+        } else {
+                    return $display;
         }
-        else
-            return $display;
     }
 
     function displayListPlain($layout_def) {
@@ -215,8 +215,9 @@ 
         }
 
         $real_table = '';
-        if (!empty($this->reporter->all_fields[$layout_def['column_key']]['real_table']))
-            $real_table = $this->reporter->all_fields[$layout_def['column_key']]['real_table'];
+        if (!empty($this->reporter->all_fields[$layout_def['column_key']]['real_table'])) {
+                    $real_table = $this->reporter->all_fields[$layout_def['column_key']]['real_table'];
+        }
 
         $add_currency_id = false;
         if(!empty($table)) {
@@ -249,19 +250,16 @@ 
         {
             $currency_symbol = $layout_def['currency_symbol'];
             $currency_id = $layout_def['currency_id'];
-        }
-        else
+        } else
         {
             $key = strtoupper(isset($layout_def['varname']) ? $layout_def['varname'] : $this->_get_column_alias($layout_def));
             if ( $this->isSystemCurrency($layout_def) )
             {
                 $currency_id = '-99';
-            }
-            elseif (isset($layout_def['fields'][$key.'_CURRENCY']))
+            } elseif (isset($layout_def['fields'][$key.'_CURRENCY']))
             {
                 $currency_id = $layout_def['fields'][$key.'_CURRENCY'];
-            }
-            elseif(isset($layout_def['fields'][$this->getTruncatedColumnAlias($this->_get_column_alias($layout_def)."_currency")]))
+            } elseif(isset($layout_def['fields'][$this->getTruncatedColumnAlias($this->_get_column_alias($layout_def)."_currency")]))
             {
                 $currency_id = $layout_def['fields'][$this->getTruncatedColumnAlias($this->_get_column_alias($layout_def)."_currency")];
             }

include/generic/SugarWidgets/SugarWidgetField.php

Braces +4 added lines, -5 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry)
+if(!defined('sugarEntry') || !sugarEntry) {
 	die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -57,8 +58,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -186,8 +186,7 @@ 
 		$key = '';
 		if ( isset($layout_def['varname']) ) {
 		    $key = strtoupper($layout_def['varname']);
-		}
-		else {
+		} else {
 			$key = strtoupper($this->_get_column_alias($layout_def));
 		}
 

include/generic/SugarWidgets/SugarWidgetFieldname.php

Braces +14 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -59,8 +61,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -89,8 +90,9 @@ 
 		$record = $layout_def['fields'][$key];
 		$layout_def['name'] = $name;
 		global $current_user;
-		if ($module == 'Users' && !is_admin($current_user))
-        	$module = 'Employees';
+		if ($module == 'Users' && !is_admin($current_user)) {
+		        	$module = 'Employees';
+		}
 		$str = "<a target='_blank' href=\"index.php?action=DetailView&module=$module&record=$record\">";
 		$str .= $this->displayListPlain($layout_def);
 		$str .= "</a>";
@@ -105,8 +107,9 @@ 
             $field_name = $layout_def['name'];
             $field_type = $field_def['type'];
             $str .= "</a>";
-            if ($field_name == 'name')
-                $str .= "&nbsp;" .SugarThemeRegistry::current()->getImage("edit_inline","border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(\"$div_id\",\"$value\",\"$module\",\"$record\",\"$field_name\",\"$field_type\");'");
+            if ($field_name == 'name') {
+                            $str .= "&nbsp;" .SugarThemeRegistry::current()->getImage("edit_inline","border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(\"$div_id\",\"$value\",\"$module\",\"$record\",\"$field_name\",\"$field_type\");'");
+            }
             $str .= "</div>";
         }
 		return $str;
@@ -238,9 +241,9 @@ 
 			if ($value == 'Current User') {
 				global $current_user;
 				array_push($arr,$this->reporter->db->quoted($current_user->id));
+			} else {
+							array_push($arr,$this->reporter->db->quoted($value));
 			}
-			else
-				array_push($arr,$this->reporter->db->quoted($value));
 		}
 
 		$str = implode(",",$arr);
@@ -262,9 +265,9 @@ 
 			if ($value == 'Current User') {
 				global $current_user;
 				array_push($arr,$this->reporter->db->quoted($current_user->id));
+			} else {
+							array_push($arr,$this->reporter->db->quoted($value));
 			}
-			else
-				array_push($arr,$this->reporter->db->quoted($value));
 		}
 
 		$str = implode(",",$arr);

include/generic/SugarWidgets/SugarWidgetSubPanelTopButton.php

Braces +34 added lines, -30 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -66,31 +68,38 @@ 
 			$class_details = $module;
 
 			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($class_details['module']))
-				$this->module = $class_details['module'];
-			if(!empty($class_details['title']))
-				$this->title = $app_strings[$class_details['title']];
-			if(!empty($class_details['access_key']))
-				$this->access_key = $app_strings[$class_details['access_key']];
-			if(!empty($class_details['form_value']))
-				$this->form_value = translate($class_details['form_value'], $this->module);
-			if(!empty($class_details['additional_form_fields']))
-				$this->additional_form_fields = $class_details['additional_form_fields'];
+			if(!empty($class_details['module'])) {
+							$this->module = $class_details['module'];
+			}
+			if(!empty($class_details['title'])) {
+							$this->title = $app_strings[$class_details['title']];
+			}
+			if(!empty($class_details['access_key'])) {
+							$this->access_key = $app_strings[$class_details['access_key']];
+			}
+			if(!empty($class_details['form_value'])) {
+							$this->form_value = translate($class_details['form_value'], $this->module);
+			}
+			if(!empty($class_details['additional_form_fields'])) {
+							$this->additional_form_fields = $class_details['additional_form_fields'];
+			}
 			if(!empty($class_details['ACL'])){
 				$this->acl = $class_details['ACL'];
 			}
-		}
-		else
+		} else
 		{
 			$this->module = $module;
 
 			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($title))
-				$this->title = $app_strings[$title];
-			if(!empty($access_key))
-				$this->access_key = $app_strings[$access_key];
-			if(!empty($form_value))
-				$this->form_value = translate($form_value, $module);
+			if(!empty($title)) {
+							$this->title = $app_strings[$title];
+			}
+			if(!empty($access_key)) {
+							$this->access_key = $app_strings[$access_key];
+			}
+			if(!empty($form_value)) {
+							$this->form_value = translate($form_value, $module);
+			}
 		}
 	}
 
@@ -101,8 +110,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($module, $title, $access_key, $form_value);
@@ -130,8 +138,7 @@ 
                 if(!empty($defines['focus']->$value))
                 {
                     $additionalFormFields[$key] = $defines['focus']->$value;
-                }
-                else
+                } else
                 {
                     $additionalFormFields[$key] = '';
                 }
@@ -142,8 +149,7 @@ 
 		if(!empty($this->module))
         {
             $defines['child_module_name'] = $this->module;
-        }
-        else
+        } else
         {
             $defines['child_module_name'] = $defines['module'];
         }
@@ -175,7 +181,7 @@ 
 
         if($currentModule == 'Campaigns'){
             $formValues['return_action'] = "DetailView";
-        }else{
+        } else{
             $formValues['return_action'] = $defines['action'];
             if ( $formValues['return_action'] == 'SubPanelViewer' ) {
                 $formValues['return_action'] = 'DetailView';
@@ -209,8 +215,7 @@ 
         {
             if($defines['focus']->object_name=='Contact') {
                 $additionalFormFields['parent_type'] = 'Accounts';
-            }
-            else {
+            } else {
                 $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
             }
         }
@@ -219,8 +224,7 @@ 
             if($defines['focus']->object_name=='Contact') {
                 $additionalFormFields['parent_name'] = $defines['focus']->account_name;
                 $additionalFormFields['account_name'] = $defines['focus']->account_name;
-            }
-            else {
+            } else {
                 $additionalFormFields['parent_name'] = $defines['focus']->name;
             }
         }

modules/Campaigns/WizardNewsletterSave.php

Braces +6 added lines, -5 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,8 +55,7 @@ 
     $campaign_focus = new Campaign();
     if(isset($_REQUEST['record']) && $_REQUEST['record'] && !(isset($_REQUEST['campaign_id']) && $_REQUEST['campaign_id'])) {
         $campaign_focus->retrieve($_REQUEST['record']);
-    }
-    else if(isset($_REQUEST['campaign_id']) && $_REQUEST['campaign_id']) {
+    } else if(isset($_REQUEST['campaign_id']) && $_REQUEST['campaign_id']) {
         $campaign_focus->retrieve($_REQUEST['campaign_id']);
     }
 
@@ -230,7 +231,7 @@ 
                          $action = 'WizardMarketing';
                         break;
                 }
-            }else{
+            } else{
                 $action = 'WizardHome&record='.$campaign_focus->id;
             }
             //require_once('modules/Campaigns/WizardMarketing.php');
@@ -395,7 +396,7 @@ 
                         $action = 'WizardHome';
                         break;
                 }
-            }else{
+            } else{
                 $action = 'WizardHome&record='.$campaign_focus->id;
             }
             //require_once('modules/Campaigns/WizardMarketing.php');

modules/EmailTemplates/EmailTemplateData.php

Braces +7 added lines, -9 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 function handleAttachmentForRemove() {
     if(!empty($_REQUEST['attachmentsRemove'])) {
@@ -60,8 +62,7 @@ 
                     $marketing = BeanFactory::getBean('EmailMarketing', $marketingId);
                     $marketing->template_id = $emailTemplateId;
                     $marketing->save();
-                }
-                else {
+                } else {
                     // TODO something is not OK, the selected campaign isn't related to this marketing!!
                     $GLOBALS['log']->debug('Selected marketing not found!');
                 }
@@ -75,8 +76,7 @@ 
             foreach($bean as $key => $value) {
                 if(in_array($key, $fields)) {
                     $newBean->$key = $_POST[$key];
-                }
-                else if(in_array($key, $fieldsForCopy)) {
+                } else if(in_array($key, $fieldsForCopy)) {
                     $newBean->$key = $bean->$key;
                 }
             }
@@ -125,16 +125,14 @@ 
                     }
                     $data['attachments'] = $attachments;
                 }
-            }
-            else {
+            } else {
                 $error = 'Email Template not found.';
             }
             break;
     }
 
 
-}
-else {
+} else {
     $error = 'Illegal GUID format.';
 }