adamjakab / SuiteCRM

modules/ModuleBuilder/views/view.property.php

Braces +4 added lines, -4 removed lines

@@ -55,8 +55,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -141,8 +140,9 @@ 
         $smarty->assign('APP', $GLOBALS['app_strings']);
         $smarty->assign("view_module", $this->editModule);
         $smarty->assign("subpanel", $this->subpanel);
-        if (isset($this->editPackage))
-            $smarty->assign("view_package", $this->editPackage);
+        if (isset($this->editPackage)) {
+                    $smarty->assign("view_package", $this->editPackage);
+        }
 
         $ajax->addSection('east', translate('LBL_SECTION_PROPERTIES', 'ModuleBuilder'), $smarty->fetch('modules/ModuleBuilder/tpls/editProperty.tpl'));
         echo $ajax->getJavascript();

modules/ModuleBuilder/views/view.main.php

Braces +4 added lines, -3 removed lines

@@ -52,8 +52,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -116,7 +115,9 @@ 
 			$smarty->assign('TREElabel', $mbt->getName());
 		}
 		$userPref = $current_user->getPreference('mb_assist', 'Assistant');
-		if(!$userPref) $userPref="na";
+		if(!$userPref) {
+		    $userPref="na";
+		}
 		$smarty->assign('userPref',$userPref);
 
 		///////////////////////////////////

modules/ModuleBuilder/views/view.layoutview.php

Braces +9 added lines, -8 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -75,8 +76,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -269,9 +269,9 @@ 
         $ajax = new AjaxCompose ( ) ;
 
         $translatedViewType = '' ;
-		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) )
-			$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
-        else if (isset($this->sm))
+		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) ) {
+					$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+		} else if (isset($this->sm))
         {
             foreach($this->sm->sources as $file => $def)
             {
@@ -284,8 +284,9 @@ 
             {
                 $label = "LBL_" . strtoupper($this->editLayout);
                 $translated = translate($label, $this->editModule);
-                if ($translated != $label)
-                    $translatedViewType =  $translated;
+                if ($translated != $label) {
+                                    $translatedViewType =  $translated;
+                }
             }
         }
 

modules/ModuleBuilder/parsers/parser.searchfields.php

Braces +9 added lines, -5 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -68,8 +69,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($moduleName, $packageName);
@@ -100,9 +100,11 @@ 
     function getSearchFields()
     {
     	$searchFields = array();
-        if (!empty($this->packageName) && file_exists("custom/modulebuilder/packages/{$this->packageName}/modules/{$this->moduleName}/metadata/SearchFields.php")) //we are in Module builder
+        if (!empty($this->packageName) && file_exists("custom/modulebuilder/packages/{$this->packageName}/modules/{$this->moduleName}/metadata/SearchFields.php")) {
+            //we are in Module builder
         {
 			include("custom/modulebuilder/packages/{$this->packageName}/modules/{$this->moduleName}/metadata/SearchFields.php");
+        }
         } else if(file_exists("custom/modules/{$this->moduleName}/metadata/SearchFields.php")) {
 			include("custom/modules/{$this->moduleName}/metadata/SearchFields.php");
         } else if(file_exists("modules/{$this->moduleName}/metadata/SearchFields.php")) {
@@ -114,9 +116,11 @@ 
 
     function saveSearchFields ($searchFields)
     {
-        if (!empty($this->packageName)) //we are in Module builder
+        if (!empty($this->packageName)) {
+            //we are in Module builder
         {
 			$header = file_get_contents('modules/ModuleBuilder/MB/header.php');
+        }
             if(!file_exists("custom/modulebuilder/packages/{$this->packageName}/modules/{$this->moduleName}/metadata/SearchFields.php"))
             {
                mkdir_recursive("custom/modulebuilder/packages/{$this->packageName}/modules/{$this->moduleName}/metadata");

modules/ModuleBuilder/parsers/ModuleBuilderParser.php

Braces +8 added lines, -7 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -58,8 +60,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -131,8 +132,9 @@ 
 	 */
 	function _writeToFile ($file,$view,$moduleName,$defs,$variables)
 	{
-	        if(file_exists($file))
-	            unlink($file);
+	        if(file_exists($file)) {
+	        	            unlink($file);
+	        }
 
 	        mkdir_recursive ( dirname ( $file ) ) ;
 	        $GLOBALS['log']->debug("ModuleBuilderParser->_writeFile(): file=".$file);
@@ -174,8 +176,7 @@ 
 //           $GLOBALS['log']->debug("parser.modifylayout.php->_writeFile(): out=".print_r($out,true));
             fputs( $fh, $out);
             fclose( $fh );
-            }
-            else
+            } else
             {
                 $GLOBALS['log']->fatal("ModuleBuilderParser->_writeFile() Could not write new viewdef file ".$file);
             }

modules/Relationships/Relationship.php

Braces +5 added lines, -5 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -83,8 +85,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -212,8 +213,7 @@ 
 			{
 					$this->$field = $value;
 			}
-		}
-		else {
+		} else {
 			$GLOBALS['log']->fatal('Error fetching relationship from cache '.$relationship_name);
 			return false;
 		}

modules/Leads/LeadsJjwg_MapsLogicHook.php

Braces +3 added lines, -3 removed lines

@@ -1,7 +1,8 @@ 
 <?php
 
-if (!defined('sugarEntry') || !sugarEntry)
+if (!defined('sugarEntry') || !sugarEntry) {
     die('Not A Valid Entry Point');
+}
 
 class LeadsJjwg_MapsLogicHook {
 
@@ -17,8 +18,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();

modules/SchedulersJobs/SchedulersJob.php

Braces +6 added lines, -7 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -110,8 +112,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -587,12 +588,10 @@ 
                 } else {
                     return $this->resolution != self::JOB_FAILURE;
                 }
-            }
-            else {
+            } else {
                 $this->resolveJob(self::JOB_FAILURE, sprintf(translate('ERR_JOBTYPE', 'SchedulersJobs'), strip_tags($this->target)));
             }
-        }
-        else {
+        } else {
 		    $this->resolveJob(self::JOB_FAILURE, sprintf(translate('ERR_JOBTYPE', 'SchedulersJobs'), strip_tags($this->target)));
 		}
 		return false;

modules/ACLActions/ACLAction.php

Braces +20 added lines, -15 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -62,8 +64,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -100,7 +101,7 @@ 
                 }
             }
 
-        }else{
+        } else{
             sugar_die("FAILED TO ADD: $category - TYPE $type NOT DEFINED IN modules/ACLActions/actiondefs.php");
         }
 
@@ -128,7 +129,7 @@ 
                     $action->mark_deleted($row['id']);
                 }
             }
-        }else{
+        } else{
             sugar_die("FAILED TO REMOVE: $category : $name - TYPE $type NOT DEFINED IN modules/ACLActions/actiondefs.php");
         }
     }
@@ -196,7 +197,9 @@ 
         global $ACLActions;
         $options = array();
 
-        if(empty($ACLActions[$type]['actions'][$action]['aclaccess']))return $options;
+        if(empty($ACLActions[$type]['actions'][$action]['aclaccess'])) {
+            return $options;
+        }
         foreach($ACLActions[$type]['actions'][$action]['aclaccess'] as $action){
             $options[$action] = ACLAction::AccessName($action);
         }
@@ -247,14 +250,14 @@ 
         if(!$refresh && !empty($_SESSION['ACL'][$user_id])){
             if(empty($category) && empty($action)){
                 return $_SESSION['ACL'][$user_id];
-            }else{
+            } else{
                 if(!empty($category) && isset($_SESSION['ACL'][$user_id][$category])){
                     if(empty($action)){
                         if(empty($type)){
                             return $_SESSION['ACL'][$user_id][$category];
                         }
                         return $_SESSION['ACL'][$user_id][$category][$type];
-                    }else if(!empty($type) && isset($_SESSION['ACL'][$user_id][$category][$type][$action])){
+                    } else if(!empty($type) && isset($_SESSION['ACL'][$user_id][$category][$type][$action])){
                         return $_SESSION['ACL'][$user_id][$category][$type][$action];
                     }
                 }
@@ -374,12 +377,12 @@ 
                 $_SESSION['ACL'] = array();
             }
             $_SESSION['ACL'][$user_id] = $selected_actions;
-        }else{
+        } else{
             if(empty($action) && !empty($category)){
                 if(!empty($type)){
                     $_SESSION['ACL'][$user_id][$category][$type] = $selected_actions[$category][$type];}
                 $_SESSION['ACL'][$user_id][$category] = $selected_actions[$category];
-            }else{
+            } else{
                 if(!empty($action) && !empty($category) && !empty($type)){
                 $_SESSION['ACL'][$user_id][$category][$type][$action] = $selected_actions[$category][$action];
 
@@ -398,8 +401,9 @@ 
         // Fallback to array key if translation is empty
         $a = empty($app_list_strings['moduleList'][$a]) ? $a : $app_list_strings['moduleList'][$a];
         $b = empty($app_list_strings['moduleList'][$b]) ? $b : $app_list_strings['moduleList'][$b];
-        if ($a == $b)
-            return 0;
+        if ($a == $b) {
+                    return 0;
+        }
         return ($a < $b) ? -1 : 1;
     }
 
@@ -494,7 +498,9 @@ 
         return true;
         }
         //check if we don't have it set in the cache if not lets reload the cache
-        if(ACLAction::getUserAccessLevel($user_id, $category, 'access', $type) < ACL_ALLOW_ENABLED) return false;
+        if(ACLAction::getUserAccessLevel($user_id, $category, 'access', $type) < ACL_ALLOW_ENABLED) {
+            return false;
+        }
         if(empty($_SESSION['ACL'][$user_id][$category][$type][$action])){
             ACLAction::getUserActions($user_id, false);
 
@@ -590,8 +596,7 @@ 
                     if($cat_name=='Users'&& $act_name=='admin'){
                         $categories[$cat_name][$type_name][$act_name]['accessOptions'][ACL_ALLOW_DEFAULT]=ACLAction::AccessName(ACL_ALLOW_DEFAULT);;
                         $categories[$cat_name][$type_name][$act_name]['accessOptions'][ACL_ALLOW_DEV]=ACLAction::AccessName(ACL_ALLOW_DEV);;
-                    }
-                    else{
+                    } else{
                     $categories[$cat_name][$type_name][$act_name]['accessOptions'] =  ACLAction::getAccessOptions($act_name, $type_name);
                     }
                 }