adamjakab / SuiteCRM

modules/ModuleBuilder/parsers/parser.modifysubpanel.php

Braces +11 added lines, -6 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -114,10 +115,12 @@ 
         $this->defaults = array ( ) ;
         foreach ( $this->listViewDefs as $key => $def )
         {
-            if (! empty ( $def [ 'usage' ] ) && strcmp ( $def [ 'usage' ], 'query_only' ) == 0)
-                continue ;
-            if (! empty ( $def [ 'vname' ] ))
-                $def [ 'label' ] = $def [ 'vname' ] ;
+            if (! empty ( $def [ 'usage' ] ) && strcmp ( $def [ 'usage' ], 'query_only' ) == 0) {
+                            continue ;
+            }
+            if (! empty ( $def [ 'vname' ] )) {
+                            $def [ 'label' ] = $def [ 'vname' ] ;
+            }
             $this->defaults [ $key ] = $def ;
         }
         return $this->defaults ;
@@ -144,11 +147,13 @@ 
             foreach ( $this->subPanelParentModule->field_defs as $key => $fieldDefinition )
             {
                 $fieldName = strtolower ( $key ) ;
-                if (! isset ( $lowerFieldList [ $fieldName ] )) // bug 16728 - check this first, so that other conditions (e.g., studio == visible) can't override and add duplicate entries
+                if (! isset ( $lowerFieldList [ $fieldName ] )) {
+                    // bug 16728 - check this first, so that other conditions (e.g., studio == visible) can't override and add duplicate entries
                 {
                     if ((empty ( $fieldDefinition [ 'source' ] ) || $fieldDefinition [ 'source' ] == 'db' || $fieldDefinition [ 'source' ] == 'custom_fields') && $fieldDefinition [ 'type' ] != 'id' && strcmp ( $fieldName, 'deleted' ) != 0 || (isset ( $def [ 'name' ] ) && strpos ( $def [ 'name' ], "_name" ) != false) || ! empty ( $def [ 'custom_type' ] ) && (empty ( $fieldDefinition [ 'dbType' ] ) || $fieldDefinition [ 'dbType' ] != 'id') && (empty ( $fieldDefinition [ 'dbtype' ] ) || $fieldDefinition [ 'dbtype' ] != 'id') || (! empty ( $fieldDefinition [ 'studio' ] ) && $fieldDefinition [ 'studio' ] == 'visible'))
                     {
                         $label = (isset ( $fieldDefinition [ 'vname' ] )) ? $fieldDefinition [ 'vname' ] : (isset ( $fieldDefinition [ 'label' ] ) ? $fieldDefinition [ 'label' ] : $fieldDefinition [ 'name' ]) ;
+                }
                         $this->availableFields [ $fieldName ] = array ( 'width' => '10' , 'label' => $label ) ;
                     }
                 }

modules/ModuleBuilder/parsers/parser.modifylayoutview.php

Braces +14 added lines, -20 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined('sugarEntry') || ! sugarEntry)
-die('Not A Valid Entry Point');
+if (! defined('sugarEntry') || ! sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -80,12 +81,10 @@ 
         {
             $this->_sourceFile = $this->_workingFile;
             $this->usingWorkingFile = true;
-        }
-        else if (is_file($this->_customFile))
+        } else if (is_file($this->_customFile))
         {
             $this->_sourceFile = $this->_customFile;
-        }
-        else if (! is_file($this->_sourceFile))
+        } else if (! is_file($this->_sourceFile))
         {
             // if we don't have ANY defined metadata then improvise as best we can
             if (strtolower($this->_view) == 'quickcreate')
@@ -97,8 +96,7 @@ 
                     $this->_sourceFile = "custom/" . $this->_sourceFile;
                 }
                 $this->_sourceView = 'EditView';
-            }
-            else
+            } else
             {
                 $this->_fatalError('parser.modifylayout.php->init(): no metadata for '.$this->_module.' '.$this->_view);
             }
@@ -171,8 +169,7 @@ 
         {
         	TemplateHandler::clearCache($this->_module,"form_SubPanelQuickCreate_{$this->_module}.tpl");
         	TemplateHandler::clearCache($this->_module,"form_DCQuickCreate_{$this->_module}.tpl");
-        } 
-        else 
+        } else 
         {
         	TemplateHandler::clearCache($this->_module,"{$this->_view}.tpl");
         }
@@ -236,8 +233,7 @@ 
                 if ($slotComponents ['3'] == 'name' && isset($origFieldDefs [$value]) && is_array($origFieldDefs [$value]))
                 {
                     $this->_viewdefs ['panels'] [$panelID] [$rowID] [$colID] = $origFieldDefs [$value];
-                }
-                else
+                } else
                 {
                     $property = $slotComponents ['3'];
                     if ($value == '(filler)')
@@ -341,8 +337,7 @@ 
                     foreach ($row as $col_id => $col) {
                         if ($col['name'] == '(filler)') {
                             $this->_viewdefs['panels'][$loop_panelID][$row_id][$col_id] = NULL;
-                        }
-                        elseif ($col['name'] == '(empty)') {
+                        } elseif ($col['name'] == '(empty)') {
                             unset($this->_viewdefs['panels'][$loop_panelID][$row_id][$col_id]);
                         }
                     }
@@ -401,8 +396,7 @@ 
             {
                 $label = isset($def['vname']) ? $def['vname'] : $def['name'];
                 $modelFields [$field] = array('name' => $field, 'label' => $label);
-            }
-            else
+            } else
             {
                 $GLOBALS['log']->debug( get_class($this)."->_getModelFields(): skipping $field from modelFields as it fails the test for inclusion");
             }
@@ -414,8 +408,9 @@ 
     function _parseData ($panels)
     {
         $fields = array();
-        if (empty($panels))
-        return;
+        if (empty($panels)) {
+                return;
+        }
 
         // Fix for a flexibility in the format of the panel sections - if only one panel, then we don't have a panel level defined, it goes straight into rows
         // See EditView2 for similar treatment
@@ -506,8 +501,7 @@ 
                         if (is_array($fieldDef))
                         {
                             $fieldName = $fieldDef ['name'];
-                        }
-                        else
+                        } else
                         {
                             $fieldName = $fieldDef;
                         }

modules/Reminders_Invitees/Reminder_Invitee.php

Braces +6 added lines, -7 removed lines

@@ -76,7 +76,9 @@ 
     public static function saveRemindersInviteesData($reminderId, $inviteesData) {
         $savedInviteeIds = array();
         foreach($inviteesData as $k => $inviteeData) {
-            if(isset($_POST['isDuplicate']) && $_POST['isDuplicate']) $inviteeData->id = '';
+            if(isset($_POST['isDuplicate']) && $_POST['isDuplicate']) {
+                $inviteeData->id = '';
+            }
             $reminderInviteeBean = BeanFactory::getBean('Reminders_Invitees', $inviteeData->id);
             $reminderInviteeBean->reminder_id = $reminderId;
             $reminderInviteeBean->related_invitee_module = $inviteeData->module;
@@ -84,8 +86,7 @@ 
             if(!$inviteeData->id) {
                 $reminderInviteeBean->save();
                 $savedInviteeIds[] = $reminderInviteeBean->id;
-            }
-            else {
+            } else {
                 $addedInvitees = BeanFactory::getBean('Reminders_Invitees')->get_full_list("", "reminders_invitees.id != '{$inviteeData->id}' AND reminders_invitees.reminder_id = '{$reminderInviteeBean->reminder_id}' AND reminders_invitees.related_invitee_module = '{$reminderInviteeBean->related_invitee_module}' AND reminders_invitees.related_invitee_module_id = '{$reminderInviteeBean->related_invitee_module_id}'");
                 if (!$addedInvitees) {
                     $reminderInviteeBean->save();
@@ -132,11 +133,9 @@ 
             default:
                 if(isset($bean->first_name) && isset($bean->last_name)) {
                     $retValue = "{$bean->first_name} {$bean->last_name}";
-                }
-                else if(isset($bean->name)) {
+                } else if(isset($bean->name)) {
                     $retValue = $bean->name;
-                }
-                else if(isset($bean->email)) {
+                } else if(isset($bean->email)) {
                     $retValue = $bean->email;
                 }
                 if(!$retValue) {

modules/Import/maps/ImportMap.php

Braces +16 added lines, -10 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -227,7 +229,9 @@ 
 
         // Bug 23354 - Make sure enclosure gets saved as an empty string if
         // it is an empty string, instead of as a null
-        if ( strlen($enclosure) <= 0 ) $enclosure = ' ';
+        if ( strlen($enclosure) <= 0 ) {
+            $enclosure = ' ';
+        }
 
         $this->assigned_user_id = $owner_id;
         $this->name             = $name;
@@ -266,8 +270,9 @@ 
             $other_map = new ImportMap();
             $other_map->retrieve_by_string_fields(array('id'=> $id), false);
 
-            if ( $other_map->assigned_user_id != $current_user->id )
-                return false;
+            if ( $other_map->assigned_user_id != $current_user->id ) {
+                            return false;
+            }
         }
 
         return parent::mark_deleted($id);
@@ -287,8 +292,9 @@ 
     {
         global $current_user;
 
-        if ( !is_admin($current_user) )
-            return false;
+        if ( !is_admin($current_user) ) {
+                    return false;
+        }
 
         // check for problems
         if ($flag) {
@@ -299,8 +305,7 @@ 
                 'name'         =>$this->name,
                 'is_published' =>'yes'
                 );
-        }
-        else {
+        } else {
             // if you are trying to unpublish a map
             // but you own an unpublished map by the same name
             $query_arr = array(
@@ -313,8 +318,9 @@ 
         $other_map->retrieve_by_string_fields($query_arr, false);
 
         // if we find this other map, quit
-        if ( isset($other_map->id) )
-            return false;
+        if ( isset($other_map->id) ) {
+                    return false;
+        }
 
         // otherwise update the is_published flag
         $query = "UPDATE $this->table_name

modules/Import/ImportDuplicateCheck.php

Braces +64 added lines, -42 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -83,18 +85,20 @@ 
             $indexes = array_merge($custmIndexes,$indexes);
         }
 
-        if ( $this->_focus->getFieldDefinition('email1') )
-            $indexes[] = array(
+        if ( $this->_focus->getFieldDefinition('email1') ) {
+                    $indexes[] = array(
                 'name' => 'special_idx_email1',
                 'type' => 'index',
                 'fields' => array('email1')
                 );
-        if ( $this->_focus->getFieldDefinition('email2') )
-            $indexes[] = array(
+        }
+        if ( $this->_focus->getFieldDefinition('email2') ) {
+                    $indexes[] = array(
                 'name' => 'special_idx_email2',
                 'type' => 'index',
                 'fields' => array('email2')
                 );
+        }
 
         return $indexes;
     }
@@ -116,12 +120,15 @@ 
             if ($index['type'] == "index"){
                 $labelsArray = array();
                 foreach ($index['fields'] as $field){
-                    if ($field == 'deleted') continue;
+                    if ($field == 'deleted') {
+                        continue;
+                    }
                     $fieldDef = $this->_focus->getFieldDefinition($field);
-                    if ( isset($fieldDef['vname']) && isset($super_language_pack[$fieldDef['vname']]) )
-                        $labelsArray[$fieldDef['name']] = $super_language_pack[$fieldDef['vname']];
-                    else
-                        $labelsArray[$fieldDef['name']] = $fieldDef['name'];
+                    if ( isset($fieldDef['vname']) && isset($super_language_pack[$fieldDef['vname']]) ) {
+                                            $labelsArray[$fieldDef['name']] = $super_language_pack[$fieldDef['vname']];
+                    } else {
+                                            $labelsArray[$fieldDef['name']] = $fieldDef['name'];
+                    }
                 }
                 $index_array[$index['name']] = str_replace(":", "",implode(", ",$labelsArray));
             }
@@ -144,33 +151,37 @@ 
             {
                 $emailAddress = new SugarEmailAddress();
                 $email = $field;
-                if ( $emailAddress->getCountEmailAddressByBean($this->_focus->$email,$this->_focus,($field == 'email1')) > 0 )
-                    return true;
-            }
-            else
+                if ( $emailAddress->getCountEmailAddressByBean($this->_focus->$email,$this->_focus,($field == 'email1')) > 0 ) {
+                                    return true;
+                }
+            } else
             {
                 $index_fields = array('deleted' => '0');
                 if( is_array($field) )
                 {
                     foreach($field as $tmpField)
                     {
-                        if ($tmpField == 'deleted')
-                            continue;
-                        if (strlen($this->_focus->$tmpField) > 0)
-                            $index_fields[$tmpField] = $this->_focus->$tmpField;
+                        if ($tmpField == 'deleted') {
+                                                    continue;
+                        }
+                        if (strlen($this->_focus->$tmpField) > 0) {
+                                                    $index_fields[$tmpField] = $this->_focus->$tmpField;
+                        }
                     }
+                } elseif($field != 'deleted' && strlen($this->_focus->$field) > 0) {
+                                    $index_fields[$field] = $this->_focus->$field;
                 }
-                elseif($field != 'deleted' && strlen($this->_focus->$field) > 0)
-                    $index_fields[$field] = $this->_focus->$field;
 
-                if ( count($index_fields) <= 1 )
-                    continue;
+                if ( count($index_fields) <= 1 ) {
+                                    continue;
+                }
 
                 $newfocus = loadBean($this->_focus->module_dir);
                 $result = $newfocus->retrieve_by_string_fields($index_fields,true);
 
-                if ( !is_null($result) )
-                    return true;
+                if ( !is_null($result) ) {
+                                    return true;
+                }
             }
         }
 
@@ -204,13 +215,15 @@ 
         $fieldlist=array();
         $customIndexlist=array();
         foreach($origIndexList as $iv){
-            if(empty($iv)) continue;
+            if(empty($iv)) {
+                continue;
+            }
             $field_index_array = explode('::',$iv);
             if($field_index_array[0] == 'customfield'){
                 //this is a custom field, so place in custom array
                 $customIndexlist[] = $field_index_array[1];
 
-            }else{
+            } else{
                 //this is not a custom field, so place in index list
                 $indexlist[] = $field_index_array[0];
                 if(isset($field_index_array[1])) {
@@ -237,8 +250,9 @@ 
         // loop through var def indexes and compare with selected indexes
         foreach ($this->_getIndexVardefs() as $index){
             // if we get an index not in the indexlist, loop
-            if ( !in_array($index['name'],$indexlist) )
-                continue;
+            if ( !in_array($index['name'],$indexlist) ) {
+                            continue;
+            }
 
             // This handles the special case of duplicate email checking
             if ( $index['name'] == 'special_idx_email1' || $index['name'] == 'special_idx_email2' ) {
@@ -249,31 +263,35 @@ 
                         $this->_focus,
                         ($index['name'] == 'special_idx_email1')
                         ) > 0 ){ foreach($index['fields'] as $field){
-                        if($field !='deleted')
-                            $this->_dupedFields[] = $field;
+                        if($field !='deleted') {
+                                                    $this->_dupedFields[] = $field;
+                        }
                     }
                 }
             }
             // Adds a hook so you can define a method in the bean to handle dupe checking
             elseif ( isset($index['dupeCheckFunction']) ) {
                 $functionName = substr_replace($index['dupeCheckFunction'],'',0,9);
-                if ( method_exists($this->_focus,$functionName) && $this->_focus->$functionName($index) === true)
-                    return $this->_focus->$functionName($index);
-            }
-            else {
+                if ( method_exists($this->_focus,$functionName) && $this->_focus->$functionName($index) === true) {
+                                    return $this->_focus->$functionName($index);
+                }
+            } else {
                 $index_fields = array('deleted' => '0');
                 //search only for the field we have selected
                 foreach($index['fields'] as $field){
-                    if ($field == 'deleted' ||  !in_array($field,$fieldlist))
-                        continue;
-                    if (!in_array($field,$index_fields))
-                        if (isset($this->_focus->$field) && strlen($this->_focus->$field) > 0)
+                    if ($field == 'deleted' ||  !in_array($field,$fieldlist)) {
+                                            continue;
+                    }
+                    if (!in_array($field,$index_fields)) {
+                                            if (isset($this->_focus->$field) && strlen($this->_focus->$field) > 0)
                             $index_fields[$field] = $this->_focus->$field;
+                    }
                 }
 
                 // if there are no valid fields in the index field list, loop
-                if ( count($index_fields) <= 1 )
-                    continue;
+                if ( count($index_fields) <= 1 ) {
+                                    continue;
+                }
 
                 $newfocus = loadBean($this->_focus->module_dir);
                 $result = $newfocus->retrieve_by_string_fields($index_fields,true);
@@ -320,11 +338,15 @@ 
                     $fieldName='';
 
                     //skip this field if it is the deleted field, not in the importable keys array, or a field in the exclude array
-                    if (!in_array($field, $importable_keys) || in_array($field, $exclude_array)) continue;
+                    if (!in_array($field, $importable_keys) || in_array($field, $exclude_array)) {
+                        continue;
+                    }
                     $fieldDef = $this->_focus->getFieldDefinition($field);
 
                     //skip if this field is already defined (from another index)
-                    if (in_array($fieldDef['name'],$fields_used)) continue;
+                    if (in_array($fieldDef['name'],$fields_used)) {
+                        continue;
+                    }
 
                     //get the proper export label
                     $fieldName = translateForExport($fieldDef['name'],$this->_focus);

modules/Cases/metadata/additionalDetails.php

Braces +9 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,12 +54,16 @@ 
 		
 	if(!empty($fields['DESCRIPTION'])) { 
 		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['DESCRIPTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 		$overlib_string .= '<br>';
 	}
 	if(!empty($fields['RESOLUTION'])) { 
 		$overlib_string .= '<b>'. $mod_strings['LBL_RESOLUTION'] . '</b> ' . substr($fields['RESOLUTION'], 0, 300);
-		if(strlen($fields['RESOLUTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['RESOLUTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 	}		
 	
 	return array('fieldToAddTo' => 'NAME', 

modules/Opportunities/SubPanelView.php

Braces +7 added lines, -4 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -69,7 +71,9 @@ 
 
 $button  = "<form action='index.php' method='post' name='form' id='form'>\n";
 $button .= "<input type='hidden' name='module' value='Opportunities'>\n";
-if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
+if ($currentModule == 'Accounts') {
+    $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
+}
 if ($currentModule == 'Contacts') {
 	$button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
 	$button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
@@ -105,8 +109,7 @@ 
 		."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
 		."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
 //		."  ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
-}
-else
+} else
 {
 	///////////////////////////////////////
 	///

modules/Opportunities/metadata/additionalDetails.php

Braces +18 added lines, -6 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,15 +47,25 @@ 
 	$mod_strings = return_module_language($current_language, 'Opportunities');
 	$overlib_string = '';
 	
-	if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
-	if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
-	if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
-	if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
+	if(!empty($fields['LEAD_SOURCE'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
+	}
+	if(!empty($fields['PROBABILITY'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
+	}
+	if(!empty($fields['NEXT_STEP'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
+	}
+	if(!empty($fields['OPPORTUNITY_TYPE'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
+	}
 
 	if(!empty($fields['DESCRIPTION'])) {
 		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
 		$overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['DESCRIPTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 	}	
 	
 	return array('fieldToAddTo' => 'NAME', 

modules/Opportunities/OpportunityFormBase.php

Braces +21 added lines, -9 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -65,7 +67,9 @@ 
 			$i++;
 			$rows[$i] = $row;
 		}
-		if ($i==-1) return null;
+		if ($i==-1) {
+		    return null;
+		}
 		
 		return $rows;		
 	}
@@ -77,7 +81,9 @@ 
 	if(!empty($mod)){
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
-	}else global $mod_strings;
+	} else {
+	    global $mod_strings;
+	}
 	global $app_strings;
 	$cols = sizeof($rows[0]) * 2 + 1;
 	$form = '<table width="100%"><tr><td>'.$mod_strings['MSG_DUPLICATE']. '</td></tr><tr><td height="20"></td></tr></table>';
@@ -108,14 +114,14 @@ 
 					if(!$wasSet){
 					$form .= "<td scope='row'><a target='_blank' href='index.php?module=Opportunities&action=DetailView&record=${row['id']}'>$value</a></td>";
 					$wasSet = true;
-					}else{
+					} else{
 					$form .= "<td><a target='_blank' href='index.php?module=Opportunities&action=DetailView&record=${row['id']}'>$value</a></td>";
 					}
 				}}
 
 		if($rowColor == 'evenListRowS1'){
 			$rowColor = 'oddListRowS1';
-		}else{
+		} else{
 			 $rowColor = 'evenListRowS1';
 		}
 		$form .= "</tr>";
@@ -136,7 +142,9 @@ 
 if(!empty($mod)){
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
-}else global $mod_strings;
+} else {
+    global $mod_strings;
+}
 global $app_strings;
 global $sugar_version, $sugar_config;
 
@@ -286,7 +294,9 @@ 
 EOQ;
 //carry forward custom lead fields to opportunities during Lead Conversion
 	$tempOpp = new Opportunity();
-	if (method_exists($lead, 'convertCustomFieldsForm')) $lead->convertCustomFieldsForm($the_form, $tempOpp, $prefix);
+	if (method_exists($lead, 'convertCustomFieldsForm')) {
+	    $lead->convertCustomFieldsForm($the_form, $tempOpp, $prefix);
+	}
 	unset($tempOpp);
 
 $the_form .= <<<EOQ
@@ -321,7 +331,9 @@ 
 if(!empty($mod)){
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
-}else global $mod_strings;
+} else {
+    global $mod_strings;
+}
 global $app_strings;
 global $app_list_strings;
 global $theme;
@@ -461,7 +473,7 @@ 
 	$GLOBALS['log']->debug("Saved record with id of ".$return_id);
 	if($redirect){
 		handleRedirect($return_id,"Opportunities" );
-	}else{
+	} else{
 		return $focus;
 	}
 }