adamjakab / SuiteCRM

modules/ModuleBuilder/parsers/relationships/OneToOneRelationship.php

Braces +11 added lines, -6 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -122,16 +124,19 @@ 
      */
     function buildFieldsToLayouts ()
     {
-        if ($this->relationship_only)
-            return array () ;
+        if ($this->relationship_only) {
+                    return array () ;
+        }
  
-        if ($this->lhs_module == $this->rhs_module) // don't add in two fields on recursive relationships
+        if ($this->lhs_module == $this->rhs_module) {
+            // don't add in two fields on recursive relationships
             return array ( $this->lhs_module => $this->getValidDBName($this->relationship_name . "_name") );
-        else
-            return array (
+        } else {
+                    return array (
                 $this->lhs_module => $this->getValidDBName($this->relationship_name . "_name") ,
                 $this->rhs_module => $this->getValidDBName($this->relationship_name . "_name")
             ) ;
+        }
     }
 
 }

modules/ModuleBuilder/parsers/relationships/AbstractRelationship.php

Braces +53 added lines, -38 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -107,9 +109,10 @@ 
     function __construct ($definition)
     {
         // set any undefined attributes to the default value
-        foreach ( array ( 'readonly' , 'deleted' , 'relationship_only', 'for_activities', 'is_custom', 'from_studio' ) as $key )
-            if (! isset ( $definition [ $key ] ))
+        foreach ( array ( 'readonly' , 'deleted' , 'relationship_only', 'for_activities', 'is_custom', 'from_studio' ) as $key ) {
+                    if (! isset ( $definition [ $key ] ))
                 $definition [ $key ] = false ;
+        }
         
         foreach ( self::$definitionKeys as $key )
         {
@@ -297,8 +300,9 @@ 
      */
     protected function getSubpanelDefinition ($relationshipName , $sourceModule , $subpanelName, $titleKeyName = '', $source = "")
     {
-        if (empty($source)) 
-        	$source = $this->getValidDBName($relationshipName);
+        if (empty($source)) {
+                	$source = $this->getValidDBName($relationshipName);
+        }
     	$subpanelDefinition = array ( ) ;
         $subpanelDefinition [ 'order' ] = 100 ;
         $subpanelDefinition [ 'module' ] = $sourceModule ;
@@ -308,7 +312,7 @@ 
         $subpanelDefinition [ 'sort_by' ] = 'id' ;
 		if(!empty($titleKeyName)){
 			$subpanelDefinition [ 'title_key' ] = 'LBL_' . strtoupper ( $relationshipName . '_FROM_' . $titleKeyName ) . '_TITLE' ;
-		}else{
+		} else{
 			$subpanelDefinition [ 'title_key' ] = 'LBL_' . strtoupper ( $relationshipName . '_FROM_' . $sourceModule ) . '_TITLE' ;
 		}
         $subpanelDefinition [ 'get_subpanel_data' ] = $source ;
@@ -338,12 +342,15 @@ 
         $vardef [ 'source' ] = 'non-db' ;
         $vardef [ 'module' ] = $sourceModule ;
         $vardef [ 'bean_name' ] = BeanFactory::getObjectName($sourceModule) ;
-        if ($right_side)
-        	$vardef [ 'side' ] = 'right' ;
-        if (!empty($vname))
-            $vardef [ 'vname' ] = $vname;
-        if (!empty($id_name))
-            $vardef['id_name'] = $id_name;
+        if ($right_side) {
+                	$vardef [ 'side' ] = 'right' ;
+        }
+        if (!empty($vname)) {
+                    $vardef [ 'vname' ] = $vname;
+        }
+        if (!empty($id_name)) {
+                    $vardef['id_name'] = $id_name;
+        }
 
         return $vardef ;
     }
@@ -365,12 +372,14 @@ 
         $vardef [ 'relationship' ] = $relationshipName ;
         $vardef [ 'source' ] = 'non-db' ;
 		$vardef ['reportable'] = false;
-        if ($right_side)
-        	$vardef [ 'side' ] = 'right' ;
-        else
-        	$vardef [ 'side' ] = 'left' ;
-        if (!empty($vname))
-            $vardef [ 'vname' ] = $vname;
+        if ($right_side) {
+                	$vardef [ 'side' ] = 'right' ;
+        } else {
+                	$vardef [ 'side' ] = 'left' ;
+        }
+        if (!empty($vname)) {
+                    $vardef [ 'vname' ] = $vname;
+        }
 
         return $vardef ;
     }
@@ -391,7 +400,7 @@ 
         $vardef [ 'source' ] = 'non-db' ;
 		if(!empty($vnameLabel)){
 			$vardef [ 'vname' ] = 'LBL_' . strtoupper ( $relationshipName . '_FROM_' . $vnameLabel ) . '_TITLE' ;
-		}else{
+		} else{
 			$vardef [ 'vname' ] = 'LBL_' . strtoupper ( $relationshipName . '_FROM_' . $sourceModule ) . '_TITLE' ;
 		}
         
@@ -420,11 +429,10 @@ 
             $module = $mb->getPackageModule ( $parsedModuleName['packageName'] , $parsedModuleName['moduleName'] ) ;
             if (in_array( 'file' , array_keys ( $module->config [ 'templates' ] ) ) ){
                 $vardef [ 'rname' ] = 'document_name' ;
-            }elseif(in_array ( 'person' , array_keys ( $module->config [ 'templates' ] ) ) ){
+            } elseif(in_array ( 'person' , array_keys ( $module->config [ 'templates' ] ) ) ){
             	$vardef [ 'db_concat_fields' ] = array( 0 =>'first_name', 1 =>'last_name') ;
             }
-        }
-        else
+        } else
         {
             switch ( strtolower( $sourceModule ) )
             {
@@ -452,7 +460,7 @@ 
                     if ( isset ( $GLOBALS [ 'dictionary' ] [ $object ] [ 'templates'] )){
                     	if(in_array ( 'file' , $GLOBALS [ 'dictionary' ] [ $object ] [ 'templates'] )){
                     		$vardef [ 'rname' ] = 'document_name' ;
-                    	}elseif(in_array ( 'person' , $GLOBALS [ 'dictionary' ] [ $object ] [ 'templates'] )){
+                    	} elseif(in_array ( 'person' , $GLOBALS [ 'dictionary' ] [ $object ] [ 'templates'] )){
                     		 $vardef [ 'db_concat_fields' ] = array( 0 =>'first_name', 1 =>'last_name') ;
                     	}
                     }
@@ -513,8 +521,9 @@ 
             // but as we need to display the true cardinality in Studio and ModuleBuilder we also record the actual relationship type
             // this property is only used by Studio/MB
             $properties [ 'true_relationship_type' ] = $relationshipType ;
-            if ($this->from_studio)
-                $properties [ 'from_studio' ] = true;
+            if ($this->from_studio) {
+                            $properties [ 'from_studio' ] = true;
+            }
 
             $rel_properties [ 'join_table' ] = $this->getValidDBName ( $relationshipName."_c" ) ;
             // a and b are in case the module relates to itself
@@ -525,8 +534,9 @@ 
         // set the extended properties if they exist = for now, many-to-many definitions do not have to contain a role_column even if role_column_value is set; we'll just create a likely name if missing
         if (isset ( $this->definition [ 'relationship_role_column_value' ] ))
         {
-            if (! isset ( $this->definition [ 'relationship_role_column' ] ))
-                $this->definition [ 'relationship_role_column' ] = 'relationship_role_column' ;
+            if (! isset ( $this->definition [ 'relationship_role_column' ] )) {
+                            $this->definition [ 'relationship_role_column' ] = 'relationship_role_column' ;
+            }
             $rel_properties [ 'relationship_role_column' ] = $this->definition [ 'relationship_role_column' ] ;
             $rel_properties [ 'relationship_role_column_value' ] = $this->definition [ 'relationship_role_column_value' ] ;
         }
@@ -575,8 +585,10 @@ 
                 $alternateKeys = array ( $rel_properties [ 'join_key_lhs' ] , $rel_properties [ 'join_key_rhs' ] ) ;
         }
         
-        if (count($alternateKeys)>0)
-            $properties [ 'indices' ] [] = array ( 'name' => $indexBase . '_alt' , 'type' => 'alternate_key' , 'fields' => $alternateKeys ) ; // type must be set to alternate_key for Link.php to correctly update an existing record rather than inserting a copy - it uses the fields in this array as the keys to check if a duplicate record already exists
+        if (count($alternateKeys)>0) {
+                    $properties [ 'indices' ] [] = array ( 'name' => $indexBase . '_alt' , 'type' => 'alternate_key' , 'fields' => $alternateKeys ) ;
+        }
+        // type must be set to alternate_key for Link.php to correctly update an existing record rather than inserting a copy - it uses the fields in this array as the keys to check if a duplicate record already exists
         
         return $properties ;
     }
@@ -623,8 +635,9 @@ 
         $canonicalTypes = array ( ) ;
         foreach ( array ( MB_ONETOONE , MB_ONETOMANY , MB_MANYTOMANY , MB_MANYTOONE) as $canonicalType )
         {
-            if ($type == preg_replace ( '/[^\w]+/i', '', strtolower ( $canonicalType ) ))
-                return $canonicalType ;
+            if ($type == preg_replace ( '/[^\w]+/i', '', strtolower ( $canonicalType ) )) {
+                            return $canonicalType ;
+            }
         }
         // ok, we give up...
         return MB_MANYTOMANY ;
@@ -633,16 +646,18 @@ 
     
     function getJoinKeyLHS()
     {
-        if (!isset($this->joinKeyLHS))
-        	$this->joinKeyLHS = $this->getValidDBName ( $this->relationship_name . $this->lhs_module . "_ida"  , true) ;
+        if (!isset($this->joinKeyLHS)) {
+                	$this->joinKeyLHS = $this->getValidDBName ( $this->relationship_name . $this->lhs_module . "_ida"  , true) ;
+        }
         
         return $this->joinKeyLHS;
     }
     
     function getJoinKeyRHS()
     {
-        if (!isset($this->joinKeyRHS))
-        	$this->joinKeyRHS = $this->getValidDBName ( $this->relationship_name . $this->rhs_module . "_idb"  , true) ;
+        if (!isset($this->joinKeyRHS)) {
+                	$this->joinKeyRHS = $this->getValidDBName ( $this->relationship_name . $this->rhs_module . "_idb"  , true) ;
+        }
     	
         return $this->joinKeyRHS;
     }
@@ -679,7 +694,7 @@ 
     		if(isset($layout_defs[$this->rhs_module]['subpanel_setup'][strtolower($this->lhs_module)]['title_key'])){
     			return $layout_defs[$this->rhs_module]['subpanel_setup'][strtolower($this->lhs_module)]['title_key'];
     		}
-    	}else if(!$this->is_custom &&  file_exists("modules/{$this->lhs_module}/metadata/subpaneldefs.php")){
+    	} else if(!$this->is_custom &&  file_exists("modules/{$this->lhs_module}/metadata/subpaneldefs.php")){
     		include("modules/{$this->lhs_module}/metadata/subpaneldefs.php");
     		if(isset($layout_defs[$this->lhs_module]['subpanel_setup'][strtolower($this->rhs_module)]['title_key'])){
     			return $layout_defs[$this->lhs_module]['subpanel_setup'][strtolower($this->rhs_module)]['title_key'];
@@ -689,14 +704,14 @@ 
     	if($left){
     		$titleKeyName = $this->getRightModuleSystemLabel();
     		$sourceModule = $this->rhs_module;
-    	}else{
+    	} else{
     		$titleKeyName = $this->getLeftModuleSystemLabel();
     		$sourceModule = $this->lhs_module;
     	}
     	
 		if(!empty($titleKeyName)){
 			$title_key = 'LBL_' . strtoupper ( $this->relationship_name . '_FROM_' . $titleKeyName ) . '_TITLE' ;
-		}else{
+		} else{
 			$title_key = 'LBL_' . strtoupper ( $this->relationship_name . '_FROM_' . $sourceModule ) . '_TITLE' ;
 		}
 		

modules/ModuleBuilder/parsers/relationships/AbstractRelationships.php

Braces +27 added lines, -18 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -97,8 +98,9 @@ 
         while ( list( $moduleName , $module ) = each($browser->modules) )
         {
             // do not include the submodules of Activities as already have the parent...
-            if (! $includeActivitiesSubmodules && in_array ( $module->module, self::$activities ))
-                continue ;
+            if (! $includeActivitiesSubmodules && in_array ( $module->module, self::$activities )) {
+                            continue ;
+            }
             $providedSubpanels = $module->getProvidedSubpanels();
             if ( $providedSubpanels !== false ) {
                 $relatableModules [ $module->module ] = $providedSubpanels;
@@ -111,8 +113,9 @@ 
 
     static function validSubpanel ($filename)
     {
-        if (! file_exists ( $filename ))
-            return false ;
+        if (! file_exists ( $filename )) {
+                    return false ;
+        }
         
         include $filename ;
         return (isset ( $subpanel_layout ) && (isset ( $subpanel_layout [ 'top_buttons' ] ) && isset ( $subpanel_layout [ 'list_fields' ] ))) ;
@@ -127,8 +130,9 @@ 
         $list = array ( ) ;
         foreach ( $this->relationships as $name => $relationship )
         {
-            if (! $relationship->deleted ())
-                $list [ $name ] = $name ;
+            if (! $relationship->deleted ()) {
+                            $list [ $name ] = $name ;
+            }
         }
         return $list ;
     }
@@ -172,8 +176,9 @@ 
             if ($relationship = $this->get ( $_REQUEST [ 'relationship_name' ] ))
             {
                 unset( $definition[ 'relationship_name' ] ) ; // in case the related modules have changed; this name is probably no longer appropriate
-                if (! $relationship->readonly ())
-                    $this->delete ( $_REQUEST [ 'relationship_name' ] ) ;
+                if (! $relationship->readonly ()) {
+                                    $this->delete ( $_REQUEST [ 'relationship_name' ] ) ;
+                }
         }
         }
         
@@ -298,8 +303,7 @@ 
         {
             $name = $basename . '_1' ;
             $suffix = 2 ;
-        }
-        else
+        } else
         {
             $name = $basename ;
             $suffix = 1 ;
@@ -351,9 +355,11 @@ 
                     {
                         $metadata = $relationship->$buildMethod () ;
                         
-                        if (count ( $metadata ) > 0) // don't clutter up the filesystem with empty files...
+                        if (count ( $metadata ) > 0) {
+                            // don't clutter up the filesystem with empty files...
                         {
                             $GLOBALS [ 'log' ]->debug ( get_class ( $this ) . ": BUILD is running METHOD $saveMethod" ) ;
+                        }
                             $installDef = $this->$saveMethod ( $basepath, $installDefPrefix, $name, $metadata ) ;
                             
                             // some save methods (e.g., saveRelateFieldDefinition) handle the installDefs internally and so return null
@@ -406,8 +412,9 @@ 
         	
         	$filename = "{$basepath}/language/{$definition['module']}.php" ;
     	
-	    	if (file_exists ( $filename ))
-	    		include ($filename);
+	    	if (file_exists ( $filename )) {
+	    		    		include ($filename);
+	    	}
 	    		
             
             //Check for app strings
@@ -415,12 +422,14 @@ 
                                       . print_r ( $definition, true ) ) ;
             if ($definition['module'] == 'application') {
             	$app_list_strings[$definition [ 'system_label' ]] = $definition [ 'display_label' ];
-            	foreach ($app_list_strings as $key => $val)
-            		$out .= override_value_to_string_recursive2('app_list_strings', $key, $val);
+            	foreach ($app_list_strings as $key => $val) {
+            	            		$out .= override_value_to_string_recursive2('app_list_strings', $key, $val);
+            	}
             } else {
             	$mod_strings[ $definition [ 'system_label' ]] = $definition [ 'display_label' ];
-            	foreach ($mod_strings as $key => $val)
-            		$out .= override_value_to_string_recursive2('mod_strings', $key, $val);
+            	foreach ($mod_strings as $key => $val) {
+            	            		$out .= override_value_to_string_recursive2('mod_strings', $key, $val);
+            	}
             }
             
             $fh = fopen ( $filename, 'w' ) ;

modules/ModuleBuilder/parsers/relationships/UndeployedRelationships.php

Braces +10 added lines, -9 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -270,8 +271,7 @@ 
             $module->setAppListStrings ( 'en_us', $appStrings ) ;
             $module->save () ;
 
-        }
-        else
+        } else
         {
             //Bug42170================================
             $appStrings = $module->getAppListStrings () ;
@@ -333,8 +333,9 @@ 
             $appStrings = $module->getAppListStrings () ;
             foreach(getTypeDisplayList() as $key)
             {
-                if (isset($appStrings[$key][ $module->key_name ]))
-                    unset($appStrings[$key][ $module->key_name ]);
+                if (isset($appStrings[$key][ $module->key_name ])) {
+                                    unset($appStrings[$key][ $module->key_name ]);
+                }
             }
             $module->setAppListStrings ( 'en_us', $appStrings ) ;
             $module->save () ;
@@ -351,8 +352,9 @@ 
     {
         
         // many-to-many relationships don't have fields so if we have a many-to-many we can just skip this...
-        if ($relationship->getType () == MB_MANYTOMANY)
-            return false ;
+        if ($relationship->getType () == MB_MANYTOMANY) {
+                    return false ;
+        }
         
         $successful = true ;
         $layoutAdditions = $relationship->buildFieldsToLayouts () ;
@@ -371,8 +373,7 @@ 
                     if (($actionAdd) ? $parser->addField ( array ( 'name' => $fieldName ) ) : $parser->removeField ( $fieldName ))
                     {
                         $parser->handleSave ( false ) ;
-                    } 
-                    else
+                    } else
                     {
                         $GLOBALS [ 'log' ]->debug ( get_class ( $this ) . ": couldn't " . (($actionAdd) ? "add" : "remove") . " $fieldName on $view layout for undeployed module $deployedModuleName" ) ;
                         $successful = false ;

modules/ModuleBuilder/parsers/relationships/DeployedRelationships.php

Braces +11 added lines, -7 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -243,8 +244,9 @@ 
         
         foreach ( $module->field_defs as $field )
         {
-            if ($field [ 'type' ] == 'relate' && isset ( $field [ 'module' ] ) && $field [ 'module' ] == $sourceModuleName)
-                return $field [ 'name' ] ;
+            if ($field [ 'type' ] == 'relate' && isset ( $field [ 'module' ] ) && $field [ 'module' ] == $sourceModuleName) {
+                            return $field [ 'name' ] ;
+            }
         }
         return null ;
     }
@@ -389,10 +391,11 @@ 
         
         foreach ( $layoutAdditions as $deployedModuleName => $fieldName )
         {
-            if (! in_array ( strtolower ( $deployedModuleName ), $invalidModules ))
-                foreach ( array ( MB_EDITVIEW , MB_DETAILVIEW ) as $view )
+            if (! in_array ( strtolower ( $deployedModuleName ), $invalidModules )) {
+                            foreach ( array ( MB_EDITVIEW , MB_DETAILVIEW ) as $view )
                 {
                     $GLOBALS [ 'log' ]->info ( get_class ( $this ) . ": adding $fieldName to $view layout for module $deployedModuleName" ) ;
+            }
                     $parser = new GridLayoutMetaDataParser ( $view, $deployedModuleName ) ;
                     $parser->addField ( array ( 'name' => $fieldName ) ) ;
                     $parser->handleSave ( false ) ;
@@ -411,8 +414,9 @@ 
     {
         
         // many-to-many relationships don't have fields so if we have a many-to-many we can just skip this...
-        if ($relationship->getType () == MB_MANYTOMANY)
-            return false ;
+        if ($relationship->getType () == MB_MANYTOMANY) {
+                    return false ;
+        }
         
         $successful = true ;
         $layoutAdditions = $relationship->buildFieldsToLayouts () ;

modules/ModuleBuilder/parsers/relationships/RelationshipFactory.php

Braces +6 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -51,8 +53,9 @@ 
     static function newRelationship ($definition = array())
     {
         // handle the case where a relationship_type is not provided - set it to Many-To-Many as this was the usual type in ModuleBuilder
-        if (! isset ( $definition [ 'relationship_type' ] ))
-            $definition [ 'relationship_type' ] = MB_MANYTOMANY ;
+        if (! isset ( $definition [ 'relationship_type' ] )) {
+                    $definition [ 'relationship_type' ] = MB_MANYTOMANY ;
+        }
             
     	if (!empty ($definition['for_activities']) && $definition['for_activities'] == true) {
         	require_once 'modules/ModuleBuilder/parsers/relationships/ActivitiesRelationship.php';

modules/ModuleBuilder/parsers/relationships/OneToManyRelationship.php

Braces +9 added lines, -5 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -93,8 +95,9 @@ 
      */
     function buildSubpanelDefinitions ()
     {        
-        if ($this->relationship_only)
-            return array () ;
+        if ($this->relationship_only) {
+                    return array () ;
+        }
         
         $source = "";
         if ($this->rhs_module == $this->lhs_module)
@@ -142,8 +145,9 @@ 
      */
     function buildFieldsToLayouts ()
     {
-        if ($this->relationship_only)
-            return array () ;
+        if ($this->relationship_only) {
+                    return array () ;
+        }
  
         return array( $this->rhs_module =>$this->getValidDBName($this->relationship_name . "_name")); // this must match the name of the relate field from buildVardefs
     }

modules/ModuleBuilder/parsers/relationships/ManyToOneRelationship.php

Braces +6 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -113,8 +115,9 @@ 
      */
     function buildFieldsToLayouts ()
     {
-        if ($this->relationship_only)
-            return array () ;
+        if ($this->relationship_only) {
+                    return array () ;
+        }
  
         return array( $this->lhs_module => $this->getValidDBName($this->relationship_name . "_name") ) ; // this must match the name of the relate field from buildVardefs
     }

modules/ModuleBuilder/parsers/relationships/ActivitiesRelationship.php

Braces +9 added lines, -5 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -173,16 +175,18 @@ 
      */
     function buildFieldsToLayouts ()
     {
-        if ($this->relationship_only)
-            return array () ;
+        if ($this->relationship_only) {
+                    return array () ;
+        }
 
         return array( $this->rhs_module => $this->relationship_name . "_name" ) ; // this must match the name of the relate field from buildVardefs
     }
 
  	function buildSubpanelDefinitions ()
     {
-        if ($this->relationship_only || isset(ActivitiesRelationship::$subpanelsAdded[$this->lhs_module]))
-            return array () ;
+        if ($this->relationship_only || isset(ActivitiesRelationship::$subpanelsAdded[$this->lhs_module])) {
+                    return array () ;
+        }
 
         ActivitiesRelationship::$subpanelsAdded[$this->lhs_module] = true;
         $relationshipName = substr($this->relationship_name, 0, strrpos($this->relationship_name, '_'));