Passed
Push — scrutinizer-code-quality ( eedb15...27193c )
by Adam
54:15 queued 15s
created
include/nusoap/class.soap_server.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -892,7 +892,7 @@  discard block
 block discarded – undo
892 892
 	*
893 893
 	* @param	array	$headers	The HTTP headers
894 894
 	* @param	string	$data		unprocessed request data from client
895
-	* @return	mixed	value of the message, decoded into a PHP type
895
+	* @return	false|null	value of the message, decoded into a PHP type
896 896
 	* @access   private
897 897
 	*/
898 898
     function parseRequest($headers, $data) {
@@ -999,7 +999,7 @@  discard block
 block discarded – undo
999 999
 	* @param    string $name the name of the PHP function, class.method or class..method
1000 1000
 	* @param    array $in assoc array of input values: key = param name, value = param type
1001 1001
 	* @param    array $out assoc array of output values: key = param name, value = param type
1002
-	* @param	mixed $namespace the element namespace for the method or false
1002
+	* @param	string $namespace the element namespace for the method or false
1003 1003
 	* @param	mixed $soapaction the soapaction for the method or false
1004 1004
 	* @param	mixed $style optional (rpc|document) or false Note: when 'document' is specified, parameter and return wrappers are created for you automatically
1005 1005
 	* @param	mixed $use optional (encoded|literal) or false
@@ -1089,11 +1089,12 @@  discard block
 block discarded – undo
1089 1089
     * Acts as a flag to enable internal WSDL generation
1090 1090
     *
1091 1091
     * @param string $serviceName, name of the service
1092
-    * @param mixed $namespace optional 'tns' service namespace or false
1093
-    * @param mixed $endpoint optional URL of service endpoint or false
1092
+    * @param string $namespace optional 'tns' service namespace or false
1093
+    * @param string $endpoint optional URL of service endpoint or false
1094 1094
     * @param string $style optional (rpc|document) WSDL style (also specified by operation)
1095 1095
     * @param string $transport optional SOAP transport
1096 1096
     * @param mixed $schemaTargetNamespace optional 'types' targetNamespace for service schema or false
1097
+    * @param string $serviceName
1097 1098
     */
1098 1099
     function configureWSDL($serviceName,$namespace = false,$endpoint = false,$style='rpc', $transport = 'http://schemas.xmlsoap.org/soap/http', $schemaTargetNamespace = false)
1099 1100
     {
Please login to merge, or discard this patch.
include/nusoap/class.soap_transport_http.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -221,10 +221,6 @@  discard block
 block discarded – undo
221 221
 	/**
222 222
 	* establish an HTTP connection
223 223
 	*
224
-	* @param    integer $timeout set connection timeout in seconds
225
-	* @param	integer $response_timeout set response timeout in seconds
226
-	* @return	boolean true if connected, false if not
227
-	* @access   private
228 224
 	*/
229 225
 	function connect($connection_timeout=0,$response_timeout=30){
230 226
 	  	// For PHP 4.3 with OpenSSL, change https scheme to ssl, then treat like
@@ -783,7 +779,7 @@  discard block
 block discarded – undo
783 779
 	*
784 780
 	* @param    string $data message data
785 781
 	* @param	array $cookies cookies to send
786
-	* @return	boolean	true if OK, false if problem
782
+	* @return	boolean|null	true if OK, false if problem
787 783
 	* @access   private
788 784
 	*/
789 785
 	function sendRequest($data, $cookies = NULL) {
@@ -1218,7 +1214,7 @@  discard block
 block discarded – undo
1218 1214
 	 * sets the content-type for the SOAP message to be sent
1219 1215
 	 *
1220 1216
 	 * @param	string $type the content type, MIME style
1221
-	 * @param	mixed $charset character set used for encoding (or false)
1217
+	 * @param	string $charset character set used for encoding (or false)
1222 1218
 	 * @access	public
1223 1219
 	 */
1224 1220
 	function setContentType($type, $charset = false) {
@@ -1251,6 +1247,10 @@  discard block
 block discarded – undo
1251 1247
 	/*
1252 1248
 	 * TODO: allow a Set-Cookie string to be parsed into multiple cookies
1253 1249
 	 */
1250
+
1251
+	/**
1252
+	 * @param string $cookie_str
1253
+	 */
1254 1254
 	function parseCookie($cookie_str) {
1255 1255
 		$cookie_str = str_replace('; ', ';', $cookie_str) . ';';
1256 1256
 		$data = preg_split('/;/', $cookie_str);
Please login to merge, or discard this patch.
include/nusoap/class.soap_val.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
 	*
105 105
 	* @param    string $name optional name
106 106
 	* @param    mixed $type optional type name
107
-	* @param	mixed $value optional value
107
+	* @param	integer $value optional value
108 108
 	* @param	mixed $element_ns optional namespace of value
109 109
 	* @param	mixed $type_ns optional namespace of type
110 110
 	* @param	mixed $attributes associative array of attributes to add to element serialization
Please login to merge, or discard this patch.
include/nusoap/class.soapclient.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -892,6 +892,7 @@
 block discarded – undo
892 892
 	/**
893 893
 	* dynamically creates proxy class code
894 894
 	*
895
+	* @param integer $r
895 896
 	* @return   string PHP/NuSOAP code for the proxy class
896 897
 	* @access   private
897 898
 	*/
Please login to merge, or discard this patch.
include/nusoap/class.wsdl.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -928,7 +928,7 @@  discard block
 block discarded – undo
928 928
 	/**
929 929
 	* serialize the parsed wsdl
930 930
 	*
931
-	* @param mixed $debug whether to put debug=1 in endpoint URL
931
+	* @param integer $debug whether to put debug=1 in endpoint URL
932 932
 	* @return string serialization of WSDL
933 933
 	* @access public
934 934
 	*/
@@ -1151,7 +1151,7 @@  discard block
 block discarded – undo
1151 1151
 	 * @param string $direction (input|output)
1152 1152
 	 * @param mixed $parameters parameter value(s)
1153 1153
 	 * @param string $bindingType (soap|soap12)
1154
-	 * @return mixed parameters serialized as XML or false on error (e.g. operation not found)
1154
+	 * @return false|string parameters serialized as XML or false on error (e.g. operation not found)
1155 1155
 	 * @access public
1156 1156
 	 */
1157 1157
 	function serializeRPCParameters($operation, $direction, $parameters, $bindingType = 'soap') {
@@ -1251,7 +1251,7 @@  discard block
 block discarded – undo
1251 1251
 	 * @param string $operation operation name
1252 1252
 	 * @param string $direction (input|output)
1253 1253
 	 * @param mixed $parameters parameter value(s)
1254
-	 * @return mixed parameters serialized as XML or false on error (e.g. operation not found)
1254
+	 * @return false|string parameters serialized as XML or false on error (e.g. operation not found)
1255 1255
 	 * @access public
1256 1256
 	 * @deprecated
1257 1257
 	 */
Please login to merge, or discard this patch.
include/nusoap/class.xmlschema.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -837,7 +837,7 @@
 block discarded – undo
837 837
     * returns a sample serialization of a given type, or false if no type by the given name
838 838
     *
839 839
     * @param string $type name of type
840
-    * @return mixed
840
+    * @return string|false
841 841
     * @access public
842 842
     * @deprecated
843 843
     */
Please login to merge, or discard this patch.
include/nusoap/nusoap.php 1 patch
Doc Comments   +25 added lines, -23 removed lines patch added patch discarded remove patch
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 	/**
553 553
 	* gets the current debug data for this instance
554 554
 	*
555
-	* @return   debug data
555
+	* @return   string data
556 556
 	* @access   public
557 557
 	*/
558 558
 	function &getDebug() {
@@ -565,7 +565,7 @@  discard block
 block discarded – undo
565 565
 	* gets the current debug data for this instance as an XML comment
566 566
 	* this may change the contents of the debug data
567 567
 	*
568
-	* @return   debug data as an XML comment
568
+	* @return   string data as an XML comment
569 569
 	* @access   public
570 570
 	*/
571 571
 	function &getDebugAsXMLComment() {
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
 	/**
597 597
 	* returns error string if present
598 598
 	*
599
-	* @return   mixed error string or false
599
+	* @return   string|false error string or false
600 600
 	* @access   public
601 601
 	*/
602 602
 	function getError(){
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
 	/**
610 610
 	* sets error string
611 611
 	*
612
-	* @return   boolean $string error string
612
+	* @return   boolean|null $string error string
613 613
 	* @access   private
614 614
 	*/
615 615
 	function setError($str){
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
     * returns false, if not prefixed
1046 1046
     *
1047 1047
     * @param string $str The prefixed string
1048
-    * @return mixed The prefix or false if there is no prefix
1048
+    * @return string|false The prefix or false if there is no prefix
1049 1049
     * @access public
1050 1050
     */
1051 1051
 	function getPrefix($str){
@@ -1076,7 +1076,7 @@  discard block
 block discarded – undo
1076 1076
     * or false if no prefixes registered for the given namespace
1077 1077
     *
1078 1078
     * @param string $ns The namespace
1079
-    * @return mixed The prefix, false if the namespace has no prefixes
1079
+    * @return string The prefix, false if the namespace has no prefixes
1080 1080
     * @access public
1081 1081
     */
1082 1082
 	function getPrefixFromNamespace($ns) {
@@ -1145,7 +1145,7 @@  discard block
 block discarded – undo
1145 1145
 *
1146 1146
 * @param    int $timestamp Unix time stamp
1147 1147
 * @param	boolean $utc Whether the time stamp is UTC or local
1148
-* @return	mixed ISO 8601 date string or false
1148
+* @return	string|false ISO 8601 date string or false
1149 1149
 * @access   public
1150 1150
 */
1151 1151
 function timestamp_to_iso8601($timestamp,$utc=true){
@@ -1484,7 +1484,7 @@  discard block
 block discarded – undo
1484 1484
     * @param string $faultcode (SOAP-ENV:Client | SOAP-ENV:Server)
1485 1485
     * @param string $faultactor only used when msg routed between multiple actors
1486 1486
     * @param string $faultstring human readable error message
1487
-    * @param mixed $faultdetail detail, typically a string or array of string
1487
+    * @param string $faultdetail detail, typically a string or array of string
1488 1488
 	*/
1489 1489
 	function nusoap_fault($faultcode,$faultactor='',$faultstring='',$faultdetail=''){
1490 1490
 		parent::nusoap_base();
@@ -2527,7 +2527,7 @@  discard block
 block discarded – undo
2527 2527
     * returns a sample serialization of a given type, or false if no type by the given name
2528 2528
     *
2529 2529
     * @param string $type name of type
2530
-    * @return mixed
2530
+    * @return string|false
2531 2531
     * @access public
2532 2532
     * @deprecated
2533 2533
     */
@@ -2970,7 +2970,7 @@  discard block
 block discarded – undo
2970 2970
 	*
2971 2971
 	* @param    string $name optional name
2972 2972
 	* @param    mixed $type optional type name
2973
-	* @param	mixed $value optional value
2973
+	* @param	integer $value optional value
2974 2974
 	* @param	mixed $element_ns optional namespace of value
2975 2975
 	* @param	mixed $type_ns optional namespace of type
2976 2976
 	* @param	mixed $attributes associative array of attributes to add to element serialization
@@ -3381,10 +3381,6 @@  discard block
 block discarded – undo
3381 3381
 	/**
3382 3382
 	* establish an HTTP connection
3383 3383
 	*
3384
-	* @param    integer $timeout set connection timeout in seconds
3385
-	* @param	integer $response_timeout set response timeout in seconds
3386
-	* @return	boolean true if connected, false if not
3387
-	* @access   private
3388 3384
 	*/
3389 3385
 	function connect($connection_timeout=0,$response_timeout=30){
3390 3386
 	  	// For PHP 4.3 with OpenSSL, change https scheme to ssl, then treat like
@@ -3943,7 +3939,7 @@  discard block
 block discarded – undo
3943 3939
 	*
3944 3940
 	* @param    string $data message data
3945 3941
 	* @param	array $cookies cookies to send
3946
-	* @return	boolean	true if OK, false if problem
3942
+	* @return	boolean|null	true if OK, false if problem
3947 3943
 	* @access   private
3948 3944
 	*/
3949 3945
 	function sendRequest($data, $cookies = NULL) {
@@ -4378,7 +4374,7 @@  discard block
 block discarded – undo
4378 4374
 	 * sets the content-type for the SOAP message to be sent
4379 4375
 	 *
4380 4376
 	 * @param	string $type the content type, MIME style
4381
-	 * @param	mixed $charset character set used for encoding (or false)
4377
+	 * @param	string $charset character set used for encoding (or false)
4382 4378
 	 * @access	public
4383 4379
 	 */
4384 4380
 	function setContentType($type, $charset = false) {
@@ -4411,6 +4407,10 @@  discard block
 block discarded – undo
4411 4407
 	/*
4412 4408
 	 * TODO: allow a Set-Cookie string to be parsed into multiple cookies
4413 4409
 	 */
4410
+
4411
+	/**
4412
+	 * @param string $cookie_str
4413
+	 */
4414 4414
 	function parseCookie($cookie_str) {
4415 4415
 		$cookie_str = str_replace('; ', ';', $cookie_str) . ';';
4416 4416
 		$data = preg_split('/;/', $cookie_str);
@@ -5571,7 +5571,7 @@  discard block
 block discarded – undo
5571 5571
 	*
5572 5572
 	* @param	array	$headers	The HTTP headers
5573 5573
 	* @param	string	$data		unprocessed request data from client
5574
-	* @return	mixed	value of the message, decoded into a PHP type
5574
+	* @return	false|null	value of the message, decoded into a PHP type
5575 5575
 	* @access   private
5576 5576
 	*/
5577 5577
     function parseRequest($headers, $data) {
@@ -5678,7 +5678,7 @@  discard block
 block discarded – undo
5678 5678
 	* @param    string $name the name of the PHP function, class.method or class..method
5679 5679
 	* @param    array $in assoc array of input values: key = param name, value = param type
5680 5680
 	* @param    array $out assoc array of output values: key = param name, value = param type
5681
-	* @param	mixed $namespace the element namespace for the method or false
5681
+	* @param	string $namespace the element namespace for the method or false
5682 5682
 	* @param	mixed $soapaction the soapaction for the method or false
5683 5683
 	* @param	mixed $style optional (rpc|document) or false Note: when 'document' is specified, parameter and return wrappers are created for you automatically
5684 5684
 	* @param	mixed $use optional (encoded|literal) or false
@@ -5768,11 +5768,12 @@  discard block
 block discarded – undo
5768 5768
     * Acts as a flag to enable internal WSDL generation
5769 5769
     *
5770 5770
     * @param string $serviceName, name of the service
5771
-    * @param mixed $namespace optional 'tns' service namespace or false
5772
-    * @param mixed $endpoint optional URL of service endpoint or false
5771
+    * @param string $namespace optional 'tns' service namespace or false
5772
+    * @param string $endpoint optional URL of service endpoint or false
5773 5773
     * @param string $style optional (rpc|document) WSDL style (also specified by operation)
5774 5774
     * @param string $transport optional SOAP transport
5775 5775
     * @param mixed $schemaTargetNamespace optional 'types' targetNamespace for service schema or false
5776
+    * @param string $serviceName
5776 5777
     */
5777 5778
     function configureWSDL($serviceName,$namespace = false,$endpoint = false,$style='rpc', $transport = 'http://schemas.xmlsoap.org/soap/http', $schemaTargetNamespace = false)
5778 5779
     {
@@ -6937,7 +6938,7 @@  discard block
 block discarded – undo
6937 6938
 	/**
6938 6939
 	* serialize the parsed wsdl
6939 6940
 	*
6940
-	* @param mixed $debug whether to put debug=1 in endpoint URL
6941
+	* @param integer $debug whether to put debug=1 in endpoint URL
6941 6942
 	* @return string serialization of WSDL
6942 6943
 	* @access public
6943 6944
 	*/
@@ -7160,7 +7161,7 @@  discard block
 block discarded – undo
7160 7161
 	 * @param string $direction (input|output)
7161 7162
 	 * @param mixed $parameters parameter value(s)
7162 7163
 	 * @param string $bindingType (soap|soap12)
7163
-	 * @return mixed parameters serialized as XML or false on error (e.g. operation not found)
7164
+	 * @return false|string parameters serialized as XML or false on error (e.g. operation not found)
7164 7165
 	 * @access public
7165 7166
 	 */
7166 7167
 	function serializeRPCParameters($operation, $direction, $parameters, $bindingType = 'soap') {
@@ -7260,7 +7261,7 @@  discard block
 block discarded – undo
7260 7261
 	 * @param string $operation operation name
7261 7262
 	 * @param string $direction (input|output)
7262 7263
 	 * @param mixed $parameters parameter value(s)
7263
-	 * @return mixed parameters serialized as XML or false on error (e.g. operation not found)
7264
+	 * @return false|string parameters serialized as XML or false on error (e.g. operation not found)
7264 7265
 	 * @access public
7265 7266
 	 * @deprecated
7266 7267
 	 */
@@ -9804,6 +9805,7 @@  discard block
 block discarded – undo
9804 9805
 	/**
9805 9806
 	* dynamically creates proxy class code
9806 9807
 	*
9808
+	* @param integer $r
9807 9809
 	* @return   string PHP/NuSOAP code for the proxy class
9808 9810
 	* @access   private
9809 9811
 	*/
Please login to merge, or discard this patch.
include/nusoap/nusoapmime.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -564,7 +564,7 @@
 block discarded – undo
564 564
 	*
565 565
 	* @param	array	$headers	The HTTP headers
566 566
 	* @param	string	$data		unprocessed request data from client
567
-	* @return	mixed	value of the message, decoded into a PHP type
567
+	* @return	false|null	value of the message, decoded into a PHP type
568 568
 	* @access   private
569 569
 	*/
570 570
     function parseRequest($headers, $data) {
Please login to merge, or discard this patch.
include/OutboundEmail/OutboundEmail.php 1 patch
Doc Comments   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * override account.
135 135
 	 *
136 136
 	 * @param unknown_type $user_id
137
-	 * @return unknown
137
+	 * @return boolean
138 138
 	 */
139 139
 	function doesUserOverrideAccountRequireCredentials($user_id)
140 140
 	{
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
 	 * Retrieves a cascading mailer set
230 230
 	 * @param object user
231 231
 	 * @param string mailer_id
232
-	 * @return object
232
+	 * @return OutboundEmail
233 233
 	 */
234 234
 	function getUserMailerSettings(&$user, $mailer_id='', $ieId='') {
235 235
 		$mailer = '';
@@ -267,7 +267,6 @@  discard block
 block discarded – undo
267 267
 	 * their outbound account set to this object.
268 268
 	 *
269 269
 	 * @param SugarBean $user
270
-	 * @param string $outbound_id
271 270
 	 * @return array
272 271
 	 */
273 272
 	function getAssociatedInboundAccounts($user)
@@ -291,7 +290,7 @@  discard block
 block discarded – undo
291 290
 	 * Retrieves a cascading mailer set
292 291
 	 * @param object user
293 292
 	 * @param string mailer_id
294
-	 * @return object
293
+	 * @return OutboundEmail
295 294
 	 */
296 295
 	function getInboundMailerSettings($user, $mailer_id='', $ieId='') {
297 296
 		$mailer = '';
@@ -390,7 +389,7 @@  discard block
 block discarded – undo
390 389
 	/**
391 390
 	 * Populates this instance
392 391
 	 * @param string $id
393
-	 * @return object $this
392
+	 * @return OutboundEmail $this
394 393
 	 */
395 394
 	function retrieve($id) {
396 395
 		require_once('include/utils/encryption_utils.php');
@@ -428,7 +427,7 @@  discard block
 block discarded – undo
428 427
 	/**
429 428
 	 * Generate values for saving into outbound_emails table
430 429
 	 * @param array $keys
431
-	 * @return array
430
+	 * @return string
432 431
 	 */
433 432
 	protected function getValues(&$keys)
434 433
 	{
Please login to merge, or discard this patch.