Passed
Push — scrutinizer-code-quality ( eedb15...27193c )
by Adam
54:15 queued 15s
created
include/generic/SugarWidgets/SugarWidgetSubPanelTopButtonQuickCreate.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,11 +53,11 @@  discard block
 block discarded – undo
53 53
 		global $currentModule;
54 54
 
55 55
 		// Create the additional form fields with real values if they were not passed in
56
-		if(empty($additionalFormFields) && $this->additional_form_fields)
56
+		if (empty($additionalFormFields) && $this->additional_form_fields)
57 57
 		{
58
-			foreach($this->additional_form_fields as $key=>$value)
58
+			foreach ($this->additional_form_fields as $key=>$value)
59 59
 			{
60
-				if(!empty($defines['focus']->$value))
60
+				if (!empty($defines['focus']->$value))
61 61
 				{
62 62
 					$additionalFormFields[$key] = $defines['focus']->$value;
63 63
 				}
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 			}
69 69
 		}
70 70
 
71
-		if(!empty($this->module))
71
+		if (!empty($this->module))
72 72
 		{
73 73
 			$defines['child_module_name'] = $this->module;
74 74
 		}
@@ -77,26 +77,26 @@  discard block
 block discarded – undo
77 77
 			$defines['child_module_name'] = $defines['module'];
78 78
 		}
79 79
 
80
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
80
+		$defines['parent_bean_name'] = get_class($defines['focus']);
81 81
 
82 82
 		$relationship_name = $this->get_subpanel_relationship_name($defines);
83 83
 
84
-		$form = 'form' . $relationship_name;
85
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . $defines['subpanel_definition']->name . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
84
+		$form = 'form'.$relationship_name;
85
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.$defines['subpanel_definition']->name.'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
86 86
 
87 87
 		//module_button is used to override the value of module name
88 88
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
89 89
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
90 90
 
91
-		if(isset($defines['focus']->name))
91
+		if (isset($defines['focus']->name))
92 92
 		{
93 93
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
94 94
 			#26451,add these fields for custom one-to-many relate field.
95
-            if(!empty($defines['child_module_name'])){
96
-            	$button .= "<input type='hidden' name='". $relationship_name ."_name' value='".$defines['focus']->name."'>";
95
+            if (!empty($defines['child_module_name'])) {
96
+            	$button .= "<input type='hidden' name='".$relationship_name."_name' value='".$defines['focus']->name."'>";
97 97
             	$childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
98
-            	if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
99
-            		$button .= "<input type='hidden' name='". $GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'] ."' value='".$defines['focus']->id."'>";
98
+            	if (!empty($GLOBALS['dictionary'][$childFocusName]["fields"][$relationship_name.'_name']['id_name'])) {
99
+            		$button .= "<input type='hidden' name='".$GLOBALS['dictionary'][$childFocusName]["fields"][$relationship_name.'_name']['id_name']."' value='".$defines['focus']->id."'>";
100 100
             	}
101 101
             }
102 102
             
@@ -104,29 +104,29 @@  discard block
 block discarded – undo
104 104
             $additionalFormFields['return_name'] = $defines['focus']->name;
105 105
 		}
106 106
 		
107
-		if(!empty($defines['view']))
108
-		$button .= '<input type="hidden" name="target_view" value="'. $defines['view'] . '" />';
107
+		if (!empty($defines['view']))
108
+		$button .= '<input type="hidden" name="target_view" value="'.$defines['view'].'" />';
109 109
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
110 110
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
111
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
112
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
113
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
114
-		$button .= '<input type="hidden" name="return_relationship" value="' . $relationship_name . "\" />\n";
111
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
112
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
113
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
114
+		$button .= '<input type="hidden" name="return_relationship" value="'.$relationship_name."\" />\n";
115 115
 		$button .= '<input type="hidden" name="record" value="" />';
116 116
 
117 117
 		// TODO: move this out and get $additionalFormFields working properly
118
-		if(empty($additionalFormFields['parent_type']))
118
+		if (empty($additionalFormFields['parent_type']))
119 119
 		{
120
-			if($defines['focus']->object_name=='Contact') {
120
+			if ($defines['focus']->object_name == 'Contact') {
121 121
 				$additionalFormFields['parent_type'] = 'Accounts';
122 122
 			}
123 123
 			else {
124 124
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
125 125
 			}
126 126
 		}
127
-		if(empty($additionalFormFields['parent_name']))
127
+		if (empty($additionalFormFields['parent_name']))
128 128
 		{
129
-			if($defines['focus']->object_name=='Contact') {
129
+			if ($defines['focus']->object_name == 'Contact') {
130 130
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
131 131
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
132 132
 			}
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
135 135
 			}
136 136
 		}
137
-		if(empty($additionalFormFields['parent_id']))
137
+		if (empty($additionalFormFields['parent_id']))
138 138
 		{
139
-			if($defines['focus']->object_name=='Contact') {
139
+			if ($defines['focus']->object_name == 'Contact') {
140 140
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
141 141
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
142 142
 			}
@@ -145,32 +145,32 @@  discard block
 block discarded – undo
145 145
 			}
146 146
 		}
147 147
 
148
-        if(strtolower($defines['child_module_name']) =='contracts') {
148
+        if (strtolower($defines['child_module_name']) == 'contracts') {
149 149
             //set variables to account name, or parent account name
150
-            if(strtolower($defines['parent_bean_name']) == 'account' ){
150
+            if (strtolower($defines['parent_bean_name']) == 'account') {
151 151
                 //if account is parent bean, then get focus id/focus name
152
-                if(isset($defines['focus']->id))$additionalFormFields['account_id'] = $defines['focus']->id;
153
-                if(isset($defines['focus']->name))$additionalFormFields['account_name'] = $defines['focus']->name;
154
-            }elseif(strtolower($defines['parent_bean_name']) == 'quote' ){
152
+                if (isset($defines['focus']->id))$additionalFormFields['account_id'] = $defines['focus']->id;
153
+                if (isset($defines['focus']->name))$additionalFormFields['account_name'] = $defines['focus']->name;
154
+            }elseif (strtolower($defines['parent_bean_name']) == 'quote') {
155 155
                 //if quote is parent bean, then get billing_account_id/billing_account_name
156
-                if(isset($defines['focus']->billing_account_id))$additionalFormFields['account_id'] = $defines['focus']->billing_account_id;
157
-                if(isset($defines['focus']->billing_account_name))$additionalFormFields['account_name'] = $defines['focus']->billing_account_name;
158
-            }else{
159
-                if(isset($defines['focus']->account_id))$additionalFormFields['account_id'] = $defines['focus']->account_id;
160
-                if(isset($defines['focus']->account_name))$additionalFormFields['account_name'] = $defines['focus']->account_name;
156
+                if (isset($defines['focus']->billing_account_id))$additionalFormFields['account_id'] = $defines['focus']->billing_account_id;
157
+                if (isset($defines['focus']->billing_account_name))$additionalFormFields['account_name'] = $defines['focus']->billing_account_name;
158
+            } else {
159
+                if (isset($defines['focus']->account_id))$additionalFormFields['account_id'] = $defines['focus']->account_id;
160
+                if (isset($defines['focus']->account_name))$additionalFormFields['account_name'] = $defines['focus']->account_name;
161 161
             }
162 162
         }
163 163
 
164
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
165
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
166
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
164
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
165
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
166
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
167 167
 
168 168
 		// fill in additional form fields for all but action
169
-		foreach($additionalFormFields as $key => $value)
169
+		foreach ($additionalFormFields as $key => $value)
170 170
 		{
171
-			if($key != 'action')
171
+			if ($key != 'action')
172 172
 			{
173
-				$button .= '<input type="hidden" name="' . $key . '" value=\'' . $value . '\' />' . "\n";
173
+				$button .= '<input type="hidden" name="'.$key.'" value=\''.$value.'\' />'."\n";
174 174
 			}
175 175
 		}
176 176
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 	 */
185 185
 	function get_subpanel_relationship_name($defines) {
186 186
 		 $relationship_name = '';
187
-		 if(!empty($defines)) {
187
+		 if (!empty($defines)) {
188 188
 		 	$relationship_name = isset($defines['module']) ? $defines['module'] : '';
189 189
 	     	$dataSource = $defines['subpanel_definition']->get_data_source_name(true);
190 190
          	if (!empty($dataSource)) {
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetFieldint.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
  function queryFilterBetween(&$layout_def)
72 72
  {
73
- 	             return $this->_get_column_select($layout_def)." BETWEEN '".$GLOBALS['db']->quote($layout_def['input_name0']). "' AND '" . $GLOBALS['db']->quote($layout_def['input_name1']) . "'\n";
73
+ 	             return $this->_get_column_select($layout_def)." BETWEEN '".$GLOBALS['db']->quote($layout_def['input_name0'])."' AND '".$GLOBALS['db']->quote($layout_def['input_name1'])."'\n";
74 74
  }
75 75
 
76 76
  function queryFilterStarts_With(&$layout_def)
@@ -80,17 +80,17 @@  discard block
 block discarded – undo
80 80
 
81 81
  function displayInput(&$layout_def)
82 82
  {
83
- 	 return '<input type="text" size="20" value="' . $layout_def['input_name0'] . '" name="' . $layout_def['name'] . '">';
83
+ 	 return '<input type="text" size="20" value="'.$layout_def['input_name0'].'" name="'.$layout_def['name'].'">';
84 84
 
85 85
  }
86 86
  
87 87
  function display($layout_def)
88 88
  {
89 89
 	   //Bug40995
90
-	   if(isset($obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision']))
90
+	   if (isset($obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision']))
91 91
 	   {
92
-		   $precision=$obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision'];
93
-		   $layout_def['precision']=$precision;
92
+		   $precision = $obj->layout_manager->defs['reporter']->focus->field_name_map[$layout_def['name']]['precision'];
93
+		   $layout_def['precision'] = $precision;
94 94
 	   }
95 95
 	   //Bug40995
96 96
        return parent::display($layout_def);
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetSubPanelTopSummaryButton.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -65,17 +65,17 @@  discard block
 block discarded – undo
65 65
 		$module_name = 'Activities';
66 66
 		$id = $widget_data['focus']->id;
67 67
 		$initial_filter = "&record=$id&module_name=$currentModule";
68
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'detail', true)){
69
-			$temp =  '<input disabled type="button" name="summary_button" id="summary_button"'
68
+		if (ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'detail', true)) {
69
+			$temp = '<input disabled type="button" name="summary_button" id="summary_button"'
70 70
 			. ' class="button"'
71
-			. ' title="' . $title . '"'
72
-			. ' value="' . $value . '"';
71
+			. ' title="'.$title.'"'
72
+			. ' value="'.$value.'"';
73 73
 			return $temp;
74 74
 		}
75 75
 		return '<input type="button" name="summary_button" id="summary_button"'
76 76
 			. ' class="button"'
77
-			. ' title="' . $title . '"'
78
-			. ' value="' . $value . '"'
77
+			. ' title="'.$title.'"'
78
+			. ' value="'.$value.'"'
79 79
 			. " onclick='open_popup(\"$module_name\",600,400,\"$initial_filter\",false,false,$json_encoded_php_array);' />\n";
80 80
 	}
81 81
 }
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetField.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry)
2
+if (!defined('sugarEntry') || !sugarEntry)
3 3
 	die('Not A Valid Entry Point');
4 4
 /*********************************************************************************
5 5
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -56,14 +56,14 @@  discard block
 block discarded – undo
56 56
 		$func_name = 'display'.$context;
57 57
 
58 58
 		if (!empty ($context) && method_exists($this, $func_name)) {
59
-			return $this-> $func_name ($layout_def);
59
+			return $this-> $func_name($layout_def);
60 60
 		} else {
61 61
 			return 'display not found:'.$func_name;
62 62
 		}
63 63
 	}
64 64
 
65 65
 	function _get_column_alias($layout_def) {
66
-		$alias_arr = array ();
66
+		$alias_arr = array();
67 67
 
68 68
 		if (!empty ($layout_def['name']) && $layout_def['name'] == 'count') {
69 69
 			return 'count';
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 		$header_cell_text = $this->displayHeaderCellPlain($layout_def);
120 120
 
121 121
 		$subpanel_module = $layout_def['subpanel_module'];
122
-		$html_var = $subpanel_module . "_CELL";
122
+		$html_var = $subpanel_module."_CELL";
123 123
 		if (empty ($this->base_URL)) {
124 124
 			$objListView = new ListView();
125 125
 			$this->base_URL = $objListView -> getBaseURL($html_var);
@@ -159,9 +159,9 @@  discard block
 block discarded – undo
159 159
 	}
160 160
 
161 161
 	function displayListPlain($layout_def) {
162
-		$value= $this->_get_list_value($layout_def);
163
-		if (isset($layout_def['widget_type']) && $layout_def['widget_type'] =='checkbox') {
164
-			if ($value != '' &&  ($value == 'on' || intval($value) == 1 || $value == 'yes'))
162
+		$value = $this->_get_list_value($layout_def);
163
+		if (isset($layout_def['widget_type']) && $layout_def['widget_type'] == 'checkbox') {
164
+			if ($value != '' && ($value == 'on' || intval($value) == 1 || $value == 'yes'))
165 165
 			{
166 166
 				return "<input name='checkbox_display' class='checkbox' type='checkbox' disabled='true' checked>";
167 167
 			}
@@ -173,14 +173,14 @@  discard block
 block discarded – undo
173 173
 	function _get_list_value(& $layout_def) 
174 174
 	{
175 175
 		$key = '';
176
-		if ( isset($layout_def['varname']) ) {
176
+		if (isset($layout_def['varname'])) {
177 177
 		    $key = strtoupper($layout_def['varname']);
178 178
 		} 
179 179
 		else {
180 180
 			$key = strtoupper($this->_get_column_alias($layout_def));
181 181
 		}
182 182
 
183
-		if ( isset($layout_def['fields'][$key]) ) {
183
+		if (isset($layout_def['fields'][$key])) {
184 184
 			return $layout_def['fields'][$key];
185 185
 		}
186 186
 		
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
         $myName = $layout_def['column_key'];
212 212
         $vardef = $this->layout_manager->defs['reporter']->all_fields[$myName];
213 213
 
214
-        if ( !isset($vardef) ) {
214
+        if (!isset($vardef)) {
215 215
             // No vardef, return an empty array
216 216
             return array();
217 217
         } else {
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetSubPanelEmailLink.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		global $sugar_config;
53 53
 		global $locale;
54 54
 
55
-		if(isset($layout_def['varname'])) {
55
+		if (isset($layout_def['varname'])) {
56 56
 			$key = strtoupper($layout_def['varname']);
57 57
 		} else {
58 58
 			$key = $this->_get_column_alias($layout_def);
@@ -62,35 +62,35 @@  discard block
 block discarded – undo
62 62
 
63 63
 
64 64
 
65
-			if(isset($_REQUEST['action'])) $action = $_REQUEST['action'];
65
+			if (isset($_REQUEST['action'])) $action = $_REQUEST['action'];
66 66
 			else $action = '';
67 67
 
68
-			if(isset($_REQUEST['module'])) $module = $_REQUEST['module'];
68
+			if (isset($_REQUEST['module'])) $module = $_REQUEST['module'];
69 69
 			else $module = '';
70 70
 
71
-			if(isset($_REQUEST['record'])) $record = $_REQUEST['record'];
71
+			if (isset($_REQUEST['record'])) $record = $_REQUEST['record'];
72 72
 			else $record = '';
73 73
 
74 74
 			if (!empty($focus->name)) {
75 75
 				$name = $focus->name;
76 76
 			} else {
77
-				if( !empty($focus->first_name) && !empty($focus->last_name)) {
77
+				if (!empty($focus->first_name) && !empty($focus->last_name)) {
78 78
 					$name = $locale->getLocaleFormattedName($focus->first_name, $focus->last_name);
79 79
 					}
80
-				if(empty($name)) {
80
+				if (empty($name)) {
81 81
 					$name = '*';
82 82
 				}
83 83
 			}
84 84
 
85 85
 			$userPref = $current_user->getPreference('email_link_type');
86 86
 			$defaultPref = $sugar_config['email_default_client'];
87
-			if($userPref != '') {
87
+			if ($userPref != '') {
88 88
 				$client = $userPref;
89 89
 			} else {
90 90
 				$client = $defaultPref;
91 91
 			}
92 92
 
93
-			if($client == 'sugar')
93
+			if ($client == 'sugar')
94 94
 			{
95 95
 			    $composeData = array(
96 96
 			        'load_id' => $layout_def['fields']['ID'],
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 			        'return_action' => $action,
102 102
 			        'return_id' => $record
103 103
 			    );
104
-                if(isset($layout_def['fields']['FULL_NAME'])){
104
+                if (isset($layout_def['fields']['FULL_NAME'])) {
105 105
                     $composeData['parent_name'] = $layout_def['fields']['FULL_NAME'];
106 106
                     $composeData['to_email_addrs'] = sprintf("%s <%s>", $layout_def['fields']['FULL_NAME'], $layout_def['fields']['EMAIL1']);
107 107
                 } else {
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 
114 114
                 $link = "<a href='javascript:void(0);' onclick='SUGAR.quickCompose.init($j_quickComposeOptions);'>";
115 115
 			} else {
116
-				$link = '<a href="mailto:' . $value .'" >';
116
+				$link = '<a href="mailto:'.$value.'" >';
117 117
 			}
118 118
 
119 119
 			return $link.$value.'</a>';
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetSubPanelTopFilterButton.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
  * display the words  "Powered by SugarCRM" and "Supercharged by SuiteCRM".
39 39
  ********************************************************************************/
40 40
 
41
-class SugarWidgetSubPanelTopFilterButton  extends SugarWidgetSubPanelTopButton{
41
+class SugarWidgetSubPanelTopFilterButton  extends SugarWidgetSubPanelTopButton {
42 42
 
43 43
     function display($defines, $additionalFormFields = NULL, $nonbutton = false)
44 44
     {
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
         $button = "<script src='include/SubPanel/SubPanel.js'></script>";
48 48
 
49
-        $button .= "<input class='button' type='button'  value='".$app_strings['LBL_SUBPANEL_FILTER_LABEL']."'  id='". $this->getWidgetId() ."'  name='".$app_strings['LBL_SUBPANEL_FILTER_LABEL']."'  title='".$app_strings['LBL_SUBPANEL_FILTER_LABEL']."' onclick=\"showSearchPanel('history');return false;\" />";
49
+        $button .= "<input class='button' type='button'  value='".$app_strings['LBL_SUBPANEL_FILTER_LABEL']."'  id='".$this->getWidgetId()."'  name='".$app_strings['LBL_SUBPANEL_FILTER_LABEL']."'  title='".$app_strings['LBL_SUBPANEL_FILTER_LABEL']."' onclick=\"showSearchPanel('history');return false;\" />";
50 50
 
51 51
         return $button;
52 52
     }
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetSubPanelTopCreateTaskButton.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,15 +50,15 @@  discard block
 block discarded – undo
50 50
 		global $app_strings;
51 51
 		global $currentModule;
52 52
 
53
-		$this->module="Tasks";
53
+		$this->module = "Tasks";
54 54
 		$this->subpanelDiv = "activities";
55 55
 
56 56
 		// Create the additional form fields with real values if they were not passed in
57
-		if(empty($additionalFormFields) && $this->additional_form_fields)
57
+		if (empty($additionalFormFields) && $this->additional_form_fields)
58 58
 		{
59
-			foreach($this->additional_form_fields as $key=>$value)
59
+			foreach ($this->additional_form_fields as $key=>$value)
60 60
 			{
61
-				if(!empty($defines['focus']->$value))
61
+				if (!empty($defines['focus']->$value))
62 62
 				{
63 63
 					$additionalFormFields[$key] = $defines['focus']->$value;
64 64
 				}
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 			}
70 70
 		}
71 71
 
72
-		if(!empty($this->module))
72
+		if (!empty($this->module))
73 73
 		{
74 74
 			$defines['child_module_name'] = $this->module;
75 75
 		}
@@ -78,45 +78,45 @@  discard block
 block discarded – undo
78 78
 			$defines['child_module_name'] = $defines['module'];
79 79
 		}
80 80
 
81
-		if(empty($defines['subpanelDiv']))
81
+		if (empty($defines['subpanelDiv']))
82 82
 		{
83 83
 			$defines['subpanelDiv'] = $this->subpanelDiv;
84 84
 		}
85 85
 
86
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
86
+		$defines['parent_bean_name'] = get_class($defines['focus']);
87 87
 
88
-		$form = 'form' . $defines['child_module_name'];
89
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
88
+		$form = 'form'.$defines['child_module_name'];
89
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.strtolower($defines['subpanelDiv']).'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
90 90
 
91 91
 		//module_button is used to override the value of module name
92 92
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
93 93
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
94 94
 
95
-		if(isset($defines['focus']->name))
95
+		if (isset($defines['focus']->name))
96 96
 		{
97 97
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
98 98
 		}
99 99
 
100 100
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
101 101
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
102
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
103
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
104
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
102
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
103
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
104
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
105 105
 		$button .= '<input type="hidden" name="record" value="" />';
106 106
 
107 107
 		// TODO: move this out and get $additionalFormFields working properly
108
-		if(empty($additionalFormFields['parent_type']))
108
+		if (empty($additionalFormFields['parent_type']))
109 109
 		{
110
-			if($defines['focus']->object_name=='Contact') {
110
+			if ($defines['focus']->object_name == 'Contact') {
111 111
 				$additionalFormFields['parent_type'] = 'Accounts';
112 112
 			}
113 113
 			else {
114 114
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
115 115
 			}
116 116
 		}
117
-		if(empty($additionalFormFields['parent_name']))
117
+		if (empty($additionalFormFields['parent_name']))
118 118
 		{
119
-			if($defines['focus']->object_name=='Contact') {
119
+			if ($defines['focus']->object_name == 'Contact') {
120 120
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
121 121
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
122 122
 			}
@@ -124,9 +124,9 @@  discard block
 block discarded – undo
124 124
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
125 125
 			}
126 126
 		}
127
-		if(empty($additionalFormFields['parent_id']))
127
+		if (empty($additionalFormFields['parent_id']))
128 128
 		{
129
-			if($defines['focus']->object_name=='Contact') {
129
+			if ($defines['focus']->object_name == 'Contact') {
130 130
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
131 131
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
132 132
 			}
@@ -135,16 +135,16 @@  discard block
 block discarded – undo
135 135
 			}
136 136
 		}
137 137
 
138
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
139
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
140
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
138
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
139
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
140
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
141 141
 
142 142
 		// fill in additional form fields for all but action
143
-		foreach($additionalFormFields as $key => $value)
143
+		foreach ($additionalFormFields as $key => $value)
144 144
 		{
145
-			if($key != 'action')
145
+			if ($key != 'action')
146 146
 			{
147
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
147
+				$button .= '<input type="hidden" name="'.$key.'" value="'.$value.'" />'."\n";
148 148
 			}
149 149
 		}
150 150
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 	function display($defines, $additionalFormFields = null, $nonbutton = false)
156 156
 	{
157 157
 	    $focus = new Task;
158
-		if ( !$focus->ACLAccess('EditView') ) {
158
+		if (!$focus->ACLAccess('EditView')) {
159 159
 		    return '';
160 160
 	    }
161 161
 		
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetSubPanelEditButton.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
                 }
72 72
             }
73 73
 
74
-            $handler = 'subp_nav(\'' . $layout_def['module'] . '\', \'' . $layout_def['fields']['ID'] . '\', \'e\', this';
74
+            $handler = 'subp_nav(\''.$layout_def['module'].'\', \''.$layout_def['fields']['ID'].'\', \'e\', this';
75 75
             if (!empty($relationship_name)) {
76
-                $handler .= ', \'' . $relationship_name . '\'';
76
+                $handler .= ', \''.$relationship_name.'\'';
77 77
             }
78 78
             $handler .= ');';
79 79
 
80
-            return '<a href="#" onmouseover="' . $handler . '" onfocus="' . $handler .
81
-                '" class="listViewTdToolsS1" id="' . $unique_id . '">' . $app_strings['LNK_EDIT'] . '</a>';
80
+            return '<a href="#" onmouseover="'.$handler.'" onfocus="'.$handler.
81
+                '" class="listViewTdToolsS1" id="'.$unique_id.'">'.$app_strings['LNK_EDIT'].'</a>';
82 82
         }
83 83
 
84 84
         return '';
Please login to merge, or discard this patch.
include/generic/SugarWidgets/SugarWidgetFieldtime.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
2
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3 3
 /*********************************************************************************
4 4
  * SugarCRM Community Edition is a customer relationship management program developed by
5 5
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,10 +45,10 @@  discard block
 block discarded – undo
45 45
         {
46 46
                 global $timedate;
47 47
                 // i guess qualifier and column_function are the same..
48
-                if (! empty($layout_def['column_function']))
48
+                if (!empty($layout_def['column_function']))
49 49
                  {
50 50
                         $func_name = 'displayList'.$layout_def['column_function'];
51
-                        if ( method_exists($this,$func_name))
51
+                        if (method_exists($this, $func_name))
52 52
                         {
53 53
                                 return $this->$func_name($layout_def)." \n";
54 54
                         }
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
                 
62 62
                 $content = $this->displayListPlain($layout_def);
63 63
                 
64
-                if(!empty($date)) { // able to get the date context of the time            	
65
-                	$td = explode(' ', $timedate->to_display_date_time($date . ' ' . $content));
64
+                if (!empty($date)) { // able to get the date context of the time            	
65
+                	$td = explode(' ', $timedate->to_display_date_time($date.' '.$content));
66 66
 	                return $td[1];
67 67
                 }
68 68
                 else { // assume there is no time context
Please login to merge, or discard this patch.