Inspection of "get ocular.phar" - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — scrutinizer-code-quality ( eedb15...27193c )

by Adam

created 2016-05-03 14:27 UTC

Status

Indentation +85 added lines, -85 removed lines patch added patch discarded remove patch

@@ -39,188 +39,188 @@
 block discarded – undo
 
 $viewdefs ['Prospects'] = 
 array (
-  'DetailView' => 
-  array (
+    'DetailView' => 
+    array (
     'templateMeta' => 
     array (
-      'form' => 
-      array (
+        'form' => 
+        array (
         'buttons' => 
         array (
-          0 => 'EDIT',
-          1 => 'DUPLICATE',
-          2 => 'DELETE',
-          3 => 
-          array (
+            0 => 'EDIT',
+            1 => 'DUPLICATE',
+            2 => 'DELETE',
+            3 => 
+            array (
             'customCode' => '<input title="{$MOD.LBL_CONVERT_BUTTON_TITLE}" class="button" onclick="this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\';this.form.module.value=\'Leads\';this.form.action.value=\'EditView\';" type="submit" name="CONVERT_LEAD_BTN" value="{$MOD.LBL_CONVERT_BUTTON_LABEL}"/>',
             'sugar_html' => 
             array (
-              'type' => 'submit',
-              'value' => '{$MOD.LBL_CONVERT_BUTTON_LABEL}',
-              'htmlOptions' => 
-              array (
+                'type' => 'submit',
+                'value' => '{$MOD.LBL_CONVERT_BUTTON_LABEL}',
+                'htmlOptions' => 
+                array (
                 'class' => 'button',
                 'name' => 'CONVERT_LEAD_BTN',
                 'id' => 'convert_target_button',
                 'title' => '{$MOD.LBL_CONVERT_BUTTON_TITLE}',
                 'onclick' => 'this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\';this.form.module.value=\'Leads\';this.form.action.value=\'EditView\';',
-              ),
+                ),
             ),
-          ),
-          4 => 
-          array (
+            ),
+            4 => 
+            array (
             'customCode' => '<input title="{$APP.LBL_MANAGE_SUBSCRIPTIONS}" class="button" onclick="this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'; this.form.action.value=\'Subscriptions\'; this.form.module.value=\'Campaigns\';" type="submit" name="Manage Subscriptions" value="{$APP.LBL_MANAGE_SUBSCRIPTIONS}"/>',
             'sugar_html' => 
             array (
-              'type' => 'submit',
-              'value' => '{$APP.LBL_MANAGE_SUBSCRIPTIONS}',
-              'htmlOptions' => 
-              array (
+                'type' => 'submit',
+                'value' => '{$APP.LBL_MANAGE_SUBSCRIPTIONS}',
+                'htmlOptions' => 
+                array (
                 'class' => 'button',
                 'id' => 'manage_subscriptions_button',
                 'name' => 'Manage Subscriptions',
                 'title' => '{$APP.LBL_MANAGE_SUBSCRIPTIONS}',
                 'onclick' => 'this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'; this.form.action.value=\'Subscriptions\'; this.form.module.value=\'Campaigns\';',
-              ),
+                ),
+            ),
             ),
-          ),
         ),
         'hidden' => 
         array (
-          0 => '<input type="hidden" name="prospect_id" value="{$fields.id.value}">',
+            0 => '<input type="hidden" name="prospect_id" value="{$fields.id.value}">',
         ),
         'headerTpl' => 'modules/Prospects/tpls/DetailViewHeader.tpl',
-      ),
-      'maxColumns' => '2',
-      'widths' => 
-      array (
+        ),
+        'maxColumns' => '2',
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
+        ),
         ),
-      ),
-      'useTabs' => true,
-      'tabDefs' => 
-      array (
+        'useTabs' => true,
+        'tabDefs' => 
+        array (
         'LBL_PROSPECT_INFORMATION' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
         'LBL_MORE_INFORMATION' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
+        ),
         ),
-      ),
     ),
     'panels' => 
     array (
-      'lbl_prospect_information' => 
-      array (
+        'lbl_prospect_information' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'full_name',
-          ),
+            ),
         ),
         1 => 
         array (
-          0 => 'title',
-          1 => 
-          array (
+            0 => 'title',
+            1 => 
+            array (
             'name' => 'phone_work',
             'label' => 'LBL_OFFICE_PHONE',
-          ),
+            ),
         ),
         2 => 
         array (
-          0 => 'department',
-          1 => 'phone_mobile',
+            0 => 'department',
+            1 => 'phone_mobile',
         ),
         3 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'account_name',
-          ),
-          1 => 'phone_fax',
+            ),
+            1 => 'phone_fax',
         ),
         4 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'primary_address_street',
             'label' => 'LBL_PRIMARY_ADDRESS',
             'type' => 'address',
             'displayParams' => 
             array (
-              'key' => 'primary',
+                'key' => 'primary',
+            ),
             ),
-          ),
-          1 => 
-          array (
+            1 => 
+            array (
             'name' => 'alt_address_street',
             'label' => 'LBL_ALTERNATE_ADDRESS',
             'type' => 'address',
             'displayParams' => 
             array (
-              'key' => 'alt',
+                'key' => 'alt',
+            ),
             ),
-          ),
         ),
         5 => 
         array (
-          0 => 'email1',
+            0 => 'email1',
         ),
         6 => 
         array (
-          0 => 'description',
+            0 => 'description',
         ),
         7 => 
         array (
-          0 => 'assigned_user_name',
+            0 => 'assigned_user_name',
         ),
-      ),
-      'LBL_MORE_INFORMATION' => 
-      array (
+        ),
+        'LBL_MORE_INFORMATION' => 
+        array (
         0 => 
         array (
-          0 => 'email_opt_out',
-          1 => 'do_not_call',
+            0 => 'email_opt_out',
+            1 => 'do_not_call',
+        ),
         ),
-      ),
-      'LBL_PANEL_ASSIGNMENT' => 
-      array (
+        'LBL_PANEL_ASSIGNMENT' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'modified_by_name',
             'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_MODIFIED',
-          ),
-          1 =>
-          array (
+            ),
+            1 =>
+            array (
             'name' => 'created_by_name',
             'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_ENTERED',
-          ),
+            ),
         ),
-      ),
+        ),
+    ),
     ),
-  ),
 );
 ?>

Please login to merge, or discard this patch.

modules/Prospects/metadata/quickcreatedefs.php 1 patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

@@ -46,121 +46,121 @@
 block discarded – undo
  ********************************************************************************/
 
 $viewdefs = array (
-  'Prospects' => 
-  array (
+    'Prospects' => 
+    array (
     'QuickCreate' => 
     array (
-      'templateMeta' => 
-      array (
+        'templateMeta' => 
+        array (
         'maxColumns' => '2',
         'widths' => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'label' => '10',
             'field' => '30',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'label' => '10',
             'field' => '30',
-          ),
+            ),
         ),
-      ),
-      'panels' => 
-      array (
+        ),
+        'panels' => 
+        array (
         'LBL_PROSPECT_INFORMATION' => 
         array (
-          0 => 
-          array (
             0 => 
             array (
-              'name' => 'first_name',
+            0 => 
+            array (
+                'name' => 'first_name',
             ),
             1 => 
             array (
-              'name' => 'phone_work',
+                'name' => 'phone_work',
             ),
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             0 => 
             array (
-              'name' => 'last_name',
-              'displayParams'=>array('required'=>true)
+                'name' => 'last_name',
+                'displayParams'=>array('required'=>true)
             ),
             1 => 
             array (
-              'name' => 'phone_mobile',
+                'name' => 'phone_mobile',
+            ),
             ),
-          ),
-          2 => 
-          array (
+            2 => 
+            array (
             0 => 
             array (
-              'name' => 'account_name',
+                'name' => 'account_name',
             ),
             1 => 
             array (
-              'name' => 'phone_fax',
+                'name' => 'phone_fax',
+            ),
             ),
-          ),
-          3 => 
-          array (
+            3 => 
+            array (
             0 => 
             array (
-              'name' => 'title',
+                'name' => 'title',
             ),
             1 => 
             array (
-              'name' => 'department',
+                'name' => 'department',
+            ),
             ),
-          ),
-          4 => 
-          array (
+            4 => 
+            array (
             0 => 
             array (
-              'name' => 'team_name',
+                'name' => 'team_name',
             ),
             1 => 
             array (
-              'name' => 'do_not_call',
+                'name' => 'do_not_call',
+            ),
             ),
-          ),
-          5 => 
-          array (
+            5 => 
+            array (
             0 => 
             array (
-              'name' => 'assigned_user_name',
+                'name' => 'assigned_user_name',
+            ),
             ),
-          ),
         ),
         'lbl_email_addresses' => 
         array (
-          0 => 
-          array (
             0 => 
             array (
-              'name' => 'email1',
+            0 => 
+            array (
+                'name' => 'email1',
+            ),
             ),
-          ),
         ),
         'LBL_ADDRESS_INFORMATION' => 
         array (
-          0 => 
-          array (
             0 => 
             array (
-              'name' => 'primary_address_street',
+            0 => 
+            array (
+                'name' => 'primary_address_street',
             ),
             1 => 
             array (
-              'name' => 'alt_address_street',
+                'name' => 'alt_address_street',
+            ),
             ),
-          ),
         ),
-      ),
+        ),
+    ),
     ),
-  ),
 );
 ?>

Please login to merge, or discard this patch.

modules/Prospects/metadata/listviewdefs.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -42,10 +42,10 @@  discard block
 block discarded – undo
 
 
 $listViewDefs['Prospects'] = array(
-	'FULL_NAME' => array(
-		'width' => '20', 
-		'label' => 'LBL_LIST_NAME', 
-		'link' => true,
+    'FULL_NAME' => array(
+        'width' => '20', 
+        'label' => 'LBL_LIST_NAME', 
+        'link' => true,
         'related_fields' => array('first_name', 'last_name'),
         'orderBy' => 'last_name',
         'default' => true),
@@ -65,11 +65,11 @@  discard block
 block discarded – undo
         'label' => 'LBL_LIST_PHONE', 
         'link' => false,
         'default' => true), 
-	'DATE_ENTERED' => array (
-	    'type' => 'datetime',
-	    'label' => 'LBL_DATE_ENTERED',
-	    'width' => '10',
-	    'default' => true,
-	  ),  
+    'DATE_ENTERED' => array (
+        'type' => 'datetime',
+        'label' => 'LBL_DATE_ENTERED',
+        'width' => '10',
+        'default' => true,
+        ),  
 );
 ?>

Please login to merge, or discard this patch.

modules/Documents/GetLatestRevision.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -45,12 +45,12 @@
 block discarded – undo
 require_once('include/formbase.php');
 if (!empty($_REQUEST['record'])) {
 
-	$document = new Document();
-	$document->retrieve($_REQUEST['record']);
-	if (!empty($document->document_revision_id) && !empty($_REQUEST['get_latest_for_id']))  {
-		$query="update linked_documents set document_revision_id='{$document->document_revision_id}', date_modified='".TimeDate::getInstance()->nowDb()."' where id ='{$_REQUEST['get_latest_for_id']}' ";
-		$document->db->query($query);
-	}	
+    $document = new Document();
+    $document->retrieve($_REQUEST['record']);
+    if (!empty($document->document_revision_id) && !empty($_REQUEST['get_latest_for_id']))  {
+        $query="update linked_documents set document_revision_id='{$document->document_revision_id}', date_modified='".TimeDate::getInstance()->nowDb()."' where id ='{$_REQUEST['get_latest_for_id']}' ";
+        $document->db->query($query);
+    }	
 }
 handleRedirect();
 ?>

Please login to merge, or discard this patch.

modules/Documents/DocumentExternalApiDropDown.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 if(!defined('sugarEntry') || !sugarEntry)
-	die('Not A Valid Entry Point');
+    die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

modules/Documents/metadata/editviewdefs.php 1 patch

Indentation +61 added lines, -61 removed lines patch added patch discarded remove patch

@@ -1,131 +1,131 @@
 block discarded – undo
 <?php
 $viewdefs ['Documents'] = 
 array (
-  'EditView' => 
-  array (
+    'EditView' => 
+    array (
     'templateMeta' => 
     array (
-      'form' => 
-      array (
+        'form' => 
+        array (
         'enctype' => 'multipart/form-data',
         'hidden' => 
         array (
-          0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
-          1 => '<input type="hidden" name="contract_id" value="{$smarty.request.contract_id}">',
+            0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
+            1 => '<input type="hidden" name="contract_id" value="{$smarty.request.contract_id}">',
         ),
-      ),
-      'maxColumns' => '2',
-      'widths' => 
-      array (
+        ),
+        'maxColumns' => '2',
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
-      ),
-      'javascript' => '{sugar_getscript file="include/javascript/popup_parent_helper.js"}
+        ),
+        'javascript' => '{sugar_getscript file="include/javascript/popup_parent_helper.js"}
 {sugar_getscript file="cache/include/javascript/sugar_grp_jsolait.js"}
 {sugar_getscript file="modules/Documents/documents.js"}',
-      'useTabs' => false,
-      'tabDefs' => 
-      array (
+        'useTabs' => false,
+        'tabDefs' => 
+        array (
         'LBL_DOCUMENT_INFORMATION' => 
         array (
-          'newTab' => false,
-          'panelDefault' => 'expanded',
+            'newTab' => false,
+            'panelDefault' => 'expanded',
+        ),
         ),
-      ),
     ),
     'panels' => 
     array (
-      'lbl_document_information' => 
-      array (
+        'lbl_document_information' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'filename',
             'displayParams' => 
             array (
-              'onchangeSetFileNameTo' => 'document_name',
+                'onchangeSetFileNameTo' => 'document_name',
+            ),
             ),
-          ),
-          1 => 
-          array (
+            1 => 
+            array (
             'name' => 'status_id',
             'label' => 'LBL_DOC_STATUS',
-          ),
+            ),
         ),
         1 => 
         array (
-          0 => 'document_name',
-          1 => 
-          array (
+            0 => 'document_name',
+            1 => 
+            array (
             'name' => 'revision',
             'customCode' => '<input name="revision" type="text" value="{$fields.revision.value}" {$DISABLED}>',
-          ),
+            ),
         ),
         2 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'template_type',
             'label' => 'LBL_DET_TEMPLATE_TYPE',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'is_template',
             'label' => 'LBL_DET_IS_TEMPLATE',
-          ),
+            ),
         ),
         3 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'active_date',
-          ),
-          1 => 'exp_date',
+            ),
+            1 => 'exp_date',
         ),
         4 => 
         array (
-          0 => 'category_id',
-          1 => 'subcategory_id',
+            0 => 'category_id',
+            1 => 'subcategory_id',
         ),
         5 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'description',
-          ),
+            ),
         ),
         6 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'related_doc_name',
             'customCode' => '<input name="related_document_name" type="text" size="30" maxlength="255" value="{$RELATED_DOCUMENT_NAME}" readonly><input name="related_doc_id" type="hidden" value="{$fields.related_doc_id.value}"/>&nbsp;<input title="{$APP.LBL_SELECT_BUTTON_TITLE}" type="{$RELATED_DOCUMENT_BUTTON_AVAILABILITY}" class="button" value="{$APP.LBL_SELECT_BUTTON_LABEL}" name="btn2" onclick=\'open_popup("Documents", 600, 400, "", true, false, {$encoded_document_popup_request_data}, "single", true);\'/>',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'related_doc_rev_number',
             'customCode' => '<select name="related_doc_rev_id" id="related_doc_rev_id" {$RELATED_DOCUMENT_REVISION_DISABLED}>{$RELATED_DOCUMENT_REVISION_OPTIONS}</select>',
-          ),
+            ),
         ),
         7 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
-          ),
+            ),
+        ),
         ),
-      ),
     ),
-  ),
+    ),
 );
 ?>

Please login to merge, or discard this patch.

modules/Documents/metadata/searchdefs.php 1 patch

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

@@ -1,88 +1,88 @@
 block discarded – undo
 <?php
 $searchdefs ['Documents'] = 
 array (
-  'layout' => 
-  array (
+    'layout' => 
+    array (
     'basic_search' => 
     array (
-      0 => 'document_name',
-      1 => array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
+        0 => 'document_name',
+        1 => array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
     ),
     'advanced_search' => 
     array (
-      'document_name' => 
-      array (
+        'document_name' => 
+        array (
         'name' => 'document_name',
         'default' => true,
         'width' => '10%',
-      ),
-      'status' => 
-      array (
+        ),
+        'status' => 
+        array (
         'type' => 'varchar',
         'label' => 'LBL_DOC_STATUS',
         'width' => '10%',
         'default' => true,
         'name' => 'status',
-      ),
-      'template_type' => 
-      array (
+        ),
+        'template_type' => 
+        array (
         'type' => 'enum',
         'label' => 'LBL_TEMPLATE_TYPE',
         'width' => '10%',
         'default' => true,
         'name' => 'template_type',
-      ),
-      'category_id' => 
-      array (
+        ),
+        'category_id' => 
+        array (
         'name' => 'category_id',
         'default' => true,
         'width' => '10%',
-      ),
-      'subcategory_id' => 
-      array (
+        ),
+        'subcategory_id' => 
+        array (
         'name' => 'subcategory_id',
         'default' => true,
         'width' => '10%',
-      ),
-      'assigned_user_id' => 
-      array (
+        ),
+        'assigned_user_id' => 
+        array (
         'name' => 'assigned_user_id',
         'type' => 'enum',
         'label' => 'LBL_ASSIGNED_TO',
         'function' => 
         array (
-          'name' => 'get_user_array',
-          'params' => 
-          array (
+            'name' => 'get_user_array',
+            'params' => 
+            array (
             0 => false,
-          ),
+            ),
         ),
         'default' => true,
         'width' => '10%',
-      ),
-      'active_date' => 
-      array (
+        ),
+        'active_date' => 
+        array (
         'name' => 'active_date',
         'default' => true,
         'width' => '10%',
-      ),
-      'exp_date' => 
-      array (
+        ),
+        'exp_date' => 
+        array (
         'name' => 'exp_date',
         'default' => true,
         'width' => '10%',
-      ),
+        ),
+    ),
     ),
-  ),
-  'templateMeta' => 
-  array (
+    'templateMeta' => 
+    array (
     'maxColumns' => '3',
     'maxColumnsBasic' => '4',
     'widths' => 
     array (
-      'label' => '10',
-      'field' => '30',
+        'label' => '10',
+        'field' => '30',
+    ),
     ),
-  ),
 );
 ?>

Please login to merge, or discard this patch.

modules/Documents/metadata/SearchFields.php 1 patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -3,36 +3,36 @@  discard block
 block discarded – undo
 global $current_user;
 $module_name = "Documents";
 $searchFields['Documents'] = array (
-  'document_name' => 
-  array (
+    'document_name' => 
+    array (
     'query_type' => 'default',
-  ),
-  'category_id' => 
-  array (
+    ),
+    'category_id' => 
+    array (
     'query_type' => 'default',
     'options' => 'document_category_dom',
     'template_var' => 'CATEGORY_OPTIONS',
-  ),
-  'subcategory_id' => 
-  array (
+    ),
+    'subcategory_id' => 
+    array (
     'query_type' => 'default',
     'options' => 'document_subcategory_dom',
     'template_var' => 'SUBCATEGORY_OPTIONS',
-  ),
-  'active_date' => 
-  array (
+    ),
+    'active_date' => 
+    array (
     'query_type' => 'default',
-  ),
-  'exp_date' => 
-  array (
+    ),
+    'exp_date' => 
+    array (
     'query_type' => 'default',
-  ),
-  'assigned_user_id' => 
-  array (
+    ),
+    'assigned_user_id' => 
+    array (
     'query_type' => 'default',
-  ),
-  'filename' => 
-  array (
+    ),
+    'filename' => 
+    array (
     'query_type' => 'format',
     'operator' => 'subquery',
     'subquery' => 'SELECT document_revisions.id FROM document_revisions
@@ -40,45 +40,45 @@  discard block
 block discarded – undo
 				   AND document_revisions.filename LIKE \'{0}\'',
     'db_field' => 
     array (
-      0 => 'document_revision_id',
+        0 => 'document_revision_id',
     ),
-  ),
-  'range_date_entered' => 
-  array (
+    ),
+    'range_date_entered' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'start_range_date_entered' => 
-  array (
+    ),
+    'start_range_date_entered' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'end_range_date_entered' => 
-  array (
+    ),
+    'end_range_date_entered' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'range_date_modified' => 
-  array (
+    ),
+    'range_date_modified' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'start_range_date_modified' => 
-  array (
+    ),
+    'start_range_date_modified' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'end_range_date_modified' => 
-  array (
+    ),
+    'end_range_date_modified' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
+    ),
     'favorites_only' => array(
         'query_type'=>'format',
         'operator' => 'subquery',

Please login to merge, or discard this patch.

modules/Documents/metadata/detailviewdefs.php 1 patch

Indentation +72 added lines, -72 removed lines patch added patch discarded remove patch

@@ -39,140 +39,140 @@
 block discarded – undo
 
 $viewdefs ['Documents'] = 
 array (
-  'DetailView' => 
-  array (
+    'DetailView' => 
+    array (
     'templateMeta' => 
     array (
-      'maxColumns' => '2',
-      'form' => 
-      array (
+        'maxColumns' => '2',
+        'form' => 
+        array (
         'hidden' => 
         array (
-          0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
+            0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
         ),
-      ),
-      'widths' => 
-      array (
+        ),
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
-      ),
-      'useTabs' => true,
-      'tabDefs' => 
-      array (
+        ),
+        'useTabs' => true,
+        'tabDefs' => 
+        array (
         'LBL_DOCUMENT_INFORMATION' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' =>
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
+        ),
         ),
-      ),
     ),
     'panels' => 
     array (
-      'lbl_document_information' => 
-      array (
+        'lbl_document_information' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'filename',
             'displayParams' => 
             array (
-              'link' => 'filename',
-              'id' => 'document_revision_id',
+                'link' => 'filename',
+                'id' => 'document_revision_id',
+            ),
             ),
-          ),
-          1 => 
-          array (
+            1 => 
+            array (
             'name' => 'status_id',
             'label' => 'LBL_DOC_STATUS',
-          ),
+            ),
         ),
         1 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'document_name',
             'label' => 'LBL_DOC_NAME',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'revision',
             'label' => 'LBL_DOC_VERSION',
-          ),
+            ),
         ),
         2 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'template_type',
             'label' => 'LBL_DET_TEMPLATE_TYPE',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'is_template',
             'label' => 'LBL_DET_IS_TEMPLATE',
-          ),
+            ),
         ),
         3 => 
         array (
-          0 => 'active_date',
-          1 => 'exp_date',
+            0 => 'active_date',
+            1 => 'exp_date',
         ),
         4 => 
         array (
-          0 => 'category_id',
-          1 => 'subcategory_id',
+            0 => 'category_id',
+            1 => 'subcategory_id',
         ),
         5 => 
         array (
-          0 => '',
-          1 => '',
+            0 => '',
+            1 => '',
         ),
         6 => 
         array (
-          0 => 'related_doc_name',
-          1 => 'related_doc_rev_number',
+            0 => 'related_doc_name',
+            1 => 'related_doc_rev_number',
         ),
         7 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
-          ),
+            ),
         ),
-      ),
-      'LBL_PANEL_ASSIGNMENT' =>
-      array (
+        ),
+        'LBL_PANEL_ASSIGNMENT' =>
+        array (
         0 => 
         array (
-          0 => 
-          array (
-              'name' => 'date_entered',
-              'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
-          ),
-          1 => 
-          array (
-              'name' => 'date_modified',
-              'label' => 'LBL_DATE_MODIFIED',
-              'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',
-          ),
-        ),
-      ),
+            0 => 
+            array (
+                'name' => 'date_entered',
+                'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
+            ),
+            1 => 
+            array (
+                'name' => 'date_modified',
+                'label' => 'LBL_DATE_MODIFIED',
+                'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',
+            ),
+        ),
+        ),
+    ),
     ),
-  ),
 );
 ?>

Please login to merge, or discard this patch.

		@@ -46,121 +46,121 @@
		block discarded – undo
46	46	********************************************************************************/
47	47
48	48	$viewdefs = array (
49		- 'Prospects' =>
50		- array (
	49	+ 'Prospects' =>
	50	+ array (
51	51	'QuickCreate' =>
52	52	array (
53		- 'templateMeta' =>
54		- array (
	53	+ 'templateMeta' =>
	54	+ array (
55	55	'maxColumns' => '2',
56	56	'widths' =>
57	57	array (
58		- 0 =>
59		- array (
	58	+ 0 =>
	59	+ array (
60	60	'label' => '10',
61	61	'field' => '30',
62		- ),
63		- 1 =>
64		- array (
	62	+ ),
	63	+ 1 =>
	64	+ array (
65	65	'label' => '10',
66	66	'field' => '30',
67		- ),
	67	+ ),
68	68	),
69		- ),
70		- 'panels' =>
71		- array (
	69	+ ),
	70	+ 'panels' =>
	71	+ array (
72	72	'LBL_PROSPECT_INFORMATION' =>
73	73	array (
74		- 0 =>
75		- array (
76	74	0 =>
77	75	array (
78		- 'name' => 'first_name',
	76	+ 0 =>
	77	+ array (
	78	+ 'name' => 'first_name',
79	79	),
80	80	1 =>
81	81	array (
82		- 'name' => 'phone_work',
	82	+ 'name' => 'phone_work',
83	83	),
84		- ),
85		- 1 =>
86		- array (
	84	+ ),
	85	+ 1 =>
	86	+ array (
87	87	0 =>
88	88	array (
89		- 'name' => 'last_name',
90		- 'displayParams'=>array('required'=>true)
	89	+ 'name' => 'last_name',
	90	+ 'displayParams'=>array('required'=>true)
91	91	),
92	92	1 =>
93	93	array (
94		- 'name' => 'phone_mobile',
	94	+ 'name' => 'phone_mobile',
	95	+ ),
95	96	),
96		- ),
97		- 2 =>
98		- array (
	97	+ 2 =>
	98	+ array (
99	99	0 =>
100	100	array (
101		- 'name' => 'account_name',
	101	+ 'name' => 'account_name',
102	102	),
103	103	1 =>
104	104	array (
105		- 'name' => 'phone_fax',
	105	+ 'name' => 'phone_fax',
	106	+ ),
106	107	),
107		- ),
108		- 3 =>
109		- array (
	108	+ 3 =>
	109	+ array (
110	110	0 =>
111	111	array (
112		- 'name' => 'title',
	112	+ 'name' => 'title',
113	113	),
114	114	1 =>
115	115	array (
116		- 'name' => 'department',
	116	+ 'name' => 'department',
	117	+ ),
117	118	),
118		- ),
119		- 4 =>
120		- array (
	119	+ 4 =>
	120	+ array (
121	121	0 =>
122	122	array (
123		- 'name' => 'team_name',
	123	+ 'name' => 'team_name',
124	124	),
125	125	1 =>
126	126	array (
127		- 'name' => 'do_not_call',
	127	+ 'name' => 'do_not_call',
	128	+ ),
128	129	),
129		- ),
130		- 5 =>
131		- array (
	130	+ 5 =>
	131	+ array (
132	132	0 =>
133	133	array (
134		- 'name' => 'assigned_user_name',
	134	+ 'name' => 'assigned_user_name',
	135	+ ),
135	136	),
136		- ),
137	137	),
138	138	'lbl_email_addresses' =>
139	139	array (
140		- 0 =>
141		- array (
142	140	0 =>
143	141	array (
144		- 'name' => 'email1',
	142	+ 0 =>
	143	+ array (
	144	+ 'name' => 'email1',
	145	+ ),
145	146	),
146		- ),
147	147	),
148	148	'LBL_ADDRESS_INFORMATION' =>
149	149	array (
150		- 0 =>
151		- array (
152	150	0 =>
153	151	array (
154		- 'name' => 'primary_address_street',
	152	+ 0 =>
	153	+ array (
	154	+ 'name' => 'primary_address_street',
155	155	),
156	156	1 =>
157	157	array (
158		- 'name' => 'alt_address_street',
	158	+ 'name' => 'alt_address_street',
	159	+ ),
159	160	),
160		- ),
161	161	),
162		- ),
	162	+ ),
	163	+ ),
163	164	),
164		- ),
165	165	);
166	166	?>

		@@ -39,188 +39,188 @@
		block discarded – undo
39	39
40	40	$viewdefs ['Prospects'] =
41	41	array (
42		- 'DetailView' =>
43		- array (
	42	+ 'DetailView' =>
	43	+ array (
44	44	'templateMeta' =>
45	45	array (
46		- 'form' =>
47		- array (
	46	+ 'form' =>
	47	+ array (
48	48	'buttons' =>
49	49	array (
50		- 0 => 'EDIT',
51		- 1 => 'DUPLICATE',
52		- 2 => 'DELETE',
53		- 3 =>
54		- array (
	50	+ 0 => 'EDIT',
	51	+ 1 => 'DUPLICATE',
	52	+ 2 => 'DELETE',
	53	+ 3 =>
	54	+ array (
55	55	'customCode' => '<input title="{$MOD.LBL_CONVERT_BUTTON_TITLE}" class="button" onclick="this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\';this.form.module.value=\'Leads\';this.form.action.value=\'EditView\';" type="submit" name="CONVERT_LEAD_BTN" value="{$MOD.LBL_CONVERT_BUTTON_LABEL}"/>',
56	56	'sugar_html' =>
57	57	array (
58		- 'type' => 'submit',
59		- 'value' => '{$MOD.LBL_CONVERT_BUTTON_LABEL}',
60		- 'htmlOptions' =>
61		- array (
	58	+ 'type' => 'submit',
	59	+ 'value' => '{$MOD.LBL_CONVERT_BUTTON_LABEL}',
	60	+ 'htmlOptions' =>
	61	+ array (
62	62	'class' => 'button',
63	63	'name' => 'CONVERT_LEAD_BTN',
64	64	'id' => 'convert_target_button',
65	65	'title' => '{$MOD.LBL_CONVERT_BUTTON_TITLE}',
66	66	'onclick' => 'this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\';this.form.module.value=\'Leads\';this.form.action.value=\'EditView\';',
67		- ),
	67	+ ),
68	68	),
69		- ),
70		- 4 =>
71		- array (
	69	+ ),
	70	+ 4 =>
	71	+ array (
72	72	'customCode' => '<input title="{$APP.LBL_MANAGE_SUBSCRIPTIONS}" class="button" onclick="this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'; this.form.action.value=\'Subscriptions\'; this.form.module.value=\'Campaigns\';" type="submit" name="Manage Subscriptions" value="{$APP.LBL_MANAGE_SUBSCRIPTIONS}"/>',
73	73	'sugar_html' =>
74	74	array (
75		- 'type' => 'submit',
76		- 'value' => '{$APP.LBL_MANAGE_SUBSCRIPTIONS}',
77		- 'htmlOptions' =>
78		- array (
	75	+ 'type' => 'submit',
	76	+ 'value' => '{$APP.LBL_MANAGE_SUBSCRIPTIONS}',
	77	+ 'htmlOptions' =>
	78	+ array (
79	79	'class' => 'button',
80	80	'id' => 'manage_subscriptions_button',
81	81	'name' => 'Manage Subscriptions',
82	82	'title' => '{$APP.LBL_MANAGE_SUBSCRIPTIONS}',
83	83	'onclick' => 'this.form.return_module.value=\'Prospects\'; this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'; this.form.action.value=\'Subscriptions\'; this.form.module.value=\'Campaigns\';',
84		- ),
	84	+ ),
	85	+ ),
85	86	),
86		- ),
87	87	),
88	88	'hidden' =>
89	89	array (
90		- 0 => '<input type="hidden" name="prospect_id" value="{$fields.id.value}">',
	90	+ 0 => '<input type="hidden" name="prospect_id" value="{$fields.id.value}">',
91	91	),
92	92	'headerTpl' => 'modules/Prospects/tpls/DetailViewHeader.tpl',
93		- ),
94		- 'maxColumns' => '2',
95		- 'widths' =>
96		- array (
	93	+ ),
	94	+ 'maxColumns' => '2',
	95	+ 'widths' =>
	96	+ array (
97	97	0 =>
98	98	array (
99		- 'label' => '10',
100		- 'field' => '30',
	99	+ 'label' => '10',
	100	+ 'field' => '30',
101	101	),
102	102	1 =>
103	103	array (
104		- 'label' => '10',
105		- 'field' => '30',
	104	+ 'label' => '10',
	105	+ 'field' => '30',
	106	+ ),
106	107	),
107		- ),
108		- 'useTabs' => true,
109		- 'tabDefs' =>
110		- array (
	108	+ 'useTabs' => true,
	109	+ 'tabDefs' =>
	110	+ array (
111	111	'LBL_PROSPECT_INFORMATION' =>
112	112	array (
113		- 'newTab' => true,
114		- 'panelDefault' => 'expanded',
	113	+ 'newTab' => true,
	114	+ 'panelDefault' => 'expanded',
115	115	),
116	116	'LBL_MORE_INFORMATION' =>
117	117	array (
118		- 'newTab' => true,
119		- 'panelDefault' => 'expanded',
	118	+ 'newTab' => true,
	119	+ 'panelDefault' => 'expanded',
120	120	),
121	121	'LBL_PANEL_ASSIGNMENT' =>
122	122	array (
123		- 'newTab' => true,
124		- 'panelDefault' => 'expanded',
	123	+ 'newTab' => true,
	124	+ 'panelDefault' => 'expanded',
	125	+ ),
125	126	),
126		- ),
127	127	),
128	128	'panels' =>
129	129	array (
130		- 'lbl_prospect_information' =>
131		- array (
	130	+ 'lbl_prospect_information' =>
	131	+ array (
132	132	0 =>
133	133	array (
134		- 0 =>
135		- array (
	134	+ 0 =>
	135	+ array (
136	136	'name' => 'full_name',
137		- ),
	137	+ ),
138	138	),
139	139	1 =>
140	140	array (
141		- 0 => 'title',
142		- 1 =>
143		- array (
	141	+ 0 => 'title',
	142	+ 1 =>
	143	+ array (
144	144	'name' => 'phone_work',
145	145	'label' => 'LBL_OFFICE_PHONE',
146		- ),
	146	+ ),
147	147	),
148	148	2 =>
149	149	array (
150		- 0 => 'department',
151		- 1 => 'phone_mobile',
	150	+ 0 => 'department',
	151	+ 1 => 'phone_mobile',
152	152	),
153	153	3 =>
154	154	array (
155		- 0 =>
156		- array (
	155	+ 0 =>
	156	+ array (
157	157	'name' => 'account_name',
158		- ),
159		- 1 => 'phone_fax',
	158	+ ),
	159	+ 1 => 'phone_fax',
160	160	),
161	161	4 =>
162	162	array (
163		- 0 =>
164		- array (
	163	+ 0 =>
	164	+ array (
165	165	'name' => 'primary_address_street',
166	166	'label' => 'LBL_PRIMARY_ADDRESS',
167	167	'type' => 'address',
168	168	'displayParams' =>
169	169	array (
170		- 'key' => 'primary',
	170	+ 'key' => 'primary',
	171	+ ),
171	172	),
172		- ),
173		- 1 =>
174		- array (
	173	+ 1 =>
	174	+ array (
175	175	'name' => 'alt_address_street',
176	176	'label' => 'LBL_ALTERNATE_ADDRESS',
177	177	'type' => 'address',
178	178	'displayParams' =>
179	179	array (
180		- 'key' => 'alt',
	180	+ 'key' => 'alt',
	181	+ ),
181	182	),
182		- ),
183	183	),
184	184	5 =>
185	185	array (
186		- 0 => 'email1',
	186	+ 0 => 'email1',
187	187	),
188	188	6 =>
189	189	array (
190		- 0 => 'description',
	190	+ 0 => 'description',
191	191	),
192	192	7 =>
193	193	array (
194		- 0 => 'assigned_user_name',
	194	+ 0 => 'assigned_user_name',
195	195	),
196		- ),
197		- 'LBL_MORE_INFORMATION' =>
198		- array (
	196	+ ),
	197	+ 'LBL_MORE_INFORMATION' =>
	198	+ array (
199	199	0 =>
200	200	array (
201		- 0 => 'email_opt_out',
202		- 1 => 'do_not_call',
	201	+ 0 => 'email_opt_out',
	202	+ 1 => 'do_not_call',
	203	+ ),
203	204	),
204		- ),
205		- 'LBL_PANEL_ASSIGNMENT' =>
206		- array (
	205	+ 'LBL_PANEL_ASSIGNMENT' =>
	206	+ array (
207	207	0 =>
208	208	array (
209		- 0 =>
210		- array (
	209	+ 0 =>
	210	+ array (
211	211	'name' => 'modified_by_name',
212	212	'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value} ',
213	213	'label' => 'LBL_DATE_MODIFIED',
214		- ),
215		- 1 =>
216		- array (
	214	+ ),
	215	+ 1 =>
	216	+ array (
217	217	'name' => 'created_by_name',
218	218	'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value} ',
219	219	'label' => 'LBL_DATE_ENTERED',
220		- ),
	220	+ ),
221	221	),
222		- ),
	222	+ ),
	223	+ ),
223	224	),
224		- ),
225	225	);
226	226	?>

		@@ -42,10 +42,10 @@ discard block
		block discarded – undo
42	42
43	43
44	44	$listViewDefs['Prospects'] = array(
45		- 'FULL_NAME' => array(
46		- 'width' => '20',
47		- 'label' => 'LBL_LIST_NAME',
48		- 'link' => true,
	45	+ 'FULL_NAME' => array(
	46	+ 'width' => '20',
	47	+ 'label' => 'LBL_LIST_NAME',
	48	+ 'link' => true,
49	49	'related_fields' => array('first_name', 'last_name'),
50	50	'orderBy' => 'last_name',
51	51	'default' => true),
		@@ -65,11 +65,11 @@ discard block
		block discarded – undo
65	65	'label' => 'LBL_LIST_PHONE',
66	66	'link' => false,
67	67	'default' => true),
68		- 'DATE_ENTERED' => array (
69		- 'type' => 'datetime',
70		- 'label' => 'LBL_DATE_ENTERED',
71		- 'width' => '10',
72		- 'default' => true,
73		- ),
	68	+ 'DATE_ENTERED' => array (
	69	+ 'type' => 'datetime',
	70	+ 'label' => 'LBL_DATE_ENTERED',
	71	+ 'width' => '10',
	72	+ 'default' => true,
	73	+ ),
74	74	);
75	75	?>

		@@ -45,12 +45,12 @@
		block discarded – undo
45	45	require_once('include/formbase.php');
46	46	if (!empty($_REQUEST['record'])) {
47	47
48		- $document = new Document();
49		- $document->retrieve($_REQUEST['record']);
50		- if (!empty($document->document_revision_id) && !empty($_REQUEST['get_latest_for_id'])) {
51		- $query="update linked_documents set document_revision_id='{$document->document_revision_id}', date_modified='".TimeDate::getInstance()->nowDb()."' where id ='{$_REQUEST['get_latest_for_id']}' ";
52		- $document->db->query($query);
53		- }
	48	+ $document = new Document();
	49	+ $document->retrieve($_REQUEST['record']);
	50	+ if (!empty($document->document_revision_id) && !empty($_REQUEST['get_latest_for_id'])) {
	51	+ $query="update linked_documents set document_revision_id='{$document->document_revision_id}', date_modified='".TimeDate::getInstance()->nowDb()."' where id ='{$_REQUEST['get_latest_for_id']}' ";
	52	+ $document->db->query($query);
	53	+ }
54	54	}
55	55	handleRedirect();
56	56	?>

		@@ -1,6 +1,6 @@
		block discarded – undo
1	1	<?php
2	2	if(!defined('sugarEntry') \|\| !sugarEntry)
3		- die('Not A Valid Entry Point');
	3	+ die('Not A Valid Entry Point');
4	4	/*********************************************************************************
5	5	* SugarCRM Community Edition is a customer relationship management program developed by
6	6	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

		@@ -1,131 +1,131 @@
		block discarded – undo
1	1	<?php
2	2	$viewdefs ['Documents'] =
3	3	array (
4		- 'EditView' =>
5		- array (
	4	+ 'EditView' =>
	5	+ array (
6	6	'templateMeta' =>
7	7	array (
8		- 'form' =>
9		- array (
	8	+ 'form' =>
	9	+ array (
10	10	'enctype' => 'multipart/form-data',
11	11	'hidden' =>
12	12	array (
13		- 0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
14		- 1 => '<input type="hidden" name="contract_id" value="{$smarty.request.contract_id}">',
	13	+ 0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
	14	+ 1 => '<input type="hidden" name="contract_id" value="{$smarty.request.contract_id}">',
15	15	),
16		- ),
17		- 'maxColumns' => '2',
18		- 'widths' =>
19		- array (
	16	+ ),
	17	+ 'maxColumns' => '2',
	18	+ 'widths' =>
	19	+ array (
20	20	0 =>
21	21	array (
22		- 'label' => '10',
23		- 'field' => '30',
	22	+ 'label' => '10',
	23	+ 'field' => '30',
24	24	),
25	25	1 =>
26	26	array (
27		- 'label' => '10',
28		- 'field' => '30',
	27	+ 'label' => '10',
	28	+ 'field' => '30',
29	29	),
30		- ),
31		- 'javascript' => '{sugar_getscript file="include/javascript/popup_parent_helper.js"}
	30	+ ),
	31	+ 'javascript' => '{sugar_getscript file="include/javascript/popup_parent_helper.js"}
32	32	{sugar_getscript file="cache/include/javascript/sugar_grp_jsolait.js"}
33	33	{sugar_getscript file="modules/Documents/documents.js"}',
34		- 'useTabs' => false,
35		- 'tabDefs' =>
36		- array (
	34	+ 'useTabs' => false,
	35	+ 'tabDefs' =>
	36	+ array (
37	37	'LBL_DOCUMENT_INFORMATION' =>
38	38	array (
39		- 'newTab' => false,
40		- 'panelDefault' => 'expanded',
	39	+ 'newTab' => false,
	40	+ 'panelDefault' => 'expanded',
	41	+ ),
41	42	),
42		- ),
43	43	),
44	44	'panels' =>
45	45	array (
46		- 'lbl_document_information' =>
47		- array (
	46	+ 'lbl_document_information' =>
	47	+ array (
48	48	0 =>
49	49	array (
50		- 0 =>
51		- array (
	50	+ 0 =>
	51	+ array (
52	52	'name' => 'filename',
53	53	'displayParams' =>
54	54	array (
55		- 'onchangeSetFileNameTo' => 'document_name',
	55	+ 'onchangeSetFileNameTo' => 'document_name',
	56	+ ),
56	57	),
57		- ),
58		- 1 =>
59		- array (
	58	+ 1 =>
	59	+ array (
60	60	'name' => 'status_id',
61	61	'label' => 'LBL_DOC_STATUS',
62		- ),
	62	+ ),
63	63	),
64	64	1 =>
65	65	array (
66		- 0 => 'document_name',
67		- 1 =>
68		- array (
	66	+ 0 => 'document_name',
	67	+ 1 =>
	68	+ array (
69	69	'name' => 'revision',
70	70	'customCode' => '<input name="revision" type="text" value="{$fields.revision.value}" {$DISABLED}>',
71		- ),
	71	+ ),
72	72	),
73	73	2 =>
74	74	array (
75		- 0 =>
76		- array (
	75	+ 0 =>
	76	+ array (
77	77	'name' => 'template_type',
78	78	'label' => 'LBL_DET_TEMPLATE_TYPE',
79		- ),
80		- 1 =>
81		- array (
	79	+ ),
	80	+ 1 =>
	81	+ array (
82	82	'name' => 'is_template',
83	83	'label' => 'LBL_DET_IS_TEMPLATE',
84		- ),
	84	+ ),
85	85	),
86	86	3 =>
87	87	array (
88		- 0 =>
89		- array (
	88	+ 0 =>
	89	+ array (
90	90	'name' => 'active_date',
91		- ),
92		- 1 => 'exp_date',
	91	+ ),
	92	+ 1 => 'exp_date',
93	93	),
94	94	4 =>
95	95	array (
96		- 0 => 'category_id',
97		- 1 => 'subcategory_id',
	96	+ 0 => 'category_id',
	97	+ 1 => 'subcategory_id',
98	98	),
99	99	5 =>
100	100	array (
101		- 0 =>
102		- array (
	101	+ 0 =>
	102	+ array (
103	103	'name' => 'description',
104		- ),
	104	+ ),
105	105	),
106	106	6 =>
107	107	array (
108		- 0 =>
109		- array (
	108	+ 0 =>
	109	+ array (
110	110	'name' => 'related_doc_name',
111	111	'customCode' => '<input name="related_document_name" type="text" size="30" maxlength="255" value="{$RELATED_DOCUMENT_NAME}" readonly><input name="related_doc_id" type="hidden" value="{$fields.related_doc_id.value}"/> <input title="{$APP.LBL_SELECT_BUTTON_TITLE}" type="{$RELATED_DOCUMENT_BUTTON_AVAILABILITY}" class="button" value="{$APP.LBL_SELECT_BUTTON_LABEL}" name="btn2" onclick=\'open_popup("Documents", 600, 400, "", true, false, {$encoded_document_popup_request_data}, "single", true);\'/>',
112		- ),
113		- 1 =>
114		- array (
	112	+ ),
	113	+ 1 =>
	114	+ array (
115	115	'name' => 'related_doc_rev_number',
116	116	'customCode' => '<select name="related_doc_rev_id" id="related_doc_rev_id" {$RELATED_DOCUMENT_REVISION_DISABLED}>{$RELATED_DOCUMENT_REVISION_OPTIONS}</select>',
117		- ),
	117	+ ),
118	118	),
119	119	7 =>
120	120	array (
121		- 0 =>
122		- array (
	121	+ 0 =>
	122	+ array (
123	123	'name' => 'assigned_user_name',
124	124	'label' => 'LBL_ASSIGNED_TO_NAME',
125		- ),
	125	+ ),
	126	+ ),
126	127	),
127		- ),
128	128	),
129		- ),
	129	+ ),
130	130	);
131	131	?>

		@@ -1,88 +1,88 @@
		block discarded – undo
1	1	<?php
2	2	$searchdefs ['Documents'] =
3	3	array (
4		- 'layout' =>
5		- array (
	4	+ 'layout' =>
	5	+ array (
6	6	'basic_search' =>
7	7	array (
8		- 0 => 'document_name',
9		- 1 => array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
	8	+ 0 => 'document_name',
	9	+ 1 => array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
10	10	),
11	11	'advanced_search' =>
12	12	array (
13		- 'document_name' =>
14		- array (
	13	+ 'document_name' =>
	14	+ array (
15	15	'name' => 'document_name',
16	16	'default' => true,
17	17	'width' => '10%',
18		- ),
19		- 'status' =>
20		- array (
	18	+ ),
	19	+ 'status' =>
	20	+ array (
21	21	'type' => 'varchar',
22	22	'label' => 'LBL_DOC_STATUS',
23	23	'width' => '10%',
24	24	'default' => true,
25	25	'name' => 'status',
26		- ),
27		- 'template_type' =>
28		- array (
	26	+ ),
	27	+ 'template_type' =>
	28	+ array (
29	29	'type' => 'enum',
30	30	'label' => 'LBL_TEMPLATE_TYPE',
31	31	'width' => '10%',
32	32	'default' => true,
33	33	'name' => 'template_type',
34		- ),
35		- 'category_id' =>
36		- array (
	34	+ ),
	35	+ 'category_id' =>
	36	+ array (
37	37	'name' => 'category_id',
38	38	'default' => true,
39	39	'width' => '10%',
40		- ),
41		- 'subcategory_id' =>
42		- array (
	40	+ ),
	41	+ 'subcategory_id' =>
	42	+ array (
43	43	'name' => 'subcategory_id',
44	44	'default' => true,
45	45	'width' => '10%',
46		- ),
47		- 'assigned_user_id' =>
48		- array (
	46	+ ),
	47	+ 'assigned_user_id' =>
	48	+ array (
49	49	'name' => 'assigned_user_id',
50	50	'type' => 'enum',
51	51	'label' => 'LBL_ASSIGNED_TO',
52	52	'function' =>
53	53	array (
54		- 'name' => 'get_user_array',
55		- 'params' =>
56		- array (
	54	+ 'name' => 'get_user_array',
	55	+ 'params' =>
	56	+ array (
57	57	0 => false,
58		- ),
	58	+ ),
59	59	),
60	60	'default' => true,
61	61	'width' => '10%',
62		- ),
63		- 'active_date' =>
64		- array (
	62	+ ),
	63	+ 'active_date' =>
	64	+ array (
65	65	'name' => 'active_date',
66	66	'default' => true,
67	67	'width' => '10%',
68		- ),
69		- 'exp_date' =>
70		- array (
	68	+ ),
	69	+ 'exp_date' =>
	70	+ array (
71	71	'name' => 'exp_date',
72	72	'default' => true,
73	73	'width' => '10%',
74		- ),
	74	+ ),
	75	+ ),
75	76	),
76		- ),
77		- 'templateMeta' =>
78		- array (
	77	+ 'templateMeta' =>
	78	+ array (
79	79	'maxColumns' => '3',
80	80	'maxColumnsBasic' => '4',
81	81	'widths' =>
82	82	array (
83		- 'label' => '10',
84		- 'field' => '30',
	83	+ 'label' => '10',
	84	+ 'field' => '30',
	85	+ ),
85	86	),
86		- ),
87	87	);
88	88	?>

		@@ -3,36 +3,36 @@ discard block
		block discarded – undo
3	3	global $current_user;
4	4	$module_name = "Documents";
5	5	$searchFields['Documents'] = array (
6		- 'document_name' =>
7		- array (
	6	+ 'document_name' =>
	7	+ array (
8	8	'query_type' => 'default',
9		- ),
10		- 'category_id' =>
11		- array (
	9	+ ),
	10	+ 'category_id' =>
	11	+ array (
12	12	'query_type' => 'default',
13	13	'options' => 'document_category_dom',
14	14	'template_var' => 'CATEGORY_OPTIONS',
15		- ),
16		- 'subcategory_id' =>
17		- array (
	15	+ ),
	16	+ 'subcategory_id' =>
	17	+ array (
18	18	'query_type' => 'default',
19	19	'options' => 'document_subcategory_dom',
20	20	'template_var' => 'SUBCATEGORY_OPTIONS',
21		- ),
22		- 'active_date' =>
23		- array (
	21	+ ),
	22	+ 'active_date' =>
	23	+ array (
24	24	'query_type' => 'default',
25		- ),
26		- 'exp_date' =>
27		- array (
	25	+ ),
	26	+ 'exp_date' =>
	27	+ array (
28	28	'query_type' => 'default',
29		- ),
30		- 'assigned_user_id' =>
31		- array (
	29	+ ),
	30	+ 'assigned_user_id' =>
	31	+ array (
32	32	'query_type' => 'default',
33		- ),
34		- 'filename' =>
35		- array (
	33	+ ),
	34	+ 'filename' =>
	35	+ array (
36	36	'query_type' => 'format',
37	37	'operator' => 'subquery',
38	38	'subquery' => 'SELECT document_revisions.id FROM document_revisions
		@@ -40,45 +40,45 @@ discard block
		block discarded – undo
40	40	AND document_revisions.filename LIKE \'{0}\'',
41	41	'db_field' =>
42	42	array (
43		- 0 => 'document_revision_id',
	43	+ 0 => 'document_revision_id',
44	44	),
45		- ),
46		- 'range_date_entered' =>
47		- array (
	45	+ ),
	46	+ 'range_date_entered' =>
	47	+ array (
48	48	'query_type' => 'default',
49	49	'enable_range_search' => true,
50	50	'is_date_field' => true,
51		- ),
52		- 'start_range_date_entered' =>
53		- array (
	51	+ ),
	52	+ 'start_range_date_entered' =>
	53	+ array (
54	54	'query_type' => 'default',
55	55	'enable_range_search' => true,
56	56	'is_date_field' => true,
57		- ),
58		- 'end_range_date_entered' =>
59		- array (
	57	+ ),
	58	+ 'end_range_date_entered' =>
	59	+ array (
60	60	'query_type' => 'default',
61	61	'enable_range_search' => true,
62	62	'is_date_field' => true,
63		- ),
64		- 'range_date_modified' =>
65		- array (
	63	+ ),
	64	+ 'range_date_modified' =>
	65	+ array (
66	66	'query_type' => 'default',
67	67	'enable_range_search' => true,
68	68	'is_date_field' => true,
69		- ),
70		- 'start_range_date_modified' =>
71		- array (
	69	+ ),
	70	+ 'start_range_date_modified' =>
	71	+ array (
72	72	'query_type' => 'default',
73	73	'enable_range_search' => true,
74	74	'is_date_field' => true,
75		- ),
76		- 'end_range_date_modified' =>
77		- array (
	75	+ ),
	76	+ 'end_range_date_modified' =>
	77	+ array (
78	78	'query_type' => 'default',
79	79	'enable_range_search' => true,
80	80	'is_date_field' => true,
81		- ),
	81	+ ),
82	82	'favorites_only' => array(
83	83	'query_type'=>'format',
84	84	'operator' => 'subquery',

		@@ -39,140 +39,140 @@
		block discarded – undo
39	39
40	40	$viewdefs ['Documents'] =
41	41	array (
42		- 'DetailView' =>
43		- array (
	42	+ 'DetailView' =>
	43	+ array (
44	44	'templateMeta' =>
45	45	array (
46		- 'maxColumns' => '2',
47		- 'form' =>
48		- array (
	46	+ 'maxColumns' => '2',
	47	+ 'form' =>
	48	+ array (
49	49	'hidden' =>
50	50	array (
51		- 0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
	51	+ 0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
52	52	),
53		- ),
54		- 'widths' =>
55		- array (
	53	+ ),
	54	+ 'widths' =>
	55	+ array (
56	56	0 =>
57	57	array (
58		- 'label' => '10',
59		- 'field' => '30',
	58	+ 'label' => '10',
	59	+ 'field' => '30',
60	60	),
61	61	1 =>
62	62	array (
63		- 'label' => '10',
64		- 'field' => '30',
	63	+ 'label' => '10',
	64	+ 'field' => '30',
65	65	),
66		- ),
67		- 'useTabs' => true,
68		- 'tabDefs' =>
69		- array (
	66	+ ),
	67	+ 'useTabs' => true,
	68	+ 'tabDefs' =>
	69	+ array (
70	70	'LBL_DOCUMENT_INFORMATION' =>
71	71	array (
72		- 'newTab' => true,
73		- 'panelDefault' => 'expanded',
	72	+ 'newTab' => true,
	73	+ 'panelDefault' => 'expanded',
74	74	),
75	75	'LBL_PANEL_ASSIGNMENT' =>
76	76	array (
77		- 'newTab' => true,
78		- 'panelDefault' => 'expanded',
	77	+ 'newTab' => true,
	78	+ 'panelDefault' => 'expanded',
	79	+ ),
79	80	),
80		- ),
81	81	),
82	82	'panels' =>
83	83	array (
84		- 'lbl_document_information' =>
85		- array (
	84	+ 'lbl_document_information' =>
	85	+ array (
86	86	0 =>
87	87	array (
88		- 0 =>
89		- array (
	88	+ 0 =>
	89	+ array (
90	90	'name' => 'filename',
91	91	'displayParams' =>
92	92	array (
93		- 'link' => 'filename',
94		- 'id' => 'document_revision_id',
	93	+ 'link' => 'filename',
	94	+ 'id' => 'document_revision_id',
	95	+ ),
95	96	),
96		- ),
97		- 1 =>
98		- array (
	97	+ 1 =>
	98	+ array (
99	99	'name' => 'status_id',
100	100	'label' => 'LBL_DOC_STATUS',
101		- ),
	101	+ ),
102	102	),
103	103	1 =>
104	104	array (
105		- 0 =>
106		- array (
	105	+ 0 =>
	106	+ array (
107	107	'name' => 'document_name',
108	108	'label' => 'LBL_DOC_NAME',
109		- ),
110		- 1 =>
111		- array (
	109	+ ),
	110	+ 1 =>
	111	+ array (
112	112	'name' => 'revision',
113	113	'label' => 'LBL_DOC_VERSION',
114		- ),
	114	+ ),
115	115	),
116	116	2 =>
117	117	array (
118		- 0 =>
119		- array (
	118	+ 0 =>
	119	+ array (
120	120	'name' => 'template_type',
121	121	'label' => 'LBL_DET_TEMPLATE_TYPE',
122		- ),
123		- 1 =>
124		- array (
	122	+ ),
	123	+ 1 =>
	124	+ array (
125	125	'name' => 'is_template',
126	126	'label' => 'LBL_DET_IS_TEMPLATE',
127		- ),
	127	+ ),
128	128	),
129	129	3 =>
130	130	array (
131		- 0 => 'active_date',
132		- 1 => 'exp_date',
	131	+ 0 => 'active_date',
	132	+ 1 => 'exp_date',
133	133	),
134	134	4 =>
135	135	array (
136		- 0 => 'category_id',
137		- 1 => 'subcategory_id',
	136	+ 0 => 'category_id',
	137	+ 1 => 'subcategory_id',
138	138	),
139	139	5 =>
140	140	array (
141		- 0 => '',
142		- 1 => '',
	141	+ 0 => '',
	142	+ 1 => '',
143	143	),
144	144	6 =>
145	145	array (
146		- 0 => 'related_doc_name',
147		- 1 => 'related_doc_rev_number',
	146	+ 0 => 'related_doc_name',
	147	+ 1 => 'related_doc_rev_number',
148	148	),
149	149	7 =>
150	150	array (
151		- 0 =>
152		- array (
	151	+ 0 =>
	152	+ array (
153	153	'name' => 'assigned_user_name',
154	154	'label' => 'LBL_ASSIGNED_TO_NAME',
155		- ),
	155	+ ),
156	156	),
157		- ),
158		- 'LBL_PANEL_ASSIGNMENT' =>
159		- array (
	157	+ ),
	158	+ 'LBL_PANEL_ASSIGNMENT' =>
	159	+ array (
160	160	0 =>
161	161	array (
162		- 0 =>
163		- array (
164		- 'name' => 'date_entered',
165		- 'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
166		- ),
167		- 1 =>
168		- array (
169		- 'name' => 'date_modified',
170		- 'label' => 'LBL_DATE_MODIFIED',
171		- 'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',
172		- ),
173		- ),
174		- ),
	162	+ 0 =>
	163	+ array (
	164	+ 'name' => 'date_entered',
	165	+ 'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
	166	+ ),
	167	+ 1 =>
	168	+ array (
	169	+ 'name' => 'date_modified',
	170	+ 'label' => 'LBL_DATE_MODIFIED',
	171	+ 'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',
	172	+ ),
	173	+ ),
	174	+ ),
	175	+ ),
175	176	),
176		- ),
177	177	);
178	178	?>

adamjakab / SuiteCRM

Push — scrutinizer-code-quality ( eedb15...27193c )

Status

Category

Indentation +85 added lines, -85 removed lines patch added patch discarded remove patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +61 added lines, -61 removed lines patch added patch discarded remove patch

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +72 added lines, -72 removed lines patch added patch discarded remove patch