Inspection of "Merge branch 'develop' into console-installer" - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — console-installer ( 3d54e5...e2b50d )

by Adam

created 2016-05-10 07:51 UTC

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,8 +1,8 @@  discard block
 block discarded – undo
 <?php
 $listViewDefs ['ProjectTask'] = 
-array (
+array(
   'NAME' => 
-  array (
+  array(
     'width' => '40%',
     'label' => 'LBL_LIST_NAME',
     'link' => true,
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
     'sortable' => true,
   ),
   'PROJECT_NAME' => 
-  array (
+  array(
     'width' => '25%',
     'label' => 'LBL_PROJECT_NAME',
     'id' => 'PROJECT_ID',
@@ -20,26 +20,26 @@  discard block
 block discarded – undo
     'module' => 'Project',
     'ACLTag' => 'PROJECT',
     'related_fields' => 
-    array (
+    array(
       0 => 'project_id',
     ),
   ),
   'DATE_START' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_DATE_START',
     'default' => true,
     'sortable' => true,
   ),
   'DATE_FINISH' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_DATE_FINISH',
     'default' => true,
     'sortable' => true,
   ),
   'ASSIGNED_USER_NAME' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_ASSIGNED_USER_ID',
     'module' => 'Employees',
@@ -47,14 +47,14 @@  discard block
 block discarded – undo
     'default' => true,
   ),
   'PRIORITY' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_PRIORITY',
     'default' => true,
     'sortable' => true,
   ),
   'PERCENT_COMPLETE' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_PERCENT_COMPLETE',
     'default' => true,

Please login to merge, or discard this patch.

modules/Calls/SubPanelViewInvitees.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
 
 // Stick the form header out there.
 echo get_form_header($mod_strings['LBL_INVITEES'], $button, false);
-$xtpl=new XTemplate ('modules/Calls/SubPanelViewInvitees.html');
+$xtpl = new XTemplate('modules/Calls/SubPanelViewInvitees.html');
 $xtpl->assign("MOD", $mod_strings);
 $xtpl->assign("APP", $app_strings);
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 $xtpl->assign("CALL_ID", $focus->id);
 
 $oddRow = true;
-foreach($focus_users_list as $user)
+foreach ($focus_users_list as $user)
 {
 	$user_fields = array(
 		'USER_NAME' => $user->user_name,
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
 
 	$xtpl->assign("USER", $user_fields);
 
-	if($oddRow)
+	if ($oddRow)
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'oddListRow');
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
 $xtpl->out("users");
 
 $oddRow = true;
-foreach($focus_contacts_list as $contact)
+foreach ($focus_contacts_list as $contact)
 {
 	$contact_fields = array(
 		'FIRST_NAME' => $contact->first_name,
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 
 	$xtpl->assign("CONTACT", $contact_fields);
 
-	if($oddRow)
+	if ($oddRow)
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'oddListRow');

Please login to merge, or discard this patch.

modules/Calls/metadata/additionalDetails.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -42,56 +42,56 @@  discard block
 block discarded – undo
 function additionalDetailsCall($fields) {
     global $timedate;
 	static $mod_strings;
-	if(empty($mod_strings)) {
+	if (empty($mod_strings)) {
 		global $current_language;
 		$mod_strings = return_module_language($current_language, 'Calls');
 	}
     $overlib_string = '';
     $overlib_string .= '<input id="type" type="hidden" value="Call"/>';
 
-    if(!empty($fields['ID'])) {
-        $overlib_string .= '<input id="id" type="hidden" value="'. $fields['ID'];
+    if (!empty($fields['ID'])) {
+        $overlib_string .= '<input id="id" type="hidden" value="'.$fields['ID'];
         $overlib_string .= '"/>';
     }
 
-    $overlib_string .= '<h2><img src="index.php?entryPoint=getImage&themeName=' . SugarThemeRegistry::current()->name .'&imageName=Calls.gif"/> '.$mod_strings['LBL_CALL'].'</h2>';
+    $overlib_string .= '<h2><img src="index.php?entryPoint=getImage&themeName='.SugarThemeRegistry::current()->name.'&imageName=Calls.gif"/> '.$mod_strings['LBL_CALL'].'</h2>';
 
-   if(!empty($fields['NAME'])) {
-        	$overlib_string .= '<b>'. $mod_strings['LBL_SUBJECT'] . '</b> ';
+   if (!empty($fields['NAME'])) {
+        	$overlib_string .= '<b>'.$mod_strings['LBL_SUBJECT'].'</b> ';
             $url = 'index.php?action=DetailView&module=Calls&record='.$fields['ID'];
-            $overlib_string .= '<a href="'.$url.'">' . $fields['NAME'] . '</a>';
+            $overlib_string .= '<a href="'.$url.'">'.$fields['NAME'].'</a>';
         	$overlib_string .= '<br>';
     }
-	if(!empty($fields['DATE_START'])) {
+	if (!empty($fields['DATE_START'])) {
         $data_date = $timedate->fromUser($fields['DATE_START'])->format('Y-m-d H:i:s');
-        $overlib_string .= '<span data-field="DATE_START" data-date="' . $data_date . '">';
-        $overlib_string .= '<b>' . $mod_strings['LBL_DATE_TIME'] . '</b> ' . $fields['DATE_START'] . ' <br>';
+        $overlib_string .= '<span data-field="DATE_START" data-date="'.$data_date.'">';
+        $overlib_string .= '<b>'.$mod_strings['LBL_DATE_TIME'].'</b> '.$fields['DATE_START'].' <br>';
         $overlib_string .= '</span>';
     }
-	if(isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DURATION'] . '</b> ';
-        if(isset($fields['DURATION_HOURS'])) {
-            $overlib_string .= $fields['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'] . ' ';
+	if (isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) {
+		$overlib_string .= '<b>'.$mod_strings['LBL_DURATION'].'</b> ';
+        if (isset($fields['DURATION_HOURS'])) {
+            $overlib_string .= $fields['DURATION_HOURS'].$mod_strings['LBL_HOURS_ABBREV'].' ';
         }
-        if(isset($fields['DURATION_MINUTES'])) {
-            $overlib_string .=  $fields['DURATION_MINUTES'] . $mod_strings['LBL_MINSS_ABBREV'];
+        if (isset($fields['DURATION_MINUTES'])) {
+            $overlib_string .= $fields['DURATION_MINUTES'].$mod_strings['LBL_MINSS_ABBREV'];
         }
-        $overlib_string .=  '<br>';
+        $overlib_string .= '<br>';
 	}
     if (!empty($fields['PARENT_ID']))
     {
-            $overlib_string .= "<b>". $mod_strings['LBL_RELATED_TO'] . "</b> ".
+            $overlib_string .= "<b>".$mod_strings['LBL_RELATED_TO']."</b> ".
                     "<a href='index.php?module=".$fields['PARENT_TYPE']."&action=DetailView&record=".$fields['PARENT_ID']."'>".
-                    $fields['PARENT_NAME'] . "</a>";
+                    $fields['PARENT_NAME']."</a>";
             $overlib_string .= '<br>';
     }
-    if(!empty($fields['STATUS'])) {
-      	$overlib_string .= '<b>'. $mod_strings['LBL_STATUS'] . '</b> ' . $fields['STATUS'];
+    if (!empty($fields['STATUS'])) {
+      	$overlib_string .= '<b>'.$mod_strings['LBL_STATUS'].'</b> '.$fields['STATUS'];
       	$overlib_string .= '<br>';
       }
-	if(!empty($fields['DESCRIPTION'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+	if (!empty($fields['DESCRIPTION'])) {
+		$overlib_string .= '<b>'.$mod_strings['LBL_DESCRIPTION'].'</b> '.substr($fields['DESCRIPTION'], 0, 300);
+		if (strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
 		$overlib_string .= '<br>';
 	}
     $overlib_string .= '<br>';

Please login to merge, or discard this patch.

modules/Calls/metadata/editviewdefs.php 1 patch

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -38,19 +38,19 @@  discard block
 block discarded – undo
  ********************************************************************************/
 
 $viewdefs ['Calls'] =
-array (
+array(
   'EditView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
         'includes' => array(
             array('file' => 'modules/Reminders/Reminders.js'),
         ),
       'maxColumns' => '2',
       'form' => 
-      array (
+      array(
         'hidden' => 
-        array (
+        array(
           0 => '<input type="hidden" name="isSaveAndNew" value="false">',
           1 => '<input type="hidden" name="send_invites">',
           2 => '<input type="hidden" name="user_invitees">',
@@ -58,48 +58,48 @@  discard block
 block discarded – undo
           4 => '<input type="hidden" name="contact_invitees">',
         ),
         'buttons' => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_HEADER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
           ),
           1 => 'CANCEL',
           2 => 
-          array (
+          array(
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_HEADER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
           ),
           3 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_HEADER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
           ),
         ),
         'buttons_footer' => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_FOOTER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
           ),
           1 => 'CANCEL',
           2 => 
-          array (
+          array(
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_FOOTER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
           ),
           3 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_FOOTER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
           ),
         ),
         'footerTpl' => 'modules/Calls/tpls/footer.tpl',
       ),
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
@@ -110,61 +110,61 @@  discard block
 block discarded – undo
 function formSubmitCheck(){ldelim}var duration=true;if(typeof(isValidDuration)!="undefined"){ldelim}duration=isValidDuration();{rdelim}if(check_form(\'EditView\') && duration){ldelim}SUGAR.ajaxUI.submitForm("EditView");{rdelim}{rdelim}</script>',
       'useTabs' => false,
       'tabDefs' => 
-      array (
+      array(
         'LBL_CALL_INFORMATION' => 
-        array (
+        array(
           'newTab' => false,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'lbl_call_information' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'name',
           ),
           1 => 
-          array (
+          array(
             'name' => 'status',
             'fields' => 
-            array (
+            array(
               0 => 
-              array (
+              array(
                 'name' => 'direction',
               ),
               1 => 
-              array (
+              array(
                 'name' => 'status',
               ),
             ),
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_start',
             'displayParams' => 
-            array (
+            array(
               'updateCallback' => 'SugarWidgetScheduler.update_time();',
             ),
             'label' => 'LBL_DATE_TIME',
           ),
           1 => 
-          array (
+          array(
             'name' => 'parent_name',
             'label' => 'LBL_LIST_RELATED_TO',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration_hours',
             'label' => 'LBL_DURATION',
             'customCode' => '{literal}<script type="text/javascript">function isValidDuration() { form = document.getElementById(\'EditView\'); if ( form.duration_hours.value + form.duration_minutes.value <= 0 ) { alert(\'{/literal}{$MOD.NOTICE_DURATION_TIME}{literal}\'); return false; } return true; }</script>{/literal}<input id="duration_hours" name="duration_hours" size="2" maxlength="2" type="text" value="{$fields.duration_hours.value}" onkeyup="SugarWidgetScheduler.update_time();"/>{$fields.duration_minutes.value}&nbsp;<span class="dateFormat">{$MOD.LBL_HOURS_MINUTES}</span>',
@@ -178,25 +178,25 @@  discard block
 block discarded – undo
         ),
         3 => array(
             0 =>
-                array (
+                array(
                     'name' => 'reminders',
                     'customCode' => '{include file="modules/Reminders/tpls/reminders.tpl"}',
                     'label' => 'LBL_REMINDERS',
                 ),
         ),
         4 =>
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',
           ),
         ),
         5 =>
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
           ),

Please login to merge, or discard this patch.

modules/Calls/metadata/SearchFields.php 1 patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -39,33 +39,33 @@  discard block
 block discarded – undo
  ********************************************************************************/
 global $current_user;
 $module_name = "Calls";
-$searchFields['Calls'] = array (
+$searchFields['Calls'] = array(
   'name' =>
-  array (
+  array(
     'query_type' => 'default',
   ),
   'contact_name' => 
-  array (
+  array(
     'query_type' => 'default',
     'db_field' => 
-    array (
+    array(
       0 => 'contacts.first_name',
       1 => 'contacts.last_name',
     ),
   ),
   'date_start' => 
-  array (
+  array(
     'query_type' => 'default',
   ),
   'location' => 
-  array (
+  array(
     'query_type' => 'default',
   ),
   'current_user_only' => 
-  array (
+  array(
     'query_type' => 'default',
     'db_field' => 
-    array (
+    array(
       0 => 'assigned_user_id',
     ),
     'my_items' => true,
@@ -73,98 +73,98 @@  discard block
 block discarded – undo
     'type' => 'bool',
   ),
   'assigned_user_id' => 
-  array (
+  array(
     'query_type' => 'default',
   ),
   'status' => 
-  array (
+  array(
     'query_type' => 'default',
     'options' => 'call_status_dom',
     'template_var' => 'STATUS_FILTER',
   ),
   'open_only' => 
-  array (
+  array(
     'query_type' => 'default',
     'db_field' => 
-    array (
+    array(
       0 => 'status',
     ),
     'operator' => 'not in',
     'closed_values' => 
-    array (
+    array(
       0 => 'Held',
       1 => 'Not Held',
     ),
     'type' => 'bool',
   ),
   'range_date_entered' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_entered' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_entered' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'range_date_modified' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_modified' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_modified' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'range_date_start' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_start' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_start' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'range_date_end' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_end' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_end' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
@@ -175,6 +175,6 @@  discard block
 block discarded – undo
         'subquery' => 'SELECT favorites.parent_id FROM favorites
 			                    WHERE favorites.deleted = 0
 			                        and favorites.parent_type = "'.$module_name.'"
-			                        and favorites.assigned_user_id = "' .$current_user->id . '") OR NOT ({0}',
+			                        and favorites.assigned_user_id = "' .$current_user->id.'") OR NOT ({0}',
         'db_field'=>array('id')),
 );
\ No newline at end of file

Please login to merge, or discard this patch.

modules/Calls/metadata/detailviewdefs.php 1 patch

Spacing +43 added lines, -43 removed lines patch added patch discarded remove patch

@@ -39,27 +39,27 @@  discard block
 block discarded – undo
 
 
 $viewdefs ['Calls'] =
-array (
+array(
   'DetailView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'form' => 
-      array (
+      array(
         'buttons' => 
-        array (
+        array(
           0 => 'EDIT',
           1 => 'DUPLICATE',
           2 => 'DELETE',
           3 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSaveAndNew" value="false">  <input type="hidden" name="status" value="">  <input type="hidden" name="isSaveFromDetailView" value="true">  <input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}"   class="button"  onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_create_button" name="button"  value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}"  type="submit">{/if}',
             'sugar_html' => 
-            array (
+            array(
               'type' => 'submit',
               'value' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
               'htmlOptions' => 
-              array (
+              array(
                 'title' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
                 'class' => 'button',
                 'onclick' => 'this.form.isSaveFromDetailView.value=true; this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'',
@@ -70,14 +70,14 @@  discard block
 block discarded – undo
             ),
           ),
           4 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSave" value="false">  <input title="{$APP.LBL_CLOSE_BUTTON_TITLE}"  accesskey="{$APP.LBL_CLOSE_BUTTON_KEY}"  class="button"  onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isSave.value=true;this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_button" name="button1"  value="{$APP.LBL_CLOSE_BUTTON_TITLE}"  type="submit">{/if}',
             'sugar_html' => 
-            array (
+            array(
               'type' => 'submit',
               'value' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
               'htmlOptions' => 
-              array (
+              array(
                 'title' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
                 'accesskey' => '{$APP.LBL_CLOSE_BUTTON_KEY}',
                 'class' => 'button',
@@ -89,12 +89,12 @@  discard block
 block discarded – undo
             ),
           ),
           'SA_RESCHEDULE' => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"} <input title="{$MOD.LBL_RESCHEDULE}" class="button" onclick="get_form();" name="Reschedule" id="reschedule_button" value="{$MOD.LBL_RESCHEDULE}" type="button">{/if}',
           ),
         ),
         'hidden' => 
-        array (
+        array(
           0 => '<input type="hidden" name="isSaveAndNew">',
           1 => '<input type="hidden" name="status">',
           2 => '<input type="hidden" name="isSaveFromDetailView">',
@@ -104,82 +104,82 @@  discard block
 block discarded – undo
       ),
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'useTabs' => true,
       'includes' => 
-      array (
+      array(
         'SA_RESCHEDULE' => 
-        array (
+        array(
           'file' => 'modules/Calls_Reschedule/reschedule_form.js',
         ),
           array('file' => 'modules/Reminders/Reminders.js'),
       ),
       'tabDefs' => 
-      array (
+      array(
         'LBL_CALL_INFORMATION' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_RESCHEDULE_PANEL' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' =>
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'lbl_call_information' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'name',
             'label' => 'LBL_SUBJECT',
           ),
           1 => 
-          array (
+          array(
             'name' => 'direction',
             'customCode' => '{$fields.direction.options[$fields.direction.value]} {$fields.status.options[$fields.status.value]}',
             'label' => 'LBL_STATUS',
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_start',
             'customCode' => '{$fields.date_start.value} {$fields.time_start.value}&nbsp;',
             'label' => 'LBL_DATE_TIME',
           ),
           1 => 
-          array (
+          array(
             'name' => 'parent_name',
             'customLabel' => '{sugar_translate label=\'LBL_MODULE_NAME\' module=$fields.parent_type.value}',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration_hours',
             'customCode' => '{$fields.duration_hours.value}{$MOD.LBL_HOURS_ABBREV} {$fields.duration_minutes.value}{$MOD.LBL_MINSS_ABBREV}&nbsp;',
             'label' => 'LBL_DURATION',
@@ -196,18 +196,18 @@  discard block
 block discarded – undo
                 ),
         ),
         3 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',
           ),
         ),
         4 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'customCode' => '{$fields.assigned_user_name.value}',
             'label' => 'LBL_ASSIGNED_TO',
@@ -215,11 +215,11 @@  discard block
 block discarded – undo
         ),
       ),
       'lbl_reschedule_panel' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'reschedule_history',
             'comment' => 'Call duration, minutes portion',
             'label' => 'LBL_RESCHEDULE_HISTORY',
@@ -228,17 +228,17 @@  discard block
 block discarded – undo
         ),
       ),
       'LBL_PANEL_ASSIGNMENT' =>
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_entered',
             'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_ENTERED',
           ),
           1 => 
-          array (
+          array(
             'name' => 'date_modified',
             'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_MODIFIED',

Please login to merge, or discard this patch.

modules/Calls/metadata/quickcreatedefs.php 1 patch

Spacing +35 added lines, -35 removed lines patch added patch discarded remove patch

@@ -38,19 +38,19 @@  discard block
 block discarded – undo
  ********************************************************************************/
 
 $viewdefs ['Calls'] =
-array (
+array(
   'QuickCreate' =>
-  array (
+  array(
     'templateMeta' =>
-    array (
+    array(
         'includes' => array(
             array('file' => 'modules/Reminders/Reminders.js'),
         ),
       'maxColumns' => '2',
       'form' =>
-      array (
+      array(
         'hidden' =>
-        array (
+        array(
           0 => '<input type="hidden" name="isSaveAndNew" value="false">',
           1 => '<input type="hidden" name="send_invites">',
           2 => '<input type="hidden" name="user_invitees">',
@@ -58,95 +58,95 @@  discard block
 block discarded – undo
           4 => '<input type="hidden" name="contact_invitees">',
         ),
         'buttons' =>
-        array (
+        array(
           0 =>
-          array (
+          array(
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees();this.form.action.value=\'Save\'; this.form.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}this.form.return_id.value=\'\'; {/if}return check_form(\'EditView\') && isValidDuration();" type="submit" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
           ),
           1 => 'CANCEL',
           2 =>
-          array (
+          array(
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" class="button" onclick="this.form.send_invites.value=\'1\';SUGAR.calls.fill_invitees();this.form.action.value=\'Save\';this.form.return_action.value=\'EditView\';this.form.return_module.value=\'{$smarty.request.return_module}\';return check_form(\'EditView\') && isValidDuration();" type="submit" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
           ),
           3 =>
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" class="button" onclick="SUGAR.calls.fill_invitees(); this.form.status.value=\'Held\'; this.form.action.value=\'Save\'; this.form.return_module.value=\'Calls\'; this.form.isDuplicate.value=true; this.form.isSaveAndNew.value=true; this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'; return check_form(\'EditView\') && isValidDuration();" type="submit" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
           ),
         ),
       ),
       'widths' =>
-      array (
+      array(
         0 =>
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 =>
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'javascript' => '<script type="text/javascript">{$JSON_CONFIG_JAVASCRIPT}</script>'.
-                '{sugar_getscript file="cache/include/javascript/sugar_grp_jsolait.js"}' .
+                '{sugar_getscript file="cache/include/javascript/sugar_grp_jsolait.js"}'.
                 '<script>toggle_portal_flag();function toggle_portal_flag()  {literal} { {/literal} {$TOGGLE_JS} {literal} } {/literal} </script>',
 
       'useTabs' => false,
     ),
     'panels' =>
-    array (
+    array(
       'default' =>
-      array (
-        array (
-          array (
+      array(
+        array(
+          array(
             'name' => 'name',
             'displayParams' =>
-            array (
+            array(
               'required' => true,
             ),
           ),
-          array (
+          array(
             'name' => 'status',
             'displayParams' =>
-            array (
+            array(
               'required' => true,
             ),
             'fields' =>
-            array (
-              array (
+            array(
+              array(
                 'name' => 'direction',
               ),
-              array (
+              array(
                 'name' => 'status',
               ),
             ),
           ),
         ),
 
-        array (
-          array (
+        array(
+          array(
             'name' => 'date_start',
             'type' => 'datetimecombo',
             'displayParams' =>
-            array (
+            array(
               'required' => true,
               'updateCallback' => 'SugarWidgetScheduler.update_time();',
             ),
             'label' => 'LBL_DATE_TIME',
           ),
-          array (
+          array(
             'name' => 'parent_name',
             'label' => 'LBL_LIST_RELATED_TO',
           ),
         ),
 
-        array (
-          array (
+        array(
+          array(
             'name' => 'duration_hours',
             'label' => 'LBL_DURATION',
             'customCode' => '{literal}<script type="text/javascript">function isValidDuration() { form = document.getElementById(\'EditView\'); if ( form.duration_hours.value + form.duration_minutes.value <= 0 ) { alert(\'{/literal}{$MOD.NOTICE_DURATION_TIME}{literal}\'); return false; } return true; }</script>{/literal}<input id="duration_hours" name="duration_hours" tabindex="1" size="2" maxlength="2" type="text" value="{$fields.duration_hours.value}" onkeyup="SugarWidgetScheduler.update_time();"/>{$fields.duration_minutes.value}&nbsp;<span class="dateFormat">{$MOD.LBL_HOURS_MINUTES}',
             'displayParams' =>
-            array (
+            array(
               'required' => true,
             ),
           ),
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
 //            'customCode' => '{include file="modules/Meetings/tpls/reminders.tpl"}',
 //            'label' => 'LBL_REMINDER',
 //          ),
-            array (
+            array(
                 'name' => 'reminders',
                 'customCode' => '{include file="modules/Reminders/tpls/reminders.tpl"}',
                 'label' => 'LBL_REMINDERS',
@@ -163,15 +163,15 @@  discard block
 block discarded – undo
 
         ),
 
-        array (
-          array (
+        array(
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
           ),
         ),
 
-        array (
-          array (
+        array(
+          array(
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',

Please login to merge, or discard this patch.

modules/Calls/metadata/listviewdefs.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -38,35 +38,35 @@  discard block
 block discarded – undo
  ********************************************************************************/
 
 $listViewDefs ['Calls'] = 
-array (
+array(
   'SET_COMPLETE' => 
-  array (
+  array(
     'width' => '1%',
     'label' => 'LBL_LIST_CLOSE',
     'link' => true,
     'sortable' => false,
     'default' => true,
     'related_fields' => 
-    array (
+    array(
       0 => 'status',
     ),
   ),
   'DIRECTION' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_DIRECTION',
     'link' => false,
     'default' => true,
   ),
   'NAME' => 
-  array (
+  array(
     'width' => '40%',
     'label' => 'LBL_LIST_SUBJECT',
     'link' => true,
     'default' => true,
   ),
   'CONTACT_NAME' => 
-  array (
+  array(
     'width' => '20%',
     'label' => 'LBL_LIST_CONTACT',
     'link' => true,
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
     'ACLTag' => 'CONTACT',
   ),
   'PARENT_NAME' => 
-  array (
+  array(
     'width' => '20%',
     'label' => 'LBL_LIST_RELATED_TO',
     'dynamic_module' => 'PARENT_TYPE',
@@ -86,24 +86,24 @@  discard block
 block discarded – undo
     'sortable' => false,
     'ACLTag' => 'PARENT',
     'related_fields' => 
-    array (
+    array(
       0 => 'parent_id',
       1 => 'parent_type',
     ),
   ),
   'DATE_START' => 
-  array (
+  array(
     'width' => '15%',
     'label' => 'LBL_LIST_DATE',
     'link' => false,
     'default' => true,
     'related_fields' => 
-    array (
+    array(
       0 => 'time_start',
     ),
   ),
   'ASSIGNED_USER_NAME' => 
-  array (
+  array(
     'width' => '2%',
     'label' => 'LBL_LIST_ASSIGNED_TO_NAME',
     'module' => 'Employees',
@@ -111,13 +111,13 @@  discard block
 block discarded – undo
     'default' => true,
   ),
   'STATUS' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_STATUS',
     'link' => false,
     'default' => false,
   ),
-  'DATE_ENTERED' => array (
+  'DATE_ENTERED' => array(
     'width' => '10%',
     'label' => 'LBL_DATE_ENTERED',
     'default' => true

Please login to merge, or discard this patch.

modules/Calls/views/view.edit.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -49,10 +49,10 @@  discard block
 block discarded – undo
  	 */
  	public function preDisplay()
  	{
- 		if($_REQUEST['module'] != 'Calls' && isset($_REQUEST['status']) && empty($_REQUEST['status'])) {
+ 		if ($_REQUEST['module'] != 'Calls' && isset($_REQUEST['status']) && empty($_REQUEST['status'])) {
 	       $this->bean->status = '';
  		} //if
-        if(!empty($_REQUEST['status']) && ($_REQUEST['status'] == 'Held')) {
+        if (!empty($_REQUEST['status']) && ($_REQUEST['status'] == 'Held')) {
 	       $this->bean->status = 'Held';
  		}
  		parent::preDisplay();
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
 		$this->ss->assign('remindersDefaultValuesDataJson', Reminder::loadRemindersDefaultValuesDataJson());
 		$this->ss->assign('remindersDisabled', json_encode(false));
 
- 		if($this->ev->isDuplicate){
+ 		if ($this->ev->isDuplicate) {
 	        $this->bean->status = $this->bean->getDefaultStatus();
  		} //if
  		parent::display();

Please login to merge, or discard this patch.

		@@ -1,8 +1,8 @@ discard block
		block discarded – undo
1	1	<?php
2	2	$listViewDefs ['ProjectTask'] =
3		-array (
	3	+array(
4	4	'NAME' =>
5		- array (
	5	+ array(
6	6	'width' => '40%',
7	7	'label' => 'LBL_LIST_NAME',
8	8	'link' => true,
		@@ -10,7 +10,7 @@ discard block
		block discarded – undo
10	10	'sortable' => true,
11	11	),
12	12	'PROJECT_NAME' =>
13		- array (
	13	+ array(
14	14	'width' => '25%',
15	15	'label' => 'LBL_PROJECT_NAME',
16	16	'id' => 'PROJECT_ID',
		@@ -20,26 +20,26 @@ discard block
		block discarded – undo
20	20	'module' => 'Project',
21	21	'ACLTag' => 'PROJECT',
22	22	'related_fields' =>
23		- array (
	23	+ array(
24	24	0 => 'project_id',
25	25	),
26	26	),
27	27	'DATE_START' =>
28		- array (
	28	+ array(
29	29	'width' => '10%',
30	30	'label' => 'LBL_DATE_START',
31	31	'default' => true,
32	32	'sortable' => true,
33	33	),
34	34	'DATE_FINISH' =>
35		- array (
	35	+ array(
36	36	'width' => '10%',
37	37	'label' => 'LBL_DATE_FINISH',
38	38	'default' => true,
39	39	'sortable' => true,
40	40	),
41	41	'ASSIGNED_USER_NAME' =>
42		- array (
	42	+ array(
43	43	'width' => '10%',
44	44	'label' => 'LBL_LIST_ASSIGNED_USER_ID',
45	45	'module' => 'Employees',
		@@ -47,14 +47,14 @@ discard block
		block discarded – undo
47	47	'default' => true,
48	48	),
49	49	'PRIORITY' =>
50		- array (
	50	+ array(
51	51	'width' => '10%',
52	52	'label' => 'LBL_LIST_PRIORITY',
53	53	'default' => true,
54	54	'sortable' => true,
55	55	),
56	56	'PERCENT_COMPLETE' =>
57		- array (
	57	+ array(
58	58	'width' => '10%',
59	59	'label' => 'LBL_LIST_PERCENT_COMPLETE',
60	60	'default' => true,

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if (!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
3	3	/*********************************************************************************
4	4	* SugarCRM Community Edition is a customer relationship management program developed by
5	5	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	// Stick the form header out there.
80	80	echo get_form_header($mod_strings['LBL_INVITEES'], $button, false);
81		-$xtpl=new XTemplate ('modules/Calls/SubPanelViewInvitees.html');
	81	+$xtpl = new XTemplate('modules/Calls/SubPanelViewInvitees.html');
82	82	$xtpl->assign("MOD", $mod_strings);
83	83	$xtpl->assign("APP", $app_strings);
84	84
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	$xtpl->assign("CALL_ID", $focus->id);
87	87
88	88	$oddRow = true;
89		-foreach($focus_users_list as $user)
	89	+foreach ($focus_users_list as $user)
90	90	{
91	91	$user_fields = array(
92	92	'USER_NAME' => $user->user_name,
		@@ -98,7 +98,7 @@ discard block
		block discarded – undo
98	98
99	99	$xtpl->assign("USER", $user_fields);
100	100
101		- if($oddRow)
	101	+ if ($oddRow)
102	102	{
103	103	//todo move to themes
104	104	$xtpl->assign("ROW_COLOR", 'oddListRow');
		@@ -118,7 +118,7 @@ discard block
		block discarded – undo
118	118	$xtpl->out("users");
119	119
120	120	$oddRow = true;
121		-foreach($focus_contacts_list as $contact)
	121	+foreach ($focus_contacts_list as $contact)
122	122	{
123	123	$contact_fields = array(
124	124	'FIRST_NAME' => $contact->first_name,
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131
132	132	$xtpl->assign("CONTACT", $contact_fields);
133	133
134		- if($oddRow)
	134	+ if ($oddRow)
135	135	{
136	136	//todo move to themes
137	137	$xtpl->assign("ROW_COLOR", 'oddListRow');

		@@ -38,19 +38,19 @@ discard block
		block discarded – undo
38	38	********************************************************************************/
39	39
40	40	$viewdefs ['Calls'] =
41		-array (
	41	+array(
42	42	'EditView' =>
43		- array (
	43	+ array(
44	44	'templateMeta' =>
45		- array (
	45	+ array(
46	46	'includes' => array(
47	47	array('file' => 'modules/Reminders/Reminders.js'),
48	48	),
49	49	'maxColumns' => '2',
50	50	'form' =>
51		- array (
	51	+ array(
52	52	'hidden' =>
53		- array (
	53	+ array(
54	54	0 => '<input type="hidden" name="isSaveAndNew" value="false">',
55	55	1 => '<input type="hidden" name="send_invites">',
56	56	2 => '<input type="hidden" name="user_invitees">',
		@@ -58,48 +58,48 @@ discard block
		block discarded – undo
58	58	4 => '<input type="hidden" name="contact_invitees">',
59	59	),
60	60	'buttons' =>
61		- array (
	61	+ array(
62	62	0 =>
63		- array (
	63	+ array(
64	64	'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_HEADER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
65	65	),
66	66	1 => 'CANCEL',
67	67	2 =>
68		- array (
	68	+ array(
69	69	'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_HEADER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
70	70	),
71	71	3 =>
72		- array (
	72	+ array(
73	73	'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_HEADER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
74	74	),
75	75	),
76	76	'buttons_footer' =>
77		- array (
	77	+ array(
78	78	0 =>
79		- array (
	79	+ array(
80	80	'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_FOOTER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
81	81	),
82	82	1 => 'CANCEL',
83	83	2 =>
84		- array (
	84	+ array(
85	85	'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_FOOTER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
86	86	),
87	87	3 =>
88		- array (
	88	+ array(
89	89	'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_FOOTER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
90	90	),
91	91	),
92	92	'footerTpl' => 'modules/Calls/tpls/footer.tpl',
93	93	),
94	94	'widths' =>
95		- array (
	95	+ array(
96	96	0 =>
97		- array (
	97	+ array(
98	98	'label' => '10',
99	99	'field' => '30',
100	100	),
101	101	1 =>
102		- array (
	102	+ array(
103	103	'label' => '10',
104	104	'field' => '30',
105	105	),
		@@ -110,61 +110,61 @@ discard block
		block discarded – undo
110	110	function formSubmitCheck(){ldelim}var duration=true;if(typeof(isValidDuration)!="undefined"){ldelim}duration=isValidDuration();{rdelim}if(check_form(\'EditView\') && duration){ldelim}SUGAR.ajaxUI.submitForm("EditView");{rdelim}{rdelim}</script>',
111	111	'useTabs' => false,
112	112	'tabDefs' =>
113		- array (
	113	+ array(
114	114	'LBL_CALL_INFORMATION' =>
115		- array (
	115	+ array(
116	116	'newTab' => false,
117	117	'panelDefault' => 'expanded',
118	118	),
119	119	),
120	120	),
121	121	'panels' =>
122		- array (
	122	+ array(
123	123	'lbl_call_information' =>
124		- array (
	124	+ array(
125	125	0 =>
126		- array (
	126	+ array(
127	127	0 =>
128		- array (
	128	+ array(
129	129	'name' => 'name',
130	130	),
131	131	1 =>
132		- array (
	132	+ array(
133	133	'name' => 'status',
134	134	'fields' =>
135		- array (
	135	+ array(
136	136	0 =>
137		- array (
	137	+ array(
138	138	'name' => 'direction',
139	139	),
140	140	1 =>
141		- array (
	141	+ array(
142	142	'name' => 'status',
143	143	),
144	144	),
145	145	),
146	146	),
147	147	1 =>
148		- array (
	148	+ array(
149	149	0 =>
150		- array (
	150	+ array(
151	151	'name' => 'date_start',
152	152	'displayParams' =>
153		- array (
	153	+ array(
154	154	'updateCallback' => 'SugarWidgetScheduler.update_time();',
155	155	),
156	156	'label' => 'LBL_DATE_TIME',
157	157	),
158	158	1 =>
159		- array (
	159	+ array(
160	160	'name' => 'parent_name',
161	161	'label' => 'LBL_LIST_RELATED_TO',
162	162	),
163	163	),
164	164	2 =>
165		- array (
	165	+ array(
166	166	0 =>
167		- array (
	167	+ array(
168	168	'name' => 'duration_hours',
169	169	'label' => 'LBL_DURATION',
170	170	'customCode' => '{literal}<script type="text/javascript">function isValidDuration() { form = document.getElementById(\'EditView\'); if ( form.duration_hours.value + form.duration_minutes.value <= 0 ) { alert(\'{/literal}{$MOD.NOTICE_DURATION_TIME}{literal}\'); return false; } return true; }</script>{/literal}<input id="duration_hours" name="duration_hours" size="2" maxlength="2" type="text" value="{$fields.duration_hours.value}" onkeyup="SugarWidgetScheduler.update_time();"/>{$fields.duration_minutes.value} <span class="dateFormat">{$MOD.LBL_HOURS_MINUTES}</span>',
		@@ -178,25 +178,25 @@ discard block
		block discarded – undo
178	178	),
179	179	3 => array(
180	180	0 =>
181		- array (
	181	+ array(
182	182	'name' => 'reminders',
183	183	'customCode' => '{include file="modules/Reminders/tpls/reminders.tpl"}',
184	184	'label' => 'LBL_REMINDERS',
185	185	),
186	186	),
187	187	4 =>
188		- array (
	188	+ array(
189	189	0 =>
190		- array (
	190	+ array(
191	191	'name' => 'description',
192	192	'comment' => 'Full text of the note',
193	193	'label' => 'LBL_DESCRIPTION',
194	194	),
195	195	),
196	196	5 =>
197		- array (
	197	+ array(
198	198	0 =>
199		- array (
	199	+ array(
200	200	'name' => 'assigned_user_name',
201	201	'label' => 'LBL_ASSIGNED_TO_NAME',
202	202	),

		@@ -39,27 +39,27 @@ discard block
		block discarded – undo
39	39
40	40
41	41	$viewdefs ['Calls'] =
42		-array (
	42	+array(
43	43	'DetailView' =>
44		- array (
	44	+ array(
45	45	'templateMeta' =>
46		- array (
	46	+ array(
47	47	'form' =>
48		- array (
	48	+ array(
49	49	'buttons' =>
50		- array (
	50	+ array(
51	51	0 => 'EDIT',
52	52	1 => 'DUPLICATE',
53	53	2 => 'DELETE',
54	54	3 =>
55		- array (
	55	+ array(
56	56	'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSaveAndNew" value="false"> <input type="hidden" name="status" value=""> <input type="hidden" name="isSaveFromDetailView" value="true"> <input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" class="button" onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_create_button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" type="submit">{/if}',
57	57	'sugar_html' =>
58		- array (
	58	+ array(
59	59	'type' => 'submit',
60	60	'value' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
61	61	'htmlOptions' =>
62		- array (
	62	+ array(
63	63	'title' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
64	64	'class' => 'button',
65	65	'onclick' => 'this.form.isSaveFromDetailView.value=true; this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'',
		@@ -70,14 +70,14 @@ discard block
		block discarded – undo
70	70	),
71	71	),
72	72	4 =>
73		- array (
	73	+ array(
74	74	'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSave" value="false"> <input title="{$APP.LBL_CLOSE_BUTTON_TITLE}" accesskey="{$APP.LBL_CLOSE_BUTTON_KEY}" class="button" onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isSave.value=true;this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_button" name="button1" value="{$APP.LBL_CLOSE_BUTTON_TITLE}" type="submit">{/if}',
75	75	'sugar_html' =>
76		- array (
	76	+ array(
77	77	'type' => 'submit',
78	78	'value' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
79	79	'htmlOptions' =>
80		- array (
	80	+ array(
81	81	'title' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
82	82	'accesskey' => '{$APP.LBL_CLOSE_BUTTON_KEY}',
83	83	'class' => 'button',
		@@ -89,12 +89,12 @@ discard block
		block discarded – undo
89	89	),
90	90	),
91	91	'SA_RESCHEDULE' =>
92		- array (
	92	+ array(
93	93	'customCode' => '{if $fields.status.value != "Held"} <input title="{$MOD.LBL_RESCHEDULE}" class="button" onclick="get_form();" name="Reschedule" id="reschedule_button" value="{$MOD.LBL_RESCHEDULE}" type="button">{/if}',
94	94	),
95	95	),
96	96	'hidden' =>
97		- array (
	97	+ array(
98	98	0 => '<input type="hidden" name="isSaveAndNew">',
99	99	1 => '<input type="hidden" name="status">',
100	100	2 => '<input type="hidden" name="isSaveFromDetailView">',
		@@ -104,82 +104,82 @@ discard block
		block discarded – undo
104	104	),
105	105	'maxColumns' => '2',
106	106	'widths' =>
107		- array (
	107	+ array(
108	108	0 =>
109		- array (
	109	+ array(
110	110	'label' => '10',
111	111	'field' => '30',
112	112	),
113	113	1 =>
114		- array (
	114	+ array(
115	115	'label' => '10',
116	116	'field' => '30',
117	117	),
118	118	),
119	119	'useTabs' => true,
120	120	'includes' =>
121		- array (
	121	+ array(
122	122	'SA_RESCHEDULE' =>
123		- array (
	123	+ array(
124	124	'file' => 'modules/Calls_Reschedule/reschedule_form.js',
125	125	),
126	126	array('file' => 'modules/Reminders/Reminders.js'),
127	127	),
128	128	'tabDefs' =>
129		- array (
	129	+ array(
130	130	'LBL_CALL_INFORMATION' =>
131		- array (
	131	+ array(
132	132	'newTab' => true,
133	133	'panelDefault' => 'expanded',
134	134	),
135	135	'LBL_RESCHEDULE_PANEL' =>
136		- array (
	136	+ array(
137	137	'newTab' => true,
138	138	'panelDefault' => 'expanded',
139	139	),
140	140	'LBL_PANEL_ASSIGNMENT' =>
141		- array (
	141	+ array(
142	142	'newTab' => true,
143	143	'panelDefault' => 'expanded',
144	144	),
145	145	),
146	146	),
147	147	'panels' =>
148		- array (
	148	+ array(
149	149	'lbl_call_information' =>
150		- array (
	150	+ array(
151	151	0 =>
152		- array (
	152	+ array(
153	153	0 =>
154		- array (
	154	+ array(
155	155	'name' => 'name',
156	156	'label' => 'LBL_SUBJECT',
157	157	),
158	158	1 =>
159		- array (
	159	+ array(
160	160	'name' => 'direction',
161	161	'customCode' => '{$fields.direction.options[$fields.direction.value]} {$fields.status.options[$fields.status.value]}',
162	162	'label' => 'LBL_STATUS',
163	163	),
164	164	),
165	165	1 =>
166		- array (
	166	+ array(
167	167	0 =>
168		- array (
	168	+ array(
169	169	'name' => 'date_start',
170	170	'customCode' => '{$fields.date_start.value} {$fields.time_start.value} ',
171	171	'label' => 'LBL_DATE_TIME',
172	172	),
173	173	1 =>
174		- array (
	174	+ array(
175	175	'name' => 'parent_name',
176	176	'customLabel' => '{sugar_translate label=\'LBL_MODULE_NAME\' module=$fields.parent_type.value}',
177	177	),
178	178	),
179	179	2 =>
180		- array (
	180	+ array(
181	181	0 =>
182		- array (
	182	+ array(
183	183	'name' => 'duration_hours',
184	184	'customCode' => '{$fields.duration_hours.value}{$MOD.LBL_HOURS_ABBREV} {$fields.duration_minutes.value}{$MOD.LBL_MINSS_ABBREV} ',
185	185	'label' => 'LBL_DURATION',
		@@ -196,18 +196,18 @@ discard block
		block discarded – undo
196	196	),
197	197	),
198	198	3 =>
199		- array (
	199	+ array(
200	200	0 =>
201		- array (
	201	+ array(
202	202	'name' => 'description',
203	203	'comment' => 'Full text of the note',
204	204	'label' => 'LBL_DESCRIPTION',
205	205	),
206	206	),
207	207	4 =>
208		- array (
	208	+ array(
209	209	0 =>
210		- array (
	210	+ array(
211	211	'name' => 'assigned_user_name',
212	212	'customCode' => '{$fields.assigned_user_name.value}',
213	213	'label' => 'LBL_ASSIGNED_TO',
		@@ -215,11 +215,11 @@ discard block
		block discarded – undo
215	215	),
216	216	),
217	217	'lbl_reschedule_panel' =>
218		- array (
	218	+ array(
219	219	0 =>
220		- array (
	220	+ array(
221	221	0 =>
222		- array (
	222	+ array(
223	223	'name' => 'reschedule_history',
224	224	'comment' => 'Call duration, minutes portion',
225	225	'label' => 'LBL_RESCHEDULE_HISTORY',
		@@ -228,17 +228,17 @@ discard block
		block discarded – undo
228	228	),
229	229	),
230	230	'LBL_PANEL_ASSIGNMENT' =>
231		- array (
	231	+ array(
232	232	0 =>
233		- array (
	233	+ array(
234	234	0 =>
235		- array (
	235	+ array(
236	236	'name' => 'date_entered',
237	237	'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value} ',
238	238	'label' => 'LBL_DATE_ENTERED',
239	239	),
240	240	1 =>
241		- array (
	241	+ array(
242	242	'name' => 'date_modified',
243	243	'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value} ',
244	244	'label' => 'LBL_DATE_MODIFIED',

		@@ -38,35 +38,35 @@ discard block
		block discarded – undo
38	38	********************************************************************************/
39	39
40	40	$listViewDefs ['Calls'] =
41		-array (
	41	+array(
42	42	'SET_COMPLETE' =>
43		- array (
	43	+ array(
44	44	'width' => '1%',
45	45	'label' => 'LBL_LIST_CLOSE',
46	46	'link' => true,
47	47	'sortable' => false,
48	48	'default' => true,
49	49	'related_fields' =>
50		- array (
	50	+ array(
51	51	0 => 'status',
52	52	),
53	53	),
54	54	'DIRECTION' =>
55		- array (
	55	+ array(
56	56	'width' => '10%',
57	57	'label' => 'LBL_LIST_DIRECTION',
58	58	'link' => false,
59	59	'default' => true,
60	60	),
61	61	'NAME' =>
62		- array (
	62	+ array(
63	63	'width' => '40%',
64	64	'label' => 'LBL_LIST_SUBJECT',
65	65	'link' => true,
66	66	'default' => true,
67	67	),
68	68	'CONTACT_NAME' =>
69		- array (
	69	+ array(
70	70	'width' => '20%',
71	71	'label' => 'LBL_LIST_CONTACT',
72	72	'link' => true,
		@@ -76,7 +76,7 @@ discard block
		block discarded – undo
76	76	'ACLTag' => 'CONTACT',
77	77	),
78	78	'PARENT_NAME' =>
79		- array (
	79	+ array(
80	80	'width' => '20%',
81	81	'label' => 'LBL_LIST_RELATED_TO',
82	82	'dynamic_module' => 'PARENT_TYPE',
		@@ -86,24 +86,24 @@ discard block
		block discarded – undo
86	86	'sortable' => false,
87	87	'ACLTag' => 'PARENT',
88	88	'related_fields' =>
89		- array (
	89	+ array(
90	90	0 => 'parent_id',
91	91	1 => 'parent_type',
92	92	),
93	93	),
94	94	'DATE_START' =>
95		- array (
	95	+ array(
96	96	'width' => '15%',
97	97	'label' => 'LBL_LIST_DATE',
98	98	'link' => false,
99	99	'default' => true,
100	100	'related_fields' =>
101		- array (
	101	+ array(
102	102	0 => 'time_start',
103	103	),
104	104	),
105	105	'ASSIGNED_USER_NAME' =>
106		- array (
	106	+ array(
107	107	'width' => '2%',
108	108	'label' => 'LBL_LIST_ASSIGNED_TO_NAME',
109	109	'module' => 'Employees',
		@@ -111,13 +111,13 @@ discard block
		block discarded – undo
111	111	'default' => true,
112	112	),
113	113	'STATUS' =>
114		- array (
	114	+ array(
115	115	'width' => '10%',
116	116	'label' => 'LBL_STATUS',
117	117	'link' => false,
118	118	'default' => false,
119	119	),
120		- 'DATE_ENTERED' => array (
	120	+ 'DATE_ENTERED' => array(
121	121	'width' => '10%',
122	122	'label' => 'LBL_DATE_ENTERED',
123	123	'default' => true

adamjakab / SuiteCRM

Push — console-installer ( 3d54e5...e2b50d )

Category

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

Spacing +43 added lines, -43 removed lines patch added patch discarded remove patch

Spacing +35 added lines, -35 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch