adamjakab / SuiteCRM

modules/ModuleBuilder/parsers/parser.modifylayoutview.php

Spacing +50 added lines, -50 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if (! defined('sugarEntry') || ! sugarEntry)
+if (!defined('sugarEntry') || !sugarEntry)
 die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -62,19 +62,19 @@ 
     /**
      * Constructor
      */
-    function init ($module, $view, $submittedLayout = false)
+    function init($module, $view, $submittedLayout = false)
     {
         $this->_view = ucfirst($view);
         $this->_module = $module;
         $this->language_module = $module;
 
         $this->_baseDirectory = "modules/{$module}/metadata/";
-        $file =  $this->_baseDirectory . strtolower($view) . "defs.php";
-        $this->_customFile = "custom/" . $file;
-        $this->_workingFile = "custom/working/" . $file;
+        $file = $this->_baseDirectory.strtolower($view)."defs.php";
+        $this->_customFile = "custom/".$file;
+        $this->_workingFile = "custom/working/".$file;
 
         $this->_sourceView = $this->_view;
-        $this->_originalFile = $file ;
+        $this->_originalFile = $file;
         $this->_sourceFile = $file;
         if (is_file($this->_workingFile))
         {
@@ -85,16 +85,16 @@ 
         {
             $this->_sourceFile = $this->_customFile;
         }
-        else if (! is_file($this->_sourceFile))
+        else if (!is_file($this->_sourceFile))
         {
             // if we don't have ANY defined metadata then improvise as best we can
             if (strtolower($this->_view) == 'quickcreate')
             {
                 // special handling for quickcreates - base the quickcreate on the editview if no quickcreatedef exists
                 $this->_sourceFile = $this->_baseDirectory."editviewdefs.php";
-                if (is_file("custom/" . $this->_sourceFile))
+                if (is_file("custom/".$this->_sourceFile))
                 {
-                    $this->_sourceFile = "custom/" . $this->_sourceFile;
+                    $this->_sourceFile = "custom/".$this->_sourceFile;
                 }
                 $this->_sourceView = 'EditView';
             }
@@ -126,13 +126,13 @@ 
 
     }
 
-    function getAvailableFields ()
+    function getAvailableFields()
     {
         // Available fields are those that are in the Model and the original layout definition, but not already shown in the View
         // So, because the formats of the two are different we brute force loop through View and unset the fields we find in a copy of Model
         $availableFields = $this->_getModelFields();
-        $GLOBALS['log']->debug( get_class($this)."->getAvailableFields(): _getModelFields returns: ".implode(",",array_keys($availableFields)));
-        if (! empty($this->_viewdefs))
+        $GLOBALS['log']->debug(get_class($this)."->getAvailableFields(): _getModelFields returns: ".implode(",", array_keys($availableFields)));
+        if (!empty($this->_viewdefs))
         {
             foreach ($this->_viewdefs ['panels'] as $panel)
             {
@@ -143,7 +143,7 @@ 
                         if (isset($fieldArray ['name']))
                         {
                             unset($availableFields [$fieldArray ['name']]);
-                            $GLOBALS['log']->debug( get_class($this)."->getAvailableFields(): removing ".$fieldArray ['name'] );
+                            $GLOBALS['log']->debug(get_class($this)."->getAvailableFields(): removing ".$fieldArray ['name']);
                         }
                     }
                 }
@@ -152,39 +152,39 @@ 
         return $availableFields;
     }
 
-    function getLayout ()
+    function getLayout()
     {
         return $this->_viewdefs ['panels'];
     }
 
-    function writeWorkingFile ()
+    function writeWorkingFile()
     {
-        $this->_writeToFile($this->_workingFile,$this->_view,$this->_module,$this->_viewdefs,$this->_variables);
+        $this->_writeToFile($this->_workingFile, $this->_view, $this->_module, $this->_viewdefs, $this->_variables);
     }
 
-    function handleSave ()
+    function handleSave()
     {
-        $this->_writeToFile($this->_customFile,$this->_view,$this->_module,$this->_viewdefs,$this->_variables);
+        $this->_writeToFile($this->_customFile, $this->_view, $this->_module, $this->_viewdefs, $this->_variables);
         // now clear the cache so that the results are immediately visible
         include_once('include/TemplateHandler/TemplateHandler.php');
         if (strtolower($this->_view) == 'quickcreate')
         {
-        	TemplateHandler::clearCache($this->_module,"form_SubPanelQuickCreate_{$this->_module}.tpl");
-        	TemplateHandler::clearCache($this->_module,"form_DCQuickCreate_{$this->_module}.tpl");
+        	TemplateHandler::clearCache($this->_module, "form_SubPanelQuickCreate_{$this->_module}.tpl");
+        	TemplateHandler::clearCache($this->_module, "form_DCQuickCreate_{$this->_module}.tpl");
         } 
         else 
         {
-        	TemplateHandler::clearCache($this->_module,"{$this->_view}.tpl");
+        	TemplateHandler::clearCache($this->_module, "{$this->_view}.tpl");
         }
 
     }
 
-    function loadModule ($module, $view)
+    function loadModule($module, $view)
     {
         $this->_viewdefs = array();
         $viewdefs = null;
 
-        $loaded = $this->_loadFromFile($view,$this->_sourceFile,$module);
+        $loaded = $this->_loadFromFile($view, $this->_sourceFile, $module);
         $this->_viewdefs = $loaded['viewdefs'][$module][$view];
         $this->_variables = $loaded['variables'];
     }
@@ -193,14 +193,14 @@ 
      * Load the canonical panel layout from the submitted form
      *
      */
-    function _loadLayoutFromRequest ()
+    function _loadLayoutFromRequest()
     {
 
         $i = 1;
         // set up the map of panel# (as provided in the _REQUEST) to panel ID (as used in $this->_viewdefs['panels'])
         foreach ($this->_viewdefs ['panels'] as $panelID => $panel)
         {
-            $panelMap [$i ++] = $panelID;
+            $panelMap [$i++] = $panelID;
         }
         // replace any old values with new panel labels from the request
         foreach ($_REQUEST as $key => $value)
@@ -220,7 +220,7 @@ 
 
         if ($this->maxColumns < 1)
         {
-            $this->_fatalError("EditDetailViewParser:invalid maxColumns=" . $this->maxColumns);
+            $this->_fatalError("EditDetailViewParser:invalid maxColumns=".$this->maxColumns);
         }
 
         foreach ($_REQUEST as $slot => $value)
@@ -267,7 +267,7 @@ 
                         // if a leading (empty) then remove (by noting that remaining fields need to be shuffled along)
                         if ($startOfRow)
                         {
-                            $offset ++;
+                            $offset++;
                         }
                         unset($row [$colID]);
                     } else
@@ -287,9 +287,9 @@ 
         //          _pp($this->_viewdefs);
     }
 
-    function _padFields ()
+    function _padFields()
     {
-        if (! empty($this->_viewdefs))
+        if (!empty($this->_viewdefs))
         {
             foreach ($this->_viewdefs ['panels'] as $panelID => $panel)
             {
@@ -299,7 +299,7 @@ 
                     // pad between fields on a row
                     foreach ($row as $colID => $col)
                     {
-                        for ($i = $column + 1 ; $i < $colID ; $i ++ )
+                        for ($i = $column + 1; $i < $colID; $i++)
                         {
                             $row [$i] = array('name' => '(empty)', 'label' => '(empty)');
                         }
@@ -308,7 +308,7 @@ 
                     // now pad out to the end of the row
                     if (($column + 1) < $this->maxColumns)
                     { // last column is maxColumns-1
-                        for ($i = $column + 1 ; $i < $this->maxColumns ; $i ++ )
+                        for ($i = $column + 1; $i < $this->maxColumns; $i++)
                         {
                             $row [$i] = array('name' => '(empty)', 'label' => '(empty)');
                         }
@@ -323,7 +323,7 @@ 
 
     // add a new field to the end of a panel
     // don't write out (caller should call handleSave() when ready)
-    function _addField ($properties, $panelID = FALSE)
+    function _addField($properties, $panelID = FALSE)
     {
 
         // if a panelID was not passed, use the first available panel in the list
@@ -357,7 +357,7 @@ 
             //          print "lastrow=$lastrow lastcol=$lastcol";
             if ($lastcol >= $this->maxColumns)
             {
-                $lastrow ++;
+                $lastrow++;
                 $this->_viewdefs ['panels'] [$panelID] [$lastrow] = array();
                 $lastcol = 0;
             }
@@ -367,7 +367,7 @@ 
     }
 
     /* getModelFields returns an array of all fields stored in the database for this module plus those fields in the original layout definition (so we get fields such as Team ID)*/
-    function _getModelFields ()
+    function _getModelFields()
     {
         $modelFields = array();
         $origViewDefs = $this->_getOrigFieldViewDefs();
@@ -376,13 +376,13 @@ 
         {
             if (!empty($field))
             {
-                if (! is_array($def)) {
+                if (!is_array($def)) {
                     $def = array('name' => $field);
                 }
                 // get this field's label - if it has not been explicitly provided, see if the fieldDefs has a label for this field, and if not fallback to the field name
-                if (! isset($def ['label']))
+                if (!isset($def ['label']))
                         {
-                            if (! empty($this->_fieldDefs [$field] ['vname']))
+                            if (!empty($this->_fieldDefs [$field] ['vname']))
                             {
                                 $def ['label'] = $this->_fieldDefs [$field] ['vname'];
                             } else
@@ -393,25 +393,25 @@ 
                 $modelFields[$field] = array('name' => $field, 'label' => $def ['label']);
             }
         }
-        $GLOBALS['log']->debug(print_r($modelFields,true));
+        $GLOBALS['log']->debug(print_r($modelFields, true));
         foreach ($this->_fieldDefs as $field => $def)
         {
             if ((!empty($def['studio']) && $def['studio'] == 'visible')
-            || (empty($def['studio']) &&  (empty($def ['source']) || $def ['source'] == 'db' || $def ['source'] == 'custom_fields') && $def ['type'] != 'id' && strcmp($field, 'deleted') != 0 && (empty($def ['dbType']) || $def ['dbType'] != 'id') && (empty($def ['dbtype']) || $def ['dbtype'] != 'id')))
+            || (empty($def['studio']) && (empty($def ['source']) || $def ['source'] == 'db' || $def ['source'] == 'custom_fields') && $def ['type'] != 'id' && strcmp($field, 'deleted') != 0 && (empty($def ['dbType']) || $def ['dbType'] != 'id') && (empty($def ['dbtype']) || $def ['dbtype'] != 'id')))
             {
                 $label = isset($def['vname']) ? $def['vname'] : $def['name'];
                 $modelFields [$field] = array('name' => $field, 'label' => $label);
             }
             else
             {
-                $GLOBALS['log']->debug( get_class($this)."->_getModelFields(): skipping $field from modelFields as it fails the test for inclusion");
+                $GLOBALS['log']->debug(get_class($this)."->_getModelFields(): skipping $field from modelFields as it fails the test for inclusion");
             }
         }
-        $GLOBALS['log']->debug( get_class($this)."->_getModelFields(): remaining entries in modelFields are: ".implode(",",array_keys($modelFields)));
+        $GLOBALS['log']->debug(get_class($this)."->_getModelFields(): remaining entries in modelFields are: ".implode(",", array_keys($modelFields)));
         return $modelFields;
     }
 
-    function _parseData ($panels)
+    function _parseData($panels)
     {
         $fields = array();
         if (empty($panels))
@@ -419,7 +419,7 @@ 
 
         // Fix for a flexibility in the format of the panel sections - if only one panel, then we don't have a panel level defined, it goes straight into rows
         // See EditView2 for similar treatment
-        if (! empty($panels) && count($panels) > 0)
+        if (!empty($panels) && count($panels) > 0)
         {
             $keys = array_keys($panels);
             if (is_numeric($keys [0]))
@@ -438,12 +438,12 @@ 
                 {
                     $properties = array();
 
-                    if (! empty($col))
+                    if (!empty($col))
                     {
                         if (is_string($col))
                         {
                             $properties ['name'] = $col;
-                        } else if (! empty($col ['name']))
+                        } else if (!empty($col ['name']))
                         {
                             $properties = $col;
                         }
@@ -452,13 +452,13 @@ 
                         $properties ['name'] = translate('LBL_FILLER');
                     }
 
-                    if (! empty($properties ['name']))
+                    if (!empty($properties ['name']))
                     {
 
                         // get this field's label - if it has not been explicity provided, see if the fieldDefs has a label for this field, and if not fallback to the field name
-                        if (! isset($properties ['label']))
+                        if (!isset($properties ['label']))
                         {
-                            if (! empty($this->_fieldDefs [$properties ['name']] ['vname']))
+                            if (!empty($this->_fieldDefs [$properties ['name']] ['vname']))
                             {
                                 $properties ['label'] = $this->_fieldDefs [$properties ['name']] ['vname'];
                             } else
@@ -476,7 +476,7 @@ 
         return $displayData;
     }
 
-    function _getOrigFieldViewDefs ()
+    function _getOrigFieldViewDefs()
     {
         $origFieldDefs = array();
         $GLOBALS['log']->debug("Original File = ".$this->_originalFile);
@@ -487,7 +487,7 @@ 
 //          $GLOBALS['log']->debug($origdefs);
             // Fix for a flexibility in the format of the panel sections - if only one panel, then we don't have a panel level defined, it goes straight into rows
             // See EditView2 for similar treatment
-            if (! empty($origdefs) && count($origdefs) > 0)
+            if (!empty($origdefs) && count($origdefs) > 0)
             {
                 $keys = array_keys($origdefs);
                 if (is_numeric($keys [0]))

modules/ModuleBuilder/parsers/ParserFactory.php

Spacing +43 added lines, -43 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
-    die ( 'Not A Valid Entry Point' ) ;
+if (!defined('sugarEntry') || !sugarEntry)
+    die ('Not A Valid Entry Point');
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -41,7 +41,7 @@ 
  ********************************************************************************/
 
 
-require_once 'modules/ModuleBuilder/parsers/constants.php' ;
+require_once 'modules/ModuleBuilder/parsers/constants.php';
 
 class ParserFactory
 {
@@ -55,20 +55,20 @@ 
      * @return AbstractMetaDataParser
      */
 
-    public static function getParser ( $view , $moduleName , $packageName = null , $subpanelName = null )
+    public static function getParser($view, $moduleName, $packageName = null, $subpanelName = null)
     {
-        $GLOBALS [ 'log' ]->info ( "ParserFactory->getParser($view,$moduleName,$packageName,$subpanelName )" ) ;
+        $GLOBALS ['log']->info("ParserFactory->getParser($view,$moduleName,$packageName,$subpanelName )");
 		$sm = null;
-        $lView = strtolower ( $view );
-        if ( empty ( $packageName ) || ( $packageName == 'studio' ) )
+        $lView = strtolower($view);
+        if (empty ($packageName) || ($packageName == 'studio'))
         {
-            $packageName = null ;
+            $packageName = null;
             //For studio modules, check for view parser overrides
             $parser = self::checkForStudioParserOverride($view, $moduleName, $packageName);
             if ($parser) return $parser;
             $sm = StudioModuleFactory::getStudioModule($moduleName);
             //If we didn't find a specofic parser, see if there is a view to type mapping
-            foreach($sm->sources as $file => $def)
+            foreach ($sm->sources as $file => $def)
             {
                 if (!empty($def['view']) && $def['view'] == $view && !empty($def['type']))
                 {
@@ -78,41 +78,41 @@ 
             }
         }
 
-        switch ( $lView)
+        switch ($lView)
         {
             case MB_EDITVIEW :
             case MB_DETAILVIEW :
             case MB_QUICKCREATE :
-                require_once 'modules/ModuleBuilder/parsers/views/GridLayoutMetaDataParser.php' ;
-                return new GridLayoutMetaDataParser ( $view, $moduleName, $packageName ) ;
+                require_once 'modules/ModuleBuilder/parsers/views/GridLayoutMetaDataParser.php';
+                return new GridLayoutMetaDataParser($view, $moduleName, $packageName);
             case MB_BASICSEARCH :
             case MB_ADVANCEDSEARCH :
-                require_once 'modules/ModuleBuilder/parsers/views/SearchViewMetaDataParser.php' ;
-                return new SearchViewMetaDataParser ( $view, $moduleName, $packageName ) ;
+                require_once 'modules/ModuleBuilder/parsers/views/SearchViewMetaDataParser.php';
+                return new SearchViewMetaDataParser($view, $moduleName, $packageName);
             case MB_LISTVIEW :
                 if ($subpanelName == null)
                 {
-                    require_once 'modules/ModuleBuilder/parsers/views/ListLayoutMetaDataParser.php' ;
-                    return new ListLayoutMetaDataParser ( MB_LISTVIEW, $moduleName, $packageName ) ;
+                    require_once 'modules/ModuleBuilder/parsers/views/ListLayoutMetaDataParser.php';
+                    return new ListLayoutMetaDataParser(MB_LISTVIEW, $moduleName, $packageName);
                 } else
                 {
-                    require_once 'modules/ModuleBuilder/parsers/views/SubpanelMetaDataParser.php' ;
-                    return new SubpanelMetaDataParser ( $subpanelName, $moduleName, $packageName ) ;
+                    require_once 'modules/ModuleBuilder/parsers/views/SubpanelMetaDataParser.php';
+                    return new SubpanelMetaDataParser($subpanelName, $moduleName, $packageName);
                 }
             case MB_DASHLET :
             case MB_DASHLETSEARCH :
-                require_once 'modules/ModuleBuilder/parsers/views/DashletMetaDataParser.php' ;
-                return new DashletMetaDataParser($view, $moduleName, $packageName  );
+                require_once 'modules/ModuleBuilder/parsers/views/DashletMetaDataParser.php';
+                return new DashletMetaDataParser($view, $moduleName, $packageName);
             case MB_POPUPLIST :
             case MB_POPUPSEARCH :
-                require_once 'modules/ModuleBuilder/parsers/views/PopupMetaDataParser.php' ;
-                return new PopupMetaDataParser($view, $moduleName, $packageName  );
+                require_once 'modules/ModuleBuilder/parsers/views/PopupMetaDataParser.php';
+                return new PopupMetaDataParser($view, $moduleName, $packageName);
             case MB_LABEL :
-                require_once 'modules/ModuleBuilder/parsers/parser.label.php' ;
-                return new ParserLabel ( $moduleName, $packageName ) ;
+                require_once 'modules/ModuleBuilder/parsers/parser.label.php';
+                return new ParserLabel($moduleName, $packageName);
             case MB_VISIBILITY :
-                require_once 'modules/ModuleBuilder/parsers/parser.visibility.php' ;
-                return new ParserVisibility ( $moduleName, $packageName ) ;
+                require_once 'modules/ModuleBuilder/parsers/parser.visibility.php';
+                return new ParserVisibility($moduleName, $packageName);
             default :
                 $parser = self::checkForParserClass($view, $moduleName, $packageName);
                 if ($parser)
@@ -120,33 +120,33 @@ 
 
         }
 
-        $GLOBALS [ 'log' ]->fatal ("ParserFactory: cannot create ModuleBuilder Parser $view" ) ;
+        $GLOBALS ['log']->fatal("ParserFactory: cannot create ModuleBuilder Parser $view");
 
     }
 
     protected static function checkForParserClass($view, $moduleName, $packageName, $nameOverride = false)
     {
         $prefix = '';
-        if(!is_null ( $packageName )){
-            $prefix = empty($packageName) ? 'build' :'modify';
+        if (!is_null($packageName)) {
+            $prefix = empty($packageName) ? 'build' : 'modify';
         }
         $fileNames = array(
-            "custom/modules/$moduleName/parsers/parser." . strtolower ( $prefix . $view ) . ".php",
-            "modules/$moduleName/parsers/parser." . strtolower ( $prefix . $view ) . ".php",
-            "custom/modules/ModuleBuilder/parsers/parser." . strtolower ( $prefix . $view ) . ".php",
-            "modules/ModuleBuilder/parsers/parser." . strtolower ( $prefix . $view ) . ".php",
+            "custom/modules/$moduleName/parsers/parser.".strtolower($prefix.$view).".php",
+            "modules/$moduleName/parsers/parser.".strtolower($prefix.$view).".php",
+            "custom/modules/ModuleBuilder/parsers/parser.".strtolower($prefix.$view).".php",
+            "modules/ModuleBuilder/parsers/parser.".strtolower($prefix.$view).".php",
         );
-        foreach($fileNames as $fileName)
+        foreach ($fileNames as $fileName)
         {
-            if (file_exists ( $fileName ))
+            if (file_exists($fileName))
             {
-                require_once $fileName ;
-                $class = 'Parser' . $prefix . ucfirst ( $view ) ;
-                if (class_exists ( $class ))
+                require_once $fileName;
+                $class = 'Parser'.$prefix.ucfirst($view);
+                if (class_exists($class))
                 {
-                    $GLOBALS [ 'log' ]->debug ( 'Using ModuleBuilder Parser ' . $fileName ) ;
-                    $parser = new $class ( ) ;
-                    return $parser ;
+                    $GLOBALS ['log']->debug('Using ModuleBuilder Parser '.$fileName);
+                    $parser = new $class( );
+                    return $parser;
                 }
             }
         }
@@ -157,7 +157,7 @@ 
     {
         require_once('modules/ModuleBuilder/Module/StudioModuleFactory.php');
         $sm = StudioModuleFactory::getStudioModule($moduleName);
-        foreach($sm->sources as $file => $def)
+        foreach ($sm->sources as $file => $def)
         {
             if (!empty($def['view']) && $def['view'] == strtolower($view) && !empty($def['parser']))
             {
@@ -167,7 +167,7 @@ 
                     require_once("custom/$path");
                 else if (file_exists($path))
                     require_once($path);
-                if (class_exists ( $pName ))
+                if (class_exists($pName))
                     return new $pName($view, $moduleName, $packageName);
                 //If it wasn't defined directly, check for a generic parser name for the view
                 $parser = self::checkForParserClass($view, $moduleName, $packageName);

modules/ModuleBuilder/parsers/parser.modifylistview.php

Spacing +119 added lines, -119 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
-die ( 'Not A Valid Entry Point' ) ;
+if (!defined('sugarEntry') || !sugarEntry)
+die ('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -40,43 +40,43 @@ 
  ********************************************************************************/
 
 
-require_once ('modules/ModuleBuilder/parsers/ModuleBuilderParser.php') ;
+require_once ('modules/ModuleBuilder/parsers/ModuleBuilderParser.php');
 class ParserModifyListView extends ModuleBuilderParser
 {
-	var $listViewDefs = false ;
-	var $defaults = array ( ) ;
-	var $additional = array ( ) ;
-	var $available = array ( ) ;
+	var $listViewDefs = false;
+	var $defaults = array( );
+	var $additional = array( );
+	var $available = array( );
 	var $reserved = array(); // fields marked by 'studio'=>false in the listviewdefs; need to be preserved
 	//	var $language_module = '';
-	var $columns = array ( 'LBL_DEFAULT' => 'getDefaultFields' , 'LBL_AVAILABLE' => 'getAdditionalFields' , 'LBL_HIDDEN' => 'getAvailableFields' ) ;
-	function init ( $module_name , $submodule = '' )
+	var $columns = array('LBL_DEFAULT' => 'getDefaultFields', 'LBL_AVAILABLE' => 'getAdditionalFields', 'LBL_HIDDEN' => 'getAvailableFields');
+	function init($module_name, $submodule = '')
 	{
-		global $app_list_strings ;
-		$this->module_name = $module_name ;
-		$mod_strings = return_module_language ( $GLOBALS [ 'current_language' ], $this->module_name ) ; // needed solely so that listviewdefs that reference this can be included without error
-		$class = $GLOBALS [ 'beanList' ] [ $this->module_name ] ;
-		require_once ($GLOBALS [ 'beanFiles' ] [ $class ]) ;
-		$this->module = new $class ( ) ;
+		global $app_list_strings;
+		$this->module_name = $module_name;
+		$mod_strings = return_module_language($GLOBALS ['current_language'], $this->module_name); // needed solely so that listviewdefs that reference this can be included without error
+		$class = $GLOBALS ['beanList'] [$this->module_name];
+		require_once ($GLOBALS ['beanFiles'] [$class]);
+		$this->module = new $class( );
 
-		$loaded = $this->_loadFromFile('ListView','modules/' . $this->module_name . '/metadata/listviewdefs.php',$this->module_name);
-		$this->originalListViewDefs = $loaded['viewdefs'] [ $this->module_name ] ;
+		$loaded = $this->_loadFromFile('ListView', 'modules/'.$this->module_name.'/metadata/listviewdefs.php', $this->module_name);
+		$this->originalListViewDefs = $loaded['viewdefs'] [$this->module_name];
 		$this->_variables = $loaded['variables'];
 		//		_pp($loaded);
-		$this->customFile = 'custom/modules/' . $this->module_name . '/metadata/listviewdefs.php' ;
-		if (file_exists ( $this->customFile ))
+		$this->customFile = 'custom/modules/'.$this->module_name.'/metadata/listviewdefs.php';
+		if (file_exists($this->customFile))
 		{
-			$loaded = $this->_loadFromFile('ListView',$this->customFile,$this->module_name);
-			$this->listViewDefs = $loaded['viewdefs'] [ $this->module_name ] ;
+			$loaded = $this->_loadFromFile('ListView', $this->customFile, $this->module_name);
+			$this->listViewDefs = $loaded['viewdefs'] [$this->module_name];
 			$this->_variables = $loaded['variables'];
 		} else
 		{
-			$this->listViewDefs = & $this->originalListViewDefs ;
+			$this->listViewDefs = & $this->originalListViewDefs;
 		}
 
-		$this->fixKeys ( $this->originalListViewDefs ) ;
-		$this->fixKeys ( $this->listViewDefs ) ;
-		$this->language_module = $this->module_name ;
+		$this->fixKeys($this->originalListViewDefs);
+		$this->fixKeys($this->listViewDefs);
+		$this->language_module = $this->module_name;
 	}
 	
 	function getLanguage()
@@ -84,102 +84,102 @@ 
 	    return $this->language_module;
 	}
 	// re-key array so that every entry has a key=name and all keys are lowercase - makes it easier in handleSave() later...
-	function fixKeys ( &$defs )
+	function fixKeys(&$defs)
 	{
-		$temp = array ( ) ;
-		foreach ( $defs as $key => $value )
+		$temp = array( );
+		foreach ($defs as $key => $value)
 		{
-			if (! is_array ( $value ))
+			if (!is_array($value))
 			{
-				$key = $value ;
-				$def = array ( ) ;
-				$def [ 'name' ] = (isset ( $this->module->field_defs [ $key ] )) ? $this->module->field_defs [ $key ] [ 'name' ] : $key ;
-				$value = $def ;
+				$key = $value;
+				$def = array( );
+				$def ['name'] = (isset ($this->module->field_defs [$key])) ? $this->module->field_defs [$key] ['name'] : $key;
+				$value = $def;
 			}
-			if (isset ( $value [ 'name' ] ))
+			if (isset ($value ['name']))
 			{
-				$key = $value [ 'name' ] ; // override key with name, needed when the entry lacks a key
+				$key = $value ['name']; // override key with name, needed when the entry lacks a key
 			}
-			$temp [ strtolower ( $key ) ] = $value ;
+			$temp [strtolower($key)] = $value;
 		}
-		$defs = $temp ;
+		$defs = $temp;
 	}
 	
 	/**
 	 * returns the default fields for a listview
 	 * Called only when displaying the listview for editing; not called when saving
 	 */
-	function getDefaultFields ()
+	function getDefaultFields()
 	{
-		$this->defaults = array ( ) ;
-		foreach ( $this->listViewDefs as $key => $def )
+		$this->defaults = array( );
+		foreach ($this->listViewDefs as $key => $def)
 		{
 		    // add in the default fields from the listviewdefs, stripping out any field with 'studio' set to a value other than true
 		    // Important: the 'studio' fields must be added back into the layout on save, as they're not editable rather than hidden
-			if (! empty ( $def [ 'default' ] ))
+			if (!empty ($def ['default']))
 			{
-			    if (! isset($def['studio']) || $def['studio'] === true)
+			    if (!isset($def['studio']) || $def['studio'] === true)
 			    {
-			        $this->defaults [ $key ] = $def ;
+			        $this->defaults [$key] = $def;
 			    }
 			    else
 			    // anything which doesn't go into the defaults is a reserved field - this makes sure we don't miss anything
 			    {
-			        $this->reserved [ $key ] = $def;
+			        $this->reserved [$key] = $def;
 			    }
 			}
 		}
-		return $this->defaults ;
+		return $this->defaults;
 	}
 	/**
 	 * returns additional fields available for users to create fields
 	 */
-	function getAdditionalFields ()
+	function getAdditionalFields()
 	{
-		$this->additional = array ( ) ;
-		foreach ( $this->listViewDefs as $key => $def )
+		$this->additional = array( );
+		foreach ($this->listViewDefs as $key => $def)
 		{
-			if (empty ( $def [ 'default' ] ))
+			if (empty ($def ['default']))
 			{
-				$key = strtolower ( $key ) ;
-				$this->additional [ $key ] = $def ;
+				$key = strtolower($key);
+				$this->additional [$key] = $def;
 			}
 		}
-		return $this->additional ;
+		return $this->additional;
 	}
 	/**
 	 * returns unused fields that are available for using in either default or additional list views
 	 */
-	function getAvailableFields ()
+	function getAvailableFields()
 	{
-		$this->availableFields = array ( ) ;
-		$lowerFieldList = array_change_key_case ( $this->listViewDefs ) ;
-		foreach ( $this->originalListViewDefs as $key => $def )
+		$this->availableFields = array( );
+		$lowerFieldList = array_change_key_case($this->listViewDefs);
+		foreach ($this->originalListViewDefs as $key => $def)
 		{
-			$key = strtolower ( $key ) ;
-			if (! isset ( $lowerFieldList [ $key ] ))
+			$key = strtolower($key);
+			if (!isset ($lowerFieldList [$key]))
 			{
-				$this->availableFields [ $key ] = $def ;
+				$this->availableFields [$key] = $def;
 			}
 		}
-		$GLOBALS['log']->debug('parser.modifylistview.php->getAvailableFields(): field_defs='.print_r($this->availableFields,true));
+		$GLOBALS['log']->debug('parser.modifylistview.php->getAvailableFields(): field_defs='.print_r($this->availableFields, true));
 		$modFields = !empty($this->module->field_name_map) ? $this->module->field_name_map : $this->module->field_defs;
-		foreach ( $modFields as $key => $def )
+		foreach ($modFields as $key => $def)
 		{
-			$fieldName = strtolower ( $key ) ;
+			$fieldName = strtolower($key);
             if ($fieldName == 'currency_id')
                 continue;
-			if (!isset ( $lowerFieldList [ $fieldName ] )) // bug 16728 - check this first, so that other conditions (e.g., studio == visible) can't override and add duplicate entries
+			if (!isset ($lowerFieldList [$fieldName])) // bug 16728 - check this first, so that other conditions (e.g., studio == visible) can't override and add duplicate entries
 			{
             // bug 19656: this test changed after 5.0.0b - we now remove all ID type fields - whether set as type, or dbtype, from the fielddefs
-            if ($this->isValidField($key, $def)){
-					$label = (isset ( $def [ 'vname' ] )) ? $def [ 'vname' ] : (isset($def [ 'label' ]) ? $def['label'] : $def['name']) ;
-					$this->availableFields [ $fieldName ] = array ( 'width' => '10' , 'label' => $label ) ;
+            if ($this->isValidField($key, $def)) {
+					$label = (isset ($def ['vname'])) ? $def ['vname'] : (isset($def ['label']) ? $def['label'] : $def['name']);
+					$this->availableFields [$fieldName] = array('width' => '10', 'label' => $label);
 				}
 			}
 		}
 
-		return $this->availableFields ;
+		return $this->availableFields;
 	}
 
     function getFieldDefs()
@@ -190,19 +190,19 @@ 
 	
 	function isValidField($key, $def) {
 	    //Allow fields that are studio visible  
-		if (! empty ( $def [ 'studio' ] ) && $def [ 'studio' ] == 'visible')
+		if (!empty ($def ['studio']) && $def ['studio'] == 'visible')
 		  return true;
 		  
 		//No ID fields
-		if  ((!empty ( $def [ 'dbType' ] ) && $def [ 'dbType' ] == 'id') || (!empty ( $def [ 'type' ] ) && $def [ 'type' ] == 'id'))
+		if ((!empty ($def ['dbType']) && $def ['dbType'] == 'id') || (!empty ($def ['type']) && $def ['type'] == 'id'))
 		  return false;
 		  
 		//only allow DB and custom fields (if a source is specified)
-	    if (!empty($def [ 'source' ]) && $def [ 'source' ] != 'db' && $def [ 'source' ] != 'custom_fields')
+	    if (!empty($def ['source']) && $def ['source'] != 'db' && $def ['source'] != 'custom_fields')
 		  return false;
 
 		//Dont ever show the "deleted" fields or "_name" fields
-		if (strcmp ( $key, 'deleted' ) == 0 || (isset ( $def [ 'name' ] ) && strpos ( $def [ 'name' ], "_name" ) !== false))
+		if (strcmp($key, 'deleted') == 0 || (isset ($def ['name']) && strpos($def ['name'], "_name") !== false))
 	       return false;
 
 	    //If none of the "ifs" are true, the field is valid
@@ -210,124 +210,124 @@ 
 	}
 	
 	
-	function getField ( $fieldName )
+	function getField($fieldName)
 	{
-		$fieldName = strtolower ( $fieldName ) ;
-		foreach ( $this->listViewDefs as $key => $def )
+		$fieldName = strtolower($fieldName);
+		foreach ($this->listViewDefs as $key => $def)
 		{
-			$key = strtolower ( $key ) ;
+			$key = strtolower($key);
 			if ($key == $fieldName)
 			{
-				return $def ;
+				return $def;
 			}
 		}
-		foreach ( $this->module->field_defs as $key => $def )
+		foreach ($this->module->field_defs as $key => $def)
 		{
-			$key = strtolower ( $key ) ;
+			$key = strtolower($key);
 			if ($key == $fieldName)
 			{
-				return $def ;
+				return $def;
 			}
 		}
-		return array ( ) ;
+		return array( );
 	}
 	function addRelateData($fieldname, $listfielddef) {
-		$modFieldDef = $this->module->field_defs [ strtolower ( $fieldname ) ];
+		$modFieldDef = $this->module->field_defs [strtolower($fieldname)];
 		if (!empty($modFieldDef['module']) && !empty($modFieldDef['id_name'])) {
 			$listfielddef['module'] = $modFieldDef['module'];
 			$listfielddef['id'] = strtoupper($modFieldDef['id_name']);
 			$listfielddef['link'] = true;
-			$listfielddef['related_fields'] = array (strtolower($modFieldDef['id_name']));
+			$listfielddef['related_fields'] = array(strtolower($modFieldDef['id_name']));
 		}
 		return $listfielddef;
 	}
-	function _loadLayoutFromRequest ()
+	function _loadLayoutFromRequest()
 	{
 	    $GLOBALS['log']->debug("ParserModifyListView->_loadLayoutFromRequest()");
-		$fields = array ( ) ;
-		$rejectTypes = array ( 'html' , 'enum' , 'text' ) ;
-		for ( $i = 0 ; isset ( $_POST [ 'group_' . $i ] ) && $i < 2 ; $i ++ )
+		$fields = array( );
+		$rejectTypes = array('html', 'enum', 'text');
+		for ($i = 0; isset ($_POST ['group_'.$i]) && $i < 2; $i++)
 		{
 			//echo "\n***group-$i Size:".sizeof($_POST['group_' . $i])."\n";
-			foreach ( $_POST [ 'group_' . $i ] as $field )
+			foreach ($_POST ['group_'.$i] as $field)
 			{
-				$fieldname = strtoupper ( $field ) ;
+				$fieldname = strtoupper($field);
 				//originalListViewDefs are all lower case
-				$lowerFieldName = strtolower ( $field ) ;
-				if (isset ( $this->originalListViewDefs [ $lowerFieldName ] ))
+				$lowerFieldName = strtolower($field);
+				if (isset ($this->originalListViewDefs [$lowerFieldName]))
 				{
-					$fields [ $fieldname ] = $this->originalListViewDefs [ $lowerFieldName ] ;
+					$fields [$fieldname] = $this->originalListViewDefs [$lowerFieldName];
 				} else
 				{
 					//check if we have the case wrong for custom fields
-					if (! isset ( $this->module->field_defs [ $fieldname ] ))
+					if (!isset ($this->module->field_defs [$fieldname]))
 					{
-						foreach ( $this->module->field_defs as $key => $value )
+						foreach ($this->module->field_defs as $key => $value)
 						{
-							if (strtoupper ( $key ) == $fieldname)
+							if (strtoupper($key) == $fieldname)
 							{
-								$fields [ $fieldname ] = array ( 'width' => 10 , 'label' => $this->module->field_defs [ $key ] [ 'vname' ] ) ;
-								break ;
+								$fields [$fieldname] = array('width' => 10, 'label' => $this->module->field_defs [$key] ['vname']);
+								break;
 							}
 						}
 					} else
 					{
-						$fields [ $fieldname ] = array ( 'width' => 10 , 'label' => $this->module->field_defs [ $fieldname ] [ 'vname' ] ) ;
+						$fields [$fieldname] = array('width' => 10, 'label' => $this->module->field_defs [$fieldname] ['vname']);
 					}
 					// sorting fields of certain types will cause a database engine problems
 					// we only check this for custom fields, as we assume that OOB fields have been independently confirmed as ok
-					if (isset ( $this->module->field_defs [ strtolower ( $fieldname ) ] ) && (in_array ( $this->module->field_defs [ strtolower ( $fieldname ) ] [ 'type' ], $rejectTypes ) || isset($this->module->field_defs [ strtolower ( $fieldname ) ]['custom_module'])))
+					if (isset ($this->module->field_defs [strtolower($fieldname)]) && (in_array($this->module->field_defs [strtolower($fieldname)] ['type'], $rejectTypes) || isset($this->module->field_defs [strtolower($fieldname)]['custom_module'])))
 					{
-						$fields [ $fieldname ] [ 'sortable' ] = false ;
+						$fields [$fieldname] ['sortable'] = false;
 					}
 					// Bug 23728 - Make adding a currency type field default to setting the 'currency_format' to true
-					if (isset ( $this->module->field_defs [ strtolower ( $fieldname ) ] [ 'type ' ] ) && $this->module->field_defs [ strtolower ( $fieldname ) ] [ 'type' ] == 'currency') 
+					if (isset ($this->module->field_defs [strtolower($fieldname)] ['type ']) && $this->module->field_defs [strtolower($fieldname)] ['type'] == 'currency') 
 					{
-						$fields [ $fieldname ] [ 'currency_format' ] = true;
+						$fields [$fieldname] ['currency_format'] = true;
 					}
 				}
-				if (isset ( $_REQUEST [ strtolower ( $fieldname ) . 'width' ] ))
+				if (isset ($_REQUEST [strtolower($fieldname).'width']))
 				{
-					$width = substr ( $_REQUEST [ strtolower ( $fieldname ) . 'width' ], 6, 3 ) ;
-					if (strpos ( $width, "%" ) !== false)
+					$width = substr($_REQUEST [strtolower($fieldname).'width'], 6, 3);
+					if (strpos($width, "%") !== false)
 					{
-						$width = substr ( $width, 0, 2 ) ;
+						$width = substr($width, 0, 2);
 					}
 					if ($width < 101 && $width > 0)
 					{
-						$fields [ $fieldname ] [ 'width' ] = $width ;
+						$fields [$fieldname] ['width'] = $width;
 					}
-				} else if (isset ( $this->listViewDefs [ $fieldname ] [ 'width' ] ))
+				} else if (isset ($this->listViewDefs [$fieldname] ['width']))
 				{
-					$fields [ $fieldname ] [ 'width' ] = $this->listViewDefs [ $fieldname ] [ 'width' ] ;
+					$fields [$fieldname] ['width'] = $this->listViewDefs [$fieldname] ['width'];
 				}
 				//Get additional Data for relate fields
-				if (isset($this->module->field_defs [ strtolower ( $fieldname ) ] [ 'type' ]) && $this->module->field_defs [ strtolower ( $fieldname ) ] [ 'type' ] == 'relate') {
-					$fields [ $fieldname ] = $this->addRelateData($field, $fields [ $fieldname ]);
+				if (isset($this->module->field_defs [strtolower($fieldname)] ['type']) && $this->module->field_defs [strtolower($fieldname)] ['type'] == 'relate') {
+					$fields [$fieldname] = $this->addRelateData($field, $fields [$fieldname]);
 				}
-				$fields [ $fieldname ] [ 'default' ] = ($i == 0) ;
+				$fields [$fieldname] ['default'] = ($i == 0);
 			}
 		}
 		// Add the reserved fields back in to the end of the default fields in the layout
 		// ASSUMPTION: reserved fields go back at the end
 		// First, load the reserved fields - we cannot assume that getDefaultFields has been called earlier when saving
 		$this->getDefaultFields();
-		foreach ( $this->reserved as $key => $def)
+		foreach ($this->reserved as $key => $def)
 		{
-		    $fields[ $key ] = $def;
+		    $fields[$key] = $def;
 		}
 		
-		return $fields ;
+		return $fields;
 	}
-	function handleSave ()
+	function handleSave()
 	{
 		$fields = $this->_loadLayoutFromRequest();
-		$this->_writeToFile($this->customFile,'ListView',$this->module_name,$fields,$this->_variables);
+		$this->_writeToFile($this->customFile, 'ListView', $this->module_name, $fields, $this->_variables);
 
-		$GLOBALS [ "listViewDefs" ] [ $this->module_name ] = $fields ;
+		$GLOBALS ["listViewDefs"] [$this->module_name] = $fields;
 		// now clear the cache so that the results are immediately visible
-		include_once ('include/TemplateHandler/TemplateHandler.php') ;
-		TemplateHandler::clearCache ( $this->module_name, "ListView.tpl" ) ; // not currently cached, but here for the future
+		include_once ('include/TemplateHandler/TemplateHandler.php');
+		TemplateHandler::clearCache($this->module_name, "ListView.tpl"); // not currently cached, but here for the future
 	}
 }
 ?>

modules/AOR_Fields/vardefs.php

Spacing +20 added lines, -20 removed lines

@@ -26,9 +26,9 @@ 
 	'table'=>'aor_fields',
 	'audited'=>false,
 	'duplicate_merge'=>true,
-	'fields'=>array (
+	'fields'=>array(
         'aor_report_id' =>
-        array (
+        array(
             'required' => false,
             'name' => 'aor_report_id',
             'vname' => 'LBL_AOR_REPORT_ID',
@@ -47,7 +47,7 @@ 
             'size' => '20',
         ),
         'field_order' =>
-        array (
+        array(
             'required' => false,
             'name' => 'field_order',
             'vname' => 'LBL_ORDER',
@@ -68,14 +68,14 @@ 
             'disable_num_format' => '',
         ),
         'module_path' =>
-        array (
+        array(
             'name' => 'module_path',
             'type' => 'longtext',
             'vname' => 'LBL_MODULE_PATH',
             'isnull' => true,
         ),
         'field' =>
-        array (
+        array(
             'required' => false,
             'name' => 'field',
             'vname' => 'LBL_FIELD',
@@ -97,7 +97,7 @@ 
             'dependency' => false,
         ),
         'display' =>
-        array (
+        array(
             'required' => false,
             'name' => 'display',
             'vname' => 'LBL_DISPLAY',
@@ -115,7 +115,7 @@ 
             'studio' => 'visible',
         ),
         'link' =>
-        array (
+        array(
             'required' => false,
             'name' => 'link',
             'vname' => 'LBL_LINK',
@@ -133,7 +133,7 @@ 
             'studio' => 'visible',
         ),
         'label' =>
-        array (
+        array(
             'required' => false,
             'name' => 'label',
             'vname' => 'LBL_LABEL',
@@ -152,7 +152,7 @@ 
             'size' => '20',
         ),
         'field_function' =>
-        array (
+        array(
             'required' => false,
             'name' => 'field_function',
             'vname' => 'LBL_FUNCTION',
@@ -174,7 +174,7 @@ 
             'dependency' => false,
         ),
         'sort_by' =>
-        array (
+        array(
             'required' => false,
             'name' => 'sort_by',
             'vname' => 'LBL_SORT',
@@ -196,7 +196,7 @@ 
             'dependency' => false,
         ),
         'format' =>
-            array (
+            array(
                 'required' => false,
                 'name' => 'format',
                 'vname' => 'LBL_FORMAT',
@@ -218,7 +218,7 @@ 
                 'dependency' => false,
             ),
         'total' =>
-            array (
+            array(
                 'required' => false,
                 'name' => 'total',
                 'vname' => 'LBL_TOTAL',
@@ -240,7 +240,7 @@ 
                 'dependency' => false,
             ),
         'sort_order' =>
-        array (
+        array(
             'required' => false,
             'name' => 'sort_order',
             'vname' => 'LBL_SORT_ORDER',
@@ -262,7 +262,7 @@ 
             'dependency' => false,
         ),
         'group_by' =>
-        array (
+        array(
             'required' => false,
             'name' => 'group_by',
             'vname' => 'LBL_GROUP',
@@ -280,7 +280,7 @@ 
             'studio' => 'visible',
         ),
         'group_order' =>
-        array (
+        array(
             'required' => false,
             'name' => 'group_order',
             'vname' => 'LBL_GROUP_ORDER',
@@ -302,7 +302,7 @@ 
             'dependency' => false,
         ),
         'group_display' =>
-        array (
+        array(
             'required' => false,
             'name' => 'group_display',
             'vname' => 'LBL_GROUP_DISPLAY',
@@ -320,7 +320,7 @@ 
             'studio' => 'visible',
         ),
         'aor_reports' =>
-        array (
+        array(
             'name' => 'aor_reports',
             'type' => 'link',
             'relationship' => 'aor_report_aor_fields',
@@ -329,7 +329,7 @@ 
             'source'=>'non-db',
         ),
     ),
-    'relationships'=>array (
+    'relationships'=>array(
     ),
     'indices' => array(
         array(
@@ -341,7 +341,7 @@ 
 	'optimistic_locking'=>true,
 		'unified_search'=>true,
 );
-if (!class_exists('VardefManager')){
+if (!class_exists('VardefManager')) {
         require_once('include/SugarObjects/VardefManager.php');
 }
-VardefManager::createVardef('AOR_Fields','AOR_Field', array('basic'));
+VardefManager::createVardef('AOR_Fields', 'AOR_Field', array('basic'));

modules/Reminders_Invitees/Reminder_Invitee.php

Spacing +12 added lines, -12 removed lines

@@ -60,8 +60,8 @@ 
         parent::Basic();
     }
 
-    public function bean_implements($interface){
-        switch($interface){
+    public function bean_implements($interface) {
+        switch ($interface) {
             case 'ACL': return true;
         }
         return false;
@@ -75,13 +75,13 @@ 
 	 */
     public static function saveRemindersInviteesData($reminderId, $inviteesData) {
         $savedInviteeIds = array();
-        foreach($inviteesData as $k => $inviteeData) {
-            if(isset($_POST['isDuplicate']) && $_POST['isDuplicate']) $inviteeData->id = '';
+        foreach ($inviteesData as $k => $inviteeData) {
+            if (isset($_POST['isDuplicate']) && $_POST['isDuplicate']) $inviteeData->id = '';
             $reminderInviteeBean = BeanFactory::getBean('Reminders_Invitees', $inviteeData->id);
             $reminderInviteeBean->reminder_id = $reminderId;
             $reminderInviteeBean->related_invitee_module = $inviteeData->module;
             $reminderInviteeBean->related_invitee_module_id = $inviteeData->module_id;
-            if(!$inviteeData->id) {
+            if (!$inviteeData->id) {
                 $reminderInviteeBean->save();
                 $savedInviteeIds[] = $reminderInviteeBean->id;
             }
@@ -108,7 +108,7 @@ 
 		$ret = array();
 		$reminderInviteeBeen = new Reminder_Invitee();
 		$reminderInvitees = $reminderInviteeBeen->get_full_list("reminders_invitees.date_entered", "reminders_invitees.reminder_id = '$reminderId'");
-        if($reminderInvitees) {
+        if ($reminderInvitees) {
             foreach ($reminderInvitees as $reminderInvitee) {
                 $ret[] = array(
                     'id' => $isDuplicate ? null : $reminderInvitee->id,
@@ -125,21 +125,21 @@ 
         $retValue = "unknown";
 
         $bean = BeanFactory::getBean($module, $moduleId);
-        switch($module) {
+        switch ($module) {
             case 'Users':
             case 'Contacts':
             case 'Leads':
             default:
-                if(isset($bean->first_name) && isset($bean->last_name)) {
+                if (isset($bean->first_name) && isset($bean->last_name)) {
                     $retValue = "{$bean->first_name} {$bean->last_name}";
                 }
-                else if(isset($bean->name)) {
+                else if (isset($bean->name)) {
                     $retValue = $bean->name;
                 }
-                else if(isset($bean->email)) {
+                else if (isset($bean->email)) {
                     $retValue = $bean->email;
                 }
-                if(!$retValue) {
+                if (!$retValue) {
                     $retValue = "$module ($moduleId)";
                 }
                 break;
@@ -155,7 +155,7 @@ 
 	 */
     public static function deleteRemindersInviteesMultiple($reminderId, $inviteeIds = array()) {
         $invitees = BeanFactory::getBean('Reminders_Invitees')->get_full_list("", "reminders_invitees.reminder_id = '$reminderId'");
-        if($invitees) {
+        if ($invitees) {
             foreach ($invitees as $invitee) {
                 if (!in_array($invitee->id, $inviteeIds)) {
                     $invitee->mark_deleted($invitee->id);

modules/AOP_Case_Updates/AOPAssignManager.php

Spacing +46 added lines, -46 removed lines

@@ -1,76 +1,76 @@ 
 <?php
-class AOPAssignManager{
+class AOPAssignManager {
     private $ieX = false;
     private $distributionMethod = '';
     private $aopFallback = true;
     private $assignableUsers = array();
 
-    function __construct($ieX = false){
+    function __construct($ieX = false) {
         global $sugar_config;
         $this->ieX = $ieX;
-        if($ieX) {
+        if ($ieX) {
             $inboundDistribMethod = $ieX->get_stored_options("distrib_method", "");
-        }else{
+        } else {
             $inboundDistribMethod = '';
         }
-        if($this->isAOPFallback($inboundDistribMethod)){
+        if ($this->isAOPFallback($inboundDistribMethod)) {
             $this->distributionMethod = $sugar_config['aop']['distribution_method'];
             $this->aopFallback = true;
-        }else{
+        } else {
             $this->distributionMethod = $inboundDistribMethod;
             $this->aopFallback = false;
         }
         $this->assignableUsers = $this->getAssignableUsers();
     }
 
-    private function isAOPFallback($distribMethod){
+    private function isAOPFallback($distribMethod) {
         return empty($distribMethod) || $distribMethod == 'AOPDefault';
     }
 
-    private function getDistributionOptions(){
+    private function getDistributionOptions() {
         global $sugar_config;
-        if($this->aopFallback){
+        if ($this->aopFallback) {
             return $sugar_config['aop']['distribution_options'];
-        }else{
+        } else {
             return $this->ieX->get_stored_options("distribution_options", '');
         }
     }
 
-    private function getRoleUsers($roleId){
+    private function getRoleUsers($roleId) {
         require_once('modules/ACLRoles/ACLRole.php');
         $role = new ACLRole();
         $role->retrieve($roleId);
-        $role_users = $role->get_linked_beans( 'users','User');
+        $role_users = $role->get_linked_beans('users', 'User');
         $r_users = array();
-        foreach($role_users as $role_user){
+        foreach ($role_users as $role_user) {
             $r_users[$role_user->id] = $role_user->name;
         }
         return $r_users;
     }
 
-    private function getAssignableUsers(){
-        if($this->distributionMethod == 'singleUser'){
+    private function getAssignableUsers() {
+        if ($this->distributionMethod == 'singleUser') {
             return array();
         }
         $distributionOptions = $this->getDistributionOptions();
 
-        if(empty($distributionOptions)){
+        if (empty($distributionOptions)) {
             return array();
         }
-        switch($distributionOptions[0]) {
+        switch ($distributionOptions[0]) {
             Case 'security_group':
-                if(file_exists('modules/SecurityGroups/SecurityGroup.php')){
+                if (file_exists('modules/SecurityGroups/SecurityGroup.php')) {
                     require_once('modules/SecurityGroups/SecurityGroup.php');
                     $security_group = new SecurityGroup();
                     $security_group->retrieve($distributionOptions[1]);
-                    $group_users = $security_group->get_linked_beans( 'users','User');
+                    $group_users = $security_group->get_linked_beans('users', 'User');
                     $users = array();
                     $r_users = array();
-                    if($distributionOptions[2] != ''){
+                    if ($distributionOptions[2] != '') {
                         $r_users = $this->getRoleUsers($distributionOptions[2]);
                     }
-                    foreach($group_users as $group_user){
-                        if($distributionOptions[2] != '' && !isset($r_users[$group_user->id])){
+                    foreach ($group_users as $group_user) {
+                        if ($distributionOptions[2] != '' && !isset($r_users[$group_user->id])) {
                             continue;
                         }
                         $users[$group_user->id] = $group_user->name;
@@ -90,57 +90,57 @@ 
 
     }
 
-    private function getSingleUser(){
+    private function getSingleUser() {
         global $sugar_config;
-        if($this->singleUser){
+        if ($this->singleUser) {
             return $this->singleUser;
         }
-        if($this->aopFallback){
+        if ($this->aopFallback) {
             $this->singleUser = !empty($sugar_config['aop']['distribution_user_id']) ? $sugar_config['aop']['distribution_user_id'] : '';
-        }else{
+        } else {
             $this->singleUser = $this->ieX->get_stored_options("distribution_user_id", "");
         }
         return $this->singleUser;
     }
 
-    private function getLeastBusyCounts(){
-        if($this->leastBusyUsers){
+    private function getLeastBusyCounts() {
+        if ($this->leastBusyUsers) {
             return $this->leastBusyUsers;
         }
         global $db;
-        $idIn = implode("','",$db->arrayQuote(array_keys($this->assignableUsers)));
-        if($idIn){
+        $idIn = implode("','", $db->arrayQuote(array_keys($this->assignableUsers)));
+        if ($idIn) {
             $idIn = "'".$idIn."'";
         }
         $res = $db->query("SELECT assigned_user_id, COUNT(*) AS c FROM cases WHERE assigned_user_id IN ({$idIn}) AND deleted = 0 GROUP BY assigned_user_id ORDER BY COUNT(*)");
         $this->leastBusyUsers = array();
-        while($row = $db->fetchByAssoc($res)){
+        while ($row = $db->fetchByAssoc($res)) {
             $this->leastBusyUsers[$row['assigned_user_id']] = $row['c'];
         }
         return $this->leastBusyUsers;
     }
 
-    private function getLeastBusyUser(){
+    private function getLeastBusyUser() {
         $leastBusyCounts = $this->getLeastBusyCounts();
         asort($leastBusyCounts);
         reset($leastBusyCounts);
         return key($leastBusyCounts);
     }
 
-    private function updateLeastBusy($id){
-        if(!$this->leastBusyUsers){
+    private function updateLeastBusy($id) {
+        if (!$this->leastBusyUsers) {
             $this->getLeastBusyCounts();
         }
         $this->leastBusyUsers[$id] = $this->leastBusyUsers[$id] + 1;
     }
 
-    private function getRandomUser(){
+    private function getRandomUser() {
         $randKey = array_rand($this->assignableUsers);
         return $this->assignableUsers[$randKey];
     }
 
-    function getNextAssignedUser(){
-        switch($this->distributionMethod){
+    function getNextAssignedUser() {
+        switch ($this->distributionMethod) {
             case 'singleUser':
                 $userId = $this->getSingleUser();
                 break;
@@ -163,20 +163,20 @@ 
 
     private function getRoundRobinUser() {
         $id = empty($this->ieX) ? '' : $this->ieX->id;
-        $file = create_cache_directory('modules/AOP_Case_Updates/Users/') . $id . 'lastUser.cache.php';
-        if(isset($_SESSION['AOPlastuser'][$id]) && $_SESSION['AOPlastuser'][$id] != '') {
+        $file = create_cache_directory('modules/AOP_Case_Updates/Users/').$id.'lastUser.cache.php';
+        if (isset($_SESSION['AOPlastuser'][$id]) && $_SESSION['AOPlastuser'][$id] != '') {
             $lastUserId = $_SESSION['AOPlastuser'][$id];
         }
-        else if (is_file($file)){
+        else if (is_file($file)) {
             include $file;
-            if(isset($lastUser['User']) && $lastUser['User'] != '') {
+            if (isset($lastUser['User']) && $lastUser['User'] != '') {
                 $lastUserId = $lastUser['User'];
             }
         }
         $users = array_keys($this->assignableUsers);
-        $lastOffset = array_search($lastUserId,$users);
+        $lastOffset = array_search($lastUserId, $users);
         $newOffset = ($lastOffset + 1) % count($users);
-        if(!empty($users[$newOffset])) {
+        if (!empty($users[$newOffset])) {
             return $users[$newOffset];
         }
         return reset($users);
@@ -185,14 +185,14 @@ 
     private function setLastRoundRobinUser($user_id) {
         $id = empty($this->ieX) ? '' : $this->ieX->id;
         $_SESSION['AOPlastuser'][$id] = $user_id;
-        $file = create_cache_directory('modules/AOP_Case_Updates/Users/') . $id . 'lastUser.cache.php';
+        $file = create_cache_directory('modules/AOP_Case_Updates/Users/').$id.'lastUser.cache.php';
         $arrayString = var_export_helper(array('User' => $user_id));
-        $content =<<<eoq
+        $content = <<<eoq
 <?php
 	\$lastUser = {$arrayString};
 ?>
 eoq;
-        if($fh = @sugar_fopen($file, 'w')) {
+        if ($fh = @sugar_fopen($file, 'w')) {
             fputs($fh, $content);
             fclose($fh);
         }

modules/SchedulersJobs/field_arrays.php

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -39,8 +39,8 @@ 
  ********************************************************************************/
 
 
-$fields_array['Schedulers_jobs'] = array (
-	'column_fields' => array (
+$fields_array['Schedulers_jobs'] = array(
+	'column_fields' => array(
 		'id',
 		'deleted',
 		'date_entered',
@@ -49,12 +49,12 @@ 
 		'execute_time',
 		'status',
 	),
-	'list_fields' => array (
+	'list_fields' => array(
 		'id',
 		'job_id',
 		'execute_time'
 	),
-	'required_fields' => array (
+	'required_fields' => array(
 		'job_id' => 1,
 		'execute_time' => 1
 	)

modules/Import/ImportFieldSanitize.php

Spacing +36 added lines, -36 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -87,24 +87,24 @@ 
     {
         static $sfh;
         
-        if(!isset($sfh)) {
+        if (!isset($sfh)) {
             require_once('include/SugarFields/SugarFieldHandler.php');
             $sfh = new SugarFieldHandler();
         }
         $value = $params[0];
         $vardef = $params[1];
-        if ( isset($params[2]) )
+        if (isset($params[2]))
             $focus = $params[2];
         else
             $focus = null;
-        if ( $name == 'relate' && !empty($params[3]) )
+        if ($name == 'relate' && !empty($params[3]))
             $this->addRelatedBean = true;
         else
             $this->addRelatedBean = false;
         
         $field = $sfh->getSugarField(ucfirst($name));
-        if ( $field instanceOf SugarFieldBase ) {
-            $value = $field->importSanitize($value,$vardef,$focus,$this);
+        if ($field instanceOf SugarFieldBase) {
+            $value = $field->importSanitize($value, $vardef, $focus, $this);
         }
         
         return $value;
@@ -128,10 +128,10 @@ 
 
         $format = $this->dateformat;
 
-        if ( !$timedate->check_matching_format($value, $format) )
+        if (!$timedate->check_matching_format($value, $format))
             return false;
 
-        if ( !$this->isValidTimeDate($value, $format) )
+        if (!$this->isValidTimeDate($value, $format))
             return false;
 
         $value = $timedate->swap_formats(
@@ -156,11 +156,11 @@ 
         // cache $sea instance
         static $sea;
         
-        if ( !($sea instanceof SugarEmailAddress) ) {
+        if (!($sea instanceof SugarEmailAddress)) {
             $sea = new SugarEmailAddress;
         }
         
-        if ( !empty($value) && !preg_match($sea->regex,$value) ) {
+        if (!empty($value) && !preg_match($sea->regex, $value)) {
             return false;
         }
 
@@ -184,18 +184,18 @@ 
         static $focus_user;
 
         // cache this object since we'll be reusing it a bunch
-        if ( !($focus_user instanceof User) ) {
+        if (!($focus_user instanceof User)) {
 
             $focus_user = new User();
         }
 
 
-        if ( !empty($value) && strtolower($value) != "all" ) {
-            $theList   = explode(",",$value);
+        if (!empty($value) && strtolower($value) != "all") {
+            $theList   = explode(",", $value);
             $isValid   = true;
             $bad_names = array();
             foreach ($theList as $eachItem) {
-                if ( $focus_user->retrieve_user_id($eachItem)
+                if ($focus_user->retrieve_user_id($eachItem)
                         || $focus_user->retrieve($eachItem)
                 ) {
                     // all good
@@ -206,7 +206,7 @@ 
                     continue;
                 }
             }
-            if(!$isValid) {
+            if (!$isValid) {
                 return false;
             }
         }
@@ -232,10 +232,10 @@ 
 
         $format = $this->timeformat;
 
-        if ( !$timedate->check_matching_format($value, $format) )
+        if (!$timedate->check_matching_format($value, $format))
             return false;
 
-        if ( !$this->isValidTimeDate($value, $format) )
+        if (!$this->isValidTimeDate($value, $format))
             return false;
 
         $value = $timedate->swap_formats(
@@ -266,46 +266,46 @@ 
         $reg = $timedate->get_regular_expression($format);
         preg_match('@'.$reg['format'].'@', $value, $dateparts);
 
-        if ( empty($dateparts) )
+        if (empty($dateparts))
             return false;
-        if ( isset($reg['positions']['a'])
-                && !in_array($dateparts[$reg['positions']['a']], array('am','pm')) )
+        if (isset($reg['positions']['a'])
+                && !in_array($dateparts[$reg['positions']['a']], array('am', 'pm')))
             return false;
-        if ( isset($reg['positions']['A'])
-                && !in_array($dateparts[$reg['positions']['A']], array('AM','PM')) )
+        if (isset($reg['positions']['A'])
+                && !in_array($dateparts[$reg['positions']['A']], array('AM', 'PM')))
             return false;
-        if ( isset($reg['positions']['h']) && (
+        if (isset($reg['positions']['h']) && (
                 !is_numeric($dateparts[$reg['positions']['h']])
                 || $dateparts[$reg['positions']['h']] < 1
-                || $dateparts[$reg['positions']['h']] > 12 ) )
+                || $dateparts[$reg['positions']['h']] > 12 ))
             return false;
-        if ( isset($reg['positions']['H']) && (
+        if (isset($reg['positions']['H']) && (
                 !is_numeric($dateparts[$reg['positions']['H']])
                 || $dateparts[$reg['positions']['H']] < 0
-                || $dateparts[$reg['positions']['H']] > 23 ) )
+                || $dateparts[$reg['positions']['H']] > 23 ))
             return false;
-        if ( isset($reg['positions']['i']) && (
+        if (isset($reg['positions']['i']) && (
                 !is_numeric($dateparts[$reg['positions']['i']])
                 || $dateparts[$reg['positions']['i']] < 0
-                || $dateparts[$reg['positions']['i']] > 59 ) )
+                || $dateparts[$reg['positions']['i']] > 59 ))
             return false;
-        if ( isset($reg['positions']['s']) && (
+        if (isset($reg['positions']['s']) && (
                 !is_numeric($dateparts[$reg['positions']['s']])
                 || $dateparts[$reg['positions']['s']] < 0
-                || $dateparts[$reg['positions']['s']] > 59 ) )
+                || $dateparts[$reg['positions']['s']] > 59 ))
             return false;
-        if ( isset($reg['positions']['d']) && (
+        if (isset($reg['positions']['d']) && (
                 !is_numeric($dateparts[$reg['positions']['d']])
                 || $dateparts[$reg['positions']['d']] < 1
-                || $dateparts[$reg['positions']['d']] > 31 ) )
+                || $dateparts[$reg['positions']['d']] > 31 ))
             return false;
-        if ( isset($reg['positions']['m']) && (
+        if (isset($reg['positions']['m']) && (
                 !is_numeric($dateparts[$reg['positions']['m']])
                 || $dateparts[$reg['positions']['m']] < 1
-                || $dateparts[$reg['positions']['m']] > 12 ) )
+                || $dateparts[$reg['positions']['m']] > 12 ))
             return false;
-        if ( isset($reg['positions']['Y']) &&
-                !is_numeric($dateparts[$reg['positions']['Y']]) )
+        if (isset($reg['positions']['Y']) &&
+                !is_numeric($dateparts[$reg['positions']['Y']]))
             return false;
 
         return true;

modules/Import/maps/ImportMapGoogle.php

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -86,13 +86,13 @@ 
              'email2' => array('sugar_key' => 'email2', 'sugar_label' => 'LBL_OTHER_EMAIL_ADDRESS', 'default_label' => 'Other Email'),
 
              'assigned_user_name' => array('sugar_key' => 'assigned_user_name', 'sugar_help_key' => 'LBL_EXTERNAL_ASSIGNED_TOOLTIP', 'sugar_label' => 'LBL_ASSIGNED_TO_NAME', 'default_label' => 'Assigned To'),
-             'team_name' => array('sugar_key' => 'team_name', 'sugar_help_key' => 'LBL_EXTERNAL_TEAM_TOOLTIP','sugar_label' => 'LBL_TEAMS', 'default_label' => 'Teams'),
+             'team_name' => array('sugar_key' => 'team_name', 'sugar_help_key' => 'LBL_EXTERNAL_TEAM_TOOLTIP', 'sugar_label' => 'LBL_TEAMS', 'default_label' => 'Teams'),
             );
 
-        if($module == 'Users')
+        if ($module == 'Users')
         {
-            $return_array['status'] =  array('sugar_key' => 'status', 'sugar_label' => '', 'default_label' => 'Status');
-            $return_array['full_name'] =  array('sugar_key' => 'user_name', 'sugar_label' => '', 'default_label' => 'Full Name');
+            $return_array['status'] = array('sugar_key' => 'status', 'sugar_label' => '', 'default_label' => 'Status');
+            $return_array['full_name'] = array('sugar_key' => 'user_name', 'sugar_label' => '', 'default_label' => 'Full Name');
         }
         return $return_array;
     }