adamjakab / SuiteCRM

modules/Administration/SupportPortal.php

Braces +19 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,7 +55,9 @@ 
 
 switch ($_REQUEST['view']) {
 	case "support_portal":
-		if (!is_admin($current_user)) sugar_die("Unauthorized access to administration.");
+		if (!is_admin($current_user)) {
+		    sugar_die("Unauthorized access to administration.");
+		}
 		$GLOBALS['log']->info("Administration SupportPortal");
 
 		$iframe_url = add_http("www.sugarcrm.com/network/redirect.php?tmpl=network");
@@ -83,14 +87,18 @@ 
 		$send_key = isset($_REQUEST['key']) ? $_REQUEST['key'] : "";
 		$send_anchor = '';
 		// awu: Fixes the ProjectTasks pluralization issue -- must fix in later versions.
-		if ($send_module == 'ProjectTasks')
-			$send_module = 'ProjectTask';
-        if ($send_module == 'ProductCatalog')
-                $send_module = 'ProductTemplates';
-        if ($send_module == 'TargetLists')
-                $send_module = 'ProspectLists';
-        if ($send_module == 'Targets')
-                $send_module = 'Prospects';                            
+		if ($send_module == 'ProjectTasks') {
+					$send_module = 'ProjectTask';
+		}
+        if ($send_module == 'ProductCatalog') {
+                        $send_module = 'ProductTemplates';
+        }
+        if ($send_module == 'TargetLists') {
+                        $send_module = 'ProspectLists';
+        }
+        if ($send_module == 'Targets') {
+                        $send_module = 'Prospects';
+        }
 		// FG - Bug 39819 - Check for custom help files
 		$helpPath = 'modules/'.$send_module.'/language/'.$send_lang.'.help.'.$send_action.'.html';
 		if (sugar_is_file("custom/" . $helpPath)) {
@@ -205,7 +213,7 @@ 
 								$send_anchor = $map['anchor'];
 							}
 						}
-					}else{
+					} else{
 						$send_module = $map['name'];
 						if(!empty($map['anchor'])){
 								$send_anchor = $map['anchor'];

modules/Administration/DiagnosticRun.php

Braces +74 added lines, -50 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -47,7 +49,9 @@ 
 global $current_user;
 
 
-if (!is_admin($current_user)) sugar_die("Unauthorized access to administration.");
+if (!is_admin($current_user)) {
+    sugar_die("Unauthorized access to administration.");
+}
 if (isset($GLOBALS['sugar_config']['hide_admin_diagnostics']) && $GLOBALS['sugar_config']['hide_admin_diagnostics'])
 {
     sugar_die("Unauthorized access to diagnostic tool.");
@@ -131,9 +135,9 @@ 
     global $currentitems;
 
     $currentitems++;
-    if($currentitems == $totalitems)
-      update_progress_bar("diagnostic", 100, 100);
-    else
+    if($currentitems == $totalitems) {
+          update_progress_bar("diagnostic", 100, 100);
+    } else
     {
       $progress_bar_percent += ($itemweight / $GLOBALS['totalweight'] * 100);
       update_progress_bar("diagnostic", $progress_bar_percent, 100);
@@ -214,18 +218,21 @@ 
 			//perform this check when counter is set to two, which means it is on the 'value' column
 			if($counter == 2) {
 				//if the previous "name" column value was set to smtppass, set replace_val to true
-				if(strcmp($row[$counter - 1], "smtppass") == 0  )
-					$replace_val = true;
+				if(strcmp($row[$counter - 1], "smtppass") == 0  ) {
+									$replace_val = true;
+				}
 
 				//if the previous "name" column value was set to smtppass,
 				//and the "category" value set to ldap, set replace_val to true
-				if (strcmp($row[$counter - 2], "ldap") == 0 && strcmp($row[$counter - 1], "admin_password") == 0)
-					$replace_val = true;
+				if (strcmp($row[$counter - 2], "ldap") == 0 && strcmp($row[$counter - 1], "admin_password") == 0) {
+									$replace_val = true;
+				}
 
 				//if the previous "name" column value was set to password,
 				//and the "category" value set to proxy, set replace_val to true
-				if(strcmp($row[$counter - 2], "proxy") == 0 && strcmp($row[$counter - 1], "password") == 0 )
-					$replace_val = true;
+				if(strcmp($row[$counter - 2], "proxy") == 0 && strcmp($row[$counter - 1], "password") == 0 ) {
+									$replace_val = true;
+				}
 			}
 
 			if($replace_val) {
@@ -245,8 +252,9 @@ 
 // Deletes the directory recursively
 function deleteDir($dir)
 {
-   if (substr($dir, strlen($dir)-1, 1) != '/')
-       $dir .= '/';
+   if (substr($dir, strlen($dir)-1, 1) != '/') {
+          $dir .= '/';
+   }
 
    if ($handle = opendir($dir))
    {
@@ -256,21 +264,23 @@ 
            {
                if (is_dir($dir.$obj))
                {
-                   if (!deleteDir($dir.$obj))
-                       return false;
-               }
-               elseif (is_file($dir.$obj))
+                   if (!deleteDir($dir.$obj)) {
+                                          return false;
+                   }
+               } elseif (is_file($dir.$obj))
                {
-                   if (!unlink($dir.$obj))
-                       return false;
+                   if (!unlink($dir.$obj)) {
+                                          return false;
+                   }
                }
            }
        }
 
        closedir($handle);
 
-       if (!@rmdir($dir))
-           return false;
+       if (!@rmdir($dir)) {
+                  return false;
+       }
        return true;
    }
    return false;
@@ -301,10 +311,11 @@ 
 
 
 	//determine if files.md5 exists or not
-	if(file_exists('files.md5'))
-		$skip_md5_diff = false;
-	else
-		$skip_md5_diff = true;
+	if(file_exists('files.md5')) {
+			$skip_md5_diff = false;
+	} else {
+			$skip_md5_diff = true;
+	}
 
 	// array of all tables that we need to pull rows from below
 	$getDumpsFrom = array('config' => 'config',
@@ -392,8 +403,9 @@ 
 
 
     //create directory for table definitions
-    if($getschema)
-      $tablesSchemaDir = create_cache_directory("diagnostic/".$sod_guid."/diagnostic".$curdatetime."/{$db->dbName}/TableSchema/");
+    if($getschema) {
+          $tablesSchemaDir = create_cache_directory("diagnostic/".$sod_guid."/diagnostic".$curdatetime."/{$db->dbName}/TableSchema/");
+    }
 
     //make sure they checked the box to get basic info
     if($getinfo)
@@ -547,13 +559,13 @@ 
 		if(!isset($beanFiles[$beanz]))
 		{
 			echo "<font color=orange>NO! --- ".$beanz." is not an index in \$beanFiles</font><br>";
-		}
-		else
+		} else
 		{
-			if(file_exists($beanFiles[$beanz]))
-				echo "<font color=green>YES --- ".$beanz." file \"".$beanFiles[$beanz]."\" exists</font><br>";
-			else
-				echo "<font color=red>NO! --- ".$beanz." file \"".$beanFiles[$beanz]."\" does NOT exist</font><br>";
+			if(file_exists($beanFiles[$beanz])) {
+							echo "<font color=green>YES --- ".$beanz." file \"".$beanFiles[$beanz]."\" exists</font><br>";
+			} else {
+							echo "<font color=red>NO! --- ".$beanz." file \"".$beanFiles[$beanz]."\" does NOT exist</font><br>";
+			}
 		}
 	}
 
@@ -589,8 +601,9 @@ 
 	global $curdatetime;
 	global $skip_md5_diff;
 	global $sod_guid;
-	if(file_exists('files.md5'))
-        include( 'files.md5');
+	if(file_exists('files.md5')) {
+	        include( 'files.md5');
+	}
 	//create dir for md5s
 	$md5_directory = create_cache_directory("diagnostic/".$sod_guid."/diagnostic".$curdatetime."/md5/");
 
@@ -598,15 +611,17 @@ 
 	if(!$skip_md5_diff)
 	{
 		//make sure the files.md5
-		if($filesmd5)
-			if(!copy('files.md5', $md5_directory."files.md5"))
+		if($filesmd5) {
+					if(!copy('files.md5', $md5_directory."files.md5"))
 				echo "Couldn't copy files.md5 to ".$md5_directory."<br>Skipping md5 checks.<br>";
+		}
 	}
 
 	$md5_string_calculated = generateMD5array('./');
 
-	if($md5calculated)
-		write_array_to_file('md5_string_calculated', $md5_string_calculated, $md5_directory."md5_array_calculated.php");
+	if($md5calculated) {
+			write_array_to_file('md5_string_calculated', $md5_string_calculated, $md5_directory."md5_array_calculated.php");
+	}
 
 
 	//if the files.md5 didn't exist, we can't do this
@@ -668,8 +683,9 @@ 
 
     foreach($tables as $t) {
 	$name = $t;
-	if ( $name == "does_not_exist" )
-	  continue;
+	if ( $name == "does_not_exist" ) {
+		  continue;
+	}
 	$comment = $comments[$t];
 	echo "<h2>Table: $t</h2>
 		<p><i>{$comment}</i></p>";
@@ -686,8 +702,9 @@ 
 
 	foreach($fields[$t] as $k => $v) {
 	  // we only care about physical tables ('source' can be 'non-db' or 'nondb' or 'function' )
-	  if ( isset( $v[ 'source' ] ))
-	    continue;
+	  if ( isset( $v[ 'source' ] )) {
+	  	    continue;
+	  }
 	  $columnname = $v[ 'name' ];
 	  $columntype = $v[ 'type' ];
 	  $columndbtype = $v[ 'dbType' ];
@@ -695,13 +712,20 @@ 
 	  $columncomment = $v[ 'comment' ];
 	  $columnrequired = $v[ 'required' ];
 
-	  if ( empty( $columnlen ) ) $columnlen = '<i>n/a</i>';
-	  if ( empty( $columncomment ) ) $columncomment = '<i>(none)</i>';
-	  if ( !empty( $columndbtype ) ) $columntype = $columndbtype;
-	  if ( empty( $columnrequired ) || ( $columnrequired == false ))
-	    $columndisplayrequired = 'no';
-	  else
-	    $columndisplayrequired = 'yes';
+	  if ( empty( $columnlen ) ) {
+	      $columnlen = '<i>n/a</i>';
+	  }
+	  if ( empty( $columncomment ) ) {
+	      $columncomment = '<i>(none)</i>';
+	  }
+	  if ( !empty( $columndbtype ) ) {
+	      $columntype = $columndbtype;
+	  }
+	  if ( empty( $columnrequired ) || ( $columnrequired == false )) {
+	  	    $columndisplayrequired = 'no';
+	  } else {
+	  	    $columndisplayrequired = 'yes';
+	  }
 
 	  echo '<TR BGCOLOR="#FFFFFF" ALIGN=left>
 			<TD ALIGN=left class=\"tabDetailViewDF\">'.$columnname.'</TD>

modules/Administration/RepairSeedUsers.php

Braces +7 added lines, -6 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -47,7 +49,7 @@ 
     		$status = '';
     		if($_POST['activate'] == 'false'){
     			$status = 'Inactive';
-    		}else{
+    		} else{
     			$status = 'Active';
     		}
     	}
@@ -73,18 +75,17 @@ 
 				<table cellspacing="{CELLSPACING}" class="otherview">
 					<tr>
 					    <td scope="row" width="30%"><?php echo $mod_strings['LBL_REPAIR_SEED_USERS_TITLE']; ?></td>
-					    <td><input type="submit" name="button" value="<?php if($row['status'] == 'Inactive'){echo $mod_strings['LBL_REPAIR_SEED_USERS_ACTIVATE'];}else{echo $mod_strings['LBL_REPAIR_SEED_USERS_DECACTIVATE'];} ?>"></td>
+					    <td><input type="submit" name="button" value="<?php if($row['status'] == 'Inactive'){echo $mod_strings['LBL_REPAIR_SEED_USERS_ACTIVATE'];} else{echo $mod_strings['LBL_REPAIR_SEED_USERS_DECACTIVATE'];} ?>"></td>
 					</tr>
 				</table>
 				</form>
 				</p>
 			<?php
 
-		}else{
+		} else{
 			echo 'No seed Users';
 		}
-}
-else{
+} else{
 	sugar_die($GLOBALS['app_strings']['ERR_NOT_ADMIN']);
 }
 ?>
\ No newline at end of file

modules/Administration/updater_utils.php

Braces +21 added lines, -15 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -94,10 +96,11 @@ 
 
 		if(!$send_usage_info){
 			$info['latest_tracker_id'] = -1;
-		}else{
+		} else{
 			$id=$db->getOne("select id from tracker order by date_modified desc", false, 'fetching most recent tracker entry');
-			if ( $id !== false )
-			    $info['latest_tracker_id'] = $id;
+			if ( $id !== false ) {
+						    $info['latest_tracker_id'] = $id;
+			}
 		}
 
 		$info['db_type']=$sugar_config['dbconfig']['db_type'];
@@ -105,7 +108,9 @@ 
 	}
 	if(file_exists('distro.php')){
 		include('distro.php');
-		if(!empty($distro_name))$info['distro_name'] = $distro_name;
+		if(!empty($distro_name)) {
+		    $info['distro_name'] = $distro_name;
+		}
 	}
 	$info['os'] = php_uname('s');
 	$info['os_version'] = php_uname('r');
@@ -143,14 +148,16 @@ 
 
 
 	$return_array=array();
-    if(!$from_install && empty($license))loadLicense(true);
+    if(!$from_install && empty($license)) {
+        loadLicense(true);
+    }
 
 	if(!$response_data){
 
         if($from_install){
     		$info = getBaseSystemInfo(false);
 
-        }else{
+        } else{
             $info = getSystemInfo($send_usage_info);
         }
 
@@ -183,7 +190,7 @@ 
 		}
 		$encodedResult = $sclient->call('sugarHome', array('key'=>$key, 'data'=>$encoded));
 
-	}else{
+	} else{
 		$encodedResult = 	$response_data['data'];
 		$key = $response_data['key'];
 
@@ -197,7 +204,7 @@ 
 			$resultData = array();
 			$resultData['validation'] = 'invalid validation key';
 		}
-	}else
+	} else
 	{
 		$resultData = array();
 		$resultData['versions'] = array();
@@ -209,22 +216,21 @@ 
 		if(!empty($resultData['msg'])){
 			if(!empty($resultData['msg']['admin'])){
 				$license->saveSetting('license', 'msg_admin', base64_encode($resultData['msg']['admin']));
-			}else{
+			} else{
 				$license->saveSetting('license', 'msg_admin','');
 			}
 			if(!empty($resultData['msg']['all'])){
 				$license->saveSetting('license', 'msg_all', base64_encode($resultData['msg']['all']));
-			}else{
+			} else{
 				$license->saveSetting('license', 'msg_all','');
 			}
-		}else{
+		} else{
 			$license->saveSetting('license', 'msg_admin','');
 			$license->saveSetting('license', 'msg_all','');
 		}
 		$license->saveSetting('license', 'last_validation', 'success');
 		unset($_SESSION['COULD_NOT_CONNECT']);
-	}
-	else
+	} else
 	{
 		$resultData = array();
 		$resultData['versions'] = array();
@@ -243,7 +249,7 @@ 
 	if(!empty($resultData['versions'])){
 
 		$license->saveSetting('license', 'latest_versions',base64_encode(serialize($resultData['versions'])));
-	}else{
+	} else{
 		$resultData['versions'] = array();
 		$license->saveSetting('license', 'latest_versions','')	;
 	}

modules/Administration/DiagnosticDownload.php

Braces +6 added lines, -2 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -42,7 +44,9 @@ 
 global $current_user;
 
 
-if (!is_admin($current_user)) sugar_die("Unauthorized access to administration.");
+if (!is_admin($current_user)) {
+    sugar_die("Unauthorized access to administration.");
+}
 if (isset($GLOBALS['sugar_config']['hide_admin_diagnostics']) && $GLOBALS['sugar_config']['hide_admin_diagnostics'])
 {
     sugar_die("Unauthorized access to diagnostic tool.");

modules/Administration/expandDatabase.php

Braces +4 added lines, -2 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -157,7 +159,7 @@ 
 			    echo "<b>{$mod_strings['LBL_EXPAND_DATABASE_FINISHED_ERROR']}</b><br>";
 		} //if-else
 	} //if
-}else{
+} else{
 	sugar_die($GLOBALS['app_strings']['ERR_NOT_ADMIN']);
 }
 

modules/Administration/upgrade_custom_relationships.php

Braces +12 added lines, -7 removed lines

@@ -45,13 +45,16 @@ 
 function upgrade_custom_relationships($modules = array())
 {
 	global $current_user, $moduleList;
-	if (!is_admin($current_user)) sugar_die($GLOBALS['app_strings']['ERR_NOT_ADMIN']); 
+	if (!is_admin($current_user)) {
+	    sugar_die($GLOBALS['app_strings']['ERR_NOT_ADMIN']);
+	}
 	
 	require_once("modules/ModuleBuilder/parsers/relationships/DeployedRelationships.php");
 	require_once("modules/ModuleBuilder/parsers/relationships/OneToManyRelationship.php");
 	
-	if (empty($modules))
-		$modules = $moduleList;
+	if (empty($modules)) {
+			$modules = $moduleList;
+	}
 	
 	foreach($modules as $module)
 	{
@@ -65,8 +68,9 @@ 
 			if ($def['lhs_module'] == $def['rhs_module'] && $def['is_custom'] && $def['relationship_type'] == "one-to-many")
 			{
 				$layout_defs = array();
-				if (!is_dir("custom/Extension/modules/$module/Ext/Layoutdefs") || !is_dir("custom/Extension/modules/$module/Ext/Vardefs"))
-					continue;
+				if (!is_dir("custom/Extension/modules/$module/Ext/Layoutdefs") || !is_dir("custom/Extension/modules/$module/Ext/Vardefs")) {
+									continue;
+				}
 				//Find the extension file containing the vardefs for this relationship
 				foreach(scandir("custom/Extension/modules/$module/Ext/Vardefs") as $file)
 				{
@@ -121,5 +125,6 @@ 
 	}
 }
 
-if (isset($_REQUEST['execute']) && $_REQUEST['execute'])
-	upgrade_custom_relationships();
\ No newline at end of file
+if (isset($_REQUEST['execute']) && $_REQUEST['execute']) {
+	upgrade_custom_relationships();
+}

modules/Administration/DiagnosticDelete.php

Braces +7 added lines, -6 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -60,8 +62,7 @@ 
 if(empty($_REQUEST['file']) || empty($_REQUEST['guid']))
 {
 	echo $mod_strings['LBL_DIAGNOSTIC_DELETE_ERROR'];
-}
-else
+} else
 {
     // Make sure the guid and file are valid file names for security purposes
     clean_string($_REQUEST['guid'], "ALPHANUM");
@@ -79,10 +80,10 @@ 
   	  unlink($cachedfile);
   	  rmdir(dirname($cachedfile));
 	  echo $mod_strings['LBL_DIAGNOSTIC_DELETED']."<br><br>";
+	} else {
+		  echo $mod_strings['LBL_DIAGNOSTIC_FILE'] . $_REQUEST['file'].$mod_strings['LBL_DIAGNOSTIC_ZIP'];
+	}
 	}
-	else
-	  echo $mod_strings['LBL_DIAGNOSTIC_FILE'] . $_REQUEST['file'].$mod_strings['LBL_DIAGNOSTIC_ZIP'];
-}
 
 print "<a href=\"index.php?module=Administration&action=index\">" . $mod_strings['LBL_DIAGNOSTIC_DELETE_RETURN'] . "</a><br>";
 

modules/Administration/RebuildRelationship.php

Braces +29 added lines, -17 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -67,11 +68,13 @@ 
         if ( $focus instanceOf SugarBean ) {
             $table_name = $focus->table_name ;
             $empty = array() ;
-            if (empty ( $_REQUEST [ 'silent' ] ))
-                echo $mod_strings [ 'LBL_REBUILD_REL_PROC_META' ] . $focus->table_name . "..." ;
+            if (empty ( $_REQUEST [ 'silent' ] )) {
+                            echo $mod_strings [ 'LBL_REBUILD_REL_PROC_META' ] . $focus->table_name . "..." ;
+            }
             SugarBean::createRelationshipMeta ( $focus->getObjectName (), $db, $table_name, $empty, $focus->module_dir ) ;
-            if (empty ( $_REQUEST [ 'silent' ] ))
-                echo $mod_strings [ 'LBL_DONE' ] . '<br>' ;
+            if (empty ( $_REQUEST [ 'silent' ] )) {
+                            echo $mod_strings [ 'LBL_DONE' ] . '<br>' ;
+            }
         }
     }
 }
@@ -80,7 +83,9 @@ 
 foreach ( $GLOBALS['beanFiles'] as $bean => $file )
 {
 	//skip this file if it does not exist
-	if(!file_exists($file)) continue;
+	if(!file_exists($file)) {
+	    continue;
+	}
 
 	if (! class_exists ( $bean ))
     {
@@ -90,11 +95,13 @@ 
     if ( $focus instanceOf SugarBean ) {
         $table_name = $focus->table_name ;
         $empty = array() ;
-        if (empty ( $_REQUEST [ 'silent' ] ))
-            echo $mod_strings [ 'LBL_REBUILD_REL_PROC_C_META' ] . $focus->table_name . "..." ;
+        if (empty ( $_REQUEST [ 'silent' ] )) {
+                    echo $mod_strings [ 'LBL_REBUILD_REL_PROC_C_META' ] . $focus->table_name . "..." ;
+        }
         SugarBean::createRelationshipMeta ( $focus->getObjectName (), $db, $table_name, $empty, $focus->module_dir, true ) ;
-        if (empty ( $_REQUEST [ 'silent' ] ))
-            echo $mod_strings [ 'LBL_DONE' ] . '<br>' ;
+        if (empty ( $_REQUEST [ 'silent' ] )) {
+                    echo $mod_strings [ 'LBL_DONE' ] . '<br>' ;
+        }
     }
 }
 
@@ -111,24 +118,28 @@ 
     {
         $table = isset($rel_data [ 'table' ]) ? $rel_data [ 'table' ] : "" ;
 
-        if (empty ( $_REQUEST [ 'silent' ] ))
-            echo $mod_strings [ 'LBL_REBUILD_REL_PROC_C_META' ] . $rel_name . "..." ;
+        if (empty ( $_REQUEST [ 'silent' ] )) {
+                    echo $mod_strings [ 'LBL_REBUILD_REL_PROC_C_META' ] . $rel_name . "..." ;
+        }
         SugarBean::createRelationshipMeta ( $rel_name, $db, $table, $rel_dictionary, '' ) ;
-        if (empty ( $_REQUEST [ 'silent' ] ))
-            echo $mod_strings [ 'LBL_DONE' ] . '<br>' ;
+        if (empty ( $_REQUEST [ 'silent' ] )) {
+                    echo $mod_strings [ 'LBL_DONE' ] . '<br>' ;
+        }
     }
 
 //clean relationship cache..will be rebuilt upon first access.
-if (empty ( $_REQUEST [ 'silent' ] ))
+if (empty ( $_REQUEST [ 'silent' ] )) {
     echo $mod_strings [ 'LBL_REBUILD_REL_DEL_CACHE' ] ;
+}
 Relationship::delete_cache () ;
 
 //////////////////////////////////////////////////////////////////////////////
 // Remove the "Rebuild Relationships" red text message on admin logins
 
 
-if (empty ( $_REQUEST [ 'silent' ] ))
+if (empty ( $_REQUEST [ 'silent' ] )) {
     echo $mod_strings [ 'LBL_REBUILD_REL_UPD_WARNING' ] ;
+}
 
 // clear the database row if it exists (just to be sure)
 $query = "DELETE FROM versions WHERE name='Rebuild Relationships'" ;
@@ -153,6 +164,7 @@ 
     unset ( $_SESSION [ 'rebuild_relationships' ] ) ;
 }
 
-if (empty ( $_REQUEST [ 'silent' ] ))
+if (empty ( $_REQUEST [ 'silent' ] )) {
     echo $mod_strings [ 'LBL_DONE' ] ;
+}
 ?>