adamjakab / SuiteCRM

modules/ModuleBuilder/parsers/parser.modifylistview.php

Braces +22 added lines, -15 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
-die ( 'Not A Valid Entry Point' ) ;
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
+    die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -121,8 +122,7 @@ 
 			    if (! isset($def['studio']) || $def['studio'] === true)
 			    {
 			        $this->defaults [ $key ] = $def ;
-			    }
-			    else
+			    } else
 			    // anything which doesn't go into the defaults is a reserved field - this makes sure we don't miss anything
 			    {
 			        $this->reserved [ $key ] = $def;
@@ -167,13 +167,16 @@ 
 		foreach ( $modFields as $key => $def )
 		{
 			$fieldName = strtolower ( $key ) ;
-            if ($fieldName == 'currency_id')
-                continue;
-			if (!isset ( $lowerFieldList [ $fieldName ] )) // bug 16728 - check this first, so that other conditions (e.g., studio == visible) can't override and add duplicate entries
+            if ($fieldName == 'currency_id') {
+                            continue;
+            }
+			if (!isset ( $lowerFieldList [ $fieldName ] )) {
+			    // bug 16728 - check this first, so that other conditions (e.g., studio == visible) can't override and add duplicate entries
 			{
             // bug 19656: this test changed after 5.0.0b - we now remove all ID type fields - whether set as type, or dbtype, from the fielddefs
             if ($this->isValidField($key, $def)){
 					$label = (isset ( $def [ 'vname' ] )) ? $def [ 'vname' ] : (isset($def [ 'label' ]) ? $def['label'] : $def['name']) ;
+			}
 					$this->availableFields [ $fieldName ] = array ( 'width' => '10' , 'label' => $label ) ;
 				}
 			}
@@ -190,20 +193,24 @@ 
 	
 	function isValidField($key, $def) {
 	    //Allow fields that are studio visible  
-		if (! empty ( $def [ 'studio' ] ) && $def [ 'studio' ] == 'visible')
-		  return true;
+		if (! empty ( $def [ 'studio' ] ) && $def [ 'studio' ] == 'visible') {
+				  return true;
+		}
 		  
 		//No ID fields
-		if  ((!empty ( $def [ 'dbType' ] ) && $def [ 'dbType' ] == 'id') || (!empty ( $def [ 'type' ] ) && $def [ 'type' ] == 'id'))
-		  return false;
+		if  ((!empty ( $def [ 'dbType' ] ) && $def [ 'dbType' ] == 'id') || (!empty ( $def [ 'type' ] ) && $def [ 'type' ] == 'id')) {
+				  return false;
+		}
 		  
 		//only allow DB and custom fields (if a source is specified)
-	    if (!empty($def [ 'source' ]) && $def [ 'source' ] != 'db' && $def [ 'source' ] != 'custom_fields')
-		  return false;
+	    if (!empty($def [ 'source' ]) && $def [ 'source' ] != 'db' && $def [ 'source' ] != 'custom_fields') {
+	    		  return false;
+	    }
 
 		//Dont ever show the "deleted" fields or "_name" fields
-		if (strcmp ( $key, 'deleted' ) == 0 || (isset ( $def [ 'name' ] ) && strpos ( $def [ 'name' ], "_name" ) !== false))
-	       return false;
+		if (strcmp ( $key, 'deleted' ) == 0 || (isset ( $def [ 'name' ] ) && strpos ( $def [ 'name' ], "_name" ) !== false)) {
+			       return false;
+		}
 
 	    //If none of the "ifs" are true, the field is valid
 	    return true;

modules/Reminders_Invitees/Reminder_Invitee.php

Braces +6 added lines, -7 removed lines

@@ -76,7 +76,9 @@ 
     public static function saveRemindersInviteesData($reminderId, $inviteesData) {
         $savedInviteeIds = array();
         foreach($inviteesData as $k => $inviteeData) {
-            if(isset($_POST['isDuplicate']) && $_POST['isDuplicate']) $inviteeData->id = '';
+            if(isset($_POST['isDuplicate']) && $_POST['isDuplicate']) {
+                $inviteeData->id = '';
+            }
             $reminderInviteeBean = BeanFactory::getBean('Reminders_Invitees', $inviteeData->id);
             $reminderInviteeBean->reminder_id = $reminderId;
             $reminderInviteeBean->related_invitee_module = $inviteeData->module;
@@ -84,8 +86,7 @@ 
             if(!$inviteeData->id) {
                 $reminderInviteeBean->save();
                 $savedInviteeIds[] = $reminderInviteeBean->id;
-            }
-            else {
+            } else {
                 $addedInvitees = BeanFactory::getBean('Reminders_Invitees')->get_full_list("", "reminders_invitees.id != '{$inviteeData->id}' AND reminders_invitees.reminder_id = '{$reminderInviteeBean->reminder_id}' AND reminders_invitees.related_invitee_module = '{$reminderInviteeBean->related_invitee_module}' AND reminders_invitees.related_invitee_module_id = '{$reminderInviteeBean->related_invitee_module_id}'");
                 if (!$addedInvitees) {
                     $reminderInviteeBean->save();
@@ -132,11 +133,9 @@ 
             default:
                 if(isset($bean->first_name) && isset($bean->last_name)) {
                     $retValue = "{$bean->first_name} {$bean->last_name}";
-                }
-                else if(isset($bean->name)) {
+                } else if(isset($bean->name)) {
                     $retValue = $bean->name;
-                }
-                else if(isset($bean->email)) {
+                } else if(isset($bean->email)) {
                     $retValue = $bean->email;
                 }
                 if(!$retValue) {

modules/AOP_Case_Updates/Case_Updates.php

Braces +6 added lines, -4 removed lines

@@ -159,7 +159,7 @@ 
         $bDate = $b->fetched_row['date_entered'];
         if($aDate < $bDate){
             return -1;
-        }elseif($aDate > $bDate){
+        } elseif($aDate > $bDate){
             return 1;
         }
         return 0;
@@ -195,9 +195,9 @@ 
     global $mod_strings;
     if($update->contact_id){
         $name = $update->getUpdateContact()->name;
-    }elseif($update->assigned_user_id){
+    } elseif($update->assigned_user_id){
         $name = $update->getUpdateUser()->name;
-    }else{
+    } else{
         $name = "Unknown";
     }
     $html = "<a href='' onclick='toggleCaseUpdate(\"".$update->id."\");return false;'>";
@@ -281,7 +281,9 @@ 
     global $action;
 
     //on DetailView only
-    if($action != 'DetailView') return;
+    if($action != 'DetailView') {
+        return;
+    }
 
     //current record id
     $record = $_GET['record'];

modules/AOP_Case_Updates/AOPAssignManager.php

Braces +5 added lines, -6 removed lines

@@ -10,13 +10,13 @@ 
         $this->ieX = $ieX;
         if($ieX) {
             $inboundDistribMethod = $ieX->get_stored_options("distrib_method", "");
-        }else{
+        } else{
             $inboundDistribMethod = '';
         }
         if($this->isAOPFallback($inboundDistribMethod)){
             $this->distributionMethod = $sugar_config['aop']['distribution_method'];
             $this->aopFallback = true;
-        }else{
+        } else{
             $this->distributionMethod = $inboundDistribMethod;
             $this->aopFallback = false;
         }
@@ -31,7 +31,7 @@ 
         global $sugar_config;
         if($this->aopFallback){
             return $sugar_config['aop']['distribution_options'];
-        }else{
+        } else{
             return $this->ieX->get_stored_options("distribution_options", '');
         }
     }
@@ -97,7 +97,7 @@ 
         }
         if($this->aopFallback){
             $this->singleUser = !empty($sugar_config['aop']['distribution_user_id']) ? $sugar_config['aop']['distribution_user_id'] : '';
-        }else{
+        } else{
             $this->singleUser = $this->ieX->get_stored_options("distribution_user_id", "");
         }
         return $this->singleUser;
@@ -166,8 +166,7 @@ 
         $file = create_cache_directory('modules/AOP_Case_Updates/Users/') . $id . 'lastUser.cache.php';
         if(isset($_SESSION['AOPlastuser'][$id]) && $_SESSION['AOPlastuser'][$id] != '') {
             $lastUserId = $_SESSION['AOPlastuser'][$id];
-        }
-        else if (is_file($file)){
+        } else if (is_file($file)){
             include $file;
             if(isset($lastUser['User']) && $lastUser['User'] != '') {
                 $lastUserId = $lastUser['User'];

modules/Import/ImportFieldSanitize.php

Braces +56 added lines, -39 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -93,14 +95,16 @@ 
         }
         $value = $params[0];
         $vardef = $params[1];
-        if ( isset($params[2]) )
-            $focus = $params[2];
-        else
-            $focus = null;
-        if ( $name == 'relate' && !empty($params[3]) )
-            $this->addRelatedBean = true;
-        else
-            $this->addRelatedBean = false;
+        if ( isset($params[2]) ) {
+                    $focus = $params[2];
+        } else {
+                    $focus = null;
+        }
+        if ( $name == 'relate' && !empty($params[3]) ) {
+                    $this->addRelatedBean = true;
+        } else {
+                    $this->addRelatedBean = false;
+        }
         
         $field = $sfh->getSugarField(ucfirst($name));
         if ( $field instanceOf SugarFieldBase ) {
@@ -128,11 +132,13 @@ 
 
         $format = $this->dateformat;
 
-        if ( !$timedate->check_matching_format($value, $format) )
-            return false;
+        if ( !$timedate->check_matching_format($value, $format) ) {
+                    return false;
+        }
 
-        if ( !$this->isValidTimeDate($value, $format) )
-            return false;
+        if ( !$this->isValidTimeDate($value, $format) ) {
+                    return false;
+        }
 
         $value = $timedate->swap_formats(
             $value, $format, $timedate->get_date_format());
@@ -199,8 +205,7 @@ 
                         || $focus_user->retrieve($eachItem)
                 ) {
                     // all good
-                }
-                else {
+                } else {
                     $isValid     = false;
                     $bad_names[] = $eachItem;
                     continue;
@@ -232,11 +237,13 @@ 
 
         $format = $this->timeformat;
 
-        if ( !$timedate->check_matching_format($value, $format) )
-            return false;
+        if ( !$timedate->check_matching_format($value, $format) ) {
+                    return false;
+        }
 
-        if ( !$this->isValidTimeDate($value, $format) )
-            return false;
+        if ( !$this->isValidTimeDate($value, $format) ) {
+                    return false;
+        }
 
         $value = $timedate->swap_formats(
             $value, $format, $timedate->get_time_format());
@@ -266,47 +273,57 @@ 
         $reg = $timedate->get_regular_expression($format);
         preg_match('@'.$reg['format'].'@', $value, $dateparts);
 
-        if ( empty($dateparts) )
-            return false;
+        if ( empty($dateparts) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['a'])
-                && !in_array($dateparts[$reg['positions']['a']], array('am','pm')) )
-            return false;
+                && !in_array($dateparts[$reg['positions']['a']], array('am','pm')) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['A'])
-                && !in_array($dateparts[$reg['positions']['A']], array('AM','PM')) )
-            return false;
+                && !in_array($dateparts[$reg['positions']['A']], array('AM','PM')) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['h']) && (
                 !is_numeric($dateparts[$reg['positions']['h']])
                 || $dateparts[$reg['positions']['h']] < 1
-                || $dateparts[$reg['positions']['h']] > 12 ) )
-            return false;
+                || $dateparts[$reg['positions']['h']] > 12 ) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['H']) && (
                 !is_numeric($dateparts[$reg['positions']['H']])
                 || $dateparts[$reg['positions']['H']] < 0
-                || $dateparts[$reg['positions']['H']] > 23 ) )
-            return false;
+                || $dateparts[$reg['positions']['H']] > 23 ) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['i']) && (
                 !is_numeric($dateparts[$reg['positions']['i']])
                 || $dateparts[$reg['positions']['i']] < 0
-                || $dateparts[$reg['positions']['i']] > 59 ) )
-            return false;
+                || $dateparts[$reg['positions']['i']] > 59 ) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['s']) && (
                 !is_numeric($dateparts[$reg['positions']['s']])
                 || $dateparts[$reg['positions']['s']] < 0
-                || $dateparts[$reg['positions']['s']] > 59 ) )
-            return false;
+                || $dateparts[$reg['positions']['s']] > 59 ) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['d']) && (
                 !is_numeric($dateparts[$reg['positions']['d']])
                 || $dateparts[$reg['positions']['d']] < 1
-                || $dateparts[$reg['positions']['d']] > 31 ) )
-            return false;
+                || $dateparts[$reg['positions']['d']] > 31 ) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['m']) && (
                 !is_numeric($dateparts[$reg['positions']['m']])
                 || $dateparts[$reg['positions']['m']] < 1
-                || $dateparts[$reg['positions']['m']] > 12 ) )
-            return false;
+                || $dateparts[$reg['positions']['m']] > 12 ) ) {
+                    return false;
+        }
         if ( isset($reg['positions']['Y']) &&
-                !is_numeric($dateparts[$reg['positions']['Y']]) )
-            return false;
+                !is_numeric($dateparts[$reg['positions']['Y']]) ) {
+                    return false;
+        }
 
         return true;
     }

modules/Import/maps/ImportMap.php

Braces +16 added lines, -10 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -227,7 +229,9 @@ 
 
         // Bug 23354 - Make sure enclosure gets saved as an empty string if
         // it is an empty string, instead of as a null
-        if ( strlen($enclosure) <= 0 ) $enclosure = ' ';
+        if ( strlen($enclosure) <= 0 ) {
+            $enclosure = ' ';
+        }
 
         $this->assigned_user_id = $owner_id;
         $this->name             = $name;
@@ -266,8 +270,9 @@ 
             $other_map = new ImportMap();
             $other_map->retrieve_by_string_fields(array('id'=> $id), false);
 
-            if ( $other_map->assigned_user_id != $current_user->id )
-                return false;
+            if ( $other_map->assigned_user_id != $current_user->id ) {
+                            return false;
+            }
         }
 
         return parent::mark_deleted($id);
@@ -287,8 +292,9 @@ 
     {
         global $current_user;
 
-        if ( !is_admin($current_user) )
-            return false;
+        if ( !is_admin($current_user) ) {
+                    return false;
+        }
 
         // check for problems
         if ($flag) {
@@ -299,8 +305,7 @@ 
                 'name'         =>$this->name,
                 'is_published' =>'yes'
                 );
-        }
-        else {
+        } else {
             // if you are trying to unpublish a map
             // but you own an unpublished map by the same name
             $query_arr = array(
@@ -313,8 +318,9 @@ 
         $other_map->retrieve_by_string_fields($query_arr, false);
 
         // if we find this other map, quit
-        if ( isset($other_map->id) )
-            return false;
+        if ( isset($other_map->id) ) {
+                    return false;
+        }
 
         // otherwise update the is_published flag
         $query = "UPDATE $this->table_name

modules/Import/ImportDuplicateCheck.php

Braces +64 added lines, -42 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -83,18 +85,20 @@ 
             $indexes = array_merge($custmIndexes,$indexes);
         }
 
-        if ( $this->_focus->getFieldDefinition('email1') )
-            $indexes[] = array(
+        if ( $this->_focus->getFieldDefinition('email1') ) {
+                    $indexes[] = array(
                 'name' => 'special_idx_email1',
                 'type' => 'index',
                 'fields' => array('email1')
                 );
-        if ( $this->_focus->getFieldDefinition('email2') )
-            $indexes[] = array(
+        }
+        if ( $this->_focus->getFieldDefinition('email2') ) {
+                    $indexes[] = array(
                 'name' => 'special_idx_email2',
                 'type' => 'index',
                 'fields' => array('email2')
                 );
+        }
 
         return $indexes;
     }
@@ -116,12 +120,15 @@ 
             if ($index['type'] == "index"){
                 $labelsArray = array();
                 foreach ($index['fields'] as $field){
-                    if ($field == 'deleted') continue;
+                    if ($field == 'deleted') {
+                        continue;
+                    }
                     $fieldDef = $this->_focus->getFieldDefinition($field);
-                    if ( isset($fieldDef['vname']) && isset($super_language_pack[$fieldDef['vname']]) )
-                        $labelsArray[$fieldDef['name']] = $super_language_pack[$fieldDef['vname']];
-                    else
-                        $labelsArray[$fieldDef['name']] = $fieldDef['name'];
+                    if ( isset($fieldDef['vname']) && isset($super_language_pack[$fieldDef['vname']]) ) {
+                                            $labelsArray[$fieldDef['name']] = $super_language_pack[$fieldDef['vname']];
+                    } else {
+                                            $labelsArray[$fieldDef['name']] = $fieldDef['name'];
+                    }
                 }
                 $index_array[$index['name']] = str_replace(":", "",implode(", ",$labelsArray));
             }
@@ -144,33 +151,37 @@ 
             {
                 $emailAddress = new SugarEmailAddress();
                 $email = $field;
-                if ( $emailAddress->getCountEmailAddressByBean($this->_focus->$email,$this->_focus,($field == 'email1')) > 0 )
-                    return true;
-            }
-            else
+                if ( $emailAddress->getCountEmailAddressByBean($this->_focus->$email,$this->_focus,($field == 'email1')) > 0 ) {
+                                    return true;
+                }
+            } else
             {
                 $index_fields = array('deleted' => '0');
                 if( is_array($field) )
                 {
                     foreach($field as $tmpField)
                     {
-                        if ($tmpField == 'deleted')
-                            continue;
-                        if (strlen($this->_focus->$tmpField) > 0)
-                            $index_fields[$tmpField] = $this->_focus->$tmpField;
+                        if ($tmpField == 'deleted') {
+                                                    continue;
+                        }
+                        if (strlen($this->_focus->$tmpField) > 0) {
+                                                    $index_fields[$tmpField] = $this->_focus->$tmpField;
+                        }
                     }
+                } elseif($field != 'deleted' && strlen($this->_focus->$field) > 0) {
+                                    $index_fields[$field] = $this->_focus->$field;
                 }
-                elseif($field != 'deleted' && strlen($this->_focus->$field) > 0)
-                    $index_fields[$field] = $this->_focus->$field;
 
-                if ( count($index_fields) <= 1 )
-                    continue;
+                if ( count($index_fields) <= 1 ) {
+                                    continue;
+                }
 
                 $newfocus = loadBean($this->_focus->module_dir);
                 $result = $newfocus->retrieve_by_string_fields($index_fields,true);
 
-                if ( !is_null($result) )
-                    return true;
+                if ( !is_null($result) ) {
+                                    return true;
+                }
             }
         }
 
@@ -204,13 +215,15 @@ 
         $fieldlist=array();
         $customIndexlist=array();
         foreach($origIndexList as $iv){
-            if(empty($iv)) continue;
+            if(empty($iv)) {
+                continue;
+            }
             $field_index_array = explode('::',$iv);
             if($field_index_array[0] == 'customfield'){
                 //this is a custom field, so place in custom array
                 $customIndexlist[] = $field_index_array[1];
 
-            }else{
+            } else{
                 //this is not a custom field, so place in index list
                 $indexlist[] = $field_index_array[0];
                 if(isset($field_index_array[1])) {
@@ -237,8 +250,9 @@ 
         // loop through var def indexes and compare with selected indexes
         foreach ($this->_getIndexVardefs() as $index){
             // if we get an index not in the indexlist, loop
-            if ( !in_array($index['name'],$indexlist) )
-                continue;
+            if ( !in_array($index['name'],$indexlist) ) {
+                            continue;
+            }
 
             // This handles the special case of duplicate email checking
             if ( $index['name'] == 'special_idx_email1' || $index['name'] == 'special_idx_email2' ) {
@@ -249,31 +263,35 @@ 
                         $this->_focus,
                         ($index['name'] == 'special_idx_email1')
                         ) > 0 ){ foreach($index['fields'] as $field){
-                        if($field !='deleted')
-                            $this->_dupedFields[] = $field;
+                        if($field !='deleted') {
+                                                    $this->_dupedFields[] = $field;
+                        }
                     }
                 }
             }
             // Adds a hook so you can define a method in the bean to handle dupe checking
             elseif ( isset($index['dupeCheckFunction']) ) {
                 $functionName = substr_replace($index['dupeCheckFunction'],'',0,9);
-                if ( method_exists($this->_focus,$functionName) && $this->_focus->$functionName($index) === true)
-                    return $this->_focus->$functionName($index);
-            }
-            else {
+                if ( method_exists($this->_focus,$functionName) && $this->_focus->$functionName($index) === true) {
+                                    return $this->_focus->$functionName($index);
+                }
+            } else {
                 $index_fields = array('deleted' => '0');
                 //search only for the field we have selected
                 foreach($index['fields'] as $field){
-                    if ($field == 'deleted' ||  !in_array($field,$fieldlist))
-                        continue;
-                    if (!in_array($field,$index_fields))
-                        if (isset($this->_focus->$field) && strlen($this->_focus->$field) > 0)
+                    if ($field == 'deleted' ||  !in_array($field,$fieldlist)) {
+                                            continue;
+                    }
+                    if (!in_array($field,$index_fields)) {
+                                            if (isset($this->_focus->$field) && strlen($this->_focus->$field) > 0)
                             $index_fields[$field] = $this->_focus->$field;
+                    }
                 }
 
                 // if there are no valid fields in the index field list, loop
-                if ( count($index_fields) <= 1 )
-                    continue;
+                if ( count($index_fields) <= 1 ) {
+                                    continue;
+                }
 
                 $newfocus = loadBean($this->_focus->module_dir);
                 $result = $newfocus->retrieve_by_string_fields($index_fields,true);
@@ -320,11 +338,15 @@ 
                     $fieldName='';
 
                     //skip this field if it is the deleted field, not in the importable keys array, or a field in the exclude array
-                    if (!in_array($field, $importable_keys) || in_array($field, $exclude_array)) continue;
+                    if (!in_array($field, $importable_keys) || in_array($field, $exclude_array)) {
+                        continue;
+                    }
                     $fieldDef = $this->_focus->getFieldDefinition($field);
 
                     //skip if this field is already defined (from another index)
-                    if (in_array($fieldDef['name'],$fields_used)) continue;
+                    if (in_array($fieldDef['name'],$fields_used)) {
+                        continue;
+                    }
 
                     //get the proper export label
                     $fieldName = translateForExport($fieldDef['name'],$this->_focus);

modules/Cases/metadata/additionalDetails.php

Braces +9 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,12 +54,16 @@ 
 		
 	if(!empty($fields['DESCRIPTION'])) { 
 		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['DESCRIPTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 		$overlib_string .= '<br>';
 	}
 	if(!empty($fields['RESOLUTION'])) { 
 		$overlib_string .= '<b>'. $mod_strings['LBL_RESOLUTION'] . '</b> ' . substr($fields['RESOLUTION'], 0, 300);
-		if(strlen($fields['RESOLUTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['RESOLUTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 	}		
 	
 	return array('fieldToAddTo' => 'NAME', 

modules/Opportunities/SubPanelView.php

Braces +7 added lines, -4 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -69,7 +71,9 @@ 
 
 $button  = "<form action='index.php' method='post' name='form' id='form'>\n";
 $button .= "<input type='hidden' name='module' value='Opportunities'>\n";
-if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
+if ($currentModule == 'Accounts') {
+    $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
+}
 if ($currentModule == 'Contacts') {
 	$button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
 	$button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
@@ -105,8 +109,7 @@ 
 		."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
 		."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
 //		."  ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
-}
-else
+} else
 {
 	///////////////////////////////////////
 	///