adamjakab / SuiteCRM

modules/Opportunities/metadata/searchdefs.php

Spacing +19 added lines, -19 removed lines

@@ -39,67 +39,67 @@ 
 
 $searchdefs['Opportunities'] = array(
   'templateMeta' => 
-  array (
+  array(
     'maxColumns' => '3',
     'maxColumnsBasic' => '4', 
     'widths' => 
-    array (
+    array(
       'label' => '10',
       'field' => '30',
     ),
   ),
   'layout' => 
-  array (
+  array(
     'basic_search' => 
-    array (
+    array(
       'name' => 
-      array (
+      array(
         'name' => 'name',
         'default' => true,
         'width' => '10%',
       ),
       'current_user_only' => 
-      array (
+      array(
         'name' => 'current_user_only',
         'label' => 'LBL_CURRENT_USER_FILTER',
         'type' => 'bool',
         'default' => true,
         'width' => '10%',
       ),
-	  array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
-      array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
+	  array('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
+      array('name' => 'favorites_only', 'label' => 'LBL_FAVORITES_FILTER', 'type' => 'bool',),
 
     ),
     'advanced_search' => 
-    array (
+    array(
       'name' => 
-      array (
+      array(
         'name' => 'name',
         'default' => true,
         'width' => '10%',
       ),
       'account_name' => 
-      array (
+      array(
         'name' => 'account_name',
         'default' => true,
         'width' => '10%',
       ),
       'amount' => 
-      array (
+      array(
         'name' => 'amount',
         'default' => true,
         'width' => '10%',
       ),
       'assigned_user_id' => 
-      array (
+      array(
         'name' => 'assigned_user_id',
         'type' => 'enum',
         'label' => 'LBL_ASSIGNED_TO',
         'function' => 
-        array (
+        array(
           'name' => 'get_user_array',
           'params' => 
-          array (
+          array(
             0 => false,
           ),
         ),
@@ -107,25 +107,25 @@ 
         'width' => '10%',
       ),
       'sales_stage' => 
-      array (
+      array(
         'name' => 'sales_stage',
         'default' => true,
         'width' => '10%',
       ),
       'lead_source' => 
-      array (
+      array(
         'name' => 'lead_source',
         'default' => true,
         'width' => '10%',
       ),
       'date_closed' => 
-      array (
+      array(
         'name' => 'date_closed',
         'default' => true,
         'width' => '10%',
       ),
       'next_step' => 
-      array (
+      array(
         'type' => 'varchar',
         'label' => 'LBL_NEXT_STEP',
         'width' => '10%',

modules/Opportunities/metadata/SearchFields.php

Spacing +18 added lines, -18 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -40,16 +40,16 @@ 
 global $current_user;
 $module_name = "Opportunities";
 $searchFields['Opportunities'] = 
-	array (
-		'name' => array( 'query_type'=>'default'),
-		'account_name'=> array('query_type'=>'default','db_field'=>array('accounts.name')),
+	array(
+		'name' => array('query_type'=>'default'),
+		'account_name'=> array('query_type'=>'default', 'db_field'=>array('accounts.name')),
 		'amount'=> array('query_type'=>'default'),
 		'next_step'=> array('query_type'=>'default'),
 		'probability'=> array('query_type'=>'default'),
 		'lead_source'=> array('query_type'=>'default', 'operator'=>'=', 'options' => 'lead_source_dom', 'template_var' => 'LEAD_SOURCE_OPTIONS'),
 		'opportunity_type'=> array('query_type'=>'default', 'operator'=>'=', 'options' => 'opportunity_type_dom', 'template_var' => 'TYPE_OPTIONS'),
 		'sales_stage'=> array('query_type'=>'default', 'operator'=>'=', 'options' => 'sales_stage_dom', 'template_var' => 'SALES_STAGE_OPTIONS', 'options_add_blank' => true),
-		'current_user_only'=> array('query_type'=>'default','db_field'=>array('assigned_user_id'),'my_items'=>true, 'vname' => 'LBL_CURRENT_USER_FILTER', 'type' => 'bool'),
+		'current_user_only'=> array('query_type'=>'default', 'db_field'=>array('assigned_user_id'), 'my_items'=>true, 'vname' => 'LBL_CURRENT_USER_FILTER', 'type' => 'bool'),
 		'assigned_user_id'=> array('query_type'=>'default'),
 		'open_only' => array(
 			'query_type'=>'default',
@@ -64,24 +64,24 @@ 
             'subquery' => 'SELECT favorites.parent_id FROM favorites
 			                    WHERE favorites.deleted = 0
 			                        and favorites.parent_type = "'.$module_name.'"
-			                        and favorites.assigned_user_id = "' .$current_user->id . '") OR NOT ({0}',
+			                        and favorites.assigned_user_id = "' .$current_user->id.'") OR NOT ({0}',
             'db_field'=>array('id')),
 
 		//Range Search Support 
-	   'range_date_entered' => array ('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
-	   'start_range_date_entered' => array ('query_type' => 'default',  'enable_range_search' => true, 'is_date_field' => true),
-	   'end_range_date_entered' => array ('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
-	   'range_date_modified' => array ('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
-	   'start_range_date_modified' => array ('query_type' => 'default',  'enable_range_search' => true, 'is_date_field' => true),
-       'end_range_date_modified' => array ('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),	
+	   'range_date_entered' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+	   'start_range_date_entered' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+	   'end_range_date_entered' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+	   'range_date_modified' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+	   'start_range_date_modified' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+       'end_range_date_modified' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),	
 	   
-       'range_date_closed' => array ('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
-	   'start_range_date_closed' => array ('query_type' => 'default',  'enable_range_search' => true, 'is_date_field' => true),
-       'end_range_date_closed' => array ('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),	
+       'range_date_closed' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+	   'start_range_date_closed' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),
+       'end_range_date_closed' => array('query_type' => 'default', 'enable_range_search' => true, 'is_date_field' => true),	
 
-       'range_amount' => array ('query_type' => 'default', 'enable_range_search' => true),
-	   'start_range_amount' => array ('query_type' => 'default',  'enable_range_search' => true),
-       'end_range_amount' => array ('query_type' => 'default', 'enable_range_search' => true),
+       'range_amount' => array('query_type' => 'default', 'enable_range_search' => true),
+	   'start_range_amount' => array('query_type' => 'default', 'enable_range_search' => true),
+       'end_range_amount' => array('query_type' => 'default', 'enable_range_search' => true),
 		//Range Search Support 			
 	);
 ?>

modules/Opportunities/metadata/detailviewdefs.php

Spacing +27 added lines, -27 removed lines

@@ -38,15 +38,15 @@ 
  ********************************************************************************/
 
 $viewdefs ['Opportunities'] = 
-array (
+array(
   'DetailView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'form' => 
-      array (
+      array(
         'buttons' => 
-        array (
+        array(
           0 => 'EDIT',
           1 => 'DUPLICATE',
           2 => 'DELETE',
@@ -55,95 +55,95 @@ 
       ),
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'useTabs' => true,
       'tabDefs' => 
-      array (
+      array(
         'DEFAULT' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'default' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 'name',
           1 => 'account_name',
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'amount',
             'label' => '{$MOD.LBL_AMOUNT} ({$CURRENCY})',
           ),
           1 => 'date_closed',
         ),
         2 => 
-        array (
+        array(
           0 => 'sales_stage',
           1 => 'opportunity_type',
         ),
         3 => 
-        array (
+        array(
           0 => 'probability',
           1 => 'lead_source',
         ),
         4 => 
-        array (
+        array(
           0 => 'next_step',
           1 => 'campaign_name',
         ),
         5 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
             'nl2br' => true,
           ),
         ),
         6 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO',
           ),
         ),
       ),
       'LBL_PANEL_ASSIGNMENT' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_modified',
             'label' => 'LBL_DATE_MODIFIED',
             'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',
           ),
           1 =>
-          array (
+          array(
             'name' => 'date_entered',
             'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
           ),

modules/Opportunities/metadata/quickcreatedefs.php

Spacing +21 added lines, -21 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,23 +45,23 @@ 
  * Contributor(s): ______________________________________..
  ********************************************************************************/
 
-$viewdefs = array (
+$viewdefs = array(
   'Opportunities' => 
-  array (
+  array(
     'QuickCreate' => 
-    array (
+    array(
       'templateMeta' => 
-      array (
+      array(
         'maxColumns' => '2',
         'widths' => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'label' => '10',
             'field' => '30',
           ),
           1 => 
-          array (
+          array(
             'label' => '10',
             'field' => '30',
           ),
@@ -69,40 +69,40 @@ 
         'javascript' => '{$PROBABILITY_SCRIPT}',
       ),
       'panels' => 
-      array (
+      array(
         'DEFAULT' => 
-        array (
-          array (
-            array (
+        array(
+          array(
+            array(
               'name' => 'name',
               'displayParams'=>array('required'=>true),
             ),
-            array (
+            array(
               'name' => 'account_name',
             ),
           ),
-          array (
-            array (
+          array(
+            array(
               'name' => 'currency_id',
             ),
-            array (
+            array(
               'name' => 'opportunity_type',
             ),            
           ),
-          array (
+          array(
             'amount',
             'date_closed'          
           ),
-          array (
+          array(
              'next_step',
              'sales_stage',
           ),
-          array (
+          array(
              'lead_source',
              'probability',
           ),
-        array (
-            array (
+        array(
+            array(
               'name' => 'assigned_user_name',
             ),
         ),

modules/Opportunities/OpportunityFormBase.php

Spacing +57 added lines, -57 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -41,31 +41,31 @@ 
 
 
 
-class OpportunityFormBase{
+class OpportunityFormBase {
 
 
-function checkForDuplicates($prefix){
+function checkForDuplicates($prefix) {
 	require_once('include/formbase.php');
 	
 	$focus = new Opportunity();
 	$query = '';
 	$baseQuery = 'select id, name, sales_stage,amount, date_closed  from opportunities where deleted!=1 and (';
 
-	if(isset($_POST[$prefix.'name']) && !empty($_POST[$prefix.'name'])){
-		$query = $baseQuery ."  name like '%".$_POST[$prefix.'name']."%'";
+	if (isset($_POST[$prefix.'name']) && !empty($_POST[$prefix.'name'])) {
+		$query = $baseQuery."  name like '%".$_POST[$prefix.'name']."%'";
 		$query .= getLikeForEachWord('name', $_POST[$prefix.'name']);
 	}
 
-	if(!empty($query)){
+	if (!empty($query)) {
 		$rows = array();
 		global $db;
 		$result = $db->query($query.')');
-		$i=-1;
-		while(($row=$db->fetchByAssoc($result)) != null) {
+		$i = -1;
+		while (($row = $db->fetchByAssoc($result)) != null) {
 			$i++;
 			$rows[$i] = $row;
 		}
-		if ($i==-1) return null;
+		if ($i == -1) return null;
 		
 		return $rows;		
 	}
@@ -73,14 +73,14 @@ 
 }
 
 
-function buildTableForm($rows, $mod='Opportunities'){
-	if(!empty($mod)){
+function buildTableForm($rows, $mod = 'Opportunities') {
+	if (!empty($mod)) {
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
-	}else global $mod_strings;
+	} else global $mod_strings;
 	global $app_strings;
 	$cols = sizeof($rows[0]) * 2 + 1;
-	$form = '<table width="100%"><tr><td>'.$mod_strings['MSG_DUPLICATE']. '</td></tr><tr><td height="20"></td></tr></table>';
+	$form = '<table width="100%"><tr><td>'.$mod_strings['MSG_DUPLICATE'].'</td></tr><tr><td height="20"></td></tr></table>';
 
 	$form .= "<form action='index.php' method='post' name='dupOpps'><input type='hidden' name='selectedOpportunity' value=''>";
 	$form .= "<table width='100%' cellpadding='0' cellspacing='0' class='list view'>";
@@ -88,34 +88,34 @@ 
 	$form .= "<tr><td scope='col'>&nbsp;</td>";
     require_once('include/formbase.php');
 	$form .= getPostToForm();
-	if(isset($rows[0])){
-		foreach ($rows[0] as $key=>$value){
-			if($key != 'id'){
-					$form .= "<td scope='col'>". $mod_strings[$mod_strings['db_'.$key]]. "</td>";
+	if (isset($rows[0])) {
+		foreach ($rows[0] as $key=>$value) {
+			if ($key != 'id') {
+					$form .= "<td scope='col'>".$mod_strings[$mod_strings['db_'.$key]]."</td>";
 		}}
 		$form .= "</tr>";
 	}
 
 	$rowColor = 'oddListRowS1';
-	foreach($rows as $row){
+	foreach ($rows as $row) {
 
 		$form .= "<tr class='$rowColor'>";
 
 		$form .= "<td width='1%' nowrap='nowrap'><a href='#' onclick='document.dupOpps.selectedOpportunity.value=\"${row['id']}\";document.dupOpps.submit();'>[${app_strings['LBL_SELECT_BUTTON_LABEL']}]</a>&nbsp;&nbsp;</td>";
 		$wasSet = false;
-		foreach ($row as $key=>$value){
-				if($key != 'id'){
-					if(!$wasSet){
+		foreach ($row as $key=>$value) {
+				if ($key != 'id') {
+					if (!$wasSet) {
 					$form .= "<td scope='row'><a target='_blank' href='index.php?module=Opportunities&action=DetailView&record=${row['id']}'>$value</a></td>";
 					$wasSet = true;
-					}else{
+					} else {
 					$form .= "<td><a target='_blank' href='index.php?module=Opportunities&action=DetailView&record=${row['id']}'>$value</a></td>";
 					}
 				}}
 
-		if($rowColor == 'evenListRowS1'){
+		if ($rowColor == 'evenListRowS1') {
 			$rowColor = 'oddListRowS1';
-		}else{
+		} else {
 			 $rowColor = 'evenListRowS1';
 		}
 		$form .= "</tr>";
@@ -129,14 +129,14 @@ 
 
 }
 
-function getForm($prefix, $mod='Opportunities'){
-	if(!ACLController::checkAccess('Opportunities', 'edit', true)){
+function getForm($prefix, $mod = 'Opportunities') {
+	if (!ACLController::checkAccess('Opportunities', 'edit', true)) {
 		return '';
 	}
-if(!empty($mod)){
+if (!empty($mod)) {
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
-}else global $mod_strings;
+} else global $mod_strings;
 global $app_strings;
 global $sugar_version, $sugar_config;
 
@@ -164,17 +164,17 @@ 
 return $the_form;
 }
 
-function getWideFormBody($prefix, $mod='Opportunities', $formname='', $lead='', $showaccount = true){
-	if(!ACLController::checkAccess('Opportunities', 'edit', true)){
+function getWideFormBody($prefix, $mod = 'Opportunities', $formname = '', $lead = '', $showaccount = true) {
+	if (!ACLController::checkAccess('Opportunities', 'edit', true)) {
 		return '';
 	}
-	if(empty($lead)){
+	if (empty($lead)) {
 		$lead = new Lead();
 	}
 global $mod_strings, $sugar_config;
 $showaccount = $showaccount && $sugar_config['require_accounts'];
 $temp_strings = $mod_strings;
-if(!empty($mod)){
+if (!empty($mod)) {
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
 }
@@ -200,7 +200,7 @@ 
 //$prePopProb = '';
 //if(empty($this->bean->id)) 
 $prePopProb = 'document.getElementsByName(\''.$prefix.'sales_stage\')[0].onchange();';
-$probability_script=<<<EOQ
+$probability_script = <<<EOQ
 	<script>
 	prob_array = $prob_array;
 	document.getElementsByName('{$prefix}sales_stage')[0].onchange = function() {
@@ -215,7 +215,7 @@ 
 $ntc_date_format = $timedate->get_user_date_format();
 $cal_dateformat = $timedate->get_cal_date_format();
 if (isset($lead->assigned_user_id)) {
-	$user_id=$lead->assigned_user_id;
+	$user_id = $lead->assigned_user_id;
 } else {
 	$user_id = $current_user->id;
 }
@@ -225,13 +225,13 @@ 
 // $cal_lang = (empty($cal_codes[$current_language])) ? $cal_codes[$default_language] : $cal_codes[$current_language];
 $cal_lang = "en";
 
-$the_form="";
+$the_form = "";
 
 
 if (isset($lead->opportunity_amount)) {
-	$opp_amount=$lead->opportunity_amount;
+	$opp_amount = $lead->opportunity_amount;
 } else {
- 	$opp_amount='';
+ 	$opp_amount = '';
 }
 $jsCalendarImage = SugarThemeRegistry::current()->getImageURL('jscalendar.gif');
 $the_form .= <<<EOQ
@@ -256,7 +256,7 @@ 
 <td ><input name='{$prefix}date_closed' onblur="parseDate(this, '$cal_dateformat');" size='12' maxlength='10' id='${prefix}jscal_field' type="text" value="">&nbsp;<!--not_in_theme!--><img src="{$jsCalendarImage}" alt="{$app_strings['LBL_ENTER_DATE']}"  id="${prefix}jscal_trigger" align="absmiddle"></td>
 </tr>
 EOQ;
-if($showaccount){
+if ($showaccount) {
 	$the_form .= <<<EOQ
 <tr>
     <td scope="row">${mod_strings['LBL_ACCOUNT_NAME']}&nbsp;<span class="required">${lbl_required_symbol}</span></td>
@@ -308,20 +308,20 @@ 
 $javascript->setFormName($formname);
 $javascript->setSugarBean(new Opportunity());
 $javascript->addRequiredFields($prefix);
-$the_form .=$javascript->getScript();
+$the_form .= $javascript->getScript();
 $mod_strings = $temp_strings;
 return $the_form;
 
 } // end getWideFormBody
 
-function getFormBody($prefix, $mod='Opportunities', $formname=''){
-	if(!ACLController::checkAccess('Opportunities', 'edit', true)){
+function getFormBody($prefix, $mod = 'Opportunities', $formname = '') {
+	if (!ACLController::checkAccess('Opportunities', 'edit', true)) {
 		return '';
 	}
-if(!empty($mod)){
+if (!empty($mod)) {
 	global $current_language;
 	$mod_strings = return_module_language($current_language, $mod);
-}else global $mod_strings;
+} else global $mod_strings;
 global $app_strings;
 global $app_list_strings;
 global $theme;
@@ -356,7 +356,7 @@ 
 		$lbl_opportunity_name&nbsp;<span class="required">$lbl_required_symbol</span><br>
 		<input name='{$prefix}name' type="text" value="">
 EOQ;
-if($sugar_config['require_accounts']){
+if ($sugar_config['require_accounts']) {
 
 ///////////////////////////////////////
 ///
@@ -408,7 +408,7 @@ 
 $qsd = QuickSearchDefaults::getQuickSearchDefaults();
 $sqs_objects = array('qc_account_name' => $qsd->getQSParent());
 $sqs_objects['qc_account_name']['populate_list'] = array('qc_account_name', 'qc_account_id');
-$quicksearch_js = '<script type="text/javascript" language="javascript">sqs_objects = ' . $json->encode($sqs_objects) . '</script>';
+$quicksearch_js = '<script type="text/javascript" language="javascript">sqs_objects = '.$json->encode($sqs_objects).'</script>';
 $the_form .= $quicksearch_js;
 
 
@@ -417,7 +417,7 @@ 
 $javascript->setFormName($formname);
 $javascript->setSugarBean(new Opportunity());
 $javascript->addRequiredFields($prefix);
-$the_form .=$javascript->getScript();
+$the_form .= $javascript->getScript();
 
 
 return $the_form;
@@ -425,25 +425,25 @@ 
 }
 
 
-function handleSave($prefix,$redirect=true, $useRequired=false){
+function handleSave($prefix, $redirect = true, $useRequired = false) {
     global $current_user;
 	
 	
 	require_once('include/formbase.php');
 	
 	$focus = new Opportunity();
-	if($useRequired &&  !checkRequired($prefix, array_keys($focus->required_fields))){
+	if ($useRequired && !checkRequired($prefix, array_keys($focus->required_fields))) {
 		return null;
 	}
 
-    if(empty($_POST['currency_id'])){
+    if (empty($_POST['currency_id'])) {
         $currency_id = $current_user->getPreference('currency');
-        if(isset($currency_id)){
-            $focus->currency_id =   $currency_id;
+        if (isset($currency_id)) {
+            $focus->currency_id = $currency_id;
         }
     }
 	$focus = populateFromPost($prefix, $focus);
-	if( !ACLController::checkAccess($focus->module_dir, 'edit', $focus->isOwner($current_user->id))){
+	if (!ACLController::checkAccess($focus->module_dir, 'edit', $focus->isOwner($current_user->id))) {
 		ACLController::displayNoAccess(true);
 	}
 	$check_notify = FALSE;
@@ -453,15 +453,15 @@ 
 
 	$focus->save($check_notify);
 
-	if(!empty($_POST['duplicate_parent_id'])){
-		clone_relationship($focus->db, array('opportunities_contacts'),'opportunity_id',  $_POST['duplicate_parent_id'], $focus->id);
+	if (!empty($_POST['duplicate_parent_id'])) {
+		clone_relationship($focus->db, array('opportunities_contacts'), 'opportunity_id', $_POST['duplicate_parent_id'], $focus->id);
 	}
 	$return_id = $focus->id;
 	
 	$GLOBALS['log']->debug("Saved record with id of ".$return_id);
-	if($redirect){
-		handleRedirect($return_id,"Opportunities" );
-	}else{
+	if ($redirect) {
+		handleRedirect($return_id, "Opportunities");
+	} else {
 		return $focus;
 	}
 }

modules/ProspectLists/field_arrays.php

Spacing +6 added lines, -6 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,16 +45,16 @@ 
  * All Rights Reserved.
  * Contributor(s): ______________________________________..
  ********************************************************************************/
-$fields_array['ProspectList'] = array ('column_fields' => array(
+$fields_array['ProspectList'] = array('column_fields' => array(
 				"id", "date_entered",
 				"date_modified", "modified_user_id",
 				"assigned_user_id", "created_by",
-				"name", "description",'list_type','domain_name',
+				"name", "description", 'list_type', 'domain_name',
 	),
         'list_fields' =>  array(
-				'id', 'name', 'description','list_type',
-				'assigned_user_id','assigned_user_name',
+				'id', 'name', 'description', 'list_type',
+				'assigned_user_id', 'assigned_user_name',
 	),
-    'required_fields' =>  array('name'=>1,'list_type'=>2),
+    'required_fields' =>  array('name'=>1, 'list_type'=>2),
 );
 ?>
\ No newline at end of file

modules/ProspectLists/ProspectListFormBase.php

Spacing +16 added lines, -16 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,19 +50,19 @@ 
 class ProspectListFormBase {
 
 
-function getForm($prefix, $mod='', $form=''){
+function getForm($prefix, $mod = '', $form = '') {
 	
-	if(!ACLController::checkAccess('ProspectLists', 'edit', true)){
+	if (!ACLController::checkAccess('ProspectLists', 'edit', true)) {
 		return '';
 	}
 	
-	if(!empty($mod)){
+	if (!empty($mod)) {
 		global $current_language;
 		$mod_strings = return_module_language($current_language, $mod);
 	} else {
 		global $mod_strings;
 	}
-	global $app_strings,$current_user;
+	global $app_strings, $current_user;
 	
 	$lbl_save_button_title = $app_strings['LBL_SAVE_BUTTON_TITLE'];
 	$lbl_save_button_key = $app_strings['LBL_SAVE_BUTTON_KEY'];
@@ -91,13 +91,13 @@ 
 	return $the_form;	
 }
 
-function getFormBody($prefix, $mod='',$formname='', $size='30',$script=true) {
-	if(!ACLController::checkAccess('ProspectLists', 'edit', true)){
+function getFormBody($prefix, $mod = '', $formname = '', $size = '30', $script = true) {
+	if (!ACLController::checkAccess('ProspectLists', 'edit', true)) {
 		return '';
 	}
 	global $mod_strings;
 	$temp_strings = $mod_strings;
-	if(!empty($mod)){
+	if (!empty($mod)) {
 		global $current_language;
 		$mod_strings = return_module_language($current_language, $mod);
 	}
@@ -111,7 +111,7 @@ 
 	$lbl_save_button_label = $app_strings['LBL_SAVE_BUTTON_LABEL'];
 	$user_id = $current_user->id;
 
-	$list_options=get_select_options_with_id($app_list_strings['prospect_list_type_dom'], 'default');
+	$list_options = get_select_options_with_id($app_list_strings['prospect_list_type_dom'], 'default');
 	
 	$lbl_prospect_list_name = $mod_strings['LBL_PROSPECT_LIST_NAME'];
 	$lbl_list_type = $mod_strings['LBL_LIST_TYPE'];
@@ -130,34 +130,34 @@ 
 	$javascript->setFormName($formname);
 	$javascript->setSugarBean(new ProspectList());
 	$javascript->addRequiredFields($prefix);
-	$form .=$javascript->getScript();
+	$form .= $javascript->getScript();
 	$mod_strings = $temp_strings;
 	return $form;
 }
 
-	function handleSave($prefix,$redirect=true, $useRequired=false){
+	function handleSave($prefix, $redirect = true, $useRequired = false) {
 		
 		
 		require_once('include/formbase.php');
 	
 		
 		$focus = new ProspectList();
-		if($useRequired &&  !checkRequired($prefix, array_keys($focus->required_fields))){
+		if ($useRequired && !checkRequired($prefix, array_keys($focus->required_fields))) {
 			return null;
 		}
 		$focus = populateFromPost($prefix, $focus);
-		if(!$focus->ACLAccess('Save')){
+		if (!$focus->ACLAccess('Save')) {
 			ACLController::displayNoAccess(true);
 			sugar_cleanup(true);
 		}
-		if(empty($focus->name)){
+		if (empty($focus->name)) {
 			return null;
 		}	
-        if ( !isset($focus->assigned_user_id) || $focus->assigned_user_id == '' )
+        if (!isset($focus->assigned_user_id) || $focus->assigned_user_id == '')
             $focus->assigned_user_id = $GLOBALS['current_user']->id;
 	
 		$return_id = $focus->save();
-		if($redirect){
+		if ($redirect) {
 			$GLOBALS['log']->debug("Saved record with id of ".$return_id);
 			handleRedirect($return_id, "ProspectLists");
 		} else { 

modules/ProspectLists/TargetListUpdate.php

Spacing +19 added lines, -19 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2012 SugarCRM Inc.
@@ -47,13 +47,13 @@ 
 
 require_once 'include/formbase.php';
 
-global $beanFiles,$beanList;
+global $beanFiles, $beanList;
 $bean_name = $beanList[$_REQUEST['module']];
 require_once($beanFiles[$bean_name]);
 $focus = new $bean_name();
 
 $uids = array();
-if($_REQUEST['select_entire_list'] == '1'){
+if ($_REQUEST['select_entire_list'] == '1') {
 	$order_by = '';
 
 	require_once('include/MassUpdate.php');
@@ -62,52 +62,52 @@ 
 	$ret_array = create_export_query_relate_link_patch($_REQUEST['module'], $mass->searchFields, $mass->where_clauses);
 	/* BEGIN - SECURITY GROUPS */
 	//need to hijack the $ret_array['where'] of securitygorup required
-	if($focus->bean_implements('ACL') && ACLController::requireSecurityGroup($focus->module_dir, 'list') )
+	if ($focus->bean_implements('ACL') && ACLController::requireSecurityGroup($focus->module_dir, 'list'))
 	{
 		require_once('modules/SecurityGroups/SecurityGroup.php');
 		global $current_user;
 		$owner_where = $focus->getOwnerWhere($current_user->id);
-		$group_where = SecurityGroup::getGroupWhere($focus->table_name,$focus->module_dir,$current_user->id);
-		if(!empty($owner_where)){
-			if(empty($ret_array['where']))
+		$group_where = SecurityGroup::getGroupWhere($focus->table_name, $focus->module_dir, $current_user->id);
+		if (!empty($owner_where)) {
+			if (empty($ret_array['where']))
 			{
-				$ret_array['where'] = " (".  $owner_where." or ".$group_where.") ";
+				$ret_array['where'] = " (".$owner_where." or ".$group_where.") ";
 			} else {
-				$ret_array['where'] .= " AND (".  $owner_where." or ".$group_where.") ";
+				$ret_array['where'] .= " AND (".$owner_where." or ".$group_where.") ";
 			}
 		} else {
-			$ret_array['where'] .= ' AND '.  $group_where;
+			$ret_array['where'] .= ' AND '.$group_where;
 		}
 	}
 	/* END - SECURITY GROUPS */
 	$query = $focus->create_export_query($order_by, $ret_array['where'], $ret_array['join']);
-	$result = $GLOBALS['db']->query($query,true);
+	$result = $GLOBALS['db']->query($query, true);
 	$uids = array();
-	while($val = $GLOBALS['db']->fetchByAssoc($result,false))
+	while ($val = $GLOBALS['db']->fetchByAssoc($result, false))
 	{
 		array_push($uids, $val['id']);
 	}
 }
-else{
-	$uids = explode ( ',', $_POST['uids'] );
+else {
+	$uids = explode(',', $_POST['uids']);
 }
 
 // find the relationship to use
 $relationship = '';
-foreach($focus->get_linked_fields() as $field => $def) {
+foreach ($focus->get_linked_fields() as $field => $def) {
     if ($focus->load_relationship($field)) {
-        if ( $focus->$field->getRelatedModuleName() == 'ProspectLists' ) {
+        if ($focus->$field->getRelatedModuleName() == 'ProspectLists') {
             $relationship = $field;
             break;
         }
     }
 }
 
-if ( $relationship != '' ) {
-    foreach ( $uids as $id) {
+if ($relationship != '') {
+    foreach ($uids as $id) {
         $focus->retrieve($id);
         $focus->load_relationship($relationship);
-        $focus->prospect_lists->add( $_REQUEST['prospect_list'] );
+        $focus->prospect_lists->add($_REQUEST['prospect_list']);
     }
 }
 handleRedirect();

modules/ProspectLists/ProspectList.php

Spacing +35 added lines, -35 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -120,18 +120,18 @@ 
         $query .= $custom_join['join'];
 
 			$where_auto = '1=1';
-				if($show_deleted == 0){
+				if ($show_deleted == 0) {
                 	$where_auto = "$this->table_name.deleted=0";
-				}else if($show_deleted == 1){
+				} else if ($show_deleted == 1) {
                 	$where_auto = "$this->table_name.deleted=1";
 				}
 
-		if($where != "")
+		if ($where != "")
 			$query .= "where $where AND ".$where_auto;
 		else
 			$query .= "where ".$where_auto;
 
-		if($order_by != "")
+		if ($order_by != "")
 			$query .= " ORDER BY $order_by";
 		else
 			$query .= " ORDER BY prospect_lists.name";
@@ -147,17 +147,17 @@ 
                                 prospect_lists.*,
                                 users.user_name as assigned_user_name ";
 	                            $query .= "FROM prospect_lists ";
-		$query .= 				"LEFT JOIN users
+		$query .= "LEFT JOIN users
                                 ON prospect_lists.assigned_user_id=users.id ";
 
 		$where_auto = " prospect_lists.deleted=0";
 
-        if($where != "")
+        if ($where != "")
                 $query .= " WHERE $where AND ".$where_auto;
         else
                 $query .= " WHERE ".$where_auto;
 
-        if($order_by != "")
+        if ($order_by != "")
                 $query .= " ORDER BY $order_by";
         else
                 $query .= " ORDER BY prospect_lists.name";
@@ -166,7 +166,7 @@ 
 
 	function create_export_members_query($record_id)
 	{
-		$members = array(	'Accounts' 	=> array('has_custom_fields' => false, 'fields' => array()), 
+		$members = array('Accounts' 	=> array('has_custom_fields' => false, 'fields' => array()), 
 					'Contacts' 	=> array('has_custom_fields' => false, 'fields' => array()),
 					'Users' 	=> array('has_custom_fields' => false, 'fields' => array()),
 					'Prospects' 	=> array('has_custom_fields' => false, 'fields' => array()),
@@ -175,31 +175,31 @@ 
 
 		// query all custom fields in the fields_meta_data table for the modules which are being exported 
 		$db = DBManagerFactory::getInstance();
-		$result = $db->query("select name, custom_module from fields_meta_data where custom_module in ('" . 
-					implode("', '", array_keys($members)) . "')",
+		$result = $db->query("select name, custom_module from fields_meta_data where custom_module in ('". 
+					implode("', '", array_keys($members))."')",
 					true,
 					"ProspectList::create_export_members_query() : error querying custom fields");
 
 		// cycle through the custom fields and put them in the members array according to 
 		// what module the field belongs
 		// take into account that the same custom field may exist in more modules
-		while($val = $db->fetchByAssoc($result, false)) 
+		while ($val = $db->fetchByAssoc($result, false)) 
 		{
 			$fieldname = $val['name'];
 
-			foreach($members as $membername => &$memberarr)	
+			foreach ($members as $membername => &$memberarr)	
 			{
 				// if the field belongs to this module, then query it in the cstm table
 				if ($membername == $val['custom_module'])
 				{
 					$memberarr['has_custom_fields'] = true;
 					$memberarr['fields'][$fieldname] = 
-						strtolower($membername) . '_cstm.'.$fieldname . ' AS ' . $fieldname;
+						strtolower($membername).'_cstm.'.$fieldname.' AS '.$fieldname;
 				}
 				// else, only if for this module no entry exists for this field, query an empty string
 				else if (!isset($memberarr['fields'][$val['name']]))
 				{
-					$memberarr['fields'][$fieldname] = "'' AS " . $fieldname;
+					$memberarr['fields'][$fieldname] = "'' AS ".$fieldname;
 				}
 			}
 		}
@@ -209,7 +209,7 @@ 
 				l.account_name AS account_name,
 				ea.email_address AS primary_email_address, ea.invalid_email AS invalid_email, ea.opt_out AS opt_out, ea.deleted AS ea_deleted, ear.deleted AS ear_deleted, ear.primary_address AS primary_address,
 				l.do_not_call AS do_not_call, l.phone_fax AS phone_fax, l.phone_other AS phone_other, l.phone_home AS phone_home, l.phone_mobile AS phone_mobile, l.phone_work AS phone_work
-				".(count($members['Leads']['fields']) ? ', ' : '') . implode(', ', $members['Leads']['fields'])."
+				".(count($members['Leads']['fields']) ? ', ' : '').implode(', ', $members['Leads']['fields'])."
 				FROM prospect_lists_prospects plp
 				INNER JOIN leads l ON plp.related_id=l.id
 				".($members['Leads']['has_custom_fields'] ? 'LEFT join leads_cstm ON l.id = leads_cstm.id_c' : '')."
@@ -224,7 +224,7 @@ 
 				'' AS account_name,
 				ea.email_address AS email_address, ea.invalid_email AS invalid_email, ea.opt_out AS opt_out, ea.deleted AS ea_deleted, ear.deleted AS ear_deleted, ear.primary_address AS primary_address,
 				0 AS do_not_call, u.phone_fax AS phone_fax, u.phone_other AS phone_other, u.phone_home AS phone_home, u.phone_mobile AS phone_mobile, u.phone_work AS phone_work
-				".(count($members['Users']['fields']) ? ', ' : '') . implode(', ', $members['Users']['fields'])."
+				".(count($members['Users']['fields']) ? ', ' : '').implode(', ', $members['Users']['fields'])."
 				FROM prospect_lists_prospects plp
 				INNER JOIN users u ON plp.related_id=u.id
 				".($members['Users']['has_custom_fields'] ? 'LEFT join users_cstm ON u.id = users_cstm.id_c' : '')."
@@ -239,7 +239,7 @@ 
 				a.name AS account_name,
 				ea.email_address AS email_address, ea.invalid_email AS invalid_email, ea.opt_out AS opt_out, ea.deleted AS ea_deleted, ear.deleted AS ear_deleted, ear.primary_address AS primary_address,
 				c.do_not_call AS do_not_call, c.phone_fax AS phone_fax, c.phone_other AS phone_other, c.phone_home AS phone_home, c.phone_mobile AS phone_mobile, c.phone_work AS phone_work
-				".(count($members['Contacts']['fields']) ? ', ' : '') . implode(', ', $members['Contacts']['fields'])."
+				".(count($members['Contacts']['fields']) ? ', ' : '').implode(', ', $members['Contacts']['fields'])."
 FROM prospect_lists_prospects plp
 				INNER JOIN contacts c ON plp.related_id=c.id LEFT JOIN accounts_contacts ac ON ac.contact_id=c.id LEFT JOIN accounts a ON ac.account_id=a.id
 				".($members['Contacts']['has_custom_fields'] ? 'LEFT join contacts_cstm ON c.id = contacts_cstm.id_c' : '')."
@@ -255,7 +255,7 @@ 
 				p.account_name AS account_name,
 				ea.email_address AS email_address, ea.invalid_email AS invalid_email, ea.opt_out AS opt_out, ea.deleted AS ea_deleted, ear.deleted AS ear_deleted, ear.primary_address AS primary_address,
 				p.do_not_call AS do_not_call, p.phone_fax AS phone_fax, p.phone_other AS phone_other, p.phone_home AS phone_home, p.phone_mobile AS phone_mobile, p.phone_work AS phone_work
-				".(count($members['Prospects']['fields']) ? ', ' : '') . implode(', ', $members['Prospects']['fields'])."
+				".(count($members['Prospects']['fields']) ? ', ' : '').implode(', ', $members['Prospects']['fields'])."
 				FROM prospect_lists_prospects plp
 				INNER JOIN prospects p ON plp.related_id=p.id
 				".($members['Prospects']['has_custom_fields'] ? 'LEFT join prospects_cstm ON p.id = prospects_cstm.id_c' : '')."
@@ -270,7 +270,7 @@ 
 				'' AS account_name,
 				ea.email_address AS email_address, ea.invalid_email AS invalid_email, ea.opt_out AS opt_out, ea.deleted AS ea_deleted, ear.deleted AS ear_deleted, ear.primary_address AS primary_address,
 				0 AS do_not_call, a.phone_fax as phone_fax, a.phone_alternate AS phone_other, '' AS phone_home, '' AS phone_mobile, a.phone_office AS phone_office
-				".(count($members['Accounts']['fields']) ? ', ' : '') . implode(', ', $members['Accounts']['fields'])."
+				".(count($members['Accounts']['fields']) ? ', ' : '').implode(', ', $members['Accounts']['fields'])."
 				FROM prospect_lists_prospects plp
 				INNER JOIN accounts a ON plp.related_id=a.id
 				".($members['Accounts']['has_custom_fields'] ? 'LEFT join accounts_cstm ON a.id = accounts_cstm.id_c' : '')."
@@ -287,11 +287,11 @@ 
 	function save_relationship_changes($is_update, $exclude = array())
     {
     	parent::save_relationship_changes($is_update, $exclude);
-		if($this->lead_id != "")
+		if ($this->lead_id != "")
 	   		$this->set_prospect_relationship($this->id, $this->lead_id, "lead");
-    	if($this->contact_id != "")
+    	if ($this->contact_id != "")
     		$this->set_prospect_relationship($this->id, $this->contact_id, "contact");
-    	if($this->prospect_id != "")
+    	if ($this->prospect_id != "")
     		$this->set_prospect_relationship($this->id, $this->contact_id, "prospect");
     }
 
@@ -299,9 +299,9 @@ 
 	{
 		$link_field = sprintf("%s_id", $link_name);
 		
-		foreach($link_ids as $link_id)
+		foreach ($link_ids as $link_id)
 		{
-			$this->set_relationship('prospect_lists_prospects', array( $link_field=>$link_id, 'prospect_list_id'=>$prospect_list_id ));
+			$this->set_relationship('prospect_lists_prospects', array($link_field=>$link_id, 'prospect_list_id'=>$prospect_list_id));
 		}
 	}
 
@@ -309,7 +309,7 @@ 
 	{
 		$link_field = sprintf("%s_id", $link_name);
 		
-		$this->set_relationship('prospect_lists_prospects', array( $link_field=>$link_id, 'prospect_list_id'=>$prospect_list_id ));
+		$this->set_relationship('prospect_lists_prospects', array($link_field=>$link_id, 'prospect_list_id'=>$prospect_list_id));
 	}
 
 
@@ -339,7 +339,7 @@ 
 	}
 
 	
-	function update_currency_id($fromid, $toid){
+	function update_currency_id($fromid, $toid) {
 	}
 
 
@@ -350,14 +350,14 @@ 
 		
 		$row = $this->db->fetchByAssoc($result);
 
-		if($row)
+		if ($row)
 			return $row['num'];
 		else
 			return 0;
 	}
 		
 		
-	function get_list_view_data(){
+	function get_list_view_data() {
 		$temp_array = $this->get_list_view_array();
 		$temp_array["ENTRY_COUNT"] = $this->get_entry_count();		
 		return $temp_array;
@@ -366,16 +366,16 @@ 
 		builds a generic search based on the query string using or
 		do not include any $this-> because this is called on without having the class instantiated
 	*/
-	function build_generic_where_clause ($the_query_string) 
+	function build_generic_where_clause($the_query_string) 
 	{
 		$where_clauses = Array();
 		$the_query_string = $GLOBALS['db']->quote($the_query_string);
 		array_push($where_clauses, "prospect_lists.name like '$the_query_string%'");
 
 		$the_where = "";
-		foreach($where_clauses as $clause)
+		foreach ($where_clauses as $clause)
 		{
-			if($the_where != "") $the_where .= " or ";
+			if ($the_where != "") $the_where .= " or ";
 			$the_where .= $clause;
 		}
 
@@ -389,14 +389,14 @@ 
 
 	}
 
-    function mark_deleted($id){
+    function mark_deleted($id) {
         $query = "UPDATE prospect_lists_prospects SET deleted = 1 WHERE prospect_list_id = '{$id}' ";
         $this->db->query($query);
         return parent::mark_deleted($id);
     }
 	
-	 function bean_implements($interface){
-		switch($interface){
+	 function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL':return true;
 		}
 		return false;