adamjakab / SuiteCRM

data/Relationships/One2OneBeanRelationship.php

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -87,14 +87,14 @@ 
         $targetTable = $linkIsLHS ? $this->def['rhs_table'] : $this->def['lhs_table'];
         $targetTableWithAlias = $targetTable;
         $targetKey = $linkIsLHS ? $this->def['rhs_key'] : $this->def['lhs_key'];
-        $join_type= isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
+        $join_type = isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
 
         $join = '';
 
         //Set up any table aliases required
-        if ( ! empty($params['join_table_alias']))
+        if (!empty($params['join_table_alias']))
         {
-            $targetTableWithAlias = $targetTable . " ". $params['join_table_alias'];
+            $targetTableWithAlias = $targetTable." ".$params['join_table_alias'];
             $targetTable = $params['join_table_alias'];
         }
 
@@ -106,7 +106,7 @@ 
         //Next add any role filters
                . $this->getRoleWhere();
 
-        if($return_array){
+        if ($return_array) {
             return array(
                 'join' => $join,
                 'type' => $this->type,

data/Relationships/One2MBeanRelationship.php

Spacing +16 added lines, -16 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -66,7 +66,7 @@ 
         // test to see if the relationship exist if the relationship between the two beans
         // exist then we just fail out with false as we don't want to re-trigger this
         // the save and such as it causes problems with the related() in sugarlogic
-        if($this->relationship_exists($lhs, $rhs) && !empty($GLOBALS['resavingRelatedBeans'])) return false;
+        if ($this->relationship_exists($lhs, $rhs) && !empty($GLOBALS['resavingRelatedBeans'])) return false;
 
         $lhsLinkName = $this->lhsLink;
         $rhsLinkName = $this->rhsLink;
@@ -77,7 +77,7 @@ 
         {
             $oldLink = $rhs->$rhsLinkName;
             $prevRelated = $oldLink->getBeans(null);
-            foreach($prevRelated as $oldLHS)
+            foreach ($prevRelated as $oldLHS)
             {
                 if ($oldLHS->id != $lhs->id)
                     $this->remove($oldLHS, $rhs, false);
@@ -131,12 +131,12 @@ 
         //Now update the RHS bean's ID field
         $rhsID = $this->def['rhs_key'];
         $rhs->$rhsID = $lhs->id;
-        foreach($additionalFields as $field => $val)
+        foreach ($additionalFields as $field => $val)
         {
             $rhs->$field = $val;
         }
         //Update role fields
-        if(!empty($this->def["relationship_role_column"]) && !empty($this->def["relationship_role_column_value"]))
+        if (!empty($this->def["relationship_role_column"]) && !empty($this->def["relationship_role_column_value"]))
         {
             $roleField = $this->def["relationship_role_column"];
             $rhs->$roleField = $this->def["relationship_role_column_value"];
@@ -240,7 +240,7 @@ 
 
             //Add any optional where clause
             if (!empty($params['where'])) {
-                $add_where = is_string($params['where']) ? $params['where'] : "$rhsTable." . $this->getOptionalWhereClause($params['where']);
+                $add_where = is_string($params['where']) ? $params['where'] : "$rhsTable.".$this->getOptionalWhereClause($params['where']);
                 if (!empty($add_where))
                     $where .= " AND $add_where";
             }
@@ -282,22 +282,22 @@ 
         $targetTable = $linkIsLHS ? $this->def['rhs_table'] : $this->def['lhs_table'];
         $targetTableWithAlias = $targetTable;
         $targetKey = $linkIsLHS ? $this->def['rhs_key'] : $this->def['lhs_key'];
-        $join_type= isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
+        $join_type = isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
         $join = '';
 
         //Set up any table aliases required
-        if ( ! empty($params['join_table_alias']))
+        if (!empty($params['join_table_alias']))
         {
-            $targetTableWithAlias = $targetTable. " ".$params['join_table_alias'];
+            $targetTableWithAlias = $targetTable." ".$params['join_table_alias'];
             $targetTable = $params['join_table_alias'];
         }
 
         //First join the relationship table
         $join .= "$join_type $targetTableWithAlias ON $startingTable.$startingKey=$targetTable.$targetKey AND $targetTable.deleted=0\n"
         //Next add any role filters
-               . $this->getRoleWhere(($linkIsLHS) ? $targetTable : $startingTable) . "\n";
+               . $this->getRoleWhere(($linkIsLHS) ? $targetTable : $startingTable)."\n";
 
-        if($return_array){
+        if ($return_array) {
             return array(
                 'join' => $join,
                 'type' => $this->type,
@@ -320,10 +320,10 @@ 
         $startingKey = $linkIsLHS ? $this->def['lhs_key'] : $this->def['rhs_key'];
         $targetTable = $linkIsLHS ? $this->def['rhs_table'] : $this->def['lhs_table'];
         $targetKey = $linkIsLHS ? $this->def['rhs_key'] : $this->def['lhs_key'];
-        $join_type= isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
+        $join_type = isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
         $query = '';
 
-        $alias = empty($params['join_table_alias']) ? "{$link->name}_rel": $params['join_table_alias'];
+        $alias = empty($params['join_table_alias']) ? "{$link->name}_rel" : $params['join_table_alias'];
         $alias = $GLOBALS['db']->getValidDBName($alias, false, 'alias');
 
         $tableInRoleFilter = "";
@@ -342,7 +342,7 @@ 
                 || $targetTable == "tasks"
                 || $targetTable == "calls"
             )
-            && substr($alias, 0, 12 + strlen($targetTable)) == $targetTable . "_activities_"
+            && substr($alias, 0, 12 + strlen($targetTable)) == $targetTable."_activities_"
         )
         {
             $tableInRoleFilter = $linkIsLHS ? $alias : $startingTable;
@@ -354,13 +354,13 @@ 
 
         $query .= "$join_type $targetTableWithAlias ON $startingTable.$startingKey=$targetTable.$targetKey AND $targetTable.deleted=0\n"
         //Next add any role filters
-               . $this->getRoleWhere($tableInRoleFilter) . "\n";
+               . $this->getRoleWhere($tableInRoleFilter)."\n";
 
         if (!empty($params['return_as_array'])) {
             $return_array = true;
         }
 
-        if($return_array){
+        if ($return_array) {
             return array(
                 'join' => $query,
                 'type' => $this->type,

data/Relationships/M2MRelationship.php

Spacing +35 added lines, -35 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -73,14 +73,14 @@ 
      */
     public function getLinkedDefForModuleByRelationship($module)
     {
-        $results = VardefManager::getLinkFieldForRelationship( $module, BeanFactory::getObjectName($module), $this->name);
+        $results = VardefManager::getLinkFieldForRelationship($module, BeanFactory::getObjectName($module), $this->name);
         //Only a single link was found
-        if( isset($results['name']) )
+        if (isset($results['name']))
         {
             return $results;
         }
         //Multiple links with same relationship name
-        else if( is_array($results) )
+        else if (is_array($results))
         {
             $GLOBALS['log']->error("Warning: Multiple links found for relationship {$this->name} within module {$module}");
             return $this->getMostAppropriateLinkedDefinition($results);
@@ -101,17 +101,17 @@ 
     protected function getMostAppropriateLinkedDefinition($links)
     {
         //First priority is to find a link name that matches the relationship name
-        foreach($links as $link)
+        foreach ($links as $link)
         {
-            if( isset($link['name']) && $link['name'] == $this->name )
+            if (isset($link['name']) && $link['name'] == $this->name)
             {
                 return $link;
             }
         }
         //Next would be a relationship that has a side defined
-        foreach($links as $link)
+        foreach ($links as $link)
         {
-            if( isset($link['id_name']))
+            if (isset($link['id_name']))
             {
                 return $link;
             }
@@ -135,7 +135,7 @@ 
     	//Need to hijack this as security groups will not contain a link on the module side
     	//due to the way the module works. Plus it would remove the relative ease of adding custom module support
     	
-    	if(get_class($rhs) != 'User' && get_class($rhs) != 'ACLRole' && get_class($lhs) == 'SecurityGroup') {
+    	if (get_class($rhs) != 'User' && get_class($rhs) != 'ACLRole' && get_class($lhs) == 'SecurityGroup') {
 			$rhs->$rhsLinkName->addBean($lhs);			
 			$this->callBeforeAdd($rhs, $lhs, $rhsLinkName);
 
@@ -143,7 +143,7 @@ 
 			$this->addRow($dataToInsert);
     		$rhs->$rhsLinkName->addBean($lhs);
     		$this->callAfterAdd($lhs, $rhs, $lhsLinkName);
-    	} else if(get_class($lhs) != 'User' && get_class($lhs) != 'ACLRole' && get_class($rhs) == 'SecurityGroup') {
+    	} else if (get_class($lhs) != 'User' && get_class($lhs) != 'ACLRole' && get_class($rhs) == 'SecurityGroup') {
 			$lhs->$lhsLinkName->addBean($rhs);			
 			$this->callBeforeAdd($lhs, $rhs, $lhsLinkName);
 
@@ -205,14 +205,14 @@ 
         );
 
 
-        if (!empty($this->def['relationship_role_column']) && !empty($this->def['relationship_role_column_value']) && !$this->ignore_role_filter )
+        if (!empty($this->def['relationship_role_column']) && !empty($this->def['relationship_role_column_value']) && !$this->ignore_role_filter)
         {
             $row[$this->relationship_role_column] = $this->relationship_role_column_value;
         }
 
         if (!empty($this->def['fields']))
         {
-            foreach($this->def['fields'] as $fieldDef)
+            foreach ($this->def['fields'] as $fieldDef)
             {
                 if (!empty($fieldDef['name']) && !isset($row[$fieldDef['name']]) && !empty($fieldDef['default']))
                 {
@@ -246,7 +246,7 @@ 
 
     public function remove($lhs, $rhs)
     {
-        if(!($lhs instanceof SugarBean) || !($rhs instanceof SugarBean)) {
+        if (!($lhs instanceof SugarBean) || !($rhs instanceof SugarBean)) {
             $GLOBALS['log']->fatal("LHS and RHS must be beans");
             return false;
         }
@@ -266,7 +266,7 @@ 
     	//Need to hijack this as security groups will not contain a link on the module side
     	//due to the way the module works. Plus it would remove the relative ease of adding custom module support
     	
-    	if(get_class($lhs) == 'SecurityGroup' || get_class($rhs) == 'SecurityGroup') {
+    	if (get_class($lhs) == 'SecurityGroup' || get_class($rhs) == 'SecurityGroup') {
 			$dataToRemove = array(
 				$this->def['join_key_lhs'] => $lhs->id,
 				$this->def['join_key_rhs'] => $rhs->id
@@ -426,12 +426,12 @@ 
         }
         $rel_table = $this->getRelationshipTable();
 
-        $where = "$rel_table.$knownKey = '{$link->getFocus()->id}'" . $this->getRoleWhere();
+        $where = "$rel_table.$knownKey = '{$link->getFocus()->id}'".$this->getRoleWhere();
         $order_by = '';
 
         //Add any optional where clause
         if (!empty($params['where'])) {
-            $add_where = is_string($params['where']) ? $params['where'] : "$whereTable." . $this->getOptionalWhereClause($params['where']);
+            $add_where = is_string($params['where']) ? $params['where'] : "$whereTable.".$this->getOptionalWhereClause($params['where']);
             if (!empty($add_where))
                 $where .= " AND $add_where";
         }
@@ -442,7 +442,7 @@ 
         }
 
         $deleted = !empty($params['deleted']) ? 1 : 0;
-        $from = $rel_table . " ";
+        $from = $rel_table." ";
         if (!empty($params['where']) || !empty($params['order_by'])) {
             $from .= ", $whereTable";
             if (isset($relatedSeed->custom_fields)) {
@@ -454,7 +454,7 @@ 
 
         if (empty($params['return_as_array'])) {
             $query = "SELECT $targetKey id FROM $from WHERE $where AND $rel_table.deleted=$deleted";
-            if(!empty($order_by)) $query .= ' ORDER BY '.$order_by;
+            if (!empty($order_by)) $query .= ' ORDER BY '.$order_by;
             //Limit is not compatible with return_as_array
             if (!empty($params['limit']) && $params['limit'] > 0) {
                 $offset = isset($params['offset']) ? $params['offset'] : 0;
@@ -488,19 +488,19 @@ 
         $targetTable = $linkIsLHS ? $this->def['rhs_table'] : $this->def['lhs_table'];
         $targetTableWithAlias = $targetTable;
         $targetKey = $linkIsLHS ? $this->def['rhs_key'] : $this->def['lhs_key'];
-        $join_type= isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
+        $join_type = isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
 
         $join = '';
 
         //Set up any table aliases required
         if (!empty($params['join_table_link_alias']))
         {
-            $joinTableWithAlias = $joinTable . " ". $params['join_table_link_alias'];
+            $joinTableWithAlias = $joinTable." ".$params['join_table_link_alias'];
             $joinTable = $params['join_table_link_alias'];
         }
-        if ( ! empty($params['join_table_alias']))
+        if (!empty($params['join_table_alias']))
         {
-            $targetTableWithAlias = $targetTable . " ". $params['join_table_alias'];
+            $targetTableWithAlias = $targetTable." ".$params['join_table_alias'];
             $targetTable = $params['join_table_alias'];
         }
 
@@ -512,11 +512,11 @@ 
         //First join the relationship table
         $join .= "$join_type $joinTableWithAlias ON $join1 AND $joinTable.deleted=0\n"
         //Next add any role filters
-               . $this->getRoleWhere($joinTable) . "\n"
+               . $this->getRoleWhere($joinTable)."\n"
         //Then finally join the related module's table
                . "$join_type $targetTableWithAlias ON $join2 AND $targetTable.deleted=0\n";
 
-        if($return_array){
+        if ($return_array) {
             return array(
                 'join' => $join,
                 'type' => $this->type,
@@ -526,7 +526,7 @@ 
                 'select' => "$targetTable.id",
             );
         }
-        return $join . $where;
+        return $join.$where;
     }
 
     /**
@@ -540,21 +540,21 @@ 
     public function getSubpanelQuery($link, $params = array(), $return_array = false)
     {
         $targetIsLHS = $link->getSide() == REL_RHS;
-        $startingTable = $targetIsLHS ? $this->def['lhs_table'] : $this->def['rhs_table'];;
+        $startingTable = $targetIsLHS ? $this->def['lhs_table'] : $this->def['rhs_table']; ;
         $startingKey = $targetIsLHS ? $this->def['lhs_key'] : $this->def['rhs_key'];
         $startingJoinKey = $targetIsLHS ? $this->def['join_key_lhs'] : $this->def['join_key_rhs'];
         $joinTable = $this->getRelationshipTable();
         $joinTableWithAlias = $joinTable;
         $joinKey = $targetIsLHS ? $this->def['join_key_rhs'] : $this->def['join_key_lhs'];
         $targetKey = $targetIsLHS ? $this->def['rhs_key'] : $this->def['lhs_key'];
-        $join_type= isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
+        $join_type = isset($params['join_type']) ? $params['join_type'] : ' INNER JOIN ';
 
         $query = '';
 
         //Set up any table aliases required
         if (!empty($params['join_table_link_alias']))
         {
-            $joinTableWithAlias = $joinTable . " ". $params['join_table_link_alias'];
+            $joinTableWithAlias = $joinTable." ".$params['join_table_link_alias'];
             $joinTable = $params['join_table_link_alias'];
         }
 
@@ -566,12 +566,12 @@ 
         //First join the relationship table
         $query .= "$join_type $joinTableWithAlias ON $where AND $joinTable.deleted=0\n"
         //Next add any role filters
-               . $this->getRoleWhere($joinTable, $ignoreRole) . "\n";
+               . $this->getRoleWhere($joinTable, $ignoreRole)."\n";
 
         if (!empty($params['return_as_array'])) {
             $return_array = true;
         }
-        if($return_array){
+        if ($return_array) {
             return array(
                 'join' => $query,
                 'type' => $this->type,
@@ -594,11 +594,11 @@ 
             //role column value.
             if (empty($this->relationship_role_column_value))
             {
-                $ret.=' IS NULL';
+                $ret .= ' IS NULL';
             } else {
-                $ret.= "='".$this->relationship_role_column_value."'";
+                $ret .= "='".$this->relationship_role_column_value."'";
             }
-            $ret.= "\n";
+            $ret .= "\n";
         }
         return $ret;
     }
@@ -613,7 +613,7 @@ 
         $query = "SELECT id FROM {$this->getRelationshipTable()} WHERE {$this->join_key_lhs} = '{$lhs->id}' AND {$this->join_key_rhs} = '{$rhs->id}'";
 
         //Roles can allow for multiple links between two records with different roles
-        $query .= $this->getRoleWhere() . " and deleted = 0";
+        $query .= $this->getRoleWhere()." and deleted = 0";
 
         return $GLOBALS['db']->getOne($query);
     }
@@ -638,7 +638,7 @@ 
     {
         if (!empty($this->def['table']))
             return $this->def['table'];
-        else if(!empty($this->def['join_table']))
+        else if (!empty($this->def['join_table']))
             return $this->def['join_table'];
 
         return false;

data/Relationships/One2MRelationship.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -152,7 +152,7 @@ 
 	        	$related = $link->getBeans();
 	        	
         		// Clear the relations from many side bean
-	        	foreach($related as $relBean) {
+	        	foreach ($related as $relBean) {
 	        		$this->remove($focus, $relBean);
 	        	}
             } else { // For non self-referencing, remove all the relationships from the many (RHS) side

data/Relationships/RelationshipFactory.php

Spacing +12 added lines, -12 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -51,7 +51,7 @@ 
 
     protected $relationships;
 
-    protected function __construct(){
+    protected function __construct() {
         //Load the relationship definitions from the cache.
         $this->loadRelationships();
     }
@@ -75,7 +75,7 @@ 
     public static function deleteCache()
     {
         $file = self::getInstance()->getCacheFile();
-        if(sugar_is_file($file))
+        if (sugar_is_file($file))
         {
             unlink($file);
         }
@@ -98,7 +98,7 @@ 
         $def = $this->relationships[$relationshipName];
 
         $type = isset($def['true_relationship_type']) ? $def['true_relationship_type'] : $def['relationship_type'];
-        switch($type)
+        switch ($type)
         {
             case "many-to-many":
                 if (isset($def['rhs_module']) && $def['rhs_module'] == 'EmailAddresses')
@@ -112,7 +112,7 @@ 
             case "one-to-many":
                 require_once("data/Relationships/One2MBeanRelationship.php");
                 //If a relationship has no table or join keys, it must be bean based
-                if (empty($def['true_relationship_type']) || (empty($def['table']) && empty($def['join_table'])) || empty($def['join_key_rhs'])){
+                if (empty($def['true_relationship_type']) || (empty($def['table']) && empty($def['join_table'])) || empty($def['join_key_rhs'])) {
                     return new One2MBeanRelationship($def);
                 }
                 else {
@@ -120,7 +120,7 @@ 
                 }
                 break;
             case "one-to-one":
-                if (empty($def['true_relationship_type'])){
+                if (empty($def['true_relationship_type'])) {
                     require_once("data/Relationships/One2OneBeanRelationship.php");
                     return new One2OneBeanRelationship($def);
                 }
@@ -131,7 +131,7 @@ 
                 break;
         }
 
-        $GLOBALS['log']->fatal ("$relationshipName had an unknown type $type ");
+        $GLOBALS['log']->fatal("$relationshipName had an unknown type $type ");
 
         return false;
     }
@@ -149,7 +149,7 @@ 
 
     protected function loadRelationships()
     {
-        if(sugar_is_file($this->getCacheFile()))
+        if (sugar_is_file($this->getCacheFile()))
         {
             include($this->getCacheFile());
             $this->relationships = $relationships;
@@ -169,7 +169,7 @@ 
         if (empty($beanList))
             include("include/modules.php");
         //Reload ALL the module vardefs....
-        foreach($beanList as $moduleName => $beanName)
+        foreach ($beanList as $moduleName => $beanName)
         {
             VardefManager::loadVardef($moduleName, BeanFactory::getObjectName($moduleName), false, array(
                 //If relationships are not yet loaded, we can't figure out the rel_calc_fields.
@@ -184,13 +184,13 @@ 
         {
             if (!empty($def['relationships']))
             {
-                foreach($def['relationships'] as $relKey => $relDef)
+                foreach ($def['relationships'] as $relKey => $relDef)
                 {
                     if ($key == $relKey) //Relationship only entry, we need to capture everything
                         $relationships[$key] = array_merge(array('name' => $key), (array)$def, (array)$relDef);
                     else {
                         $relationships[$relKey] = array_merge(array('name' => $relKey), (array)$relDef);
-                        if(!empty($relationships[$relKey]['join_table']) && empty($relationships[$relKey]['fields'])
+                        if (!empty($relationships[$relKey]['join_table']) && empty($relationships[$relKey]['fields'])
                             && isset($dictionary[$relationships[$relKey]['join_table']]['fields'])) {
                             $relationships[$relKey]['fields'] = $dictionary[$relationships[$relKey]['join_table']]['fields'];
                         }
@@ -200,7 +200,7 @@ 
         }
         //Save it out
         sugar_mkdir(dirname($this->getCacheFile()), null, true);
-        $out = "<?php \n \$relationships = " . var_export($relationships, true) . ";";
+        $out = "<?php \n \$relationships = ".var_export($relationships, true).";";
         sugar_file_put_contents_atomic($this->getCacheFile(), $out);
 
         $this->relationships = $relationships;

data/Relationships/EmailAddressRelationship.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -153,7 +153,7 @@ 
             } else {
                 $roleCheck .= " AND $table.bean_module";
             }
-            $roleCheck .= " = '" . $this->getLHSModule() . "'";
+            $roleCheck .= " = '".$this->getLHSModule()."'";
         }
 
         return $roleCheck;

themes/SuiteR/css/colourSelector.php

Spacing +5 added lines, -5 removed lines

@@ -1,16 +1,16 @@ 
 <?php
 
 // config|_override.php
-if(is_file('../../../config.php')) {
+if (is_file('../../../config.php')) {
     require_once('../../../config.php');
 }
 
 // load up the config_override.php file.  This is used to provide default user settings
-if(is_file('../../../config_override.php')) {
+if (is_file('../../../config_override.php')) {
     require_once('../../../config_override.php');
 }
 
-if(!isset($sugar_config['theme_settings']['SuiteR'])) return;
+if (!isset($sugar_config['theme_settings']['SuiteR'])) return;
 
 //set file type back to css from php
 header("Content-type: text/css; charset: UTF-8");
@@ -43,7 +43,7 @@ 
 /* Top navigation bar CSS */
 
 .navbar-inverse {
-background:#<?php echo $sugar_config['theme_settings']['SuiteR']['navbar'];?> !important;
+background:#<?php echo $sugar_config['theme_settings']['SuiteR']['navbar']; ?> !important;
 }
 
 .headerlinks a:link, .headerlinks a:visited, .navbar-inverse .navbar-brand, .moremenu a,  a[id^=grouptab], a[id^=moduleTab] {
@@ -71,7 +71,7 @@ 
 
 #searchform .btn
 {
-background:#<?php echo $sugar_config['theme_settings']['SuiteR']['navbar'];?>;
+background:#<?php echo $sugar_config['theme_settings']['SuiteR']['navbar']; ?>;
 color: #<?php echo $sugar_config['theme_settings']['SuiteR']['icon']; ?>;
 }
 

themes/Suite7/css/colourSelector.php

Spacing +3 added lines, -3 removed lines

@@ -1,16 +1,16 @@
 <?php
 
 // config|_override.php
-if(is_file('../../../config.php')) {
+if (is_file('../../../config.php')) {
     require_once('../../../config.php');
 }
 
 // load up the config_override.php file.  This is used to provide default user settings
-if(is_file('../../../config_override.php')) {
+if (is_file('../../../config_override.php')) {
     require_once('../../../config_override.php');
 }
 
-if(!isset($sugar_config['theme_settings']['Suite7'])) return;
+if (!isset($sugar_config['theme_settings']['Suite7'])) return;
 
 //set file type back to css from php
 header("Content-type: text/css; charset: UTF-8");

soap.php

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
- if(!defined('sugarEntry'))define('sugarEntry', true);
+ if (!defined('sugarEntry'))define('sugarEntry', true);
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -64,7 +64,7 @@ 
 $server->configureWSDL('sugarsoap', $NAMESPACE, $sugar_config['site_url'].'/soap.php');
 
 //New API is in these files
-if(!empty($administrator->settings['portal_on'])) {
+if (!empty($administrator->settings['portal_on'])) {
 	require_once('soap/SoapPortalUsers.php');
 }
 
@@ -78,7 +78,7 @@ 
 /* Begin the HTTP listener service and exit. */
 ob_clean();
 
-if (!isset($HTTP_RAW_POST_DATA)){
+if (!isset($HTTP_RAW_POST_DATA)) {
     $HTTP_RAW_POST_DATA = file_get_contents('php://input');
 }
 
@@ -87,8 +87,8 @@ 
 $resourceManager->setup('Soap');
 $observers = $resourceManager->getObservers();
 //Call set_soap_server for SoapResourceObserver instance(s)
-foreach($observers as $observer) {
-   if(method_exists($observer, 'set_soap_server')) {
+foreach ($observers as $observer) {
+   if (method_exists($observer, 'set_soap_server')) {
    	  $observer->set_soap_server($server);
    }
 }