adamjakab /
SuiteCRM
| Conditions | 15 |
| Paths | 128 |
| Total Lines | 75 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 52 | function displayList($layout_def) |
||
| 53 | { |
||
| 54 | |||
| 55 | global $app_strings; |
||
| 56 | global $subpanel_item_count; |
||
| 57 | |||
| 58 | $unique_id = $layout_def['subpanel_id'] . "_remove_" . $subpanel_item_count; //bug 51512 |
||
| 59 | |||
| 60 | $parent_record_id = $_REQUEST['record']; |
||
| 61 | $parent_module = $_REQUEST['module']; |
||
| 62 | |||
| 63 | $action = 'DeleteRelationship'; |
||
| 64 | $record = $layout_def['fields']['ID']; |
||
| 65 | $current_module = $layout_def['module']; |
||
| 66 | //in document revisions subpanel ,users are now allowed to |
||
| 67 | //delete the latest revsion of a document. this will be tested here |
||
| 68 | //and if the condition is met delete button will be removed. |
||
| 69 | $hideremove = false; |
||
| 70 | if ($current_module === 'DocumentRevisions') { |
||
| 71 | if ($layout_def['fields']['ID'] === $layout_def['fields']['LATEST_REVISION_ID']) { |
||
| 72 | $hideremove = true; |
||
| 73 | } |
||
| 74 | } elseif ($_REQUEST['module'] === 'Teams' && $current_module === 'Users') { |
||
| 75 | // Implicit Team-memberships are not "removeable" |
||
| 76 | if ($layout_def['fields']['UPLINE'] !== translate('LBL_TEAM_UPLINE_EXPLICIT', 'Users')) { |
||
| 77 | $hideremove = true; |
||
| 78 | } |
||
| 79 | |||
| 80 | //We also cannot remove the user whose private team is set to the parent_record_id value |
||
| 81 | $user = new User(); |
||
| 82 | $user->retrieve($layout_def['fields']['ID']); |
||
| 83 | if ($parent_record_id === $user->getPrivateTeamID()) { |
||
| 84 | $hideremove = true; |
||
| 85 | } |
||
| 86 | } elseif ($current_module === 'ACLRoles' && (!ACLController::checkAccess($current_module, 'edit', true))) { |
||
| 87 | $hideremove = true; |
||
| 88 | } |
||
| 89 | |||
| 90 | |||
| 91 | $return_module = $_REQUEST['module']; |
||
| 92 | $return_action = 'SubPanelViewer'; |
||
| 93 | $subpanel = $layout_def['subpanel_id']; |
||
| 94 | $return_id = $_REQUEST['record']; |
||
| 95 | if (isset($layout_def['linked_field_set']) && !empty($layout_def['linked_field_set'])) { |
||
| 96 | $linked_field = $layout_def['linked_field_set']; |
||
| 97 | } else { |
||
| 98 | $linked_field = $layout_def['linked_field']; |
||
| 99 | } |
||
| 100 | $refresh_page = 0; |
||
| 101 | if (!empty($layout_def['refresh_page'])) { |
||
| 102 | $refresh_page = 1; |
||
| 103 | } |
||
| 104 | $return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel&record=$return_id&sugar_body_only=1&inline=1"; |
||
| 105 | |||
| 106 | $icon_remove_text = $app_strings['LBL_ID_FF_REMOVE']; |
||
| 107 | |||
| 108 | if ($linked_field === 'get_emails_by_assign_or_link') { |
||
| 109 | $linked_field = 'emails'; |
||
| 110 | } |
||
| 111 | //based on listview since that lets you select records |
||
| 112 | if ($layout_def['ListView'] && !$hideremove) { |
||
| 113 | $retStr = "<a href=\"javascript:sub_p_rem('$subpanel', '$linked_field'" |
||
| 114 | . ", '$record', $refresh_page);\"" |
||
| 115 | . ' class="listViewTdToolsS1"' |
||
| 116 | . "id=$unique_id" |
||
| 117 | . " onclick=\"return sp_rem_conf();\"" |
||
| 118 | . ">$icon_remove_text</a>"; |
||
| 119 | |||
| 120 | return $retStr; |
||
| 121 | |||
| 122 | } |
||
| 123 | |||
| 124 | return ''; |
||
| 125 | |||
| 126 | } |
||
| 127 | } |
||
| 128 |
