adamjakab / SuiteCRM

include/database/MssqlManager.php

Switch Indentation +71 added lines, -71 removed lines

@@ -1304,24 +1304,24 @@ 
     protected function alterSQLRep($action, array $def, $ignoreRequired, $tablename)
     {
         switch($action){
-        case 'add':
-             $f_def=$this->oneColumnSQLRep($def, $ignoreRequired,$tablename,false);
-            return "ADD " . $f_def;
-            break;
-        case 'drop':
-            return "DROP COLUMN " . $def['name'];
-            break;
-        case 'modify':
-            //You cannot specify a default value for a column for MSSQL
-            $f_def  = $this->oneColumnSQLRep($def, $ignoreRequired,$tablename, true);
-            $f_stmt = "ALTER COLUMN ".$f_def['name'].' '.$f_def['colType'].' '.
-                        $f_def['required'].' '.$f_def['auto_increment']."\n";
-            if (!empty( $f_def['default']))
-                $f_stmt .= " ALTER TABLE " . $tablename .  " ADD  ". $f_def['default'] . " FOR " . $def['name'];
-            return $f_stmt;
-            break;
-        default:
-            return '';
+            case 'add':
+                 $f_def=$this->oneColumnSQLRep($def, $ignoreRequired,$tablename,false);
+                return "ADD " . $f_def;
+                break;
+            case 'drop':
+                return "DROP COLUMN " . $def['name'];
+                break;
+            case 'modify':
+                //You cannot specify a default value for a column for MSSQL
+                $f_def  = $this->oneColumnSQLRep($def, $ignoreRequired,$tablename, true);
+                $f_stmt = "ALTER COLUMN ".$f_def['name'].' '.$f_def['colType'].' '.
+                            $f_def['required'].' '.$f_def['auto_increment']."\n";
+                if (!empty( $f_def['default']))
+                    $f_stmt .= " ALTER TABLE " . $tablename .  " ADD  ". $f_def['default'] . " FOR " . $def['name'];
+                return $f_stmt;
+                break;
+            default:
+                return '';
     	}
     }
 
@@ -1511,59 +1511,59 @@ 
 
         switch ($type){
         // generic indices
-        case 'index':
-        case 'alternate_key':
-            if ($drop)
-                $sql = "DROP INDEX {$name} ON {$table}";
-            else
-                $sql = "CREATE INDEX {$name} ON {$table} ({$fields})";
-            break;
-        case 'clustered':
-            if ($drop)
-                $sql = "DROP INDEX {$name} ON {$table}";
-            else
-                $sql = "CREATE CLUSTERED INDEX $name ON $table ($fields)";
-            break;
-            // constraints as indices
-        case 'unique':
-            if ($drop)
-                $sql = "ALTER TABLE {$table} DROP CONSTRAINT $name";
-            else
-                $sql = "ALTER TABLE {$table} ADD CONSTRAINT {$name} UNIQUE ({$fields})";
-            break;
-        case 'primary':
-            if ($drop)
-                $sql = "ALTER TABLE {$table} DROP CONSTRAINT {$name}";
-            else
-                $sql = "ALTER TABLE {$table} ADD CONSTRAINT {$name} PRIMARY KEY ({$fields})";
-            break;
-        case 'foreign':
-            if ($drop)
-                $sql = "ALTER TABLE {$table} DROP FOREIGN KEY ({$fields})";
-            else
-                $sql = "ALTER TABLE {$table} ADD CONSTRAINT {$name}  FOREIGN KEY ({$fields}) REFERENCES {$definition['foreignTable']}({$definition['foreignFields']})";
-            break;
-        case 'fulltext':
-            if ($this->full_text_indexing_enabled() && $drop) {
-                $sql = "DROP FULLTEXT INDEX ON {$table}";
-            } elseif ($this->full_text_indexing_enabled()) {
-                $catalog_name=$this->ftsCatalogName();
-                if ( isset($definition['catalog_name']) && $definition['catalog_name'] != 'default')
-                    $catalog_name = $definition['catalog_name'];
-
-                $language = "Language 1033";
-                if (isset($definition['language']) && !empty($definition['language']))
-                    $language = "Language " . $definition['language'];
-
-                $key_index = $definition['key_index'];
-
-                $change_tracking = "auto";
-                if (isset($definition['change_tracking']) && !empty($definition['change_tracking']))
-                    $change_tracking = $definition['change_tracking'];
-
-                $sql = " CREATE FULLTEXT INDEX ON $table ($fields $language) KEY INDEX $key_index ON $catalog_name WITH CHANGE_TRACKING $change_tracking" ;
-            }
-            break;
+            case 'index':
+            case 'alternate_key':
+                if ($drop)
+                    $sql = "DROP INDEX {$name} ON {$table}";
+                else
+                    $sql = "CREATE INDEX {$name} ON {$table} ({$fields})";
+                break;
+            case 'clustered':
+                if ($drop)
+                    $sql = "DROP INDEX {$name} ON {$table}";
+                else
+                    $sql = "CREATE CLUSTERED INDEX $name ON $table ($fields)";
+                break;
+                // constraints as indices
+            case 'unique':
+                if ($drop)
+                    $sql = "ALTER TABLE {$table} DROP CONSTRAINT $name";
+                else
+                    $sql = "ALTER TABLE {$table} ADD CONSTRAINT {$name} UNIQUE ({$fields})";
+                break;
+            case 'primary':
+                if ($drop)
+                    $sql = "ALTER TABLE {$table} DROP CONSTRAINT {$name}";
+                else
+                    $sql = "ALTER TABLE {$table} ADD CONSTRAINT {$name} PRIMARY KEY ({$fields})";
+                break;
+            case 'foreign':
+                if ($drop)
+                    $sql = "ALTER TABLE {$table} DROP FOREIGN KEY ({$fields})";
+                else
+                    $sql = "ALTER TABLE {$table} ADD CONSTRAINT {$name}  FOREIGN KEY ({$fields}) REFERENCES {$definition['foreignTable']}({$definition['foreignFields']})";
+                break;
+            case 'fulltext':
+                if ($this->full_text_indexing_enabled() && $drop) {
+                    $sql = "DROP FULLTEXT INDEX ON {$table}";
+                } elseif ($this->full_text_indexing_enabled()) {
+                    $catalog_name=$this->ftsCatalogName();
+                    if ( isset($definition['catalog_name']) && $definition['catalog_name'] != 'default')
+                        $catalog_name = $definition['catalog_name'];
+
+                    $language = "Language 1033";
+                    if (isset($definition['language']) && !empty($definition['language']))
+                        $language = "Language " . $definition['language'];
+
+                    $key_index = $definition['key_index'];
+
+                    $change_tracking = "auto";
+                    if (isset($definition['change_tracking']) && !empty($definition['change_tracking']))
+                        $change_tracking = $definition['change_tracking'];
+
+                    $sql = " CREATE FULLTEXT INDEX ON $table ($fields $language) KEY INDEX $key_index ON $catalog_name WITH CHANGE_TRACKING $change_tracking" ;
+                }
+                break;
         }
         return $sql;
     }

Doc Comments +4 added lines, -4 removed lines

@@ -1298,7 +1298,7 @@ 
      * modify operation
      * @param string $action
      * @param array  $def
-     * @param bool   $ignorRequired
+     * @param boolean   $ignoreRequired
      * @param string $tablename
      */
     protected function alterSQLRep($action, array $def, $ignoreRequired, $tablename)
@@ -1767,7 +1767,7 @@ 
     /**
      * Saves changes to module's audit table
      *
-     * @param object $bean    Sugarbean instance
+     * @param SugarBean $bean    Sugarbean instance
      * @param array  $changes changes
      */
     public function save_audit_records(SugarBean $bean, $changes)
@@ -1876,7 +1876,7 @@ 
      * This is a utility function to prepend the "N" character in front of SQL values that are
      * surrounded by single quotes.
      *
-     * @param  $sql string SQL statement
+     * @param  string $sql string SQL statement
      * @return string SQL statement with single quote values prepended with "N" character for nvarchar columns
      */
     protected function _appendN($sql)
@@ -1947,7 +1947,7 @@ 
 
     /**
      * Generate fulltext query from set of terms
-     * @param string $fields Field to search against
+     * @param string $field Field to search against
      * @param array $terms Search terms that may be or not be in the result
      * @param array $must_terms Search terms that have to be in the result
      * @param array $exclude_terms Search terms that have to be not in the result

include/database/MysqlManager.php

Switch Indentation +49 added lines, -49 removed lines

@@ -825,33 +825,33 @@ 
 			$fields = $index['fields'];
 
 		switch ($type) {
-		case 'unique':
-			$columns[] = " UNIQUE $name ($fields)";
-			break;
-		case 'primary':
-			$columns[] = " PRIMARY KEY ($fields)";
-			break;
-		case 'index':
-		case 'foreign':
-		case 'clustered':
-		case 'alternate_key':
-			/**
+		    case 'unique':
+			    $columns[] = " UNIQUE $name ($fields)";
+			    break;
+		    case 'primary':
+			    $columns[] = " PRIMARY KEY ($fields)";
+			    break;
+		    case 'index':
+		    case 'foreign':
+		    case 'clustered':
+		    case 'alternate_key':
+			    /**
 				* @todo here it is assumed that the primary key of the foreign
 				* table will always be named 'id'. It must be noted though
 				* that this can easily be fixed by referring to db dictionary
 				* to find the correct primary field name
 				*/
-			if ( $alter_table )
-				$columns[] = " INDEX $name ($fields)";
-			else
-				$columns[] = " KEY $name ($fields)";
-			break;
-		case 'fulltext':
-			if ($this->full_text_indexing_installed())
-				$columns[] = " FULLTEXT ($fields)";
-			else
-				$GLOBALS['log']->debug('MYISAM engine is not available/enabled, full-text indexes will be skipped. Skipping:',$name);
-			break;
+			    if ( $alter_table )
+				    $columns[] = " INDEX $name ($fields)";
+			    else
+				    $columns[] = " KEY $name ($fields)";
+			    break;
+		    case 'fulltext':
+			    if ($this->full_text_indexing_installed())
+				    $columns[] = " FULLTEXT ($fields)";
+			    else
+				    $GLOBALS['log']->debug('MYISAM engine is not available/enabled, full-text indexes will be skipped. Skipping:',$name);
+			    break;
 		}
 	}
 	$columns = implode(", $alter_action ", $columns);
@@ -935,33 +935,33 @@ 
 
 		switch ($type){
 		// generic indices
-		case 'index':
-		case 'alternate_key':
-		case 'clustered':
-			if ($drop)
-				$sql = "ALTER TABLE {$table} DROP INDEX {$name} ";
-			else
-				$sql = "ALTER TABLE {$table} ADD INDEX {$name} ({$fields})";
-			break;
-		// constraints as indices
-		case 'unique':
-			if ($drop)
-				$sql = "ALTER TABLE {$table} DROP INDEX $name";
-			else
-				$sql = "ALTER TABLE {$table} ADD CONSTRAINT UNIQUE {$name} ({$fields})";
-			break;
-		case 'primary':
-			if ($drop)
-				$sql = "ALTER TABLE {$table} DROP PRIMARY KEY";
-			else
-				$sql = "ALTER TABLE {$table} ADD CONSTRAINT PRIMARY KEY ({$fields})";
-			break;
-		case 'foreign':
-			if ($drop)
-				$sql = "ALTER TABLE {$table} DROP FOREIGN KEY ({$fields})";
-			else
-				$sql = "ALTER TABLE {$table} ADD CONSTRAINT FOREIGN KEY {$name} ({$fields}) REFERENCES {$definition['foreignTable']}({$definition['foreignField']})";
-			break;
+		    case 'index':
+		    case 'alternate_key':
+		    case 'clustered':
+			    if ($drop)
+				    $sql = "ALTER TABLE {$table} DROP INDEX {$name} ";
+			    else
+				    $sql = "ALTER TABLE {$table} ADD INDEX {$name} ({$fields})";
+			    break;
+		    // constraints as indices
+		    case 'unique':
+			    if ($drop)
+				    $sql = "ALTER TABLE {$table} DROP INDEX $name";
+			    else
+				    $sql = "ALTER TABLE {$table} ADD CONSTRAINT UNIQUE {$name} ({$fields})";
+			    break;
+		    case 'primary':
+			    if ($drop)
+				    $sql = "ALTER TABLE {$table} DROP PRIMARY KEY";
+			    else
+				    $sql = "ALTER TABLE {$table} ADD CONSTRAINT PRIMARY KEY ({$fields})";
+			    break;
+		    case 'foreign':
+			    if ($drop)
+				    $sql = "ALTER TABLE {$table} DROP FOREIGN KEY ({$fields})";
+			    else
+				    $sql = "ALTER TABLE {$table} ADD CONSTRAINT FOREIGN KEY {$name} ({$fields}) REFERENCES {$definition['foreignTable']}({$definition['foreignField']})";
+			    break;
 		}
 		return $sql;
 	}

Doc Comments +5 added lines, -2 removed lines

@@ -651,7 +651,7 @@ 
 	/**
 	 * Returns the name of the engine to use or null if we are to use the default
 	 *
-	 * @param  object $bean SugarBean instance
+	 * @param  SugarBean $bean SugarBean instance
 	 * @return string
 	 */
 	protected function getEngine($bean)
@@ -1149,7 +1149,7 @@ 
 
 	/**
 	 * Generate fulltext query from set of terms
-	 * @param string $fields Field to search against
+	 * @param string $field Field to search against
 	 * @param array $terms Search terms that may be or not be in the result
 	 * @param array $must_terms Search terms that have to be in the result
 	 * @param array $exclude_terms Search terms that have to be not in the result
@@ -1276,6 +1276,9 @@ 
 		return '';
 	}
 
+	/**
+	 * @param string $querytype
+	 */
 	protected function verifyGenericReplaceQuery($querytype, $table, $query)
 	{
 		$this->log->debug("verifying $querytype statement");

include/MVC/View/SugarView.php

Switch Indentation +12 added lines, -12 removed lines

@@ -1387,18 +1387,18 @@
 		//$params = array();
         if (isset($this->action)){
             switch ($this->action) {
-            case 'EditView':
-                if(!empty($this->bean->id) && (empty($_REQUEST['isDuplicate']) || $_REQUEST['isDuplicate'] === 'false')) {
-                    $params[] = "<a href='index.php?module={$this->module}&action=DetailView&record={$this->bean->id}'>".$this->bean->get_summary_text()."</a>";
-                    $params[] = $GLOBALS['app_strings']['LBL_EDIT_BUTTON_LABEL'];
-                }
-                else
-                    $params[] = $GLOBALS['app_strings']['LBL_CREATE_BUTTON_LABEL'];
-                break;
-            case 'DetailView':
-                $beanName = $this->bean->get_summary_text();
-                $params[] = $beanName;
-                break;
+                case 'EditView':
+                    if(!empty($this->bean->id) && (empty($_REQUEST['isDuplicate']) || $_REQUEST['isDuplicate'] === 'false')) {
+                        $params[] = "<a href='index.php?module={$this->module}&action=DetailView&record={$this->bean->id}'>".$this->bean->get_summary_text()."</a>";
+                        $params[] = $GLOBALS['app_strings']['LBL_EDIT_BUTTON_LABEL'];
+                    }
+                    else
+                        $params[] = $GLOBALS['app_strings']['LBL_CREATE_BUTTON_LABEL'];
+                    break;
+                case 'DetailView':
+                    $beanName = $this->bean->get_summary_text();
+                    $params[] = $beanName;
+                    break;
             }
         }
 

Doc Comments +6 added lines, -2 removed lines

@@ -1039,6 +1039,7 @@ 
      *
      * @param string option - the option that we want to know the valye of
      * @param bool default - what the default value should be if we do not find the option
+     * @param string $option
      *
      * @return bool - the value of the option
      */
@@ -1273,7 +1274,7 @@ 
     * Return the "breadcrumbs" to display at the top of the page
     *
     * @param  bool $show_help optional, true if we show the help links
-    * @return HTML string containing breadcrumb title
+    * @return string string containing breadcrumb title
     */
     public function getModuleTitle(
         $show_help = true
@@ -1446,6 +1447,9 @@ 
     	}
     }
 
+    /**
+     * @param string $module
+     */
     protected function getModuleTitleIconPath($module)
     {
     	$iconPath = "";
@@ -1496,7 +1500,7 @@ 
     /**
      * Fetch config values to be put into an array for JavaScript
      *
-     * @return array
+     * @return string[]
      */
     protected function getSugarConfigJS(){
         global $sugar_config;

modules/Import/maps/ImportMapOutlook.php

Switch Indentation +13 added lines, -13 removed lines

@@ -78,19 +78,19 @@
     {
         $return_array = parent::getMapping($module);
         switch ($module) {
-        case 'Contacts':
-        case 'Leads':
-            return $return_array + array(
-                "Job Title"=>"title",
-                "Home Country"=>"alt_address_country",
-                "E-mail 2 Address"=>"email2",
-                );
-            break;
-        case 'Accounts':
-            return $return_array;
-            break;
-        default:
-            return $return_array;
+            case 'Contacts':
+            case 'Leads':
+                return $return_array + array(
+                    "Job Title"=>"title",
+                    "Home Country"=>"alt_address_country",
+                    "E-mail 2 Address"=>"email2",
+                    );
+                break;
+            case 'Accounts':
+                return $return_array;
+                break;
+            default:
+                return $return_array;
         }
     }
 }

modules/Import/maps/ImportMapSalesforce.php

Switch Indentation +70 added lines, -70 removed lines

@@ -78,76 +78,76 @@
     {
         $return_array = parent::getMapping($module);
         switch ($module) {
-        case 'Contacts':
-        case 'Leads':
-            return $return_array + array(
-                "Description"=>"description",
-                "Birthdate"=>"birthdate",
-                "Lead Source"=>"lead_source",
-                "Assistant"=>"assistant",
-                "Asst. Phone"=>"assistant_phone",
-                "Mailing Street"=>"primary_address_street",
-                "Mailing Address Line1"=>"primary_address_street_2",
-                "Mailing Address Line2"=>"primary_address_street_3",
-                "Mailing Address Line3"=>"primary_address_street_4",
-                "Mailing City"=>"primary_address_city",
-                "Mailing State"=>"primary_address_state",
-                "Mailing Zip/Postal Code"=>"primary_address_postalcode",
-                "Mailing Country"=>"primary_address_country",
-                "Other Street"=>"alt_address_street",
-                "Other Address Line 1"=>"alt_address_street_2",
-                "Other Address Line 2"=>"alt_address_street_3",
-                "Other Address Line 3"=>"alt_address_street_4",
-                "Other City"=>"alt_address_city",
-                "Other State"=>"alt_address_state",
-                "Other Zip/Postal Code"=>"alt_address_postalcode",
-                "Other Country"=>"alt_address_country",
-                "Phone"=>"phone_work",
-                "Mobile"=>"phone_mobile",
-                "Home Phone"=>"phone_home",
-                "Other Phone"=>"phone_other",
-                "Fax"=>"phone_fax",
-                "Email"=>"email1",
-                "Email Opt Out"=>"email_opt_out",
-                "Do Not Call"=>"do_not_call",
-                "Account Name"=>"account_name",
-                );
-            break;
-        case 'Accounts':
-            return array(
-                "Account Name"=>"name",
-                "Annual Revenue"=>"annual_revenue",
-                "Type"=>"account_type",
-                "Ticker Symbol"=>"ticker_symbol",
-                "Rating"=>"rating",
-                "Industry"=>"industry",
-                "SIC Code"=>"sic_code",
-                "Ownership"=>"ownership",
-                "Employees"=>"employees",
-                "Description"=>"description",
-                "Billing Street"=>"billing_address_street",
-                "Billing Address Line1"=>"billing_address_street_2",
-                "Billing Address Line2"=>"billing_address_street_3",
-                "Billing City"=>"billing_address_city",
-                "Billing State"=>"billing_address_state",
-                "Billing State/Province"=>"billing_address_state",
-                "Billing Zip/Postal Code"=>"billing_address_postalcode",
-                "Billing Country"=>"billing_address_country",
-                "Shipping Street"=>"shipping_address_street",
-                "Shipping Address Line1"=>"shipping_address_street_2",
-                "Shipping Address Line2"=>"shipping_address_street_3",
-                "Shipping City"=>"shipping_address_city",
-                "Shipping State"=>"shipping_address_state",
-                "Shipping Zip/Postal Code"=>"shipping_address_postalcode",
-                "Shipping Country"=>"shipping_address_country",
-                "Phone"=>"phone_office",
-                "Fax"=>"phone_fax",
-                "Website"=>"website",
-                "Created Date"=>"date_entered",
-                );
-            break;
-        default:
-            return $return_array;
+            case 'Contacts':
+            case 'Leads':
+                return $return_array + array(
+                    "Description"=>"description",
+                    "Birthdate"=>"birthdate",
+                    "Lead Source"=>"lead_source",
+                    "Assistant"=>"assistant",
+                    "Asst. Phone"=>"assistant_phone",
+                    "Mailing Street"=>"primary_address_street",
+                    "Mailing Address Line1"=>"primary_address_street_2",
+                    "Mailing Address Line2"=>"primary_address_street_3",
+                    "Mailing Address Line3"=>"primary_address_street_4",
+                    "Mailing City"=>"primary_address_city",
+                    "Mailing State"=>"primary_address_state",
+                    "Mailing Zip/Postal Code"=>"primary_address_postalcode",
+                    "Mailing Country"=>"primary_address_country",
+                    "Other Street"=>"alt_address_street",
+                    "Other Address Line 1"=>"alt_address_street_2",
+                    "Other Address Line 2"=>"alt_address_street_3",
+                    "Other Address Line 3"=>"alt_address_street_4",
+                    "Other City"=>"alt_address_city",
+                    "Other State"=>"alt_address_state",
+                    "Other Zip/Postal Code"=>"alt_address_postalcode",
+                    "Other Country"=>"alt_address_country",
+                    "Phone"=>"phone_work",
+                    "Mobile"=>"phone_mobile",
+                    "Home Phone"=>"phone_home",
+                    "Other Phone"=>"phone_other",
+                    "Fax"=>"phone_fax",
+                    "Email"=>"email1",
+                    "Email Opt Out"=>"email_opt_out",
+                    "Do Not Call"=>"do_not_call",
+                    "Account Name"=>"account_name",
+                    );
+                break;
+            case 'Accounts':
+                return array(
+                    "Account Name"=>"name",
+                    "Annual Revenue"=>"annual_revenue",
+                    "Type"=>"account_type",
+                    "Ticker Symbol"=>"ticker_symbol",
+                    "Rating"=>"rating",
+                    "Industry"=>"industry",
+                    "SIC Code"=>"sic_code",
+                    "Ownership"=>"ownership",
+                    "Employees"=>"employees",
+                    "Description"=>"description",
+                    "Billing Street"=>"billing_address_street",
+                    "Billing Address Line1"=>"billing_address_street_2",
+                    "Billing Address Line2"=>"billing_address_street_3",
+                    "Billing City"=>"billing_address_city",
+                    "Billing State"=>"billing_address_state",
+                    "Billing State/Province"=>"billing_address_state",
+                    "Billing Zip/Postal Code"=>"billing_address_postalcode",
+                    "Billing Country"=>"billing_address_country",
+                    "Shipping Street"=>"shipping_address_street",
+                    "Shipping Address Line1"=>"shipping_address_street_2",
+                    "Shipping Address Line2"=>"shipping_address_street_3",
+                    "Shipping City"=>"shipping_address_city",
+                    "Shipping State"=>"shipping_address_state",
+                    "Shipping Zip/Postal Code"=>"shipping_address_postalcode",
+                    "Shipping Country"=>"shipping_address_country",
+                    "Phone"=>"phone_office",
+                    "Fax"=>"phone_fax",
+                    "Website"=>"website",
+                    "Created Date"=>"date_entered",
+                    );
+                break;
+            default:
+                return $return_array;
         }
     }
 	

modules/Import/maps/ImportMapOther.php

Switch Indentation +64 added lines, -64 removed lines

@@ -75,70 +75,70 @@
         )
     {
         switch ($module) {
-        case 'Contacts':
-        case 'Leads':
-            return array(
-                "Salutation"=>"salutation",
-                "Full Name"=>"full_name",
-                "Company"=>"company",
-                "First Name"=>"first_name",
-                "Last Name"=>"last_name",
-                "Title"=>"title",
-                "Department"=>"department",
-                "Birthday"=>"birthdate",
-                "Home Phone"=>"phone_home",
-                "Mobile Phone"=>"phone_mobile",
-                "Business Phone"=>"phone_work",
-                "Other Phone"=>"phone_other",
-                "Business Fax"=>"phone_fax",
-                "E-mail Address"=>"email1",
-                "E-mail 2"=>"email2",
-                "Assistant's Name"=>"assistant",
-                "Assistant's Phone"=>"assistant_phone",
-                "Business Street"=>"primary_address_street",
-                "Business Street 2"=>"primary_address_street_2",
-                "Business Street 3"=>"primary_address_street_3",
-                "Business City"=>"primary_address_city",
-                "Business State"=>"primary_address_state",
-                "Business Postal Code"=>"primary_address_postalcode",
-                "Business Country/Region"=>"primary_address_country",
-                "Home Street"=>"alt_address_street",
-                "Home Street 2"=>"alt_address_street_2",
-                "Home Street 3"=>"alt_address_street_3",
-                "Home City"=>"alt_address_city",
-                "Home State"=>"alt_address_state",
-                "Home Postal Code"=>"alt_address_postalcode",
-                "Home Country/Region"=>"alt_address_country",
-                );
-            break;
-        case 'Accounts':
-            return array(
-                "Company"=>"name",
-                "Business Street"=>"billing_address_street",
-                "Business City"=>"billing_address_city",
-                "Business State"=>"billing_address_state",
-                "Business Country"=>"billing_address_country",
-                "Business Postal Code"=>"billing_address_postalcode",
-                "Business Fax"=>"phone_fax",
-                "Company Main Phone"=>"phone_office",
-                "Web Page"=>"website",
-                );
-            break;
-        case 'Opportunities':
-            return array(
-                "Opportunity Name"=>"name" ,
-                "Type"=>"opportunity_type",
-                "Lead Source"=>"lead_source",
-                "Amount"=>"amount",
-                "Created Date"=>"date_entered",
-                "Close Date"=>"date_closed",
-                "Next Step"=>"next_step",
-                "Stage"=>"sales_stage",
-                "Probability (%)"=>"probability",
-                "Account Name"=>"account_name");
-            break;
-        default:
-            return array();
+            case 'Contacts':
+            case 'Leads':
+                return array(
+                    "Salutation"=>"salutation",
+                    "Full Name"=>"full_name",
+                    "Company"=>"company",
+                    "First Name"=>"first_name",
+                    "Last Name"=>"last_name",
+                    "Title"=>"title",
+                    "Department"=>"department",
+                    "Birthday"=>"birthdate",
+                    "Home Phone"=>"phone_home",
+                    "Mobile Phone"=>"phone_mobile",
+                    "Business Phone"=>"phone_work",
+                    "Other Phone"=>"phone_other",
+                    "Business Fax"=>"phone_fax",
+                    "E-mail Address"=>"email1",
+                    "E-mail 2"=>"email2",
+                    "Assistant's Name"=>"assistant",
+                    "Assistant's Phone"=>"assistant_phone",
+                    "Business Street"=>"primary_address_street",
+                    "Business Street 2"=>"primary_address_street_2",
+                    "Business Street 3"=>"primary_address_street_3",
+                    "Business City"=>"primary_address_city",
+                    "Business State"=>"primary_address_state",
+                    "Business Postal Code"=>"primary_address_postalcode",
+                    "Business Country/Region"=>"primary_address_country",
+                    "Home Street"=>"alt_address_street",
+                    "Home Street 2"=>"alt_address_street_2",
+                    "Home Street 3"=>"alt_address_street_3",
+                    "Home City"=>"alt_address_city",
+                    "Home State"=>"alt_address_state",
+                    "Home Postal Code"=>"alt_address_postalcode",
+                    "Home Country/Region"=>"alt_address_country",
+                    );
+                break;
+            case 'Accounts':
+                return array(
+                    "Company"=>"name",
+                    "Business Street"=>"billing_address_street",
+                    "Business City"=>"billing_address_city",
+                    "Business State"=>"billing_address_state",
+                    "Business Country"=>"billing_address_country",
+                    "Business Postal Code"=>"billing_address_postalcode",
+                    "Business Fax"=>"phone_fax",
+                    "Company Main Phone"=>"phone_office",
+                    "Web Page"=>"website",
+                    );
+                break;
+            case 'Opportunities':
+                return array(
+                    "Opportunity Name"=>"name" ,
+                    "Type"=>"opportunity_type",
+                    "Lead Source"=>"lead_source",
+                    "Amount"=>"amount",
+                    "Created Date"=>"date_entered",
+                    "Close Date"=>"date_closed",
+                    "Next Step"=>"next_step",
+                    "Stage"=>"sales_stage",
+                    "Probability (%)"=>"probability",
+                    "Account Name"=>"account_name");
+                break;
+            default:
+                return array();
         }
     }
 	

modules/Administration/UpgradeWizard_commit.php

Switch Indentation +50 added lines, -50 removed lines

@@ -305,50 +305,50 @@ 
 }
 
 switch( $install_type ){
-    case "langpack":
-        if( !isset($_REQUEST['new_lang_name']) || ($_REQUEST['new_lang_name'] == "") ){
-            die($mod_strings['ERR_UW_NO_LANG']);
-        }
-        if( !isset($_REQUEST['new_lang_desc']) || ($_REQUEST['new_lang_desc'] == "") ){
-            die($mod_strings['ERR_UW_NO_LANG_DESC']);
-        }
+        case "langpack":
+            if( !isset($_REQUEST['new_lang_name']) || ($_REQUEST['new_lang_name'] == "") ){
+                die($mod_strings['ERR_UW_NO_LANG']);
+            }
+            if( !isset($_REQUEST['new_lang_desc']) || ($_REQUEST['new_lang_desc'] == "") ){
+                die($mod_strings['ERR_UW_NO_LANG_DESC']);
+            }
 
-        if( $mode == "Install" || $mode=="Enable" ){
-            $sugar_config['languages'] = $sugar_config['languages'] + array( $_REQUEST['new_lang_name'] => $_REQUEST['new_lang_desc'] );
-        }
-        else if( $mode == "Uninstall" || $mode=="Disable" ){
-            $new_langs = array();
-            $old_langs = $sugar_config['languages'];
-            foreach( $old_langs as $key => $value ){
-                if( $key != $_REQUEST['new_lang_name'] ){
-                    $new_langs += array( $key => $value );
+            if( $mode == "Install" || $mode=="Enable" ){
+                $sugar_config['languages'] = $sugar_config['languages'] + array( $_REQUEST['new_lang_name'] => $_REQUEST['new_lang_desc'] );
+            }
+            else if( $mode == "Uninstall" || $mode=="Disable" ){
+                $new_langs = array();
+                $old_langs = $sugar_config['languages'];
+                foreach( $old_langs as $key => $value ){
+                    if( $key != $_REQUEST['new_lang_name'] ){
+                        $new_langs += array( $key => $value );
+                    }
                 }
+			    $sugar_config['languages'] = $new_langs;
+
+	            $default_sugar_instance_lang = 'en_us';
+	            if($current_language == $_REQUEST['new_lang_name']){
+	        	    $_SESSION['authenticated_user_language'] =$default_sugar_instance_lang;
+	        	    $lang_changed_string = $mod_strings['LBL_CURRENT_LANGUAGE_CHANGE'].$sugar_config['languages'][$default_sugar_instance_lang].'<br/>';
+	            }
+
+	            if($sugar_config['default_language'] == $_REQUEST['new_lang_name']){
+	        	    $cfg = new Configurator();
+             	    $cfg->config['languages'] = $new_langs;
+				    $cfg->config['default_language'] = $default_sugar_instance_lang;
+				    $cfg->handleOverride();
+	        	    $lang_changed_string .= $mod_strings['LBL_DEFAULT_LANGUAGE_CHANGE'].$sugar_config['languages'][$default_sugar_instance_lang].'<br/>';
+	            }
             }
-			$sugar_config['languages'] = $new_langs;
-
-	        $default_sugar_instance_lang = 'en_us';
-	        if($current_language == $_REQUEST['new_lang_name']){
-	        	$_SESSION['authenticated_user_language'] =$default_sugar_instance_lang;
-	        	$lang_changed_string = $mod_strings['LBL_CURRENT_LANGUAGE_CHANGE'].$sugar_config['languages'][$default_sugar_instance_lang].'<br/>';
-	        }
-
-	        if($sugar_config['default_language'] == $_REQUEST['new_lang_name']){
-	        	$cfg = new Configurator();
-             	$cfg->config['languages'] = $new_langs;
-				$cfg->config['default_language'] = $default_sugar_instance_lang;
-				$cfg->handleOverride();
-	        	$lang_changed_string .= $mod_strings['LBL_DEFAULT_LANGUAGE_CHANGE'].$sugar_config['languages'][$default_sugar_instance_lang].'<br/>';
-	        }
-        }
-        ksort( $sugar_config );
-        if( !write_array_to_file( "sugar_config", $sugar_config, "config.php" ) ){
-            die($mod_strings['ERR_UW_CONFIG_FAILED']);
-        }
-        break;
-    case "module":
-        require_once( "ModuleInstall/ModuleInstaller.php" );
-        $mi = new ModuleInstaller();
-        switch( $mode ){
+            ksort( $sugar_config );
+            if( !write_array_to_file( "sugar_config", $sugar_config, "config.php" ) ){
+                die($mod_strings['ERR_UW_CONFIG_FAILED']);
+            }
+            break;
+        case "module":
+            require_once( "ModuleInstall/ModuleInstaller.php" );
+            $mi = new ModuleInstaller();
+            switch( $mode ){
             case "Install":
             //here we can determine if this is an upgrade or a new version
             	if(!empty($previous_version)){
@@ -388,14 +388,14 @@ 
                 break;
             default:
                 break;
-        }
+            }
         $current_user->incrementETag("mainMenuETag");
         break;
-    case "full":
-        // purposely flow into "case: patch"
-    case "patch":
- 		switch($mode)
- 		{
+        case "full":
+            // purposely flow into "case: patch"
+        case "patch":
+ 		    switch($mode)
+ 		    {
  			case 'Install':
  				$file = "$unzip_dir/" . constant('SUGARCRM_POST_INSTALL_FILE');
 				if(is_file($file))
@@ -424,7 +424,7 @@ 
  				break;
  			default:
  				break;
- 		}
+ 		    }
 
 		require( "sugar_version.php" );
 		$sugar_config['sugar_version'] = $sugar_version;
@@ -435,8 +435,8 @@ 
 			die($mod_strings['ERR_UW_UPDATE_CONFIG']);
 		}
         break;
-    default:
-        break;
+        default:
+            break;
 }
 
 switch( $mode ){

modules/Administration/UpgradeWizard_prepare.php

Switch Indentation +79 added lines, -79 removed lines

@@ -164,58 +164,58 @@ 
 	}//fi
 }
 switch( $install_type ){
-	case "full":
-	case "patch":
-		if( !is_writable( "config.php" ) ){
-			die( $mod_strings['ERR_UW_CONFIG'] );
-		}
-		break;
-	case "theme":
-		break;
-	case "langpack":
-		// find name of language pack: find single file in include/language/xx_xx.lang.php
-		$d = dir( "$unzip_dir/$zip_from_dir/include/language" );
-		while( $f = $d->read() ){
-			if( $f == "." || $f == ".." ){
-				continue;
-			}
-			else if( preg_match("/(.*)\.lang\.php\$/", $f, $match) ){
-				$new_lang_name = $match[1];
-			}
-		}
-		if( $new_lang_name == "" ){
-			die( $mod_strings['ERR_UW_NO_LANGPACK'].$install_file );
-		}
-		$hidden_fields .= "<input type=hidden name=\"new_lang_name\" value=\"$new_lang_name\"/>";
-
-		$new_lang_desc = getLanguagePackName( "$unzip_dir/$zip_from_dir/include/language/$new_lang_name.lang.php" );
-		if( $new_lang_desc == "" ){
-			die( $mod_strings['ERR_UW_NO_LANG_DESC_1']."include/language/$new_lang_name.lang.php".$mod_strings['ERR_UW_NO_LANG_DESC_2']."$install_file." );
-		}
-		$hidden_fields .= "<input type=hidden name=\"new_lang_desc\" value=\"$new_lang_desc\"/>";
-
-		if( !is_writable( "config.php" ) ){
-			die( $mod_strings['ERR_UW_CONFIG'] );
-		}
-		break;
-	case "module":
-		$previous_install = array();
-		if(!empty($id_name) & !empty($version))
-		$previous_install = $uh->determineIfUpgrade($id_name, $version);
-		$previous_version = (empty($previous_install['version'])) ? '' : $previous_install['version'];
-		$previous_id = (empty($previous_install['id'])) ? '' : $previous_install['id'];
-		$show_files = false;
-		//rrs pull out unique_key
-		$hidden_fields .= "<input type=hidden name=\"author\" value=\"$author\"/>";
-		$hidden_fields .= "<input type=hidden name=\"name\" value=\"$name\"/>";
-		$hidden_fields .= "<input type=hidden name=\"description\" value=\"$description\"/>";
-		$hidden_fields .= "<input type=hidden name=\"is_uninstallable\" value=\"$is_uninstallable\"/>";
-		$hidden_fields .= "<input type=hidden name=\"id_name\" value=\"$id_name\"/>";
-		$hidden_fields .= "<input type=hidden name=\"previous_version\" value=\"$previous_version\"/>";
-		$hidden_fields .= "<input type=hidden name=\"previous_id\" value=\"$previous_id\"/>";
-		break;
-	default:
-		die( $mod_strings['ERR_UW_WRONG_TYPE'].$install_type );
+	    case "full":
+	    case "patch":
+		    if( !is_writable( "config.php" ) ){
+			    die( $mod_strings['ERR_UW_CONFIG'] );
+		    }
+		    break;
+	    case "theme":
+		    break;
+	    case "langpack":
+		    // find name of language pack: find single file in include/language/xx_xx.lang.php
+		    $d = dir( "$unzip_dir/$zip_from_dir/include/language" );
+		    while( $f = $d->read() ){
+			    if( $f == "." || $f == ".." ){
+				    continue;
+			    }
+			    else if( preg_match("/(.*)\.lang\.php\$/", $f, $match) ){
+				    $new_lang_name = $match[1];
+			    }
+		    }
+		    if( $new_lang_name == "" ){
+			    die( $mod_strings['ERR_UW_NO_LANGPACK'].$install_file );
+		    }
+		    $hidden_fields .= "<input type=hidden name=\"new_lang_name\" value=\"$new_lang_name\"/>";
+
+		    $new_lang_desc = getLanguagePackName( "$unzip_dir/$zip_from_dir/include/language/$new_lang_name.lang.php" );
+		    if( $new_lang_desc == "" ){
+			    die( $mod_strings['ERR_UW_NO_LANG_DESC_1']."include/language/$new_lang_name.lang.php".$mod_strings['ERR_UW_NO_LANG_DESC_2']."$install_file." );
+		    }
+		    $hidden_fields .= "<input type=hidden name=\"new_lang_desc\" value=\"$new_lang_desc\"/>";
+
+		    if( !is_writable( "config.php" ) ){
+			    die( $mod_strings['ERR_UW_CONFIG'] );
+		    }
+		    break;
+	    case "module":
+		    $previous_install = array();
+		    if(!empty($id_name) & !empty($version))
+		    $previous_install = $uh->determineIfUpgrade($id_name, $version);
+		    $previous_version = (empty($previous_install['version'])) ? '' : $previous_install['version'];
+		    $previous_id = (empty($previous_install['id'])) ? '' : $previous_install['id'];
+		    $show_files = false;
+		    //rrs pull out unique_key
+		    $hidden_fields .= "<input type=hidden name=\"author\" value=\"$author\"/>";
+		    $hidden_fields .= "<input type=hidden name=\"name\" value=\"$name\"/>";
+		    $hidden_fields .= "<input type=hidden name=\"description\" value=\"$description\"/>";
+		    $hidden_fields .= "<input type=hidden name=\"is_uninstallable\" value=\"$is_uninstallable\"/>";
+		    $hidden_fields .= "<input type=hidden name=\"id_name\" value=\"$id_name\"/>";
+		    $hidden_fields .= "<input type=hidden name=\"previous_version\" value=\"$previous_version\"/>";
+		    $hidden_fields .= "<input type=hidden name=\"previous_id\" value=\"$previous_id\"/>";
+		    break;
+	    default:
+		    die( $mod_strings['ERR_UW_WRONG_TYPE'].$install_type );
 }
 
 
@@ -317,33 +317,33 @@ 
 }
 
 switch( $mode ){
-	case "Install":
-		if( $install_type == "langpack") {
-			print( $mod_strings['LBL_UW_LANGPACK_READY'] );
-			echo '<br><br>';
-		}
-		break;
-	case "Uninstall":
-		if( $install_type == "langpack" ){
-			print( $mod_strings['LBL_UW_LANGPACK_READY_UNISTALL'] );
-			echo '<br><br>';
-		}
-		else if($install_type != "module"){
-			print( $mod_strings['LBL_UW_FILES_REMOVED'] );
-		}
-		break;
-	case "Disable":
-		if( $install_type == "langpack" ){
-			print( $mod_strings['LBL_UW_LANGPACK_READY_DISABLE'] );
-			echo '<br><br>';
-		}
-		break;
-	case "Enable":
-		if( $install_type == "langpack" ){
-			print( $mod_strings['LBL_UW_LANGPACK_READY_ENABLE'] );
-			echo '<br><br>';
-		}
-		break;
+	    case "Install":
+		    if( $install_type == "langpack") {
+			    print( $mod_strings['LBL_UW_LANGPACK_READY'] );
+			    echo '<br><br>';
+		    }
+		    break;
+	    case "Uninstall":
+		    if( $install_type == "langpack" ){
+			    print( $mod_strings['LBL_UW_LANGPACK_READY_UNISTALL'] );
+			    echo '<br><br>';
+		    }
+		    else if($install_type != "module"){
+			    print( $mod_strings['LBL_UW_FILES_REMOVED'] );
+		    }
+		    break;
+	    case "Disable":
+		    if( $install_type == "langpack" ){
+			    print( $mod_strings['LBL_UW_LANGPACK_READY_DISABLE'] );
+			    echo '<br><br>';
+		    }
+		    break;
+	    case "Enable":
+		    if( $install_type == "langpack" ){
+			    print( $mod_strings['LBL_UW_LANGPACK_READY_ENABLE'] );
+			    echo '<br><br>';
+		    }
+		    break;
 }
 
 

data/Link2.php

Doc Comments +3 added lines, -2 removed lines

@@ -74,7 +74,7 @@ 
      * @param  $linkName String name of a link field in the module's vardefs
      * @param  $bean SugarBean focus bean for this link (one half of a relationship)
      * @param  $linkDef Array Optional vardef for the link in case it can't be found in the passed in bean for the global dictionary
-     * @return void
+     * @return false|null
      *
      */
     function __construct($linkName, $bean, $linkDef = false){
@@ -356,7 +356,7 @@ 
     /**
      * @param array $params optional parameters. Possible Values;
      * 'return_as_array': returns the query broken into
-     * @return String/Array query to grab just ids for this relationship
+     * @return string query to grab just ids for this relationship
      */
     function getQuery($params = array())
     {
@@ -686,6 +686,7 @@ 
     /**
      * @deprecated
      * Gets the vardef for the relationship of this link.
+     * @param string $def_name
      */
     public function _get_link_table_definition($table_name, $def_name) {