adamjakab / SuiteCRM

modules/Relationships/RelationshipHandler.php

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/ProspectLists/ProspectList.php

Braces +42 added lines, -31 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -103,8 +105,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -137,19 +138,21 @@ 
 			$where_auto = '1=1';
 				if($show_deleted == 0){
                 	$where_auto = "$this->table_name.deleted=0";
-				}else if($show_deleted == 1){
+				} else if($show_deleted == 1){
                 	$where_auto = "$this->table_name.deleted=1";
 				}
 
-		if($where != "")
-			$query .= "where $where AND ".$where_auto;
-		else
-			$query .= "where ".$where_auto;
+		if($where != "") {
+					$query .= "where $where AND ".$where_auto;
+		} else {
+					$query .= "where ".$where_auto;
+		}
 
-		if($order_by != "")
-			$query .= " ORDER BY $order_by";
-		else
-			$query .= " ORDER BY prospect_lists.name";
+		if($order_by != "") {
+					$query .= " ORDER BY $order_by";
+		} else {
+					$query .= " ORDER BY prospect_lists.name";
+		}
 
 		return $query;
 	}
@@ -167,15 +170,17 @@ 
 
 		$where_auto = " prospect_lists.deleted=0";
 
-        if($where != "")
-                $query .= " WHERE $where AND ".$where_auto;
-        else
-                $query .= " WHERE ".$where_auto;
+        if($where != "") {
+                        $query .= " WHERE $where AND ".$where_auto;
+        } else {
+                        $query .= " WHERE ".$where_auto;
+        }
 
-        if($order_by != "")
-                $query .= " ORDER BY $order_by";
-        else
-                $query .= " ORDER BY prospect_lists.name";
+        if($order_by != "") {
+                        $query .= " ORDER BY $order_by";
+        } else {
+                        $query .= " ORDER BY prospect_lists.name";
+        }
         return $query;
     }
 
@@ -302,12 +307,15 @@ 
 	function save_relationship_changes($is_update, $exclude = array())
     {
     	parent::save_relationship_changes($is_update, $exclude);
-		if($this->lead_id != "")
-	   		$this->set_prospect_relationship($this->id, $this->lead_id, "lead");
-    	if($this->contact_id != "")
-    		$this->set_prospect_relationship($this->id, $this->contact_id, "contact");
-    	if($this->prospect_id != "")
-    		$this->set_prospect_relationship($this->id, $this->contact_id, "prospect");
+		if($this->lead_id != "") {
+			   		$this->set_prospect_relationship($this->id, $this->lead_id, "lead");
+		}
+    	if($this->contact_id != "") {
+    	    		$this->set_prospect_relationship($this->id, $this->contact_id, "contact");
+    	}
+    	if($this->prospect_id != "") {
+    	    		$this->set_prospect_relationship($this->id, $this->contact_id, "prospect");
+    	}
     }
 
 	function set_prospect_relationship($prospect_list_id, &$link_ids, $link_name)
@@ -365,10 +373,11 @@ 
 
 		$row = $this->db->fetchByAssoc($result);
 
-		if($row)
-			return $row['num'];
-		else
-			return 0;
+		if($row) {
+					return $row['num'];
+		} else {
+					return 0;
+		}
 	}
 
 
@@ -390,7 +399,9 @@ 
 		$the_where = "";
 		foreach($where_clauses as $clause)
 		{
-			if($the_where != "") $the_where .= " or ";
+			if($the_where != "") {
+			    $the_where .= " or ";
+			}
 			$the_where .= $clause;
 		}
 

modules/SchedulersJobs/SchedulersJob.php

Braces +6 added lines, -7 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -110,8 +112,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -587,12 +588,10 @@ 
                 } else {
                     return $this->resolution != self::JOB_FAILURE;
                 }
-            }
-            else {
+            } else {
                 $this->resolveJob(self::JOB_FAILURE, sprintf(translate('ERR_JOBTYPE', 'SchedulersJobs'), strip_tags($this->target)));
             }
-        }
-        else {
+        } else {
 		    $this->resolveJob(self::JOB_FAILURE, sprintf(translate('ERR_JOBTYPE', 'SchedulersJobs'), strip_tags($this->target)));
 		}
 		return false;

modules/Connectors/ConnectorRecord.php

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/ACLActions/ACLAction.php

Braces +20 added lines, -15 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -62,8 +64,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -100,7 +101,7 @@ 
                 }
             }
 
-        }else{
+        } else{
             sugar_die("FAILED TO ADD: $category - TYPE $type NOT DEFINED IN modules/ACLActions/actiondefs.php");
         }
 
@@ -128,7 +129,7 @@ 
                     $action->mark_deleted($row['id']);
                 }
             }
-        }else{
+        } else{
             sugar_die("FAILED TO REMOVE: $category : $name - TYPE $type NOT DEFINED IN modules/ACLActions/actiondefs.php");
         }
     }
@@ -196,7 +197,9 @@ 
         global $ACLActions;
         $options = array();
 
-        if(empty($ACLActions[$type]['actions'][$action]['aclaccess']))return $options;
+        if(empty($ACLActions[$type]['actions'][$action]['aclaccess'])) {
+            return $options;
+        }
         foreach($ACLActions[$type]['actions'][$action]['aclaccess'] as $action){
             $options[$action] = ACLAction::AccessName($action);
         }
@@ -247,14 +250,14 @@ 
         if(!$refresh && !empty($_SESSION['ACL'][$user_id])){
             if(empty($category) && empty($action)){
                 return $_SESSION['ACL'][$user_id];
-            }else{
+            } else{
                 if(!empty($category) && isset($_SESSION['ACL'][$user_id][$category])){
                     if(empty($action)){
                         if(empty($type)){
                             return $_SESSION['ACL'][$user_id][$category];
                         }
                         return $_SESSION['ACL'][$user_id][$category][$type];
-                    }else if(!empty($type) && isset($_SESSION['ACL'][$user_id][$category][$type][$action])){
+                    } else if(!empty($type) && isset($_SESSION['ACL'][$user_id][$category][$type][$action])){
                         return $_SESSION['ACL'][$user_id][$category][$type][$action];
                     }
                 }
@@ -374,12 +377,12 @@ 
                 $_SESSION['ACL'] = array();
             }
             $_SESSION['ACL'][$user_id] = $selected_actions;
-        }else{
+        } else{
             if(empty($action) && !empty($category)){
                 if(!empty($type)){
                     $_SESSION['ACL'][$user_id][$category][$type] = $selected_actions[$category][$type];}
                 $_SESSION['ACL'][$user_id][$category] = $selected_actions[$category];
-            }else{
+            } else{
                 if(!empty($action) && !empty($category) && !empty($type)){
                 $_SESSION['ACL'][$user_id][$category][$type][$action] = $selected_actions[$category][$action];
 
@@ -398,8 +401,9 @@ 
         // Fallback to array key if translation is empty
         $a = empty($app_list_strings['moduleList'][$a]) ? $a : $app_list_strings['moduleList'][$a];
         $b = empty($app_list_strings['moduleList'][$b]) ? $b : $app_list_strings['moduleList'][$b];
-        if ($a == $b)
-            return 0;
+        if ($a == $b) {
+                    return 0;
+        }
         return ($a < $b) ? -1 : 1;
     }
 
@@ -494,7 +498,9 @@ 
         return true;
         }
         //check if we don't have it set in the cache if not lets reload the cache
-        if(ACLAction::getUserAccessLevel($user_id, $category, 'access', $type) < ACL_ALLOW_ENABLED) return false;
+        if(ACLAction::getUserAccessLevel($user_id, $category, 'access', $type) < ACL_ALLOW_ENABLED) {
+            return false;
+        }
         if(empty($_SESSION['ACL'][$user_id][$category][$type][$action])){
             ACLAction::getUserActions($user_id, false);
 
@@ -590,8 +596,7 @@ 
                     if($cat_name=='Users'&& $act_name=='admin'){
                         $categories[$cat_name][$type_name][$act_name]['accessOptions'][ACL_ALLOW_DEFAULT]=ACLAction::AccessName(ACL_ALLOW_DEFAULT);;
                         $categories[$cat_name][$type_name][$act_name]['accessOptions'][ACL_ALLOW_DEV]=ACLAction::AccessName(ACL_ALLOW_DEV);;
-                    }
-                    else{
+                    } else{
                     $categories[$cat_name][$type_name][$act_name]['accessOptions'] =  ACLAction::getAccessOptions($act_name, $type_name);
                     }
                 }

modules/Users/authentication/SugarAuthenticate/SugarAuthenticate.php

Braces +15 added lines, -14 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,8 +63,7 @@ 
 	    // check in custom dir first, in case someone want's to override an auth controller
 		if (file_exists('custom/modules/Users/authentication/'.$this->authenticationDir.'/' . $this->userAuthenticateClass . '.php')) {
             require_once('custom/modules/Users/authentication/'.$this->authenticationDir.'/' . $this->userAuthenticateClass . '.php');
-        }
-        elseif (file_exists('modules/Users/authentication/'.$this->authenticationDir.'/' . $this->userAuthenticateClass . '.php')) {
+        } elseif (file_exists('modules/Users/authentication/'.$this->authenticationDir.'/' . $this->userAuthenticateClass . '.php')) {
             require_once('modules/Users/authentication/'.$this->authenticationDir.'/' . $this->userAuthenticateClass . '.php');
         }
 
@@ -76,8 +77,7 @@ 
 		$deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
 		if(isset($GLOBALS['log'])) {
 			$GLOBALS['log']->deprecated($deprecatedMessage);
-		}
-		else {
+		} else {
 			trigger_error($deprecatedMessage, E_USER_DEPRECATED);
 		}
 		self::__construct();
@@ -113,15 +113,15 @@ 
 			}
 			return $this->postLoginAuthenticate();
 
-		}
-		else
+		} else
 		{
 			//if(!empty($usr_id) && $res['lockoutexpiration'] > 0){
             if(!empty($usr_id)){
-				if (($logout=$usr->getPreference('loginfailed'))=='')
-	        		$usr->setPreference('loginfailed','1');
-	    		else
-	        		$usr->setPreference('loginfailed',$logout+1);
+				if (($logout=$usr->getPreference('loginfailed'))=='') {
+					        		$usr->setPreference('loginfailed','1');
+				} else {
+	    			        		$usr->setPreference('loginfailed',$logout+1);
+	    		}
 	    		$usr->savePreferencesToDB();
     		}
 		}
@@ -160,7 +160,9 @@ 
 		unset($_SESSION['ACL']);
 
 		//set the server unique key
-		if (isset ($sugar_config['unique_key']))$_SESSION['unique_key'] = $sugar_config['unique_key'];
+		if (isset ($sugar_config['unique_key'])) {
+		    $_SESSION['unique_key'] = $sugar_config['unique_key'];
+		}
 
 		//set user language
 		if (isset ($reset_language_on_default_user) && $reset_language_on_default_user && $GLOBALS['current_user']->user_name == $sugar_config['default_user_name']) {
@@ -277,8 +279,7 @@ 
 				$client_parts = explode(".", $clientIP);
                 if(count($session_parts) < 4) {
                     $classCheck = 0;
-                }
-                else {
+                } else {
     				// match class C IP addresses
     				for ($i = 0; $i < 3; $i ++) {
     					if ($session_parts[$i] == $client_parts[$i]) {

modules/Documents/Document.php

Braces +23 added lines, -15 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry)
+if(!defined('sugarEntry') || !sugarEntry) {
 	die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -110,8 +111,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -252,9 +252,13 @@ 
             	$this->name = $this->document_name;
             }
 
-            if(isset($row['filename']))$this->filename = $row['filename'];
+            if(isset($row['filename'])) {
+                $this->filename = $row['filename'];
+            }
             //$this->latest_revision = $row['revision'];
-            if(isset($row['revision']))$this->revision = $row['revision'];
+            if(isset($row['revision'])) {
+                $this->revision = $row['revision'];
+            }
 
             //image is selected based on the extension name <ext>_icon_inline, extension is stored in document_revisions.
             //if file is not found then default image file will be used.
@@ -281,7 +285,7 @@ 
 
     		$this->file_url = $file_url;
     		$this->file_url_noimage = "index.php?entryPoint=download&type=Documents&id={$this->document_revision_id}";
-		}else{
+		} else{
             $this->file_url = "";
             $this->file_url_noimage = "";
 		}
@@ -321,15 +325,17 @@ 
 
 		$where_auto = " documents.deleted = 0";
 
-		if ($where != "")
-			$query .= " WHERE $where AND ".$where_auto;
-		else
-			$query .= " WHERE ".$where_auto;
+		if ($where != "") {
+					$query .= " WHERE $where AND ".$where_auto;
+		} else {
+					$query .= " WHERE ".$where_auto;
+		}
 
-		if ($order_by != "")
-			$query .= " ORDER BY $order_by";
-		else
-			$query .= " ORDER BY documents.document_name";
+		if ($order_by != "") {
+					$query .= " ORDER BY $order_by";
+		} else {
+					$query .= " ORDER BY documents.document_name";
+		}
 
 		return $query;
 	}
@@ -389,7 +395,9 @@ 
 
 	//static function.
 	function get_document_name($doc_id){
-		if (empty($doc_id)) return null;
+		if (empty($doc_id)) {
+		    return null;
+		}
 
 		$db = DBManagerFactory::getInstance();
 		$query="select document_name from documents where id='$doc_id'  and deleted=0";

modules/UpgradeWizard/upgradeMetaHelper.php

Braces +14 added lines, -13 removed lines

@@ -83,8 +83,7 @@ 
 		$deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
 		if(isset($GLOBALS['log'])) {
 			$GLOBALS['log']->deprecated($deprecatedMessage);
-		}
-		else {
+		} else {
 			trigger_error($deprecatedMessage, E_USER_DEPRECATED);
 		}
 		self::__construct($dir, $masterCopyDirecotry, $debugMode);
@@ -145,12 +144,10 @@ 
 	$file_queries_file = $upgrade_progress_dir.'/files_queries.php';
 	if(file_exists($file_queries_file)){
 		include($file_queries_file);
-	}
-	else{
+	} else{
 		if(function_exists('sugar_fopen')){
 			sugar_fopen($file_queries_file, 'w+');
-		}
-		else{
+		} else{
 			fopen($file_queries_file, 'w+');
 		}
 	}
@@ -176,7 +173,9 @@ 
     $modulesAll = getAllModules(); //keep all modules as well
     $allOtherModules = array_diff($modulesAll,$modules);
     foreach($modules as $mod) {
-	  if(!is_dir('modules/'.$mod)) continue;
+	  if(!is_dir('modules/'.$mod)) {
+	      continue;
+	  }
 	  $editView = "modules/$mod/EditView.html";
 	  $detailView ="modules/$mod/DetailView.html";
 	  $exclude_files[]=$editView;
@@ -190,8 +189,7 @@ 
 		       	  $fileContents = file_get_contents($file);
 		       	  if(md5($fileContents) != $md5_string['./'.$file]) {
 		       	  	$return_array[$mod][] = $file;
-		       	  }
-		       	  else{
+		       	  } else{
 		       	  	//keep in the array to be deleted later
 		       	  	$_SESSION['removeMd5MatchingFiles'][] = $file;
 		               	  }
@@ -202,7 +200,9 @@ 
     //also check out other non-studio modules by taking the difference between
     //allMOdules and
   foreach($allOtherModules as $mod) {
-	  if(!is_dir('modules/'.$mod)) continue;
+	  if(!is_dir('modules/'.$mod)) {
+	      continue;
+	  }
 	  $allModFiles = array();
       $allModFiles = findAllFiles('modules/'.$mod,$allModFiles);
       foreach($allModFiles as $file){
@@ -251,8 +251,7 @@ 
 	               	  	  $return_array[$mod];
 	               	  	  break;
 	               	  }
-               	  }
-               	  else{
+               	  } else{
                	  	// This is a new file in user's version and indicates that module has been
                	  	//customized. Put the module in the customized array.
                        echo 'New File'.$file;
@@ -275,7 +274,9 @@ 
 		$modules = array();
 		$d = dir('modules');
 		while($e = $d->read()){
-			if(substr($e, 0, 1) == '.' || !is_dir('modules/' . $e))continue;
+			if(substr($e, 0, 1) == '.' || !is_dir('modules/' . $e)) {
+			    continue;
+			}
 			if(file_exists('modules/' . $e . '/metadata/studio.php')){
 			   $modules[] = $e;
 			}

modules/Opportunities/OpportunitiesJjwg_MapsLogicHook.php

Braces +3 added lines, -3 removed lines

@@ -1,7 +1,8 @@ 
 <?php
 
-if (!defined('sugarEntry') || !sugarEntry)
+if (!defined('sugarEntry') || !sugarEntry) {
     die('Not A Valid Entry Point');
+}
 
 class OpportunitiesJjwg_MapsLogicHook {
 
@@ -17,8 +18,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();