adamjakab / SuiteCRM

include/generic/SugarWidgets/SugarWidgetFieldtext.php

Indentation +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     function queryFilterEquals($layout_def)
     {
         return $this->reporter->db->convert($this->_get_column_select($layout_def), "text2char").
-        	" = ".$this->reporter->db->quoted($layout_def['input_name0']);
+            " = ".$this->reporter->db->quoted($layout_def['input_name0']);
     }
 
     function queryFilterNot_Equals_Str($layout_def)

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,9 +50,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function SugarWidgetFieldText(&$layout_manager){
+    function SugarWidgetFieldText(&$layout_manager) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -71,7 +71,7 @@ 
     function queryFilterNot_Equals_Str($layout_def)
     {
         $column = $this->_get_column_select($layout_def);
-        return "($column IS NULL OR ". $this->reporter->db->convert($column, "text2char")." != ".
+        return "($column IS NULL OR ".$this->reporter->db->convert($column, "text2char")." != ".
             $this->reporter->db->quoted($layout_def['input_name0']).")";
     }
 

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

include/generic/SugarWidgets/SugarWidgetSubPanelTopSelectAccountButton.php

Indentation +9 added lines, -9 removed lines

@@ -44,21 +44,21 @@
 
 
 class SugarWidgetSubPanelTopSelectAccountButton extends SugarWidgetSubPanelTopSelectButton {
-	function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
-	{
-		/*
+    function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
+    {
+        /*
 		* i.dymovsky
 		* Because when user role can't edit Accounts, it also can't edit Membership Organizations. Select button leads to change MO list
 		* See bug 25633
 		* Bug25633 code change start
 		*/
-		if (!ACLController::checkAccess($widget_data["module"], "edit", true)) {
-			return ;
-		}
-		/*
+        if (!ACLController::checkAccess($widget_data["module"], "edit", true)) {
+            return ;
+        }
+        /*
 		* Bug25633 code change end
 		*/
 		
-		return parent::display($widget_data);
-	}
+        return parent::display($widget_data);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,7 +53,7 @@ 
 		* Bug25633 code change start
 		*/
 		if (!ACLController::checkAccess($widget_data["module"], "edit", true)) {
-			return ;
+			return;
 		}
 		/*
 		* Bug25633 code change end

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetFielddatetimecombo.php

Indentation +18 added lines, -18 removed lines

@@ -42,28 +42,28 @@
 
 
 class SugarWidgetFieldDateTimecombo extends SugarWidgetFieldDateTime {
-	var $reporter;
-	var $assigned_user=null;
+    var $reporter;
+    var $assigned_user=null;
 
     function SugarWidgetFieldDateTimecombo(&$layout_manager) {
         parent::SugarWidgetFieldDateTime($layout_manager);
         $this->reporter = $this->layout_manager->getAttribute('reporter');
     }
-	//TODO:now for date time field , we just search from date start to date end. The time is from 00:00:00 to 23:59:59
-	//If there is requirement, we can modify report.js::addFilterInputDatetimesBetween and this function
-	function queryFilterBetween_Datetimes(& $layout_def) {
-		global $timedate;
-		if($this->getAssignedUser()) {
-			$begin = $timedate->handle_offset($layout_def['input_name0'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
-			$end = $timedate->handle_offset($layout_def['input_name2'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
-		}
-		else {
-			$begin = $layout_def['input_name0'];
-			$end = $layout_def['input_name1'];
-		}
-		return "(".$this->_get_column_select($layout_def).">=".$this->reporter->db->convert($this->reporter->db->quoted($begin), "datetime").
-			" AND\n ".$this->_get_column_select($layout_def)."<=".$this->reporter->db->convert($this->reporter->db->quoted($end), "datetime").
-			")\n";
-	}
+    //TODO:now for date time field , we just search from date start to date end. The time is from 00:00:00 to 23:59:59
+    //If there is requirement, we can modify report.js::addFilterInputDatetimesBetween and this function
+    function queryFilterBetween_Datetimes(& $layout_def) {
+        global $timedate;
+        if($this->getAssignedUser()) {
+            $begin = $timedate->handle_offset($layout_def['input_name0'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
+            $end = $timedate->handle_offset($layout_def['input_name2'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
+        }
+        else {
+            $begin = $layout_def['input_name0'];
+            $end = $layout_def['input_name1'];
+        }
+        return "(".$this->_get_column_select($layout_def).">=".$this->reporter->db->convert($this->reporter->db->quoted($begin), "datetime").
+            " AND\n ".$this->_get_column_select($layout_def)."<=".$this->reporter->db->convert($this->reporter->db->quoted($end), "datetime").
+            ")\n";
+    }
 
 }

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -43,7 +43,7 @@ 
 
 class SugarWidgetFieldDateTimecombo extends SugarWidgetFieldDateTime {
 	var $reporter;
-	var $assigned_user=null;
+	var $assigned_user = null;
 
     function __construct(&$layout_manager) {
         parent::__construct($layout_manager);
@@ -53,9 +53,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function SugarWidgetFieldDateTimecombo(&$layout_manager){
+    function SugarWidgetFieldDateTimecombo(&$layout_manager) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -68,7 +68,7 @@ 
 	//If there is requirement, we can modify report.js::addFilterInputDatetimesBetween and this function
 	function queryFilterBetween_Datetimes(& $layout_def) {
 		global $timedate;
-		if($this->getAssignedUser()) {
+		if ($this->getAssignedUser()) {
 			$begin = $timedate->handle_offset($layout_def['input_name0'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
 			$end = $timedate->handle_offset($layout_def['input_name2'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
 		}

Braces +5 added lines, -5 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -57,8 +59,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($layout_manager);
@@ -71,8 +72,7 @@ 
 		if($this->getAssignedUser()) {
 			$begin = $timedate->handle_offset($layout_def['input_name0'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
 			$end = $timedate->handle_offset($layout_def['input_name2'], $timedate->get_db_date_time_format(), false, $this->assigned_user);
-		}
-		else {
+		} else {
 			$begin = $layout_def['input_name0'];
 			$end = $layout_def['input_name1'];
 		}

include/generic/SugarWidgets/SugarWidgetSubPanelDelegatesSelectButton.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -47,7 +47,7 @@ 
     {
         global $mod_strings;
         $button = "<script src='include/javascript/checkbox.js' type='text/javascript'></script>";
-        $button  .= "<form id='CustSelectForm' name='CustSelectForm' method='post' action=''>";
+        $button .= "<form id='CustSelectForm' name='CustSelectForm' method='post' action=''>";
 
        // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
         $button .= "<input id='Custom_Select' class='button' type='button' name='Custom_Select' onclick='select_targets()' value='".$mod_strings['LBL_SELECT_DELEGATES']."'/>\n</form>";	

Indentation +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
         global $mod_strings;
         
         $button  = "<form id='ManageDelegatesForm' name='ManageDelegatesForm' method='post' action=''>";
-       // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
+        // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
         $button .= "<input id='Manage_Delegates' class='button' type='button' name='Manage_Delegates' onclick='manage_delegates()' value='".$mod_strings['LBL_MANAGE_DELEGATES']."'/>\n</form>";
         return $button;
     }

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelTopButton_c.php

Braces +33 added lines, -28 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -66,31 +68,38 @@ 
 			$class_details = $module;
 
 			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($class_details['module']))
-				$this->module = $class_details['module'];
-			if(!empty($class_details['title']))
-				$this->title = $app_strings[$class_details['title']];
-			if(!empty($class_details['access_key']))
-				$this->access_key = $app_strings[$class_details['access_key']];
-			if(!empty($class_details['form_value']))
-				$this->form_value = translate($class_details['form_value'], $this->module);
-			if(!empty($class_details['additional_form_fields']))
-				$this->additional_form_fields = $class_details['additional_form_fields'];
+			if(!empty($class_details['module'])) {
+							$this->module = $class_details['module'];
+			}
+			if(!empty($class_details['title'])) {
+							$this->title = $app_strings[$class_details['title']];
+			}
+			if(!empty($class_details['access_key'])) {
+							$this->access_key = $app_strings[$class_details['access_key']];
+			}
+			if(!empty($class_details['form_value'])) {
+							$this->form_value = translate($class_details['form_value'], $this->module);
+			}
+			if(!empty($class_details['additional_form_fields'])) {
+							$this->additional_form_fields = $class_details['additional_form_fields'];
+			}
 			if(!empty($class_details['ACL'])){
 				$this->acl = $class_details['ACL'];
 			}
-		}
-		else
+		} else
 		{
 			$this->module = $module;
 
 			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($title))
-				$this->title = $app_strings[$title];
-			if(!empty($access_key))
-				$this->access_key = $app_strings[$access_key];
-			if(!empty($form_value))
-				$this->form_value = translate($form_value, $module);
+			if(!empty($title)) {
+							$this->title = $app_strings[$title];
+			}
+			if(!empty($access_key)) {
+							$this->access_key = $app_strings[$access_key];
+			}
+			if(!empty($form_value)) {
+							$this->form_value = translate($form_value, $module);
+			}
 		}
 	}
 
@@ -116,8 +125,7 @@ 
                 if(!empty($defines['focus']->$value))
                 {
                     $additionalFormFields[$key] = $defines['focus']->$value;
-                }
-                else
+                } else
                 {
                     $additionalFormFields[$key] = '';
                 }
@@ -128,8 +136,7 @@ 
 		if(!empty($this->module))
         {
             $defines['child_module_name'] = $this->module;
-        }
-        else
+        } else
         {
             $defines['child_module_name'] = $defines['module'];
         }
@@ -161,7 +168,7 @@ 
 
         if($currentModule == 'Campaigns'){
             $formValues['return_action'] = "DetailView";
-        }else{
+        } else{
             $formValues['return_action'] = $defines['action'];
             if ( $formValues['return_action'] == 'SubPanelViewer' ) {
                 $formValues['return_action'] = 'DetailView';
@@ -195,8 +202,7 @@ 
         {
             if($defines['focus']->object_name=='Contact') {
                 $additionalFormFields['parent_type'] = 'Accounts';
-            }
-            else {
+            } else {
                 $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
             }
         }
@@ -205,8 +211,7 @@ 
             if($defines['focus']->object_name=='Contact') {
                 $additionalFormFields['parent_name'] = $defines['focus']->account_name;
                 $additionalFormFields['account_name'] = $defines['focus']->account_name;
-            }
-            else {
+            } else {
                 $additionalFormFields['parent_name'] = $defines['focus']->name;
             }
         }

Indentation +98 added lines, -98 removed lines

@@ -46,60 +46,60 @@ 
 class SugarWidgetSubPanelTopButton_c extends SugarWidget
 {
     var $module;
-	var $title;
-	var $access_key;
-	var $form_value;
-	var $additional_form_fields;
-	var $acl;
+    var $title;
+    var $access_key;
+    var $form_value;
+    var $additional_form_fields;
+    var $acl;
 
 //TODO rename defines to layout defs and make it a member variable instead of passing it multiple layers with extra copying.
 
-	/** Take the keys for the strings and look them up.  Module is literal, the rest are label keys
-	*/
-	function __construct($module='', $title='', $access_key='', $form_value='')
-	{
-		global $app_strings;
-
-		if(is_array($module))
-		{
-			// it is really the class details from the mapping
-			$class_details = $module;
-
-			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($class_details['module']))
-				$this->module = $class_details['module'];
-			if(!empty($class_details['title']))
-				$this->title = $app_strings[$class_details['title']];
-			if(!empty($class_details['access_key']))
-				$this->access_key = $app_strings[$class_details['access_key']];
-			if(!empty($class_details['form_value']))
-				$this->form_value = translate($class_details['form_value'], $this->module);
-			if(!empty($class_details['additional_form_fields']))
-				$this->additional_form_fields = $class_details['additional_form_fields'];
-			if(!empty($class_details['ACL'])){
-				$this->acl = $class_details['ACL'];
-			}
-		}
-		else
-		{
-			$this->module = $module;
-
-			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($title))
-				$this->title = $app_strings[$title];
-			if(!empty($access_key))
-				$this->access_key = $app_strings[$access_key];
-			if(!empty($form_value))
-				$this->form_value = translate($form_value, $module);
-		}
-	}
+    /** Take the keys for the strings and look them up.  Module is literal, the rest are label keys
+     */
+    function __construct($module='', $title='', $access_key='', $form_value='')
+    {
+        global $app_strings;
+
+        if(is_array($module))
+        {
+            // it is really the class details from the mapping
+            $class_details = $module;
+
+            // If keys were passed into the constructor, translate them from keys to values.
+            if(!empty($class_details['module']))
+                $this->module = $class_details['module'];
+            if(!empty($class_details['title']))
+                $this->title = $app_strings[$class_details['title']];
+            if(!empty($class_details['access_key']))
+                $this->access_key = $app_strings[$class_details['access_key']];
+            if(!empty($class_details['form_value']))
+                $this->form_value = translate($class_details['form_value'], $this->module);
+            if(!empty($class_details['additional_form_fields']))
+                $this->additional_form_fields = $class_details['additional_form_fields'];
+            if(!empty($class_details['ACL'])){
+                $this->acl = $class_details['ACL'];
+            }
+        }
+        else
+        {
+            $this->module = $module;
+
+            // If keys were passed into the constructor, translate them from keys to values.
+            if(!empty($title))
+                $this->title = $app_strings[$title];
+            if(!empty($access_key))
+                $this->access_key = $app_strings[$access_key];
+            if(!empty($form_value))
+                $this->form_value = translate($form_value, $module);
+        }
+    }
 
     public function getWidgetId($buttonSuffix = true)
     {
-    	$widgetID = parent::getWidgetId() . '_'.preg_replace('[ ]', '', strtolower($this->form_value));
-    	if($buttonSuffix){
-    		$widgetID .= '_button';
-    	}
+        $widgetID = parent::getWidgetId() . '_'.preg_replace('[ ]', '', strtolower($this->form_value));
+        if($buttonSuffix){
+            $widgetID .= '_button';
+        }
         return $widgetID;
     }
 
@@ -125,7 +125,7 @@ 
         }
 
 
-		if(!empty($this->module))
+        if(!empty($this->module))
         {
             $defines['child_module_name'] = $this->module;
         }
@@ -135,7 +135,7 @@ 
         }
 
         $defines['parent_bean_name'] = get_class( $defines['focus']);
-		$relationship_name = $this->get_subpanel_relationship_name($defines);
+        $relationship_name = $this->get_subpanel_relationship_name($defines);
 
 
         $formValues = array();
@@ -150,10 +150,10 @@ 
             // #26451,add these fields for custom one-to-many relate field.
             if(!empty($defines['child_module_name'])){
                 $formValues[$relationship_name."_name"] = $defines['focus']->name;
-            	$childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
-            	if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
-            		$formValues[$GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name']] = $defines['focus']->id;
-            	}
+                $childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
+                if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
+                    $formValues[$GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name']] = $defines['focus']->id;
+                }
             }
         }
 
@@ -216,7 +216,7 @@ 
                 $additionalFormFields['parent_id'] = $defines['focus']->account_id;
                 $additionalFormFields['account_id'] = $defines['focus']->account_id;
             } else if($defines['focus']->object_name=='Contract') {
-            	$additionalFormFields['contract_id'] = $defines['focus']->id;
+                $additionalFormFields['contract_id'] = $defines['focus']->id;
             } else {
                 $additionalFormFields['parent_id'] = $defines['focus']->id;
             }
@@ -266,17 +266,17 @@ 
         }
     }
 
-	/** This default function is used to create the HTML for a simple button */
-	function display($defines, $additionalFormFields = null, $nonbutton = false)
-	{
-		$temp='';
-		$inputID = $this->getWidgetId();
+    /** This default function is used to create the HTML for a simple button */
+    function display($defines, $additionalFormFields = null, $nonbutton = false)
+    {
+        $temp='';
+        $inputID = $this->getWidgetId();
 
-		if(!empty($this->acl) && ACLController::moduleSupportsACL($defines['module'])  &&  !ACLController::checkAccess($defines['module'], $this->acl, true)){
-			return $temp;
-		}
+        if(!empty($this->acl) && ACLController::moduleSupportsACL($defines['module'])  &&  !ACLController::checkAccess($defines['module'], $this->acl, true)){
+            return $temp;
+        }
 
-		global $app_strings;
+        global $app_strings;
 
         if ( isset($_REQUEST['layout_def_key']) && $_REQUEST['layout_def_key'] == 'UserEAPM' ) {
             // Subpanels generally don't go on the editview, so we have to handle this special
@@ -289,42 +289,42 @@ 
         }
 
         if ($nonbutton) {
-           // $button = "<a onclick=''>$this->form_value";
+            // $button = "<a onclick=''>$this->form_value";
         }
         return $button;
-	}
-
-	/**
-	 * Returns a string that is the JSON encoded version of the popup request.
-	 * Perhaps this function should be moved to a more globally accessible location?
-	 */
-	function _create_json_encoded_popup_request($popup_request_data)
-	{
-	    return json_encode($popup_request_data);
-	}
-
-	/**
-	 * get_subpanel_relationship_name
-	 * Get the relationship name based on the subapnel definition
-	 * @param mixed $defines The subpanel definition
-	 */
-	function get_subpanel_relationship_name($defines) {
-		 $relationship_name = '';
-		 if(!empty($defines)) {
-		 	$relationship_name = isset($defines['module']) ? $defines['module'] : '';
-	     	$dataSource = $defines['subpanel_definition']->get_data_source_name(true);
-         	if (!empty($dataSource)) {
-				$relationship_name = $dataSource;
-				//Try to set the relationship name to the real relationship, not the link.
-				if (!empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource])
-				 && !empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship']))
-				{
-					$relationship_name = $defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship'];
-				}
-			}
-		 }
-		 return $relationship_name;
-	}
+    }
+
+    /**
+     * Returns a string that is the JSON encoded version of the popup request.
+     * Perhaps this function should be moved to a more globally accessible location?
+     */
+    function _create_json_encoded_popup_request($popup_request_data)
+    {
+        return json_encode($popup_request_data);
+    }
+
+    /**
+     * get_subpanel_relationship_name
+     * Get the relationship name based on the subapnel definition
+     * @param mixed $defines The subpanel definition
+     */
+    function get_subpanel_relationship_name($defines) {
+            $relationship_name = '';
+            if(!empty($defines)) {
+                $relationship_name = isset($defines['module']) ? $defines['module'] : '';
+                $dataSource = $defines['subpanel_definition']->get_data_source_name(true);
+                if (!empty($dataSource)) {
+                $relationship_name = $dataSource;
+                //Try to set the relationship name to the real relationship, not the link.
+                if (!empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource])
+                 && !empty($defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship']))
+                {
+                    $relationship_name = $defines['subpanel_definition']->parent_bean->field_defs[$dataSource]['relationship'];
+                }
+            }
+            }
+            return $relationship_name;
+    }
 
 }
 ?>

Spacing +61 added lines, -61 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -56,27 +56,27 @@ 
 
 	/** Take the keys for the strings and look them up.  Module is literal, the rest are label keys
 	*/
-	function __construct($module='', $title='', $access_key='', $form_value='')
+	function __construct($module = '', $title = '', $access_key = '', $form_value = '')
 	{
 		global $app_strings;
 
-		if(is_array($module))
+		if (is_array($module))
 		{
 			// it is really the class details from the mapping
 			$class_details = $module;
 
 			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($class_details['module']))
+			if (!empty($class_details['module']))
 				$this->module = $class_details['module'];
-			if(!empty($class_details['title']))
+			if (!empty($class_details['title']))
 				$this->title = $app_strings[$class_details['title']];
-			if(!empty($class_details['access_key']))
+			if (!empty($class_details['access_key']))
 				$this->access_key = $app_strings[$class_details['access_key']];
-			if(!empty($class_details['form_value']))
+			if (!empty($class_details['form_value']))
 				$this->form_value = translate($class_details['form_value'], $this->module);
-			if(!empty($class_details['additional_form_fields']))
+			if (!empty($class_details['additional_form_fields']))
 				$this->additional_form_fields = $class_details['additional_form_fields'];
-			if(!empty($class_details['ACL'])){
+			if (!empty($class_details['ACL'])) {
 				$this->acl = $class_details['ACL'];
 			}
 		}
@@ -85,19 +85,19 @@ 
 			$this->module = $module;
 
 			// If keys were passed into the constructor, translate them from keys to values.
-			if(!empty($title))
+			if (!empty($title))
 				$this->title = $app_strings[$title];
-			if(!empty($access_key))
+			if (!empty($access_key))
 				$this->access_key = $app_strings[$access_key];
-			if(!empty($form_value))
+			if (!empty($form_value))
 				$this->form_value = translate($form_value, $module);
 		}
 	}
 
     public function getWidgetId($buttonSuffix = true)
     {
-    	$widgetID = parent::getWidgetId() . '_'.preg_replace('[ ]', '', strtolower($this->form_value));
-    	if($buttonSuffix){
+    	$widgetID = parent::getWidgetId().'_'.preg_replace('[ ]', '', strtolower($this->form_value));
+    	if ($buttonSuffix) {
     		$widgetID .= '_button';
     	}
         return $widgetID;
@@ -109,11 +109,11 @@ 
         global $currentModule;
 
         // Create the additional form fields with real values if they were not passed in
-        if(empty($additionalFormFields) && $this->additional_form_fields)
+        if (empty($additionalFormFields) && $this->additional_form_fields)
         {
-            foreach($this->additional_form_fields as $key=>$value)
+            foreach ($this->additional_form_fields as $key=>$value)
             {
-                if(!empty($defines['focus']->$value))
+                if (!empty($defines['focus']->$value))
                 {
                     $additionalFormFields[$key] = $defines['focus']->$value;
                 }
@@ -125,7 +125,7 @@ 
         }
 
 
-		if(!empty($this->module))
+		if (!empty($this->module))
         {
             $defines['child_module_name'] = $this->module;
         }
@@ -134,7 +134,7 @@ 
             $defines['child_module_name'] = $defines['module'];
         }
 
-        $defines['parent_bean_name'] = get_class( $defines['focus']);
+        $defines['parent_bean_name'] = get_class($defines['focus']);
 		$relationship_name = $this->get_subpanel_relationship_name($defines);
 
 
@@ -144,65 +144,65 @@ 
         $formValues['module'] = $defines['child_module_name'];
         $formValues[strtolower($defines['parent_bean_name'])."_id"] = $defines['focus']->id;
 
-        if(isset($defines['focus']->name))
+        if (isset($defines['focus']->name))
         {
             $formValues[strtolower($defines['parent_bean_name'])."_name"] = $defines['focus']->name;
             // #26451,add these fields for custom one-to-many relate field.
-            if(!empty($defines['child_module_name'])){
+            if (!empty($defines['child_module_name'])) {
                 $formValues[$relationship_name."_name"] = $defines['focus']->name;
             	$childFocusName = !empty($GLOBALS['beanList'][$defines['child_module_name']]) ? $GLOBALS['beanList'][$defines['child_module_name']] : "";
-            	if(!empty($GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name'])){
-            		$formValues[$GLOBALS['dictionary'][ $childFocusName ]["fields"][$relationship_name .'_name']['id_name']] = $defines['focus']->id;
+            	if (!empty($GLOBALS['dictionary'][$childFocusName]["fields"][$relationship_name.'_name']['id_name'])) {
+            		$formValues[$GLOBALS['dictionary'][$childFocusName]["fields"][$relationship_name.'_name']['id_name']] = $defines['focus']->id;
             	}
             }
         }
 
         $formValues['return_module'] = $currentModule;
 
-        if($currentModule == 'Campaigns'){
+        if ($currentModule == 'Campaigns') {
             $formValues['return_action'] = "DetailView";
-        }else{
+        } else {
             $formValues['return_action'] = $defines['action'];
-            if ( $formValues['return_action'] == 'SubPanelViewer' ) {
+            if ($formValues['return_action'] == 'SubPanelViewer') {
                 $formValues['return_action'] = 'DetailView';
             }
         }
 
         $formValues['return_id'] = $defines['focus']->id;
         $formValues['return_relationship'] = $relationship_name;
-        switch ( strtolower( $currentModule ) )
+        switch (strtolower($currentModule))
         {
             case 'prospects' :
-                $name = $defines['focus']->account_name ;
-                break ;
+                $name = $defines['focus']->account_name;
+                break;
             case 'documents' :
-                $name = $defines['focus']->document_name ;
-                break ;
+                $name = $defines['focus']->document_name;
+                break;
             case 'kbdocuments' :
-                $name = $defines['focus']->kbdocument_name ;
-                break ;
+                $name = $defines['focus']->kbdocument_name;
+                break;
             case 'leads' :
             case 'contacts' :
-                $name = $defines['focus']->first_name . " " .$defines['focus']->last_name ;
-                break ;
+                $name = $defines['focus']->first_name." ".$defines['focus']->last_name;
+                break;
             default :
                $name = (isset($defines['focus']->name)) ? $defines['focus']->name : "";
         }
         $formValues['return_name'] = $name;
 
         // TODO: move this out and get $additionalFormFields working properly
-        if(empty($additionalFormFields['parent_type']))
+        if (empty($additionalFormFields['parent_type']))
         {
-            if($defines['focus']->object_name=='Contact') {
+            if ($defines['focus']->object_name == 'Contact') {
                 $additionalFormFields['parent_type'] = 'Accounts';
             }
             else {
                 $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
             }
         }
-        if(empty($additionalFormFields['parent_name']))
+        if (empty($additionalFormFields['parent_name']))
         {
-            if($defines['focus']->object_name=='Contact') {
+            if ($defines['focus']->object_name == 'Contact') {
                 $additionalFormFields['parent_name'] = $defines['focus']->account_name;
                 $additionalFormFields['account_name'] = $defines['focus']->account_name;
             }
@@ -210,54 +210,54 @@ 
                 $additionalFormFields['parent_name'] = $defines['focus']->name;
             }
         }
-        if(empty($additionalFormFields['parent_id']))
+        if (empty($additionalFormFields['parent_id']))
         {
-            if($defines['focus']->object_name=='Contact') {
+            if ($defines['focus']->object_name == 'Contact') {
                 $additionalFormFields['parent_id'] = $defines['focus']->account_id;
                 $additionalFormFields['account_id'] = $defines['focus']->account_id;
-            } else if($defines['focus']->object_name=='Contract') {
+            } else if ($defines['focus']->object_name == 'Contract') {
             	$additionalFormFields['contract_id'] = $defines['focus']->id;
             } else {
                 $additionalFormFields['parent_id'] = $defines['focus']->id;
             }
         }
 
-        if ($defines['focus']->object_name=='Opportunity') {
+        if ($defines['focus']->object_name == 'Opportunity') {
             $additionalFormFields['account_id'] = $defines['focus']->account_id;
             $additionalFormFields['account_name'] = $defines['focus']->account_name;
         }
 
-        if (!empty($defines['child_module_name']) and $defines['child_module_name']=='Contacts' and !empty($defines['parent_bean_name']) and $defines['parent_bean_name']=='contact' ) {
-            if (!empty($defines['focus']->id ) and !empty($defines['focus']->name)) {
+        if (!empty($defines['child_module_name']) and $defines['child_module_name'] == 'Contacts' and !empty($defines['parent_bean_name']) and $defines['parent_bean_name'] == 'contact') {
+            if (!empty($defines['focus']->id) and !empty($defines['focus']->name)) {
                 $formValues['reports_to_id'] = $defines['focus']->id;
                 $formValues['reports_to_name'] = $defines['focus']->name;
             }
         }
         $formValues['action'] = "EditView";
 
-        if ( $asUrl ) {
+        if ($asUrl) {
             $returnLink = '';
-            foreach($formValues as $key => $value ) {
+            foreach ($formValues as $key => $value) {
                 $returnLink .= $key.'='.$value.'&';
             }
-            foreach($additionalFormFields as $key => $value ) {
+            foreach ($additionalFormFields as $key => $value) {
                 $returnLink .= $key.'='.$value.'&';
             }
-            $returnLink = rtrim($returnLink,'&');
+            $returnLink = rtrim($returnLink, '&');
 
             return $returnLink;
         } else {
 
-            $form = 'form' . $relationship_name;
-            $button = '<form action="index.php" method="post" name="form" id="' . $form . "\">\n";
-            foreach($formValues as $key => $value) {
-                $button .= "<input type='hidden' name='" . $key . "' value='" . $value . "' />\n";
+            $form = 'form'.$relationship_name;
+            $button = '<form action="index.php" method="post" name="form" id="'.$form."\">\n";
+            foreach ($formValues as $key => $value) {
+                $button .= "<input type='hidden' name='".$key."' value='".$value."' />\n";
             }
 
             // fill in additional form fields for all but action
-            foreach($additionalFormFields as $key => $value) {
-                if($key != 'action') {
-                    $button .= "<input type='hidden' name='" . $key . "' value='" . $value . "' />\n";
+            foreach ($additionalFormFields as $key => $value) {
+                if ($key != 'action') {
+                    $button .= "<input type='hidden' name='".$key."' value='".$value."' />\n";
                 }
             }
 
@@ -269,18 +269,18 @@ 
 	/** This default function is used to create the HTML for a simple button */
 	function display($defines, $additionalFormFields = null, $nonbutton = false)
 	{
-		$temp='';
+		$temp = '';
 		$inputID = $this->getWidgetId();
 
-		if(!empty($this->acl) && ACLController::moduleSupportsACL($defines['module'])  &&  !ACLController::checkAccess($defines['module'], $this->acl, true)){
+		if (!empty($this->acl) && ACLController::moduleSupportsACL($defines['module']) && !ACLController::checkAccess($defines['module'], $this->acl, true)) {
 			return $temp;
 		}
 
 		global $app_strings;
 
-        if ( isset($_REQUEST['layout_def_key']) && $_REQUEST['layout_def_key'] == 'UserEAPM' ) {
+        if (isset($_REQUEST['layout_def_key']) && $_REQUEST['layout_def_key'] == 'UserEAPM') {
             // Subpanels generally don't go on the editview, so we have to handle this special
-            $megaLink = $this->_get_form($defines, $additionalFormFields,true);
+            $megaLink = $this->_get_form($defines, $additionalFormFields, true);
             //$button = "<input title='$this->title' accesskey='$this->access_key' class='button' type='submit' name='$inputID' id='$inputID' value='$this->form_value' onclick='javascript:document.location=\"index.php?".$megaLink."\"; return false;'/>";
         } else {
             $button = $this->_get_form($defines, $additionalFormFields);
@@ -310,7 +310,7 @@ 
 	 */
 	function get_subpanel_relationship_name($defines) {
 		 $relationship_name = '';
-		 if(!empty($defines)) {
+		 if (!empty($defines)) {
 		 	$relationship_name = isset($defines['module']) ? $defines['module'] : '';
 	     	$dataSource = $defines['subpanel_definition']->get_data_source_name(true);
          	if (!empty($dataSource)) {

include/generic/SugarWidgets/SugarWidgetSubPanelRelFieldEditButton.php

Indentation +12 added lines, -12 removed lines

@@ -45,14 +45,14 @@ 
 //TODO Rename this to edit link
 class SugarWidgetSubPanelRelFieldEditButton extends SugarWidgetField
 {
-	function displayHeaderCell(&$layout_def)
-	{
-		return ' ';
-	}
+    function displayHeaderCell(&$layout_def)
+    {
+        return ' ';
+    }
 
-	function displayList(&$layout_def)
-	{
-		die("<pre>" . print_r($layout_def, true) . "</pre>");
+    function displayList(&$layout_def)
+    {
+        die("<pre>" . print_r($layout_def, true) . "</pre>");
 
         $rel = $layout_def['linked_field'];
         $module = $layout_def['module'];
@@ -60,8 +60,8 @@ 
 
         global $app_strings;
 
-		$edit_icon_html = SugarThemeRegistry::current()->getImage( 'edit_inline',
-			'align="absmiddle" alt="' . $app_strings['LNK_EDIT'] . '" border="0"');
+        $edit_icon_html = SugarThemeRegistry::current()->getImage( 'edit_inline',
+            'align="absmiddle" alt="' . $app_strings['LNK_EDIT'] . '" border="0"');
 
         $script = "
         function editRel(name, id, module) {
@@ -89,9 +89,9 @@ 
 		}";
 
         return "<script>$script</script>"
-             . '<div onclick="editRel(\'p1_b1_accounts\', \'cac203f3-0380-495f-3231-4cf58f089f00\', \'Accounts\')">'
-             . $edit_icon_html . "</div>";
-	}
+                . '<div onclick="editRel(\'p1_b1_accounts\', \'cac203f3-0380-495f-3231-4cf58f089f00\', \'Accounts\')">'
+                . $edit_icon_html . "</div>";
+    }
 		
 }
 

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,7 +52,7 @@ 
 
 	function displayList(&$layout_def)
 	{
-		die("<pre>" . print_r($layout_def, true) . "</pre>");
+		die("<pre>".print_r($layout_def, true)."</pre>");
 
         $rel = $layout_def['linked_field'];
         $module = $layout_def['module'];
@@ -60,8 +60,8 @@ 
 
         global $app_strings;
 
-		$edit_icon_html = SugarThemeRegistry::current()->getImage( 'edit_inline',
-			'align="absmiddle" alt="' . $app_strings['LNK_EDIT'] . '" border="0"');
+		$edit_icon_html = SugarThemeRegistry::current()->getImage('edit_inline',
+			'align="absmiddle" alt="'.$app_strings['LNK_EDIT'].'" border="0"');
 
         $script = "
         function editRel(name, id, module) {
@@ -90,7 +90,7 @@ 
 
         return "<script>$script</script>"
              . '<div onclick="editRel(\'p1_b1_accounts\', \'cac203f3-0380-495f-3231-4cf58f089f00\', \'Accounts\')">'
-             . $edit_icon_html . "</div>";
+             . $edit_icon_html."</div>";
 	}
 		
 }

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelManageDelegatesButton.php

Indentation +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
         global $mod_strings;
         
         $button  = "<form id='ManageDelegatesForm' name='ManageDelegatesForm' method='post' action=''>";
-       // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
+        // $button .= "<input id='custom_hidden_5' type='hidden' name='custom_hidden_5' value=''/>";
         $button .= "<input id='Manage_Delegates' class='button' type='button' name='Manage_Delegates' onclick='manage_delegates()' value='".$mod_strings['LBL_MANAGE_DELEGATES']."'/>\n</form>";
         return $button;
     }

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelTopComposeEmailButton.php

Indentation +41 added lines, -41 removed lines

@@ -45,57 +45,57 @@
 
 class SugarWidgetSubPanelTopComposeEmailButton extends SugarWidgetSubPanelTopButton
 {
-	var $form_value = '';
+    var $form_value = '';
     
     public function getWidgetId($buttonSuffix = true)
     {
-    	global $app_strings;
-		$this->form_value = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_LABEL'];
-    	return parent::getWidgetId();
+        global $app_strings;
+        $this->form_value = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_LABEL'];
+        return parent::getWidgetId();
     }
 
-	function display($defines, $additionalFormFields = NULL, $nonbutton = false)
-	{
-		if((ACLController::moduleSupportsACL($defines['module'])  && !ACLController::checkAccess($defines['module'], 'edit', true) ||
-			$defines['module'] == "Activities" & !ACLController::checkAccess("Emails", 'edit', true))){
-			$temp = '';
-			return $temp;
-		}
+    function display($defines, $additionalFormFields = NULL, $nonbutton = false)
+    {
+        if((ACLController::moduleSupportsACL($defines['module'])  && !ACLController::checkAccess($defines['module'], 'edit', true) ||
+            $defines['module'] == "Activities" & !ACLController::checkAccess("Emails", 'edit', true))){
+            $temp = '';
+            return $temp;
+        }
 		
-		global $app_strings,$current_user,$sugar_config,$beanList,$beanFiles;
-		$title = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_TITLE'];
-		//$accesskey = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_KEY'];
-		$value = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_LABEL'];
-		$parent_type = $defines['focus']->module_dir;
-		$parent_id = $defines['focus']->id;
+        global $app_strings,$current_user,$sugar_config,$beanList,$beanFiles;
+        $title = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_TITLE'];
+        //$accesskey = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_KEY'];
+        $value = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_LABEL'];
+        $parent_type = $defines['focus']->module_dir;
+        $parent_id = $defines['focus']->id;
 
-		//martin Bug 19660
-		$userPref = $current_user->getPreference('email_link_type');
-		$defaultPref = $sugar_config['email_default_client'];
-		if($userPref != '') {
-			$client = $userPref;
-		} else {
-			$client = $defaultPref;
-		}
-		if($client != 'sugar') {
-			$bean = $defines['focus'];
-			// awu: Not all beans have emailAddress property, we must account for this
-			if (isset($bean->emailAddress)){
-				$to_addrs = $bean->emailAddress->getPrimaryAddress($bean);
-				$button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() . "'  name='".preg_replace('[ ]', '', $value)."'   title='$title' onclick=\"location.href='mailto:$to_addrs';return false;\" />";
-			}
-			else{
-				$button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() ."'  name='".preg_replace('[ ]', '', $value)."'  title='$title' onclick=\"location.href='mailto:';return false;\" />";
-			}
-		} else {
-			//Generate the compose package for the quick create options.
-    		$composeData = array("parent_id" => $parent_id, "parent_type"=>$parent_type);
+        //martin Bug 19660
+        $userPref = $current_user->getPreference('email_link_type');
+        $defaultPref = $sugar_config['email_default_client'];
+        if($userPref != '') {
+            $client = $userPref;
+        } else {
+            $client = $defaultPref;
+        }
+        if($client != 'sugar') {
+            $bean = $defines['focus'];
+            // awu: Not all beans have emailAddress property, we must account for this
+            if (isset($bean->emailAddress)){
+                $to_addrs = $bean->emailAddress->getPrimaryAddress($bean);
+                $button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() . "'  name='".preg_replace('[ ]', '', $value)."'   title='$title' onclick=\"location.href='mailto:$to_addrs';return false;\" />";
+            }
+            else{
+                $button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() ."'  name='".preg_replace('[ ]', '', $value)."'  title='$title' onclick=\"location.href='mailto:';return false;\" />";
+            }
+        } else {
+            //Generate the compose package for the quick create options.
+            $composeData = array("parent_id" => $parent_id, "parent_type"=>$parent_type);
             require_once('modules/Emails/EmailUI.php');
             $eUi = new EmailUI();
             $j_quickComposeOptions = $eUi->generateComposePackageForQuickCreate($composeData, http_build_query($composeData), false, $defines['focus']);
 
             $button = "<input title='$title'  id='". $this->getWidgetId()."'  onclick='SUGAR.quickCompose.init($j_quickComposeOptions);' class='button' type='submit' name='".preg_replace('[ ]', '', $value)."_button' value='$value' />";
-		}
-		return $button;
-	}
+        }
+        return $button;
+    }
 }

Spacing +11 added lines, -11 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -56,13 +56,13 @@ 
 
 	function display($defines, $additionalFormFields = NULL, $nonbutton = false)
 	{
-		if((ACLController::moduleSupportsACL($defines['module'])  && !ACLController::checkAccess($defines['module'], 'edit', true) ||
-			$defines['module'] == "Activities" & !ACLController::checkAccess("Emails", 'edit', true))){
+		if ((ACLController::moduleSupportsACL($defines['module']) && !ACLController::checkAccess($defines['module'], 'edit', true) ||
+			$defines['module'] == "Activities" & !ACLController::checkAccess("Emails", 'edit', true))) {
 			$temp = '';
 			return $temp;
 		}
 		
-		global $app_strings,$current_user,$sugar_config,$beanList,$beanFiles;
+		global $app_strings, $current_user, $sugar_config, $beanList, $beanFiles;
 		$title = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_TITLE'];
 		//$accesskey = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_KEY'];
 		$value = $app_strings['LBL_COMPOSE_EMAIL_BUTTON_LABEL'];
@@ -72,20 +72,20 @@ 
 		//martin Bug 19660
 		$userPref = $current_user->getPreference('email_link_type');
 		$defaultPref = $sugar_config['email_default_client'];
-		if($userPref != '') {
+		if ($userPref != '') {
 			$client = $userPref;
 		} else {
 			$client = $defaultPref;
 		}
-		if($client != 'sugar') {
+		if ($client != 'sugar') {
 			$bean = $defines['focus'];
 			// awu: Not all beans have emailAddress property, we must account for this
-			if (isset($bean->emailAddress)){
+			if (isset($bean->emailAddress)) {
 				$to_addrs = $bean->emailAddress->getPrimaryAddress($bean);
-				$button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() . "'  name='".preg_replace('[ ]', '', $value)."'   title='$title' onclick=\"location.href='mailto:$to_addrs';return false;\" />";
+				$button = "<input class='button' type='button'  value='$value'  id='".$this->getWidgetId()."'  name='".preg_replace('[ ]', '', $value)."'   title='$title' onclick=\"location.href='mailto:$to_addrs';return false;\" />";
 			}
-			else{
-				$button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() ."'  name='".preg_replace('[ ]', '', $value)."'  title='$title' onclick=\"location.href='mailto:';return false;\" />";
+			else {
+				$button = "<input class='button' type='button'  value='$value'  id='".$this->getWidgetId()."'  name='".preg_replace('[ ]', '', $value)."'  title='$title' onclick=\"location.href='mailto:';return false;\" />";
 			}
 		} else {
 			//Generate the compose package for the quick create options.
@@ -94,7 +94,7 @@ 
             $eUi = new EmailUI();
             $j_quickComposeOptions = $eUi->generateComposePackageForQuickCreate($composeData, http_build_query($composeData), false, $defines['focus']);
 
-            $button = "<input title='$title'  id='". $this->getWidgetId()."'  onclick='SUGAR.quickCompose.init($j_quickComposeOptions);' class='button' type='submit' name='".preg_replace('[ ]', '', $value)."_button' value='$value' />";
+            $button = "<input title='$title'  id='".$this->getWidgetId()."'  onclick='SUGAR.quickCompose.init($j_quickComposeOptions);' class='button' type='submit' name='".preg_replace('[ ]', '', $value)."_button' value='$value' />";
 		}
 		return $button;
 	}

Braces +4 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -83,8 +85,7 @@ 
 			if (isset($bean->emailAddress)){
 				$to_addrs = $bean->emailAddress->getPrimaryAddress($bean);
 				$button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() . "'  name='".preg_replace('[ ]', '', $value)."'   title='$title' onclick=\"location.href='mailto:$to_addrs';return false;\" />";
-			}
-			else{
+			} else{
 				$button = "<input class='button' type='button'  value='$value'  id='". $this->getWidgetId() ."'  name='".preg_replace('[ ]', '', $value)."'  title='$title' onclick=\"location.href='mailto:';return false;\" />";
 			}
 		} else {

include/generic/SugarWidgets/SugarWidgetSubPanelTopScheduleCallButton.php

Indentation +114 added lines, -114 removed lines

@@ -45,120 +45,120 @@
 
 class SugarWidgetSubPanelTopScheduleCallButton extends SugarWidgetSubPanelTopButtonQuickCreate
 {
-	function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
-	{
-		global $app_strings;
-		global $currentModule;
-
-		$this->module="Calls";
-		$this->subpanelDiv = "activities";
-
-		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
-		{
-			foreach($this->additional_form_fields as $key=>$value)
-			{
-				if(!empty($defines['focus']->$value))
-				{
-					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
-				{
-					$additionalFormFields[$key] = '';
-				}
-			}
-		}
-
-		if(!empty($this->module))
-		{
-			$defines['child_module_name'] = $this->module;
-		}
-		else
-		{
-			$defines['child_module_name'] = $defines['module'];
-		}
-
-		if(!empty($this->subpanelDiv))
-		{
-			$defines['subpanelDiv'] = $this->subpanelDiv;
-		}
-
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
-
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
-
-		//module_button is used to override the value of module name
-		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
-		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
-
-		if(isset($defines['focus']->name))
-		{
-			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
-		}
-
-		$button .= '<input type="hidden" name="to_pdf" value="true" />';
+    function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
+    {
+        global $app_strings;
+        global $currentModule;
+
+        $this->module="Calls";
+        $this->subpanelDiv = "activities";
+
+        // Create the additional form fields with real values if they were not passed in
+        if(empty($additionalFormFields) && $this->additional_form_fields)
+        {
+            foreach($this->additional_form_fields as $key=>$value)
+            {
+                if(!empty($defines['focus']->$value))
+                {
+                    $additionalFormFields[$key] = $defines['focus']->$value;
+                }
+                else
+                {
+                    $additionalFormFields[$key] = '';
+                }
+            }
+        }
+
+        if(!empty($this->module))
+        {
+            $defines['child_module_name'] = $this->module;
+        }
+        else
+        {
+            $defines['child_module_name'] = $defines['module'];
+        }
+
+        if(!empty($this->subpanelDiv))
+        {
+            $defines['subpanelDiv'] = $this->subpanelDiv;
+        }
+
+        $defines['parent_bean_name'] = get_class( $defines['focus']);
+
+        $form = 'form' . $defines['child_module_name'];
+        $button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+
+        //module_button is used to override the value of module name
+        $button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
+        $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
+
+        if(isset($defines['focus']->name))
+        {
+            $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
+        }
+
+        $button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
-		$button .= '<input type="hidden" name="record" value="" />';
-
-		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
-				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
-			}
-		}
-		if(empty($additionalFormFields['parent_name']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
-				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
-				$additionalFormFields['parent_name'] = $defines['focus']->name;
-			}
-		}
-		if(empty($additionalFormFields['parent_id']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
-				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
-				$additionalFormFields['parent_id'] = $defines['focus']->id;
-			}
-		}
-
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
-
-		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
-		{
-			if($key != 'action')
-			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
-			}
-		}
-		$button .= getVersionedScript('include/SugarFields/Fields/Datetimecombo/Datetimecombo.js')."\n";
-		return $button;
-	}
-
-	function display($defines, $additionalFormFields = null, $nonbutton = false)
-	{
-	    $focus = new Call;
-		if ( !$focus->ACLAccess('EditView') ) {
-		    return '';
-	    }
-
-		return parent::display($defines, $additionalFormFields);
-	}
+        $button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
+        $button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
+        $button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+        $button .= '<input type="hidden" name="record" value="" />';
+
+        // TODO: move this out and get $additionalFormFields working properly
+        if(empty($additionalFormFields['parent_type']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_type'] = 'Accounts';
+            }
+            else {
+                $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
+            }
+        }
+        if(empty($additionalFormFields['parent_name']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_name'] = $defines['focus']->account_name;
+                $additionalFormFields['account_name'] = $defines['focus']->account_name;
+            }
+            else {
+                $additionalFormFields['parent_name'] = $defines['focus']->name;
+            }
+        }
+        if(empty($additionalFormFields['parent_id']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_id'] = $defines['focus']->account_id;
+                $additionalFormFields['account_id'] = $defines['focus']->account_id;
+            }
+            else {
+                $additionalFormFields['parent_id'] = $defines['focus']->id;
+            }
+        }
+
+        $button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
+        $button .= '<input type="hidden" name="module" value="Home" />' . "\n";
+        $button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+
+        // fill in additional form fields for all but action
+        foreach($additionalFormFields as $key => $value)
+        {
+            if($key != 'action')
+            {
+                $button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+            }
+        }
+        $button .= getVersionedScript('include/SugarFields/Fields/Datetimecombo/Datetimecombo.js')."\n";
+        return $button;
+    }
+
+    function display($defines, $additionalFormFields = null, $nonbutton = false)
+    {
+        $focus = new Call;
+        if ( !$focus->ACLAccess('EditView') ) {
+            return '';
+        }
+
+        return parent::display($defines, $additionalFormFields);
+    }
 }
 ?>

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,15 +50,15 @@ 
 		global $app_strings;
 		global $currentModule;
 
-		$this->module="Calls";
+		$this->module = "Calls";
 		$this->subpanelDiv = "activities";
 
 		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
+		if (empty($additionalFormFields) && $this->additional_form_fields)
 		{
-			foreach($this->additional_form_fields as $key=>$value)
+			foreach ($this->additional_form_fields as $key=>$value)
 			{
-				if(!empty($defines['focus']->$value))
+				if (!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
 				}
@@ -69,7 +69,7 @@ 
 			}
 		}
 
-		if(!empty($this->module))
+		if (!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
 		}
@@ -78,45 +78,45 @@ 
 			$defines['child_module_name'] = $defines['module'];
 		}
 
-		if(!empty($this->subpanelDiv))
+		if (!empty($this->subpanelDiv))
 		{
 			$defines['subpanelDiv'] = $this->subpanelDiv;
 		}
 
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
+		$defines['parent_bean_name'] = get_class($defines['focus']);
 
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+		$form = 'form'.$defines['child_module_name'];
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.strtolower($defines['subpanelDiv']).'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
 
 		//module_button is used to override the value of module name
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
 
-		if(isset($defines['focus']->name))
+		if (isset($defines['focus']->name))
 		{
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
 		}
 
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
 		$button .= '<input type="hidden" name="record" value="" />';
 
 		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
+		if (empty($additionalFormFields['parent_type']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
 			}
 			else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
-		if(empty($additionalFormFields['parent_name']))
+		if (empty($additionalFormFields['parent_name']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
 			}
@@ -124,9 +124,9 @@ 
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
-		if(empty($additionalFormFields['parent_id']))
+		if (empty($additionalFormFields['parent_id']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
 			}
@@ -135,16 +135,16 @@ 
 			}
 		}
 
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
 
 		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
+		foreach ($additionalFormFields as $key => $value)
 		{
-			if($key != 'action')
+			if ($key != 'action')
 			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+				$button .= '<input type="hidden" name="'.$key.'" value="'.$value.'" />'."\n";
 			}
 		}
 		$button .= getVersionedScript('include/SugarFields/Fields/Datetimecombo/Datetimecombo.js')."\n";
@@ -154,7 +154,7 @@ 
 	function display($defines, $additionalFormFields = null, $nonbutton = false)
 	{
 	    $focus = new Call;
-		if ( !$focus->ACLAccess('EditView') ) {
+		if (!$focus->ACLAccess('EditView')) {
 		    return '';
 	    }
 

Braces +8 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,8 +63,7 @@ 
 				if(!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
+				} else
 				{
 					$additionalFormFields[$key] = '';
 				}
@@ -72,8 +73,7 @@ 
 		if(!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
-		}
-		else
+		} else
 		{
 			$defines['child_module_name'] = $defines['module'];
 		}
@@ -109,8 +109,7 @@ 
 		{
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
@@ -119,8 +118,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
@@ -129,8 +127,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_id'] = $defines['focus']->id;
 			}
 		}