Passed
Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )
by Adam
56:05 queued 14:08
created
service/core/SugarWebServiceImpl.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
  *
74 74
  * @param String $session -- Session ID returned by a previous call to login.
75 75
  * @param String $module_name -- The name of the module to return records from.  This name should be the name the module was developed under (changing a tab name is studio does not affect the name that should be passed into this method)..
76
- * @param Array $ids -- An array of SugarBean IDs.
76
+ * @param string[] $ids -- An array of SugarBean IDs.
77 77
  * @param Array $select_fields -- A list of the fields to be included in the results. This optional parameter allows for only needed fields to be retrieved.
78 78
 * @param Array $link_name_to_fields_array -- A list of link_names and for each link_name, what fields value to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address')))
79 79
 * @return Array
Please login to merge, or discard this patch.
service/v3/SugarWebServiceImplv3.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -309,7 +309,7 @@
 block discarded – undo
309 309
      * Retrieve a list of recently viewed records by module.
310 310
      *
311 311
      * @param String $session -- Session ID returned by a previous call to login.
312
-     * @param String $modules -- An array of modules or 'Home' to indicate all.
312
+     * @param String $module_names -- An array of modules or 'Home' to indicate all.
313 313
      * @return Array The recently viewed records
314 314
      * @exception 'SoapFault' -- The SOAP error, if any
315 315
      */
Please login to merge, or discard this patch.
service/v3_1/SugarWebServiceImplv3_1.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     * @param String $id -- The SugarBean's ID value.
62 62
     * @param Array  $select_fields -- A list of the fields to be included in the results. This optional parameter allows for only needed fields to be retrieved.
63 63
     * @param Array $link_name_to_fields_array -- A list of link_names and for each link_name, what fields value to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address')))
64
-    * @param bool $trackView -- Should we track the record accessed.
64
+    * @param bool $track_view -- Should we track the record accessed.
65 65
     * @return Array
66 66
     *        'entry_list' -- Array - The records name value pair for the simple data types excluding link field data.
67 67
     *	     'relationship_list' -- Array - The records link field data. The example is if asked about accounts email address then return data would look like Array ( [0] => Array ( [name] => email_addresses [records] => Array ( [0] => Array ( [0] => Array ( [name] => id [value] => 3fb16797-8d90-0a94-ac12-490b63a6be67 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 1 ) ) [1] => Array ( [0] => Array ( [name] => id [value] => 403f8da1-214b-6a88-9cef-490b63d43566 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 0 ) ) ) ) )
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     * @param Array $ids -- An array of SugarBean IDs.
126 126
     * @param Array $select_fields -- A list of the fields to be included in the results. This optional parameter allows for only needed fields to be retrieved.
127 127
     * @param Array $link_name_to_fields_array -- A list of link_names and for each link_name, what fields value to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address')))
128
-    * @param bool $trackView -- Should we track the record accessed.
128
+    * @param bool $track_view -- Should we track the record accessed.
129 129
     * @return Array
130 130
     *        'entry_list' -- Array - The records name value pair for the simple data types excluding link field data.
131 131
     *	     'relationship_list' -- Array - The records link field data. The example is if asked about accounts email address then return data would look like Array ( [0] => Array ( [name] => email_addresses [records] => Array ( [0] => Array ( [0] => Array ( [name] => id [value] => 3fb16797-8d90-0a94-ac12-490b63a6be67 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 1 ) ) [1] => Array ( [0] => Array ( [name] => id [value] => 403f8da1-214b-6a88-9cef-490b63d43566 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 0 ) ) ) ) )
Please login to merge, or discard this patch.
service/v4/SugarWebServiceUtilv4.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	/**
144 144
 	 * Processes the filter_fields attribute to use with SugarBean::create_new_list_query()
145 145
 	 *
146
-	 * @param object $value SugarBean
146
+	 * @param SugarBean $value SugarBean
147 147
 	 * @param array $fields
148 148
 	 * @return array
149 149
 	 */
@@ -454,6 +454,12 @@  discard block
 block discarded – undo
454 454
 	}
455 455
 
456 456
 
457
+    /**
458
+     * @param string $login_error_key
459
+     * @param string $access_level
460
+     * @param string $module_access_level_error_key
461
+     * @param SoapError $errorObject
462
+     */
457 463
     function checkSessionAndModuleAccess($session, $login_error_key, $module_name, $access_level, $module_access_level_error_key, $errorObject)
458 464
     {
459 465
           if(isset($_REQUEST['oauth_token'])) {
Please login to merge, or discard this patch.
service/v4_1/SugarWebServiceImplv4_1.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
      * @param Array $related_module_link_name_to_fields_array - For every related bean returrned, specify link fields name to fields info for that bean to be returned. For ex.'link_name_to_fields_array' => array(array('name' =>  'email_addresses', 'value' => array('id', 'email_address', 'opt_out', 'primary_address'))).
76 76
      * @param Number $deleted -- false if deleted records should not be include, true if deleted records should be included.
77 77
      * @param String $order_by -- field to order the result sets by
78
-     * @param Number $offset -- where to start in the return
78
+     * @param integer $offset -- where to start in the return
79 79
      * @param Number $limit -- number of results to return (defaults to all)
80 80
      * @return Array 'entry_list' -- Array - The records that were retrieved
81 81
      *               'relationship_list' -- Array - The records link field data. The example is if asked about accounts contacts email address then return data would look like Array ( [0] => Array ( [name] => email_addresses [records] => Array ( [0] => Array ( [0] => Array ( [name] => id [value] => 3fb16797-8d90-0a94-ac12-490b63a6be67 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 1 ) ) [1] => Array ( [0] => Array ( [name] => id [value] => 403f8da1-214b-6a88-9cef-490b63d43566 ) [1] => Array ( [name] => email_address [value] => [email protected] ) [2] => Array ( [name] => opt_out [value] => 0 ) [3] => Array ( [name] => primary_address [value] => 0 ) ) ) ) )
Please login to merge, or discard this patch.
service/v4_1/SugarWebServiceUtilv4_1.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
    	 * Validate the provided session information is correct and current.  Load the session.
46 46
    	 *
47 47
    	 * @param String $session_id -- The session ID that was returned by a call to login.
48
-   	 * @return true -- If the session is valid and loaded.
49
-   	 * @return false -- if the session is not valid.
48
+   	 * @return boolean -- If the session is valid and loaded.
49
+   	 * @return boolean -- if the session is not valid.
50 50
    	 */
51 51
    	function validate_authenticated($session_id)
52 52
     {
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
      * getRelationshipResults
104 104
      * Returns the
105 105
      *
106
-     * @param Mixed $bean The SugarBean instance to retrieve relationships from
106
+     * @param SugarBean $bean The SugarBean instance to retrieve relationships from
107 107
      * @param String $link_field_name The name of the relationship entry to fetch relationships for
108 108
      * @param Array $link_module_fields Array of fields of relationship entries to return
109 109
      * @param string $optional_where String containing an optional WHERE select clause
110 110
      * @param string $order_by String containing field to order results by
111
-     * @param Number $offset -- where to start in the return (defaults to 0)
111
+     * @param integer $offset -- where to start in the return (defaults to 0)
112 112
      * @param Number $limit -- number of results to return (defaults to all)
113 113
      * @return array|bool Returns an Array of relationship results; false if relationship could not be retrieved
114 114
      */
Please login to merge, or discard this patch.
soap/SoapDeprecated.php 1 patch
Doc Comments   +3 added lines, -8 removed lines patch added patch discarded remove patch
@@ -208,8 +208,8 @@  discard block
 block discarded – undo
208 208
  *
209 209
  * @param string $user_name -- The user name to create a session for
210 210
  * @param string $password -- The MD5 sum of the user's password
211
- * @return true -- If the session is created
212
- * @return false -- If the session is not created
211
+ * @return boolean|null -- If the session is created
212
+ * @return boolean|null -- If the session is not created
213 213
  */
214 214
 function validate_user($user_name, $password){
215 215
 	global $server, $current_user, $sugar_config, $system_config;
@@ -479,7 +479,6 @@  discard block
 block discarded – undo
479 479
 /**
480 480
  * Internal: convert a bean into an array
481 481
  *
482
- * @param Bean $bean -- The bean to convert
483 482
  * @param int $msi_id -- Russult array index
484 483
  * @return An associated array containing the detail fields.
485 484
  */
@@ -573,7 +572,6 @@  discard block
 block discarded – undo
573 572
 /**
574 573
  * Internal: convert a bean into an array
575 574
  *
576
- * @param Bean $bean -- The bean to convert
577 575
  * @param int $msi_id -- Russult array index
578 576
  * @return An associated array containing the detail fields.
579 577
  */
@@ -612,7 +610,6 @@  discard block
 block discarded – undo
612 610
 /**
613 611
  * Internal: convert a bean into an array
614 612
  *
615
- * @param Bean $bean -- The bean to convert
616 613
  * @param int $msi_id -- Russult array index
617 614
  * @return An associated array containing the detail fields.
618 615
  */
@@ -651,7 +648,6 @@  discard block
 block discarded – undo
651 648
 /**
652 649
  * Internal: convert a bean into an array
653 650
  *
654
- * @param Bean $bean -- The bean to convert
655 651
  * @param int $msi_id -- Russult array index
656 652
  * @return An associated array containing the detail fields.
657 653
  */
@@ -691,8 +687,8 @@  discard block
 block discarded – undo
691 687
 /**
692 688
  * Internal: convert a bean into an array
693 689
  *
694
- * @param Bean $bean -- The bean to convert
695 690
  * @param int $msi_id -- Russult array index
691
+ * @param string $type
696 692
  * @return An associated array containing the detail fields.
697 693
  */
698 694
 function get_bean_array($value, $msi_id, $type){
@@ -708,7 +704,6 @@  discard block
 block discarded – undo
708 704
 /**
709 705
  * Internal: convert a bean into an array
710 706
  *
711
- * @param Bean $bean -- The bean to convert
712 707
  * @param int $msi_id -- Russult array index
713 708
  * @return An associated array containing the detail fields.
714 709
  */
Please login to merge, or discard this patch.
soap/SoapError.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@
 block discarded – undo
48 48
 		$this->set_error('no_error');
49 49
 	}
50 50
 
51
+	/**
52
+	 * @param string $error_name
53
+	 */
51 54
 	function set_error($error_name){
52 55
 		global $error_defs;
53 56
 		if(!isset($error_defs[$error_name])){
Please login to merge, or discard this patch.
soap/SoapHelperFunctions.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
  * @param String $module_id -- The ID of the bean in the specified module
612 612
  * @param String $link_field_name - The relationship name for which to create realtionships.
613 613
  * @param Array $related_ids -- The array of ids for which we want to create relationships
614
- * @return true on success, false on failure
614
+ * @return boolean on success, false on failure
615 615
  */
616 616
 function new_handle_set_relationship($module_name, $module_id, $link_field_name, $related_ids) {
617 617
     global  $beanList, $beanFiles;
@@ -1037,6 +1037,9 @@  discard block
 block discarded – undo
1037 1037
         return false;
1038 1038
 }
1039 1039
 
1040
+/**
1041
+ * @param string $file_in_zip
1042
+ */
1040 1043
 function getFile( $zip_file, $file_in_zip ){
1041 1044
     $base_upgrade_dir = sugar_cached("/upgrades");
1042 1045
     $base_tmp_upgrade_dir   = "$base_upgrade_dir/temp";
Please login to merge, or discard this patch.