Passed
Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )
by Adam
56:05 queued 14:08
created
modules/Users/authentication/SAMLAuthenticate/SAMLAuthenticateUser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -338,7 +338,7 @@
 block discarded – undo
338 338
     /**
339 339
      * Fetches user by provided ID and field name
340 340
      *
341
-     * @param mixed $id
341
+     * @param string $id
342 342
      * @param string $field
343 343
      * @return User
344 344
      */
Please login to merge, or discard this patch.
modules/Users/password_utils.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -79,6 +79,9 @@
 block discarded – undo
79 79
 		return $mod_strings['LBL_EMAIL_NOT_SENT'];
80 80
 }
81 81
 
82
+/**
83
+ * @param string $username
84
+ */
82 85
 function  hasPasswordExpired($username){
83 86
     $current_user= new user();
84 87
     $usr_id=$current_user->retrieve_user_id($username);
Please login to merge, or discard this patch.
modules/Users/UserViewHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -760,7 +760,7 @@
 block discarded – undo
760 760
      * setUserType
761 761
      * This function is used to set the user_type variable for a given User instance
762 762
      *
763
-     * @param Mixed $user The user instance to set the user_type variable on
763
+     * @param SugarBean $user The user instance to set the user_type variable on
764 764
      * @return String value representing the user type
765 765
      */
766 766
     function setUserType($user)
Please login to merge, or discard this patch.
modules/Users/views/view.wizard.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
      * in the array.
268 268
      *
269 269
      * @param array $currenciesArray Array of currencies to sort
270
-     * @return array|string Array of sorted currencies with the US Dollar as the first
270
+     * @return string Array of sorted currencies with the US Dollar as the first
271 271
      */
272 272
     public function correctCurrenciesSymbolsSort($currenciesArray)
273 273
     {
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
      *
290 290
      * @see correctCurrenciesSymbolsSort
291 291
      * @param $array
292
-     * @return array|string Javascript code snippet of currencies array
292
+     * @return string Javascript code snippet of currencies array
293 293
      */
294 294
     public function pushCurrencyArrayToString($array)
295 295
     {
Please login to merge, or discard this patch.
modules/vCals/HTTP_WebDAV_Server_vCal.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
          * PUT method handler
393 393
          *
394 394
          * @param  array  parameter passing array
395
-         * @return bool   true on success
395
+         * @return boolean|null   true on success
396 396
          */
397 397
         function PUT(&$options)
398 398
         {
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
          * UNLOCK method handler
417 417
          *
418 418
          * @param  array  general parameter passing array
419
-         * @return bool   true on success
419
+         * @return string   true on success
420 420
          */
421 421
         function unlock(&$options)
422 422
         {
Please login to merge, or discard this patch.
modules/vCals/vCal.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      * escape iCal chars as per RFC 5545: http://tools.ietf.org/html/rfc5545#section-3.3.11
315 315
      *
316 316
      * @param string $string string to escape chars
317
-     * @return escaped string
317
+     * @return string string
318 318
      */
319 319
     public static function escape_ical_chars($string)
320 320
     {
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
      * unescape iCal chars as per RFC 5545: http://tools.ietf.org/html/rfc5545#section-3.3.11
327 327
      *
328 328
      * @param string $string string to escape chars
329
-     * @return unescaped string
329
+     * @return string string
330 330
      */
331 331
     public static function unescape_ical_chars($string)
332 332
     {
Please login to merge, or discard this patch.
service/core/PHP5Soap.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -106,6 +106,9 @@
 block discarded – undo
106 106
 		} // if
107 107
 	} // fn
108 108
 
109
+	/**
110
+	 * @param boolean $generateWSDL
111
+	 */
109 112
 	public function getWSDLPath($generateWSDL) {
110 113
 		$wsdlURL = $this->getSoapURL().'?wsdl';
111 114
 		$wsdlCacheFile = 'upload://wsdlcache-' . md5($wsdlURL);
Please login to merge, or discard this patch.
service/core/REST/SugarRestRSS.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -64,6 +64,9 @@
 block discarded – undo
64 64
 		$this->generateResponseFooter();
65 65
 	} // fn
66 66
 
67
+	/**
68
+	 * @param integer $count
69
+	 */
67 70
 	protected function generateResponseHeader($count)
68 71
 	{
69 72
 	    global $app_strings, $sugar_version, $sugar_flavor;
Please login to merge, or discard this patch.
service/core/SoapHelperWebService.php 1 patch
Doc Comments   +19 added lines, -5 removed lines patch added patch discarded remove patch
@@ -154,8 +154,8 @@  discard block
 block discarded – undo
154 154
  *
155 155
  * @param string $user_name -- The user name to create a session for
156 156
  * @param string $password -- The MD5 sum of the user's password
157
- * @return true -- If the session is created
158
- * @return false -- If the session is not created
157
+ * @return boolean|null -- If the session is created
158
+ * @return boolean|null -- If the session is not created
159 159
  */
160 160
 function validate_user($user_name, $password){
161 161
 	$GLOBALS['log']->info('Begin: SoapHelperWebServices->validate_user');
@@ -193,8 +193,8 @@  discard block
 block discarded – undo
193 193
 	 * Validate the provided session information is correct and current.  Load the session.
194 194
 	 *
195 195
 	 * @param String $session_id -- The session ID that was returned by a call to login.
196
-	 * @return true -- If the session is valid and loaded.
197
-	 * @return false -- if the session is not valid.
196
+	 * @return boolean -- If the session is valid and loaded.
197
+	 * @return boolean -- if the session is not valid.
198 198
 	 */
199 199
 	function validate_authenticated($session_id){
200 200
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->validate_authenticated');
@@ -303,6 +303,11 @@  discard block
 block discarded – undo
303 303
 		return true;
304 304
 	} // fn
305 305
 
306
+	/**
307
+	 * @param string $viewType
308
+	 * @param SoapError $errorObject
309
+	 * @param string $error_key
310
+	 */
306 311
 	function checkACLAccess($bean, $viewType, $errorObject, $error_key) {
307 312
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->checkACLAccess');
308 313
 		if(!$bean->ACLAccess($viewType)) {
@@ -316,6 +321,9 @@  discard block
 block discarded – undo
316 321
 		return true;
317 322
 	} // fn
318 323
 
324
+	/**
325
+	 * @param SoapError $errorObject
326
+	 */
319 327
 	function checkQuery($errorObject, $query, $order_by = '')
320 328
     {
321 329
         require_once 'include/SugarSQLValidate.php';
@@ -695,7 +703,7 @@  discard block
 block discarded – undo
695 703
 	 * @param Array $related_ids -- The array of ids for which we want to create relationships
696 704
 	 * @param Array $name_value_list -- The array of name value pair of additional attributes to be set when adding this relationship
697 705
 	 * @param int delete -- If 0 then add relationship else delete this relationship data
698
-	 * @return true on success, false on failure
706
+	 * @return boolean on success, false on failure
699 707
 	 */
700 708
 	function new_handle_set_relationship($module_name, $module_id, $link_field_name, $related_ids, $name_value_list, $delete) {
701 709
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->new_handle_set_relationship');
@@ -743,6 +751,9 @@  discard block
 block discarded – undo
743 751
 		}
744 752
 	}
745 753
 
754
+	/**
755
+	 * @param string $module_name
756
+	 */
746 757
 	function new_handle_set_entries($module_name, $name_value_lists, $select_fields = FALSE) {
747 758
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->new_handle_set_entries');
748 759
 		global $beanList, $beanFiles, $current_user, $app_list_strings;
@@ -907,6 +918,9 @@  discard block
 block discarded – undo
907 918
 	}
908 919
 
909 920
 
921
+	/**
922
+	 * @param string $module
923
+	 */
910 924
 	function get_return_module_fields($value, $module,$fields, $translate=true){
911 925
 		$GLOBALS['log']->info('Begin: SoapHelperWebServices->get_return_module_fields');
912 926
 		global $module_name;
Please login to merge, or discard this patch.