adamjakab / SuiteCRM

modules/Employees/Employee.php

Spacing +23 added lines, -23 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -115,9 +115,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function Employee(){
+    function Employee() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -142,11 +142,11 @@ 
 	{
 		global $locale;
 		$query = "SELECT u1.first_name, u1.last_name from users u1, users u2 where u1.id = u2.reports_to_id AND u2.id = '$this->id' and u1.deleted=0";
-		$result =$this->db->query($query, true, "Error filling in additional detail fields") ;
+		$result = $this->db->query($query, true, "Error filling in additional detail fields");
 
 		$row = $this->db->fetchByAssoc($result);
 
-		if($row != null)
+		if ($row != null)
 		{
 			$this->reports_to_name = stripslashes($locale->getLocaleFormattedName($row['first_name'], $row['last_name']));
 		}
@@ -159,7 +159,7 @@ 
 	function retrieve_employee_id($employee_name)
 	{
 		$query = "SELECT id from users where user_name='$user_name' AND deleted=0";
-		$result  = $this->db->query($query, false,"Error retrieving employee ID: ");
+		$result = $this->db->query($query, false, "Error retrieving employee ID: ");
 		$row = $this->db->fetchByAssoc($result);
 		return $row['id'];
 	}
@@ -177,21 +177,21 @@ 
 		return TRUE;
 	}
 
-	function get_list_view_data(){
+	function get_list_view_data() {
 
         $user_fields = parent::get_list_view_data();
 
 		// Copy over the reports_to_name
-		if ( isset($GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type]) )
+		if (isset($GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type]))
             $user_fields['MESSENGER_TYPE'] = $GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type];
-		if ( isset($GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status]) )
+		if (isset($GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status]))
             $user_fields['EMPLOYEE_STATUS'] = $GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status];
 		$user_fields['REPORTS_TO_NAME'] = $this->reports_to_name;
 
         return $user_fields;
 	}
 
-	function list_view_parse_additional_sections(&$list_form/*, $xTemplateSection*/){
+	function list_view_parse_additional_sections(&$list_form/*, $xTemplateSection*/) {
 		return $list_form;
 	}
 
@@ -200,7 +200,7 @@ 
 		include('modules/Employees/field_arrays.php');
 
 		$cols = '';
-		foreach($fields_array['Employee']['export_fields'] as $field) {
+		foreach ($fields_array['Employee']['export_fields'] as $field) {
 			$cols .= (empty($cols)) ? '' : ', ';
 			$cols .= $field;
 		}
@@ -209,12 +209,12 @@ 
 
 		$where_auto = " users.deleted = 0";
 
-		if($where != "")
-			$query .= " WHERE $where AND " . $where_auto;
+		if ($where != "")
+			$query .= " WHERE $where AND ".$where_auto;
 		else
-			$query .= " WHERE " . $where_auto;
+			$query .= " WHERE ".$where_auto;
 
-		if($order_by != "")
+		if ($order_by != "")
 			$query .= " ORDER BY $order_by";
 		else
 			$query .= " ORDER BY users.user_name";
@@ -235,7 +235,7 @@ 
 	}
 	*/
 
-	function preprocess_fields_on_save(){
+	function preprocess_fields_on_save() {
 		parent::preprocess_fields_on_save();
 
 	}
@@ -259,17 +259,17 @@ 
      * @param boolean $singleSelect Optional, default false.
      * @return String select query string, optionally an array value will be returned if $return_array= true.
      */
-	function create_new_list_query($order_by, $where,$filter=array(),$params=array(), $show_deleted = 0,$join_type='', $return_array = false,$parentbean=null, $singleSelect = false, $ifListForExport = false)
+	function create_new_list_query($order_by, $where, $filter = array(), $params = array(), $show_deleted = 0, $join_type = '', $return_array = false, $parentbean = null, $singleSelect = false, $ifListForExport = false)
     {
         //create the filter for portal only users, as they should not be showing up in query results
-        if(empty($where)){
+        if (empty($where)) {
             $where = ' users.portal_only = 0 ';
-        }else{
+        } else {
             $where .= ' and users.portal_only = 0 ';
         }
 
         //return parent method, specifying for array to be returned
-        return parent::create_new_list_query($order_by, $where, $filter,$params, $show_deleted, $join_type, $return_array, $parentbean, $singleSelect, $ifListForExport);
+        return parent::create_new_list_query($order_by, $where, $filter, $params, $show_deleted, $join_type, $return_array, $parentbean, $singleSelect, $ifListForExport);
     }
 
     /*
@@ -280,10 +280,10 @@ 
 
         //Check to see if there are custom user fields that we should report on, first check the custom_fields array
         $userCustomfields = !empty($GLOBALS['dictionary']['Employee']['custom_fields']);
-        if(!$userCustomfields){
+        if (!$userCustomfields) {
             //custom Fields not set, so traverse employee fields to see if any custom fields exist
-            foreach ($GLOBALS['dictionary']['Employee']['fields'] as $k=>$v){
-                if(!empty($v['source']) && $v['source'] == 'custom_fields'){
+            foreach ($GLOBALS['dictionary']['Employee']['fields'] as $k=>$v) {
+                if (!empty($v['source']) && $v['source'] == 'custom_fields') {
                     //custom field has been found, set flag to true and break
                     $userCustomfields = true;
                     break;

Braces +22 added lines, -18 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -119,8 +121,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -149,8 +150,7 @@ 
 		if($row != null)
 		{
 			$this->reports_to_name = stripslashes($locale->getLocaleFormattedName($row['first_name'], $row['last_name']));
-		}
-		else
+		} else
 		{
 			$this->reports_to_name = '';
 		}
@@ -182,10 +182,12 @@ 
         $user_fields = parent::get_list_view_data();
 
 		// Copy over the reports_to_name
-		if ( isset($GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type]) )
-            $user_fields['MESSENGER_TYPE'] = $GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type];
-		if ( isset($GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status]) )
-            $user_fields['EMPLOYEE_STATUS'] = $GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status];
+		if ( isset($GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type]) ) {
+		            $user_fields['MESSENGER_TYPE'] = $GLOBALS['app_list_strings']['messenger_type_dom'][$this->messenger_type];
+		}
+		if ( isset($GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status]) ) {
+		            $user_fields['EMPLOYEE_STATUS'] = $GLOBALS['app_list_strings']['employee_status_dom'][$this->employee_status];
+		}
 		$user_fields['REPORTS_TO_NAME'] = $this->reports_to_name;
 
         return $user_fields;
@@ -209,15 +211,17 @@ 
 
 		$where_auto = " users.deleted = 0";
 
-		if($where != "")
-			$query .= " WHERE $where AND " . $where_auto;
-		else
-			$query .= " WHERE " . $where_auto;
+		if($where != "") {
+					$query .= " WHERE $where AND " . $where_auto;
+		} else {
+					$query .= " WHERE " . $where_auto;
+		}
 
-		if($order_by != "")
-			$query .= " ORDER BY $order_by";
-		else
-			$query .= " ORDER BY users.user_name";
+		if($order_by != "") {
+					$query .= " ORDER BY $order_by";
+		} else {
+					$query .= " ORDER BY users.user_name";
+		}
 
 		return $query;
 	}
@@ -264,7 +268,7 @@ 
         //create the filter for portal only users, as they should not be showing up in query results
         if(empty($where)){
             $where = ' users.portal_only = 0 ';
-        }else{
+        } else{
             $where .= ' and users.portal_only = 0 ';
         }
 

modules/jjwg_Areas/views/view.area_detail_map.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 class Jjwg_AreasViewArea_Detail_Map extends SugarView {
 
@@ -11,9 +11,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function Jjwg_AreasViewArea_Detail_Map(){
+    public function Jjwg_AreasViewArea_Detail_Map() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/jjwg_Areas/views/view.area_edit_map.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 
 class Jjwg_AreasViewArea_Edit_Map extends SugarView {
 
@@ -11,9 +11,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function Jjwg_AreasViewArea_Edit_Map(){
+    function Jjwg_AreasViewArea_Edit_Map() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/jjwg_Areas/jjwg_Areas.php

Spacing +12 added lines, -12 removed lines

@@ -37,19 +37,19 @@ 
      */
     var $centroid = null;
 
-    function __construct($init=true) {
+    function __construct($init = true) {
 
         parent::__construct();
         // Admin Config Setting
-        if($init) $this->configuration();
+        if ($init) $this->configuration();
     }
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function jjwg_Areas($init=true){
+    function jjwg_Areas($init = true) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -154,11 +154,11 @@ 
         $p[] = $p[0];
 
         for ($i = 0; $i < $n; $i++) {
-            $cx += ($p[$i]['lng'] + $p[$i+1]['lng']) * ( ($p[$i]['lng'] * $p[$i+1]['lat']) - ($p[$i+1]['lng'] * $p[$i]['lat']) );
-            $cy += ($p[$i]['lat'] + $p[$i+1]['lat']) * ( ($p[$i]['lng'] * $p[$i+1]['lat']) - ($p[$i+1]['lng'] * $p[$i]['lat']) );
+            $cx += ($p[$i]['lng'] + $p[$i + 1]['lng']) * (($p[$i]['lng'] * $p[$i + 1]['lat']) - ($p[$i + 1]['lng'] * $p[$i]['lat']));
+            $cy += ($p[$i]['lat'] + $p[$i + 1]['lat']) * (($p[$i]['lng'] * $p[$i + 1]['lat']) - ($p[$i + 1]['lng'] * $p[$i]['lat']));
         }
-        $centroid_lng = -(1/(6*$a))*$cx;
-        $centroid_lat = -(1/(6*$a))*$cy;
+        $centroid_lng = -(1 / (6 * $a)) * $cx;
+        $centroid_lat = -(1 / (6 * $a)) * $cy;
 
         if ($centroid_lng != 0 && $centroid_lat != 0) {
             $this->centroid = array(
@@ -301,7 +301,7 @@ 
         // Chek $polygon count
         if (!(count($polygon) > 1)) return false;
         // Add the first point to the end, in order to properly close the loop completely
-        if ($polygon[count($polygon)-1] != $polygon[0]) $polygon[] = $polygon[0];
+        if ($polygon[count($polygon) - 1] != $polygon[0]) $polygon[] = $polygon[0];
 
         // Transform string coordinates into arrays with x and y values
         $point = $this->point_string_to_coordinates($point);
@@ -319,8 +319,8 @@ 
         $intersections = 0;
         $vertices_count = count($vertices);
 
-        for ($i=1; $i < $vertices_count; $i++) {
-            $vertex1 = $vertices[$i-1];
+        for ($i = 1; $i < $vertices_count; $i++) {
+            $vertex1 = $vertices[$i - 1];
             $vertex2 = $vertices[$i];
             if ($vertex1['y'] == $vertex2['y'] and $vertex1['y'] == $point['y'] and $point['x'] > min($vertex1['x'], $vertex2['x']) and $point['x'] < max($vertex1['x'], $vertex2['x'])) { // Check if point is on an horizontal polygon boundary
                 return true;
@@ -345,7 +345,7 @@ 
 
     function point_on_vertex($point, $vertices) {
 
-        foreach($vertices as $vertex) {
+        foreach ($vertices as $vertex) {
             if ($point == $vertex) {
                 return true;
             }

Braces +30 added lines, -12 removed lines

@@ -1,7 +1,8 @@ 
 <?php
 
-if (!defined('sugarEntry') || !sugarEntry)
+if (!defined('sugarEntry') || !sugarEntry) {
     die('Not A Valid Entry Point');
+}
 
 require_once('modules/jjwg_Areas/jjwg_Areas_sugar.php');
 require_once('modules/jjwg_Maps/jjwg_Maps.php');
@@ -41,7 +42,9 @@ 
 
         parent::__construct();
         // Admin Config Setting
-        if($init) $this->configuration();
+        if($init) {
+            $this->configuration();
+        }
     }
 
     /**
@@ -51,8 +54,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($init);
@@ -91,7 +93,9 @@ 
      */
     function define_polygon() {
 
-        if (!empty($this->polygon)) return $this->polygon;
+        if (!empty($this->polygon)) {
+            return $this->polygon;
+        }
 
         if (preg_match('/[\n\r]/', $this->coordinates)) {
             $this->coords = preg_split("/[\n\r\s]+/", $this->coordinates, null, PREG_SPLIT_NO_EMPTY);
@@ -140,13 +144,19 @@ 
      */
     function define_centroid() {
 
-        if (!empty($this->centroid)) return $this->centroid;
+        if (!empty($this->centroid)) {
+            return $this->centroid;
+        }
 
-        if (empty($this->polygon)) $this->polygon = $this->define_polygon();
+        if (empty($this->polygon)) {
+            $this->polygon = $this->define_polygon();
+        }
 
         $n = count($this->polygon);
         $a = $this->define_area($this->polygon);
-        if (empty($a)) return $this->centroid;
+        if (empty($a)) {
+            return $this->centroid;
+        }
         $cx = 0.0;
         $cy = 0.0;
         // Set $p as Polygon and Add Closing Point
@@ -177,9 +187,13 @@ 
      */
     function define_area() {
 
-        if (!empty($this->area)) return $this->area;
+        if (!empty($this->area)) {
+            return $this->area;
+        }
 
-        if (empty($this->polygon)) $this->polygon = $this->define_polygon();
+        if (empty($this->polygon)) {
+            $this->polygon = $this->define_polygon();
+        }
 
         // Based on: http://forums.devnetwork.net/viewtopic.php?f=1&t=44074
         $n = count($this->polygon);
@@ -299,9 +313,13 @@ 
         $polygon = preg_split('/[\s]+/', $this->coordinates);
 
         // Chek $polygon count
-        if (!(count($polygon) > 1)) return false;
+        if (!(count($polygon) > 1)) {
+            return false;
+        }
         // Add the first point to the end, in order to properly close the loop completely
-        if ($polygon[count($polygon)-1] != $polygon[0]) $polygon[] = $polygon[0];
+        if ($polygon[count($polygon)-1] != $polygon[0]) {
+            $polygon[] = $polygon[0];
+        }
 
         // Transform string coordinates into arrays with x and y values
         $point = $this->point_string_to_coordinates($point);

modules/jjwg_Areas/Dashlets/jjwg_AreasDashlet/jjwg_AreasDashlet.php

Spacing +2 added lines, -2 removed lines

@@ -26,9 +26,9 @@
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function jjwg_AreasDashlet($id, $def = null){
+    function jjwg_AreasDashlet($id, $def = null) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +6 added lines, -5 removed lines

@@ -1,7 +1,8 @@ 
 <?php
 
-if (!defined('sugarEntry') || !sugarEntry)
+if (!defined('sugarEntry') || !sugarEntry) {
     die('Not A Valid Entry Point');
+}
 
 require_once('include/Dashlets/DashletGeneric.php');
 require_once('modules/jjwg_Areas/jjwg_Areas.php');
@@ -14,8 +15,9 @@ 
 
         parent::__construct($id, $def);
 
-        if (empty($def['title']))
-            $this->title = translate('LBL_HOMEPAGE_TITLE', 'jjwg_Areas');
+        if (empty($def['title'])) {
+                    $this->title = translate('LBL_HOMEPAGE_TITLE', 'jjwg_Areas');
+        }
 
         $this->searchFields = $dashletData['jjwg_AreasDashlet']['searchFields'];
         $this->columns = $dashletData['jjwg_AreasDashlet']['columns'];
@@ -30,8 +32,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);

modules/Releases/Release.php

Indentation +91 added lines, -91 removed lines

@@ -50,30 +50,30 @@ 
 
 
 class Release extends SugarBean {
-	// Stored fields
-	var $id;
-	var $deleted;
-	var $date_entered;
-	var $date_modified;
-	var $modified_user_id;
-	var $created_by;
-	var $created_by_name;
-	var $modified_by_name;
-	var $name;
-	var $status;
-
-	var $table_name = "releases";
-
-	var $object_name = "Release";
-	var $module_dir = 'Releases';
-	var $new_schema = true;
-
-	// This is used to retrieve related fields from form posts.
-	var $additional_column_fields = Array();
+    // Stored fields
+    var $id;
+    var $deleted;
+    var $date_entered;
+    var $date_modified;
+    var $modified_user_id;
+    var $created_by;
+    var $created_by_name;
+    var $modified_by_name;
+    var $name;
+    var $status;
+
+    var $table_name = "releases";
+
+    var $object_name = "Release";
+    var $module_dir = 'Releases';
+    var $new_schema = true;
+
+    // This is used to retrieve related fields from form posts.
+    var $additional_column_fields = Array();
 
     public function __construct() {
-		parent::__construct();
-	}
+        parent::__construct();
+    }
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
@@ -90,83 +90,83 @@ 
     }
 
 
-	function get_summary_text()
-	{
-		return "$this->name";
-	}
-
-	function get_releases($add_blank=false,$status='Active',$where='')
-	{
-		if($where!='') {
-			$query = "SELECT id, name FROM $this->table_name where ". $where ." and deleted=0 ";
-		}
-		else {
-			$query = "SELECT id, name FROM $this->table_name where deleted=0 ";
-		}
-		if ($status=='Active') {
-			$query .= " and status='Active' ";
-		}
-		elseif ($status=='Hidden') {
-			$query .= " and status='Hidden' ";
-		}
-		elseif ($status=='All') {
-		}
-		$query .= " order by list_order asc";
-		$result = $this->db->query($query, false);
-		$GLOBALS['log']->debug("get_releases: result is ".var_export($result, true));
-
-		$list = array();
-		if ($add_blank) {
-			$list['']='';
-		}
-		//if($this->db->getRowCount($result) > 0){
-			// We have some data.
-			while (($row = $this->db->fetchByAssoc($result)) != null) {
-			//while ($row = $this->db->fetchByAssoc($result)) {
-				$list[$row['id']] = $row['name'];
-				$GLOBALS['log']->debug("row id is:".$row['id']);
-				$GLOBALS['log']->debug("row name is:".$row['name']);
-			}
-		//}
-		return $list;
-	}
-
-	function fill_in_additional_list_fields()
-	{
-		$this->fill_in_additional_detail_fields();
-	}
-
-	function fill_in_additional_detail_fields() {
-
-	}
-
-	function get_list_view_data(){
-		global $app_list_strings;
-		$temp_array = $this->get_list_view_array();
+    function get_summary_text()
+    {
+        return "$this->name";
+    }
+
+    function get_releases($add_blank=false,$status='Active',$where='')
+    {
+        if($where!='') {
+            $query = "SELECT id, name FROM $this->table_name where ". $where ." and deleted=0 ";
+        }
+        else {
+            $query = "SELECT id, name FROM $this->table_name where deleted=0 ";
+        }
+        if ($status=='Active') {
+            $query .= " and status='Active' ";
+        }
+        elseif ($status=='Hidden') {
+            $query .= " and status='Hidden' ";
+        }
+        elseif ($status=='All') {
+        }
+        $query .= " order by list_order asc";
+        $result = $this->db->query($query, false);
+        $GLOBALS['log']->debug("get_releases: result is ".var_export($result, true));
+
+        $list = array();
+        if ($add_blank) {
+            $list['']='';
+        }
+        //if($this->db->getRowCount($result) > 0){
+            // We have some data.
+            while (($row = $this->db->fetchByAssoc($result)) != null) {
+            //while ($row = $this->db->fetchByAssoc($result)) {
+                $list[$row['id']] = $row['name'];
+                $GLOBALS['log']->debug("row id is:".$row['id']);
+                $GLOBALS['log']->debug("row name is:".$row['name']);
+            }
+        //}
+        return $list;
+    }
+
+    function fill_in_additional_list_fields()
+    {
+        $this->fill_in_additional_detail_fields();
+    }
+
+    function fill_in_additional_detail_fields() {
+
+    }
+
+    function get_list_view_data(){
+        global $app_list_strings;
+        $temp_array = $this->get_list_view_array();
         $temp_array["ENCODED_NAME"]=$this->name;
         $temp_array['ENCODED_STATUS'] = $app_list_strings['release_status_dom'][$this->status];
 //	$temp_array["ENCODED_NAME"]=htmlspecialchars($this->name, ENT_QUOTES);
-    	return $temp_array;
+        return $temp_array;
 
-	}
-	/**
+    }
+    /**
 		builds a generic search based on the query string using or
 		do not include any $this-> because this is called on without having the class instantiated
-	*/
-	function build_generic_where_clause ($the_query_string) {
-	$where_clauses = Array();
-	$the_query_string = $GLOBALS['db']->quote($the_query_string);
-	array_push($where_clauses, "name like '$the_query_string%'");
-
-	$the_where = "";
-	foreach($where_clauses as $clause)
-	{
-		if($the_where != "") $the_where .= " or ";
-		$the_where .= $clause;
-	}
+     */
+    function build_generic_where_clause ($the_query_string) {
+    $where_clauses = Array();
+    $the_query_string = $GLOBALS['db']->quote($the_query_string);
+    array_push($where_clauses, "name like '$the_query_string%'");
+
+    $the_where = "";
+    foreach($where_clauses as $clause)
+    {
+        if($the_where != "") $the_where .= " or ";
+        $the_where .= $clause;
+    }
 
 
-	return $the_where;
+    return $the_where;
 }
 
 

Spacing +15 added lines, -15 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -78,9 +78,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    public function Release(){
+    public function Release() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -95,21 +95,21 @@ 
 		return "$this->name";
 	}
 
-	function get_releases($add_blank=false,$status='Active',$where='')
+	function get_releases($add_blank = false, $status = 'Active', $where = '')
 	{
-		if($where!='') {
-			$query = "SELECT id, name FROM $this->table_name where ". $where ." and deleted=0 ";
+		if ($where != '') {
+			$query = "SELECT id, name FROM $this->table_name where ".$where." and deleted=0 ";
 		}
 		else {
 			$query = "SELECT id, name FROM $this->table_name where deleted=0 ";
 		}
-		if ($status=='Active') {
+		if ($status == 'Active') {
 			$query .= " and status='Active' ";
 		}
-		elseif ($status=='Hidden') {
+		elseif ($status == 'Hidden') {
 			$query .= " and status='Hidden' ";
 		}
-		elseif ($status=='All') {
+		elseif ($status == 'All') {
 		}
 		$query .= " order by list_order asc";
 		$result = $this->db->query($query, false);
@@ -117,7 +117,7 @@ 
 
 		$list = array();
 		if ($add_blank) {
-			$list['']='';
+			$list[''] = '';
 		}
 		//if($this->db->getRowCount($result) > 0){
 			// We have some data.
@@ -140,10 +140,10 @@ 
 
 	}
 
-	function get_list_view_data(){
+	function get_list_view_data() {
 		global $app_list_strings;
 		$temp_array = $this->get_list_view_array();
-        $temp_array["ENCODED_NAME"]=$this->name;
+        $temp_array["ENCODED_NAME"] = $this->name;
         $temp_array['ENCODED_STATUS'] = $app_list_strings['release_status_dom'][$this->status];
 //	$temp_array["ENCODED_NAME"]=htmlspecialchars($this->name, ENT_QUOTES);
     	return $temp_array;
@@ -153,15 +153,15 @@ 
 		builds a generic search based on the query string using or
 		do not include any $this-> because this is called on without having the class instantiated
 	*/
-	function build_generic_where_clause ($the_query_string) {
+	function build_generic_where_clause($the_query_string) {
 	$where_clauses = Array();
 	$the_query_string = $GLOBALS['db']->quote($the_query_string);
 	array_push($where_clauses, "name like '$the_query_string%'");
 
 	$the_where = "";
-	foreach($where_clauses as $clause)
+	foreach ($where_clauses as $clause)
 	{
-		if($the_where != "") $the_where .= " or ";
+		if ($the_where != "") $the_where .= " or ";
 		$the_where .= $clause;
 	}
 

Braces +10 added lines, -10 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -82,8 +84,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct();
@@ -99,17 +100,14 @@ 
 	{
 		if($where!='') {
 			$query = "SELECT id, name FROM $this->table_name where ". $where ." and deleted=0 ";
-		}
-		else {
+		} else {
 			$query = "SELECT id, name FROM $this->table_name where deleted=0 ";
 		}
 		if ($status=='Active') {
 			$query .= " and status='Active' ";
-		}
-		elseif ($status=='Hidden') {
+		} elseif ($status=='Hidden') {
 			$query .= " and status='Hidden' ";
-		}
-		elseif ($status=='All') {
+		} elseif ($status=='All') {
 		}
 		$query .= " order by list_order asc";
 		$result = $this->db->query($query, false);
@@ -161,7 +159,9 @@ 
 	$the_where = "";
 	foreach($where_clauses as $clause)
 	{
-		if($the_where != "") $the_where .= " or ";
+		if($the_where != "") {
+		    $the_where .= " or ";
+		}
 		$the_where .= $clause;
 	}
 

modules/AOW_Processed/AOW_Processed.php

Spacing +6 added lines, -6 removed lines

@@ -29,7 +29,7 @@ 
 	var $object_name = 'AOW_Processed';
 	var $table_name = 'aow_processed';
 	var $importable = false;
-	var $disable_row_level_security = true ;
+	var $disable_row_level_security = true;
 
 	var $id;
 	var $name;
@@ -51,16 +51,16 @@ 
 	var $parent_type;
 	var $status;
 
-	function __construct(){
+	function __construct() {
 		parent::__construct();
 	}
 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function AOW_Processed(){
+    function AOW_Processed() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {
@@ -70,8 +70,8 @@ 
     }
 
 
-	function bean_implements($interface){
-		switch($interface){
+	function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL': return true;
 		}
 		return false;

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($seed, $module, $subPanel, $options);

modules/AOW_Processed/views/view.list.php

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /**
  * Advanced OpenWorkflow, Automating SugarCRM.
  * @package Advanced OpenWorkflow for SugarCRM
@@ -33,9 +33,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function AOW_ProcessedViewList(){
+    function AOW_ProcessedViewList() {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +4 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
  * Date: 06/03/15
  * Comments
  */
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 
 class CasesController extends SugarController {
 
@@ -90,8 +92,7 @@ 
                 $count++;
             }
             echo '</table>';
-        }
-        else {
+        } else {
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
         }
         die();

modules/AOW_Processed/Dashlets/AOW_ProcessedDashlet/AOW_ProcessedDashlet.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /**
  * Advanced OpenWorkflow, Automating SugarCRM.
  * @package Advanced OpenWorkflow for SugarCRM
@@ -34,7 +34,7 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_Processed');
+        if (empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_Processed');
 
         $this->searchFields = $dashletData['AOW_ProcessedDashlet']['searchFields'];
         $this->columns = $dashletData['AOW_ProcessedDashlet']['columns'];
@@ -45,9 +45,9 @@ 
     /**
      * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
      */
-    function AOW_ProcessedDashlet($id, $def = null){
+    function AOW_ProcessedDashlet($id, $def = null) {
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
-        if(isset($GLOBALS['log'])) {
+        if (isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
         }
         else {

Braces +7 added lines, -4 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /**
  * Advanced OpenWorkflow, Automating SugarCRM.
  * @package Advanced OpenWorkflow for SugarCRM
@@ -34,7 +36,9 @@ 
 
         parent::__construct($id, $def);
 
-        if(empty($def['title'])) $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_Processed');
+        if(empty($def['title'])) {
+            $this->title = translate('LBL_HOMEPAGE_TITLE', 'AOW_Processed');
+        }
 
         $this->searchFields = $dashletData['AOW_ProcessedDashlet']['searchFields'];
         $this->columns = $dashletData['AOW_ProcessedDashlet']['columns'];
@@ -49,8 +53,7 @@ 
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
         if(isset($GLOBALS['log'])) {
             $GLOBALS['log']->deprecated($deprecatedMessage);
-        }
-        else {
+        } else {
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
         }
         self::__construct($id, $def);