Passed
Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )
by Adam
56:05 queued 14:08
created
modules/EAPM/views/view.edit.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -107,6 +107,7 @@
 block discarded – undo
107 107
 
108 108
     /**
109 109
 	 * @see SugarView::getModuleTitleIconPath()
110
+	 * @param string $module
110 111
 	 */
111 112
 	protected function getModuleTitleIconPath($module) 
112 113
     {
Please login to merge, or discard this patch.
modules/EmailMan/EmailMan.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,6 +131,9 @@  discard block
 block discarded – undo
131 131
 
132 132
     } // if
133 133
 
134
+    /**
135
+     * @param string $order_by
136
+     */
134 137
     function create_queue_items_query($order_by, $where,$filter=array(),$params=array(), $show_deleted = 0,$join_type='', $return_array = false,$parentbean=null, $singleSelect = false) {
135 138
 
136 139
 		if ($return_array) {
@@ -262,6 +265,10 @@  discard block
 block discarded – undo
262 265
     }
263 266
 
264 267
 
268
+	/**
269
+	 * @param string $email_type
270
+	 * @param string $activity_type
271
+	 */
265 272
 	function set_as_sent($email_address, $delete= true,$email_id=null, $email_type=null,$activity_type=null){
266 273
 
267 274
 		global $timedate;
@@ -308,7 +315,7 @@  discard block
 block discarded – undo
308 315
      * @param string $subject email subject
309 316
      * @param string $body_text Email Body Text
310 317
      * @param string $body_html Email Body HTML
311
-     * @param string $campaign_name Campaign Name
318
+     * @param string $campagin_name Campaign Name
312 319
      * @param string from_address Email address of the sender, usually email address of the configured inbox.
313 320
      * @param string sender_id If of the user sending the campaign.
314 321
      * @param array  macro_nv array of name value pair, one row for each replacable macro in email template text.
Please login to merge, or discard this patch.
modules/Emails/Email.php 1 patch
Doc Comments   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1158,6 +1158,10 @@  discard block
 block discarded – undo
1158 1158
 		}
1159 1159
 	}
1160 1160
 
1161
+	/**
1162
+	 * @param string $id
1163
+	 * @param string $type
1164
+	 */
1161 1165
 	function linkEmailToAddress($id, $type) {
1162 1166
 		// TODO: make this update?
1163 1167
 		$q1 = "SELECT * FROM emails_email_addr_rel WHERE email_id = '{$this->id}' AND email_address_id = '{$id}' AND address_type = '{$type}' AND deleted = 0";
@@ -1598,6 +1602,9 @@  discard block
 block discarded – undo
1598 1602
 	 * @param array addrs_ids (from contacts)
1599 1603
 	 * @param array addrs_names (from contacts);
1600 1604
 	 * @param array addrs_emails (from contacts);
1605
+	 * @param string $addrs_ids
1606
+	 * @param string $addrs_names
1607
+	 * @param string $addrs_emails
1601 1608
 	 * @return array Parsed assoc array to feed to PHPMailer
1602 1609
 	 */
1603 1610
 	function parse_addrs($addrs, $addrs_ids, $addrs_names, $addrs_emails) {
@@ -1940,6 +1947,7 @@  discard block
 block discarded – undo
1940 1947
 	 * @param object mail SugarPHPMailer object
1941 1948
 	 * @param string mailer_id
1942 1949
 	 * @param string ieId
1950
+	 * @param SugarPHPMailer $mail
1943 1951
 	 * @return object mail SugarPHPMailer object
1944 1952
 	 */
1945 1953
 	function setMailer($mail, $mailer_id='', $ieId='') {
@@ -2645,7 +2653,7 @@  discard block
 block discarded – undo
2645 2653
      * Determine if an imported email has an attachment by examining the relationship to notes.
2646 2654
      *
2647 2655
      * @param string $id
2648
-     * @return boolean
2656
+     * @return integer
2649 2657
      */
2650 2658
     function doesImportedEmailHaveAttachment($id)
2651 2659
 	{
@@ -3075,8 +3083,7 @@  discard block
 block discarded – undo
3075 3083
         /**
3076 3084
          * Convert reference to inline image (stored as Note) to URL link
3077 3085
          * Enter description here ...
3078
-         * @param string $note ID of the note
3079
-         * @param string $ext type of the note
3086
+         * @param string $noteId ID of the note
3080 3087
          */
3081 3088
         public function cid2Link($noteId, $noteType)
3082 3089
         {
@@ -3144,7 +3151,7 @@  discard block
 block discarded – undo
3144 3151
      * Bugs 50972, 50973
3145 3152
      * Set the field def back to the way it was prior to modification
3146 3153
      *
3147
-     * @param $field
3154
+     * @param string $field
3148 3155
      * @return void
3149 3156
      */
3150 3157
     public function revertFieldNullable($field)
Please login to merge, or discard this patch.
modules/Emails/EmailUI.php 1 patch
Doc Comments   +19 added lines, -15 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
 	 * Generate the frame needed for the quick compose email UI.  This frame is loaded dynamically
298 298
 	 * by an ajax call.
299 299
 	 *
300
-	 * @return JSON An object containing html markup and js script variables.
300
+	 * @return string An object containing html markup and js script variables.
301 301
 	 */
302 302
 	function displayQuickComposeEmailFrame()
303 303
 	{
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
      * UI.
347 347
      *
348 348
      * @param String $emailLinkUrl
349
-     * @return JSON Object containing the composePackage and full link url
349
+     * @return string Object containing the composePackage and full link url
350 350
      */
351 351
     function generateComposePackageForQuickCreateFromComposeUrl($emailLinkUrl, $lazyLoad=false)
352 352
     {
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
      * @param String $fullLinkUrl A link that contains all pertinant information so the user can be
370 370
      *                              directed to the full compose screen if needed
371 371
      * @param SugarBean $bean Optional - the parent object bean with data
372
-     * @return JSON Object containg composePackage and fullLinkUrl
372
+     * @return string Object containg composePackage and fullLinkUrl
373 373
      */
374 374
     function generateComposePackageForQuickCreate($composeData,$fullLinkUrl, $lazyLoad=false, $bean = null)
375 375
     {
@@ -798,7 +798,6 @@  discard block
 block discarded – undo
798 798
 	/**
799 799
 	 * Creates a new Sugar folder
800 800
 	 * @param string $nodeLabel New sugar folder name
801
-	 * @param string $parentLabel Parent folder name
802 801
 	 */
803 802
 	function saveNewFolder($nodeLabel, $parentId, $isGroup=0) {
804 803
 		global $current_user;
@@ -921,8 +920,7 @@  discard block
 block discarded – undo
921 920
 
922 921
 	/**
923 922
 	 * returns an array of nodes that correspond to IMAP mailboxes.
924
-	 * @param bool $forceRefresh
925
-	 * @return object TreeView object
923
+	 * @return Tree TreeView object
926 924
 	 */
927 925
 	function getMailboxNodes() {
928 926
 		global $sugar_config;
@@ -1052,7 +1050,8 @@  discard block
 block discarded – undo
1052 1050
 	 * @param string nodePath Serialized path from root node to current node
1053 1051
 	 * @param bool isGroup
1054 1052
 	 * @param bool forceRefresh
1055
-	 * @return mixed
1053
+	 * @param boolean $isGroup
1054
+	 * @return ExtNode
1056 1055
 	 */
1057 1056
 	function buildTreeNode($key, $label, $mbox, $ieId, $nodePath, $isGroup, $ie) {
1058 1057
 		global $sugar_config;
@@ -1114,6 +1113,7 @@  discard block
 block discarded – undo
1114 1113
 
1115 1114
 	/**
1116 1115
 	 * Totals the unread emails
1116
+	 * @param string $mailbox
1117 1117
 	 */
1118 1118
 	function getUnreadCount(&$ie, $mailbox) {
1119 1119
 		global $sugar_config;
@@ -1203,7 +1203,7 @@  discard block
 block discarded – undo
1203 1203
 	 * Renders the QuickCreate form from Smarty and returns HTML
1204 1204
 	 * @param array $vars request variable global
1205 1205
 	 * @param object $email Fetched email object
1206
-	 * @param bool $addToAddressBook
1206
+	 * @param bool $addToAddressBookButton
1207 1207
 	 * @return array
1208 1208
 	 */
1209 1209
 	function getQuickCreateForm($vars, $email, $addToAddressBookButton=false) {
@@ -1340,9 +1340,8 @@  discard block
 block discarded – undo
1340 1340
 	/**
1341 1341
      * Renders the Import form from Smarty and returns HTML
1342 1342
      * @param array $vars request variable global
1343
-     * @param object $email Fetched email object
1344
-     * @param bool $addToAddressBook
1345
-     * @return array
1343
+     * @param Email $email Fetched email object
1344
+     * @return string
1346 1345
      */
1347 1346
     function getImportForm($vars, $email, $formName = 'ImportEditView') {
1348 1347
 		require_once("include/EditView/EditView2.php");
@@ -1786,6 +1785,9 @@  discard block
 block discarded – undo
1786 1785
 	return $counts;
1787 1786
 } // fn
1788 1787
 
1788
+/**
1789
+ * @param InboundEmail $ie
1790
+ */
1789 1791
 function getLastRobin($ie) {
1790 1792
 	$lastRobin = "";
1791 1793
 	if($this->validCacheFileExists($ie->id, 'folders', "robin.cache.php")) {
@@ -1794,6 +1796,9 @@  discard block
 block discarded – undo
1794 1796
 	return $lastRobin;
1795 1797
 } // fn
1796 1798
 
1799
+/**
1800
+ * @param InboundEmail $ie
1801
+ */
1797 1802
 function setLastRobin($ie, $lastRobin) {
1798 1803
     global $sugar_config;
1799 1804
     $cacheFolderPath = sugar_cached("modules/Emails/{$ie->id}/folders");
@@ -1996,6 +2001,7 @@  discard block
 block discarded – undo
1996 2001
 	 * Formats email body on reply/forward
1997 2002
 	 * @param object email Email object in focus
1998 2003
 	 * @param string type
2004
+	 * @param Email $email
1999 2005
 	 * @return object email
2000 2006
 	 */
2001 2007
 	function handleReplyType($email, $type) {
@@ -2283,7 +2289,7 @@  discard block
 block discarded – undo
2283 2289
 
2284 2290
 	/**
2285 2291
 	 * Cleans UID lists
2286
-	 * @param mixed $uids
2292
+	 * @param string $uids
2287 2293
 	 * @param bool $returnString False will return an array
2288 2294
 	 * @return mixed
2289 2295
 	 */
@@ -2582,7 +2588,7 @@  discard block
 block discarded – undo
2582 2588
      * This function will return all the accounts this user has access to based on the
2583 2589
      * match of the emailId passed in as a parameter
2584 2590
      *
2585
-     * @param unknown_type $ie
2591
+     * @param InboundEmail $ie
2586 2592
      * @return unknown
2587 2593
      */
2588 2594
 	function getFromAllAccountsArray($ie, $ret) {
@@ -3030,8 +3036,6 @@  discard block
 block discarded – undo
3030 3036
      * Generate to/cc addresses string in email detailview.
3031 3037
      *
3032 3038
      * @param string $str
3033
-     * @param string $target values: to, cc
3034
-     * @param int $defaultNum
3035 3039
      * @return string $str
3036 3040
      */
3037 3041
 	function generateExpandableAddrs($str) {
Please login to merge, or discard this patch.
modules/Employees/views/view.list.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
     * Return the "breadcrumbs" to display at the top of the page
69 69
     *
70 70
     * @param  bool $show_help optional, true if we show the help links
71
-    * @return HTML string containing breadcrumb title
71
+    * @return string string containing breadcrumb title
72 72
     */
73 73
     public function getModuleTitle($show_help = true)
74 74
     {
Please login to merge, or discard this patch.
modules/FP_events/controller.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -598,6 +598,12 @@
 block discarded – undo
598 598
     }
599 599
 
600 600
     //handles sending the emails
601
+
602
+    /**
603
+     * @param string $emailToname
604
+     * @param string $emailBody
605
+     * @param string $altemailBody
606
+     */
601 607
     public function sendEmail($emailTo, $emailSubject, $emailToname, $emailBody, $altemailBody, SugarBean $relatedBean = null, $attachments = array()){
602 608
        
603 609
         $emailObj = new Email();
Please login to merge, or discard this patch.
modules/Home/Dashlets/RSSDashlet/RSSDashlet.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -142,6 +142,9 @@
 block discarded – undo
142 142
         return $options;
143 143
     }
144 144
 
145
+    /**
146
+     * @param string $url
147
+     */
145 148
     protected function getRSSOutput(
146 149
         $url
147 150
         )
Please login to merge, or discard this patch.
modules/Home/QuickSearch.php 1 patch
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      *        'order' => 'name', // order by
79 79
      *        'limit' => '30', // limit, number of records to return
80 80
      *       )
81
-     * @return array list of elements returned
81
+     * @return string list of elements returned
82 82
      */
83 83
     public function query($args)
84 84
     {
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
      * Returns the list of users, faster than using query method for Users module
108 108
      *
109 109
      * @param array $args arguments used to construct query, see query() for example
110
-     * @return array list of users returned
110
+     * @return string list of users returned
111 111
      */
112 112
     public function get_user_array($args)
113 113
     {
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      * Returns search results from external API
123 123
      *
124 124
      * @param array $args
125
-     * @return array
125
+     * @return string
126 126
      */
127 127
     public function externalApi($args)
128 128
     {
@@ -496,7 +496,6 @@  discard block
 block discarded – undo
496 496
     /**
497 497
      * Returns prepared arguments. Should be redefined in child classes.
498 498
      *
499
-     * @param array $arguments
500 499
      * @return array
501 500
      */
502 501
     protected function prepareArguments($args)
Please login to merge, or discard this patch.
modules/Home/UnifiedSearch.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -188,6 +188,9 @@  discard block
 block discarded – undo
188 188
     $output = preg_replace(array('/(?<=[^A-Z])([A-Z])/', '/(?<=[^0-9])([0-9])/'), $sep.'$0', $input);
189 189
     return ucwords($output);
190 190
 }
191
+/**
192
+ * @param string $module
193
+ */
191 194
 function getModuleLabel($module){
192 195
     return translate('LBL_MODULE_NAME', $module);
193 196
 }
@@ -197,6 +200,9 @@  discard block
 block discarded – undo
197 200
     sugar_file_put_contents_atomic($file, $out);
198 201
 }
199 202
 
203
+/**
204
+ * @param string $filePath
205
+ */
200 206
 function getCorrectMTime($filePath){
201 207
     $time = filemtime($filePath);
202 208
     $isDST = (date('I', $time) == 1);
Please login to merge, or discard this patch.