Passed
Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )
by Adam
56:05 queued 14:08
created
OpportunitiesByLeadSourceDashlet/OpportunitiesByLeadSourceDashlet.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -200,6 +200,9 @@
 block discarded – undo
200 200
 
201 201
     }
202 202
 
203
+    /**
204
+     * @param string $query
205
+     */
203 206
     function getChartData($query)
204 207
     {
205 208
         global $app_list_strings, $db;
Please login to merge, or discard this patch.
Charts/Dashlets/PipelineBySalesStageDashlet/PipelineBySalesStageDashlet.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -241,7 +241,7 @@
 block discarded – undo
241 241
      * awu: Bug 16794 - this function is a hack to get the correct sales stage order until
242 242
      * i can clean it up later
243 243
      *
244
-     * @param  $query string
244
+     * @param  string $query string
245 245
      * @return array
246 246
      */
247 247
     function getChartData(
Please login to merge, or discard this patch.
modules/Configurator/Configurator.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -182,6 +182,10 @@  discard block
 block discarded – undo
182 182
 		}
183 183
 		return $sugar_config;
184 184
 	}
185
+
186
+	/**
187
+	 * @param string $override
188
+	 */
185 189
 	function saveOverride($override) {
186 190
         require_once('install/install_utils.php');
187 191
 	    if ( !file_exists('config_override.php') ) {
@@ -230,6 +234,11 @@  discard block
 block discarded – undo
230 234
 		}
231 235
 	}
232 236
 
237
+	/**
238
+	 * @param string $path
239
+	 *
240
+	 * @return string
241
+	 */
233 242
 	function checkTempImage($path)
234 243
 	{
235 244
         if(!verify_uploaded_image($path)) {
Please login to merge, or discard this patch.
modules/Connectors/controller.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -705,6 +705,9 @@  discard block
 block discarded – undo
705 705
 	    echo $json->encode($results);
706 706
 	}
707 707
 
708
+	/**
709
+	 * @param string $field_name
710
+	 */
708 711
 	function add_social_field($module, $field_name)
709 712
 	{
710 713
 
@@ -741,6 +744,10 @@  discard block
 block discarded – undo
741 744
 
742 745
 	}
743 746
 
747
+	/**
748
+	 * @param string $view
749
+	 * @param string $panel_name
750
+	 */
744 751
 	private function create_panel_on_view($view, $field, $module, $panel_name){
745 752
 		//require and create object.
746 753
 		require_once('modules/ModuleBuilder/parsers/ParserFactory.php');
Please login to merge, or discard this patch.
modules/Contacts/Contact.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -427,6 +427,7 @@  discard block
 block discarded – undo
427 427
 	/**
428 428
 		builds a generic search based on the query string using or
429 429
 		do not include any $this-> because this is called on without having the class instantiated
430
+	* @param string $the_query_string
430 431
 	*/
431 432
 	function build_generic_where_clause ($the_query_string)
432 433
 	{
@@ -520,7 +521,7 @@  discard block
 block discarded – undo
520 521
      * - string 'all': add this contact for all users
521 522
      * - comma deliminated lists of teams and/or users
522 523
      *
523
-     * @param string $list_of_user
524
+     * @param string $list_of_users
524 525
      */
525 526
     function process_sync_to_outlook($list_of_users)
526 527
     {
Please login to merge, or discard this patch.
modules/Contacts/ContactFormBase.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
  * @see checkForDuplicates (method), ContactFormBase.php, LeadFormBase.php, ProspectFormBase.php
62 62
  * @param $focus sugarbean
63 63
  * @param $prefix String value of prefix that may be present in $_POST variables
64
- * @return SQL String of the query that should be used for the initial duplicate lookup check
64
+ * @return string String of the query that should be used for the initial duplicate lookup check
65 65
  */
66 66
 public function getDuplicateQuery($focus, $prefix='')
67 67
 {
@@ -645,6 +645,9 @@  discard block
 block discarded – undo
645 645
 	}
646 646
 }
647 647
 
648
+/**
649
+ * @param string $return_id
650
+ */
648 651
 function handleRedirect($return_id){
649 652
 	if(isset($_POST['return_module']) && $_POST['return_module'] != "") {
650 653
 		$return_module = urlencode($_POST['return_module']);
Please login to merge, or discard this patch.
modules/Contacts/updatePortal.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@
 block discarded – undo
48 48
         }
49 49
     }
50 50
 
51
+ /**
52
+  * @param string $emailSubject
53
+  */
51 54
  function sendEmail($emailTo, $emailSubject, $emailBody, $altemailBody, SugarBean $relatedBean = null)
52 55
 	{
53 56
 	   	require_once('modules/Emails/Email.php');
Please login to merge, or discard this patch.
modules/DynamicFields/DynamicField.php 1 patch
Doc Comments   +18 added lines, -7 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     *
100 100
     * @param STRING $module
101 101
     * @param boolean saveCache Boolean value indicating whether or not to pass saveCache value to saveToVardef, defaults to true
102
-    * @return unknown
102
+    * @return boolean
103 103
     */
104 104
     function buildCache($module = false, $saveCache=true) {
105 105
         //We can't build the cache while installing as the required database tables may not exist.
@@ -308,6 +308,9 @@  discard block
 block discarded – undo
308 308
 
309 309
     }
310 310
 
311
+   /**
312
+    * @param string $joinTableAlias
313
+    */
311 314
    function getRelateJoin($field_def, $joinTableAlias, $withIdName = true) {
312 315
         if (empty($field_def['type']) || $field_def['type'] != "relate") {
313 316
             return false;
@@ -465,7 +468,6 @@  discard block
 block discarded – undo
465 468
     /**
466 469
      * Deletes the field from fields_meta_data and drops the database column then it rebuilds the cache
467 470
      * Use the widgets get_db_modify_alter_table() method to get the table sql - some widgets do not need any custom table modifications
468
-     * @param STRING $name - field name
469 471
      */
470 472
     function deleteField($widget){
471 473
         require_once('modules/DynamicFields/templates/Fields/TemplateField.php');
@@ -525,7 +527,7 @@  discard block
 block discarded – undo
525 527
     /**
526 528
      * Adds a custom field using a field object
527 529
      *
528
-     * @param Field Object $field
530
+     * @param Field TemplateField $field
529 531
      * @return boolean
530 532
      */
531 533
     function addFieldObject(&$field){
@@ -605,6 +607,9 @@  discard block
 block discarded – undo
605 607
         return true;
606 608
     }
607 609
 
610
+    /**
611
+     * @param string[] $column_fields
612
+     */
608 613
     function saveExtendedAttributes($field, $column_fields)
609 614
     {
610 615
             require_once ('modules/ModuleBuilder/parsers/StandardField.php') ;
@@ -686,6 +691,9 @@  discard block
 block discarded – undo
686 691
         }
687 692
     }
688 693
 
694
+    /**
695
+     * @param TemplateField $field
696
+     */
689 697
     protected function removeVardefExtension($field)
690 698
     {
691 699
         $file_loc = "$this->base_path/sugarfield_{$field->name}.php";
@@ -710,12 +718,12 @@  discard block
 block discarded – undo
710 718
      * @param unknown_type $ext1
711 719
      * @param unknown_type $ext2
712 720
      * @param unknown_type $ext3
713
-     * @param unknown_type $audited
714
-     * @param unknown_type $inline_edit
715
-     * @param unknown_type $mass_update
721
+     * @param integer $audited
722
+     * @param integer $inline_edit
723
+     * @param integer $mass_update
716 724
      * @param unknown_type $ext4
717 725
      * @param unknown_type $help
718
-     * @param unknown_type $duplicate_merge
726
+     * @param integer $duplicate_merge
719 727
      * @param unknown_type $comment
720 728
      * @return boolean
721 729
      */
@@ -983,6 +991,9 @@  discard block
 block discarded – undo
983 991
 
984 992
     }
985 993
 
994
+    /**
995
+     * @param string $type
996
+     */
986 997
     function getAllFieldsView($view, $type){
987 998
          require_once ('modules/DynamicFields/FieldCases.php');
988 999
          $results = array();
Please login to merge, or discard this patch.
modules/DynamicFields/templates/Fields/TemplateField.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -309,6 +309,9 @@
 block discarded – undo
309 309
 		return $GLOBALS['db']->getHelper()->addColumnSQL($table, $this->get_field_def(), true);
310 310
 	}
311 311
 
312
+	/**
313
+	 * @param string $table
314
+	 */
312 315
 	function get_db_delete_alter_table($table)
313 316
 	{
314 317
 		return $GLOBALS['db']->getHelper()->dropColumnSQL(
Please login to merge, or discard this patch.