Passed
Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )
by Adam
56:05 queued 14:08
created
modules/Contacts/ContactOpportunityRelationship.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
  * Date: 06/03/15
44 44
  * Comments
45 45
  */
46
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
46
+if(!defined('sugarEntry') || !sugarEntry) {
47
+    die('Not A Valid Entry Point');
48
+}
47 49
 
48 50
 class CasesController extends SugarController {
49 51
 
@@ -90,8 +92,7 @@  discard block
 block discarded – undo
90 92
                 $count++;
91 93
             }
92 94
             echo '</table>';
93
-        }
94
-        else {
95
+        } else {
95 96
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
96 97
         }
97 98
         die();
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.quick_radius_display.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
  * Date: 06/03/15
44 44
  * Comments
45 45
  */
46
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
46
+if(!defined('sugarEntry') || !sugarEntry) {
47
+    die('Not A Valid Entry Point');
48
+}
47 49
 
48 50
 class CasesController extends SugarController {
49 51
 
@@ -90,8 +92,7 @@  discard block
 block discarded – undo
90 92
                 $count++;
91 93
             }
92 94
             echo '</table>';
93
-        }
94
-        else {
95
+        } else {
95 96
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
96 97
         }
97 98
         die();
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.geocoded_counts.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
  * Date: 06/03/15
44 44
  * Comments
45 45
  */
46
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
46
+if(!defined('sugarEntry') || !sugarEntry) {
47
+    die('Not A Valid Entry Point');
48
+}
47 49
 
48 50
 class CasesController extends SugarController {
49 51
 
@@ -90,8 +92,7 @@  discard block
 block discarded – undo
90 92
                 $count++;
91 93
             }
92 94
             echo '</table>';
93
-        }
94
-        else {
95
+        } else {
95 96
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
96 97
         }
97 98
         die();
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.quick_radius.php 1 patch
Braces   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,6 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3
+if(!defined('sugarEntry') || !sugarEntry) {
4
+    die('Not A Valid Entry Point');
5
+}
4 6
 
5 7
 class Jjwg_MapsViewQuick_Radius extends SugarView {
6 8
 
@@ -15,8 +17,7 @@  discard block
 block discarded – undo
15 17
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
16 18
         if(isset($GLOBALS['log'])) {
17 19
             $GLOBALS['log']->deprecated($deprecatedMessage);
18
-        }
19
-        else {
20
+        } else {
20 21
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
21 22
         }
22 23
         self::__construct();
@@ -25,8 +26,10 @@  discard block
 block discarded – undo
25 26
 
26 27
 	function display() {
27 28
 
28
-        if (!isset($_REQUEST['quick_address'])) $_REQUEST['quick_address'] = '';
29
-?>
29
+        if (!isset($_REQUEST['quick_address'])) {
30
+            $_REQUEST['quick_address'] = '';
31
+        }
32
+        ?>
30 33
 
31 34
 <div class="moduleTitle"><h2><?php echo $GLOBALS['mod_strings']['LBL_MAP_QUICK_RADIUS']; ?><div class="clear"></div></h2></div>
32 35
 <div class="clear"></div>
@@ -53,7 +56,9 @@  discard block
 block discarded – undo
53 56
             <select id="display_module" tabindex="111" title="<?php echo $GLOBALS['mod_strings']['LBL_MODULE_TYPE']; ?>" name="display_module">
54 57
                 <?php foreach ($GLOBALS['jjwg_config']['valid_geocode_modules'] as $module) { ?>
55 58
                     <option value="<?php echo htmlspecialchars($module); ?>" <?php
56
-                    if (!empty($_REQUEST['display_module']) && $module == $_REQUEST['display_module']) echo 'selected="selected"';
59
+                    if (!empty($_REQUEST['display_module']) && $module == $_REQUEST['display_module']) {
60
+                        echo 'selected="selected"';
61
+                    }
57 62
                     ?>><?php echo htmlspecialchars($GLOBALS['app_list_strings']['moduleList'][$module]); ?>
58 63
                 <?php } ?>
59 64
             </select>
@@ -69,7 +74,9 @@  discard block
 block discarded – undo
69 74
             <select id="unit_type" tabindex="131" title="<?php echo $GLOBALS['mod_strings']['LBL_DISTANCE']; ?>" name="unit_type">
70 75
                 <?php foreach ($GLOBALS['app_list_strings']['map_unit_type_list'] as $key=>$value) { ?>
71 76
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
72
-                    if ($key == $_REQUEST['unit_type']) echo 'selected="selected"';
77
+                    if ($key == $_REQUEST['unit_type']) {
78
+                        echo 'selected="selected"';
79
+                    }
73 80
                     ?>><?php echo htmlspecialchars($value); ?>
74 81
                 <?php } ?>
75 82
             </select>
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.geocoding_test.php 1 patch
Braces   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3
+if(!defined('sugarEntry') || !sugarEntry) {
4
+    die('Not A Valid Entry Point');
5
+}
4 6
 
5 7
 class Jjwg_MapsViewGeocoding_Test extends SugarView {
6 8
 
@@ -15,8 +17,7 @@  discard block
 block discarded – undo
15 17
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
16 18
         if(isset($GLOBALS['log'])) {
17 19
             $GLOBALS['log']->deprecated($deprecatedMessage);
18
-        }
19
-        else {
20
+        } else {
20 21
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
21 22
         }
22 23
         self::__construct();
@@ -25,8 +26,10 @@  discard block
 block discarded – undo
25 26
 
26 27
 	function display() {
27 28
 
28
-        if (!isset($_REQUEST['geocoding_address'])) $_REQUEST['geocoding_address'] = '';
29
-?>
29
+        if (!isset($_REQUEST['geocoding_address'])) {
30
+            $_REQUEST['geocoding_address'] = '';
31
+        }
32
+        ?>
30 33
 
31 34
 <div class="moduleTitle"><h2><?php echo $GLOBALS['mod_strings']['LBL_MAP_ADDRESS_TEST']; ?></h2><div class="clear"></div></div>
32 35
 <div class="clear"></div>
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.map_display.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
  * Date: 06/03/15
44 44
  * Comments
45 45
  */
46
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
46
+if(!defined('sugarEntry') || !sugarEntry) {
47
+    die('Not A Valid Entry Point');
48
+}
47 49
 
48 50
 class CasesController extends SugarController {
49 51
 
@@ -90,8 +92,7 @@  discard block
 block discarded – undo
90 92
                 $count++;
91 93
             }
92 94
             echo '</table>';
93
-        }
94
-        else {
95
+        } else {
95 96
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
96 97
         }
97 98
         die();
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.config.php 1 patch
Braces   +46 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,6 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3
+if (!defined('sugarEntry') || !sugarEntry) {
4
+    die('Not A Valid Entry Point');
5
+}
4 6
 
5 7
 class Jjwg_MapsViewConfig extends SugarView {
6 8
 
@@ -15,8 +17,7 @@  discard block
 block discarded – undo
15 17
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
16 18
         if(isset($GLOBALS['log'])) {
17 19
             $GLOBALS['log']->deprecated($deprecatedMessage);
18
-        }
19
-        else {
20
+        } else {
20 21
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
21 22
         }
22 23
         self::__construct();
@@ -128,7 +129,9 @@  discard block
 block discarded – undo
128 129
                 name="address_type_Accounts" title="">
129 130
                 <?php foreach ($address_types_billing_or_shipping as $key=>$value) { ?>
130 131
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
131
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Accounts']) echo 'selected="selected"';
132
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Accounts']) {
133
+                        echo 'selected="selected"';
134
+                    }
132 135
                     ?>><?php echo htmlspecialchars($value); ?></option>
133 136
                 <?php } ?>
134 137
             </select>
@@ -145,7 +148,9 @@  discard block
 block discarded – undo
145 148
                 name="address_type_Contacts" title="">
146 149
                 <?php foreach ($address_types_primary_or_alt as $key=>$value) { ?>
147 150
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
148
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Contacts']) echo 'selected="selected"';
151
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Contacts']) {
152
+                        echo 'selected="selected"';
153
+                    }
149 154
                     ?>><?php echo htmlspecialchars($value); ?></option>
150 155
                 <?php } ?>
151 156
             </select>
@@ -162,7 +167,9 @@  discard block
 block discarded – undo
162 167
                 name="address_type_Leads" title="">
163 168
                 <?php foreach ($address_types_primary_or_alt as $key=>$value) { ?>
164 169
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
165
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Leads']) echo 'selected="selected"';
170
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Leads']) {
171
+                        echo 'selected="selected"';
172
+                    }
166 173
                     ?>><?php echo htmlspecialchars($value); ?></option>
167 174
                 <?php } ?>
168 175
             </select>
@@ -179,7 +186,9 @@  discard block
 block discarded – undo
179 186
                 name="address_type_Opportunities" title="">
180 187
                 <?php foreach ($address_types_billing_or_shipping as $key=>$value) { ?>
181 188
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
182
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Opportunities']) echo 'selected="selected"';
189
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Opportunities']) {
190
+                        echo 'selected="selected"';
191
+                    }
183 192
                     ?>><?php echo htmlspecialchars($value); ?></option>
184 193
                 <?php } ?>
185 194
             </select>
@@ -197,7 +206,9 @@  discard block
 block discarded – undo
197 206
                 name="address_type_Cases" title="">
198 207
                 <?php foreach ($address_types_billing_or_shipping as $key=>$value) { ?>
199 208
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
200
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Cases']) echo 'selected="selected"';
209
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Cases']) {
210
+                        echo 'selected="selected"';
211
+                    }
201 212
                     ?>><?php echo htmlspecialchars($value); ?></option>
202 213
                 <?php } ?>
203 214
             </select>
@@ -215,7 +226,9 @@  discard block
 block discarded – undo
215 226
                 name="address_type_Project" title="">
216 227
                 <?php foreach ($address_types_billing_or_shipping as $key=>$value) { ?>
217 228
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
218
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Project']) echo 'selected="selected"';
229
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Project']) {
230
+                        echo 'selected="selected"';
231
+                    }
219 232
                     ?>><?php echo htmlspecialchars($value); ?></option>
220 233
                 <?php } ?>
221 234
             </select>
@@ -233,7 +246,9 @@  discard block
 block discarded – undo
233 246
                 name="address_type_Meetings" title="">
234 247
                 <?php foreach ($address_types_flex_relate as $key=>$value) { ?>
235 248
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
236
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Meetings']) echo 'selected="selected"';
249
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Meetings']) {
250
+                        echo 'selected="selected"';
251
+                    }
237 252
                     ?>><?php echo htmlspecialchars($value); ?></option>
238 253
                 <?php } ?>
239 254
             </select>
@@ -249,7 +264,9 @@  discard block
 block discarded – undo
249 264
                 name="address_type_Prospects" title="">
250 265
                 <?php foreach ($address_types_primary_or_alt as $key=>$value) { ?>
251 266
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
252
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Prospects']) echo 'selected="selected"';
267
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type']['Prospects']) {
268
+                        echo 'selected="selected"';
269
+                    }
253 270
                     ?>><?php echo htmlspecialchars($value); ?></option>
254 271
                 <?php } ?>
255 272
             </select>
@@ -270,7 +287,9 @@  discard block
 block discarded – undo
270 287
                 name="address_type_<?php echo $module; ?>" title="">
271 288
                 <?php foreach ($address_types_all as $key=>$value) { ?>
272 289
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
273
-                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type'][$module]) echo 'selected="selected"';
290
+                    if ($key == $GLOBALS['jjwg_config']['geocode_modules_to_address_type'][$module]) {
291
+                        echo 'selected="selected"';
292
+                    }
274 293
                     ?>><?php echo htmlspecialchars($value); ?></option>
275 294
                 <?php } ?>
276 295
             </select>
@@ -464,7 +483,9 @@  discard block
 block discarded – undo
464 483
                 name="allow_approximate_location_type" title="">
465 484
                 <?php foreach ($enabled_disabled as $key=>$value) { ?>
466 485
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
467
-                    if ($key == $enabled) echo 'selected="selected"';
486
+                    if ($key == $enabled) {
487
+                        echo 'selected="selected"';
488
+                    }
468 489
                     ?>><?php echo htmlspecialchars($value); ?>
469 490
                 <?php } ?>
470 491
             </select>
@@ -508,7 +529,9 @@  discard block
 block discarded – undo
508 529
                 name="address_cache_get_enabled" title="">
509 530
                 <?php foreach ($enabled_disabled as $key=>$value) { ?>
510 531
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
511
-                    if ($key == $enabled) echo 'selected="selected"';
532
+                    if ($key == $enabled) {
533
+                        echo 'selected="selected"';
534
+                    }
512 535
                     ?>><?php echo htmlspecialchars($value); ?>
513 536
                 <?php } ?>
514 537
             </select>
@@ -526,7 +549,9 @@  discard block
 block discarded – undo
526 549
                 name="address_cache_save_enabled" title="">
527 550
                 <?php foreach ($enabled_disabled as $key=>$value) { ?>
528 551
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
529
-                    if ($key == $enabled) echo 'selected="selected"';
552
+                    if ($key == $enabled) {
553
+                        echo 'selected="selected"';
554
+                    }
530 555
                     ?>><?php echo htmlspecialchars($value); ?>
531 556
                 <?php } ?>
532 557
             </select>
@@ -556,7 +581,9 @@  discard block
 block discarded – undo
556 581
                 name="logic_hooks_enabled" title="">
557 582
                 <?php foreach ($enabled_disabled as $key=>$value) { ?>
558 583
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
559
-                    if ($key == $enabled) echo 'selected="selected"';
584
+                    if ($key == $enabled) {
585
+                        echo 'selected="selected"';
586
+                    }
560 587
                     ?>><?php echo htmlspecialchars($value); ?>
561 588
                 <?php } ?>
562 589
             </select>
@@ -624,7 +651,9 @@  discard block
 block discarded – undo
624 651
                 name="map_default_unit_type" title="">
625 652
                 <?php foreach ($unit_types as $key=>$value) { ?>
626 653
                     <option value="<?php echo htmlspecialchars($key); ?>" <?php
627
-                    if ($key == $GLOBALS['jjwg_config']['map_default_unit_type']) echo 'selected="selected"';
654
+                    if ($key == $GLOBALS['jjwg_config']['map_default_unit_type']) {
655
+                        echo 'selected="selected"';
656
+                    }
628 657
                     ?>><?php echo htmlspecialchars($value); ?>
629 658
                 <?php } ?>
630 659
             </select>
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.donate.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
  * Date: 06/03/15
44 44
  * Comments
45 45
  */
46
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
46
+if(!defined('sugarEntry') || !sugarEntry) {
47
+    die('Not A Valid Entry Point');
48
+}
47 49
 
48 50
 class CasesController extends SugarController {
49 51
 
@@ -90,8 +92,7 @@  discard block
 block discarded – undo
90 92
                 $count++;
91 93
             }
92 94
             echo '</table>';
93
-        }
94
-        else {
95
+        } else {
95 96
             echo $mod_strings['LBL_NO_SUGGESTIONS'];
96 97
         }
97 98
         die();
Please login to merge, or discard this patch.
modules/jjwg_Maps/views/view.map_markers.php 1 patch
Braces   +13 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,6 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
3
+if(!defined('sugarEntry') || !sugarEntry) {
4
+    die('Not A Valid Entry Point');
5
+}
4 6
 
5 7
 class Jjwg_MapsViewMap_Markers extends SugarView {
6 8
 
@@ -15,8 +17,7 @@  discard block
 block discarded – undo
15 17
         $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
16 18
         if(isset($GLOBALS['log'])) {
17 19
             $GLOBALS['log']->deprecated($deprecatedMessage);
18
-        }
19
-        else {
20
+        } else {
20 21
             trigger_error($deprecatedMessage, E_USER_DEPRECATED);
21 22
         }
22 23
         self::__construct();
@@ -113,8 +114,12 @@  discard block
 block discarded – undo
113 114
         // Define default point as map center
114 115
         $this->bean->map_center['lat'] = $GLOBALS['jjwg_config']['map_default_center_latitude'];
115 116
         $this->bean->map_center['lng'] = $GLOBALS['jjwg_config']['map_default_center_longitude'];
116
-        if (!isset($this->bean->map_center['html'])) $this->bean->map_center['html'] = $GLOBALS['mod_strings']['LBL_DEFAULT'];
117
-        if (!isset($this->bean->map_center['name'])) $this->bean->map_center['name'] = $GLOBALS['mod_strings']['LBL_DEFAULT'];
117
+        if (!isset($this->bean->map_center['html'])) {
118
+            $this->bean->map_center['html'] = $GLOBALS['mod_strings']['LBL_DEFAULT'];
119
+        }
120
+        if (!isset($this->bean->map_center['name'])) {
121
+            $this->bean->map_center['name'] = $GLOBALS['mod_strings']['LBL_DEFAULT'];
122
+        }
118 123
     }
119 124
 }
120 125
 ?>
@@ -127,7 +132,9 @@  discard block
 block discarded – undo
127 132
     // Define Map Data
128 133
     $num_markers = count($this->bean->map_markers);
129 134
     $num_groups = count($this->bean->map_markers_groups);
130
-    if ($num_groups > 216) $num_groups = 216;
135
+    if ($num_groups > 216) {
136
+        $num_groups = 216;
137
+    }
131 138
     $group_name_to_num = array();
132 139
     $i = 1;
133 140
     // Define Group Name to Icon Number Mapping 1-216(max)
Please login to merge, or discard this patch.