Passed
Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )
by Adam
56:05 queued 14:08
created
modules/ACL/ACLController.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,6 +76,9 @@  discard block
 block discarded – undo
76 76
 	}
77 77
 	/* END - SECURITY GROUPS */	
78 78
 
79
+	/**
80
+	 * @param string $value
81
+	 */
79 82
 	static function requireOwner($category, $value, $type='module'){
80 83
 			global $current_user;
81 84
 			if(is_admin($current_user))return false;
@@ -83,6 +86,10 @@  discard block
 block discarded – undo
83 86
 	}
84 87
 
85 88
 	/* BEGIN - SECURITY GROUPS */
89
+
90
+	/**
91
+	 * @param string $value
92
+	 */
86 93
 	static function requireSecurityGroup($category, $value, $type='module'){
87 94
 			global $current_user;
88 95
 			if(is_admin($current_user))return false;
@@ -142,7 +149,7 @@  discard block
 block discarded – undo
142 149
 	 * Check to see if the module is available for this user.
143 150
 	 *
144 151
 	 * @param String $module_name
145
-	 * @return true if they are allowed.  false otherwise.
152
+	 * @return boolean if they are allowed.  false otherwise.
146 153
 	 */
147 154
 	static function checkModuleAllowed($module_name, $actions)
148 155
 	{
Please login to merge, or discard this patch.
modules/ACLActions/ACLAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
      * returns the label  associated with an access level
159 159
      * these label definitions  exist in the definitions in modules/ACLActions/actiondefs.php
160 160
      * @param INT $access - the access level you want the color for
161
-     * @return the access level label or false if the level does not exist
161
+     * @return string|false access level label or false if the level does not exist
162 162
      */
163 163
     protected static function AccessLabel($access){
164 164
         global $ACLActionAccessLevels;
Please login to merge, or discard this patch.
modules/ACLRoles/ACLRole.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
  *
69 69
  * Sets the relationship between a role and an action and sets the access level of that relationship
70 70
  *
71
- * @param GUID $role_id - the role id
71
+ * @param string $role_id - the role id
72 72
  * @param GUID $action_id - the ACL Action id
73 73
  * @param int $access - the access level ACL_ALLOW_ALL ACL_ALLOW_NONE ACL_ALLOW_OWNER...
74 74
  */
Please login to merge, or discard this patch.
modules/Activities/EmailReminder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
      * @param SugarBean $bean
124 124
      * @param Administration $admin
125 125
      * @param array $recipients
126
-     * @return boolean
126
+     * @return null|boolean
127 127
      */
128 128
     public function sendReminders(SugarBean $bean, Administration $admin, $recipients)
129 129
     {
Please login to merge, or discard this patch.
modules/Administration/Common.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,6 +74,7 @@  discard block
 block discarded – undo
74 74
 /**
75 75
  * @return string&
76 76
  * @param the_array array, language string, module string
77
+ * @param string $old_contents
77 78
  * @desc Returns the contents of the customized language pack.
78 79
  */
79 80
 function &create_field_lang_pak_contents($old_contents, $key, $value, $language, $module)
@@ -346,7 +347,7 @@  discard block
 block discarded – undo
346 347
 
347 348
 /**
348 349
  * @return bool
349
- * @param dropdown_name string, language string
350
+ * @param dropdown_name string language string
350 351
  * @desc Creates a new dropdown type.
351 352
  */
352 353
 function create_dropdown_type($dropdown_name, $language)
@@ -549,6 +550,9 @@  discard block
 block discarded – undo
549 550
    save_custom_app_list_strings_contents($new_contents, $language);
550 551
 }
551 552
 
553
+/**
554
+ * @param string $file_contents
555
+ */
552 556
 function replace_or_add_dropdown_type($dropdown_type, &$dropdown_array,
553 557
    &$file_contents)
554 558
 {
@@ -580,6 +584,9 @@  discard block
 block discarded – undo
580 584
 	return $new_contents;
581 585
 }
582 586
 
587
+/**
588
+ * @param string $file_contents
589
+ */
583 590
 function replace_or_add_app_string($name, $value,
584 591
    &$file_contents)
585 592
 {
Please login to merge, or discard this patch.
modules/Administration/controller.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,6 @@
 block discarded – undo
123 123
      * to be able to add additional parameters which are currently not supported
124 124
      * in the UI (i.e. additional curl settings for elastic search for auth)
125 125
      *
126
-     * @param array $config
127 126
      * @return array
128 127
      */
129 128
     protected function mergeFtsConfig($type, $newConfig)
Please login to merge, or discard this patch.
modules/Administration/DiagnosticRun.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -124,6 +124,9 @@
 block discarded – undo
124 124
 global $cacheDir;
125 125
 $cacheDir = "";
126 126
 
127
+/**
128
+ * @param integer $itemweight
129
+ */
127 130
 function sodUpdateProgressBar($itemweight){
128 131
     global $progress_bar_percent;
129 132
     global $totalweight;
Please login to merge, or discard this patch.
modules/Administration/QuickRepairAndRebuild.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
     public $execute;
48 48
     protected $module_list_from_cache;
49 49
 
50
+    /**
51
+     * @param string[] $selected_actions
52
+     */
50 53
     public function repairAndClearAll($selected_actions, $modules, $autoexecute=false, $show_output=true)
51 54
     {
52 55
         global $mod_strings;
@@ -446,6 +449,11 @@  discard block
 block discarded – undo
446 449
 	///////////////////////////////////////////////////////////////
447 450
 	//// Recursively unlink all files of the given $extension in the given $thedir.
448 451
 	//
452
+
453
+	/**
454
+	 * @param string $thedir
455
+	 * @param string $extension
456
+	 */
449 457
 	private function _clearCache($thedir, $extension)
450 458
 	{
451 459
         if ($current = @opendir($thedir)) {
Please login to merge, or discard this patch.
modules/Administration/SugarSpriteBuilder.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
      * addDirectory
107 107
      *
108 108
      * This function is used to create the spriteSrc array
109
-     * @param $name String value of the sprite name
109
+     * @param string $name String value of the sprite name
110 110
      * @param $dir String value of the directory associated with the sprite entry
111 111
      */
112 112
 	public function addDirectory($name, $dir) {
@@ -212,6 +212,7 @@  discard block
 block discarded – undo
212 212
      * This is a private helper function to return attributes about an image.  If the width, height or type of the
213 213
      * image file cannot be determined, then we do not process the file.
214 214
      *
215
+     * @param string $file
215 216
      * @return array of file info entries containing file information (x, y, type) if image type is supported
216 217
      */
217 218
 	private function getFileInfo($dir, $file) {
@@ -631,6 +632,10 @@  discard block
 block discarded – undo
631 632
 	}
632 633
 
633 634
 	// helper function to get highest axis value
635
+
636
+	/**
637
+	 * @param string $axis
638
+	 */
634 639
 	function getMaxAxis($axis) {
635 640
 		$val = 0;
636 641
 		foreach($this->spriteMatrix as $id => $coor) {
Please login to merge, or discard this patch.