ViewEdit::ViewEdit() - Code Metrics - Inspection of "Merge branch 'develop' into scrutinizer-code-quali..." - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )

by Adam

created 2016-05-10 07:43 UTC

ViewEdit::ViewEdit() A

↳ Parent: ViewEdit

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	1	Features	1

Metric	Value
cc	2
eloc	7
c	1
b	1
f	1
nc	2
nop	0
dl	0
loc	10
ccs	0
cts	1
cp	0
crap	6
rs	9.4285

<?php
/*********************************************************************************
 * SugarCRM Community Edition is a customer relationship management program developed by
 * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

 * SuiteCRM is an extension to SugarCRM Community Edition developed by Salesagility Ltd.
 * Copyright (C) 2011 - 2014 Salesagility Ltd.
 *
 * This program is free software; you can redistribute it and/or modify it under
 * the terms of the GNU Affero General Public License version 3 as published by the
 * Free Software Foundation with the addition of the following permission added
 * to Section 15 as permitted in Section 7(a): FOR ANY PART OF THE COVERED WORK
 * IN WHICH THE COPYRIGHT IS OWNED BY SUGARCRM, SUGARCRM DISCLAIMS THE WARRANTY
 * OF NON INFRINGEMENT OF THIRD PARTY RIGHTS.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more
 * details.
 *
 * You should have received a copy of the GNU Affero General Public License along with
 * this program; if not, see http://www.gnu.org/licenses or write to the Free
 * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
 * 02110-1301 USA.
 *
 * You can contact SugarCRM, Inc. headquarters at 10050 North Wolfe Road,
 * SW2-130, Cupertino, CA 95014, USA. or at email address [email protected].
 *
 * The interactive user interfaces in modified source and object code versions
 * of this program must display Appropriate Legal Notices, as required under
 * Section 5 of the GNU Affero General Public License version 3.
 *
 * In accordance with Section 7(b) of the GNU Affero General Public License version 3,
 * these Appropriate Legal Notices must retain the display of the "Powered by
 * SugarCRM" logo and "Supercharged by SuiteCRM" logo. If the display of the logos is not
 * reasonably feasible for  technical reasons, the Appropriate Legal Notices must
 * display the words  "Powered by SugarCRM" and "Supercharged by SuiteCRM".
 ********************************************************************************/

/*
 * Created on Apr 13, 2007
 *
 * To change the template for this generated file go to
 * Window - Preferences - PHPeclipse - PHP - Code Templates
 */

require_once('include/EditView/EditView2.php');
 class ViewEdit extends SugarView{
 	var $ev;
 	var $type ='edit';
 	var $useForSubpanel = false;  //boolean variable to determine whether view can be used for subpanel creates
 	var $useModuleQuickCreateTemplate = false; //boolean variable to determine whether or not SubpanelQuickCreate has a separate display function
 	var $showTitle = true;

 	public function __construct(){
 		parent::__construct();
 	}

    /**
     * @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
     */
    public function ViewEdit(){
        $deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
        if(isset($GLOBALS['log'])) {
            $GLOBALS['log']->deprecated($deprecatedMessage);
        }
        else {
            trigger_error($deprecatedMessage, E_USER_DEPRECATED);
        }
        self::__construct();
    }


    /**
     * @see SugarView::preDisplay()
     */
    public function preDisplay()
    {
        $metadataFile = $this->getMetaDataFile();
        $this->ev = $this->getEditView();
        $this->ev->ss =& $this->ss;
        $this->ev->setup($this->module, $this->bean, $metadataFile, get_custom_file_if_exists('include/EditView/EditView.tpl'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

 	function display(){
		$this->ev->process();
		echo $this->ev->display($this->showTitle);

 	}

    /**
     * Get EditView object
     * @return EditView
     */
    protected function getEditView()
    {
        return new EditView();

    }
}



1		<?php
2		/*********************************************************************************
3		* SugarCRM Community Edition is a customer relationship management program developed by
4		* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
5
6		* SuiteCRM is an extension to SugarCRM Community Edition developed by Salesagility Ltd.
7		* Copyright (C) 2011 - 2014 Salesagility Ltd.
8		*
9		* This program is free software; you can redistribute it and/or modify it under
10		* the terms of the GNU Affero General Public License version 3 as published by the
11		* Free Software Foundation with the addition of the following permission added
12		* to Section 15 as permitted in Section 7(a): FOR ANY PART OF THE COVERED WORK
13		* IN WHICH THE COPYRIGHT IS OWNED BY SUGARCRM, SUGARCRM DISCLAIMS THE WARRANTY
14		* OF NON INFRINGEMENT OF THIRD PARTY RIGHTS.
15		*
16		* This program is distributed in the hope that it will be useful, but WITHOUT
17		* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
18		* FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
19		* details.
20		*
21		* You should have received a copy of the GNU Affero General Public License along with
22		* this program; if not, see http://www.gnu.org/licenses or write to the Free
23		* Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
24		* 02110-1301 USA.
25		*
26		* You can contact SugarCRM, Inc. headquarters at 10050 North Wolfe Road,
27		* SW2-130, Cupertino, CA 95014, USA. or at email address [email protected].
28		*
29		* The interactive user interfaces in modified source and object code versions
30		* of this program must display Appropriate Legal Notices, as required under
31		* Section 5 of the GNU Affero General Public License version 3.
32		*
33		* In accordance with Section 7(b) of the GNU Affero General Public License version 3,
34		* these Appropriate Legal Notices must retain the display of the "Powered by
35		* SugarCRM" logo and "Supercharged by SuiteCRM" logo. If the display of the logos is not
36		* reasonably feasible for technical reasons, the Appropriate Legal Notices must
37		* display the words "Powered by SugarCRM" and "Supercharged by SuiteCRM".
38		********************************************************************************/
39
40		/*
41		* Created on Apr 13, 2007
42		*
43		* To change the template for this generated file go to
44		* Window - Preferences - PHPeclipse - PHP - Code Templates
45		*/
46
47	1	require_once('include/EditView/EditView2.php');
48		class ViewEdit extends SugarView{
49		var $ev;
50		var $type ='edit';
51		var $useForSubpanel = false; //boolean variable to determine whether view can be used for subpanel creates
52		var $useModuleQuickCreateTemplate = false; //boolean variable to determine whether or not SubpanelQuickCreate has a separate display function
53		var $showTitle = true;
54
55	5	public function __construct(){
56	5	parent::__construct();
57	5	}
58
59		/**
60		* @deprecated deprecated since version 7.6, PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code, use __construct instead
61		*/
62		public function ViewEdit(){
63		$deprecatedMessage = 'PHP4 Style Constructors are deprecated and will be remove in 7.8, please update your code';
64		if(isset($GLOBALS['log'])) {
65		$GLOBALS['log']->deprecated($deprecatedMessage);
66		}
67		else {
68		trigger_error($deprecatedMessage, E_USER_DEPRECATED);
69		}
70		self::__construct();
71		}
72
73
74		/**
75		* @see SugarView::preDisplay()
76		*/
77	2	public function preDisplay()
78		{
79	2	$metadataFile = $this->getMetaDataFile();
80	2	$this->ev = $this->getEditView();
81	2	$this->ev->ss =& $this->ss;
82	2	$this->ev->setup($this->module, $this->bean, $metadataFile, get_custom_file_if_exists('include/EditView/EditView.tpl'));
		0 ignored issues – show Bug introduced 2016-03-07 17:58 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `EditView` as the method `setup()` does only exist in the following sub-classes of `EditView`: `DetailView2`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
83	2	}
84
85	3	function display(){
86	3	$this->ev->process();
87	3	echo $this->ev->display($this->showTitle);
		0 ignored issues – show Unused Code introduced 2016-03-07 17:58 UTC by Report Bug Copy Issue Report The call to `EditView::display()` has too many arguments starting with `$this->showTitle`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
88	3	}
89
90		/**
91		* Get EditView object
92		* @return EditView
93		*/
94	2	protected function getEditView()
95		{
96	2	return new EditView();
		0 ignored issues – show Bug introduced 2016-05-03 11:15 UTC by Report Bug Copy Issue Report The call to `EditView::__construct()` misses some required arguments starting with `$module`. Loading history... Deprecated Code introduced 2016-03-07 17:58 UTC by Report Bug Copy Issue Report The class `EditView` has been deprecated. This class, trait or interface has been deprecated. Loading history...
97		}
98		}
99
100

adamjakab / SuiteCRM

Push — scrutinizer-code-quality ( 09f5a1...c4c5fb )

ViewEdit::ViewEdit() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like