adamjakab / SuiteCRM

include/generic/SugarWidgets/SugarWidgetSubPanelTopMessage.php

Indentation +3 added lines, -3 removed lines

@@ -46,8 +46,8 @@
 
 class SugarWidgetSubPanelTopMessage extends SugarWidgetSubPanelTopButton
 {
-	function display($defines)
-	{
+    function display($defines)
+    {
         return $defines['message'];
-	}
+    }
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetFieldenum.php

Indentation +104 added lines, -104 removed lines

@@ -58,39 +58,39 @@ 
     }
 
     public function queryFilteris($layout_def) {
-		$input_name0 = $layout_def['input_name0'];
-		if (is_array($layout_def['input_name0'])) {
-			$input_name0 = $layout_def['input_name0'][0];
-		}
-		return $this->_get_column_select($layout_def)." = ".$this->reporter->db->quoted($input_name0)."\n";
-	}
-
-	public function queryFilteris_not($layout_def) {
-		$input_name0 = $layout_def['input_name0'];
-		if (is_array($layout_def['input_name0'])) {
-			$input_name0 = $layout_def['input_name0'][0];
-		}
-		return $this->_get_column_select($layout_def)." <> ".$this->reporter->db->quoted($input_name0)."\n";
-	}
-
-	public function queryFilterone_of($layout_def) {
-		$arr = array ();
-		foreach ($layout_def['input_name0'] as $value) {
-			$arr[] = $this->reporter->db->quoted($value);
-		}
-		$str = implode(",", $arr);
-		return $this->_get_column_select($layout_def)." IN (".$str.")\n";
-	}
-
-	public function queryFilternot_one_of($layout_def) {
-		$arr = array ();
-		foreach ($layout_def['input_name0'] as $value) {
-			$arr[] = $this->reporter->db->quoted($value);
-		}
-	    $reporter = $this->layout_manager->getAttribute("reporter");
-		$str = implode(",", $arr);
-		return $this->_get_column_select($layout_def)." NOT IN (".$str.")\n";
-	}
+        $input_name0 = $layout_def['input_name0'];
+        if (is_array($layout_def['input_name0'])) {
+            $input_name0 = $layout_def['input_name0'][0];
+        }
+        return $this->_get_column_select($layout_def)." = ".$this->reporter->db->quoted($input_name0)."\n";
+    }
+
+    public function queryFilteris_not($layout_def) {
+        $input_name0 = $layout_def['input_name0'];
+        if (is_array($layout_def['input_name0'])) {
+            $input_name0 = $layout_def['input_name0'][0];
+        }
+        return $this->_get_column_select($layout_def)." <> ".$this->reporter->db->quoted($input_name0)."\n";
+    }
+
+    public function queryFilterone_of($layout_def) {
+        $arr = array ();
+        foreach ($layout_def['input_name0'] as $value) {
+            $arr[] = $this->reporter->db->quoted($value);
+        }
+        $str = implode(",", $arr);
+        return $this->_get_column_select($layout_def)." IN (".$str.")\n";
+    }
+
+    public function queryFilternot_one_of($layout_def) {
+        $arr = array ();
+        foreach ($layout_def['input_name0'] as $value) {
+            $arr[] = $this->reporter->db->quoted($value);
+        }
+        $reporter = $this->layout_manager->getAttribute("reporter");
+        $str = implode(",", $arr);
+        return $this->_get_column_select($layout_def)." NOT IN (".$str.")\n";
+    }
 
     function & displayList($layout_def) {
         if(!empty($layout_def['column_key'])){
@@ -116,84 +116,84 @@ 
                 $field_type = $field_def['type'];
                 $div_id = $field_def['module'] ."&$record&$field_name";
                 $str = "<div id='$div_id'>" . $cell . "&nbsp;"
-                     . SugarThemeRegistry::current()->getImage(
+                        . SugarThemeRegistry::current()->getImage(
                         "edit_inline",
                         "border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(" .
                         "\"$div_id\",\"$cell\",\"$module\",\"$record\",\"$field_name\",\"$field_type\");'"
-                       )
-                     . "</div>";
+                        )
+                        . "</div>";
             }
         }
         return $str;
     }
-	function & displayListPlain($layout_def) {
-		if(!empty($layout_def['column_key'])){
-			$field_def = $this->reporter->all_fields[$layout_def['column_key']];
-		}else if(!empty($layout_def['fields'])){
-			$field_def = $layout_def['fields'];
-		}
-
-		if (!empty($layout_def['table_key'] ) &&( empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))){
-			$value = $this->_get_list_value($layout_def);
-		}else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
-			$key = strtoupper($layout_def['name']);
-			$value = $layout_def['fields'][$key];
-		}
-		$cell = '';
-
-			if(isset($field_def['options'])){
-				$cell = translate($field_def['options'], $field_def['module'], $value);
-			}else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
-	            global $beanFiles;
-	            if(empty($beanFiles)) {
-	                include('include/modules.php');
-	            }
-	            $bean_name = get_singular_bean_name($field_def['module']);
-	            require_once($beanFiles[$bean_name]);
-	            $list = $field_def['function']();
-	            $cell = $list[$value];
-	        }
-		if (is_array($cell)) {
-
-			//#22632
-			$value = unencodeMultienum($value);
-			$cell=array();
-			foreach($value as $val){
-				$returnVal = translate($field_def['options'],$field_def['module'],$val);
-				if(!is_array($returnVal)){
-					array_push( $cell, translate($field_def['options'],$field_def['module'],$val));
-				}
-			}
-			$cell = implode(", ",$cell);
-		}
-		return $cell;
-	}
-
-	public function queryOrderBy($layout_def) {
-		$field_def = $this->reporter->all_fields[$layout_def['column_key']];
-		if (!empty ($field_def['sort_on'])) {
-			$order_by = $layout_def['table_alias'].".".$field_def['sort_on'];
-		} else {
-			$order_by = $this->_get_column_select($layout_def);
-		}
-		$list = array();
+    function & displayListPlain($layout_def) {
+        if(!empty($layout_def['column_key'])){
+            $field_def = $this->reporter->all_fields[$layout_def['column_key']];
+        }else if(!empty($layout_def['fields'])){
+            $field_def = $layout_def['fields'];
+        }
+
+        if (!empty($layout_def['table_key'] ) &&( empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))){
+            $value = $this->_get_list_value($layout_def);
+        }else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
+            $key = strtoupper($layout_def['name']);
+            $value = $layout_def['fields'][$key];
+        }
+        $cell = '';
+
+            if(isset($field_def['options'])){
+                $cell = translate($field_def['options'], $field_def['module'], $value);
+            }else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
+                global $beanFiles;
+                if(empty($beanFiles)) {
+                    include('include/modules.php');
+                }
+                $bean_name = get_singular_bean_name($field_def['module']);
+                require_once($beanFiles[$bean_name]);
+                $list = $field_def['function']();
+                $cell = $list[$value];
+            }
+        if (is_array($cell)) {
+
+            //#22632
+            $value = unencodeMultienum($value);
+            $cell=array();
+            foreach($value as $val){
+                $returnVal = translate($field_def['options'],$field_def['module'],$val);
+                if(!is_array($returnVal)){
+                    array_push( $cell, translate($field_def['options'],$field_def['module'],$val));
+                }
+            }
+            $cell = implode(", ",$cell);
+        }
+        return $cell;
+    }
+
+    public function queryOrderBy($layout_def) {
+        $field_def = $this->reporter->all_fields[$layout_def['column_key']];
+        if (!empty ($field_def['sort_on'])) {
+            $order_by = $layout_def['table_alias'].".".$field_def['sort_on'];
+        } else {
+            $order_by = $this->_get_column_select($layout_def);
+        }
+        $list = array();
         if(isset($field_def['options'])) {
-		    $list = translate($field_def['options'], $field_def['module']);
+            $list = translate($field_def['options'], $field_def['module']);
         } elseif(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
-	        global $beanFiles;
-		    if(empty($beanFiles)) {
-		        include('include/modules.php');
-		    }
-		    $bean_name = get_singular_bean_name($field_def['module']);
-		    require_once($beanFiles[$bean_name]);
+            global $beanFiles;
+            if(empty($beanFiles)) {
+                include('include/modules.php');
+            }
+            $bean_name = get_singular_bean_name($field_def['module']);
+            require_once($beanFiles[$bean_name]);
             $list = $field_def['function']();
         }
-		if (empty ($layout_def['sort_dir']) || $layout_def['sort_dir'] == 'a') {
-			$order_dir = "ASC";
-		} else {
-			$order_dir = "DESC";
-		}
-		return $this->reporter->db->orderByEnum($order_by, $list, $order_dir);
+        if (empty ($layout_def['sort_dir']) || $layout_def['sort_dir'] == 'a') {
+            $order_dir = "ASC";
+        } else {
+            $order_dir = "DESC";
+        }
+        return $this->reporter->db->orderByEnum($order_by, $list, $order_dir);
     }
 
     public function displayInput($layout_def) {
@@ -204,13 +204,13 @@ 
                 $ops = $layout_def['options'];
             }
             elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
-            	$ops = $app_list_strings[$layout_def['options']];
+                $ops = $app_list_strings[$layout_def['options']];
                 if(array_key_exists('', $app_list_strings[$layout_def['options']])) {
-             	   unset($ops['']);
-	            }
+                    unset($ops['']);
+                }
             }
             else{
-            	$ops = array();
+                $ops = array();
             }
         }
         else {

Spacing +32 added lines, -32 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -48,13 +48,13 @@ 
     public function queryFilterEmpty($layout_def)
     {
         $column = $this->_get_column_select($layout_def);
-        return "(coalesce(" . $this->reporter->db->convert($column, "length") . ",0) = 0 OR $column = '^^')";
+        return "(coalesce(".$this->reporter->db->convert($column, "length").",0) = 0 OR $column = '^^')";
     }
 
     public function queryFilterNot_Empty($layout_def)
     {
         $column = $this->_get_column_select($layout_def);
-        return "(coalesce(" . $this->reporter->db->convert($column, "length") . ",0) > 0 AND $column != '^^' )\n";
+        return "(coalesce(".$this->reporter->db->convert($column, "length").",0) > 0 AND $column != '^^' )\n";
     }
 
     public function queryFilteris($layout_def) {
@@ -74,7 +74,7 @@ 
 	}
 
 	public function queryFilterone_of($layout_def) {
-		$arr = array ();
+		$arr = array();
 		foreach ($layout_def['input_name0'] as $value) {
 			$arr[] = $this->reporter->db->quoted($value);
 		}
@@ -83,7 +83,7 @@ 
 	}
 
 	public function queryFilternot_one_of($layout_def) {
-		$arr = array ();
+		$arr = array();
 		foreach ($layout_def['input_name0'] as $value) {
 			$arr[] = $this->reporter->db->quoted($value);
 		}
@@ -93,9 +93,9 @@ 
 	}
 
     function & displayList($layout_def) {
-        if(!empty($layout_def['column_key'])){
+        if (!empty($layout_def['column_key'])) {
             $field_def = $this->reporter->all_fields[$layout_def['column_key']];
-        }else if(!empty($layout_def['fields'])){
+        } else if (!empty($layout_def['fields'])) {
             $field_def = $layout_def['fields'];
         }
         $cell = $this->displayListPlain($layout_def);
@@ -114,11 +114,11 @@ 
                 $record = $layout_def['fields'][$key];
                 $field_name = $field_def['name'];
                 $field_type = $field_def['type'];
-                $div_id = $field_def['module'] ."&$record&$field_name";
-                $str = "<div id='$div_id'>" . $cell . "&nbsp;"
+                $div_id = $field_def['module']."&$record&$field_name";
+                $str = "<div id='$div_id'>".$cell."&nbsp;"
                      . SugarThemeRegistry::current()->getImage(
                         "edit_inline",
-                        "border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(" .
+                        "border='0' alt='Edit Layout' align='bottom' onClick='SUGAR.reportsInlineEdit.inlineEdit(".
                         "\"$div_id\",\"$cell\",\"$module\",\"$record\",\"$field_name\",\"$field_type\");'"
                        )
                      . "</div>";
@@ -127,25 +127,25 @@ 
         return $str;
     }
 	function & displayListPlain($layout_def) {
-		if(!empty($layout_def['column_key'])){
+		if (!empty($layout_def['column_key'])) {
 			$field_def = $this->reporter->all_fields[$layout_def['column_key']];
-		}else if(!empty($layout_def['fields'])){
+		} else if (!empty($layout_def['fields'])) {
 			$field_def = $layout_def['fields'];
 		}
 
-		if (!empty($layout_def['table_key'] ) &&( empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))){
+		if (!empty($layout_def['table_key']) && (empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))) {
 			$value = $this->_get_list_value($layout_def);
-		}else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
+		} else if (!empty($layout_def['name']) && !empty($layout_def['fields'])) {
 			$key = strtoupper($layout_def['name']);
 			$value = $layout_def['fields'][$key];
 		}
 		$cell = '';
 
-			if(isset($field_def['options'])){
+			if (isset($field_def['options'])) {
 				$cell = translate($field_def['options'], $field_def['module'], $value);
-			}else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
+			} else if (isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
 	            global $beanFiles;
-	            if(empty($beanFiles)) {
+	            if (empty($beanFiles)) {
 	                include('include/modules.php');
 	            }
 	            $bean_name = get_singular_bean_name($field_def['module']);
@@ -157,14 +157,14 @@ 
 
 			//#22632
 			$value = unencodeMultienum($value);
-			$cell=array();
-			foreach($value as $val){
-				$returnVal = translate($field_def['options'],$field_def['module'],$val);
-				if(!is_array($returnVal)){
-					array_push( $cell, translate($field_def['options'],$field_def['module'],$val));
+			$cell = array();
+			foreach ($value as $val) {
+				$returnVal = translate($field_def['options'], $field_def['module'], $val);
+				if (!is_array($returnVal)) {
+					array_push($cell, translate($field_def['options'], $field_def['module'], $val));
 				}
 			}
-			$cell = implode(", ",$cell);
+			$cell = implode(", ", $cell);
 		}
 		return $cell;
 	}
@@ -177,11 +177,11 @@ 
 			$order_by = $this->_get_column_select($layout_def);
 		}
 		$list = array();
-        if(isset($field_def['options'])) {
+        if (isset($field_def['options'])) {
 		    $list = translate($field_def['options'], $field_def['module']);
-        } elseif(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
+        } elseif (isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])) {
 	        global $beanFiles;
-		    if(empty($beanFiles)) {
+		    if (empty($beanFiles)) {
 		        include('include/modules.php');
 		    }
 		    $bean_name = get_singular_bean_name($field_def['module']);
@@ -199,17 +199,17 @@ 
     public function displayInput($layout_def) {
         global $app_list_strings;
 
-        if(!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
-            if ( isset($layout_def['options']) &&  is_array($layout_def['options']) ) {
+        if (!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
+            if (isset($layout_def['options']) && is_array($layout_def['options'])) {
                 $ops = $layout_def['options'];
             }
-            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
+            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])) {
             	$ops = $app_list_strings[$layout_def['options']];
-                if(array_key_exists('', $app_list_strings[$layout_def['options']])) {
+                if (array_key_exists('', $app_list_strings[$layout_def['options']])) {
              	   unset($ops['']);
 	            }
             }
-            else{
+            else {
             	$ops = array();
             }
         }
@@ -217,7 +217,7 @@ 
             $ops = $app_list_strings[$layout_def['options']];
         }
 
-        $str = '<select multiple="true" size="3" name="' . $layout_def['name'] . '[]">';
+        $str = '<select multiple="true" size="3" name="'.$layout_def['name'].'[]">';
         $str .= get_select_options_with_id($ops, $layout_def['input_name0']);
         $str .= '</select>';
         return $str;

Braces +10 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -95,7 +97,7 @@ 
     function & displayList($layout_def) {
         if(!empty($layout_def['column_key'])){
             $field_def = $this->reporter->all_fields[$layout_def['column_key']];
-        }else if(!empty($layout_def['fields'])){
+        } else if(!empty($layout_def['fields'])){
             $field_def = $layout_def['fields'];
         }
         $cell = $this->displayListPlain($layout_def);
@@ -129,13 +131,13 @@ 
 	function & displayListPlain($layout_def) {
 		if(!empty($layout_def['column_key'])){
 			$field_def = $this->reporter->all_fields[$layout_def['column_key']];
-		}else if(!empty($layout_def['fields'])){
+		} else if(!empty($layout_def['fields'])){
 			$field_def = $layout_def['fields'];
 		}
 
 		if (!empty($layout_def['table_key'] ) &&( empty ($field_def['fields']) || empty ($field_def['fields'][0]) || empty ($field_def['fields'][1]))){
 			$value = $this->_get_list_value($layout_def);
-		}else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
+		} else if(!empty($layout_def['name']) && !empty($layout_def['fields'])){
 			$key = strtoupper($layout_def['name']);
 			$value = $layout_def['fields'][$key];
 		}
@@ -143,7 +145,7 @@ 
 
 			if(isset($field_def['options'])){
 				$cell = translate($field_def['options'], $field_def['module'], $value);
-			}else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
+			} else if(isset($field_def['type']) && $field_def['type'] == 'enum' && isset($field_def['function'])){
 	            global $beanFiles;
 	            if(empty($beanFiles)) {
 	                include('include/modules.php');
@@ -202,18 +204,15 @@ 
         if(!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {
             if ( isset($layout_def['options']) &&  is_array($layout_def['options']) ) {
                 $ops = $layout_def['options'];
-            }
-            elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
+            } elseif (isset($layout_def['options']) && isset($app_list_strings[$layout_def['options']])){
             	$ops = $app_list_strings[$layout_def['options']];
                 if(array_key_exists('', $app_list_strings[$layout_def['options']])) {
              	   unset($ops['']);
 	            }
-            }
-            else{
+            } else{
             	$ops = array();
             }
-        }
-        else {
+        } else {
             $ops = $app_list_strings[$layout_def['options']];
         }
 

include/generic/SugarWidgets/SugarWidgetSubPanelTopSelectUsersButton.php

Indentation +124 added lines, -124 removed lines

@@ -45,137 +45,137 @@
 
 class SugarWidgetSubPanelTopSelectUsersButton extends SugarWidgetSubPanelTopSelectButton
 {
-	//button_properties is a collection of properties associated with the widget_class definition. layoutmanager
-	function SugarWidgetSubPanelTopSelectUsersButton($button_properties=array())
-	{
-		$this->button_properties=$button_properties;
-	}
+    //button_properties is a collection of properties associated with the widget_class definition. layoutmanager
+    function SugarWidgetSubPanelTopSelectUsersButton($button_properties=array())
+    {
+        $this->button_properties=$button_properties;
+    }
 
     function getDisplayName()
     {
         return $GLOBALS['app_strings']['LBL_SELECT_USER_BUTTON_LABEL'];
     }
-	//widget_data is the collection of attributes associated with the button in the layout_defs file.
-	function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
-	{
-		global $app_strings;
-		$initial_filter = '';
-
-		$this->title = $app_strings['LBL_SELECT_USER_BUTTON_TITLE'];
-		//$this->accesskey = $app_strings['LBL_SELECT_USER_BUTTON_KEY'];
-		$this->value = $this->getDisplayName();
-
-		$this->module_name = 'Users';
-
-		if (is_array($this->button_properties)) {
-			if( isset($this->button_properties['title'])) {
-				$this->title = $app_strings[$this->button_properties['title']];
-			}
-			if( isset($this->button_properties['accesskey'])) {
-				//$this->accesskey = $app_strings[$this->button_properties['accesskey']];
-			}
-			if( isset($this->button_properties['form_value'])) {
-				$this->value = $app_strings[$this->button_properties['form_value']];
-			}
-			if( isset($this->button_properties['module'])) {
-				$this->module_name = $this->button_properties['module'];
-			}
-		}
-
-		$focus = $widget_data['focus'];
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
-			$button = ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-			. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
-			.' disabled />';
-			return $button;
-		}
-
-		//refresh the whole page after end of action?
-		$refresh_page = 0;
-		if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
-			$refresh_page = 1;
-		}
-
-		$subpanel_definition = $widget_data['subpanel_definition'];
-
-		$button_definition = $subpanel_definition->get_buttons();
-		$subpanel_name = $subpanel_definition->get_module_name();
-		if (empty($this->module_name)) {
-			$this->module_name = $subpanel_name;
-		}
-
-		if ($subpanel_name == 'Project'){
-			$link_field_name = 'project_users_1';
-		}
-		else{
-			$link_field_name = $subpanel_definition->get_data_source_name(true);
-		}
-
-		$popup_mode='Single';
-		if(isset($widget_data['mode'])){
-			$popup_mode=$widget_data['mode'];
-		}
-		if(isset($widget_data['initial_filter_fields'])){
-			if (is_array($widget_data['initial_filter_fields'])) {
-				foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
-					if (isset($focus->$value) and !empty($focus->$value)) {
-						$initial_filter.="&".$alias . '='.urlencode($focus->$value);
-					}
-				}
-			}
-		}
-
-		if (!empty($widget_data['filter_out_is_admin'])) {
+    //widget_data is the collection of attributes associated with the button in the layout_defs file.
+    function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
+    {
+        global $app_strings;
+        $initial_filter = '';
+
+        $this->title = $app_strings['LBL_SELECT_USER_BUTTON_TITLE'];
+        //$this->accesskey = $app_strings['LBL_SELECT_USER_BUTTON_KEY'];
+        $this->value = $this->getDisplayName();
+
+        $this->module_name = 'Users';
+
+        if (is_array($this->button_properties)) {
+            if( isset($this->button_properties['title'])) {
+                $this->title = $app_strings[$this->button_properties['title']];
+            }
+            if( isset($this->button_properties['accesskey'])) {
+                //$this->accesskey = $app_strings[$this->button_properties['accesskey']];
+            }
+            if( isset($this->button_properties['form_value'])) {
+                $this->value = $app_strings[$this->button_properties['form_value']];
+            }
+            if( isset($this->button_properties['module'])) {
+                $this->module_name = $this->button_properties['module'];
+            }
+        }
+
+        $focus = $widget_data['focus'];
+        if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
+            $button = ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
+            . ' title="' . $this->title . '"'
+            . ' value="' . $this->value . "\"\n"
+            .' disabled />';
+            return $button;
+        }
+
+        //refresh the whole page after end of action?
+        $refresh_page = 0;
+        if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
+            $refresh_page = 1;
+        }
+
+        $subpanel_definition = $widget_data['subpanel_definition'];
+
+        $button_definition = $subpanel_definition->get_buttons();
+        $subpanel_name = $subpanel_definition->get_module_name();
+        if (empty($this->module_name)) {
+            $this->module_name = $subpanel_name;
+        }
+
+        if ($subpanel_name == 'Project'){
+            $link_field_name = 'project_users_1';
+        }
+        else{
+            $link_field_name = $subpanel_definition->get_data_source_name(true);
+        }
+
+        $popup_mode='Single';
+        if(isset($widget_data['mode'])){
+            $popup_mode=$widget_data['mode'];
+        }
+        if(isset($widget_data['initial_filter_fields'])){
+            if (is_array($widget_data['initial_filter_fields'])) {
+                foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
+                    if (isset($focus->$value) and !empty($focus->$value)) {
+                        $initial_filter.="&".$alias . '='.urlencode($focus->$value);
+                    }
+                }
+            }
+        }
+
+        if (!empty($widget_data['filter_out_is_admin'])) {
             $initial_filter.="&is_admin_advanced=0";
         }
 
-		$create="true";
-		if(isset($widget_data['create'])){
-			$create=$widget_data['create'];
-		}
-		$return_module = $_REQUEST['module'];
-		$return_action = 'SubPanelViewer';
-		$return_id = $_REQUEST['record'];
-
-		//field_to_name_array
-		$fton_array= array('id' => 'subpanel_id');
-		if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
-			$fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
-		}
-
-		$return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
-
-		$popup_request_data = array(
-			'call_back_function' => 'set_return_and_save_background',
-			'form_name' => 'DetailView',
-			'field_to_name_array' => $fton_array,
-			'passthru_data' => array(
-				'child_field' => $this->module_name,
-				'return_url' => urlencode($return_url),
-				'link_field_name' => $link_field_name,
-				'module_name' => $this->module_name,
-				'refresh_page' => 1,
-			),
-		);
-
-		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
-			$popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
-		}
-
-		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
-
-			if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
-				$initial_filter = "&module_name=". urlencode($widget_data['module']);
-			}
-		}
-		$json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
-
-		return '<form action="index.php">' . "\n"
-			. ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-				. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
-			. " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
-	}
+        $create="true";
+        if(isset($widget_data['create'])){
+            $create=$widget_data['create'];
+        }
+        $return_module = $_REQUEST['module'];
+        $return_action = 'SubPanelViewer';
+        $return_id = $_REQUEST['record'];
+
+        //field_to_name_array
+        $fton_array= array('id' => 'subpanel_id');
+        if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
+            $fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
+        }
+
+        $return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
+
+        $popup_request_data = array(
+            'call_back_function' => 'set_return_and_save_background',
+            'form_name' => 'DetailView',
+            'field_to_name_array' => $fton_array,
+            'passthru_data' => array(
+                'child_field' => $this->module_name,
+                'return_url' => urlencode($return_url),
+                'link_field_name' => $link_field_name,
+                'module_name' => $this->module_name,
+                'refresh_page' => 1,
+            ),
+        );
+
+        if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
+            $popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
+        }
+
+        if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
+
+            if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
+                $initial_filter = "&module_name=". urlencode($widget_data['module']);
+            }
+        }
+        $json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
+
+        return '<form action="index.php">' . "\n"
+            . ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
+                . ' title="' . $this->title . '"'
+            . ' value="' . $this->value . "\"\n"
+            . " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
+    }
 }
 ?>

Spacing +33 added lines, -33 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,9 +46,9 @@ 
 class SugarWidgetSubPanelTopSelectUsersButton extends SugarWidgetSubPanelTopSelectButton
 {
 	//button_properties is a collection of properties associated with the widget_class definition. layoutmanager
-	function SugarWidgetSubPanelTopSelectUsersButton($button_properties=array())
+	function SugarWidgetSubPanelTopSelectUsersButton($button_properties = array())
 	{
-		$this->button_properties=$button_properties;
+		$this->button_properties = $button_properties;
 	}
 
     function getDisplayName()
@@ -68,32 +68,32 @@ 
 		$this->module_name = 'Users';
 
 		if (is_array($this->button_properties)) {
-			if( isset($this->button_properties['title'])) {
+			if (isset($this->button_properties['title'])) {
 				$this->title = $app_strings[$this->button_properties['title']];
 			}
-			if( isset($this->button_properties['accesskey'])) {
+			if (isset($this->button_properties['accesskey'])) {
 				//$this->accesskey = $app_strings[$this->button_properties['accesskey']];
 			}
-			if( isset($this->button_properties['form_value'])) {
+			if (isset($this->button_properties['form_value'])) {
 				$this->value = $app_strings[$this->button_properties['form_value']];
 			}
-			if( isset($this->button_properties['module'])) {
+			if (isset($this->button_properties['module'])) {
 				$this->module_name = $this->button_properties['module'];
 			}
 		}
 
 		$focus = $widget_data['focus'];
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
-			$button = ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-			. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
+		if (ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)) {
+			$button = ' <input type="button" name="'.$this->getWidgetId().'" id="'.$this->getWidgetId().'" class="button"'."\"\n"
+			. ' title="'.$this->title.'"'
+			. ' value="'.$this->value."\"\n"
 			.' disabled />';
 			return $button;
 		}
 
 		//refresh the whole page after end of action?
 		$refresh_page = 0;
-		if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
+		if (!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])) {
 			$refresh_page = 1;
 		}
 
@@ -105,43 +105,43 @@ 
 			$this->module_name = $subpanel_name;
 		}
 
-		if ($subpanel_name == 'Project'){
+		if ($subpanel_name == 'Project') {
 			$link_field_name = 'project_users_1';
 		}
-		else{
+		else {
 			$link_field_name = $subpanel_definition->get_data_source_name(true);
 		}
 
-		$popup_mode='Single';
-		if(isset($widget_data['mode'])){
-			$popup_mode=$widget_data['mode'];
+		$popup_mode = 'Single';
+		if (isset($widget_data['mode'])) {
+			$popup_mode = $widget_data['mode'];
 		}
-		if(isset($widget_data['initial_filter_fields'])){
+		if (isset($widget_data['initial_filter_fields'])) {
 			if (is_array($widget_data['initial_filter_fields'])) {
 				foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
 					if (isset($focus->$value) and !empty($focus->$value)) {
-						$initial_filter.="&".$alias . '='.urlencode($focus->$value);
+						$initial_filter .= "&".$alias.'='.urlencode($focus->$value);
 					}
 				}
 			}
 		}
 
 		if (!empty($widget_data['filter_out_is_admin'])) {
-            $initial_filter.="&is_admin_advanced=0";
+            $initial_filter .= "&is_admin_advanced=0";
         }
 
-		$create="true";
-		if(isset($widget_data['create'])){
-			$create=$widget_data['create'];
+		$create = "true";
+		if (isset($widget_data['create'])) {
+			$create = $widget_data['create'];
 		}
 		$return_module = $_REQUEST['module'];
 		$return_action = 'SubPanelViewer';
 		$return_id = $_REQUEST['record'];
 
 		//field_to_name_array
-		$fton_array= array('id' => 'subpanel_id');
-		if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
-			$fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
+		$fton_array = array('id' => 'subpanel_id');
+		if (isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])) {
+			$fton_array = array_merge($fton_array, $widget_data['field_to_name_array']);
 		}
 
 		$return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
@@ -160,21 +160,21 @@ 
 		);
 
 		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
-			$popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
+			$popup_request_data['passthru_data'] = array_merge($popup_request_data['passthru_data'], $this->button_properties['add_to_passthru_data']);
 		}
 
 		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
 
-			if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
-				$initial_filter = "&module_name=". urlencode($widget_data['module']);
+			if ($this->button_properties['add_to_passthru_data']['return_type'] == 'report') {
+				$initial_filter = "&module_name=".urlencode($widget_data['module']);
 			}
 		}
 		$json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
 
-		return '<form action="index.php">' . "\n"
-			. ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-				. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
+		return '<form action="index.php">'."\n"
+			. ' <input type="button" name="'.$this->getWidgetId().'" id="'.$this->getWidgetId().'" class="button"'."\"\n"
+				. ' title="'.$this->title.'"'
+			. ' value="'.$this->value."\"\n"
 			. " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
 	}
 }

Braces +4 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -108,8 +110,7 @@ 
 
 		if ($subpanel_name == 'Project'){
 			$link_field_name = 'project_contacts_1';
-		}
-		else{
+		} else{
 			$link_field_name = $subpanel_definition->get_data_source_name(true);
 		}
 

include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php

Indentation +21 added lines, -21 removed lines

@@ -45,33 +45,33 @@
 
 class SugarWidgetSubPanelEditRoleButton extends SugarWidgetField
 {
-	function displayHeaderCell(&$layout_def)
-	{
-		return ' ';
-	}
+    function displayHeaderCell(&$layout_def)
+    {
+        return ' ';
+    }
 
-	function displayList(&$layout_def)
-	{
-		global $app_strings;
+    function displayList(&$layout_def)
+    {
+        global $app_strings;
         global $subpanel_item_count;
         $unique_id = $layout_def['subpanel_id']."_edit_".$subpanel_item_count; //bug 51512
 	
-		$href = 'index.php?module=' . $layout_def['module']
-			. '&action=' . 'ContactOpportunityRelationshipEdit'
-			. '&record=' . $layout_def['fields']['OPPORTUNITY_ROLE_ID']
-			. '&return_module=' . $_REQUEST['module']
-			. '&return_action=' . 'DetailView'
-			. '&return_id=' . $_REQUEST['record'];
+        $href = 'index.php?module=' . $layout_def['module']
+            . '&action=' . 'ContactOpportunityRelationshipEdit'
+            . '&record=' . $layout_def['fields']['OPPORTUNITY_ROLE_ID']
+            . '&return_module=' . $_REQUEST['module']
+            . '&return_action=' . 'DetailView'
+            . '&return_id=' . $_REQUEST['record'];
 			
-	//based on listview since that lets you select records
-	if($layout_def['ListView']){
-		return '<a href="' . $href . '"'
+    //based on listview since that lets you select records
+    if($layout_def['ListView']){
+        return '<a href="' . $href . '"'
             . "id=\"$unique_id\""
-			. 'class="listViewTdToolsS1">' . $app_strings['LNK_EDIT'] .'</a>&nbsp;';
-	}else{
-		return '';
-	}
-	}
+            . 'class="listViewTdToolsS1">' . $app_strings['LNK_EDIT'] .'</a>&nbsp;';
+    }else{
+        return '';
+    }
+    }
 }
 
 ?>
\ No newline at end of file

Spacing +11 added lines, -11 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -56,19 +56,19 @@ 
         global $subpanel_item_count;
         $unique_id = $layout_def['subpanel_id']."_edit_".$subpanel_item_count; //bug 51512
 	
-		$href = 'index.php?module=' . $layout_def['module']
-			. '&action=' . 'ContactOpportunityRelationshipEdit'
-			. '&record=' . $layout_def['fields']['OPPORTUNITY_ROLE_ID']
-			. '&return_module=' . $_REQUEST['module']
-			. '&return_action=' . 'DetailView'
-			. '&return_id=' . $_REQUEST['record'];
+		$href = 'index.php?module='.$layout_def['module']
+			. '&action='.'ContactOpportunityRelationshipEdit'
+			. '&record='.$layout_def['fields']['OPPORTUNITY_ROLE_ID']
+			. '&return_module='.$_REQUEST['module']
+			. '&return_action='.'DetailView'
+			. '&return_id='.$_REQUEST['record'];
 			
 	//based on listview since that lets you select records
-	if($layout_def['ListView']){
-		return '<a href="' . $href . '"'
+	if ($layout_def['ListView']) {
+		return '<a href="'.$href.'"'
             . "id=\"$unique_id\""
-			. 'class="listViewTdToolsS1">' . $app_strings['LNK_EDIT'] .'</a>&nbsp;';
-	}else{
+			. 'class="listViewTdToolsS1">'.$app_strings['LNK_EDIT'].'</a>&nbsp;';
+	} else {
 		return '';
 	}
 	}

Braces +4 added lines, -2 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -68,7 +70,7 @@ 
 		return '<a href="' . $href . '"'
             . "id=\"$unique_id\""
 			. 'class="listViewTdToolsS1">' . $app_strings['LNK_EDIT'] .'</a>&nbsp;';
-	}else{
+	} else{
 		return '';
 	}
 	}

include/generic/SugarWidgets/SugarWidgetFieldparent_type.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -48,9 +48,9 @@ 
     }
    
     function displayListPlain($layout_def) {
-        $value= $this->_get_list_value($layout_def);
-        if (isset($layout_def['widget_type']) && $layout_def['widget_type'] =='checkbox') {
-            if ($value != '' &&  ($value == 'on' || intval($value) == 1 || $value == 'yes'))  
+        $value = $this->_get_list_value($layout_def);
+        if (isset($layout_def['widget_type']) && $layout_def['widget_type'] == 'checkbox') {
+            if ($value != '' && ($value == 'on' || intval($value) == 1 || $value == 'yes'))  
             {
                 return "<input name='checkbox_display' class='checkbox' type='checkbox' disabled='true' checked>";
             }

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelTopCreateNoteButton.php

Indentation +115 added lines, -115 removed lines

@@ -45,121 +45,121 @@
 
 class SugarWidgetSubPanelTopCreateNoteButton extends SugarWidgetSubPanelTopButtonQuickCreate
 {
-	function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
-	{
-		global $app_strings;
-		global $currentModule;
-
-		$this->module="Notes";
-		$this->subpanelDiv = "history";
-
-		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
-		{
-			foreach($this->additional_form_fields as $key=>$value)
-			{
-				if(!empty($defines['focus']->$value))
-				{
-					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
-				{
-					$additionalFormFields[$key] = '';
-				}
-			}
-		}
-
-		if(!empty($this->module))
-		{
-			$defines['child_module_name'] = $this->module;
-		}
-		else
-		{
-			$defines['child_module_name'] = $defines['module'];
-		}
-
-		if(!empty($this->subpanelDiv))
-		{
-			$defines['subpanelDiv'] = $this->subpanelDiv;
-		}
-
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
-
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
-
-		//module_button is used to override the value of module name
-		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
-		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
-
-		if(isset($defines['focus']->name))
-		{
-			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
-		}
-
-		$button .= '<input type="hidden" name="to_pdf" value="true" />';
+    function &_get_form($defines, $additionalFormFields = null, $asUrl = false)
+    {
+        global $app_strings;
+        global $currentModule;
+
+        $this->module="Notes";
+        $this->subpanelDiv = "history";
+
+        // Create the additional form fields with real values if they were not passed in
+        if(empty($additionalFormFields) && $this->additional_form_fields)
+        {
+            foreach($this->additional_form_fields as $key=>$value)
+            {
+                if(!empty($defines['focus']->$value))
+                {
+                    $additionalFormFields[$key] = $defines['focus']->$value;
+                }
+                else
+                {
+                    $additionalFormFields[$key] = '';
+                }
+            }
+        }
+
+        if(!empty($this->module))
+        {
+            $defines['child_module_name'] = $this->module;
+        }
+        else
+        {
+            $defines['child_module_name'] = $defines['module'];
+        }
+
+        if(!empty($this->subpanelDiv))
+        {
+            $defines['subpanelDiv'] = $this->subpanelDiv;
+        }
+
+        $defines['parent_bean_name'] = get_class( $defines['focus']);
+
+        $form = 'form' . $defines['child_module_name'];
+        $button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+
+        //module_button is used to override the value of module name
+        $button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
+        $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
+
+        if(isset($defines['focus']->name))
+        {
+            $button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
+        }
+
+        $button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
-		$button .= '<input type="hidden" name="record" value="" />';
-
-		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
-				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
-			}
-		}
-		if(empty($additionalFormFields['parent_name']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
-				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
-				$additionalFormFields['parent_name'] = $defines['focus']->name;
-			}
-		}
-		if(empty($additionalFormFields['parent_id']))
-		{
-			if($defines['focus']->object_name=='Contact') {
-				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
-				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
-				$additionalFormFields['parent_id'] = $defines['focus']->id;
-			}
-		}
-
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
-
-		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
-		{
-			if($key != 'action')
-			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
-			}
-		}
-
-		return $button;
-	}
-
-
-	function display($defines, $additionalFormFields = null, $nonbutton = false)
-	{
-	    $focus = new Note;
-		if ( !$focus->ACLAccess('EditView') ) {
-		    return '';
-	    }
-
-		return parent::display($defines, $additionalFormFields);
-	}
+        $button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
+        $button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
+        $button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+        $button .= '<input type="hidden" name="record" value="" />';
+
+        // TODO: move this out and get $additionalFormFields working properly
+        if(empty($additionalFormFields['parent_type']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_type'] = 'Accounts';
+            }
+            else {
+                $additionalFormFields['parent_type'] = $defines['focus']->module_dir;
+            }
+        }
+        if(empty($additionalFormFields['parent_name']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_name'] = $defines['focus']->account_name;
+                $additionalFormFields['account_name'] = $defines['focus']->account_name;
+            }
+            else {
+                $additionalFormFields['parent_name'] = $defines['focus']->name;
+            }
+        }
+        if(empty($additionalFormFields['parent_id']))
+        {
+            if($defines['focus']->object_name=='Contact') {
+                $additionalFormFields['parent_id'] = $defines['focus']->account_id;
+                $additionalFormFields['account_id'] = $defines['focus']->account_id;
+            }
+            else {
+                $additionalFormFields['parent_id'] = $defines['focus']->id;
+            }
+        }
+
+        $button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
+        $button .= '<input type="hidden" name="module" value="Home" />' . "\n";
+        $button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+
+        // fill in additional form fields for all but action
+        foreach($additionalFormFields as $key => $value)
+        {
+            if($key != 'action')
+            {
+                $button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+            }
+        }
+
+        return $button;
+    }
+
+
+    function display($defines, $additionalFormFields = null, $nonbutton = false)
+    {
+        $focus = new Note;
+        if ( !$focus->ACLAccess('EditView') ) {
+            return '';
+        }
+
+        return parent::display($defines, $additionalFormFields);
+    }
 }
 ?>

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -50,15 +50,15 @@ 
 		global $app_strings;
 		global $currentModule;
 
-		$this->module="Notes";
+		$this->module = "Notes";
 		$this->subpanelDiv = "history";
 
 		// Create the additional form fields with real values if they were not passed in
-		if(empty($additionalFormFields) && $this->additional_form_fields)
+		if (empty($additionalFormFields) && $this->additional_form_fields)
 		{
-			foreach($this->additional_form_fields as $key=>$value)
+			foreach ($this->additional_form_fields as $key=>$value)
 			{
-				if(!empty($defines['focus']->$value))
+				if (!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
 				}
@@ -69,7 +69,7 @@ 
 			}
 		}
 
-		if(!empty($this->module))
+		if (!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
 		}
@@ -78,45 +78,45 @@ 
 			$defines['child_module_name'] = $defines['module'];
 		}
 
-		if(!empty($this->subpanelDiv))
+		if (!empty($this->subpanelDiv))
 		{
 			$defines['subpanelDiv'] = $this->subpanelDiv;
 		}
 
-		$defines['parent_bean_name'] = get_class( $defines['focus']);
+		$defines['parent_bean_name'] = get_class($defines['focus']);
 
-		$form = 'form' . $defines['child_module_name'];
-		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_' . strtolower($defines['subpanelDiv']) . '\', \'' . addslashes($app_strings['LBL_LOADING']) . '\');" action="index.php" method="post" name="form" id="form' . $form . "\">\n";
+		$form = 'form'.$defines['child_module_name'];
+		$button = '<form onsubmit="return SUGAR.subpanelUtils.sendAndRetrieve(this.id, \'subpanel_'.strtolower($defines['subpanelDiv']).'\', \''.addslashes($app_strings['LBL_LOADING']).'\');" action="index.php" method="post" name="form" id="form'.$form."\">\n";
 
 		//module_button is used to override the value of module name
 		$button .= "<input type='hidden' name='target_module' value='".$defines['child_module_name']."'>\n";
 		$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_id' value='".$defines['focus']->id."'>\n";
 
-		if(isset($defines['focus']->name))
+		if (isset($defines['focus']->name))
 		{
 			$button .= "<input type='hidden' name='".strtolower($defines['parent_bean_name'])."_name' value='".$defines['focus']->name."'>";
 		}
 
 		$button .= '<input type="hidden" name="to_pdf" value="true" />';
         $button .= '<input type="hidden" name="tpl" value="QuickCreate.tpl" />';
-		$button .= '<input type="hidden" name="return_module" value="' . $currentModule . "\" />\n";
-		$button .= '<input type="hidden" name="return_action" value="' . $defines['action'] . "\" />\n";
-		$button .= '<input type="hidden" name="return_id" value="' . $defines['focus']->id . "\" />\n";
+		$button .= '<input type="hidden" name="return_module" value="'.$currentModule."\" />\n";
+		$button .= '<input type="hidden" name="return_action" value="'.$defines['action']."\" />\n";
+		$button .= '<input type="hidden" name="return_id" value="'.$defines['focus']->id."\" />\n";
 		$button .= '<input type="hidden" name="record" value="" />';
 
 		// TODO: move this out and get $additionalFormFields working properly
-		if(empty($additionalFormFields['parent_type']))
+		if (empty($additionalFormFields['parent_type']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
 			}
 			else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
-		if(empty($additionalFormFields['parent_name']))
+		if (empty($additionalFormFields['parent_name']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
 			}
@@ -124,9 +124,9 @@ 
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
-		if(empty($additionalFormFields['parent_id']))
+		if (empty($additionalFormFields['parent_id']))
 		{
-			if($defines['focus']->object_name=='Contact') {
+			if ($defines['focus']->object_name == 'Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
 			}
@@ -135,16 +135,16 @@ 
 			}
 		}
 
-		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />' . "\n";
-		$button .= '<input type="hidden" name="module" value="Home" />' . "\n";
-		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />' . "\n";
+		$button .= '<input type="hidden" name="action" value="SubpanelCreates" />'."\n";
+		$button .= '<input type="hidden" name="module" value="Home" />'."\n";
+		$button .= '<input type="hidden" name="target_action" value="QuickCreate" />'."\n";
 
 		// fill in additional form fields for all but action
-		foreach($additionalFormFields as $key => $value)
+		foreach ($additionalFormFields as $key => $value)
 		{
-			if($key != 'action')
+			if ($key != 'action')
 			{
-				$button .= '<input type="hidden" name="' . $key . '" value="' . $value . '" />' . "\n";
+				$button .= '<input type="hidden" name="'.$key.'" value="'.$value.'" />'."\n";
 			}
 		}
 
@@ -155,7 +155,7 @@ 
 	function display($defines, $additionalFormFields = null, $nonbutton = false)
 	{
 	    $focus = new Note;
-		if ( !$focus->ACLAccess('EditView') ) {
+		if (!$focus->ACLAccess('EditView')) {
 		    return '';
 	    }
 

Braces +8 added lines, -11 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -61,8 +63,7 @@ 
 				if(!empty($defines['focus']->$value))
 				{
 					$additionalFormFields[$key] = $defines['focus']->$value;
-				}
-				else
+				} else
 				{
 					$additionalFormFields[$key] = '';
 				}
@@ -72,8 +73,7 @@ 
 		if(!empty($this->module))
 		{
 			$defines['child_module_name'] = $this->module;
-		}
-		else
+		} else
 		{
 			$defines['child_module_name'] = $defines['module'];
 		}
@@ -109,8 +109,7 @@ 
 		{
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_type'] = 'Accounts';
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_type'] = $defines['focus']->module_dir;
 			}
 		}
@@ -119,8 +118,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_name'] = $defines['focus']->account_name;
 				$additionalFormFields['account_name'] = $defines['focus']->account_name;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_name'] = $defines['focus']->name;
 			}
 		}
@@ -129,8 +127,7 @@ 
 			if($defines['focus']->object_name=='Contact') {
 				$additionalFormFields['parent_id'] = $defines['focus']->account_id;
 				$additionalFormFields['account_id'] = $defines['focus']->account_id;
-			}
-			else {
+			} else {
 				$additionalFormFields['parent_id'] = $defines['focus']->id;
 			}
 		}

include/generic/SugarWidgets/SugarWidgetFieldtext.php

Indentation +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     function queryFilterEquals($layout_def)
     {
         return $this->reporter->db->convert($this->_get_column_select($layout_def), "text2char").
-        	" = ".$this->reporter->db->quoted($layout_def['input_name0']);
+            " = ".$this->reporter->db->quoted($layout_def['input_name0']);
     }
 
     function queryFilterNot_Equals_Str($layout_def)

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -56,7 +56,7 @@ 
     function queryFilterNot_Equals_Str($layout_def)
     {
         $column = $this->_get_column_select($layout_def);
-        return "($column IS NULL OR ". $this->reporter->db->convert($column, "text2char")." != ".
+        return "($column IS NULL OR ".$this->reporter->db->convert($column, "text2char")." != ".
             $this->reporter->db->quoted($layout_def['input_name0']).")";
     }
 

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

include/generic/SugarWidgets/SugarWidgetSubPanelTopSelectContactsButton.php

Indentation +122 added lines, -122 removed lines

@@ -45,133 +45,133 @@
 
 class SugarWidgetSubPanelTopSelectContactsButton extends SugarWidgetSubPanelTopSelectButton
 {
-	//button_properties is a collection of properties associated with the widget_class definition. layoutmanager
-	function SugarWidgetSubPanelTopSelectContactsButton($button_properties=array())
-	{
-		$this->button_properties=$button_properties;
-	}
+    //button_properties is a collection of properties associated with the widget_class definition. layoutmanager
+    function SugarWidgetSubPanelTopSelectContactsButton($button_properties=array())
+    {
+        $this->button_properties=$button_properties;
+    }
 
     public function getWidgetId($buttonSuffix = true)
     {
         return parent::getWidgetId() . '_select_button';
     }
 
-	//widget_data is the collection of attributes associated with the button in the layout_defs file.
-	function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
-	{
-		global $app_strings;
-		$initial_filter = '';
-
-		$this->title = $app_strings['LBL_SELECT_CONTACT_BUTTON_TITLE'];
-		//$this->accesskey = $app_strings['LBL_SELECT_CONTACT_BUTTON_KEY'];
-		$this->value = $app_strings['LBL_SELECT_CONTACT_BUTTON_LABEL'];
-
-		$this->module_name = 'Contacts';
-
-		if (is_array($this->button_properties)) {
-			if( isset($this->button_properties['title'])) {
-				$this->title = $app_strings[$this->button_properties['title']];
-			}
-			if( isset($this->button_properties['accesskey'])) {
-				//$this->accesskey = $app_strings[$this->button_properties['accesskey']];
-			}
-			if( isset($this->button_properties['form_value'])) {
-				$this->value = $app_strings[$this->button_properties['form_value']];
-			}
-			if( isset($this->button_properties['module'])) {
-				$this->module_name = $this->button_properties['module'];
-			}
-		}
-
-		$focus = $widget_data['focus'];
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
-			$button = ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-			. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
-			.' disabled />';
-			return $button;
-		}
-
-		//refresh the whole page after end of action?
-		$refresh_page = 0;
-		if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
-			$refresh_page = 1;
-		}
-
-		$subpanel_definition = $widget_data['subpanel_definition'];
-
-		$button_definition = $subpanel_definition->get_buttons();
-		$subpanel_name = $subpanel_definition->get_module_name();
-		if (empty($this->module_name)) {
-			$this->module_name = $subpanel_name;
-		}
-
-		if ($subpanel_name == 'Project'){
-			$link_field_name = 'project_contacts_1';
-		}
-		else{
-			$link_field_name = $subpanel_definition->get_data_source_name(true);
-		}
-
-		$popup_mode='Single';
-		if(isset($widget_data['mode'])){
-			$popup_mode=$widget_data['mode'];
-		}
-		if(isset($widget_data['initial_filter_fields'])){
-			if (is_array($widget_data['initial_filter_fields'])) {
-				foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
-					if (isset($focus->$value) and !empty($focus->$value)) {
-						$initial_filter.="&".$alias . '='.urlencode($focus->$value);
-					}
-				}
-			}
-		}
-		$create="true";
-		if(isset($widget_data['create'])){
-			$create=$widget_data['create'];
-		}
-		$return_module = $_REQUEST['module'];
-		$return_action = 'SubPanelViewer';
-		$return_id = $_REQUEST['record'];
-
-		//field_to_name_array
-		$fton_array= array('id' => 'subpanel_id');
-		if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
-			$fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
-		}
-
-		$return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
-
-		$popup_request_data = array(
-			'call_back_function' => 'set_return_and_save_background',
-			'form_name' => 'DetailView',
-			'field_to_name_array' => $fton_array,
-			'passthru_data' => array(
-				'child_field' => $this->module_name,
-				'return_url' => urlencode($return_url),
-				'link_field_name' => $link_field_name,
-				'module_name' => $this->module_name,
-				'refresh_page' => 1,
-			),
-		);
-
-		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
-			$popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
-		}
-
-		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
-
-			if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
-				$initial_filter = "&module_name=". urlencode($widget_data['module']);
-			}
-		}
-		$json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
-
-		return '<form action="index.php">' . "\n"
-			. ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-				. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
-			. " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
-	}
+    //widget_data is the collection of attributes associated with the button in the layout_defs file.
+    function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
+    {
+        global $app_strings;
+        $initial_filter = '';
+
+        $this->title = $app_strings['LBL_SELECT_CONTACT_BUTTON_TITLE'];
+        //$this->accesskey = $app_strings['LBL_SELECT_CONTACT_BUTTON_KEY'];
+        $this->value = $app_strings['LBL_SELECT_CONTACT_BUTTON_LABEL'];
+
+        $this->module_name = 'Contacts';
+
+        if (is_array($this->button_properties)) {
+            if( isset($this->button_properties['title'])) {
+                $this->title = $app_strings[$this->button_properties['title']];
+            }
+            if( isset($this->button_properties['accesskey'])) {
+                //$this->accesskey = $app_strings[$this->button_properties['accesskey']];
+            }
+            if( isset($this->button_properties['form_value'])) {
+                $this->value = $app_strings[$this->button_properties['form_value']];
+            }
+            if( isset($this->button_properties['module'])) {
+                $this->module_name = $this->button_properties['module'];
+            }
+        }
+
+        $focus = $widget_data['focus'];
+        if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
+            $button = ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
+            . ' title="' . $this->title . '"'
+            . ' value="' . $this->value . "\"\n"
+            .' disabled />';
+            return $button;
+        }
+
+        //refresh the whole page after end of action?
+        $refresh_page = 0;
+        if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
+            $refresh_page = 1;
+        }
+
+        $subpanel_definition = $widget_data['subpanel_definition'];
+
+        $button_definition = $subpanel_definition->get_buttons();
+        $subpanel_name = $subpanel_definition->get_module_name();
+        if (empty($this->module_name)) {
+            $this->module_name = $subpanel_name;
+        }
+
+        if ($subpanel_name == 'Project'){
+            $link_field_name = 'project_contacts_1';
+        }
+        else{
+            $link_field_name = $subpanel_definition->get_data_source_name(true);
+        }
+
+        $popup_mode='Single';
+        if(isset($widget_data['mode'])){
+            $popup_mode=$widget_data['mode'];
+        }
+        if(isset($widget_data['initial_filter_fields'])){
+            if (is_array($widget_data['initial_filter_fields'])) {
+                foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
+                    if (isset($focus->$value) and !empty($focus->$value)) {
+                        $initial_filter.="&".$alias . '='.urlencode($focus->$value);
+                    }
+                }
+            }
+        }
+        $create="true";
+        if(isset($widget_data['create'])){
+            $create=$widget_data['create'];
+        }
+        $return_module = $_REQUEST['module'];
+        $return_action = 'SubPanelViewer';
+        $return_id = $_REQUEST['record'];
+
+        //field_to_name_array
+        $fton_array= array('id' => 'subpanel_id');
+        if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
+            $fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
+        }
+
+        $return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
+
+        $popup_request_data = array(
+            'call_back_function' => 'set_return_and_save_background',
+            'form_name' => 'DetailView',
+            'field_to_name_array' => $fton_array,
+            'passthru_data' => array(
+                'child_field' => $this->module_name,
+                'return_url' => urlencode($return_url),
+                'link_field_name' => $link_field_name,
+                'module_name' => $this->module_name,
+                'refresh_page' => 1,
+            ),
+        );
+
+        if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
+            $popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
+        }
+
+        if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
+
+            if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
+                $initial_filter = "&module_name=". urlencode($widget_data['module']);
+            }
+        }
+        $json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
+
+        return '<form action="index.php">' . "\n"
+            . ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
+                . ' title="' . $this->title . '"'
+            . ' value="' . $this->value . "\"\n"
+            . " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
+    }
 }
 ?>

Spacing +33 added lines, -33 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -46,14 +46,14 @@ 
 class SugarWidgetSubPanelTopSelectContactsButton extends SugarWidgetSubPanelTopSelectButton
 {
 	//button_properties is a collection of properties associated with the widget_class definition. layoutmanager
-	function SugarWidgetSubPanelTopSelectContactsButton($button_properties=array())
+	function SugarWidgetSubPanelTopSelectContactsButton($button_properties = array())
 	{
-		$this->button_properties=$button_properties;
+		$this->button_properties = $button_properties;
 	}
 
     public function getWidgetId($buttonSuffix = true)
     {
-        return parent::getWidgetId() . '_select_button';
+        return parent::getWidgetId().'_select_button';
     }
 
 	//widget_data is the collection of attributes associated with the button in the layout_defs file.
@@ -69,32 +69,32 @@ 
 		$this->module_name = 'Contacts';
 
 		if (is_array($this->button_properties)) {
-			if( isset($this->button_properties['title'])) {
+			if (isset($this->button_properties['title'])) {
 				$this->title = $app_strings[$this->button_properties['title']];
 			}
-			if( isset($this->button_properties['accesskey'])) {
+			if (isset($this->button_properties['accesskey'])) {
 				//$this->accesskey = $app_strings[$this->button_properties['accesskey']];
 			}
-			if( isset($this->button_properties['form_value'])) {
+			if (isset($this->button_properties['form_value'])) {
 				$this->value = $app_strings[$this->button_properties['form_value']];
 			}
-			if( isset($this->button_properties['module'])) {
+			if (isset($this->button_properties['module'])) {
 				$this->module_name = $this->button_properties['module'];
 			}
 		}
 
 		$focus = $widget_data['focus'];
-		if(ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)){
-			$button = ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-			. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
+		if (ACLController::moduleSupportsACL($widget_data['module']) && !ACLController::checkAccess($widget_data['module'], 'list', true)) {
+			$button = ' <input type="button" name="'.$this->getWidgetId().'" id="'.$this->getWidgetId().'" class="button"'."\"\n"
+			. ' title="'.$this->title.'"'
+			. ' value="'.$this->value."\"\n"
 			.' disabled />';
 			return $button;
 		}
 
 		//refresh the whole page after end of action?
 		$refresh_page = 0;
-		if(!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])){
+		if (!empty($widget_data['subpanel_definition']->_instance_properties['refresh_page'])) {
 			$refresh_page = 1;
 		}
 
@@ -106,38 +106,38 @@ 
 			$this->module_name = $subpanel_name;
 		}
 
-		if ($subpanel_name == 'Project'){
+		if ($subpanel_name == 'Project') {
 			$link_field_name = 'project_contacts_1';
 		}
-		else{
+		else {
 			$link_field_name = $subpanel_definition->get_data_source_name(true);
 		}
 
-		$popup_mode='Single';
-		if(isset($widget_data['mode'])){
-			$popup_mode=$widget_data['mode'];
+		$popup_mode = 'Single';
+		if (isset($widget_data['mode'])) {
+			$popup_mode = $widget_data['mode'];
 		}
-		if(isset($widget_data['initial_filter_fields'])){
+		if (isset($widget_data['initial_filter_fields'])) {
 			if (is_array($widget_data['initial_filter_fields'])) {
 				foreach ($widget_data['initial_filter_fields'] as $value=>$alias) {
 					if (isset($focus->$value) and !empty($focus->$value)) {
-						$initial_filter.="&".$alias . '='.urlencode($focus->$value);
+						$initial_filter .= "&".$alias.'='.urlencode($focus->$value);
 					}
 				}
 			}
 		}
-		$create="true";
-		if(isset($widget_data['create'])){
-			$create=$widget_data['create'];
+		$create = "true";
+		if (isset($widget_data['create'])) {
+			$create = $widget_data['create'];
 		}
 		$return_module = $_REQUEST['module'];
 		$return_action = 'SubPanelViewer';
 		$return_id = $_REQUEST['record'];
 
 		//field_to_name_array
-		$fton_array= array('id' => 'subpanel_id');
-		if(isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])){
-			$fton_array=array_merge($fton_array,$widget_data['field_to_name_array']);
+		$fton_array = array('id' => 'subpanel_id');
+		if (isset($widget_data['field_to_name_array']) && is_array($widget_data['field_to_name_array'])) {
+			$fton_array = array_merge($fton_array, $widget_data['field_to_name_array']);
 		}
 
 		$return_url = "index.php?module=$return_module&action=$return_action&subpanel=$subpanel_name&record=$return_id&sugar_body_only=1";
@@ -156,21 +156,21 @@ 
 		);
 
 		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data'])) {
-			$popup_request_data['passthru_data']= array_merge($popup_request_data['passthru_data'],$this->button_properties['add_to_passthru_data']);
+			$popup_request_data['passthru_data'] = array_merge($popup_request_data['passthru_data'], $this->button_properties['add_to_passthru_data']);
 		}
 
 		if (is_array($this->button_properties) && !empty($this->button_properties['add_to_passthru_data']['return_type'])) {
 
-			if ($this->button_properties['add_to_passthru_data']['return_type']=='report') {
-				$initial_filter = "&module_name=". urlencode($widget_data['module']);
+			if ($this->button_properties['add_to_passthru_data']['return_type'] == 'report') {
+				$initial_filter = "&module_name=".urlencode($widget_data['module']);
 			}
 		}
 		$json_encoded_php_array = $this->_create_json_encoded_popup_request($popup_request_data);
 
-		return '<form action="index.php">' . "\n"
-			. ' <input type="button" name="' .$this->getWidgetId() . '" id="' .$this->getWidgetId() . '" class="button"' . "\"\n"
-				. ' title="' . $this->title . '"'
-			. ' value="' . $this->value . "\"\n"
+		return '<form action="index.php">'."\n"
+			. ' <input type="button" name="'.$this->getWidgetId().'" id="'.$this->getWidgetId().'" class="button"'."\"\n"
+				. ' title="'.$this->title.'"'
+			. ' value="'.$this->value."\"\n"
 			. " onclick='open_popup(\"$this->module_name\",600,400,\"$initial_filter\",true,true,$json_encoded_php_array,\"$popup_mode\",$create);' /></form>\n";
 	}
 }

Braces +4 added lines, -3 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -108,8 +110,7 @@ 
 
 		if ($subpanel_name == 'Project'){
 			$link_field_name = 'project_contacts_1';
-		}
-		else{
+		} else{
 			$link_field_name = $subpanel_definition->get_data_source_name(true);
 		}
 

include/generic/SugarWidgets/SugarWidgetSubPanelTopSelectAccountButton.php

Indentation +9 added lines, -9 removed lines

@@ -44,21 +44,21 @@
 
 
 class SugarWidgetSubPanelTopSelectAccountButton extends SugarWidgetSubPanelTopSelectButton {
-	function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
-	{
-		/*
+    function display($widget_data, $additionalFormFields = NULL, $nonbutton = false)
+    {
+        /*
 		* i.dymovsky
 		* Because when user role can't edit Accounts, it also can't edit Membership Organizations. Select button leads to change MO list
 		* See bug 25633
 		* Bug25633 code change start
 		*/
-		if (!ACLController::checkAccess($widget_data["module"], "edit", true)) {
-			return ;
-		}
-		/*
+        if (!ACLController::checkAccess($widget_data["module"], "edit", true)) {
+            return ;
+        }
+        /*
 		* Bug25633 code change end
 		*/
 		
-		return parent::display($widget_data);
-	}
+        return parent::display($widget_data);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -53,7 +53,7 @@ 
 		* Bug25633 code change start
 		*/
 		if (!ACLController::checkAccess($widget_data["module"], "edit", true)) {
-			return ;
+			return;
 		}
 		/*
 		* Bug25633 code change end

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.