adamjakab / SuiteCRM

modules/ModuleBuilder/views/view.wizard.php

Indentation +285 added lines, -285 removed lines

@@ -43,301 +43,301 @@
 
 class ModuleBuilderViewWizard extends SugarView
 {
-	private $view = null ; // the wizard view to display
-	private $actions ;
-	private $buttons ;
-	private $question ;
-	private $title ;
-	private $help ;
-
-	private $editModule ;
-
-	function __construct()
-	{
-		if ( isset ( $_REQUEST [ 'view' ] ) )
-			$this->view = $_REQUEST [ 'view' ] ;
-
-		$this->editModule = (! empty ( $_REQUEST [ 'view_module' ] ) ) ? $_REQUEST [ 'view_module' ] : null ;
-		$this->buttons = array(); // initialize so that modules without subpanels for example don't result in this being unset and causing problems in the smarty->assign
-	}
+    private $view = null ; // the wizard view to display
+    private $actions ;
+    private $buttons ;
+    private $question ;
+    private $title ;
+    private $help ;
+
+    private $editModule ;
+
+    function __construct()
+    {
+        if ( isset ( $_REQUEST [ 'view' ] ) )
+            $this->view = $_REQUEST [ 'view' ] ;
+
+        $this->editModule = (! empty ( $_REQUEST [ 'view_module' ] ) ) ? $_REQUEST [ 'view_module' ] : null ;
+        $this->buttons = array(); // initialize so that modules without subpanels for example don't result in this being unset and causing problems in the smarty->assign
+    }
 	
-	/**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+    /**
+     * @see SugarView::_getModuleTitleParams()
+     */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
+    }
+
+    function display()
+    {
+        $this->ajax = new AjaxCompose ( ) ;
+        $smarty = new Sugar_Smarty ( ) ;
+
+        if (isset ( $_REQUEST [ 'MB' ] ))
+        {
+            $this->processMB ( $this->ajax ) ;
+        } else
+        {
+
+                $this->processStudio ( $this->ajax ) ;
+
+        }
+
+        $smarty->assign ( 'buttons', $this->buttons ) ;
+        $smarty->assign ( 'image_path', $GLOBALS [ 'image_path' ] ) ;
+        $smarty->assign ( "title", $this->title ) ;
+        $smarty->assign ( "question", $this->question ) ;
+        $smarty->assign ( "defaultHelp", $this->help ) ;
+        $smarty->assign ( "actions", $this->actions ) ;
+
+        $this->ajax->addSection ( 'center', $this->title, $smarty->fetch ( 'modules/ModuleBuilder/tpls/wizard.tpl' ) ) ;
+        echo $this->ajax->getJavascript () ;
     }
 
-	function display()
-	{
-		$this->ajax = new AjaxCompose ( ) ;
-		$smarty = new Sugar_Smarty ( ) ;
-
-		if (isset ( $_REQUEST [ 'MB' ] ))
-		{
-			$this->processMB ( $this->ajax ) ;
-		} else
-		{
-
-				$this->processStudio ( $this->ajax ) ;
-
-		}
-
-		$smarty->assign ( 'buttons', $this->buttons ) ;
-		$smarty->assign ( 'image_path', $GLOBALS [ 'image_path' ] ) ;
-		$smarty->assign ( "title", $this->title ) ;
-		$smarty->assign ( "question", $this->question ) ;
-		$smarty->assign ( "defaultHelp", $this->help ) ;
-		$smarty->assign ( "actions", $this->actions ) ;
-
-		$this->ajax->addSection ( 'center', $this->title, $smarty->fetch ( 'modules/ModuleBuilder/tpls/wizard.tpl' ) ) ;
-		echo $this->ajax->getJavascript () ;
-	}
-
-	function processStudio( 
-	    $ajax
-	    )
-	{
-
-		$this->ajax->addCrumb ( translate( 'LBL_STUDIO' ), 'ModuleBuilder.main("studio")' ) ;
-
-		if (! isset ( $this->editModule ))
-		{
-			//Studio Select Module Page
-			$this->generateStudioModuleButtons () ;
-			$this->question = translate('LBL_QUESTION_EDIT') ;
-			$this->title = translate( 'LBL_STUDIO' );
-			global $current_user;
-			if (is_admin($current_user))
-				$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
-
-			$this->help = 'studioHelp' ;
-		} else
-		{
-			$module = StudioModuleFactory::getStudioModule( $this->editModule ) ;
-			$this->ajax->addCrumb ( $module->name, !empty($this->view) ? 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module=' . $this->editModule . '")' : '' ) ;
-			switch ( $this->view )
-			{
-				case 'layouts':
-					//Studio Select Layout page
-					$this->buttons = $module->getLayouts() ;
-					$this->title = $module->name . " " . translate('LBL_LAYOUTS') ;
-					$this->question = translate( 'LBL_QUESTION_LAYOUT' ) ;
-					$this->help = 'layoutsHelp' ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), '' ) ;
-					break;
-
-
-				case 'subpanels':
-					//Studio Select Subpanel page.
-					$this->buttons = $module->getSubpanels() ;
-					$this->title = $module->name . " " . translate( 'LBL_SUBPANELS' ) ;
-					$this->question = translate( 'LBL_QUESTION_SUBPANEL' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_SUBPANELS' ), '' ) ;
-					$this->help = 'subpanelHelp' ;
-					break;
-
-				case 'search':
-					//Studio Select Search Layout page.
-					$this->buttons = $module->getSearch() ;
-					$this->title = $module->name . " " . translate('LBL_SEARCH');
-					$this->question = translate( 'LBL_QUESTION_SEARCH' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_SEARCH' ), '' ) ;
-					$this->help = 'searchHelp' ;
-					break;
-
-				case 'dashlet':
-					$this->generateStudioDashletButtons();
-					$this->title = $this->editModule ." " .translate('LBL_DASHLET');
-					$this->question = translate( 'LBL_QUESTION_DASHLET' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_DASHLET' ), '' ) ;
-					$this->help = 'dashletHelp' ;
-					break;
+    function processStudio( 
+        $ajax
+        )
+    {
+
+        $this->ajax->addCrumb ( translate( 'LBL_STUDIO' ), 'ModuleBuilder.main("studio")' ) ;
+
+        if (! isset ( $this->editModule ))
+        {
+            //Studio Select Module Page
+            $this->generateStudioModuleButtons () ;
+            $this->question = translate('LBL_QUESTION_EDIT') ;
+            $this->title = translate( 'LBL_STUDIO' );
+            global $current_user;
+            if (is_admin($current_user))
+                $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
+
+            $this->help = 'studioHelp' ;
+        } else
+        {
+            $module = StudioModuleFactory::getStudioModule( $this->editModule ) ;
+            $this->ajax->addCrumb ( $module->name, !empty($this->view) ? 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module=' . $this->editModule . '")' : '' ) ;
+            switch ( $this->view )
+            {
+                case 'layouts':
+                    //Studio Select Layout page
+                    $this->buttons = $module->getLayouts() ;
+                    $this->title = $module->name . " " . translate('LBL_LAYOUTS') ;
+                    $this->question = translate( 'LBL_QUESTION_LAYOUT' ) ;
+                    $this->help = 'layoutsHelp' ;
+                    $this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), '' ) ;
+                    break;
+
+
+                case 'subpanels':
+                    //Studio Select Subpanel page.
+                    $this->buttons = $module->getSubpanels() ;
+                    $this->title = $module->name . " " . translate( 'LBL_SUBPANELS' ) ;
+                    $this->question = translate( 'LBL_QUESTION_SUBPANEL' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_SUBPANELS' ), '' ) ;
+                    $this->help = 'subpanelHelp' ;
+                    break;
+
+                case 'search':
+                    //Studio Select Search Layout page.
+                    $this->buttons = $module->getSearch() ;
+                    $this->title = $module->name . " " . translate('LBL_SEARCH');
+                    $this->question = translate( 'LBL_QUESTION_SEARCH' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_SEARCH' ), '' ) ;
+                    $this->help = 'searchHelp' ;
+                    break;
+
+                case 'dashlet':
+                    $this->generateStudioDashletButtons();
+                    $this->title = $this->editModule ." " .translate('LBL_DASHLET');
+                    $this->question = translate( 'LBL_QUESTION_DASHLET' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_DASHLET' ), '' ) ;
+                    $this->help = 'dashletHelp' ;
+                    break;
 				
-				case 'popup':
-					$this->generateStudioPopupButtons();
-					$this->title = $this->editModule ." " .translate('LBL_POPUP');
-					$this->question = translate( 'LBL_QUESTION_POPUP' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_POPUP' ), '' ) ;
-					$this->help = 'popupHelp' ;
-					break;
-				default:
-					//Studio Edit Module Page
-					$this->buttons = $module->getModule () ;
-					$this->question = translate( 'LBL_QUESTION_MODULE' ) ;
-					$this->title = translate( 'LBL_EDIT' ) . " " . $module->name ;
-					$this->help = 'moduleHelp' ;
-					global $current_user;
-					if (is_admin($current_user))
+                case 'popup':
+                    $this->generateStudioPopupButtons();
+                    $this->title = $this->editModule ." " .translate('LBL_POPUP');
+                    $this->question = translate( 'LBL_QUESTION_POPUP' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
+                    $this->ajax->addCrumb ( translate( 'LBL_POPUP' ), '' ) ;
+                    $this->help = 'popupHelp' ;
+                    break;
+                default:
+                    //Studio Edit Module Page
+                    $this->buttons = $module->getModule () ;
+                    $this->question = translate( 'LBL_QUESTION_MODULE' ) ;
+                    $this->title = translate( 'LBL_EDIT' ) . " " . $module->name ;
+                    $this->help = 'moduleHelp' ;
+                    global $current_user;
+                    if (is_admin($current_user))
                         $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" " 
                         . "onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=resetmodule&view_module=$this->editModule');\" value=\"" 
                         . translate( 'LBL_RESET_MODULE' ) . '">' ;
-			}
-		}
-	}
-
-	function processMB ( 
-	    $ajax 
-	    )
-	{
-		if (! isset ( $_REQUEST [ 'view_package' ] ))
-		{
-			sugar_die ( "no ModuleBuilder package set" ) ;
-		}
-
-		$this->editModule = $_REQUEST [ 'view_module' ] ;
-		$this->package = $_REQUEST [ 'view_package' ] ;
-
-		$ajax->addCrumb ( translate ( 'LBL_MODULEBUILDER', 'ModuleBuilder' ), 'ModuleBuilder.main("mb")' ) ;
-		$ajax->addCrumb ( $this->package, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&view_package=' . $this->package . '")' ) ;
-		$ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '&view_package=' . $this->package . '")') ;
-
-		switch ( $this->view )
-		{
-			case 'search':
-				//MB Select Search Layout page.
-				$this->generateMBSearchButtons () ;
-				$this->title = $this->editModule . " " . translate( 'LBL_SEARCH' ) ;
-				$this->question = translate( 'LBL_QUESTION_SEARCH' ) ;
-				$ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view_module=' . $this->editModule . '&view_package=' . $this->package . '")' ) ;
-				$ajax->addCrumb ( translate( 'LBL_SEARCH_FORMS' ), '' ) ;
-				$this->help = "searchHelp" ;
-				break;
-
-			case 'subpanel':
-				//ModuleBuilder Select Subpanel
-				$ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '&view_package=' . $this->package . '")' ) ;
-				$ajax->addCrumb ( translate( 'LBL_SUBPANELS' ), '' ) ;
-				$this->question = translate( 'LBL_QUESTION_SUBPANEL' ) ;
-				$this->help = 'subpanelHelp' ;
-				break;
-
-			case 'dashlet':
-				$this->generateMBDashletButtons ();
-				$this->title = $this->editModule ." " .translate('LBL_DASHLET');
-				$this->question = translate( 'LBL_QUESTION_DASHLET' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module=' . $this->editModule . '")' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_DASHLET' ), '' ) ;
-				$this->help = 'dashletHelp' ;
-				break;
-
-
-			case 'popup':
-				$this->generateMBPopupButtons();
-				$this->title = $this->editModule ." " .translate('LBL_POPUP');
-				$this->question = translate( 'LBL_QUESTION_POPUP' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module=' . $this->editModule . '")' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_POPUP' ), '' ) ;
-				$this->help = 'popupHelp' ;
-				break;
-			default:
-				$ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), '' ) ;
-				$this->generateMBViewButtons () ;
-				$this->title = $this->editModule . " " . translate( 'LBL_LAYOUTS' ) ;
-				$this->question = translate( 'LBL_QUESTION_LAYOUT' ) ;
-				$this->help = "layoutsHelp" ;
-		}
-	}
-
-
-	function generateStudioModuleButtons()
-	{
-		require_once ('modules/ModuleBuilder/Module/StudioBrowser.php') ;
-		$sb = new StudioBrowser ( ) ;
-		$sb->loadModules () ;
-		$nodes = $sb->getNodes () ;
-		$this->buttons = array ( ) ;
-		//$GLOBALS['log']->debug(print_r($nodes,true));
-		foreach ( $nodes as $module )
-		{
-			$this->buttons [ $module [ 'name' ] ] = array ( 'action' => $module [ 'action' ] , 'imageTitle' => ucfirst ( $module [ 'module' ] . "_32" ) , 'size' => '32', 'linkId' => 'studiolink_'.$module [ 'module' ] ) ;
-		}
-	}
-
-
-
-	function generateMBViewButtons()
-	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_EDITVIEW' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_EDITVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'EditView', 
-		      'help'=>'viewBtnEditView'
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_DETAILVIEW' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_DETAILVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'DetailView', 
-		      'help'=>'viewBtnListView'  
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_LISTVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'ListView', 
-		      'help'=>'viewBtnListView' 
-		  ) ;
-		  $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_QUICKCREATE' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_QUICKCREATE."&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'QuickCreate', 
-		      'help'=>'viewBtnQuickCreate' 
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_SEARCH' ] ] = 
-		  array (
-		      'action' => "module=ModuleBuilder&MB=true&action=wizard&view=search&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'SearchForm' , 
-		      'help'=> 'searchBtn' 
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_DASHLET' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=wizard&view=dashlet&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'Dashlet', 
-		      'help'=>'viewBtnDashlet' 
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] ['LBL_POPUP'] ] = 
-		array ( 
-			'imageTitle' => 'Popup',  
-			'action' => "module=ModuleBuilder&MB=true&action=wizard&view=popup&view_module={$this->editModule}&view_package={$this->package}", 
-			'help'=>'PopupListViewBtn'
-		);  
-	}
-
-	function generateMBDashletButtons() 
-	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashlet&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETSEARCHVIEW' ] ] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashletsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch','help'=> 'DashletSearchViewBtn');
-	}
+            }
+        }
+    }
+
+    function processMB ( 
+        $ajax 
+        )
+    {
+        if (! isset ( $_REQUEST [ 'view_package' ] ))
+        {
+            sugar_die ( "no ModuleBuilder package set" ) ;
+        }
+
+        $this->editModule = $_REQUEST [ 'view_module' ] ;
+        $this->package = $_REQUEST [ 'view_package' ] ;
+
+        $ajax->addCrumb ( translate ( 'LBL_MODULEBUILDER', 'ModuleBuilder' ), 'ModuleBuilder.main("mb")' ) ;
+        $ajax->addCrumb ( $this->package, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&view_package=' . $this->package . '")' ) ;
+        $ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '&view_package=' . $this->package . '")') ;
+
+        switch ( $this->view )
+        {
+            case 'search':
+                //MB Select Search Layout page.
+                $this->generateMBSearchButtons () ;
+                $this->title = $this->editModule . " " . translate( 'LBL_SEARCH' ) ;
+                $this->question = translate( 'LBL_QUESTION_SEARCH' ) ;
+                $ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view_module=' . $this->editModule . '&view_package=' . $this->package . '")' ) ;
+                $ajax->addCrumb ( translate( 'LBL_SEARCH_FORMS' ), '' ) ;
+                $this->help = "searchHelp" ;
+                break;
+
+            case 'subpanel':
+                //ModuleBuilder Select Subpanel
+                $ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '&view_package=' . $this->package . '")' ) ;
+                $ajax->addCrumb ( translate( 'LBL_SUBPANELS' ), '' ) ;
+                $this->question = translate( 'LBL_QUESTION_SUBPANEL' ) ;
+                $this->help = 'subpanelHelp' ;
+                break;
+
+            case 'dashlet':
+                $this->generateMBDashletButtons ();
+                $this->title = $this->editModule ." " .translate('LBL_DASHLET');
+                $this->question = translate( 'LBL_QUESTION_DASHLET' ) ;
+                $this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module=' . $this->editModule . '")' ) ;
+                $this->ajax->addCrumb ( translate( 'LBL_DASHLET' ), '' ) ;
+                $this->help = 'dashletHelp' ;
+                break;
+
+
+            case 'popup':
+                $this->generateMBPopupButtons();
+                $this->title = $this->editModule ." " .translate('LBL_POPUP');
+                $this->question = translate( 'LBL_QUESTION_POPUP' ) ;
+                $this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module=' . $this->editModule . '")' ) ;
+                $this->ajax->addCrumb ( translate( 'LBL_POPUP' ), '' ) ;
+                $this->help = 'popupHelp' ;
+                break;
+            default:
+                $ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), '' ) ;
+                $this->generateMBViewButtons () ;
+                $this->title = $this->editModule . " " . translate( 'LBL_LAYOUTS' ) ;
+                $this->question = translate( 'LBL_QUESTION_LAYOUT' ) ;
+                $this->help = "layoutsHelp" ;
+        }
+    }
+
+
+    function generateStudioModuleButtons()
+    {
+        require_once ('modules/ModuleBuilder/Module/StudioBrowser.php') ;
+        $sb = new StudioBrowser ( ) ;
+        $sb->loadModules () ;
+        $nodes = $sb->getNodes () ;
+        $this->buttons = array ( ) ;
+        //$GLOBALS['log']->debug(print_r($nodes,true));
+        foreach ( $nodes as $module )
+        {
+            $this->buttons [ $module [ 'name' ] ] = array ( 'action' => $module [ 'action' ] , 'imageTitle' => ucfirst ( $module [ 'module' ] . "_32" ) , 'size' => '32', 'linkId' => 'studiolink_'.$module [ 'module' ] ) ;
+        }
+    }
+
+
+
+    function generateMBViewButtons()
+    {
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_EDITVIEW' ] ] = 
+            array ( 
+                'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_EDITVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
+                'imageTitle' => 'EditView', 
+                'help'=>'viewBtnEditView'
+            ) ;
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_DETAILVIEW' ] ] = 
+            array ( 
+                'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_DETAILVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
+                'imageTitle' => 'DetailView', 
+                'help'=>'viewBtnListView'  
+            ) ;
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW' ] ] = 
+            array ( 
+                'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_LISTVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
+                'imageTitle' => 'ListView', 
+                'help'=>'viewBtnListView' 
+            ) ;
+            $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_QUICKCREATE' ] ] = 
+            array ( 
+                'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_QUICKCREATE."&view_module={$this->editModule}&view_package={$this->package}" , 
+                'imageTitle' => 'QuickCreate', 
+                'help'=>'viewBtnQuickCreate' 
+            ) ;
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_SEARCH' ] ] = 
+            array (
+                'action' => "module=ModuleBuilder&MB=true&action=wizard&view=search&view_module={$this->editModule}&view_package={$this->package}" , 
+                'imageTitle' => 'SearchForm' , 
+                'help'=> 'searchBtn' 
+            ) ;
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_DASHLET' ] ] = 
+            array ( 
+                'action' => "module=ModuleBuilder&MB=true&action=wizard&view=dashlet&view_module={$this->editModule}&view_package={$this->package}" , 
+                'imageTitle' => 'Dashlet', 
+                'help'=>'viewBtnDashlet' 
+            ) ;
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] ['LBL_POPUP'] ] = 
+        array ( 
+            'imageTitle' => 'Popup',  
+            'action' => "module=ModuleBuilder&MB=true&action=wizard&view=popup&view_module={$this->editModule}&view_package={$this->package}", 
+            'help'=>'PopupListViewBtn'
+        );  
+    }
+
+    function generateMBDashletButtons() 
+    {
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashlet&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETSEARCHVIEW' ] ] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashletsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch','help'=> 'DashletSearchViewBtn');
+    }
 	
-	function generateMBPopupButtons() 
-	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPSEARCH' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch','help'=> 'PopupSearchViewBtn');
-	}
+    function generateMBPopupButtons() 
+    {
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPSEARCH' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch','help'=> 'PopupSearchViewBtn');
+    }
 	
-	function generateStudioDashletButtons() 
-	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashlet&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETSEARCHVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashletsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch','help'=> 'DashletSearchViewBtn');
-	}
+    function generateStudioDashletButtons() 
+    {
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashlet&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETSEARCHVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashletsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch','help'=> 'DashletSearchViewBtn');
+    }
 	
-	function generateStudioPopupButtons()
-	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPSEARCH' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch','help'=> 'PopupSearchViewBtn');
-	}
+    function generateStudioPopupButtons()
+    {
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
+        $this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPSEARCH' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch','help'=> 'PopupSearchViewBtn');
+    }
 	
-	function generateMBSearchButtons()
-	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_BASIC' ] ] = array ( 'action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=basic_search" , 'imageTitle' => $GLOBALS [ 'mod_strings' ] [ 'LBL_BASIC_SEARCH' ] , 'imageName' => 'BasicSearch','help' => "BasicSearchBtn" ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_ADVANCED' ] ] = array ( 'action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=advanced_search" , 'imageTitle' => $GLOBALS [ 'mod_strings' ] [ 'LBL_ADVANCED_SEARCH' ] , 'imageName' => 'AdvancedSearch','help' => "AdvancedSearchBtn" ) ;
-	}
+    function generateMBSearchButtons()
+    {
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_BASIC' ] ] = array ( 'action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=basic_search" , 'imageTitle' => $GLOBALS [ 'mod_strings' ] [ 'LBL_BASIC_SEARCH' ] , 'imageName' => 'BasicSearch','help' => "BasicSearchBtn" ) ;
+        $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_ADVANCED' ] ] = array ( 'action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=advanced_search" , 'imageTitle' => $GLOBALS [ 'mod_strings' ] [ 'LBL_ADVANCED_SEARCH' ] , 'imageName' => 'AdvancedSearch','help' => "AdvancedSearchBtn" ) ;
+    }
 }

Spacing +147 added lines, -147 removed lines

@@ -37,27 +37,27 @@ 
  * display the words  "Powered by SugarCRM" and "Supercharged by SuiteCRM".
  ********************************************************************************/
 
-require_once ('modules/ModuleBuilder/MB/AjaxCompose.php') ;
-require_once ('modules/ModuleBuilder/Module/StudioModuleFactory.php') ;
-require_once ('include/MVC/View/SugarView.php') ;
+require_once ('modules/ModuleBuilder/MB/AjaxCompose.php');
+require_once ('modules/ModuleBuilder/Module/StudioModuleFactory.php');
+require_once ('include/MVC/View/SugarView.php');
 
 class ModuleBuilderViewWizard extends SugarView
 {
-	private $view = null ; // the wizard view to display
-	private $actions ;
-	private $buttons ;
-	private $question ;
-	private $title ;
-	private $help ;
+	private $view = null; // the wizard view to display
+	private $actions;
+	private $buttons;
+	private $question;
+	private $title;
+	private $help;
 
-	private $editModule ;
+	private $editModule;
 
 	function __construct()
 	{
-		if ( isset ( $_REQUEST [ 'view' ] ) )
-			$this->view = $_REQUEST [ 'view' ] ;
+		if (isset ($_REQUEST ['view']))
+			$this->view = $_REQUEST ['view'];
 
-		$this->editModule = (! empty ( $_REQUEST [ 'view_module' ] ) ) ? $_REQUEST [ 'view_module' ] : null ;
+		$this->editModule = (!empty ($_REQUEST ['view_module'])) ? $_REQUEST ['view_module'] : null;
 		$this->buttons = array(); // initialize so that modules without subpanels for example don't result in this being unset and causing problems in the smarty->assign
 	}
 	
@@ -69,35 +69,35 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
 
 	function display()
 	{
-		$this->ajax = new AjaxCompose ( ) ;
-		$smarty = new Sugar_Smarty ( ) ;
+		$this->ajax = new AjaxCompose( );
+		$smarty = new Sugar_Smarty( );
 
-		if (isset ( $_REQUEST [ 'MB' ] ))
+		if (isset ($_REQUEST ['MB']))
 		{
-			$this->processMB ( $this->ajax ) ;
+			$this->processMB($this->ajax);
 		} else
 		{
 
-				$this->processStudio ( $this->ajax ) ;
+				$this->processStudio($this->ajax);
 
 		}
 
-		$smarty->assign ( 'buttons', $this->buttons ) ;
-		$smarty->assign ( 'image_path', $GLOBALS [ 'image_path' ] ) ;
-		$smarty->assign ( "title", $this->title ) ;
-		$smarty->assign ( "question", $this->question ) ;
-		$smarty->assign ( "defaultHelp", $this->help ) ;
-		$smarty->assign ( "actions", $this->actions ) ;
+		$smarty->assign('buttons', $this->buttons);
+		$smarty->assign('image_path', $GLOBALS ['image_path']);
+		$smarty->assign("title", $this->title);
+		$smarty->assign("question", $this->question);
+		$smarty->assign("defaultHelp", $this->help);
+		$smarty->assign("actions", $this->actions);
 
-		$this->ajax->addSection ( 'center', $this->title, $smarty->fetch ( 'modules/ModuleBuilder/tpls/wizard.tpl' ) ) ;
-		echo $this->ajax->getJavascript () ;
+		$this->ajax->addSection('center', $this->title, $smarty->fetch('modules/ModuleBuilder/tpls/wizard.tpl'));
+		echo $this->ajax->getJavascript();
 	}
 
 	function processStudio( 
@@ -105,161 +105,161 @@ 
 	    )
 	{
 
-		$this->ajax->addCrumb ( translate( 'LBL_STUDIO' ), 'ModuleBuilder.main("studio")' ) ;
+		$this->ajax->addCrumb(translate('LBL_STUDIO'), 'ModuleBuilder.main("studio")');
 
-		if (! isset ( $this->editModule ))
+		if (!isset ($this->editModule))
 		{
 			//Studio Select Module Page
-			$this->generateStudioModuleButtons () ;
-			$this->question = translate('LBL_QUESTION_EDIT') ;
-			$this->title = translate( 'LBL_STUDIO' );
+			$this->generateStudioModuleButtons();
+			$this->question = translate('LBL_QUESTION_EDIT');
+			$this->title = translate('LBL_STUDIO');
 			global $current_user;
 			if (is_admin($current_user))
-				$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
+				$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"".translate('LBL_BTN_EXPORT').'">';
 
-			$this->help = 'studioHelp' ;
+			$this->help = 'studioHelp';
 		} else
 		{
-			$module = StudioModuleFactory::getStudioModule( $this->editModule ) ;
-			$this->ajax->addCrumb ( $module->name, !empty($this->view) ? 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module=' . $this->editModule . '")' : '' ) ;
-			switch ( $this->view )
+			$module = StudioModuleFactory::getStudioModule($this->editModule);
+			$this->ajax->addCrumb($module->name, !empty($this->view) ? 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module='.$this->editModule.'")' : '');
+			switch ($this->view)
 			{
 				case 'layouts':
 					//Studio Select Layout page
-					$this->buttons = $module->getLayouts() ;
-					$this->title = $module->name . " " . translate('LBL_LAYOUTS') ;
-					$this->question = translate( 'LBL_QUESTION_LAYOUT' ) ;
-					$this->help = 'layoutsHelp' ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), '' ) ;
+					$this->buttons = $module->getLayouts();
+					$this->title = $module->name." ".translate('LBL_LAYOUTS');
+					$this->question = translate('LBL_QUESTION_LAYOUT');
+					$this->help = 'layoutsHelp';
+					$this->ajax->addCrumb(translate('LBL_LAYOUTS'), '');
 					break;
 
 
 				case 'subpanels':
 					//Studio Select Subpanel page.
-					$this->buttons = $module->getSubpanels() ;
-					$this->title = $module->name . " " . translate( 'LBL_SUBPANELS' ) ;
-					$this->question = translate( 'LBL_QUESTION_SUBPANEL' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_SUBPANELS' ), '' ) ;
-					$this->help = 'subpanelHelp' ;
+					$this->buttons = $module->getSubpanels();
+					$this->title = $module->name." ".translate('LBL_SUBPANELS');
+					$this->question = translate('LBL_QUESTION_SUBPANEL');
+					$this->ajax->addCrumb(translate('LBL_SUBPANELS'), '');
+					$this->help = 'subpanelHelp';
 					break;
 
 				case 'search':
 					//Studio Select Search Layout page.
-					$this->buttons = $module->getSearch() ;
-					$this->title = $module->name . " " . translate('LBL_SEARCH');
-					$this->question = translate( 'LBL_QUESTION_SEARCH' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_SEARCH' ), '' ) ;
-					$this->help = 'searchHelp' ;
+					$this->buttons = $module->getSearch();
+					$this->title = $module->name." ".translate('LBL_SEARCH');
+					$this->question = translate('LBL_QUESTION_SEARCH');
+					$this->ajax->addCrumb(translate('LBL_LAYOUTS'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module='.$this->editModule.'")');
+					$this->ajax->addCrumb(translate('LBL_SEARCH'), '');
+					$this->help = 'searchHelp';
 					break;
 
 				case 'dashlet':
 					$this->generateStudioDashletButtons();
-					$this->title = $this->editModule ." " .translate('LBL_DASHLET');
-					$this->question = translate( 'LBL_QUESTION_DASHLET' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_DASHLET' ), '' ) ;
-					$this->help = 'dashletHelp' ;
+					$this->title = $this->editModule." ".translate('LBL_DASHLET');
+					$this->question = translate('LBL_QUESTION_DASHLET');
+					$this->ajax->addCrumb(translate('LBL_LAYOUTS'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module='.$this->editModule.'")');
+					$this->ajax->addCrumb(translate('LBL_DASHLET'), '');
+					$this->help = 'dashletHelp';
 					break;
 				
 				case 'popup':
 					$this->generateStudioPopupButtons();
-					$this->title = $this->editModule ." " .translate('LBL_POPUP');
-					$this->question = translate( 'LBL_QUESTION_POPUP' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module=' . $this->editModule . '")' ) ;
-					$this->ajax->addCrumb ( translate( 'LBL_POPUP' ), '' ) ;
-					$this->help = 'popupHelp' ;
+					$this->title = $this->editModule." ".translate('LBL_POPUP');
+					$this->question = translate('LBL_QUESTION_POPUP');
+					$this->ajax->addCrumb(translate('LBL_LAYOUTS'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&view_module='.$this->editModule.'")');
+					$this->ajax->addCrumb(translate('LBL_POPUP'), '');
+					$this->help = 'popupHelp';
 					break;
 				default:
 					//Studio Edit Module Page
-					$this->buttons = $module->getModule () ;
-					$this->question = translate( 'LBL_QUESTION_MODULE' ) ;
-					$this->title = translate( 'LBL_EDIT' ) . " " . $module->name ;
-					$this->help = 'moduleHelp' ;
+					$this->buttons = $module->getModule();
+					$this->question = translate('LBL_QUESTION_MODULE');
+					$this->title = translate('LBL_EDIT')." ".$module->name;
+					$this->help = 'moduleHelp';
 					global $current_user;
 					if (is_admin($current_user))
                         $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" " 
                         . "onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=resetmodule&view_module=$this->editModule');\" value=\"" 
-                        . translate( 'LBL_RESET_MODULE' ) . '">' ;
+                        . translate('LBL_RESET_MODULE').'">';
 			}
 		}
 	}
 
-	function processMB ( 
+	function processMB( 
 	    $ajax 
 	    )
 	{
-		if (! isset ( $_REQUEST [ 'view_package' ] ))
+		if (!isset ($_REQUEST ['view_package']))
 		{
-			sugar_die ( "no ModuleBuilder package set" ) ;
+			sugar_die("no ModuleBuilder package set");
 		}
 
-		$this->editModule = $_REQUEST [ 'view_module' ] ;
-		$this->package = $_REQUEST [ 'view_package' ] ;
+		$this->editModule = $_REQUEST ['view_module'];
+		$this->package = $_REQUEST ['view_package'];
 
-		$ajax->addCrumb ( translate ( 'LBL_MODULEBUILDER', 'ModuleBuilder' ), 'ModuleBuilder.main("mb")' ) ;
-		$ajax->addCrumb ( $this->package, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&view_package=' . $this->package . '")' ) ;
-		$ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '&view_package=' . $this->package . '")') ;
+		$ajax->addCrumb(translate('LBL_MODULEBUILDER', 'ModuleBuilder'), 'ModuleBuilder.main("mb")');
+		$ajax->addCrumb($this->package, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&view_package='.$this->package.'")');
+		$ajax->addCrumb($this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module='.$this->editModule.'&view_package='.$this->package.'")');
 
-		switch ( $this->view )
+		switch ($this->view)
 		{
 			case 'search':
 				//MB Select Search Layout page.
-				$this->generateMBSearchButtons () ;
-				$this->title = $this->editModule . " " . translate( 'LBL_SEARCH' ) ;
-				$this->question = translate( 'LBL_QUESTION_SEARCH' ) ;
-				$ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view_module=' . $this->editModule . '&view_package=' . $this->package . '")' ) ;
-				$ajax->addCrumb ( translate( 'LBL_SEARCH_FORMS' ), '' ) ;
-				$this->help = "searchHelp" ;
+				$this->generateMBSearchButtons();
+				$this->title = $this->editModule." ".translate('LBL_SEARCH');
+				$this->question = translate('LBL_QUESTION_SEARCH');
+				$ajax->addCrumb(translate('LBL_LAYOUTS'), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view_module='.$this->editModule.'&view_package='.$this->package.'")');
+				$ajax->addCrumb(translate('LBL_SEARCH_FORMS'), '');
+				$this->help = "searchHelp";
 				break;
 
 			case 'subpanel':
 				//ModuleBuilder Select Subpanel
-				$ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '&view_package=' . $this->package . '")' ) ;
-				$ajax->addCrumb ( translate( 'LBL_SUBPANELS' ), '' ) ;
-				$this->question = translate( 'LBL_QUESTION_SUBPANEL' ) ;
-				$this->help = 'subpanelHelp' ;
+				$ajax->addCrumb($this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module='.$this->editModule.'&view_package='.$this->package.'")');
+				$ajax->addCrumb(translate('LBL_SUBPANELS'), '');
+				$this->question = translate('LBL_QUESTION_SUBPANEL');
+				$this->help = 'subpanelHelp';
 				break;
 
 			case 'dashlet':
-				$this->generateMBDashletButtons ();
-				$this->title = $this->editModule ." " .translate('LBL_DASHLET');
-				$this->question = translate( 'LBL_QUESTION_DASHLET' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module=' . $this->editModule . '")' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_DASHLET' ), '' ) ;
-				$this->help = 'dashletHelp' ;
+				$this->generateMBDashletButtons();
+				$this->title = $this->editModule." ".translate('LBL_DASHLET');
+				$this->question = translate('LBL_QUESTION_DASHLET');
+				$this->ajax->addCrumb(translate('LBL_LAYOUTS'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module='.$this->editModule.'")');
+				$this->ajax->addCrumb(translate('LBL_DASHLET'), '');
+				$this->help = 'dashletHelp';
 				break;
 
 
 			case 'popup':
 				$this->generateMBPopupButtons();
-				$this->title = $this->editModule ." " .translate('LBL_POPUP');
-				$this->question = translate( 'LBL_QUESTION_POPUP' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module=' . $this->editModule . '")' ) ;
-				$this->ajax->addCrumb ( translate( 'LBL_POPUP' ), '' ) ;
-				$this->help = 'popupHelp' ;
+				$this->title = $this->editModule." ".translate('LBL_POPUP');
+				$this->question = translate('LBL_QUESTION_POPUP');
+				$this->ajax->addCrumb(translate('LBL_LAYOUTS'), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view=layouts&MB=1&view_package='.$this->package.'&view_module='.$this->editModule.'")');
+				$this->ajax->addCrumb(translate('LBL_POPUP'), '');
+				$this->help = 'popupHelp';
 				break;
 			default:
-				$ajax->addCrumb ( translate( 'LBL_LAYOUTS' ), '' ) ;
-				$this->generateMBViewButtons () ;
-				$this->title = $this->editModule . " " . translate( 'LBL_LAYOUTS' ) ;
-				$this->question = translate( 'LBL_QUESTION_LAYOUT' ) ;
-				$this->help = "layoutsHelp" ;
+				$ajax->addCrumb(translate('LBL_LAYOUTS'), '');
+				$this->generateMBViewButtons();
+				$this->title = $this->editModule." ".translate('LBL_LAYOUTS');
+				$this->question = translate('LBL_QUESTION_LAYOUT');
+				$this->help = "layoutsHelp";
 		}
 	}
 
 
 	function generateStudioModuleButtons()
 	{
-		require_once ('modules/ModuleBuilder/Module/StudioBrowser.php') ;
-		$sb = new StudioBrowser ( ) ;
-		$sb->loadModules () ;
-		$nodes = $sb->getNodes () ;
-		$this->buttons = array ( ) ;
+		require_once ('modules/ModuleBuilder/Module/StudioBrowser.php');
+		$sb = new StudioBrowser( );
+		$sb->loadModules();
+		$nodes = $sb->getNodes();
+		$this->buttons = array( );
 		//$GLOBALS['log']->debug(print_r($nodes,true));
-		foreach ( $nodes as $module )
+		foreach ($nodes as $module)
 		{
-			$this->buttons [ $module [ 'name' ] ] = array ( 'action' => $module [ 'action' ] , 'imageTitle' => ucfirst ( $module [ 'module' ] . "_32" ) , 'size' => '32', 'linkId' => 'studiolink_'.$module [ 'module' ] ) ;
+			$this->buttons [$module ['name']] = array('action' => $module ['action'], 'imageTitle' => ucfirst($module ['module']."_32"), 'size' => '32', 'linkId' => 'studiolink_'.$module ['module']);
 		}
 	}
 
@@ -267,44 +267,44 @@ 
 
 	function generateMBViewButtons()
 	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_EDITVIEW' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_EDITVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_EDITVIEW']] = 
+		  array( 
+		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_EDITVIEW."&view_module={$this->editModule}&view_package={$this->package}", 
 		      'imageTitle' => 'EditView', 
 		      'help'=>'viewBtnEditView'
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_DETAILVIEW' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_DETAILVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
+		  );
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_DETAILVIEW']] = 
+		  array( 
+		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_DETAILVIEW."&view_module={$this->editModule}&view_package={$this->package}", 
 		      'imageTitle' => 'DetailView', 
 		      'help'=>'viewBtnListView'  
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_LISTVIEW."&view_module={$this->editModule}&view_package={$this->package}" , 
+		  );
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_LISTVIEW']] = 
+		  array( 
+		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_LISTVIEW."&view_module={$this->editModule}&view_package={$this->package}", 
 		      'imageTitle' => 'ListView', 
 		      'help'=>'viewBtnListView' 
-		  ) ;
-		  $this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_QUICKCREATE' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_QUICKCREATE."&view_module={$this->editModule}&view_package={$this->package}" , 
+		  );
+		  $this->buttons [$GLOBALS ['mod_strings'] ['LBL_QUICKCREATE']] = 
+		  array( 
+		      'action' => "module=ModuleBuilder&MB=true&action=editLayout&view=".MB_QUICKCREATE."&view_module={$this->editModule}&view_package={$this->package}", 
 		      'imageTitle' => 'QuickCreate', 
 		      'help'=>'viewBtnQuickCreate' 
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_SEARCH' ] ] = 
-		  array (
-		      'action' => "module=ModuleBuilder&MB=true&action=wizard&view=search&view_module={$this->editModule}&view_package={$this->package}" , 
-		      'imageTitle' => 'SearchForm' , 
+		  );
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_SEARCH']] = 
+		  array(
+		      'action' => "module=ModuleBuilder&MB=true&action=wizard&view=search&view_module={$this->editModule}&view_package={$this->package}", 
+		      'imageTitle' => 'SearchForm', 
 		      'help'=> 'searchBtn' 
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_DASHLET' ] ] = 
-		  array ( 
-		      'action' => "module=ModuleBuilder&MB=true&action=wizard&view=dashlet&view_module={$this->editModule}&view_package={$this->package}" , 
+		  );
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_DASHLET']] = 
+		  array( 
+		      'action' => "module=ModuleBuilder&MB=true&action=wizard&view=dashlet&view_module={$this->editModule}&view_package={$this->package}", 
 		      'imageTitle' => 'Dashlet', 
 		      'help'=>'viewBtnDashlet' 
-		  ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] ['LBL_POPUP'] ] = 
-		array ( 
+		  );
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_POPUP']] = 
+		array( 
 			'imageTitle' => 'Popup',  
 			'action' => "module=ModuleBuilder&MB=true&action=wizard&view=popup&view_module={$this->editModule}&view_package={$this->package}", 
 			'help'=>'PopupListViewBtn'
@@ -313,31 +313,31 @@ 
 
 	function generateMBDashletButtons() 
 	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashlet&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETSEARCHVIEW' ] ] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashletsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch','help'=> 'DashletSearchViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW']] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashlet&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW']] = array('action'=> "module=ModuleBuilder&MB=true&action=editLayout&view=dashletsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch', 'help'=> 'DashletSearchViewBtn');
 	}
 	
 	function generateMBPopupButtons() 
 	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPSEARCH' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch','help'=> 'PopupSearchViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW']] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_POPUPSEARCH']] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}&view_package={$this->package}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch', 'help'=> 'PopupSearchViewBtn');
 	}
 	
 	function generateStudioDashletButtons() 
 	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashlet&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_DASHLETSEARCHVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashletsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch','help'=> 'DashletSearchViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW']] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashlet&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETLISTVIEW'], 'imageName'=>'ListView', 'help'=>'DashletListViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW']] = array('action'=> "module=ModuleBuilder&action=editLayout&view=dashletsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_DASHLETSEARCHVIEW'], 'imageName'=>'BasicSearch', 'help'=> 'DashletSearchViewBtn');
 	}
 	
 	function generateStudioPopupButtons()
 	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPLISTVIEW' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
-		$this->buttons [ $GLOBALS [ 'mod_strings' ][ 'LBL_POPUPSEARCH' ] ] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch','help'=> 'PopupSearchViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW']] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popuplist&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPLISTVIEW'], 'imageName'=>'ListView', 'help'=>'PopupListViewBtn');
+		$this->buttons [$GLOBALS ['mod_strings']['LBL_POPUPSEARCH']] = array('action'=> "module=ModuleBuilder&action=editLayout&view=popupsearch&view_module={$this->editModule}", 'imageTitle'=> $GLOBALS ['mod_strings']['LBL_POPUPSEARCH'], 'imageName'=>'BasicSearch', 'help'=> 'PopupSearchViewBtn');
 	}
 	
 	function generateMBSearchButtons()
 	{
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_BASIC' ] ] = array ( 'action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=basic_search" , 'imageTitle' => $GLOBALS [ 'mod_strings' ] [ 'LBL_BASIC_SEARCH' ] , 'imageName' => 'BasicSearch','help' => "BasicSearchBtn" ) ;
-		$this->buttons [ $GLOBALS [ 'mod_strings' ] [ 'LBL_ADVANCED' ] ] = array ( 'action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=advanced_search" , 'imageTitle' => $GLOBALS [ 'mod_strings' ] [ 'LBL_ADVANCED_SEARCH' ] , 'imageName' => 'AdvancedSearch','help' => "AdvancedSearchBtn" ) ;
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_BASIC']] = array('action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=basic_search", 'imageTitle' => $GLOBALS ['mod_strings'] ['LBL_BASIC_SEARCH'], 'imageName' => 'BasicSearch', 'help' => "BasicSearchBtn");
+		$this->buttons [$GLOBALS ['mod_strings'] ['LBL_ADVANCED']] = array('action' => "module=ModuleBuilder&MB=true&action=editLayout&view_module={$this->editModule}&view_package={$this->package}&view=SearchView&searchlayout=advanced_search", 'imageTitle' => $GLOBALS ['mod_strings'] ['LBL_ADVANCED_SEARCH'], 'imageName' => 'AdvancedSearch', 'help' => "AdvancedSearchBtn");
 	}
 }

Braces +9 added lines, -6 removed lines

@@ -54,8 +54,9 @@ 
 
 	function __construct()
 	{
-		if ( isset ( $_REQUEST [ 'view' ] ) )
-			$this->view = $_REQUEST [ 'view' ] ;
+		if ( isset ( $_REQUEST [ 'view' ] ) ) {
+					$this->view = $_REQUEST [ 'view' ] ;
+		}
 
 		$this->editModule = (! empty ( $_REQUEST [ 'view_module' ] ) ) ? $_REQUEST [ 'view_module' ] : null ;
 		$this->buttons = array(); // initialize so that modules without subpanels for example don't result in this being unset and causing problems in the smarty->assign
@@ -114,8 +115,9 @@ 
 			$this->question = translate('LBL_QUESTION_EDIT') ;
 			$this->title = translate( 'LBL_STUDIO' );
 			global $current_user;
-			if (is_admin($current_user))
-				$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
+			if (is_admin($current_user)) {
+							$this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=exportcustomizations');\" value=\"" . translate ( 'LBL_BTN_EXPORT' ) . '">' ;
+			}
 
 			$this->help = 'studioHelp' ;
 		} else
@@ -177,10 +179,11 @@ 
 					$this->title = translate( 'LBL_EDIT' ) . " " . $module->name ;
 					$this->help = 'moduleHelp' ;
 					global $current_user;
-					if (is_admin($current_user))
-                        $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" " 
+					if (is_admin($current_user)) {
+					                        $this->actions = "<input class=\"button\" type=\"button\" id=\"exportBtn\" name=\"exportBtn\" " 
                         . "onclick=\"ModuleBuilder.getContent('module=ModuleBuilder&action=resetmodule&view_module=$this->editModule');\" value=\"" 
                         . translate( 'LBL_RESET_MODULE' ) . '">' ;
+					}
 			}
 		}
 	}

modules/ModuleBuilder/views/view.relationships.php

Indentation +25 added lines, -25 removed lines

@@ -46,16 +46,16 @@ 
 class ViewRelationships extends SugarView
 {
     /**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+     * @see SugarView::_getModuleTitleParams()
+     */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
     function display()
@@ -69,7 +69,7 @@ 
 
         $ajax = new AjaxCompose ( ) ;
         $json = getJSONobj () ;
-		$this->fromModuleBuilder = !empty ( $_REQUEST [ 'MB' ] ) || (!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio') ;
+        $this->fromModuleBuilder = !empty ( $_REQUEST [ 'MB' ] ) || (!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio') ;
         $smarty->assign('fromModuleBuilder', $this->fromModuleBuilder);
         if (!$this->fromModuleBuilder)
         {
@@ -97,7 +97,7 @@ 
             $mb = new ModuleBuilder ( ) ;
             $module = & $mb->getPackageModule ( $_REQUEST [ 'view_package' ], $_REQUEST [ 'view_module' ] ) ;
             $package = $mb->packages [ $_REQUEST [ 'view_package' ] ] ;
-			$package->loadModuleTitles();
+            $package->loadModuleTitles();
             $relationships = new UndeployedRelationships ( $module->getModuleDir () ) ;
             $ajaxRelationships = $this->getAjaxRelationships( $relationships ) ;
             $smarty->assign ( 'relationships', $json->encode ( $ajaxRelationships ) ) ;
@@ -129,23 +129,23 @@ 
             
             //#28668  , translate the relationship type before render it .
             switch($rel['relationship_type']){
-            	case 'one-to-one':
-            	$rel['relationship_type']  = translate ( 'LBL_ONETOONE' );
-            	break;
-            	case 'one-to-many':
-            	$rel['relationship_type']  = translate ( 'LBL_ONETOMANY' );
-            	break;
-            	case 'many-to-one':
-            	$rel['relationship_type']  = translate ( 'LBL_MANYTOONE' );
-            	break;
-            	case 'many-to-many':
-            	$rel['relationship_type']  = translate ( 'LBL_MANYTOMANY' );
-            	break;
-            	default: $rel['relationship_type']  = '';
+                case 'one-to-one':
+                $rel['relationship_type']  = translate ( 'LBL_ONETOONE' );
+                break;
+                case 'one-to-many':
+                $rel['relationship_type']  = translate ( 'LBL_ONETOMANY' );
+                break;
+                case 'many-to-one':
+                $rel['relationship_type']  = translate ( 'LBL_MANYTOONE' );
+                break;
+                case 'many-to-many':
+                $rel['relationship_type']  = translate ( 'LBL_MANYTOMANY' );
+                break;
+                default: $rel['relationship_type']  = '';
             }
             $rel [ 'name' ] = $relationshipName ;
             if ($rel [ 'is_custom' ] && isset($rel [ 'from_studio' ]) && $rel [ 'from_studio' ]) {
-            	$rel [ 'name' ] = $relationshipName . "*";
+                $rel [ 'name' ] = $relationshipName . "*";
             }
             $ajaxrels [] = $rel ;
         }

Spacing +59 added lines, -59 removed lines

@@ -37,11 +37,11 @@ 
  * display the words  "Powered by SugarCRM" and "Supercharged by SuiteCRM".
  ********************************************************************************/
 
-require_once ('modules/ModuleBuilder/MB/AjaxCompose.php') ;
-require_once ('modules/ModuleBuilder/MB/ModuleBuilder.php') ;
-require_once ('modules/ModuleBuilder/views/view.relationship.php') ;
-require_once ('modules/ModuleBuilder/Module/StudioModule.php') ;
-require_once ('modules/ModuleBuilder/Module/StudioBrowser.php') ;
+require_once ('modules/ModuleBuilder/MB/AjaxCompose.php');
+require_once ('modules/ModuleBuilder/MB/ModuleBuilder.php');
+require_once ('modules/ModuleBuilder/views/view.relationship.php');
+require_once ('modules/ModuleBuilder/Module/StudioModule.php');
+require_once ('modules/ModuleBuilder/Module/StudioBrowser.php');
 
 class ViewRelationships extends SugarView
 {
@@ -53,103 +53,103 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
 
     function display()
     {
-        $moduleName = ! empty ( $_REQUEST [ 'view_module' ] ) ? $_REQUEST [ 'view_module' ] : $_REQUEST [ 'edit_module' ] ;
-        $smarty = new Sugar_Smarty ( ) ;
+        $moduleName = !empty ($_REQUEST ['view_module']) ? $_REQUEST ['view_module'] : $_REQUEST ['edit_module'];
+        $smarty = new Sugar_Smarty( );
         // set the mod_strings as we can be called after doing a Repair and the mod_strings are set to Administration
         $GLOBALS['mod_strings'] = return_module_language($GLOBALS['current_language'], 'ModuleBuilder');
-        $smarty->assign ( 'mod_strings', $GLOBALS [ 'mod_strings' ] ) ;
-        $smarty->assign ( 'view_module', $moduleName ) ;
+        $smarty->assign('mod_strings', $GLOBALS ['mod_strings']);
+        $smarty->assign('view_module', $moduleName);
 
-        $ajax = new AjaxCompose ( ) ;
-        $json = getJSONobj () ;
-		$this->fromModuleBuilder = !empty ( $_REQUEST [ 'MB' ] ) || (!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio') ;
+        $ajax = new AjaxCompose( );
+        $json = getJSONobj();
+		$this->fromModuleBuilder = !empty ($_REQUEST ['MB']) || (!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio');
         $smarty->assign('fromModuleBuilder', $this->fromModuleBuilder);
         if (!$this->fromModuleBuilder)
         {
-            $smarty->assign ( 'view_package', '' ) ;
+            $smarty->assign('view_package', '');
 
-            $relationships = new DeployedRelationships ( $moduleName ) ;
-            $ajaxRelationships = $this->getAjaxRelationships( $relationships ) ;
-            $smarty->assign ( 'relationships', $json->encode ( $ajaxRelationships ) ) ;
-            $smarty->assign ( 'empty', (sizeof ( $ajaxRelationships ) == 0) ) ;
-            $smarty->assign ( 'studio', true ) ;
+            $relationships = new DeployedRelationships($moduleName);
+            $ajaxRelationships = $this->getAjaxRelationships($relationships);
+            $smarty->assign('relationships', $json->encode($ajaxRelationships));
+            $smarty->assign('empty', (sizeof($ajaxRelationships) == 0));
+            $smarty->assign('studio', true);
 
             //crumb
-            global $app_list_strings ;
-            $moduleNames = array_change_key_case ( $app_list_strings [ 'moduleList' ] ) ;
-            $translatedModule = $moduleNames [ strtolower ( $moduleName ) ] ;
-            $ajax->addCrumb ( translate('LBL_STUDIO'), 'ModuleBuilder.main("studio")' ) ;
-            $ajax->addCrumb ( $translatedModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module=' . $moduleName . '")' ) ;
-            $ajax->addCrumb ( translate('LBL_RELATIONSHIPS'), '' ) ;
-            $ajax->addSection ( 'center', $moduleName . ' ' . translate('LBL_RELATIONSHIPS'), $this->fetchTemplate($smarty, 'modules/ModuleBuilder/tpls/studioRelationships.tpl'));
+            global $app_list_strings;
+            $moduleNames = array_change_key_case($app_list_strings ['moduleList']);
+            $translatedModule = $moduleNames [strtolower($moduleName)];
+            $ajax->addCrumb(translate('LBL_STUDIO'), 'ModuleBuilder.main("studio")');
+            $ajax->addCrumb($translatedModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module='.$moduleName.'")');
+            $ajax->addCrumb(translate('LBL_RELATIONSHIPS'), '');
+            $ajax->addSection('center', $moduleName.' '.translate('LBL_RELATIONSHIPS'), $this->fetchTemplate($smarty, 'modules/ModuleBuilder/tpls/studioRelationships.tpl'));
 
         } else
         {
-            $smarty->assign ( 'view_package', $_REQUEST [ 'view_package' ] ) ;
+            $smarty->assign('view_package', $_REQUEST ['view_package']);
 
-            $mb = new ModuleBuilder ( ) ;
-            $module = & $mb->getPackageModule ( $_REQUEST [ 'view_package' ], $_REQUEST [ 'view_module' ] ) ;
-            $package = $mb->packages [ $_REQUEST [ 'view_package' ] ] ;
+            $mb = new ModuleBuilder( );
+            $module = & $mb->getPackageModule($_REQUEST ['view_package'], $_REQUEST ['view_module']);
+            $package = $mb->packages [$_REQUEST ['view_package']];
 			$package->loadModuleTitles();
-            $relationships = new UndeployedRelationships ( $module->getModuleDir () ) ;
-            $ajaxRelationships = $this->getAjaxRelationships( $relationships ) ;
-            $smarty->assign ( 'relationships', $json->encode ( $ajaxRelationships ) ) ;
-            $smarty->assign ( 'empty', (sizeof ( $ajaxRelationships ) == 0) ) ;
+            $relationships = new UndeployedRelationships($module->getModuleDir());
+            $ajaxRelationships = $this->getAjaxRelationships($relationships);
+            $smarty->assign('relationships', $json->encode($ajaxRelationships));
+            $smarty->assign('empty', (sizeof($ajaxRelationships) == 0));
 
-            $module->help [ 'default' ] = (empty ( $_REQUEST [ 'view_module' ] )) ? 'create' : 'modify' ;
-            $module->help [ 'group' ] = 'module' ;
+            $module->help ['default'] = (empty ($_REQUEST ['view_module'])) ? 'create' : 'modify';
+            $module->help ['group'] = 'module';
 
-            $ajax->addCrumb ( translate('LBL_MODULEBUILDER'), 'ModuleBuilder.main("mb")' ) ;
-            $ajax->addCrumb ( $package->name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package=' . $package->name . '")' ) ;
-            $ajax->addCrumb ( $moduleName, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package=' . $package->name . '&view_module=' . $moduleName . '")' ) ;
-            $ajax->addCrumb ( translate('LBL_RELATIONSHIPS'), '' ) ;
-            $ajax->addSection ( 'center', $moduleName . ' ' . translate('LBL_RELATIONSHIPS'), $this->fetchTemplate($smarty, 'modules/ModuleBuilder/tpls/studioRelationships.tpl'));
+            $ajax->addCrumb(translate('LBL_MODULEBUILDER'), 'ModuleBuilder.main("mb")');
+            $ajax->addCrumb($package->name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$package->name.'")');
+            $ajax->addCrumb($moduleName, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package='.$package->name.'&view_module='.$moduleName.'")');
+            $ajax->addCrumb(translate('LBL_RELATIONSHIPS'), '');
+            $ajax->addSection('center', $moduleName.' '.translate('LBL_RELATIONSHIPS'), $this->fetchTemplate($smarty, 'modules/ModuleBuilder/tpls/studioRelationships.tpl'));
         }
-        echo $ajax->getJavascript () ;
+        echo $ajax->getJavascript();
     }
 
     /*
      * Encode the relationships for this module for display in the Ext grid layout
      */
-    function getAjaxRelationships ( $relationships )
+    function getAjaxRelationships($relationships)
     {
-        $ajaxrels = array ( ) ;
-        foreach ( $relationships->getRelationshipList () as $relationshipName )
+        $ajaxrels = array( );
+        foreach ($relationships->getRelationshipList() as $relationshipName)
         {
-            $rel = $relationships->get ( $relationshipName )->getDefinition () ;
-            $rel [ 'lhs_module' ] = translate( $rel [ 'lhs_module' ] ) ;
-            $rel [ 'rhs_module' ] = translate( $rel [ 'rhs_module' ] ) ;
+            $rel = $relationships->get($relationshipName)->getDefinition();
+            $rel ['lhs_module'] = translate($rel ['lhs_module']);
+            $rel ['rhs_module'] = translate($rel ['rhs_module']);
             
             //#28668  , translate the relationship type before render it .
-            switch($rel['relationship_type']){
+            switch ($rel['relationship_type']) {
             	case 'one-to-one':
-            	$rel['relationship_type']  = translate ( 'LBL_ONETOONE' );
+            	$rel['relationship_type']  = translate('LBL_ONETOONE');
             	break;
             	case 'one-to-many':
-            	$rel['relationship_type']  = translate ( 'LBL_ONETOMANY' );
+            	$rel['relationship_type']  = translate('LBL_ONETOMANY');
             	break;
             	case 'many-to-one':
-            	$rel['relationship_type']  = translate ( 'LBL_MANYTOONE' );
+            	$rel['relationship_type']  = translate('LBL_MANYTOONE');
             	break;
             	case 'many-to-many':
-            	$rel['relationship_type']  = translate ( 'LBL_MANYTOMANY' );
+            	$rel['relationship_type']  = translate('LBL_MANYTOMANY');
             	break;
-            	default: $rel['relationship_type']  = '';
+            	default: $rel['relationship_type'] = '';
             }
-            $rel [ 'name' ] = $relationshipName ;
-            if ($rel [ 'is_custom' ] && isset($rel [ 'from_studio' ]) && $rel [ 'from_studio' ]) {
-            	$rel [ 'name' ] = $relationshipName . "*";
+            $rel ['name'] = $relationshipName;
+            if ($rel ['is_custom'] && isset($rel ['from_studio']) && $rel ['from_studio']) {
+            	$rel ['name'] = $relationshipName."*";
             }
-            $ajaxrels [] = $rel ;
+            $ajaxrels [] = $rel;
         }
-        return $ajaxrels ;
+        return $ajaxrels;
     }
 
     /**

modules/ModuleBuilder/views/view.deletemodule.php

Indentation +15 added lines, -15 removed lines

@@ -43,22 +43,22 @@
 class Viewdeletemodule extends SugarView
 {
 /**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+ * @see SugarView::_getModuleTitleParams()
+ */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
-	function display()
-	{
- 		$ajax = new AjaxCompose();
-		$ajax->addSection('center', 'Module Deleted', $_REQUEST['module'] . ' was deleted from ' . $_REQUEST['package']);
-		echo $ajax->getJavascript(); 
- 	}
+    function display()
+    {
+            $ajax = new AjaxCompose();
+        $ajax->addSection('center', 'Module Deleted', $_REQUEST['module'] . ' was deleted from ' . $_REQUEST['package']);
+        echo $ajax->getJavascript(); 
+        }
 }
\ No newline at end of file

Spacing +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
@@ -58,7 +58,7 @@ 
 	function display()
 	{
  		$ajax = new AjaxCompose();
-		$ajax->addSection('center', 'Module Deleted', $_REQUEST['module'] . ' was deleted from ' . $_REQUEST['package']);
+		$ajax->addSection('center', 'Module Deleted', $_REQUEST['module'].' was deleted from '.$_REQUEST['package']);
 		echo $ajax->getJavascript(); 
  	}
 }
\ No newline at end of file

modules/ModuleBuilder/views/view.dropdown.php

Indentation +96 added lines, -96 removed lines

@@ -41,130 +41,130 @@
 
 class ViewDropdown extends SugarView
 {
- 	/**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+        /**
+         * @see SugarView::_getModuleTitleParams()
+         */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
- 	function display()
- 	{
-		$ajax = new AjaxCompose();
-		$smarty = $this->generateSmarty();
+        function display()
+        {
+        $ajax = new AjaxCompose();
+        $smarty = $this->generateSmarty();
 		
-		if (isset($_REQUEST['refreshTree']))
-		{
-			require_once ('modules/ModuleBuilder/Module/DropDownTree.php');
-			$mbt = new DropDownTree();
-			$ajax->addSection('west', $mbt->getName(), $mbt->fetchNodes());
-			$smarty->assign('refreshTree',true);
-		}
+        if (isset($_REQUEST['refreshTree']))
+        {
+            require_once ('modules/ModuleBuilder/Module/DropDownTree.php');
+            $mbt = new DropDownTree();
+            $ajax->addSection('west', $mbt->getName(), $mbt->fetchNodes());
+            $smarty->assign('refreshTree',true);
+        }
 
         global $mod_strings;
 
- 		$smarty->assign('deleteImage', SugarThemeRegistry::current()->getImage( 'delete_inline', '',null,null,'.gif',$mod_strings['LBL_MB_DELETE']));
-		$smarty->assign('editImage', SugarThemeRegistry::current()->getImage( 'edit_inline', ''
+            $smarty->assign('deleteImage', SugarThemeRegistry::current()->getImage( 'delete_inline', '',null,null,'.gif',$mod_strings['LBL_MB_DELETE']));
+        $smarty->assign('editImage', SugarThemeRegistry::current()->getImage( 'edit_inline', ''
 ,null,null,'.gif',$mod_strings['LBL_EDIT']));
-		$smarty->assign('action', 'savedropdown');
-		$body = $smarty->fetch('modules/ModuleBuilder/tpls/MBModule/dropdown.tpl');
-		$ajax->addSection('east2', $mod_strings['LBL_SECTION_DROPDOWNED'], $body );
- 		echo $ajax->getJavascript();
- 	}
+        $smarty->assign('action', 'savedropdown');
+        $body = $smarty->fetch('modules/ModuleBuilder/tpls/MBModule/dropdown.tpl');
+        $ajax->addSection('east2', $mod_strings['LBL_SECTION_DROPDOWNED'], $body );
+            echo $ajax->getJavascript();
+        }
  	
- 	function generateSmarty()
- 	{
-		//get the selected language
-		$selected_lang = (!empty($_REQUEST['dropdown_lang'])?$_REQUEST['dropdown_lang']:$_SESSION['authenticated_user_language']);
-		$vardef = array();
-		$package_name = 'studio';
-		$package_strings = array();
-		$new =false;
-		$my_list_strings = return_app_list_strings_language( $selected_lang ) ;
+        function generateSmarty()
+        {
+        //get the selected language
+        $selected_lang = (!empty($_REQUEST['dropdown_lang'])?$_REQUEST['dropdown_lang']:$_SESSION['authenticated_user_language']);
+        $vardef = array();
+        $package_name = 'studio';
+        $package_strings = array();
+        $new =false;
+        $my_list_strings = return_app_list_strings_language( $selected_lang ) ;
 //		$my_list_strings = $GLOBALS['app_list_strings'];
 
         $smarty = new Sugar_Smarty();
 		      
-		//if we are using ModuleBuilder then process the following
-		if(!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio'){
-			require_once('modules/ModuleBuilder/MB/ModuleBuilder.php');
-			$mb = new ModuleBuilder();
-			$module = $mb->getPackageModule($_REQUEST['view_package'], $_REQUEST['view_module']);
-			$package = $mb->packages[$_REQUEST['view_package']];
-			$package_name = $package->name;
-			$module->getVardefs();
-			if(empty($_REQUEST['dropdown_name']) && !empty($_REQUEST['field'])){
-				$new = true;
-				$_REQUEST['dropdown_name'] = $_REQUEST['field']. '_list';
-			}
+        //if we are using ModuleBuilder then process the following
+        if(!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio'){
+            require_once('modules/ModuleBuilder/MB/ModuleBuilder.php');
+            $mb = new ModuleBuilder();
+            $module = $mb->getPackageModule($_REQUEST['view_package'], $_REQUEST['view_module']);
+            $package = $mb->packages[$_REQUEST['view_package']];
+            $package_name = $package->name;
+            $module->getVardefs();
+            if(empty($_REQUEST['dropdown_name']) && !empty($_REQUEST['field'])){
+                $new = true;
+                $_REQUEST['dropdown_name'] = $_REQUEST['field']. '_list';
+            }
 			
-			$vardef = (!empty($module->mbvardefs->fields[$_REQUEST['dropdown_name']]))? $module->mbvardefs->fields[$_REQUEST['dropdown_name']]: array();
-			$module->mblanguage->generateAppStrings(false) ;
+            $vardef = (!empty($module->mbvardefs->fields[$_REQUEST['dropdown_name']]))? $module->mbvardefs->fields[$_REQUEST['dropdown_name']]: array();
+            $module->mblanguage->generateAppStrings(false) ;
             $my_list_strings = array_merge( $my_list_strings, $module->mblanguage->appListStrings[$selected_lang.'.lang.php'] );
             $smarty->assign('module_name', $module->name);
-		}
+        }
 
         $module_name = !empty($module->name) ?  $module->name : '';
         $module_name = (empty($module_name) && !empty($_REQUEST['view_module'])) ?  $_REQUEST['view_module'] : $module_name;
 
-		foreach($my_list_strings as $key=>$value){
-			if(!is_array($value)){
-				unset($my_list_strings[$key]);
-			}
-		}
+        foreach($my_list_strings as $key=>$value){
+            if(!is_array($value)){
+                unset($my_list_strings[$key]);
+            }
+        }
 		
-		$dropdowns = array_keys($my_list_strings);
-		asort($dropdowns);
-		$keys = array_keys($dropdowns);
-		$first_string = $my_list_strings[$dropdowns[$keys[0]]];
+        $dropdowns = array_keys($my_list_strings);
+        asort($dropdowns);
+        $keys = array_keys($dropdowns);
+        $first_string = $my_list_strings[$dropdowns[$keys[0]]];
 
-		$name = '';
-		$selected_dropdown = array();
+        $name = '';
+        $selected_dropdown = array();
 
-		$json = getJSONobj();
+        $json = getJSONobj();
 
-		if(!empty($_REQUEST['dropdown_name']) && !$new){
-			$name = $_REQUEST['dropdown_name'];
+        if(!empty($_REQUEST['dropdown_name']) && !$new){
+            $name = $_REQUEST['dropdown_name'];
 			
-			// handle the case where we've saved a dropdown in one language, and now attempt to edit it for another language. The $name exists, but $my_list_strings[$name] doesn't
+            // handle the case where we've saved a dropdown in one language, and now attempt to edit it for another language. The $name exists, but $my_list_strings[$name] doesn't
             // for now, we just treat it as if it was new. A better approach might be to use the first language version as a template for future languages
             if (!isset($my_list_strings[$name]))
                 $my_list_strings[$name] = array () ;
  
-			$selected_dropdown = (!empty($vardef['options']) && !empty($my_list_strings[$vardef['options']])) ? $my_list_strings[$vardef['options']] : $my_list_strings[$name];
-			$smarty->assign('ul_list', 'list = '.$json->encode(array_keys($selected_dropdown)));
-			$smarty->assign('dropdown_name', (!empty($vardef['options']) ? $vardef['options'] : $_REQUEST['dropdown_name']));
-			$smarty->assign('name', $_REQUEST['dropdown_name']);
-			$smarty->assign('options', $selected_dropdown);
-		}else{
-			$smarty->assign('ul_list', 'list = {}');
-			//we should try to find a name for this dropdown based on the field name.
-			$pre_pop_name = '';
-			if(!empty($_REQUEST['field']))
-				$pre_pop_name = $_REQUEST['field'];
-			//ensure this dropdown name does not already exist
-			$use_name = $pre_pop_name.'_list';
-			for($i = 0; $i < 100; $i++){
-				if(empty($my_list_strings[$use_name]))
-					break;
-				else
-					$use_name = $pre_pop_name.'_'.$i;
-			}
-			$smarty->assign('prepopulated_name', $use_name);
-		}
+            $selected_dropdown = (!empty($vardef['options']) && !empty($my_list_strings[$vardef['options']])) ? $my_list_strings[$vardef['options']] : $my_list_strings[$name];
+            $smarty->assign('ul_list', 'list = '.$json->encode(array_keys($selected_dropdown)));
+            $smarty->assign('dropdown_name', (!empty($vardef['options']) ? $vardef['options'] : $_REQUEST['dropdown_name']));
+            $smarty->assign('name', $_REQUEST['dropdown_name']);
+            $smarty->assign('options', $selected_dropdown);
+        }else{
+            $smarty->assign('ul_list', 'list = {}');
+            //we should try to find a name for this dropdown based on the field name.
+            $pre_pop_name = '';
+            if(!empty($_REQUEST['field']))
+                $pre_pop_name = $_REQUEST['field'];
+            //ensure this dropdown name does not already exist
+            $use_name = $pre_pop_name.'_list';
+            for($i = 0; $i < 100; $i++){
+                if(empty($my_list_strings[$use_name]))
+                    break;
+                else
+                    $use_name = $pre_pop_name.'_'.$i;
+            }
+            $smarty->assign('prepopulated_name', $use_name);
+        }
 
-		$smarty->assign('module_name', $module_name);
-		$smarty->assign('APP', $GLOBALS['app_strings']);
-		$smarty->assign('MOD', $GLOBALS['mod_strings']);
-		$smarty->assign('selected_lang', $selected_lang);
-		$smarty->assign('available_languages',get_languages());
-		$smarty->assign('package_name', $package_name);
- 		return $smarty;
- 	}
+        $smarty->assign('module_name', $module_name);
+        $smarty->assign('APP', $GLOBALS['app_strings']);
+        $smarty->assign('MOD', $GLOBALS['mod_strings']);
+        $smarty->assign('selected_lang', $selected_lang);
+        $smarty->assign('available_languages',get_languages());
+        $smarty->assign('package_name', $package_name);
+            return $smarty;
+        }
 }
\ No newline at end of file

Spacing +26 added lines, -26 removed lines

@@ -49,7 +49,7 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
@@ -64,57 +64,57 @@ 
 			require_once ('modules/ModuleBuilder/Module/DropDownTree.php');
 			$mbt = new DropDownTree();
 			$ajax->addSection('west', $mbt->getName(), $mbt->fetchNodes());
-			$smarty->assign('refreshTree',true);
+			$smarty->assign('refreshTree', true);
 		}
 
         global $mod_strings;
 
- 		$smarty->assign('deleteImage', SugarThemeRegistry::current()->getImage( 'delete_inline', '',null,null,'.gif',$mod_strings['LBL_MB_DELETE']));
-		$smarty->assign('editImage', SugarThemeRegistry::current()->getImage( 'edit_inline', ''
-,null,null,'.gif',$mod_strings['LBL_EDIT']));
+ 		$smarty->assign('deleteImage', SugarThemeRegistry::current()->getImage('delete_inline', '', null, null, '.gif', $mod_strings['LBL_MB_DELETE']));
+		$smarty->assign('editImage', SugarThemeRegistry::current()->getImage('edit_inline', ''
+,null, null, '.gif', $mod_strings['LBL_EDIT']));
 		$smarty->assign('action', 'savedropdown');
 		$body = $smarty->fetch('modules/ModuleBuilder/tpls/MBModule/dropdown.tpl');
-		$ajax->addSection('east2', $mod_strings['LBL_SECTION_DROPDOWNED'], $body );
+		$ajax->addSection('east2', $mod_strings['LBL_SECTION_DROPDOWNED'], $body);
  		echo $ajax->getJavascript();
  	}
  	
  	function generateSmarty()
  	{
 		//get the selected language
-		$selected_lang = (!empty($_REQUEST['dropdown_lang'])?$_REQUEST['dropdown_lang']:$_SESSION['authenticated_user_language']);
+		$selected_lang = (!empty($_REQUEST['dropdown_lang']) ? $_REQUEST['dropdown_lang'] : $_SESSION['authenticated_user_language']);
 		$vardef = array();
 		$package_name = 'studio';
 		$package_strings = array();
-		$new =false;
-		$my_list_strings = return_app_list_strings_language( $selected_lang ) ;
+		$new = false;
+		$my_list_strings = return_app_list_strings_language($selected_lang);
 //		$my_list_strings = $GLOBALS['app_list_strings'];
 
         $smarty = new Sugar_Smarty();
 		      
 		//if we are using ModuleBuilder then process the following
-		if(!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio'){
+		if (!empty($_REQUEST['view_package']) && $_REQUEST['view_package'] != 'studio') {
 			require_once('modules/ModuleBuilder/MB/ModuleBuilder.php');
 			$mb = new ModuleBuilder();
 			$module = $mb->getPackageModule($_REQUEST['view_package'], $_REQUEST['view_module']);
 			$package = $mb->packages[$_REQUEST['view_package']];
 			$package_name = $package->name;
 			$module->getVardefs();
-			if(empty($_REQUEST['dropdown_name']) && !empty($_REQUEST['field'])){
+			if (empty($_REQUEST['dropdown_name']) && !empty($_REQUEST['field'])) {
 				$new = true;
-				$_REQUEST['dropdown_name'] = $_REQUEST['field']. '_list';
+				$_REQUEST['dropdown_name'] = $_REQUEST['field'].'_list';
 			}
 			
-			$vardef = (!empty($module->mbvardefs->fields[$_REQUEST['dropdown_name']]))? $module->mbvardefs->fields[$_REQUEST['dropdown_name']]: array();
-			$module->mblanguage->generateAppStrings(false) ;
-            $my_list_strings = array_merge( $my_list_strings, $module->mblanguage->appListStrings[$selected_lang.'.lang.php'] );
+			$vardef = (!empty($module->mbvardefs->fields[$_REQUEST['dropdown_name']])) ? $module->mbvardefs->fields[$_REQUEST['dropdown_name']] : array();
+			$module->mblanguage->generateAppStrings(false);
+            $my_list_strings = array_merge($my_list_strings, $module->mblanguage->appListStrings[$selected_lang.'.lang.php']);
             $smarty->assign('module_name', $module->name);
 		}
 
-        $module_name = !empty($module->name) ?  $module->name : '';
-        $module_name = (empty($module_name) && !empty($_REQUEST['view_module'])) ?  $_REQUEST['view_module'] : $module_name;
+        $module_name = !empty($module->name) ? $module->name : '';
+        $module_name = (empty($module_name) && !empty($_REQUEST['view_module'])) ? $_REQUEST['view_module'] : $module_name;
 
-		foreach($my_list_strings as $key=>$value){
-			if(!is_array($value)){
+		foreach ($my_list_strings as $key=>$value) {
+			if (!is_array($value)) {
 				unset($my_list_strings[$key]);
 			}
 		}
@@ -129,29 +129,29 @@ 
 
 		$json = getJSONobj();
 
-		if(!empty($_REQUEST['dropdown_name']) && !$new){
+		if (!empty($_REQUEST['dropdown_name']) && !$new) {
 			$name = $_REQUEST['dropdown_name'];
 			
 			// handle the case where we've saved a dropdown in one language, and now attempt to edit it for another language. The $name exists, but $my_list_strings[$name] doesn't
             // for now, we just treat it as if it was new. A better approach might be to use the first language version as a template for future languages
             if (!isset($my_list_strings[$name]))
-                $my_list_strings[$name] = array () ;
+                $my_list_strings[$name] = array();
  
 			$selected_dropdown = (!empty($vardef['options']) && !empty($my_list_strings[$vardef['options']])) ? $my_list_strings[$vardef['options']] : $my_list_strings[$name];
 			$smarty->assign('ul_list', 'list = '.$json->encode(array_keys($selected_dropdown)));
 			$smarty->assign('dropdown_name', (!empty($vardef['options']) ? $vardef['options'] : $_REQUEST['dropdown_name']));
 			$smarty->assign('name', $_REQUEST['dropdown_name']);
 			$smarty->assign('options', $selected_dropdown);
-		}else{
+		} else {
 			$smarty->assign('ul_list', 'list = {}');
 			//we should try to find a name for this dropdown based on the field name.
 			$pre_pop_name = '';
-			if(!empty($_REQUEST['field']))
+			if (!empty($_REQUEST['field']))
 				$pre_pop_name = $_REQUEST['field'];
 			//ensure this dropdown name does not already exist
 			$use_name = $pre_pop_name.'_list';
-			for($i = 0; $i < 100; $i++){
-				if(empty($my_list_strings[$use_name]))
+			for ($i = 0; $i < 100; $i++) {
+				if (empty($my_list_strings[$use_name]))
 					break;
 				else
 					$use_name = $pre_pop_name.'_'.$i;
@@ -163,7 +163,7 @@ 
 		$smarty->assign('APP', $GLOBALS['app_strings']);
 		$smarty->assign('MOD', $GLOBALS['mod_strings']);
 		$smarty->assign('selected_lang', $selected_lang);
-		$smarty->assign('available_languages',get_languages());
+		$smarty->assign('available_languages', get_languages());
 		$smarty->assign('package_name', $package_name);
  		return $smarty;
  	}

Braces +12 added lines, -9 removed lines

@@ -134,27 +134,30 @@
 			
 			// handle the case where we've saved a dropdown in one language, and now attempt to edit it for another language. The $name exists, but $my_list_strings[$name] doesn't
             // for now, we just treat it as if it was new. A better approach might be to use the first language version as a template for future languages
-            if (!isset($my_list_strings[$name]))
-                $my_list_strings[$name] = array () ;
+            if (!isset($my_list_strings[$name])) {
+                            $my_list_strings[$name] = array () ;
+            }
  
 			$selected_dropdown = (!empty($vardef['options']) && !empty($my_list_strings[$vardef['options']])) ? $my_list_strings[$vardef['options']] : $my_list_strings[$name];
 			$smarty->assign('ul_list', 'list = '.$json->encode(array_keys($selected_dropdown)));
 			$smarty->assign('dropdown_name', (!empty($vardef['options']) ? $vardef['options'] : $_REQUEST['dropdown_name']));
 			$smarty->assign('name', $_REQUEST['dropdown_name']);
 			$smarty->assign('options', $selected_dropdown);
-		}else{
+		} else{
 			$smarty->assign('ul_list', 'list = {}');
 			//we should try to find a name for this dropdown based on the field name.
 			$pre_pop_name = '';
-			if(!empty($_REQUEST['field']))
-				$pre_pop_name = $_REQUEST['field'];
+			if(!empty($_REQUEST['field'])) {
+							$pre_pop_name = $_REQUEST['field'];
+			}
 			//ensure this dropdown name does not already exist
 			$use_name = $pre_pop_name.'_list';
 			for($i = 0; $i < 100; $i++){
-				if(empty($my_list_strings[$use_name]))
-					break;
-				else
-					$use_name = $pre_pop_name.'_'.$i;
+				if(empty($my_list_strings[$use_name])) {
+									break;
+				} else {
+									$use_name = $pre_pop_name.'_'.$i;
+				}
 			}
 			$smarty->assign('prepopulated_name', $use_name);
 		}

modules/ModuleBuilder/views/view.listview.php

Indentation +18 added lines, -18 removed lines

@@ -46,16 +46,16 @@ 
 class ViewListView extends SugarView
 {
     /**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+     * @see SugarView::_getModuleTitleParams()
+     */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
     /*
@@ -112,12 +112,12 @@ 
 
 
         $labels = array (
-        			MB_LISTVIEW => 'LBL_LISTVIEW' ,
-        			) ;
+                    MB_LISTVIEW => 'LBL_LISTVIEW' ,
+                    ) ;
         $translatedViewType = '' ;
-		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) )
-			$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
-		$this->translatedViewType = $translatedViewType;
+        if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) )
+            $translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+        $this->translatedViewType = $translatedViewType;
 
         if ($this->fromModuleBuilder)
         {
@@ -198,8 +198,8 @@ 
                 $subRef = $subList[strtolower($this->subpanel)];
                 $subTitleKey = !empty($subRef) ? $subRef : "LBL_" . strtoupper($this->subpanel) . "_SUBPANEL_TITLE";
                 $subTitle    = !empty($subRef) ? translate($subTitleKey, $this->editModule) : UCfirst($this->subpanel);
-            	$smarty->assign ( 'subpanel_label', $subTitleKey ) ;
-            	$smarty->assign ( 'subpanel_title', $subTitle ) ;
+                $smarty->assign ( 'subpanel_label', $subTitleKey ) ;
+                $smarty->assign ( 'subpanel_title', $subTitle ) ;
             }
         }
         $helpName = $this->subpanel ? 'subPanelEditor' : 'listViewEditor';
@@ -321,11 +321,11 @@ 
 
     function _buildImageButtons ($buttons , $horizontal = true)
     {
-    	$text = '<table cellspacing=2><tr>' ;
+        $text = '<table cellspacing=2><tr>' ;
         foreach ( $buttons as $button )
         {
             if (empty($button['id'])) {
-            	$button['id'] = $button['name'];
+                $button['id'] = $button['name'];
             }
             if (! $horizontal)
             {

Spacing +125 added lines, -125 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
-    die ( 'Not A Valid Entry Point' ) ;
+if (!defined('sugarEntry') || !sugarEntry)
+    die ('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -40,8 +40,8 @@ 
  ********************************************************************************/
 
 
-require_once 'modules/ModuleBuilder/parsers/constants.php' ;
-require_once ('include/SubPanel/SubPanel.php') ;
+require_once 'modules/ModuleBuilder/parsers/constants.php';
+require_once ('include/SubPanel/SubPanel.php');
 
 class ViewListView extends SugarView
 {
@@ -53,7 +53,7 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
@@ -63,224 +63,224 @@ 
      */
     function __construct()
     {
-        $this->editModule = $_REQUEST [ 'view_module' ] ;
-        $this->editLayout = $_REQUEST [ 'view' ] ;
-        $this->subpanel = (! empty ( $_REQUEST [ 'subpanel' ] )) ? $_REQUEST [ 'subpanel' ] : false ;
-        $this->subpanelLabel = (! empty ( $_REQUEST [ 'subpanelLabel' ] )) ? $_REQUEST [ 'subpanelLabel' ] : false ;
+        $this->editModule = $_REQUEST ['view_module'];
+        $this->editLayout = $_REQUEST ['view'];
+        $this->subpanel = (!empty ($_REQUEST ['subpanel'])) ? $_REQUEST ['subpanel'] : false;
+        $this->subpanelLabel = (!empty ($_REQUEST ['subpanelLabel'])) ? $_REQUEST ['subpanelLabel'] : false;
 
-        $this->fromModuleBuilder = ! empty ( $_REQUEST [ 'view_package' ] ) ;
-        if (! $this->fromModuleBuilder)
+        $this->fromModuleBuilder = !empty ($_REQUEST ['view_package']);
+        if (!$this->fromModuleBuilder)
         {
-            $moduleNames = array_change_key_case ( $GLOBALS['app_list_strings'] [ 'moduleList' ] ) ;
-            $this->translatedEditModule = $moduleNames [ strtolower ( $this->editModule ) ] ;
+            $moduleNames = array_change_key_case($GLOBALS['app_list_strings'] ['moduleList']);
+            $this->translatedEditModule = $moduleNames [strtolower($this->editModule)];
         }
     }
 
     // DO NOT REMOVE - overrides parent ViewEdit preDisplay() which attempts to load a bean for a non-existent module
-    function preDisplay ()
+    function preDisplay()
     {
     }
 
-    function display ($preview = false)
+    function display($preview = false)
     {
 
-        $packageName = (! empty ( $_REQUEST [ 'view_package' ] )) ? $_REQUEST [ 'view_package' ] : null ;
-        $subpanelName = (! empty ( $_REQUEST [ 'subpanel' ] )) ? $_REQUEST [ 'subpanel' ] : null ;
-        require_once 'modules/ModuleBuilder/parsers/ParserFactory.php' ;
-        $parser = ParserFactory::getParser (  $this->editLayout , $this->editModule , $packageName, $subpanelName ) ;
-        $smarty = $this->constructSmarty ( $parser ) ;
+        $packageName = (!empty ($_REQUEST ['view_package'])) ? $_REQUEST ['view_package'] : null;
+        $subpanelName = (!empty ($_REQUEST ['subpanel'])) ? $_REQUEST ['subpanel'] : null;
+        require_once 'modules/ModuleBuilder/parsers/ParserFactory.php';
+        $parser = ParserFactory::getParser($this->editLayout, $this->editModule, $packageName, $subpanelName);
+        $smarty = $this->constructSmarty($parser);
 
         if ($preview)
         {
-            echo $smarty->fetch ( "modules/ModuleBuilder/tpls/Preview/listView.tpl" ) ;
+            echo $smarty->fetch("modules/ModuleBuilder/tpls/Preview/listView.tpl");
         } else
         {
-            $ajax = $this->constructAjax () ;
-            $ajax->addSection ( 'center', $this->translatedViewType, $smarty->fetch ( "modules/ModuleBuilder/tpls/listView.tpl" ) ) ;
+            $ajax = $this->constructAjax();
+            $ajax->addSection('center', $this->translatedViewType, $smarty->fetch("modules/ModuleBuilder/tpls/listView.tpl"));
 
-            echo $ajax->getJavascript () ;
+            echo $ajax->getJavascript();
         }
     }
 
-    function constructAjax ()
+    function constructAjax()
     {
-        require_once ('modules/ModuleBuilder/MB/AjaxCompose.php') ;
-        $ajax = new AjaxCompose ( ) ;
+        require_once ('modules/ModuleBuilder/MB/AjaxCompose.php');
+        $ajax = new AjaxCompose( );
 
-        $layoutLabel = 'LBL_LAYOUTS' ;
-        $layoutView = 'layouts' ;
+        $layoutLabel = 'LBL_LAYOUTS';
+        $layoutView = 'layouts';
 
 
-        $labels = array (
-        			MB_LISTVIEW => 'LBL_LISTVIEW' ,
-        			) ;
-        $translatedViewType = '' ;
-		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) )
-			$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+        $labels = array(
+        			MB_LISTVIEW => 'LBL_LISTVIEW',
+        			);
+        $translatedViewType = '';
+		if (isset ($labels [strtolower($this->editLayout)]))
+			$translatedViewType = translate($labels [strtolower($this->editLayout)], 'ModuleBuilder');
 		$this->translatedViewType = $translatedViewType;
 
         if ($this->fromModuleBuilder)
         {
-            $ajax->addCrumb ( translate ( 'LBL_MODULEBUILDER', 'ModuleBuilder' ), 'ModuleBuilder.main("mb")' ) ;
-            $ajax->addCrumb ( $_REQUEST [ 'view_package' ], 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package=' . $_REQUEST [ 'view_package' ] . '")' ) ;
-            $ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package=' . $_REQUEST [ 'view_package' ] . '&view_module=' . $_REQUEST [ 'view_module' ] . '")' ) ;
+            $ajax->addCrumb(translate('LBL_MODULEBUILDER', 'ModuleBuilder'), 'ModuleBuilder.main("mb")');
+            $ajax->addCrumb($_REQUEST ['view_package'], 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$_REQUEST ['view_package'].'")');
+            $ajax->addCrumb($this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package='.$_REQUEST ['view_package'].'&view_module='.$_REQUEST ['view_module'].'")');
             if ($this->subpanel != "")
             {
-                $ajax->addCrumb ( translate ( 'LBL_AVAILABLE_SUBPANELS', 'ModuleBuilder' ), '' ) ;
+                $ajax->addCrumb(translate('LBL_AVAILABLE_SUBPANELS', 'ModuleBuilder'), '');
                 if ($this->subpanelLabel)
                 {
                     $subpanelLabel = $this->subpanelLabel;
                     // If the subpanel title has changed, use that for the label instead
-                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] )
+                    if (!empty($_REQUEST['subpanel_title']) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'])
                         $subpanelLabel = $_REQUEST['subpanel_title'];
 
-                    $ajax->addCrumb( $subpanelLabel, '' );
-                    $this->translatedViewType = $subpanelLabel . "&nbsp;" . translate("LBL_SUBPANEL", "ModuleBuilder");
+                    $ajax->addCrumb($subpanelLabel, '');
+                    $this->translatedViewType = $subpanelLabel."&nbsp;".translate("LBL_SUBPANEL", "ModuleBuilder");
                 } else
                 {
-                    $ajax->addCrumb ( $this->subpanel, '' ) ;
+                    $ajax->addCrumb($this->subpanel, '');
                     $this->translatedViewType = translate("LBL_SUBPANEL", "ModuleBuilder");
                 }
             } else
             {
-                $ajax->addCrumb ( translate ( $layoutLabel, 'ModuleBuilder' ), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view_module=' . $_REQUEST [ 'view_module' ] . '&view_package=' . $_REQUEST [ 'view_package' ] . '")' ) ;
-                $ajax->addCrumb ( $translatedViewType, '' ) ;
+                $ajax->addCrumb(translate($layoutLabel, 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&MB=true&action=wizard&view_module='.$_REQUEST ['view_module'].'&view_package='.$_REQUEST ['view_package'].'")');
+                $ajax->addCrumb($translatedViewType, '');
             }
         } else
         {
-            $ajax->addCrumb ( translate ( 'LBL_STUDIO', 'ModuleBuilder' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard")' ) ;
-            $ajax->addCrumb ( $this->translatedEditModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module=' . $this->editModule . '")' ) ;
+            $ajax->addCrumb(translate('LBL_STUDIO', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard")');
+            $ajax->addCrumb($this->translatedEditModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module='.$this->editModule.'")');
 
             if ($this->subpanel)
             {
-                $ajax->addCrumb ( translate ( 'LBL_SUBPANELS', 'ModuleBuilder' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=subpanels&view_module=' . $this->editModule . '")' ) ;
+                $ajax->addCrumb(translate('LBL_SUBPANELS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=subpanels&view_module='.$this->editModule.'")');
                 if ($this->subpanelLabel)
                 {
                     $subpanelLabel = $this->subpanelLabel;
                     // If the subpanel title has changed, use that for the label instead
-                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] )
+                    if (!empty($_REQUEST['subpanel_title']) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'])
                         $subpanelLabel = $_REQUEST['subpanel_title'];
 
-                    $ajax->addCrumb( $subpanelLabel, '' );
-                    $this->translatedViewType = $subpanelLabel . "&nbsp;" . translate("LBL_SUBPANEL", "ModuleBuilder");
+                    $ajax->addCrumb($subpanelLabel, '');
+                    $this->translatedViewType = $subpanelLabel."&nbsp;".translate("LBL_SUBPANEL", "ModuleBuilder");
                 } else
                 {
-                    $ajax->addCrumb ( $this->subpanel, '' ) ;
+                    $ajax->addCrumb($this->subpanel, '');
                     $this->translatedViewType = translate("LBL_SUBPANEL", "ModuleBuilder");
                 }
             } else
             {
-                $ajax->addCrumb ( translate ( $layoutLabel, 'ModuleBuilder' ), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view='.$layoutView.'&view_module=' . $this->editModule . '")' ) ;
-                $ajax->addCrumb ( $translatedViewType, '' ) ;
+                $ajax->addCrumb(translate($layoutLabel, 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view='.$layoutView.'&view_module='.$this->editModule.'")');
+                $ajax->addCrumb($translatedViewType, '');
             }
         }
-        return $ajax ;
+        return $ajax;
     }
 
-    function constructSmarty ($parser)
+    function constructSmarty($parser)
     {
         global $mod_strings;
-        $smarty = new Sugar_Smarty ( ) ;
-        $smarty->assign ( 'translate', true ) ;
-        $smarty->assign ( 'language', $parser->getLanguage () ) ;
-
-        $smarty->assign ( 'view', $this->editLayout ) ;
-        $smarty->assign ( 'module', "ModuleBuilder" ) ;
-        $smarty->assign ( 'field_defs', $parser->getFieldDefs () ) ;
-        $smarty->assign ( 'action', 'listViewSave' ) ;
-        $smarty->assign ( 'view_module', $this->editModule ) ;
-        if (!empty ( $this->subpanel ) )
+        $smarty = new Sugar_Smarty( );
+        $smarty->assign('translate', true);
+        $smarty->assign('language', $parser->getLanguage());
+
+        $smarty->assign('view', $this->editLayout);
+        $smarty->assign('module', "ModuleBuilder");
+        $smarty->assign('field_defs', $parser->getFieldDefs());
+        $smarty->assign('action', 'listViewSave');
+        $smarty->assign('view_module', $this->editModule);
+        if (!empty ($this->subpanel))
         {
-            $smarty->assign ( 'subpanel', $this->subpanel ) ;
-            $smarty->assign ( 'subpanelLabel', $this->subpanelLabel ) ;
+            $smarty->assign('subpanel', $this->subpanel);
+            $smarty->assign('subpanelLabel', $this->subpanelLabel);
             if (!$this->fromModuleBuilder) {
-                $subList =  SubPanel::getModuleSubpanels ( $this->editModule);
+                $subList = SubPanel::getModuleSubpanels($this->editModule);
                 $subRef = $subList[strtolower($this->subpanel)];
-                $subTitleKey = !empty($subRef) ? $subRef : "LBL_" . strtoupper($this->subpanel) . "_SUBPANEL_TITLE";
+                $subTitleKey = !empty($subRef) ? $subRef : "LBL_".strtoupper($this->subpanel)."_SUBPANEL_TITLE";
                 $subTitle    = !empty($subRef) ? translate($subTitleKey, $this->editModule) : UCfirst($this->subpanel);
-            	$smarty->assign ( 'subpanel_label', $subTitleKey ) ;
-            	$smarty->assign ( 'subpanel_title', $subTitle ) ;
+            	$smarty->assign('subpanel_label', $subTitleKey);
+            	$smarty->assign('subpanel_title', $subTitle);
             }
         }
         $helpName = $this->subpanel ? 'subPanelEditor' : 'listViewEditor';
-        $smarty->assign ( 'helpName', $helpName ) ;
-        $smarty->assign ( 'helpDefault', 'modify' ) ;
+        $smarty->assign('helpName', $helpName);
+        $smarty->assign('helpDefault', 'modify');
 
-        $smarty->assign ( 'title', $this->_constructTitle () ) ;
-        $groups = array ( ) ;
-        foreach ( $parser->columns as $column => $function )
+        $smarty->assign('title', $this->_constructTitle());
+        $groups = array( );
+        foreach ($parser->columns as $column => $function)
         {
             // update this so that each field has a properties set
             // properties are name, value, title (optional)
-            $groups [ $GLOBALS [ 'mod_strings' ] [ $column ] ] = $parser->$function () ; // call the parser functions to populate the list view columns, by default 'default', 'available' and 'hidden'
+            $groups [$GLOBALS ['mod_strings'] [$column]] = $parser->$function(); // call the parser functions to populate the list view columns, by default 'default', 'available' and 'hidden'
         }
-        foreach ( $groups as $groupKey => $group )
+        foreach ($groups as $groupKey => $group)
         {
-            foreach ( $group as $fieldKey => $field )
+            foreach ($group as $fieldKey => $field)
             {
-                if (isset ( $field [ 'width' ] ))
+                if (isset ($field ['width']))
                 {
-                    if (substr ( $field [ 'width' ], - 1, 1 ) == '%')
+                    if (substr($field ['width'], - 1, 1) == '%')
                     {
 
-                        $groups [ $groupKey ] [ $fieldKey ] [ 'width' ] = substr ( $field [ 'width' ], 0, strlen ( $field [ 'width' ] ) - 1 ) ;
+                        $groups [$groupKey] [$fieldKey] ['width'] = substr($field ['width'], 0, strlen($field ['width']) - 1);
                     }
                 }
             }
         }
 
-        $smarty->assign ( 'groups', $groups ) ;
+        $smarty->assign('groups', $groups);
         $smarty->assign('from_mb', $this->fromModuleBuilder);
 
         global $image_path;
-        $imageSave = SugarThemeRegistry::current()->getImage('studio_save','',null,null,'.gif',$mod_strings['LBL_BTN_SAVE']) ;
+        $imageSave = SugarThemeRegistry::current()->getImage('studio_save', '', null, null, '.gif', $mod_strings['LBL_BTN_SAVE']);
 
 //        $imageHelp = SugarThemeRegistry::current()->getImage('help') ;
 
 
-        $history = $parser->getHistory () ;
+        $history = $parser->getHistory();
 
-        $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
+        $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")";
         if ($this->subpanel)
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->subpanel}\")" ;
+            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->subpanel}\")";
 
         $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"\")'";
         if ($this->subpanel)
             $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"{$this->subpanel}\")'";
 
-        $buttons = array ( ) ;
-        $buttons [] = array ( 'id' =>'savebtn', 'name' => 'savebtn' , 'image' => $imageSave , 'text' => (! $this->fromModuleBuilder)?$GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVEPUBLISH' ]: $GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVE' ], 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");if (countListFields()==0) ModuleBuilder.layoutValidation.popup() ; else ModuleBuilder.handleSave(\"edittabs\" )'" ) ;
-        $buttons [] = array ( 'id' => 'spacer' , 'width' => '50px' ) ;
-        $buttons [] = array ( 'id' =>'historyBtn',       'name' => 'historyBtn' , 'text' => translate ( 'LBL_HISTORY' ) , 'actionScript' => "onclick='$histaction'" ) ;
-        $buttons [] = array ( 'id' => 'historyDefault' , 'name' => 'historyDefault',  'text' => translate ( 'LBL_RESTORE_DEFAULT' ) , 'actionScript' => $restoreAction ) ;
+        $buttons = array( );
+        $buttons [] = array('id' =>'savebtn', 'name' => 'savebtn', 'image' => $imageSave, 'text' => (!$this->fromModuleBuilder) ? $GLOBALS ['mod_strings'] ['LBL_BTN_SAVEPUBLISH'] : $GLOBALS ['mod_strings'] ['LBL_BTN_SAVE'], 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");if (countListFields()==0) ModuleBuilder.layoutValidation.popup() ; else ModuleBuilder.handleSave(\"edittabs\" )'");
+        $buttons [] = array('id' => 'spacer', 'width' => '50px');
+        $buttons [] = array('id' =>'historyBtn', 'name' => 'historyBtn', 'text' => translate('LBL_HISTORY'), 'actionScript' => "onclick='$histaction'");
+        $buttons [] = array('id' => 'historyDefault', 'name' => 'historyDefault', 'text' => translate('LBL_RESTORE_DEFAULT'), 'actionScript' => $restoreAction);
 
-        $smarty->assign ( 'buttons', $this->_buildImageButtons ( $buttons ) ) ;
+        $smarty->assign('buttons', $this->_buildImageButtons($buttons));
 
-        $editImage = SugarThemeRegistry::current()->getImage('edit_inline','',null,null,'.gif',$mod_strings['LBL_EDIT']) ;
+        $editImage = SugarThemeRegistry::current()->getImage('edit_inline', '', null, null, '.gif', $mod_strings['LBL_EDIT']);
 
-        $smarty->assign ( 'editImage', $editImage ) ;
-        $deleteImage = SugarThemeRegistry::current()->getImage('delete_inline','',null,null,'.gif',$mod_strings['LBL_MB_DELETE']) ;
+        $smarty->assign('editImage', $editImage);
+        $deleteImage = SugarThemeRegistry::current()->getImage('delete_inline', '', null, null, '.gif', $mod_strings['LBL_MB_DELETE']);
 
-        $smarty->assign ( 'deleteImage', $deleteImage ) ;
-        $smarty->assign ( 'MOD', $GLOBALS [ 'mod_strings' ] ) ;
+        $smarty->assign('deleteImage', $deleteImage);
+        $smarty->assign('MOD', $GLOBALS ['mod_strings']);
 
         if ($this->fromModuleBuilder)
         {
-            $smarty->assign ( 'MB', true ) ;
-            $smarty->assign ( 'view_package', $_REQUEST [ 'view_package' ] ) ;
-            $mb = new ModuleBuilder ( ) ;
-            $module = & $mb->getPackageModule ( $_REQUEST [ 'view_package' ], $this->editModule ) ;
+            $smarty->assign('MB', true);
+            $smarty->assign('view_package', $_REQUEST ['view_package']);
+            $mb = new ModuleBuilder( );
+            $module = & $mb->getPackageModule($_REQUEST ['view_package'], $this->editModule);
             $smarty->assign('current_mod_strings', $module->getModStrings());
             if ($this->subpanel)
             {
-                if (isset ( $_REQUEST [ 'local' ] ))
+                if (isset ($_REQUEST ['local']))
                 {
-                    $smarty->assign ( 'local', '1' ) ;
+                    $smarty->assign('local', '1');
                 }
-                $smarty->assign ( "subpanel", $this->subpanel ) ;
+                $smarty->assign("subpanel", $this->subpanel);
             } else
             {
-                $smarty->assign ( 'description', $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_DESCRIPTION' ] ) ;
+                $smarty->assign('description', $GLOBALS ['mod_strings'] ['LBL_LISTVIEW_DESCRIPTION']);
 
             }
 
@@ -288,55 +288,55 @@ 
         {
             if ($this->subpanel)
             {
-                $smarty->assign ( "subpanel", "$this->subpanel" ) ;
+                $smarty->assign("subpanel", "$this->subpanel");
             } else
             {
-                $smarty->assign ( 'description', $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_DESCRIPTION' ] ) ;
+                $smarty->assign('description', $GLOBALS ['mod_strings'] ['LBL_LISTVIEW_DESCRIPTION']);
             }
         }
 
-        return $smarty ;
+        return $smarty;
     }
 
-    function _constructTitle ()
+    function _constructTitle()
 
     {
 
-        global $app_list_strings ;
+        global $app_list_strings;
 
         if ($this->fromModuleBuilder)
         {
-            $title = $this->editModule ;
+            $title = $this->editModule;
             if ($this->subpanel != "")
             {
-                $title .= ":$this->subpanel" ;
+                $title .= ":$this->subpanel";
             }
         } else
         {
-            $title = ($this->subpanel) ? ':' . $this->subpanel : $app_list_strings [ 'moduleList' ] [ $this->editModule ] ;
+            $title = ($this->subpanel) ? ':'.$this->subpanel : $app_list_strings ['moduleList'] [$this->editModule];
         }
-        return $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_EDIT' ] . ':&nbsp;' . $title ;
+        return $GLOBALS ['mod_strings'] ['LBL_LISTVIEW_EDIT'].':&nbsp;'.$title;
 
     }
 
-    function _buildImageButtons ($buttons , $horizontal = true)
+    function _buildImageButtons($buttons, $horizontal = true)
     {
-    	$text = '<table cellspacing=2><tr>' ;
-        foreach ( $buttons as $button )
+    	$text = '<table cellspacing=2><tr>';
+        foreach ($buttons as $button)
         {
             if (empty($button['id'])) {
             	$button['id'] = $button['name'];
             }
-            if (! $horizontal)
+            if (!$horizontal)
             {
-                $text .= '</tr><tr>' ;
+                $text .= '</tr><tr>';
             }
             if ($button['id'] == "spacer") {
                 $text .= "<td style='width:{$button['width']}'> </td>";
                 continue;
             }
 
-            if (! empty ( $button [ 'plain' ] ))
+            if (!empty ($button ['plain']))
             {
                 $text .= <<<EOQ
 	             <td><input name={$button['name']} id={$button['id']} class="button" type="button" valign='center' {$button['actionScript']}
@@ -348,9 +348,9 @@ 
 	          <td><input name={$button['name']} id={$button['id']} class="button" type="button" valign='center' style='cursor:default'  {$button['actionScript']}
 EOQ;
             }
-            $text .= "value=\"{$button['text']}\"/></td>" ;
+            $text .= "value=\"{$button['text']}\"/></td>";
         }
-        $text .= '</tr></table>' ;
-        return $text ;
+        $text .= '</tr></table>';
+        return $text;
     }
 }

Braces +17 added lines, -11 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -115,8 +116,9 @@ 
         			MB_LISTVIEW => 'LBL_LISTVIEW' ,
         			) ;
         $translatedViewType = '' ;
-		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) )
-			$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+		if ( isset ( $labels [ strtolower ( $this->editLayout ) ] ) ) {
+					$translatedViewType = translate ( $labels [ strtolower( $this->editLayout ) ] , 'ModuleBuilder' ) ;
+		}
 		$this->translatedViewType = $translatedViewType;
 
         if ($this->fromModuleBuilder)
@@ -131,8 +133,9 @@ 
                 {
                     $subpanelLabel = $this->subpanelLabel;
                     // If the subpanel title has changed, use that for the label instead
-                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] )
-                        $subpanelLabel = $_REQUEST['subpanel_title'];
+                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] ) {
+                                            $subpanelLabel = $_REQUEST['subpanel_title'];
+                    }
 
                     $ajax->addCrumb( $subpanelLabel, '' );
                     $this->translatedViewType = $subpanelLabel . "&nbsp;" . translate("LBL_SUBPANEL", "ModuleBuilder");
@@ -158,8 +161,9 @@ 
                 {
                     $subpanelLabel = $this->subpanelLabel;
                     // If the subpanel title has changed, use that for the label instead
-                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] )
-                        $subpanelLabel = $_REQUEST['subpanel_title'];
+                    if( !empty($_REQUEST['subpanel_title'] ) && $_REQUEST['subpanelLabel'] != $_REQUEST['subpanel_title'] ) {
+                                            $subpanelLabel = $_REQUEST['subpanel_title'];
+                    }
 
                     $ajax->addCrumb( $subpanelLabel, '' );
                     $this->translatedViewType = $subpanelLabel . "&nbsp;" . translate("LBL_SUBPANEL", "ModuleBuilder");
@@ -241,12 +245,14 @@ 
         $history = $parser->getHistory () ;
 
         $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
-        if ($this->subpanel)
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->subpanel}\")" ;
+        if ($this->subpanel) {
+                    $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->subpanel}\")" ;
+        }
 
         $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"\")'";
-        if ($this->subpanel)
-            $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"{$this->subpanel}\")'";
+        if ($this->subpanel) {
+                    $restoreAction = "onclick='ModuleBuilder.history.revert(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$history->getLast()}\", \"{$this->subpanel}\")'";
+        }
 
         $buttons = array ( ) ;
         $buttons [] = array ( 'id' =>'savebtn', 'name' => 'savebtn' , 'image' => $imageSave , 'text' => (! $this->fromModuleBuilder)?$GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVEPUBLISH' ]: $GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVE' ], 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");if (countListFields()==0) ModuleBuilder.layoutValidation.popup() ; else ModuleBuilder.handleSave(\"edittabs\" )'" ) ;

modules/ModuleBuilder/views/view.dashlet.php

Indentation +17 added lines, -17 removed lines

@@ -68,16 +68,16 @@ 
     }
 
     /**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+     * @see SugarView::_getModuleTitleParams()
+     */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
     // DO NOT REMOVE - overrides parent ViewEdit preDisplay() which attempts to load a bean for a non-existent module
@@ -97,12 +97,12 @@ 
         $smarty = $this->constructSmarty ( $parser ) ;
         if ($preview)
         {
-        	echo $smarty->fetch ( "modules/ModuleBuilder/tpls/Preview/listView.tpl" ) ;
+            echo $smarty->fetch ( "modules/ModuleBuilder/tpls/Preview/listView.tpl" ) ;
         } else
         {
-        	$ajax = $this->constructAjax () ;
-        	$ajax->addSection ( 'center', translate('LBL_DASHLET'), $smarty->fetch ( "modules/ModuleBuilder/tpls/listView.tpl" ) ) ;
-        	echo $ajax->getJavascript () ;
+            $ajax = $this->constructAjax () ;
+            $ajax->addSection ( 'center', translate('LBL_DASHLET'), $smarty->fetch ( "modules/ModuleBuilder/tpls/listView.tpl" ) ) ;
+            echo $ajax->getJavascript () ;
         }
     }
 
@@ -145,11 +145,11 @@ 
         $helpName = (isset( $_REQUEST['view']) && $_REQUEST['view']=='dashletsearch') ? 'searchViewEditor' : 'listViewEditor';
         $smarty->assign ( 'helpName', $helpName ) ;
         $smarty->assign ( 'helpDefault', 'modify' ) ;
-    	if ($this->fromModuleBuilder) {
-			$mb = new ModuleBuilder ( ) ;
+        if ($this->fromModuleBuilder) {
+            $mb = new ModuleBuilder ( ) ;
             $module = & $mb->getPackageModule ( $this->editPackage, $this->editModule ) ;
-		    $smarty->assign('current_mod_strings', $module->getModStrings());
-		}
+            $smarty->assign('current_mod_strings', $module->getModStrings());
+        }
         $smarty->assign ( 'title', $this->_constructTitle () ) ;
         $groups = array ( ) ;
         foreach ( $parser->columns as $column => $function )

Spacing +80 added lines, -80 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
-    die ( 'Not A Valid Entry Point' ) ;
+if (!defined('sugarEntry') || !sugarEntry)
+    die ('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -43,27 +43,27 @@ 
 
 
 
-require_once ('modules/ModuleBuilder/views/view.listview.php') ;
-require_once 'modules/ModuleBuilder/parsers/constants.php' ;
+require_once ('modules/ModuleBuilder/views/view.listview.php');
+require_once 'modules/ModuleBuilder/parsers/constants.php';
 
 class ViewDashlet extends ViewListView
 {
     function __construct()
     {
-        $this->editModule = $_REQUEST [ 'view_module' ] ;
-        $this->editLayout = $_REQUEST [ 'view' ] ;
-        if(isset ( $_REQUEST [ 'view_package' ] ) && ! empty ( $_REQUEST [ 'view_package' ] ))
-            $this->editPackage = $_REQUEST [ 'view_package' ];
+        $this->editModule = $_REQUEST ['view_module'];
+        $this->editLayout = $_REQUEST ['view'];
+        if (isset ($_REQUEST ['view_package']) && !empty ($_REQUEST ['view_package']))
+            $this->editPackage = $_REQUEST ['view_package'];
         else
             $this->editPackage = null;
 
-        $this->fromModuleBuilder = isset ( $_REQUEST [ 'MB' ] ) || (isset($_REQUEST['view_package']) && $_REQUEST['view_package'] && $_REQUEST['view_package'] != 'studio') ;
+        $this->fromModuleBuilder = isset ($_REQUEST ['MB']) || (isset($_REQUEST['view_package']) && $_REQUEST['view_package'] && $_REQUEST['view_package'] != 'studio');
 
         if (!$this->fromModuleBuilder)
         {
-            global $app_list_strings ;
-            $moduleNames = array_change_key_case ( $app_list_strings [ 'moduleList' ] ) ;
-            $this->translatedEditModule = $moduleNames [ strtolower ( $this->editModule ) ] ;
+            global $app_list_strings;
+            $moduleNames = array_change_key_case($app_list_strings ['moduleList']);
+            $this->translatedEditModule = $moduleNames [strtolower($this->editModule)];
         }
     }
 
@@ -75,7 +75,7 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
@@ -91,141 +91,141 @@ 
     {
 
 
-        require_once 'modules/ModuleBuilder/parsers/ParserFactory.php' ;
-        $parser = ParserFactory::getParser ( $this->editLayout, $this->editModule, $this->editPackage) ;
+        require_once 'modules/ModuleBuilder/parsers/ParserFactory.php';
+        $parser = ParserFactory::getParser($this->editLayout, $this->editModule, $this->editPackage);
 
-        $smarty = $this->constructSmarty ( $parser ) ;
+        $smarty = $this->constructSmarty($parser);
         if ($preview)
         {
-        	echo $smarty->fetch ( "modules/ModuleBuilder/tpls/Preview/listView.tpl" ) ;
+        	echo $smarty->fetch("modules/ModuleBuilder/tpls/Preview/listView.tpl");
         } else
         {
-        	$ajax = $this->constructAjax () ;
-        	$ajax->addSection ( 'center', translate('LBL_DASHLET'), $smarty->fetch ( "modules/ModuleBuilder/tpls/listView.tpl" ) ) ;
-        	echo $ajax->getJavascript () ;
+        	$ajax = $this->constructAjax();
+        	$ajax->addSection('center', translate('LBL_DASHLET'), $smarty->fetch("modules/ModuleBuilder/tpls/listView.tpl"));
+        	echo $ajax->getJavascript();
         }
     }
 
     function constructAjax()
     {
-        require_once ('modules/ModuleBuilder/MB/AjaxCompose.php') ;
-        $ajax = new AjaxCompose ( ) ;
+        require_once ('modules/ModuleBuilder/MB/AjaxCompose.php');
+        $ajax = new AjaxCompose( );
 
         if ($this->fromModuleBuilder)
         {
-            $ajax->addCrumb ( translate ( 'LBL_MODULEBUILDER', 'ModuleBuilder' ), 'ModuleBuilder.main("mb")' ) ;
-            $ajax->addCrumb ( $_REQUEST [ 'view_package' ], 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package=' . $this->editPackage . '")' ) ;
-            $ajax->addCrumb ( $this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package=' . $this->editPackage . '&view_module=' . $this->editModule . '")' ) ;
-            $ajax->addCrumb ( translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&MB=1&view_package='.$this->editPackage.'&view_module=' . $this->editModule . '")');
-            $ajax->addCrumb ( translate('LBL_DASHLET', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=dashlet&MB=1&view_package='.$this->editPackage.'&view_module=' . $this->editModule . '")' );
+            $ajax->addCrumb(translate('LBL_MODULEBUILDER', 'ModuleBuilder'), 'ModuleBuilder.main("mb")');
+            $ajax->addCrumb($_REQUEST ['view_package'], 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$this->editPackage.'")');
+            $ajax->addCrumb($this->editModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package='.$this->editPackage.'&view_module='.$this->editModule.'")');
+            $ajax->addCrumb(translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&MB=1&view_package='.$this->editPackage.'&view_module='.$this->editModule.'")');
+            $ajax->addCrumb(translate('LBL_DASHLET', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=dashlet&MB=1&view_package='.$this->editPackage.'&view_module='.$this->editModule.'")');
 
             $ViewLabel = ($this->editLayout == MB_DASHLET) ? 'LBL_DASHLETLISTVIEW' : 'LBL_DASHLETSEARCHVIEW';
-            $ajax->addCrumb ( translate ($ViewLabel, 'ModuleBuilder' ), '' ) ;
-        }else{
-            $ajax->addCrumb ( translate($this->editModule), 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '")' ) ;
-            $ajax->addCrumb ( translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&view_module=' . $this->editModule . '")');
-            $ajax->addCrumb ( translate('LBL_DASHLET', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=dashlet&view_module=' . $this->editModule . '")' );
+            $ajax->addCrumb(translate($ViewLabel, 'ModuleBuilder'), '');
+        } else {
+            $ajax->addCrumb(translate($this->editModule), 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module='.$this->editModule.'")');
+            $ajax->addCrumb(translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&view_module='.$this->editModule.'")');
+            $ajax->addCrumb(translate('LBL_DASHLET', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=dashlet&view_module='.$this->editModule.'")');
             $ViewLabel = ($this->editLayout == MB_DASHLET) ? 'LBL_DASHLETLISTVIEW' : 'LBL_DASHLETSEARCHVIEW';
-            $ajax->addCrumb ( translate ($ViewLabel, 'ModuleBuilder' ), '' ) ;
+            $ajax->addCrumb(translate($ViewLabel, 'ModuleBuilder'), '');
         }
-        return $ajax ;
+        return $ajax;
     }
 
     function constructSmarty($parser)
     {
-        $smarty = new Sugar_Smarty ( ) ;
-        $smarty->assign ( 'translate', true ) ;
-        $smarty->assign ( 'language', $parser->getLanguage () ) ;
+        $smarty = new Sugar_Smarty( );
+        $smarty->assign('translate', true);
+        $smarty->assign('language', $parser->getLanguage());
 		
-        $smarty->assign ( 'view', $this->editLayout ) ;
-        $smarty->assign ( 'action', 'dashletSave' ) ;
-        $smarty->assign( 'module', 'ModuleBuilder');
-        $smarty->assign ( 'view_module', $this->editModule ) ;
-        $smarty->assign ( 'field_defs', $parser->getFieldDefs () ) ;
-        $helpName = (isset( $_REQUEST['view']) && $_REQUEST['view']=='dashletsearch') ? 'searchViewEditor' : 'listViewEditor';
-        $smarty->assign ( 'helpName', $helpName ) ;
-        $smarty->assign ( 'helpDefault', 'modify' ) ;
+        $smarty->assign('view', $this->editLayout);
+        $smarty->assign('action', 'dashletSave');
+        $smarty->assign('module', 'ModuleBuilder');
+        $smarty->assign('view_module', $this->editModule);
+        $smarty->assign('field_defs', $parser->getFieldDefs());
+        $helpName = (isset($_REQUEST['view']) && $_REQUEST['view'] == 'dashletsearch') ? 'searchViewEditor' : 'listViewEditor';
+        $smarty->assign('helpName', $helpName);
+        $smarty->assign('helpDefault', 'modify');
     	if ($this->fromModuleBuilder) {
-			$mb = new ModuleBuilder ( ) ;
-            $module = & $mb->getPackageModule ( $this->editPackage, $this->editModule ) ;
+			$mb = new ModuleBuilder( );
+            $module = & $mb->getPackageModule($this->editPackage, $this->editModule);
 		    $smarty->assign('current_mod_strings', $module->getModStrings());
 		}
-        $smarty->assign ( 'title', $this->_constructTitle () ) ;
-        $groups = array ( ) ;
-        foreach ( $parser->columns as $column => $function )
+        $smarty->assign('title', $this->_constructTitle());
+        $groups = array( );
+        foreach ($parser->columns as $column => $function)
         {
             // update this so that each field has a properties set
             // properties are name, value, title (optional)
-            $groups [ $GLOBALS [ 'mod_strings' ] [ $column ] ] = $parser->$function () ; // call the parser functions to populate the list view columns, by default 'default', 'available' and 'hidden'
+            $groups [$GLOBALS ['mod_strings'] [$column]] = $parser->$function(); // call the parser functions to populate the list view columns, by default 'default', 'available' and 'hidden'
         }
-        foreach ( $groups as $groupKey => $group )
+        foreach ($groups as $groupKey => $group)
         {
-            foreach ( $group as $fieldKey => $field )
+            foreach ($group as $fieldKey => $field)
             {
-                if (isset ( $field [ 'width' ] ))
+                if (isset ($field ['width']))
                 {
-                    if (substr ( $field [ 'width' ], - 1, 1 ) == '%')
+                    if (substr($field ['width'], - 1, 1) == '%')
                     {
 
-                        $groups [ $groupKey ] [ $fieldKey ] [ 'width' ] = substr ( $field [ 'width' ], 0, strlen ( $field [ 'width' ] ) - 1 ) ;
+                        $groups [$groupKey] [$fieldKey] ['width'] = substr($field ['width'], 0, strlen($field ['width']) - 1);
                     }
                 }
             }
         }
 
-        $smarty->assign ( 'groups', $groups ) ;
+        $smarty->assign('groups', $groups);
 
         global $image_path, $mod_strings;
-        $imageSave = SugarThemeRegistry::current()->getImage('studio_save','',null,null,'.gif',$mod_strings['LBL_BTN_SAVE']) ;
+        $imageSave = SugarThemeRegistry::current()->getImage('studio_save', '', null, null, '.gif', $mod_strings['LBL_BTN_SAVE']);
 
 //        $imageHelp = SugarThemeRegistry::current()->getImage('help','',null,null,'.gif',$mod_strings['LBL_SECTION_HELP']) ;
 
 
-        $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
+        $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")";
         if (isset($this->searchlayout))
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")";
 
-        $buttons = array ( ) ;
-        if (! $this->fromModuleBuilder)
+        $buttons = array( );
+        if (!$this->fromModuleBuilder)
         {
-            $buttons [] = array ( 'name' => 'savebtn' , 'image' => $imageSave , 'text' => $GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVEPUBLISH' ] , 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");ModuleBuilder.state.isDirty=false;ModuleBuilder.submitForm(\"edittabs\" )'" ) ;
+            $buttons [] = array('name' => 'savebtn', 'image' => $imageSave, 'text' => $GLOBALS ['mod_strings'] ['LBL_BTN_SAVEPUBLISH'], 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");ModuleBuilder.state.isDirty=false;ModuleBuilder.submitForm(\"edittabs\" )'");
         } else
         {
-            $buttons [] = array ( 'name' => 'mbsavebtn' , 'image' => $imageSave , 'text' => $GLOBALS [ 'mod_strings' ] [ 'LBL_BTN_SAVE' ] , 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");ModuleBuilder.state.isDirty=false;ModuleBuilder.submitForm(\"edittabs\" )'" ) ;
+            $buttons [] = array('name' => 'mbsavebtn', 'image' => $imageSave, 'text' => $GLOBALS ['mod_strings'] ['LBL_BTN_SAVE'], 'actionScript' => "onclick='studiotabs.generateGroupForm(\"edittabs\");ModuleBuilder.state.isDirty=false;ModuleBuilder.submitForm(\"edittabs\" )'");
         }
-        $buttons [] = array ( 'name' => 'historyBtn' , 'text' => translate ( 'LBL_HISTORY' ) , 'actionScript' => "onclick='$histaction'" ) ;
-        $smarty->assign ( 'buttons', $this->_buildImageButtons ( $buttons ) ) ;
-        $editImage = SugarThemeRegistry::current()->getImage('edit_inline','',null,null,'.gif',$mod_strings['LBL_EDIT']) ;
+        $buttons [] = array('name' => 'historyBtn', 'text' => translate('LBL_HISTORY'), 'actionScript' => "onclick='$histaction'");
+        $smarty->assign('buttons', $this->_buildImageButtons($buttons));
+        $editImage = SugarThemeRegistry::current()->getImage('edit_inline', '', null, null, '.gif', $mod_strings['LBL_EDIT']);
 
-        $smarty->assign ( 'editImage', $editImage ) ;
-        $deleteImage = SugarThemeRegistry::current()->getImage('delete_inline','',null,null,'.gif',$mod_strings['LBL_MB_DELETE']) ;
+        $smarty->assign('editImage', $editImage);
+        $deleteImage = SugarThemeRegistry::current()->getImage('delete_inline', '', null, null, '.gif', $mod_strings['LBL_MB_DELETE']);
 
-        $smarty->assign ( 'deleteImage', $deleteImage ) ;
-        $smarty->assign ( 'MOD', $GLOBALS [ 'mod_strings' ] ) ;
+        $smarty->assign('deleteImage', $deleteImage);
+        $smarty->assign('MOD', $GLOBALS ['mod_strings']);
 
         if ($this->fromModuleBuilder)
         {
-            $smarty->assign ( 'MB', true ) ;
-            $smarty->assign ( 'view_package', $this->editPackage ) ;
-            $smarty->assign ( 'description', $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_DESCRIPTION' ] ) ;
+            $smarty->assign('MB', true);
+            $smarty->assign('view_package', $this->editPackage);
+            $smarty->assign('description', $GLOBALS ['mod_strings'] ['LBL_LISTVIEW_DESCRIPTION']);
 
         } else
         {
-            $smarty->assign ( 'description', $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_DESCRIPTION' ] ) ;
+            $smarty->assign('description', $GLOBALS ['mod_strings'] ['LBL_LISTVIEW_DESCRIPTION']);
         }
 
-        return $smarty ;
+        return $smarty;
     }
 
     function _constructTitle()
     {
-        global $app_list_strings ;
+        global $app_list_strings;
 
         if ($this->fromModuleBuilder)
-            $title = $this->editModule ;
+            $title = $this->editModule;
         else
-            $title =  $app_list_strings [ 'moduleList' ] [ $this->editModule ] ;
+            $title = $app_list_strings ['moduleList'] [$this->editModule];
         
-        return $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_EDIT' ] . ':&nbsp;' . $title ;
+        return $GLOBALS ['mod_strings'] ['LBL_LISTVIEW_EDIT'].':&nbsp;'.$title;
     }
 }

Braces +16 added lines, -12 removed lines

@@ -1,6 +1,7 @@ 
 <?php
-if (! defined ( 'sugarEntry' ) || ! sugarEntry)
+if (! defined ( 'sugarEntry' ) || ! sugarEntry) {
     die ( 'Not A Valid Entry Point' ) ;
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -52,10 +53,11 @@ 
     {
         $this->editModule = $_REQUEST [ 'view_module' ] ;
         $this->editLayout = $_REQUEST [ 'view' ] ;
-        if(isset ( $_REQUEST [ 'view_package' ] ) && ! empty ( $_REQUEST [ 'view_package' ] ))
-            $this->editPackage = $_REQUEST [ 'view_package' ];
-        else
-            $this->editPackage = null;
+        if(isset ( $_REQUEST [ 'view_package' ] ) && ! empty ( $_REQUEST [ 'view_package' ] )) {
+                    $this->editPackage = $_REQUEST [ 'view_package' ];
+        } else {
+                    $this->editPackage = null;
+        }
 
         $this->fromModuleBuilder = isset ( $_REQUEST [ 'MB' ] ) || (isset($_REQUEST['view_package']) && $_REQUEST['view_package'] && $_REQUEST['view_package'] != 'studio') ;
 
@@ -121,7 +123,7 @@ 
 
             $ViewLabel = ($this->editLayout == MB_DASHLET) ? 'LBL_DASHLETLISTVIEW' : 'LBL_DASHLETSEARCHVIEW';
             $ajax->addCrumb ( translate ($ViewLabel, 'ModuleBuilder' ), '' ) ;
-        }else{
+        } else{
             $ajax->addCrumb ( translate($this->editModule), 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_module=' . $this->editModule . '")' ) ;
             $ajax->addCrumb ( translate('LBL_LAYOUTS', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&layouts=1&view_module=' . $this->editModule . '")');
             $ajax->addCrumb ( translate('LBL_DASHLET', 'ModuleBuilder'), 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view=dashlet&view_module=' . $this->editModule . '")' );
@@ -182,8 +184,9 @@ 
 
 
         $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\")" ;
-        if (isset($this->searchlayout))
-            $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+        if (isset($this->searchlayout)) {
+                    $histaction = "ModuleBuilder.history.browse(\"{$this->editModule}\", \"{$this->editLayout}\", \"{$this->searchlayout}\")" ;
+        }
 
         $buttons = array ( ) ;
         if (! $this->fromModuleBuilder)
@@ -221,10 +224,11 @@ 
     {
         global $app_list_strings ;
 
-        if ($this->fromModuleBuilder)
-            $title = $this->editModule ;
-        else
-            $title =  $app_list_strings [ 'moduleList' ] [ $this->editModule ] ;
+        if ($this->fromModuleBuilder) {
+                    $title = $this->editModule ;
+        } else {
+                    $title =  $app_list_strings [ 'moduleList' ] [ $this->editModule ] ;
+        }
         
         return $GLOBALS [ 'mod_strings' ] [ 'LBL_LISTVIEW_EDIT' ] . ':&nbsp;' . $title ;
     }

modules/ModuleBuilder/views/view.modulelabels.php

Indentation +44 added lines, -44 removed lines

@@ -48,60 +48,60 @@
 
 class ViewModulelabels extends SugarView
 {
- 	/**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+        /**
+         * @see SugarView::_getModuleTitleParams()
+         */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
-	function display()
-	{
- 		global $mod_strings;
+    function display()
+    {
+            global $mod_strings;
         $bak_mod_strings=$mod_strings;
- 		$smarty = new Sugar_Smarty();
+            $smarty = new Sugar_Smarty();
         $smarty->assign('mod_strings', $mod_strings);
- 		$package_name = $_REQUEST['view_package'];
- 		$module_name = $_REQUEST['view_module'];
+            $package_name = $_REQUEST['view_package'];
+            $module_name = $_REQUEST['view_module'];
 
-		require_once('modules/ModuleBuilder/MB/ModuleBuilder.php');
-		$mb = new ModuleBuilder();
-		$mb->getPackage($_REQUEST['view_package']);
-		$package = $mb->packages[$_REQUEST['view_package']];
-		$package->getModule($module_name);
-		$mbModule = $package->modules[$module_name];
-		$selected_lang = (!empty($_REQUEST['selected_lang'])?$_REQUEST['selected_lang']:$_SESSION['authenticated_user_language']);
-		if(empty($selected_lang)){
-	    	$selected_lang = $GLOBALS['sugar_config']['default_language'];
-		}
-	        //need to change the following to interface with MBlanguage.
+        require_once('modules/ModuleBuilder/MB/ModuleBuilder.php');
+        $mb = new ModuleBuilder();
+        $mb->getPackage($_REQUEST['view_package']);
+        $package = $mb->packages[$_REQUEST['view_package']];
+        $package->getModule($module_name);
+        $mbModule = $package->modules[$module_name];
+        $selected_lang = (!empty($_REQUEST['selected_lang'])?$_REQUEST['selected_lang']:$_SESSION['authenticated_user_language']);
+        if(empty($selected_lang)){
+            $selected_lang = $GLOBALS['sugar_config']['default_language'];
+        }
+            //need to change the following to interface with MBlanguage.
 
         $smarty->assign('MOD', $mbModule->getModStrings($selected_lang));
-		$smarty->assign('APP', $GLOBALS['app_strings']);
-		$smarty->assign('selected_lang', $selected_lang);
-		$smarty->assign('view_package', $package_name);
-		$smarty->assign('view_module', $module_name);
-		$smarty->assign('mb','1');
-		$smarty->assign('available_languages', get_languages());
-		///////////////////////////////////////////////////////////////////
- 		////ASSISTANT
- 		$smarty->assign('assistant',array('group'=>'module', 'key'=>'labels'));
-		/////////////////////////////////////////////////////////////////
-	 	////ASSISTANT
+        $smarty->assign('APP', $GLOBALS['app_strings']);
+        $smarty->assign('selected_lang', $selected_lang);
+        $smarty->assign('view_package', $package_name);
+        $smarty->assign('view_module', $module_name);
+        $smarty->assign('mb','1');
+        $smarty->assign('available_languages', get_languages());
+        ///////////////////////////////////////////////////////////////////
+            ////ASSISTANT
+            $smarty->assign('assistant',array('group'=>'module', 'key'=>'labels'));
+        /////////////////////////////////////////////////////////////////
+            ////ASSISTANT
 
-		$ajax = new AjaxCompose();
-		$ajax->addCrumb($bak_mod_strings['LBL_MODULEBUILDER'], 'ModuleBuilder.main("mb")');
-		$ajax->addCrumb($package_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$package->name. '")');
+        $ajax = new AjaxCompose();
+        $ajax->addCrumb($bak_mod_strings['LBL_MODULEBUILDER'], 'ModuleBuilder.main("mb")');
+        $ajax->addCrumb($package_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$package->name. '")');
         $ajax->addCrumb($module_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package='.$package->name.'&view_module='. $module_name . '")');
         $ajax->addCrumb($bak_mod_strings['LBL_LABELS'], '');
-		$ajax->addSection('center', $bak_mod_strings['LBL_LABELS'],$smarty->fetch('modules/ModuleBuilder/tpls/labels.tpl'));
-		echo $ajax->getJavascript();
-	}
+        $ajax->addSection('center', $bak_mod_strings['LBL_LABELS'],$smarty->fetch('modules/ModuleBuilder/tpls/labels.tpl'));
+        echo $ajax->getJavascript();
+    }
 }
 

Spacing +9 added lines, -9 removed lines

@@ -56,7 +56,7 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
@@ -64,7 +64,7 @@ 
 	function display()
 	{
  		global $mod_strings;
-        $bak_mod_strings=$mod_strings;
+        $bak_mod_strings = $mod_strings;
  		$smarty = new Sugar_Smarty();
         $smarty->assign('mod_strings', $mod_strings);
  		$package_name = $_REQUEST['view_package'];
@@ -76,8 +76,8 @@ 
 		$package = $mb->packages[$_REQUEST['view_package']];
 		$package->getModule($module_name);
 		$mbModule = $package->modules[$module_name];
-		$selected_lang = (!empty($_REQUEST['selected_lang'])?$_REQUEST['selected_lang']:$_SESSION['authenticated_user_language']);
-		if(empty($selected_lang)){
+		$selected_lang = (!empty($_REQUEST['selected_lang']) ? $_REQUEST['selected_lang'] : $_SESSION['authenticated_user_language']);
+		if (empty($selected_lang)) {
 	    	$selected_lang = $GLOBALS['sugar_config']['default_language'];
 		}
 	        //need to change the following to interface with MBlanguage.
@@ -87,20 +87,20 @@ 
 		$smarty->assign('selected_lang', $selected_lang);
 		$smarty->assign('view_package', $package_name);
 		$smarty->assign('view_module', $module_name);
-		$smarty->assign('mb','1');
+		$smarty->assign('mb', '1');
 		$smarty->assign('available_languages', get_languages());
 		///////////////////////////////////////////////////////////////////
  		////ASSISTANT
- 		$smarty->assign('assistant',array('group'=>'module', 'key'=>'labels'));
+ 		$smarty->assign('assistant', array('group'=>'module', 'key'=>'labels'));
 		/////////////////////////////////////////////////////////////////
 	 	////ASSISTANT
 
 		$ajax = new AjaxCompose();
 		$ajax->addCrumb($bak_mod_strings['LBL_MODULEBUILDER'], 'ModuleBuilder.main("mb")');
-		$ajax->addCrumb($package_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$package->name. '")');
-        $ajax->addCrumb($module_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package='.$package->name.'&view_module='. $module_name . '")');
+		$ajax->addCrumb($package_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=package&package='.$package->name.'")');
+        $ajax->addCrumb($module_name, 'ModuleBuilder.getContent("module=ModuleBuilder&action=module&view_package='.$package->name.'&view_module='.$module_name.'")');
         $ajax->addCrumb($bak_mod_strings['LBL_LABELS'], '');
-		$ajax->addSection('center', $bak_mod_strings['LBL_LABELS'],$smarty->fetch('modules/ModuleBuilder/tpls/labels.tpl'));
+		$ajax->addSection('center', $bak_mod_strings['LBL_LABELS'], $smarty->fetch('modules/ModuleBuilder/tpls/labels.tpl'));
 		echo $ajax->getJavascript();
 	}
 }

modules/ModuleBuilder/views/view.history.php

Indentation +20 added lines, -20 removed lines

@@ -47,19 +47,19 @@ 
     var $pageSize = 10 ;
 
     /**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+     * @see SugarView::_getModuleTitleParams()
+     */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 	    
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
-	function display ()
+    function display ()
     {
         $this->layout = strtolower ( $_REQUEST [ 'view' ] ) ;
         
@@ -135,7 +135,7 @@ 
         }
         echo "<input type='button' name='close$sid' value='". translate ( 'LBL_BTN_CLOSE' )."' " . 
                 "class='button' onclick='ModuleBuilder.tabPanel.removeTab(ModuleBuilder.tabPanel.get(\"activeTab\"));' style='margin:5px;'>" . 
-             "<input type='button' name='restore$sid' value='" . translate ( 'LBL_MB_RESTORE' ) . "' " .  
+                "<input type='button' name='restore$sid' value='" . translate ( 'LBL_MB_RESTORE' ) . "' " .  
                 "class='button' onclick='ModuleBuilder.history.revert(\"$this->module\",\"{$this->layout}\",\"$sid\"$subpanel);' style='margin:5px;'>" ;
         $this->history->restoreByTimestamp ( $sid ) ;
         $view ;
@@ -149,12 +149,12 @@ 
             $view = new ViewSearchView ( ) ;
         } else if ($this->layout == 'dashlet' || $this->layout == 'dashletsearch')
         {
-        	require_once ("modules/ModuleBuilder/views/view.dashlet.php") ;
-        	$view = new ViewDashlet ( ) ;
+            require_once ("modules/ModuleBuilder/views/view.dashlet.php") ;
+            $view = new ViewDashlet ( ) ;
         }  else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
         {
-        	require_once ("modules/ModuleBuilder/views/view.popupview.php") ;
-        	$view = new ViewPopupview ( ) ;
+            require_once ("modules/ModuleBuilder/views/view.popupview.php") ;
+            $view = new ViewPopupview ( ) ;
         } else
         {
             require_once ("modules/ModuleBuilder/views/view.layoutview.php") ;
@@ -175,12 +175,12 @@ 
         $this->history->restoreByTimestamp ( $sid ) ;
     }
 
-	/**
- 	 * Restores a layout to its current customized state. 
- 	 * Called when leaving a restored layout without saving.
- 	 */
+    /**
+     * Restores a layout to its current customized state. 
+     * Called when leaving a restored layout without saving.
+     */
     function unrestore() 
     {
-    	$this->history->undoRestore () ;
+        $this->history->undoRestore () ;
     }
 }

Spacing +74 added lines, -74 removed lines

@@ -38,13 +38,13 @@ 
  ********************************************************************************/
 
 
-require_once ('modules/ModuleBuilder/MB/AjaxCompose.php') ;
-require_once ('modules/ModuleBuilder/parsers/views/History.php') ;
-require_once ('modules/ModuleBuilder/parsers/ParserFactory.php') ;
+require_once ('modules/ModuleBuilder/MB/AjaxCompose.php');
+require_once ('modules/ModuleBuilder/parsers/views/History.php');
+require_once ('modules/ModuleBuilder/parsers/ParserFactory.php');
 
 class ViewHistory extends SugarView
 {
-    var $pageSize = 10 ;
+    var $pageSize = 10;
 
     /**
 	 * @see SugarView::_getModuleTitleParams()
@@ -54,125 +54,125 @@ 
 	    global $mod_strings;
 	    
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
 
-	function display ()
+	function display()
     {
-        $this->layout = strtolower ( $_REQUEST [ 'view' ] ) ;
+        $this->layout = strtolower($_REQUEST ['view']);
         
-        $subpanelName = null ;
-        if ((strtolower ( $this->layout ) == 'listview') && (!empty ( $_REQUEST [ 'subpanel' ] )))
+        $subpanelName = null;
+        if ((strtolower($this->layout) == 'listview') && (!empty ($_REQUEST ['subpanel'])))
         {
-            $subpanelName = $_REQUEST [ 'subpanel' ] ;
+            $subpanelName = $_REQUEST ['subpanel'];
             
         }
         
-        $packageName = (isset ( $_REQUEST [ 'view_package' ] ) && (strtolower ( $_REQUEST [ 'view_package' ] ) != 'studio')) ? $_REQUEST [ 'view_package' ] : null ;
-        $this->module = $_REQUEST [ 'view_module' ] ;
+        $packageName = (isset ($_REQUEST ['view_package']) && (strtolower($_REQUEST ['view_package']) != 'studio')) ? $_REQUEST ['view_package'] : null;
+        $this->module = $_REQUEST ['view_module'];
         
-        $this->parser = ParserFactory::getParser ( $this->layout, $this->module, $packageName, $subpanelName ) ;
-        $this->history = $this->parser->getHistory () ;
-        $action = ! empty ( $_REQUEST [ 'histAction' ] ) ? $_REQUEST [ 'histAction' ] : 'browse' ;
-        $GLOBALS['log']->debug( get_class($this)."->display(): performing History action {$action}" ) ;
-        $this->$action () ;
+        $this->parser = ParserFactory::getParser($this->layout, $this->module, $packageName, $subpanelName);
+        $this->history = $this->parser->getHistory();
+        $action = !empty ($_REQUEST ['histAction']) ? $_REQUEST ['histAction'] : 'browse';
+        $GLOBALS['log']->debug(get_class($this)."->display(): performing History action {$action}");
+        $this->$action();
     }
 
-    function browse ()
+    function browse()
     {
-        $smarty = new Sugar_Smarty ( ) ;
-        global $mod_strings ;
-        $smarty->assign ( 'mod_strings', $mod_strings ) ;
-        $smarty->assign ( 'view_module', $this->module ) ;
-        $smarty->assign ( 'view', $this->layout ) ;
+        $smarty = new Sugar_Smarty( );
+        global $mod_strings;
+        $smarty->assign('mod_strings', $mod_strings);
+        $smarty->assign('view_module', $this->module);
+        $smarty->assign('view', $this->layout);
         
-        if (! empty ( $_REQUEST [ 'subpanel' ] ))
+        if (!empty ($_REQUEST ['subpanel']))
         {
-            $smarty->assign ( 'subpanel', $_REQUEST [ 'subpanel' ] ) ;
+            $smarty->assign('subpanel', $_REQUEST ['subpanel']);
         }
-        $stamps = array ( ) ;
-        global $timedate ;
-        $userFormat = $timedate->get_date_time_format () ;
-        $page = ! empty ( $_REQUEST [ 'page' ] ) ? $_REQUEST [ 'page' ] : 0 ;
+        $stamps = array( );
+        global $timedate;
+        $userFormat = $timedate->get_date_time_format();
+        $page = !empty ($_REQUEST ['page']) ? $_REQUEST ['page'] : 0;
         $count = $this->history->getCount();
-        $ts = $this->history->getNth ( $page * $this->pageSize ) ;
-        $snapshots = array ( ) ;
-        for ( $i = 0 ; $i <= $this->pageSize && $ts > 0 ; $i ++ )
+        $ts = $this->history->getNth($page * $this->pageSize);
+        $snapshots = array( );
+        for ($i = 0; $i <= $this->pageSize && $ts > 0; $i++)
         {
             $dbDate = $timedate->fromTimestamp($ts)->asDb();
-            $displayTS = $timedate->to_display_date_time ( $dbDate ) ;
+            $displayTS = $timedate->to_display_date_time($dbDate);
             if ($page * $this->pageSize + $i + 1 == $count)
                 $displayTS = translate("LBL_MB_DEFAULT_LAYOUT");
-            $snapshots [ $ts ] = $displayTS ;
-            $ts = $this->history->getNext () ;
+            $snapshots [$ts] = $displayTS;
+            $ts = $this->history->getNext();
         }
-        if (count ( $snapshots ) > $this->pageSize)
+        if (count($snapshots) > $this->pageSize)
         {
-            $smarty->assign ( 'nextPage', true ) ;
+            $smarty->assign('nextPage', true);
         }
-        $snapshots = array_slice ( $snapshots, 0, $this->pageSize, true ) ;
-        $smarty->assign ( 'currentPage', $page ) ;
-        $smarty->assign ( 'snapshots', $snapshots ) ;
+        $snapshots = array_slice($snapshots, 0, $this->pageSize, true);
+        $smarty->assign('currentPage', $page);
+        $smarty->assign('snapshots', $snapshots);
         
-        $html = $smarty->fetch ( 'modules/ModuleBuilder/tpls/history.tpl' ) ;
-        echo $html ;
+        $html = $smarty->fetch('modules/ModuleBuilder/tpls/history.tpl');
+        echo $html;
     }
 
-    function preview ()
+    function preview()
     {
-        global $mod_strings ;
-        if (! isset ( $_REQUEST [ 'sid' ] ))
+        global $mod_strings;
+        if (!isset ($_REQUEST ['sid']))
         {
-            die ( 'SID Required' ) ;
+            die ('SID Required');
         }
-        $sid = $_REQUEST [ 'sid' ] ;
+        $sid = $_REQUEST ['sid'];
         $subpanel = '';
-        if (! empty ( $_REQUEST [ 'subpanel' ] ))
+        if (!empty ($_REQUEST ['subpanel']))
         {
-            $subpanel = ',"' . $_REQUEST [ 'subpanel' ] . '"' ;
+            $subpanel = ',"'.$_REQUEST ['subpanel'].'"';
         }
-        echo "<input type='button' name='close$sid' value='". translate ( 'LBL_BTN_CLOSE' )."' " . 
-                "class='button' onclick='ModuleBuilder.tabPanel.removeTab(ModuleBuilder.tabPanel.get(\"activeTab\"));' style='margin:5px;'>" . 
-             "<input type='button' name='restore$sid' value='" . translate ( 'LBL_MB_RESTORE' ) . "' " .  
-                "class='button' onclick='ModuleBuilder.history.revert(\"$this->module\",\"{$this->layout}\",\"$sid\"$subpanel);' style='margin:5px;'>" ;
-        $this->history->restoreByTimestamp ( $sid ) ;
-        $view ;
+        echo "<input type='button' name='close$sid' value='".translate('LBL_BTN_CLOSE')."' ". 
+                "class='button' onclick='ModuleBuilder.tabPanel.removeTab(ModuleBuilder.tabPanel.get(\"activeTab\"));' style='margin:5px;'>". 
+             "<input type='button' name='restore$sid' value='".translate('LBL_MB_RESTORE')."' ".  
+                "class='button' onclick='ModuleBuilder.history.revert(\"$this->module\",\"{$this->layout}\",\"$sid\"$subpanel);' style='margin:5px;'>";
+        $this->history->restoreByTimestamp($sid);
+        $view;
         if ($this->layout == 'listview')
         {
-            require_once ("modules/ModuleBuilder/views/view.listview.php") ;
-            $view = new ViewListView ( ) ;
+            require_once ("modules/ModuleBuilder/views/view.listview.php");
+            $view = new ViewListView( );
         } else if ($this->layout == 'basic_search' || $this->layout == 'advanced_search')
         {
-            require_once ("modules/ModuleBuilder/views/view.searchview.php") ;
-            $view = new ViewSearchView ( ) ;
+            require_once ("modules/ModuleBuilder/views/view.searchview.php");
+            $view = new ViewSearchView( );
         } else if ($this->layout == 'dashlet' || $this->layout == 'dashletsearch')
         {
-        	require_once ("modules/ModuleBuilder/views/view.dashlet.php") ;
-        	$view = new ViewDashlet ( ) ;
-        }  else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
+        	require_once ("modules/ModuleBuilder/views/view.dashlet.php");
+        	$view = new ViewDashlet( );
+        } else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
         {
-        	require_once ("modules/ModuleBuilder/views/view.popupview.php") ;
-        	$view = new ViewPopupview ( ) ;
+        	require_once ("modules/ModuleBuilder/views/view.popupview.php");
+        	$view = new ViewPopupview( );
         } else
         {
-            require_once ("modules/ModuleBuilder/views/view.layoutview.php") ;
-            $view = new ViewLayoutView ( ) ;
+            require_once ("modules/ModuleBuilder/views/view.layoutview.php");
+            $view = new ViewLayoutView( );
         }
         
-        $view->display ( true ) ;
-        $this->history->undoRestore () ;
+        $view->display(true);
+        $this->history->undoRestore();
     }
 
-    function restore ()
+    function restore()
     {
-        if (! isset ( $_REQUEST [ 'sid' ] ))
+        if (!isset ($_REQUEST ['sid']))
         {
-            die ( 'SID Required' ) ;
+            die ('SID Required');
         }
-        $sid = $_REQUEST [ 'sid' ] ;
-        $this->history->restoreByTimestamp ( $sid ) ;
+        $sid = $_REQUEST ['sid'];
+        $this->history->restoreByTimestamp($sid);
     }
 
 	/**
@@ -181,6 +181,6 @@ 
  	 */
     function unrestore() 
     {
-    	$this->history->undoRestore () ;
+    	$this->history->undoRestore();
     }
 }

Braces +4 added lines, -3 removed lines

@@ -103,8 +103,9 @@ 
         {
             $dbDate = $timedate->fromTimestamp($ts)->asDb();
             $displayTS = $timedate->to_display_date_time ( $dbDate ) ;
-            if ($page * $this->pageSize + $i + 1 == $count)
-                $displayTS = translate("LBL_MB_DEFAULT_LAYOUT");
+            if ($page * $this->pageSize + $i + 1 == $count) {
+                            $displayTS = translate("LBL_MB_DEFAULT_LAYOUT");
+            }
             $snapshots [ $ts ] = $displayTS ;
             $ts = $this->history->getNext () ;
         }
@@ -151,7 +152,7 @@ 
         {
         	require_once ("modules/ModuleBuilder/views/view.dashlet.php") ;
         	$view = new ViewDashlet ( ) ;
-        }  else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
+        } else if ($this->layout == 'popuplist' || $this->layout == 'popupsearch')
         {
         	require_once ("modules/ModuleBuilder/views/view.popupview.php") ;
         	$view = new ViewPopupview ( ) ;

modules/ModuleBuilder/views/view.labels.php

Indentation +89 added lines, -89 removed lines

@@ -48,73 +48,73 @@ 
 class ViewLabels extends ViewModulefields
 {
     /**
-	 * @see SugarView::_getModuleTitleParams()
-	 */
-	protected function _getModuleTitleParams($browserTitle = false)
-	{
-	    global $mod_strings;
+     * @see SugarView::_getModuleTitleParams()
+     */
+    protected function _getModuleTitleParams($browserTitle = false)
+    {
+        global $mod_strings;
 
-    	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
-    	   ModuleBuilderController::getModuleTitle(),
-    	   );
+        return array(
+            translate('LBL_MODULE_NAME','Administration'),
+            ModuleBuilderController::getModuleTitle(),
+            );
     }
 
- 	//STUDIO LABELS ONLY//
- 	//TODO Bundle Studio and ModuleBuilder label handling to increase maintainability.
- 	function display()
- 	{
-		$editModule = $_REQUEST['view_module'];
-		$allLabels = (!empty($_REQUEST['labels']) && $_REQUEST['labels']== 'all');
+        //STUDIO LABELS ONLY//
+        //TODO Bundle Studio and ModuleBuilder label handling to increase maintainability.
+        function display()
+        {
+        $editModule = $_REQUEST['view_module'];
+        $allLabels = (!empty($_REQUEST['labels']) && $_REQUEST['labels']== 'all');
 
- 		if (!isset($_REQUEST['MB']))
-		{
-		    global $app_list_strings;
-		    $moduleNames = array_change_key_case($app_list_strings['moduleList']);
-		    $translatedEditModule = $moduleNames[strtolower($editModule)];
-		}
-		$selected_lang = (!empty($_REQUEST['selected_lang'])? $_REQUEST['selected_lang']:$_SESSION['authenticated_user_language']);
-		if(empty($selected_lang)){
-		    $selected_lang = $GLOBALS['sugar_config']['default_language'];
-		}
+            if (!isset($_REQUEST['MB']))
+        {
+            global $app_list_strings;
+            $moduleNames = array_change_key_case($app_list_strings['moduleList']);
+            $translatedEditModule = $moduleNames[strtolower($editModule)];
+        }
+        $selected_lang = (!empty($_REQUEST['selected_lang'])? $_REQUEST['selected_lang']:$_SESSION['authenticated_user_language']);
+        if(empty($selected_lang)){
+            $selected_lang = $GLOBALS['sugar_config']['default_language'];
+        }
 
-		$smarty = new Sugar_Smarty();
-		global $mod_strings;
+        $smarty = new Sugar_Smarty();
+        global $mod_strings;
         $smarty->assign('mod_strings', $mod_strings);
-		$smarty->assign('available_languages',get_languages());
+        $smarty->assign('available_languages',get_languages());
 
 
         $objectName = BeanFactory::getObjectName($editModule);
         VardefManager::loadVardef($editModule, $objectName);
         global $dictionary;
         $vnames = array();
-		//jchi 24557 . We should list all the lables in viewdefs(list,detail,edit,quickcreate) that the user can edit them.
-		require_once 'modules/ModuleBuilder/parsers/views/ListLayoutMetaDataParser.php' ;
+        //jchi 24557 . We should list all the lables in viewdefs(list,detail,edit,quickcreate) that the user can edit them.
+        require_once 'modules/ModuleBuilder/parsers/views/ListLayoutMetaDataParser.php' ;
         $parser = new ListLayoutMetaDataParser ( MB_LISTVIEW, $editModule ) ;
         foreach ( $parser->getLayout() as $key => $def )
         {
-        	if(isset($def['label']) ) {
-               $vnames[$def['label']] = $def['label'];
-        	}
+            if(isset($def['label']) ) {
+                $vnames[$def['label']] = $def['label'];
+            }
         }
 
-       require_once 'modules/ModuleBuilder/parsers/views/GridLayoutMetaDataParser.php' ;
+        require_once 'modules/ModuleBuilder/parsers/views/GridLayoutMetaDataParser.php' ;
         $variableMap = $this->getVariableMap($editModule);
         foreach($variableMap as $key => $value){
-        	$gridLayoutMetaDataParserTemp = new GridLayoutMetaDataParser ( $value, $editModule) ;
-        	foreach ( $gridLayoutMetaDataParserTemp->getLayout() as $panel)
-	        {
-	                foreach ( $panel as $row )
-	                {
-	                    foreach ( $row as $fieldArray )
-	                    { // fieldArray is an array('name'=>name,'label'=>label)
-	                        if (isset ( $fieldArray [ 'label' ] ))
-	                        {
-	                            $vnames[$fieldArray [ 'label' ] ] = $fieldArray [ 'label' ] ;
-	                        }
-	                    }
-	                }
-	        }
+            $gridLayoutMetaDataParserTemp = new GridLayoutMetaDataParser ( $value, $editModule) ;
+            foreach ( $gridLayoutMetaDataParserTemp->getLayout() as $panel)
+            {
+                    foreach ( $panel as $row )
+                    {
+                        foreach ( $row as $fieldArray )
+                        { // fieldArray is an array('name'=>name,'label'=>label)
+                            if (isset ( $fieldArray [ 'label' ] ))
+                            {
+                                $vnames[$fieldArray [ 'label' ] ] = $fieldArray [ 'label' ] ;
+                            }
+                        }
+                    }
+            }
         }
         //end
 
@@ -122,23 +122,23 @@ 
         require_once ('include/SubPanel/SubPanel.php') ;
         $subList =  SubPanel::getModuleSubpanels ( $editModule );
         foreach($subList as $subpanel => $titleLabel) {
-        	$vnames[$titleLabel] = $titleLabel;
+            $vnames[$titleLabel] = $titleLabel;
         }
 
         foreach($dictionary[$objectName]['fields'] as $name=>$def) {
-        	if(isset($def['vname'])) {
-               $vnames[$def['vname']] = $def['vname'];
-        	}
-		}
- 	    $formatted_mod_strings = array();
+            if(isset($def['vname'])) {
+                $vnames[$def['vname']] = $def['vname'];
+            }
+        }
+            $formatted_mod_strings = array();
 
- 	    //we shouldn't set the $refresh=true here, or will lost template language mod_strings.
- 	    //return_module_language($selected_lang, $editModule,false) : the mod_strings will be included from cache files here.
+            //we shouldn't set the $refresh=true here, or will lost template language mod_strings.
+            //return_module_language($selected_lang, $editModule,false) : the mod_strings will be included from cache files here.
         foreach(return_module_language($selected_lang, $editModule,false) as $name=>$label) {
-        		//#25294
-        	 	if($allLabels || isset($vnames[$name]) || preg_match( '/lbl_city|lbl_country|lbl_billing_address|lbl_alt_address|lbl_shipping_address|lbl_postal_code|lbl_state$/si' , $name)) {
+                //#25294
+                    if($allLabels || isset($vnames[$name]) || preg_match( '/lbl_city|lbl_country|lbl_billing_address|lbl_alt_address|lbl_shipping_address|lbl_postal_code|lbl_state$/si' , $name)) {
                     $formatted_mod_strings[$name] = htmlentities($label, ENT_QUOTES, 'UTF-8');
-        	 	}
+                    }
         }
         //Grab everything from the custom files
         $mod_bak = $mod_strings;
@@ -147,49 +147,49 @@ 
             "custom/modules/$editModule/Ext/Language/$selected_lang.lang.ext.php"
         );
         foreach($files as $langfile){
-        	$mod_strings = array();
-        	if (is_file($langfile))
-        	{
-        	   include($langfile);
-        	   foreach($mod_strings as $key => $label)
-        	   {
+            $mod_strings = array();
+            if (is_file($langfile))
+            {
+                include($langfile);
+                foreach($mod_strings as $key => $label)
+                {
                     $formatted_mod_strings[$key] = htmlentities($label, ENT_QUOTES, 'UTF-8');
-        	   }
-        	}
+                }
+            }
         }
         $mod_strings = $mod_bak;
         ksort($formatted_mod_strings);
-		$smarty->assign('MOD', $formatted_mod_strings);
-		$smarty->assign('view_module', $editModule);
-		$smarty->assign('APP', $GLOBALS['app_strings']);
-		$smarty->assign('selected_lang', $selected_lang);
-		$smarty->assign('defaultHelp', 'labelsBtn');
-		$smarty->assign('assistant', array('key'=>'labels', 'group'=>'module'));
-		$smarty->assign('labels_choice', $mod_strings['labelTypes']);
-		$smarty->assign('labels_current', $allLabels?"all":"");
+        $smarty->assign('MOD', $formatted_mod_strings);
+        $smarty->assign('view_module', $editModule);
+        $smarty->assign('APP', $GLOBALS['app_strings']);
+        $smarty->assign('selected_lang', $selected_lang);
+        $smarty->assign('defaultHelp', 'labelsBtn');
+        $smarty->assign('assistant', array('key'=>'labels', 'group'=>'module'));
+        $smarty->assign('labels_choice', $mod_strings['labelTypes']);
+        $smarty->assign('labels_current', $allLabels?"all":"");
 
-		$ajax = new AjaxCompose();
-		$ajax->addCrumb($mod_strings['LBL_STUDIO'], 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard")');
-		$ajax->addCrumb($translatedEditModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module='.$editModule.'")');
-		$ajax->addCrumb($mod_strings['LBL_LABELS'], '');
+        $ajax = new AjaxCompose();
+        $ajax->addCrumb($mod_strings['LBL_STUDIO'], 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard")');
+        $ajax->addCrumb($translatedEditModule, 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard&view_module='.$editModule.'")');
+        $ajax->addCrumb($mod_strings['LBL_LABELS'], '');
 
- 		$html = $smarty->fetch('modules/ModuleBuilder/tpls/labels.tpl');
- 		$ajax->addSection('center', $GLOBALS['mod_strings']['LBL_SECTION_EDLABELS'], $html);
- 		echo $ajax->getJavascript();
- 	}
+            $html = $smarty->fetch('modules/ModuleBuilder/tpls/labels.tpl');
+            $ajax->addSection('center', $GLOBALS['mod_strings']['LBL_SECTION_EDLABELS'], $html);
+            echo $ajax->getJavascript();
+        }
     
     // fixing bug #39749: Quick Create in Studio
     function getVariableMap($module)
     {
         $variableMap = array(MB_EDITVIEW => 'EditView', 
-                             MB_DETAILVIEW => 'DetailView', 
-                             MB_QUICKCREATE => 'QuickCreate');
+                                MB_DETAILVIEW => 'DetailView', 
+                                MB_QUICKCREATE => 'QuickCreate');
         
         $hideQuickCreateForModules = array('KBDocuments',
-                                           'ProjectTask',
-                                           'Campaigns',
-                                           'Quotes',
-                                           'ProductTemplates');
+                                            'ProjectTask',
+                                            'Campaigns',
+                                            'Quotes',
+                                            'ProductTemplates');
         
         if(in_array($module, $hideQuickCreateForModules))
         {

Spacing +31 added lines, -31 removed lines

@@ -55,7 +55,7 @@ 
 	    global $mod_strings;
 
     	return array(
-    	   translate('LBL_MODULE_NAME','Administration'),
+    	   translate('LBL_MODULE_NAME', 'Administration'),
     	   ModuleBuilderController::getModuleTitle(),
     	   );
     }
@@ -65,7 +65,7 @@ 
  	function display()
  	{
 		$editModule = $_REQUEST['view_module'];
-		$allLabels = (!empty($_REQUEST['labels']) && $_REQUEST['labels']== 'all');
+		$allLabels = (!empty($_REQUEST['labels']) && $_REQUEST['labels'] == 'all');
 
  		if (!isset($_REQUEST['MB']))
 		{
@@ -73,15 +73,15 @@ 
 		    $moduleNames = array_change_key_case($app_list_strings['moduleList']);
 		    $translatedEditModule = $moduleNames[strtolower($editModule)];
 		}
-		$selected_lang = (!empty($_REQUEST['selected_lang'])? $_REQUEST['selected_lang']:$_SESSION['authenticated_user_language']);
-		if(empty($selected_lang)){
+		$selected_lang = (!empty($_REQUEST['selected_lang']) ? $_REQUEST['selected_lang'] : $_SESSION['authenticated_user_language']);
+		if (empty($selected_lang)) {
 		    $selected_lang = $GLOBALS['sugar_config']['default_language'];
 		}
 
 		$smarty = new Sugar_Smarty();
 		global $mod_strings;
         $smarty->assign('mod_strings', $mod_strings);
-		$smarty->assign('available_languages',get_languages());
+		$smarty->assign('available_languages', get_languages());
 
 
         $objectName = BeanFactory::getObjectName($editModule);
@@ -89,28 +89,28 @@ 
         global $dictionary;
         $vnames = array();
 		//jchi 24557 . We should list all the lables in viewdefs(list,detail,edit,quickcreate) that the user can edit them.
-		require_once 'modules/ModuleBuilder/parsers/views/ListLayoutMetaDataParser.php' ;
-        $parser = new ListLayoutMetaDataParser ( MB_LISTVIEW, $editModule ) ;
-        foreach ( $parser->getLayout() as $key => $def )
+		require_once 'modules/ModuleBuilder/parsers/views/ListLayoutMetaDataParser.php';
+        $parser = new ListLayoutMetaDataParser(MB_LISTVIEW, $editModule);
+        foreach ($parser->getLayout() as $key => $def)
         {
-        	if(isset($def['label']) ) {
+        	if (isset($def['label'])) {
                $vnames[$def['label']] = $def['label'];
         	}
         }
 
-       require_once 'modules/ModuleBuilder/parsers/views/GridLayoutMetaDataParser.php' ;
+       require_once 'modules/ModuleBuilder/parsers/views/GridLayoutMetaDataParser.php';
         $variableMap = $this->getVariableMap($editModule);
-        foreach($variableMap as $key => $value){
-        	$gridLayoutMetaDataParserTemp = new GridLayoutMetaDataParser ( $value, $editModule) ;
-        	foreach ( $gridLayoutMetaDataParserTemp->getLayout() as $panel)
+        foreach ($variableMap as $key => $value) {
+        	$gridLayoutMetaDataParserTemp = new GridLayoutMetaDataParser($value, $editModule);
+        	foreach ($gridLayoutMetaDataParserTemp->getLayout() as $panel)
 	        {
-	                foreach ( $panel as $row )
+	                foreach ($panel as $row)
 	                {
-	                    foreach ( $row as $fieldArray )
+	                    foreach ($row as $fieldArray)
 	                    { // fieldArray is an array('name'=>name,'label'=>label)
-	                        if (isset ( $fieldArray [ 'label' ] ))
+	                        if (isset ($fieldArray ['label']))
 	                        {
-	                            $vnames[$fieldArray [ 'label' ] ] = $fieldArray [ 'label' ] ;
+	                            $vnames[$fieldArray ['label']] = $fieldArray ['label'];
 	                        }
 	                    }
 	                }
@@ -119,14 +119,14 @@ 
         //end
 
         //Get Subpanel Labels:
-        require_once ('include/SubPanel/SubPanel.php') ;
-        $subList =  SubPanel::getModuleSubpanels ( $editModule );
-        foreach($subList as $subpanel => $titleLabel) {
+        require_once ('include/SubPanel/SubPanel.php');
+        $subList = SubPanel::getModuleSubpanels($editModule);
+        foreach ($subList as $subpanel => $titleLabel) {
         	$vnames[$titleLabel] = $titleLabel;
         }
 
-        foreach($dictionary[$objectName]['fields'] as $name=>$def) {
-        	if(isset($def['vname'])) {
+        foreach ($dictionary[$objectName]['fields'] as $name=>$def) {
+        	if (isset($def['vname'])) {
                $vnames[$def['vname']] = $def['vname'];
         	}
 		}
@@ -134,9 +134,9 @@ 
 
  	    //we shouldn't set the $refresh=true here, or will lost template language mod_strings.
  	    //return_module_language($selected_lang, $editModule,false) : the mod_strings will be included from cache files here.
-        foreach(return_module_language($selected_lang, $editModule,false) as $name=>$label) {
+        foreach (return_module_language($selected_lang, $editModule, false) as $name=>$label) {
         		//#25294
-        	 	if($allLabels || isset($vnames[$name]) || preg_match( '/lbl_city|lbl_country|lbl_billing_address|lbl_alt_address|lbl_shipping_address|lbl_postal_code|lbl_state$/si' , $name)) {
+        	 	if ($allLabels || isset($vnames[$name]) || preg_match('/lbl_city|lbl_country|lbl_billing_address|lbl_alt_address|lbl_shipping_address|lbl_postal_code|lbl_state$/si', $name)) {
                     $formatted_mod_strings[$name] = htmlentities($label, ENT_QUOTES, 'UTF-8');
         	 	}
         }
@@ -146,12 +146,12 @@ 
             "custom/modules/$editModule/language/$selected_lang.lang.php",
             "custom/modules/$editModule/Ext/Language/$selected_lang.lang.ext.php"
         );
-        foreach($files as $langfile){
+        foreach ($files as $langfile) {
         	$mod_strings = array();
         	if (is_file($langfile))
         	{
         	   include($langfile);
-        	   foreach($mod_strings as $key => $label)
+        	   foreach ($mod_strings as $key => $label)
         	   {
                     $formatted_mod_strings[$key] = htmlentities($label, ENT_QUOTES, 'UTF-8');
         	   }
@@ -166,7 +166,7 @@ 
 		$smarty->assign('defaultHelp', 'labelsBtn');
 		$smarty->assign('assistant', array('key'=>'labels', 'group'=>'module'));
 		$smarty->assign('labels_choice', $mod_strings['labelTypes']);
-		$smarty->assign('labels_current', $allLabels?"all":"");
+		$smarty->assign('labels_current', $allLabels ? "all" : "");
 
 		$ajax = new AjaxCompose();
 		$ajax->addCrumb($mod_strings['LBL_STUDIO'], 'ModuleBuilder.getContent("module=ModuleBuilder&action=wizard")');
@@ -191,17 +191,17 @@ 
                                            'Quotes',
                                            'ProductTemplates');
         
-        if(in_array($module, $hideQuickCreateForModules))
+        if (in_array($module, $hideQuickCreateForModules))
         {
-            if(isset($variableMap['quickcreate']))
+            if (isset($variableMap['quickcreate']))
             {
                 unset($variableMap['quickcreate']);
             }
         }
         
-        if($module == 'KBDocuments')
+        if ($module == 'KBDocuments')
         {
-            $variableMap  = array();
+            $variableMap = array();
         }
         
         return $variableMap;