Inspection of "Merge remote-tracking branch 'origin/develop' into..." - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( edae1e...431cf5 )

by Adam

created 2017-09-15 14:49 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
         'label' => 'LBL_LIST_PHONE', 
         'link' => false,
         'default' => true), 
-	'DATE_ENTERED' => array (
+	'DATE_ENTERED' => array(
 	    'type' => 'datetime',
 	    'label' => 'LBL_DATE_ENTERED',
 	    'width' => '10',

Please login to merge, or discard this patch.

modules/Documents/GetLatestRevision.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
 
 	$document = new Document();
 	$document->retrieve($_REQUEST['record']);
-	if (!empty($document->document_revision_id) && !empty($_REQUEST['get_latest_for_id']))  {
-		$query="update linked_documents set document_revision_id='{$document->document_revision_id}', date_modified='".TimeDate::getInstance()->nowDb()."' where id ='{$_REQUEST['get_latest_for_id']}' ";
+	if (!empty($document->document_revision_id) && !empty($_REQUEST['get_latest_for_id'])) {
+		$query = "update linked_documents set document_revision_id='{$document->document_revision_id}', date_modified='".TimeDate::getInstance()->nowDb()."' where id ='{$_REQUEST['get_latest_for_id']}' ";
 		$document->db->query($query);
 	}	
 }

Please login to merge, or discard this patch.

modules/Documents/DocumentExternalApiDropDown.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry)
+if (!defined('sugarEntry') || !sugarEntry)
 	die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
 
     $apiList = ExternalAPIFactory::getModuleDropDown('Documents');
 
-    $apiList = array_merge(array('Sugar'=>$GLOBALS['app_list_strings']['eapm_list']['Sugar']),$apiList);
-    if(!empty($value) && empty($apiList[$value])){
+    $apiList = array_merge(array('Sugar'=>$GLOBALS['app_list_strings']['eapm_list']['Sugar']), $apiList);
+    if (!empty($value) && empty($apiList[$value])) {
         $apiList[$value] = $value;
     }
     return $apiList;

Please login to merge, or discard this patch.

modules/Documents/metadata/editviewdefs.php 1 patch

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -1,29 +1,29 @@  discard block
 block discarded – undo
 <?php
 $viewdefs ['Documents'] = 
-array (
+array(
   'EditView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'form' => 
-      array (
+      array(
         'enctype' => 'multipart/form-data',
         'hidden' => 
-        array (
+        array(
           0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
           1 => '<input type="hidden" name="contract_id" value="{$smarty.request.contract_id}">',
         ),
       ),
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
@@ -33,93 +33,93 @@  discard block
 block discarded – undo
 {sugar_getscript file="modules/Documents/documents.js"}',
       'useTabs' => false,
       'tabDefs' => 
-      array (
+      array(
         'LBL_DOCUMENT_INFORMATION' => 
-        array (
+        array(
           'newTab' => false,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'lbl_document_information' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'filename',
             'displayParams' => 
-            array (
+            array(
               'onchangeSetFileNameTo' => 'document_name',
             ),
           ),
           1 => 
-          array (
+          array(
             'name' => 'status_id',
             'label' => 'LBL_DOC_STATUS',
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 'document_name',
           1 => 
-          array (
+          array(
             'name' => 'revision',
             'customCode' => '<input name="revision" type="text" value="{$fields.revision.value}" {$DISABLED}>',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'template_type',
             'label' => 'LBL_DET_TEMPLATE_TYPE',
           ),
           1 => 
-          array (
+          array(
             'name' => 'is_template',
             'label' => 'LBL_DET_IS_TEMPLATE',
           ),
         ),
         3 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'active_date',
           ),
           1 => 'exp_date',
         ),
         4 => 
-        array (
+        array(
           0 => 'category_id',
           1 => 'subcategory_id',
         ),
         5 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
           ),
         ),
         6 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'related_doc_name',
             'customCode' => '<input name="related_document_name" type="text" size="30" maxlength="255" value="{$RELATED_DOCUMENT_NAME}" readonly><input name="related_doc_id" type="hidden" value="{$fields.related_doc_id.value}"/>&nbsp;<input title="{$APP.LBL_SELECT_BUTTON_TITLE}" type="{$RELATED_DOCUMENT_BUTTON_AVAILABILITY}" class="button" value="{$APP.LBL_SELECT_BUTTON_LABEL}" name="btn2" onclick=\'open_popup("Documents", 600, 400, "", true, false, {$encoded_document_popup_request_data}, "single", true);\'/>',
           ),
           1 => 
-          array (
+          array(
             'name' => 'related_doc_rev_number',
             'customCode' => '<select name="related_doc_rev_id" id="related_doc_rev_id" {$RELATED_DOCUMENT_REVISION_DISABLED}>{$RELATED_DOCUMENT_REVISION_OPTIONS}</select>',
           ),
         ),
         7 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
           ),

Please login to merge, or discard this patch.

modules/Documents/metadata/popupdefs.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,16 +1,16 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
-$popupMeta = array (
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+$popupMeta = array(
     'moduleMain' => 'Documents',
     'varName' => 'DOCUMENTS',
     'orderBy' => 'name',
-    'whereClauses' => array (
+    'whereClauses' => array(
     ),
-    'searchInputs' => array (
+    'searchInputs' => array(
     ),
-    'searchdefs' => array (
+    'searchdefs' => array(
     ),
-    'listviewdefs' => array (
+    'listviewdefs' => array(
     ),
 );
 ?>
\ No newline at end of file

Please login to merge, or discard this patch.

modules/Documents/metadata/searchdefs.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -1,23 +1,23 @@  discard block
 block discarded – undo
 <?php
 $searchdefs ['Documents'] = 
-array (
+array(
   'layout' => 
-  array (
+  array(
     'basic_search' => 
-    array (
+    array(
       0 => 'document_name',
-      1 => array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
+      1 => array('name' => 'favorites_only', 'label' => 'LBL_FAVORITES_FILTER', 'type' => 'bool',),
     ),
     'advanced_search' => 
-    array (
+    array(
       'document_name' => 
-      array (
+      array(
         'name' => 'document_name',
         'default' => true,
         'width' => '10%',
       ),
       'status' => 
-      array (
+      array(
         'type' => 'varchar',
         'label' => 'LBL_DOC_STATUS',
         'width' => '10%',
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
         'name' => 'status',
       ),
       'template_type' => 
-      array (
+      array(
         'type' => 'enum',
         'label' => 'LBL_TEMPLATE_TYPE',
         'width' => '10%',
@@ -33,27 +33,27 @@  discard block
 block discarded – undo
         'name' => 'template_type',
       ),
       'category_id' => 
-      array (
+      array(
         'name' => 'category_id',
         'default' => true,
         'width' => '10%',
       ),
       'subcategory_id' => 
-      array (
+      array(
         'name' => 'subcategory_id',
         'default' => true,
         'width' => '10%',
       ),
       'assigned_user_id' => 
-      array (
+      array(
         'name' => 'assigned_user_id',
         'type' => 'enum',
         'label' => 'LBL_ASSIGNED_TO',
         'function' => 
-        array (
+        array(
           'name' => 'get_user_array',
           'params' => 
-          array (
+          array(
             0 => false,
           ),
         ),
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
         'width' => '10%',
       ),
       'active_date' => 
-      array (
+      array(
         'name' => 'active_date',
         'default' => true,
         'width' => '10%',
       ),
       'exp_date' => 
-      array (
+      array(
         'name' => 'exp_date',
         'default' => true,
         'width' => '10%',
@@ -75,11 +75,11 @@  discard block
 block discarded – undo
     ),
   ),
   'templateMeta' => 
-  array (
+  array(
     'maxColumns' => '3',
     'maxColumnsBasic' => '4',
     'widths' => 
-    array (
+    array(
       'label' => '10',
       'field' => '30',
     ),

Please login to merge, or discard this patch.

modules/Documents/metadata/detailviewdefs.php 1 patch

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -38,134 +38,134 @@
 block discarded – undo
  ********************************************************************************/
 
 $viewdefs ['Documents'] = 
-array (
+array(
   'DetailView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'maxColumns' => '2',
       'form' => 
-      array (
+      array(
         'hidden' => 
-        array (
+        array(
           0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
         ),
       ),
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'useTabs' => true,
       'tabDefs' => 
-      array (
+      array(
         'LBL_DOCUMENT_INFORMATION' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' =>
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'lbl_document_information' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'filename',
             'displayParams' => 
-            array (
+            array(
               'link' => 'filename',
               'id' => 'document_revision_id',
             ),
           ),
           1 => 
-          array (
+          array(
             'name' => 'status_id',
             'label' => 'LBL_DOC_STATUS',
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'document_name',
             'label' => 'LBL_DOC_NAME',
           ),
           1 => 
-          array (
+          array(
             'name' => 'revision',
             'label' => 'LBL_DOC_VERSION',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'template_type',
             'label' => 'LBL_DET_TEMPLATE_TYPE',
           ),
           1 => 
-          array (
+          array(
             'name' => 'is_template',
             'label' => 'LBL_DET_IS_TEMPLATE',
           ),
         ),
         3 => 
-        array (
+        array(
           0 => 'active_date',
           1 => 'exp_date',
         ),
         4 => 
-        array (
+        array(
           0 => 'category_id',
           1 => 'subcategory_id',
         ),
         5 => 
-        array (
+        array(
           0 => '',
           1 => '',
         ),
         6 => 
-        array (
+        array(
           0 => 'related_doc_name',
           1 => 'related_doc_rev_number',
         ),
         7 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
           ),
         ),
       ),
       'LBL_PANEL_ASSIGNMENT' =>
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
               'name' => 'date_entered',
               'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
           ),
           1 => 
-          array (
+          array(
               'name' => 'date_modified',
               'label' => 'LBL_DATE_MODIFIED',
               'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',

Please login to merge, or discard this patch.

modules/Documents/metadata/quickcreatedefs.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -49,39 +49,39 @@
 block discarded – undo
                                             array('label' => '10', 'field' => '30')
                                             ),
                             'includes' => 
-                              array (
+                              array(
                                 array('file' => 'include/javascript/popup_parent_helper.js'),
                                 array('file' => 'cache/include/javascript/sugar_grp_jsolait.js'),
                                 array('file' => 'modules/Documents/documents.js'),
                               ),
 ),
- 'panels' =>array (
+ 'panels' =>array(
   'default' => 
-  array (
+  array(
     
-    array (
+    array(
       'status_id',
     ),
-    array (
+    array(
       array('name'=>'filename', 
             'displayParams'=>array('required'=>true, 'onchangeSetFileNameTo' => 'document_name'),
             ),
     ),
     
-    array (
+    array(
       'document_name',
        array('name'=>'revision',
             'customCode' => '<input name="revision" type="text" value="{$fields.revision.value}" {$DISABLED}>'
            ),
     ),    
     
-    array (
-       array('name'=>'active_date','displayParams'=>array('required'=>true)),
+    array(
+       array('name'=>'active_date', 'displayParams'=>array('required'=>true)),
        'category_id',
     ),
     
 
-    array (
+    array(
       array('name'=>'description', 'displayParams'=>array('rows'=>10, 'cols'=>120)),
     ),
   ),

Please login to merge, or discard this patch.

modules/Documents/metadata/listviewdefs.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 
 $listViewDefs['Documents'] = array(
   'DOCUMENT_NAME' => 
-  array (
+  array(
     'width' => '20%',
     'label' => 'LBL_NAME',
     'link' => true,
@@ -51,16 +51,16 @@  discard block
 block discarded – undo
     'bold' => true,
   ),
   'FILENAME' => 
-  array (
+  array(
     'width' => '20%',
     'label' => 'LBL_FILENAME',
     'link' => true,
     'default' => true,
     'bold' => false,
-    'displayParams' => array ( 'module' => 'Documents', ),
+    'displayParams' => array('module' => 'Documents',),
     'sortable' => false,
     'related_fields' => 
-    array (
+    array(
         0 => 'document_revision_id',
         1 => 'doc_id', 
         2 => 'doc_type',
@@ -68,30 +68,30 @@  discard block
 block discarded – undo
     ),
   ),
   'CATEGORY_ID' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_CATEGORY',
     'default' => true,
   ),
   'SUBCATEGORY_ID' => 
-  array (
+  array(
     'width' => '15%',
     'label' => 'LBL_LIST_SUBCATEGORY',
     'default' => true,
   ),
   'LAST_REV_CREATE_DATE' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_LAST_REV_DATE',
     'default' => true,
     'sortable' => false,
     'related_fields' => 
-    array (
+    array(
       0 => 'document_revision_id',
     ),
   ),
   'EXP_DATE' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_EXP_DATE',
     'default' => true,
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
     'id' => 'ASSIGNED_USER_ID',
     'default' => true),
   'MODIFIED_BY_NAME' =>
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_MODIFIED_USER',
     'module' => 'Users',
@@ -112,11 +112,11 @@  discard block
 block discarded – undo
     'default' => false,
     'sortable' => false,
     'related_fields' =>
-    array (
+    array(
       0 => 'modified_user_id',
     ),
     ),
-  'DATE_ENTERED' => array (
+  'DATE_ENTERED' => array(
     'width' => '10%',
     'label' => 'LBL_DATE_ENTERED',
     'default' => true,

Please login to merge, or discard this patch.

		@@ -38,134 +38,134 @@
		block discarded – undo
38	38	********************************************************************************/
39	39
40	40	$viewdefs ['Documents'] =
41		-array (
	41	+array(
42	42	'DetailView' =>
43		- array (
	43	+ array(
44	44	'templateMeta' =>
45		- array (
	45	+ array(
46	46	'maxColumns' => '2',
47	47	'form' =>
48		- array (
	48	+ array(
49	49	'hidden' =>
50		- array (
	50	+ array(
51	51	0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
52	52	),
53	53	),
54	54	'widths' =>
55		- array (
	55	+ array(
56	56	0 =>
57		- array (
	57	+ array(
58	58	'label' => '10',
59	59	'field' => '30',
60	60	),
61	61	1 =>
62		- array (
	62	+ array(
63	63	'label' => '10',
64	64	'field' => '30',
65	65	),
66	66	),
67	67	'useTabs' => true,
68	68	'tabDefs' =>
69		- array (
	69	+ array(
70	70	'LBL_DOCUMENT_INFORMATION' =>
71		- array (
	71	+ array(
72	72	'newTab' => true,
73	73	'panelDefault' => 'expanded',
74	74	),
75	75	'LBL_PANEL_ASSIGNMENT' =>
76		- array (
	76	+ array(
77	77	'newTab' => true,
78	78	'panelDefault' => 'expanded',
79	79	),
80	80	),
81	81	),
82	82	'panels' =>
83		- array (
	83	+ array(
84	84	'lbl_document_information' =>
85		- array (
	85	+ array(
86	86	0 =>
87		- array (
	87	+ array(
88	88	0 =>
89		- array (
	89	+ array(
90	90	'name' => 'filename',
91	91	'displayParams' =>
92		- array (
	92	+ array(
93	93	'link' => 'filename',
94	94	'id' => 'document_revision_id',
95	95	),
96	96	),
97	97	1 =>
98		- array (
	98	+ array(
99	99	'name' => 'status_id',
100	100	'label' => 'LBL_DOC_STATUS',
101	101	),
102	102	),
103	103	1 =>
104		- array (
	104	+ array(
105	105	0 =>
106		- array (
	106	+ array(
107	107	'name' => 'document_name',
108	108	'label' => 'LBL_DOC_NAME',
109	109	),
110	110	1 =>
111		- array (
	111	+ array(
112	112	'name' => 'revision',
113	113	'label' => 'LBL_DOC_VERSION',
114	114	),
115	115	),
116	116	2 =>
117		- array (
	117	+ array(
118	118	0 =>
119		- array (
	119	+ array(
120	120	'name' => 'template_type',
121	121	'label' => 'LBL_DET_TEMPLATE_TYPE',
122	122	),
123	123	1 =>
124		- array (
	124	+ array(
125	125	'name' => 'is_template',
126	126	'label' => 'LBL_DET_IS_TEMPLATE',
127	127	),
128	128	),
129	129	3 =>
130		- array (
	130	+ array(
131	131	0 => 'active_date',
132	132	1 => 'exp_date',
133	133	),
134	134	4 =>
135		- array (
	135	+ array(
136	136	0 => 'category_id',
137	137	1 => 'subcategory_id',
138	138	),
139	139	5 =>
140		- array (
	140	+ array(
141	141	0 => '',
142	142	1 => '',
143	143	),
144	144	6 =>
145		- array (
	145	+ array(
146	146	0 => 'related_doc_name',
147	147	1 => 'related_doc_rev_number',
148	148	),
149	149	7 =>
150		- array (
	150	+ array(
151	151	0 =>
152		- array (
	152	+ array(
153	153	'name' => 'assigned_user_name',
154	154	'label' => 'LBL_ASSIGNED_TO_NAME',
155	155	),
156	156	),
157	157	),
158	158	'LBL_PANEL_ASSIGNMENT' =>
159		- array (
	159	+ array(
160	160	0 =>
161		- array (
	161	+ array(
162	162	0 =>
163		- array (
	163	+ array(
164	164	'name' => 'date_entered',
165	165	'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}',
166	166	),
167	167	1 =>
168		- array (
	168	+ array(
169	169	'name' => 'date_modified',
170	170	'label' => 'LBL_DATE_MODIFIED',
171	171	'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}',

		@@ -49,39 +49,39 @@
		block discarded – undo
49	49	array('label' => '10', 'field' => '30')
50	50	),
51	51	'includes' =>
52		- array (
	52	+ array(
53	53	array('file' => 'include/javascript/popup_parent_helper.js'),
54	54	array('file' => 'cache/include/javascript/sugar_grp_jsolait.js'),
55	55	array('file' => 'modules/Documents/documents.js'),
56	56	),
57	57	),
58		- 'panels' =>array (
	58	+ 'panels' =>array(
59	59	'default' =>
60		- array (
	60	+ array(
61	61
62		- array (
	62	+ array(
63	63	'status_id',
64	64	),
65		- array (
	65	+ array(
66	66	array('name'=>'filename',
67	67	'displayParams'=>array('required'=>true, 'onchangeSetFileNameTo' => 'document_name'),
68	68	),
69	69	),
70	70
71		- array (
	71	+ array(
72	72	'document_name',
73	73	array('name'=>'revision',
74	74	'customCode' => '<input name="revision" type="text" value="{$fields.revision.value}" {$DISABLED}>'
75	75	),
76	76	),
77	77
78		- array (
79		- array('name'=>'active_date','displayParams'=>array('required'=>true)),
	78	+ array(
	79	+ array('name'=>'active_date', 'displayParams'=>array('required'=>true)),
80	80	'category_id',
81	81	),
82	82
83	83
84		- array (
	84	+ array(
85	85	array('name'=>'description', 'displayParams'=>array('rows'=>10, 'cols'=>120)),
86	86	),
87	87	),

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if (!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
3	3	/*********************************************************************************
4	4	* SugarCRM Community Edition is a customer relationship management program developed by
5	5	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	'label' => 'LBL_LIST_PHONE',
66	66	'link' => false,
67	67	'default' => true),
68		- 'DATE_ENTERED' => array (
	68	+ 'DATE_ENTERED' => array(
69	69	'type' => 'datetime',
70	70	'label' => 'LBL_DATE_ENTERED',
71	71	'width' => '10',

		@@ -1,29 +1,29 @@ discard block
		block discarded – undo
1	1	<?php
2	2	$viewdefs ['Documents'] =
3		-array (
	3	+array(
4	4	'EditView' =>
5		- array (
	5	+ array(
6	6	'templateMeta' =>
7		- array (
	7	+ array(
8	8	'form' =>
9		- array (
	9	+ array(
10	10	'enctype' => 'multipart/form-data',
11	11	'hidden' =>
12		- array (
	12	+ array(
13	13	0 => '<input type="hidden" name="old_id" value="{$fields.document_revision_id.value}">',
14	14	1 => '<input type="hidden" name="contract_id" value="{$smarty.request.contract_id}">',
15	15	),
16	16	),
17	17	'maxColumns' => '2',
18	18	'widths' =>
19		- array (
	19	+ array(
20	20	0 =>
21		- array (
	21	+ array(
22	22	'label' => '10',
23	23	'field' => '30',
24	24	),
25	25	1 =>
26		- array (
	26	+ array(
27	27	'label' => '10',
28	28	'field' => '30',
29	29	),
		@@ -33,93 +33,93 @@ discard block
		block discarded – undo
33	33	{sugar_getscript file="modules/Documents/documents.js"}',
34	34	'useTabs' => false,
35	35	'tabDefs' =>
36		- array (
	36	+ array(
37	37	'LBL_DOCUMENT_INFORMATION' =>
38		- array (
	38	+ array(
39	39	'newTab' => false,
40	40	'panelDefault' => 'expanded',
41	41	),
42	42	),
43	43	),
44	44	'panels' =>
45		- array (
	45	+ array(
46	46	'lbl_document_information' =>
47		- array (
	47	+ array(
48	48	0 =>
49		- array (
	49	+ array(
50	50	0 =>
51		- array (
	51	+ array(
52	52	'name' => 'filename',
53	53	'displayParams' =>
54		- array (
	54	+ array(
55	55	'onchangeSetFileNameTo' => 'document_name',
56	56	),
57	57	),
58	58	1 =>
59		- array (
	59	+ array(
60	60	'name' => 'status_id',
61	61	'label' => 'LBL_DOC_STATUS',
62	62	),
63	63	),
64	64	1 =>
65		- array (
	65	+ array(
66	66	0 => 'document_name',
67	67	1 =>
68		- array (
	68	+ array(
69	69	'name' => 'revision',
70	70	'customCode' => '<input name="revision" type="text" value="{$fields.revision.value}" {$DISABLED}>',
71	71	),
72	72	),
73	73	2 =>
74		- array (
	74	+ array(
75	75	0 =>
76		- array (
	76	+ array(
77	77	'name' => 'template_type',
78	78	'label' => 'LBL_DET_TEMPLATE_TYPE',
79	79	),
80	80	1 =>
81		- array (
	81	+ array(
82	82	'name' => 'is_template',
83	83	'label' => 'LBL_DET_IS_TEMPLATE',
84	84	),
85	85	),
86	86	3 =>
87		- array (
	87	+ array(
88	88	0 =>
89		- array (
	89	+ array(
90	90	'name' => 'active_date',
91	91	),
92	92	1 => 'exp_date',
93	93	),
94	94	4 =>
95		- array (
	95	+ array(
96	96	0 => 'category_id',
97	97	1 => 'subcategory_id',
98	98	),
99	99	5 =>
100		- array (
	100	+ array(
101	101	0 =>
102		- array (
	102	+ array(
103	103	'name' => 'description',
104	104	),
105	105	),
106	106	6 =>
107		- array (
	107	+ array(
108	108	0 =>
109		- array (
	109	+ array(
110	110	'name' => 'related_doc_name',
111	111	'customCode' => '<input name="related_document_name" type="text" size="30" maxlength="255" value="{$RELATED_DOCUMENT_NAME}" readonly><input name="related_doc_id" type="hidden" value="{$fields.related_doc_id.value}"/> <input title="{$APP.LBL_SELECT_BUTTON_TITLE}" type="{$RELATED_DOCUMENT_BUTTON_AVAILABILITY}" class="button" value="{$APP.LBL_SELECT_BUTTON_LABEL}" name="btn2" onclick=\'open_popup("Documents", 600, 400, "", true, false, {$encoded_document_popup_request_data}, "single", true);\'/>',
112	112	),
113	113	1 =>
114		- array (
	114	+ array(
115	115	'name' => 'related_doc_rev_number',
116	116	'customCode' => '<select name="related_doc_rev_id" id="related_doc_rev_id" {$RELATED_DOCUMENT_REVISION_DISABLED}>{$RELATED_DOCUMENT_REVISION_OPTIONS}</select>',
117	117	),
118	118	),
119	119	7 =>
120		- array (
	120	+ array(
121	121	0 =>
122		- array (
	122	+ array(
123	123	'name' => 'assigned_user_name',
124	124	'label' => 'LBL_ASSIGNED_TO_NAME',
125	125	),

		@@ -1,16 +1,16 @@
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
3		-$popupMeta = array (
	2	+if (!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	3	+$popupMeta = array(
4	4	'moduleMain' => 'Documents',
5	5	'varName' => 'DOCUMENTS',
6	6	'orderBy' => 'name',
7		- 'whereClauses' => array (
	7	+ 'whereClauses' => array(
8	8	),
9		- 'searchInputs' => array (
	9	+ 'searchInputs' => array(
10	10	),
11		- 'searchdefs' => array (
	11	+ 'searchdefs' => array(
12	12	),
13		- 'listviewdefs' => array (
	13	+ 'listviewdefs' => array(
14	14	),
15	15	);
16	16	?>
17	17	\ No newline at end of file

		@@ -1,23 +1,23 @@ discard block
		block discarded – undo
1	1	<?php
2	2	$searchdefs ['Documents'] =
3		-array (
	3	+array(
4	4	'layout' =>
5		- array (
	5	+ array(
6	6	'basic_search' =>
7		- array (
	7	+ array(
8	8	0 => 'document_name',
9		- 1 => array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
	9	+ 1 => array('name' => 'favorites_only', 'label' => 'LBL_FAVORITES_FILTER', 'type' => 'bool',),
10	10	),
11	11	'advanced_search' =>
12		- array (
	12	+ array(
13	13	'document_name' =>
14		- array (
	14	+ array(
15	15	'name' => 'document_name',
16	16	'default' => true,
17	17	'width' => '10%',
18	18	),
19	19	'status' =>
20		- array (
	20	+ array(
21	21	'type' => 'varchar',
22	22	'label' => 'LBL_DOC_STATUS',
23	23	'width' => '10%',
		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	'name' => 'status',
26	26	),
27	27	'template_type' =>
28		- array (
	28	+ array(
29	29	'type' => 'enum',
30	30	'label' => 'LBL_TEMPLATE_TYPE',
31	31	'width' => '10%',
		@@ -33,27 +33,27 @@ discard block
		block discarded – undo
33	33	'name' => 'template_type',
34	34	),
35	35	'category_id' =>
36		- array (
	36	+ array(
37	37	'name' => 'category_id',
38	38	'default' => true,
39	39	'width' => '10%',
40	40	),
41	41	'subcategory_id' =>
42		- array (
	42	+ array(
43	43	'name' => 'subcategory_id',
44	44	'default' => true,
45	45	'width' => '10%',
46	46	),
47	47	'assigned_user_id' =>
48		- array (
	48	+ array(
49	49	'name' => 'assigned_user_id',
50	50	'type' => 'enum',
51	51	'label' => 'LBL_ASSIGNED_TO',
52	52	'function' =>
53		- array (
	53	+ array(
54	54	'name' => 'get_user_array',
55	55	'params' =>
56		- array (
	56	+ array(
57	57	0 => false,
58	58	),
59	59	),
		@@ -61,13 +61,13 @@ discard block
		block discarded – undo
61	61	'width' => '10%',
62	62	),
63	63	'active_date' =>
64		- array (
	64	+ array(
65	65	'name' => 'active_date',
66	66	'default' => true,
67	67	'width' => '10%',
68	68	),
69	69	'exp_date' =>
70		- array (
	70	+ array(
71	71	'name' => 'exp_date',
72	72	'default' => true,
73	73	'width' => '10%',
		@@ -75,11 +75,11 @@ discard block
		block discarded – undo
75	75	),
76	76	),
77	77	'templateMeta' =>
78		- array (
	78	+ array(
79	79	'maxColumns' => '3',
80	80	'maxColumnsBasic' => '4',
81	81	'widths' =>
82		- array (
	82	+ array(
83	83	'label' => '10',
84	84	'field' => '30',
85	85	),

adamjakab / SuiteCRM

Push — develop ( edae1e...431cf5 )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +31 added lines, -31 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch