adamjakab / SuiteCRM

modules/ProjectTask/metadata/detailviewdefs.php

Indentation +74 added lines, -74 removed lines

@@ -1,156 +1,156 @@
 <?php
 $viewdefs ['ProjectTask'] = 
 array (
-  'DetailView' => 
-  array (
+    'DetailView' => 
+    array (
     'templateMeta' => 
     array (
-      'maxColumns' => '2',
-      'widths' => 
-      array (
+        'maxColumns' => '2',
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
-      ),
-      'includes' => 
-      array (
+        ),
+        'includes' => 
+        array (
         0 => 
         array (
-          'file' => 'modules/ProjectTask/ProjectTask.js',
+            'file' => 'modules/ProjectTask/ProjectTask.js',
         ),
-      ),
-      'form' => 
-      array (
+        ),
+        'form' => 
+        array (
         'buttons' => 
         array (
-          0 => 'EDIT',
-          1 => 'DUPLICATE',
-          2 => 'DELETE',
+            0 => 'EDIT',
+            1 => 'DUPLICATE',
+            2 => 'DELETE',
         ),
         'hideAudit' => true,
-      ),
-      'useTabs' => true,
-      'tabDefs' => 
-      array (
+        ),
+        'useTabs' => true,
+        'tabDefs' => 
+        array (
         'DEFAULT' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_TIMELINE' =>
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
-      ),
-      'syncDetailEditViews' => true,
+        ),
+        'syncDetailEditViews' => true,
     ),
     'panels' => 
     array (
-      'default' => 
-      array (
+        'default' => 
+        array (
         0 => 
         array (
-          0 => 'name',
-          1 => 'status',
+            0 => 'name',
+            1 => 'status',
         ),
         1 => 
         array (
-          0 => 'date_start',
-          1 => 'date_finish',
+            0 => 'date_start',
+            1 => 'date_finish',
         ),
         2 => 
         array (
-          0 => 'priority',
-          1 => 'percent_complete',
+            0 => 'priority',
+            1 => 'percent_complete',
         ),
         3 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'project_name',
             'customCode' => '<a href="index.php?module=Project&action=DetailView&record={$fields.project_id.value}">{$fields.project_name.value}&nbsp;</a>',
             'label' => 'LBL_PARENT_ID',
-          ),
-          1 => 'task_number',
+            ),
+            1 => 'task_number',
         ),
         4 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_USER_ID',
-          ),
+            ),
         ),
         5 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'description',
-          ),
+            ),
         ),
-      ),
-      'LBL_PANEL_TIMELINE' =>
-      array (
+        ),
+        'LBL_PANEL_TIMELINE' =>
+        array (
         0 => 
         array (
-          0 => 'estimated_effort',
-          1 => 
-          array (
+            0 => 'estimated_effort',
+            1 => 
+            array (
             'name' => 'actual_effort',
             'label' => 'LBL_ACTUAL_EFFORT',
-          ),
+            ),
         ),
         1 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'predecessors',
             'label' => 'LBL_PREDECESSORS',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'relationship_type',
             'studio' => 'visible',
             'label' => 'LBL_RELATIONSHIP_TYPE',
-          ),
+            ),
         ),
         2 => 
         array (
-          0 => 'order_number',
-          1 => 
-          array (
+            0 => 'order_number',
+            1 => 
+            array (
             'name' => 'milestone_flag',
             'label' => 'LBL_MILESTONE_FLAG',
-          ),
+            ),
         ),
         3 => 
         array (
-          0 => 'utilization',
-          1 => '',
+            0 => 'utilization',
+            1 => '',
         ),
         4 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'duration',
             'label' => 'LBL_DURATION',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'duration_unit',
             'label' => 'LBL_DURATION_UNIT',
-          ),
+            ),
+        ),
         ),
-      ),
     ),
-  ),
+    ),
 );
 ?>

Spacing +36 added lines, -36 removed lines

@@ -1,35 +1,35 @@ 
 <?php
 $viewdefs ['ProjectTask'] = 
-array (
+array(
   'DetailView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'includes' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'file' => 'modules/ProjectTask/ProjectTask.js',
         ),
       ),
       'form' => 
-      array (
+      array(
         'buttons' => 
-        array (
+        array(
           0 => 'EDIT',
           1 => 'DUPLICATE',
           2 => 'DELETE',
@@ -38,14 +38,14 @@ 
       ),
       'useTabs' => true,
       'tabDefs' => 
-      array (
+      array(
         'DEFAULT' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_TIMELINE' =>
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
@@ -53,28 +53,28 @@ 
       'syncDetailEditViews' => true,
     ),
     'panels' => 
-    array (
+    array(
       'default' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 'name',
           1 => 'status',
         ),
         1 => 
-        array (
+        array(
           0 => 'date_start',
           1 => 'date_finish',
         ),
         2 => 
-        array (
+        array(
           0 => 'priority',
           1 => 'percent_complete',
         ),
         3 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'project_name',
             'customCode' => '<a href="index.php?module=Project&action=DetailView&record={$fields.project_id.value}">{$fields.project_name.value}&nbsp;</a>',
             'label' => 'LBL_PARENT_ID',
@@ -82,69 +82,69 @@ 
           1 => 'task_number',
         ),
         4 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_USER_ID',
           ),
         ),
         5 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
           ),
         ),
       ),
       'LBL_PANEL_TIMELINE' =>
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 'estimated_effort',
           1 => 
-          array (
+          array(
             'name' => 'actual_effort',
             'label' => 'LBL_ACTUAL_EFFORT',
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'predecessors',
             'label' => 'LBL_PREDECESSORS',
           ),
           1 => 
-          array (
+          array(
             'name' => 'relationship_type',
             'studio' => 'visible',
             'label' => 'LBL_RELATIONSHIP_TYPE',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 'order_number',
           1 => 
-          array (
+          array(
             'name' => 'milestone_flag',
             'label' => 'LBL_MILESTONE_FLAG',
           ),
         ),
         3 => 
-        array (
+        array(
           0 => 'utilization',
           1 => '',
         ),
         4 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration',
             'label' => 'LBL_DURATION',
           ),
           1 => 
-          array (
+          array(
             'name' => 'duration_unit',
             'label' => 'LBL_DURATION_UNIT',
           ),

modules/ProjectTask/metadata/quickcreatedefs.php

Indentation +55 added lines, -55 removed lines

@@ -1,130 +1,130 @@
 <?php
 $viewdefs ['ProjectTask'] = 
 array (
-  'QuickCreate' => 
-  array (
+    'QuickCreate' => 
+    array (
     'templateMeta' => 
     array (
-      'maxColumns' => '2',
-      'widths' => 
-      array (
+        'maxColumns' => '2',
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
-      ),
-      'includes' => 
-      array (
+        ),
+        'includes' => 
+        array (
         0 => 
         array (
-          'file' => 'modules/ProjectTask/ProjectTask.js',
+            'file' => 'modules/ProjectTask/ProjectTask.js',
+        ),
         ),
-      ),
     ),
     'panels' => 
     array (
-      'default' => 
-      array (
+        'default' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'name',
             'label' => 'LBL_NAME',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'project_task_id',
             'label' => 'LBL_TASK_ID',
-          ),
+            ),
         ),
         1 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'date_start',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'date_finish',
-          ),
+            ),
         ),
         2 => 
         array (
-          'name' => 'assigned_user_name',
+            'name' => 'assigned_user_name',
         ),
         3 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'status',
             'customCode' => '<select name="{$fields.status.name}" id="{$fields.status.name}" title="" tabindex="s" onchange="update_percent_complete(this.value);">{if isset($fields.status.value) && $fields.status.value != ""}{html_options options=$fields.status.options selected=$fields.status.value}{else}{html_options options=$fields.status.options selected=$fields.status.default}{/if}</select>',
-          ),
-          1 => 'priority',
+            ),
+            1 => 'priority',
         ),
         4 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'percent_complete',
             'customCode' => '<input type="text" name="{$fields.percent_complete.name}" id="{$fields.percent_complete.name}" size="30" value="{$fields.percent_complete.value}" title="" tabindex="0" onChange="update_status(this.value);" /></tr>',
-          ),
+            ),
         ),
         5 => 
         array (
-          0 => 'milestone_flag',
+            0 => 'milestone_flag',
         ),
         6 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'project_name',
             'label' => 'LBL_PROJECT_NAME',
-          ),
+            ),
         ),
         7 => 
         array (
-          0 => 'task_number',
-          1 => 'order_number',
+            0 => 'task_number',
+            1 => 'order_number',
         ),
         8 => 
         array (
-          0 => 'estimated_effort',
-          1 => 'utilization',
+            0 => 'estimated_effort',
+            1 => 'utilization',
         ),
         9 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'description',
-          ),
+            ),
         ),
         10 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'duration',
             'hideLabel' => true,
             'customCode' => '<input type="hidden" name="duration" id="projectTask_duration" value="0" />',
-          ),
+            ),
         ),
         11 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'duration_unit',
             'hideLabel' => true,
             'customCode' => '<input type="hidden" name="duration_unit" id="projectTask_durationUnit" value="Days" />',
-          ),
+            ),
         ),
-      ),
+        ),
+    ),
     ),
-  ),
 );
 ?>

Spacing +32 added lines, -32 removed lines

@@ -1,123 +1,123 @@
 <?php
 $viewdefs ['ProjectTask'] = 
-array (
+array(
   'QuickCreate' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'includes' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'file' => 'modules/ProjectTask/ProjectTask.js',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'default' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'name',
             'label' => 'LBL_NAME',
           ),
           1 => 
-          array (
+          array(
             'name' => 'project_task_id',
             'label' => 'LBL_TASK_ID',
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_start',
           ),
           1 => 
-          array (
+          array(
             'name' => 'date_finish',
           ),
         ),
         2 => 
-        array (
+        array(
           'name' => 'assigned_user_name',
         ),
         3 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'status',
             'customCode' => '<select name="{$fields.status.name}" id="{$fields.status.name}" title="" tabindex="s" onchange="update_percent_complete(this.value);">{if isset($fields.status.value) && $fields.status.value != ""}{html_options options=$fields.status.options selected=$fields.status.value}{else}{html_options options=$fields.status.options selected=$fields.status.default}{/if}</select>',
           ),
           1 => 'priority',
         ),
         4 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'percent_complete',
             'customCode' => '<input type="text" name="{$fields.percent_complete.name}" id="{$fields.percent_complete.name}" size="30" value="{$fields.percent_complete.value}" title="" tabindex="0" onChange="update_status(this.value);" /></tr>',
           ),
         ),
         5 => 
-        array (
+        array(
           0 => 'milestone_flag',
         ),
         6 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'project_name',
             'label' => 'LBL_PROJECT_NAME',
           ),
         ),
         7 => 
-        array (
+        array(
           0 => 'task_number',
           1 => 'order_number',
         ),
         8 => 
-        array (
+        array(
           0 => 'estimated_effort',
           1 => 'utilization',
         ),
         9 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
           ),
         ),
         10 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration',
             'hideLabel' => true,
             'customCode' => '<input type="hidden" name="duration" id="projectTask_duration" value="0" />',
           ),
         ),
         11 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration_unit',
             'hideLabel' => true,
             'customCode' => '<input type="hidden" name="duration_unit" id="projectTask_durationUnit" value="Days" />',

modules/ProjectTask/metadata/listviewdefs.php

Indentation +22 added lines, -22 removed lines

@@ -1,16 +1,16 @@ 
 <?php
 $listViewDefs ['ProjectTask'] = 
 array (
-  'NAME' => 
-  array (
+    'NAME' => 
+    array (
     'width' => '40%',
     'label' => 'LBL_LIST_NAME',
     'link' => true,
     'default' => true,
     'sortable' => true,
-  ),
-  'PROJECT_NAME' => 
-  array (
+    ),
+    'PROJECT_NAME' => 
+    array (
     'width' => '25%',
     'label' => 'LBL_PROJECT_NAME',
     'id' => 'PROJECT_ID',
@@ -21,44 +21,44 @@ 
     'ACLTag' => 'PROJECT',
     'related_fields' => 
     array (
-      0 => 'project_id',
+        0 => 'project_id',
+    ),
     ),
-  ),
-  'DATE_START' => 
-  array (
+    'DATE_START' => 
+    array (
     'width' => '10%',
     'label' => 'LBL_DATE_START',
     'default' => true,
     'sortable' => true,
-  ),
-  'DATE_FINISH' => 
-  array (
+    ),
+    'DATE_FINISH' => 
+    array (
     'width' => '10%',
     'label' => 'LBL_DATE_FINISH',
     'default' => true,
     'sortable' => true,
-  ),
-  'ASSIGNED_USER_NAME' => 
-  array (
+    ),
+    'ASSIGNED_USER_NAME' => 
+    array (
     'width' => '10%',
     'label' => 'LBL_LIST_ASSIGNED_USER_ID',
     'module' => 'Employees',
     'id' => 'ASSIGNED_USER_ID',
     'default' => true,
-  ),
-  'PRIORITY' => 
-  array (
+    ),
+    'PRIORITY' => 
+    array (
     'width' => '10%',
     'label' => 'LBL_LIST_PRIORITY',
     'default' => true,
     'sortable' => true,
-  ),
-  'PERCENT_COMPLETE' => 
-  array (
+    ),
+    'PERCENT_COMPLETE' => 
+    array (
     'width' => '10%',
     'label' => 'LBL_LIST_PERCENT_COMPLETE',
     'default' => true,
     'sortable' => true,
-  ),
+    ),
 );
 ?>

Spacing +9 added lines, -9 removed lines

@@ -1,8 +1,8 @@ 
 <?php
 $listViewDefs ['ProjectTask'] = 
-array (
+array(
   'NAME' => 
-  array (
+  array(
     'width' => '40%',
     'label' => 'LBL_LIST_NAME',
     'link' => true,
@@ -10,7 +10,7 @@ 
     'sortable' => true,
   ),
   'PROJECT_NAME' => 
-  array (
+  array(
     'width' => '25%',
     'label' => 'LBL_PROJECT_NAME',
     'id' => 'PROJECT_ID',
@@ -20,26 +20,26 @@ 
     'module' => 'Project',
     'ACLTag' => 'PROJECT',
     'related_fields' => 
-    array (
+    array(
       0 => 'project_id',
     ),
   ),
   'DATE_START' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_DATE_START',
     'default' => true,
     'sortable' => true,
   ),
   'DATE_FINISH' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_DATE_FINISH',
     'default' => true,
     'sortable' => true,
   ),
   'ASSIGNED_USER_NAME' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_ASSIGNED_USER_ID',
     'module' => 'Employees',
@@ -47,14 +47,14 @@ 
     'default' => true,
   ),
   'PRIORITY' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_PRIORITY',
     'default' => true,
     'sortable' => true,
   ),
   'PERCENT_COMPLETE' => 
-  array (
+  array(
     'width' => '10%',
     'label' => 'LBL_LIST_PERCENT_COMPLETE',
     'default' => true,

modules/Calls/SubPanelViewInvitees.php

Indentation +27 added lines, -27 removed lines

@@ -88,29 +88,29 @@ 
 $oddRow = true;
 foreach($focus_users_list as $user)
 {
-	$user_fields = array(
-		'USER_NAME' => $user->user_name,
-		'FULL_NAME' => $locale->getLocaleFormattedName($user->first_name, $user->last_name),
-		'ID' => $user->id,
-		'EMAIL' => $user->email1,
-		'PHONE_WORK' => $user->phone_work
-	);
+    $user_fields = array(
+        'USER_NAME' => $user->user_name,
+        'FULL_NAME' => $locale->getLocaleFormattedName($user->first_name, $user->last_name),
+        'ID' => $user->id,
+        'EMAIL' => $user->email1,
+        'PHONE_WORK' => $user->phone_work
+    );
 
-	$xtpl->assign("USER", $user_fields);
+    $xtpl->assign("USER", $user_fields);
 
-	if($oddRow)
+    if($oddRow)
     {
         //todo move to themes
-		$xtpl->assign("ROW_COLOR", 'oddListRow');
+        $xtpl->assign("ROW_COLOR", 'oddListRow');
     }
     else
     {
         //todo move to themes
-		$xtpl->assign("ROW_COLOR", 'evenListRow');
+        $xtpl->assign("ROW_COLOR", 'evenListRow');
     }
     $oddRow = !$oddRow;
 
-	$xtpl->parse("users.row");
+    $xtpl->parse("users.row");
 // Put the rows in.
 }
 
@@ -120,30 +120,30 @@ 
 $oddRow = true;
 foreach($focus_contacts_list as $contact)
 {
-	$contact_fields = array(
-		'FIRST_NAME' => $contact->first_name,
-		'LAST_NAME' => $contact->last_name,
-		'ACCOUNT_NAME' => $contact->account_name,
-		'ID' => $contact->id,
-		'EMAIL' => $contact->email1,
-		'PHONE_WORK' => $contact->phone_work
-	);
-
-	$xtpl->assign("CONTACT", $contact_fields);
-
-	if($oddRow)
+    $contact_fields = array(
+        'FIRST_NAME' => $contact->first_name,
+        'LAST_NAME' => $contact->last_name,
+        'ACCOUNT_NAME' => $contact->account_name,
+        'ID' => $contact->id,
+        'EMAIL' => $contact->email1,
+        'PHONE_WORK' => $contact->phone_work
+    );
+
+    $xtpl->assign("CONTACT", $contact_fields);
+
+    if($oddRow)
     {
         //todo move to themes
-		$xtpl->assign("ROW_COLOR", 'oddListRow');
+        $xtpl->assign("ROW_COLOR", 'oddListRow');
     }
     else
     {
         //todo move to themes
-		$xtpl->assign("ROW_COLOR", 'evenListRow');
+        $xtpl->assign("ROW_COLOR", 'evenListRow');
     }
     $oddRow = !$oddRow;
 
-	$xtpl->parse("contacts.row");
+    $xtpl->parse("contacts.row");
 // Put the rows in.
 }
 

Spacing +6 added lines, -6 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -78,7 +78,7 @@ 
 
 // Stick the form header out there.
 echo get_form_header($mod_strings['LBL_INVITEES'], $button, false);
-$xtpl=new XTemplate ('modules/Calls/SubPanelViewInvitees.html');
+$xtpl = new XTemplate('modules/Calls/SubPanelViewInvitees.html');
 $xtpl->assign("MOD", $mod_strings);
 $xtpl->assign("APP", $app_strings);
 
@@ -86,7 +86,7 @@ 
 $xtpl->assign("CALL_ID", $focus->id);
 
 $oddRow = true;
-foreach($focus_users_list as $user)
+foreach ($focus_users_list as $user)
 {
 	$user_fields = array(
 		'USER_NAME' => $user->user_name,
@@ -98,7 +98,7 @@ 
 
 	$xtpl->assign("USER", $user_fields);
 
-	if($oddRow)
+	if ($oddRow)
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'oddListRow');
@@ -118,7 +118,7 @@ 
 $xtpl->out("users");
 
 $oddRow = true;
-foreach($focus_contacts_list as $contact)
+foreach ($focus_contacts_list as $contact)
 {
 	$contact_fields = array(
 		'FIRST_NAME' => $contact->first_name,
@@ -131,7 +131,7 @@ 
 
 	$xtpl->assign("CONTACT", $contact_fields);
 
-	if($oddRow)
+	if ($oddRow)
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'oddListRow');

Braces +13 added lines, -8 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -65,14 +67,19 @@ 
 
 $button  = "<table cellspacing='0' cellpadding='1' border='0'><form border='0' action='index.php' method='post' name='form' id='form'>\n";
 $button .= "<input type='hidden' name='module' value='Contacts'>\n";
-if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value='$focus->name'>\n";
+if ($currentModule == 'Accounts') {
+    $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value='$focus->name'>\n";
+}
 $button .= "<input type='hidden' name='return_module' value='".$currentModule."'>\n";
 $button .= "<input type='hidden' name='return_action' value='".$action."'>\n";
 $button .= "<input type='hidden' name='return_id' value='".$focus->id."'>\n";
 $button .= "<input type='hidden' name='action'>\n";
 $button .= "<tr><td>&nbsp;</td>";
-if ($focus->parent_type == "Accounts") $button .= "<td><input title='".$app_strings['LBL_SELECT_CONTACT_BUTTON_TITLE']."' type='button' class='button' value='".$app_strings['LBL_SELECT_CONTACT_BUTTON_LABEL']."' name='button' LANGUAGE=javascript onclick='window.open(\"index.php?module=Contacts&action=Popup&html=Popup_picker&form=DetailView&form_submit=true&query=true&account_id=$focus->parent_id&account_name=".urlencode($focus->parent_name)."\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'></td>\n";
-else $button .= "<td><input title='".$app_strings['LBL_SELECT_CONTACT_BUTTON_TITLE']."'  type='button' class='button' value='".$app_strings['LBL_SELECT_CONTACT_BUTTON_LABEL']."' name='button' LANGUAGE=javascript onclick='window.open(\"index.php?module=Contacts&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'></td>\n";
+if ($focus->parent_type == "Accounts") {
+    $button .= "<td><input title='".$app_strings['LBL_SELECT_CONTACT_BUTTON_TITLE']."' type='button' class='button' value='".$app_strings['LBL_SELECT_CONTACT_BUTTON_LABEL']."' name='button' LANGUAGE=javascript onclick='window.open(\"index.php?module=Contacts&action=Popup&html=Popup_picker&form=DetailView&form_submit=true&query=true&account_id=$focus->parent_id&account_name=".urlencode($focus->parent_name)."\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'></td>\n";
+} else {
+    $button .= "<td><input title='".$app_strings['LBL_SELECT_CONTACT_BUTTON_TITLE']."'  type='button' class='button' value='".$app_strings['LBL_SELECT_CONTACT_BUTTON_LABEL']."' name='button' LANGUAGE=javascript onclick='window.open(\"index.php?module=Contacts&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'></td>\n";
+}
 $button .= "<td><input title='".$app_strings['LBL_SELECT_USER_BUTTON_TITLE']."'  type='button' class='button' value='".$app_strings['LBL_SELECT_USER_BUTTON_LABEL']."' name='button' LANGUAGE=javascript onclick='window.open(\"index.php?module=Users&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'></td>\n";
 $button .= "</tr></form></table>\n";
 
@@ -102,8 +109,7 @@ 
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'oddListRow');
-    }
-    else
+    } else
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'evenListRow');
@@ -135,8 +141,7 @@ 
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'oddListRow');
-    }
-    else
+    } else
     {
         //todo move to themes
 		$xtpl->assign("ROW_COLOR", 'evenListRow');

modules/Calls/Call.php

Indentation +512 added lines, -512 removed lines

@@ -47,162 +47,162 @@ 
  ********************************************************************************/
 
 class Call extends SugarBean {
-	var $field_name_map;
-	// Stored fields
-	var $id;
-	var $json_id;
-	var $date_entered;
-	var $date_modified;
-	var $assigned_user_id;
-	var $modified_user_id;
-	var $description;
-	var $name;
-	var $status;
-	var $date_start;
-	var $time_start;
-	var $duration_hours;
-	var $duration_minutes;
-	var $date_end;
-	var $parent_type;
-	var $parent_type_options;
-	var $parent_id;
-	var $contact_id;
-	var $user_id;
-	var $lead_id;
-	var $direction;
-	var $reminder_time;
-	var $reminder_time_options;
-	var $reminder_checked;
-	var $email_reminder_time;
-	var $email_reminder_checked;
-	var $email_reminder_sent;
-	var $required;
-	var $accept_status;
-	var $created_by;
-	var $created_by_name;
-	var $modified_by_name;
-	var $parent_name;
-	var $contact_name;
-	var $contact_phone;
-	var $contact_email;
-	var $account_id;
-	var $opportunity_id;
-	var $case_id;
-	var $assigned_user_name;
-	var $note_id;
+    var $field_name_map;
+    // Stored fields
+    var $id;
+    var $json_id;
+    var $date_entered;
+    var $date_modified;
+    var $assigned_user_id;
+    var $modified_user_id;
+    var $description;
+    var $name;
+    var $status;
+    var $date_start;
+    var $time_start;
+    var $duration_hours;
+    var $duration_minutes;
+    var $date_end;
+    var $parent_type;
+    var $parent_type_options;
+    var $parent_id;
+    var $contact_id;
+    var $user_id;
+    var $lead_id;
+    var $direction;
+    var $reminder_time;
+    var $reminder_time_options;
+    var $reminder_checked;
+    var $email_reminder_time;
+    var $email_reminder_checked;
+    var $email_reminder_sent;
+    var $required;
+    var $accept_status;
+    var $created_by;
+    var $created_by_name;
+    var $modified_by_name;
+    var $parent_name;
+    var $contact_name;
+    var $contact_phone;
+    var $contact_email;
+    var $account_id;
+    var $opportunity_id;
+    var $case_id;
+    var $assigned_user_name;
+    var $note_id;
     var $outlook_id;
-	var $update_vcal = true;
-	var $contacts_arr;
-	var $users_arr;
-	var $leads_arr;
-	var $default_call_name_values = array('Assemble catalogs', 'Make travel arrangements', 'Send a letter', 'Send contract', 'Send fax', 'Send a follow-up letter', 'Send literature', 'Send proposal', 'Send quote');
-	var $minutes_value_default = 15;
-	var $minutes_values = array('0'=>'00','15'=>'15','30'=>'30','45'=>'45');
-	var $table_name = "calls";
-	var $rel_users_table = "calls_users";
-	var $rel_contacts_table = "calls_contacts";
+    var $update_vcal = true;
+    var $contacts_arr;
+    var $users_arr;
+    var $leads_arr;
+    var $default_call_name_values = array('Assemble catalogs', 'Make travel arrangements', 'Send a letter', 'Send contract', 'Send fax', 'Send a follow-up letter', 'Send literature', 'Send proposal', 'Send quote');
+    var $minutes_value_default = 15;
+    var $minutes_values = array('0'=>'00','15'=>'15','30'=>'30','45'=>'45');
+    var $table_name = "calls";
+    var $rel_users_table = "calls_users";
+    var $rel_contacts_table = "calls_contacts";
     var $rel_leads_table = "calls_leads";
-	var $module_dir = 'Calls';
-	var $object_name = "Call";
-	var $new_schema = true;
-	var $importable = true;
-	var $syncing = false;
-	var $recurring_source;
-
-	// This is used to retrieve related fields from form posts.
-	var $additional_column_fields = array('assigned_user_name', 'assigned_user_id', 'contact_id', 'user_id', 'contact_name');
-	var $relationship_fields = array(	'account_id'		=> 'accounts',
-										'opportunity_id'	=> 'opportunities',
-										'contact_id'		=> 'contacts',
-										'case_id'			=> 'cases',
-										'user_id'			=> 'users',
-										'assigned_user_id'	=> 'users',
-										'note_id'			=> 'notes',
+    var $module_dir = 'Calls';
+    var $object_name = "Call";
+    var $new_schema = true;
+    var $importable = true;
+    var $syncing = false;
+    var $recurring_source;
+
+    // This is used to retrieve related fields from form posts.
+    var $additional_column_fields = array('assigned_user_name', 'assigned_user_id', 'contact_id', 'user_id', 'contact_name');
+    var $relationship_fields = array(	'account_id'		=> 'accounts',
+                                        'opportunity_id'	=> 'opportunities',
+                                        'contact_id'		=> 'contacts',
+                                        'case_id'			=> 'cases',
+                                        'user_id'			=> 'users',
+                                        'assigned_user_id'	=> 'users',
+                                        'note_id'			=> 'notes',
                                         'lead_id'			=> 'leads',
-								);
-
-	function Call() {
-		parent::SugarBean();
-		global $app_list_strings;
-
-       	$this->setupCustomFields('Calls');
-
-		foreach ($this->field_defs as $field) {
-			$this->field_name_map[$field['name']] = $field;
-		}
-
-
-
-
-         if(!empty($GLOBALS['app_list_strings']['duration_intervals']))
-        	$this->minutes_values = $GLOBALS['app_list_strings']['duration_intervals'];
-	}
-
-	/**
-	 * Disable edit if call is recurring and source is not Sugar. It should be edited only from Outlook.
-	 * @param $view string
-	 * @param $is_owner bool
-	 */
-	function ACLAccess($view,$is_owner='not_set',$in_group='not_set'){
-		// don't check if call is being synced from Outlook
-		if($this->syncing == false){
-			$view = strtolower($view);
-			switch($view){
-				case 'edit':
-				case 'save':
-				case 'editview':
-				case 'delete':
-					if(!empty($this->recurring_source) && $this->recurring_source != "Sugar"){
-						return false;
-					}
-			}
-		}
-		return parent::ACLAccess($view,$is_owner,$in_group);
-	}
+                                );
+
+    function Call() {
+        parent::SugarBean();
+        global $app_list_strings;
+
+            $this->setupCustomFields('Calls');
+
+        foreach ($this->field_defs as $field) {
+            $this->field_name_map[$field['name']] = $field;
+        }
+
+
+
+
+            if(!empty($GLOBALS['app_list_strings']['duration_intervals']))
+            $this->minutes_values = $GLOBALS['app_list_strings']['duration_intervals'];
+    }
+
+    /**
+     * Disable edit if call is recurring and source is not Sugar. It should be edited only from Outlook.
+     * @param $view string
+     * @param $is_owner bool
+     */
+    function ACLAccess($view,$is_owner='not_set',$in_group='not_set'){
+        // don't check if call is being synced from Outlook
+        if($this->syncing == false){
+            $view = strtolower($view);
+            switch($view){
+                case 'edit':
+                case 'save':
+                case 'editview':
+                case 'delete':
+                    if(!empty($this->recurring_source) && $this->recurring_source != "Sugar"){
+                        return false;
+                    }
+            }
+        }
+        return parent::ACLAccess($view,$is_owner,$in_group);
+    }
     // save date_end by calculating user input
     // this is for calendar
-	function save($check_notify = FALSE) {
-		global $timedate,$current_user;
+    function save($check_notify = FALSE) {
+        global $timedate,$current_user;
 
-	    if(isset($this->date_start) && isset($this->duration_hours) && isset($this->duration_minutes))
+        if(isset($this->date_start) && isset($this->duration_hours) && isset($this->duration_minutes))
         {
-    	    $td = $timedate->fromDb($this->date_start);
-    	    if($td)
-    	    {
-	        	$this->date_end = $td->modify("+{$this->duration_hours} hours {$this->duration_minutes} mins")->asDb();
-    	    }
+            $td = $timedate->fromDb($this->date_start);
+            if($td)
+            {
+                $this->date_end = $td->modify("+{$this->duration_hours} hours {$this->duration_minutes} mins")->asDb();
+            }
         }
 
-		if(!empty($_REQUEST['send_invites']) && $_REQUEST['send_invites'] == '1') {
-			$check_notify = true;
+        if(!empty($_REQUEST['send_invites']) && $_REQUEST['send_invites'] == '1') {
+            $check_notify = true;
         } else {
-			$check_notify = false;
-		}
-		if(empty($_REQUEST['send_invites'])) {
-			if(!empty($this->id)) {
-				$old_record = new Call();
-				$old_record->retrieve($this->id);
-				$old_assigned_user_id = $old_record->assigned_user_id;
-			}
-			if((empty($this->id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $GLOBALS['current_user']->id != $_REQUEST['assigned_user_id']) || (isset($old_assigned_user_id) && !empty($old_assigned_user_id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $old_assigned_user_id != $_REQUEST['assigned_user_id']) ){
-				$this->special_notification = true;
-				if(!isset($GLOBALS['resavingRelatedBeans']) || $GLOBALS['resavingRelatedBeans'] == false) {
-					$check_notify = true;
-				}
+            $check_notify = false;
+        }
+        if(empty($_REQUEST['send_invites'])) {
+            if(!empty($this->id)) {
+                $old_record = new Call();
+                $old_record->retrieve($this->id);
+                $old_assigned_user_id = $old_record->assigned_user_id;
+            }
+            if((empty($this->id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $GLOBALS['current_user']->id != $_REQUEST['assigned_user_id']) || (isset($old_assigned_user_id) && !empty($old_assigned_user_id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $old_assigned_user_id != $_REQUEST['assigned_user_id']) ){
+                $this->special_notification = true;
+                if(!isset($GLOBALS['resavingRelatedBeans']) || $GLOBALS['resavingRelatedBeans'] == false) {
+                    $check_notify = true;
+                }
                 if(isset($_REQUEST['assigned_user_name'])) {
                     $this->new_assigned_user_name = $_REQUEST['assigned_user_name'];
                 }
-			}
-		}
+            }
+        }
         if (empty($this->status) ) {
             $this->status = $this->getDefaultStatus();
         }
 
-		// prevent a mass mailing for recurring meetings created in Calendar module
-		if (empty($this->id) && !empty($_REQUEST['module']) && $_REQUEST['module'] == "Calendar" && !empty($_REQUEST['repeat_type']) && !empty($this->repeat_parent_id)) {
-			$check_notify = false;
-		}
-		/*nsingh 7/3/08  commenting out as bug #20814 is invalid
+        // prevent a mass mailing for recurring meetings created in Calendar module
+        if (empty($this->id) && !empty($_REQUEST['module']) && $_REQUEST['module'] == "Calendar" && !empty($_REQUEST['repeat_type']) && !empty($this->repeat_parent_id)) {
+            $check_notify = false;
+        }
+        /*nsingh 7/3/08  commenting out as bug #20814 is invalid
 		if($current_user->getPreference('reminder_time')!= -1 &&  isset($_POST['reminder_checked']) && isset($_POST['reminder_time']) && $_POST['reminder_checked']==0  && $_POST['reminder_time']==-1){
 			$this->reminder_checked = '1';
 			$this->reminder_time = $current_user->getPreference('reminder_time');
@@ -213,87 +213,87 @@ 
 
 
         if($this->update_vcal) {
-			vCal::cache_sugar_vcal($current_user);
+            vCal::cache_sugar_vcal($current_user);
         }
 
-		if(isset($_REQUEST['reminders_data'])) {
-			Reminder::saveRemindersDataJson('Calls', $return_id, html_entity_decode($_REQUEST['reminders_data']));
-		}
+        if(isset($_REQUEST['reminders_data'])) {
+            Reminder::saveRemindersDataJson('Calls', $return_id, html_entity_decode($_REQUEST['reminders_data']));
+        }
 
         return $return_id;
-	}
+    }
 
-	/** Returns a list of the associated contacts
-	 * Portions created by SugarCRM are Copyright (C) SugarCRM, Inc..
-	 * All Rights Reserved..
-	 * Contributor(s): ______________________________________..
-	*/
-	function get_contacts()
-	{
-		// First, get the list of IDs.
-		$query = "SELECT contact_id as id from calls_contacts where call_id='$this->id' AND deleted=0";
+    /** Returns a list of the associated contacts
+     * Portions created by SugarCRM are Copyright (C) SugarCRM, Inc..
+     * All Rights Reserved..
+     * Contributor(s): ______________________________________..
+     */
+    function get_contacts()
+    {
+        // First, get the list of IDs.
+        $query = "SELECT contact_id as id from calls_contacts where call_id='$this->id' AND deleted=0";
 
-		return $this->build_related_list($query, new Contact());
-	}
+        return $this->build_related_list($query, new Contact());
+    }
 
 
-	function get_summary_text()
-	{
-		return "$this->name";
-	}
+    function get_summary_text()
+    {
+        return "$this->name";
+    }
 
-	function create_list_query($order_by, $where, $show_deleted=0)
-	{
+    function create_list_query($order_by, $where, $show_deleted=0)
+    {
         $custom_join = $this->getCustomJoin();
                 $query = "SELECT ";
-		$query .= "
+        $query .= "
 			calls.*,";
-			if ( preg_match("/calls_users\.user_id/",$where))
-			{
-				$query .= "calls_users.required,
+            if ( preg_match("/calls_users\.user_id/",$where))
+            {
+                $query .= "calls_users.required,
 				calls_users.accept_status,";
-			}
+            }
 
-			$query .= "
+            $query .= "
 			users.user_name as assigned_user_name";
         $query .= $custom_join['select'];
 
-			// this line will help generate a GMT-metric to compare to a locale's timezone
+            // this line will help generate a GMT-metric to compare to a locale's timezone
 
-			if ( preg_match("/contacts/",$where)){
-				$query .= ", contacts.first_name, contacts.last_name";
-				$query .= ", contacts.assigned_user_id contact_name_owner";
-			}
-			$query .= " FROM calls ";
+            if ( preg_match("/contacts/",$where)){
+                $query .= ", contacts.first_name, contacts.last_name";
+                $query .= ", contacts.assigned_user_id contact_name_owner";
+            }
+            $query .= " FROM calls ";
 
-			if ( preg_match("/contacts/",$where)){
-				$query .=	"LEFT JOIN calls_contacts
+            if ( preg_match("/contacts/",$where)){
+                $query .=	"LEFT JOIN calls_contacts
 	                    ON calls.id=calls_contacts.call_id
 	                    LEFT JOIN contacts
 	                    ON calls_contacts.contact_id=contacts.id ";
-			}
-			if ( preg_match('/calls_users\.user_id/',$where))
-			{
-		$query .= "LEFT JOIN calls_users
+            }
+            if ( preg_match('/calls_users\.user_id/',$where))
+            {
+        $query .= "LEFT JOIN calls_users
 			ON calls.id=calls_users.call_id and calls_users.deleted=0 ";
-			}
-			$query .= "
+            }
+            $query .= "
 			LEFT JOIN users
 			ON calls.assigned_user_id=users.id ";
         $query .= $custom_join['join'];
-			$where_auto = '1=1';
-       		 if($show_deleted == 0){
-            	$where_auto = " $this->table_name.deleted=0  ";
-			}else if($show_deleted == 1){
-				$where_auto = " $this->table_name.deleted=1 ";
-			}
+            $where_auto = '1=1';
+                if($show_deleted == 0){
+                $where_auto = " $this->table_name.deleted=0  ";
+            }else if($show_deleted == 1){
+                $where_auto = " $this->table_name.deleted=1 ";
+            }
 
-			//$where_auto .= " GROUP BY calls.id";
+            //$where_auto .= " GROUP BY calls.id";
 
-		if($where != "")
-			$query .= "where $where AND ".$where_auto;
-		else
-			$query .= "where ".$where_auto;
+        if($where != "")
+            $query .= "where $where AND ".$where_auto;
+        else
+            $query .= "where ".$where_auto;
 
         $order_by = $this->process_order_by($order_by);
         if (empty($order_by)) {
@@ -301,14 +301,14 @@ 
         }
         $query .= ' ORDER BY ' . $order_by;
 
-		return $query;
-	}
+        return $query;
+    }
 
         function create_export_query($order_by, $where, $relate_link_join='')
         {
             $custom_join = $this->getCustomJoin(true, true, $where);
             $custom_join['join'] .= $relate_link_join;
-			$contact_required = stristr($where, "contacts");
+            $contact_required = stristr($where, "contacts");
             if($contact_required)
             {
                     $query = "SELECT calls.*, contacts.first_name, contacts.last_name, users.user_name as assigned_user_name ";
@@ -325,11 +325,11 @@ 
             }
 
 
-			$query .= "  LEFT JOIN users ON calls.assigned_user_id=users.id ";
+            $query .= "  LEFT JOIN users ON calls.assigned_user_id=users.id ";
 
             $query .= $custom_join['join'];
 
-			if($where != "")
+            if($where != "")
                     $query .= "where $where AND ".$where_auto;
             else
                     $query .= "where ".$where_auto;
@@ -347,199 +347,199 @@ 
 
 
 
-	function fill_in_additional_detail_fields()
-	{
-		global $locale;
-		parent::fill_in_additional_detail_fields();
-		if (!empty($this->contact_id)) {
-			$query  = "SELECT first_name, last_name FROM contacts ";
-			$query .= "WHERE id='$this->contact_id' AND deleted=0";
-			$result = $this->db->limitQuery($query,0,1,true," Error filling in additional detail fields: ");
-
-			// Get the contact name.
-			$row = $this->db->fetchByAssoc($result);
-			$GLOBALS['log']->info("additional call fields $query");
-			if($row != null)
-			{
-				$this->contact_name = $locale->getLocaleFormattedName($row['first_name'], $row['last_name'], '', '');
-				$GLOBALS['log']->debug("Call($this->id): contact_name = $this->contact_name");
-				$GLOBALS['log']->debug("Call($this->id): contact_id = $this->contact_id");
-			}
-		}
-		if (!isset($this->duration_minutes)) {
-			$this->duration_minutes = $this->minutes_value_default;
-		}
+    function fill_in_additional_detail_fields()
+    {
+        global $locale;
+        parent::fill_in_additional_detail_fields();
+        if (!empty($this->contact_id)) {
+            $query  = "SELECT first_name, last_name FROM contacts ";
+            $query .= "WHERE id='$this->contact_id' AND deleted=0";
+            $result = $this->db->limitQuery($query,0,1,true," Error filling in additional detail fields: ");
+
+            // Get the contact name.
+            $row = $this->db->fetchByAssoc($result);
+            $GLOBALS['log']->info("additional call fields $query");
+            if($row != null)
+            {
+                $this->contact_name = $locale->getLocaleFormattedName($row['first_name'], $row['last_name'], '', '');
+                $GLOBALS['log']->debug("Call($this->id): contact_name = $this->contact_name");
+                $GLOBALS['log']->debug("Call($this->id): contact_id = $this->contact_id");
+            }
+        }
+        if (!isset($this->duration_minutes)) {
+            $this->duration_minutes = $this->minutes_value_default;
+        }
 
         global $timedate;
         //setting default date and time
-		if (is_null($this->date_start)) {
-			$this->date_start = $timedate->now();
-		}
-
-		if (is_null($this->duration_hours))
-			$this->duration_hours = "0";
-		if (is_null($this->duration_minutes))
-			$this->duration_minutes = "1";
-
-		$this->fill_in_additional_parent_fields();
-
-		global $app_list_strings;
-		$parent_types = $app_list_strings['record_type_display'];
-		$disabled_parent_types = ACLController::disabledModuleList($parent_types,false, 'list');
-		foreach($disabled_parent_types as $disabled_parent_type){
-			if($disabled_parent_type != $this->parent_type){
-				unset($parent_types[$disabled_parent_type]);
-			}
-		}
-
-		$this->parent_type_options = get_select_options_with_id($parent_types, $this->parent_type);
-
-		if (empty($this->reminder_time)) {
-			$this->reminder_time = -1;
-		}
-
-		if ( empty($this->id) ) {
-		    $reminder_t = $GLOBALS['current_user']->getPreference('reminder_time');
-		    if ( isset($reminder_t) )
-		        $this->reminder_time = $reminder_t;
-		}
-		$this->reminder_checked = $this->reminder_time == -1 ? false : true;
-
-		if (empty($this->email_reminder_time)) {
-			$this->email_reminder_time = -1;
-		}
-		if(empty($this->id)){
-			$reminder_t = $GLOBALS['current_user']->getPreference('email_reminder_time');
-			if(isset($reminder_t))
-		    		$this->email_reminder_time = $reminder_t;
-		}
-		$this->email_reminder_checked = $this->email_reminder_time == -1 ? false : true;
-
-		if (isset ($_REQUEST['parent_type']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'SubpanelEdits')) {
-			$this->parent_type = $_REQUEST['parent_type'];
-		} elseif (is_null($this->parent_type)) {
-			$this->parent_type = $app_list_strings['record_type_default_key'];
-		}
-	}
-
-
-	function get_list_view_data(){
-		$call_fields = $this->get_list_view_array();
-		global $app_list_strings, $focus, $action, $currentModule;
-		if (isset($focus->id)) $id = $focus->id;
-		else $id = '';
-		if (isset($this->parent_type) && $this->parent_type != null)
-		{
-			$call_fields['PARENT_MODULE'] = $this->parent_type;
-		}
-		if ($this->status == "Planned") {
-			//cn: added this if() to deal with sequential Closes in Meetings.  this is a hack to a hack (formbase.php->handleRedirect)
-			if(empty($action))
-			    $action = "index";
+        if (is_null($this->date_start)) {
+            $this->date_start = $timedate->now();
+        }
+
+        if (is_null($this->duration_hours))
+            $this->duration_hours = "0";
+        if (is_null($this->duration_minutes))
+            $this->duration_minutes = "1";
+
+        $this->fill_in_additional_parent_fields();
+
+        global $app_list_strings;
+        $parent_types = $app_list_strings['record_type_display'];
+        $disabled_parent_types = ACLController::disabledModuleList($parent_types,false, 'list');
+        foreach($disabled_parent_types as $disabled_parent_type){
+            if($disabled_parent_type != $this->parent_type){
+                unset($parent_types[$disabled_parent_type]);
+            }
+        }
+
+        $this->parent_type_options = get_select_options_with_id($parent_types, $this->parent_type);
+
+        if (empty($this->reminder_time)) {
+            $this->reminder_time = -1;
+        }
+
+        if ( empty($this->id) ) {
+            $reminder_t = $GLOBALS['current_user']->getPreference('reminder_time');
+            if ( isset($reminder_t) )
+                $this->reminder_time = $reminder_t;
+        }
+        $this->reminder_checked = $this->reminder_time == -1 ? false : true;
+
+        if (empty($this->email_reminder_time)) {
+            $this->email_reminder_time = -1;
+        }
+        if(empty($this->id)){
+            $reminder_t = $GLOBALS['current_user']->getPreference('email_reminder_time');
+            if(isset($reminder_t))
+                    $this->email_reminder_time = $reminder_t;
+        }
+        $this->email_reminder_checked = $this->email_reminder_time == -1 ? false : true;
+
+        if (isset ($_REQUEST['parent_type']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'SubpanelEdits')) {
+            $this->parent_type = $_REQUEST['parent_type'];
+        } elseif (is_null($this->parent_type)) {
+            $this->parent_type = $app_list_strings['record_type_default_key'];
+        }
+    }
+
+
+    function get_list_view_data(){
+        $call_fields = $this->get_list_view_array();
+        global $app_list_strings, $focus, $action, $currentModule;
+        if (isset($focus->id)) $id = $focus->id;
+        else $id = '';
+        if (isset($this->parent_type) && $this->parent_type != null)
+        {
+            $call_fields['PARENT_MODULE'] = $this->parent_type;
+        }
+        if ($this->status == "Planned") {
+            //cn: added this if() to deal with sequential Closes in Meetings.  this is a hack to a hack (formbase.php->handleRedirect)
+            if(empty($action))
+                $action = "index";
 
             $setCompleteUrl = "<a id='{$this->id}' onclick='SUGAR.util.closeActivityPanel.show(\"{$this->module_dir}\",\"{$this->id}\",\"Held\",\"listview\",\"1\");'>";
-			if ($this->ACLAccess('edit')) {
+            if ($this->ACLAccess('edit')) {
                 $call_fields['SET_COMPLETE'] = $setCompleteUrl . SugarThemeRegistry::current()->getImage("close_inline"," border='0'",null,null,'.gif',translate('LBL_CLOSEINLINE'))."</a>";
             } else {
                 $call_fields['SET_COMPLETE'] = '';
             }
-		}
-		global $timedate;
-		$today = $timedate->nowDb();
-		$nextday = $timedate->asDbDate($timedate->getNow()->modify("+1 day"));
-		$mergeTime = $call_fields['DATE_START']; //$timedate->merge_date_time($call_fields['DATE_START'], $call_fields['TIME_START']);
-		$date_db = $timedate->to_db($mergeTime);
-		if( $date_db	< $today){
-			$call_fields['DATE_START']= "<font class='overdueTask'>".$call_fields['DATE_START']."</font>";
-		}else if($date_db < $nextday){
-			$call_fields['DATE_START'] = "<font class='todaysTask'>".$call_fields['DATE_START']."</font>";
-		}else{
-			$call_fields['DATE_START'] = "<font class='futureTask'>".$call_fields['DATE_START']."</font>";
-		}
-		$this->fill_in_additional_detail_fields();
-
-		//make sure we grab the localized version of the contact name, if a contact is provided
-		if (!empty($this->contact_id)) {
-           // Bug# 46125 - make first name, last name, salutation and title of Contacts respect field level ACLs
+        }
+        global $timedate;
+        $today = $timedate->nowDb();
+        $nextday = $timedate->asDbDate($timedate->getNow()->modify("+1 day"));
+        $mergeTime = $call_fields['DATE_START']; //$timedate->merge_date_time($call_fields['DATE_START'], $call_fields['TIME_START']);
+        $date_db = $timedate->to_db($mergeTime);
+        if( $date_db	< $today){
+            $call_fields['DATE_START']= "<font class='overdueTask'>".$call_fields['DATE_START']."</font>";
+        }else if($date_db < $nextday){
+            $call_fields['DATE_START'] = "<font class='todaysTask'>".$call_fields['DATE_START']."</font>";
+        }else{
+            $call_fields['DATE_START'] = "<font class='futureTask'>".$call_fields['DATE_START']."</font>";
+        }
+        $this->fill_in_additional_detail_fields();
+
+        //make sure we grab the localized version of the contact name, if a contact is provided
+        if (!empty($this->contact_id)) {
+            // Bug# 46125 - make first name, last name, salutation and title of Contacts respect field level ACLs
             $contact_temp = BeanFactory::getBean("Contacts", $this->contact_id);
             if(!empty($contact_temp)) {
                 $contact_temp->_create_proper_name_field();
                 $this->contact_name = $contact_temp->full_name;
             }
-		}
+        }
 
         $call_fields['CONTACT_ID'] = $this->contact_id;
         $call_fields['CONTACT_NAME'] = $this->contact_name;
-		$call_fields['PARENT_NAME'] = $this->parent_name;
+        $call_fields['PARENT_NAME'] = $this->parent_name;
         $call_fields['REMINDER_CHECKED'] = $this->reminder_time==-1 ? false : true;
-	    $call_fields['EMAIL_REMINDER_CHECKED'] = $this->email_reminder_time==-1 ? false : true;
+        $call_fields['EMAIL_REMINDER_CHECKED'] = $this->email_reminder_time==-1 ? false : true;
 
-		return $call_fields;
-	}
+        return $call_fields;
+    }
 
-	function set_notification_body($xtpl, $call) {
-		global $sugar_config;
-		global $app_list_strings;
-		global $current_user;
-		global $app_list_strings;
-		global $timedate;
+    function set_notification_body($xtpl, $call) {
+        global $sugar_config;
+        global $app_list_strings;
+        global $current_user;
+        global $app_list_strings;
+        global $timedate;
 
         // rrs: bug 42684 - passing a contact breaks this call
-		$notifyUser =($call->current_notify_user->object_name == 'User') ? $call->current_notify_user : $current_user;
-
-
-		// Assumes $call dates are in user format
-		$calldate = $timedate->fromDb($call->date_start);
-		$xOffset = $timedate->asUser($calldate, $notifyUser).' '.$timedate->userTimezoneSuffix($calldate, $notifyUser);
-
-		if ( strtolower(get_class($call->current_notify_user)) == 'contact' ) {
-			$xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
-				  '/index.php?entryPoint=acceptDecline&module=Calls&contact_id='.$call->current_notify_user->id.'&record='.$call->id);
-		} elseif ( strtolower(get_class($call->current_notify_user)) == 'lead' ) {
-			$xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
-				  '/index.php?entryPoint=acceptDecline&module=Calls&lead_id='.$call->current_notify_user->id.'&record='.$call->id);
-		} else {
-			$xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
-				  '/index.php?entryPoint=acceptDecline&module=Calls&user_id='.$call->current_notify_user->id.'&record='.$call->id);
-		}
-
-		$xtpl->assign("CALL_TO", $call->current_notify_user->new_assigned_user_name);
-		$xtpl->assign("CALL_SUBJECT", $call->name);
-		$xtpl->assign("CALL_STARTDATE", $xOffset);
-		$xtpl->assign("CALL_HOURS", $call->duration_hours);
-		$xtpl->assign("CALL_MINUTES", $call->duration_minutes);
-		$xtpl->assign("CALL_STATUS", ((isset($call->status))?$app_list_strings['call_status_dom'][$call->status] : ""));
-		$xtpl->assign("CALL_DESCRIPTION", $call->description);
-
-		return $xtpl;
-	}
-
-
-	function get_call_users() {
-		$template = new User();
-		// First, get the list of IDs.
-		$query = "SELECT calls_users.required, calls_users.accept_status, calls_users.user_id from calls_users where calls_users.call_id='$this->id' AND calls_users.deleted=0";
-		$GLOBALS['log']->debug("Finding linked records $this->object_name: ".$query);
-		$result = $this->db->query($query, true);
-		$list = Array();
-
-		while($row = $this->db->fetchByAssoc($result)) {
-			$template = new User(); // PHP 5 will retrieve by reference, always over-writing the "old" one
-			$record = $template->retrieve($row['user_id']);
-			$template->required = $row['required'];
-			$template->accept_status = $row['accept_status'];
-
-			if($record != null) {
-			    // this copies the object into the array
-				$list[] = $template;
-			}
-		}
-		return $list;
-	}
-
-
-  function get_invite_calls(&$user)
-  {
+        $notifyUser =($call->current_notify_user->object_name == 'User') ? $call->current_notify_user : $current_user;
+
+
+        // Assumes $call dates are in user format
+        $calldate = $timedate->fromDb($call->date_start);
+        $xOffset = $timedate->asUser($calldate, $notifyUser).' '.$timedate->userTimezoneSuffix($calldate, $notifyUser);
+
+        if ( strtolower(get_class($call->current_notify_user)) == 'contact' ) {
+            $xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
+                    '/index.php?entryPoint=acceptDecline&module=Calls&contact_id='.$call->current_notify_user->id.'&record='.$call->id);
+        } elseif ( strtolower(get_class($call->current_notify_user)) == 'lead' ) {
+            $xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
+                    '/index.php?entryPoint=acceptDecline&module=Calls&lead_id='.$call->current_notify_user->id.'&record='.$call->id);
+        } else {
+            $xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
+                    '/index.php?entryPoint=acceptDecline&module=Calls&user_id='.$call->current_notify_user->id.'&record='.$call->id);
+        }
+
+        $xtpl->assign("CALL_TO", $call->current_notify_user->new_assigned_user_name);
+        $xtpl->assign("CALL_SUBJECT", $call->name);
+        $xtpl->assign("CALL_STARTDATE", $xOffset);
+        $xtpl->assign("CALL_HOURS", $call->duration_hours);
+        $xtpl->assign("CALL_MINUTES", $call->duration_minutes);
+        $xtpl->assign("CALL_STATUS", ((isset($call->status))?$app_list_strings['call_status_dom'][$call->status] : ""));
+        $xtpl->assign("CALL_DESCRIPTION", $call->description);
+
+        return $xtpl;
+    }
+
+
+    function get_call_users() {
+        $template = new User();
+        // First, get the list of IDs.
+        $query = "SELECT calls_users.required, calls_users.accept_status, calls_users.user_id from calls_users where calls_users.call_id='$this->id' AND calls_users.deleted=0";
+        $GLOBALS['log']->debug("Finding linked records $this->object_name: ".$query);
+        $result = $this->db->query($query, true);
+        $list = Array();
+
+        while($row = $this->db->fetchByAssoc($result)) {
+            $template = new User(); // PHP 5 will retrieve by reference, always over-writing the "old" one
+            $record = $template->retrieve($row['user_id']);
+            $template->required = $row['required'];
+            $template->accept_status = $row['accept_status'];
+
+            if($record != null) {
+                // this copies the object into the array
+                $list[] = $template;
+            }
+        }
+        return $list;
+    }
+
+
+    function get_invite_calls(&$user)
+    {
     $template = $this;
     // First, get the list of IDs.
     $query = "SELECT calls_users.required, calls_users.accept_status, calls_users.call_id from calls_users where calls_users.user_id='$user->id' AND ( calls_users.accept_status IS NULL OR  calls_users.accept_status='none') AND calls_users.deleted=0";
@@ -554,182 +554,182 @@ 
 
     while($row = $this->db->fetchByAssoc($result))
     {
-      $record = $template->retrieve($row['call_id']);
-      $template->required = $row['required'];
-      $template->accept_status = $row['accept_status'];
+        $record = $template->retrieve($row['call_id']);
+        $template->required = $row['required'];
+        $template->accept_status = $row['accept_status'];
 
 
-      if($record != null)
-      {
+        if($record != null)
+        {
         // this copies the object into the array
         $list[] = $template;
-      }
+        }
     }
     return $list;
 
-  }
+    }
 
 
-  function set_accept_status(&$user,$status)
-  {
+    function set_accept_status(&$user,$status)
+    {
     if ( $user->object_name == 'User')
     {
-      $relate_values = array('user_id'=>$user->id,'call_id'=>$this->id);
-      $data_values = array('accept_status'=>$status);
-      $this->set_relationship($this->rel_users_table, $relate_values, true, true,$data_values);
-      global $current_user;
+        $relate_values = array('user_id'=>$user->id,'call_id'=>$this->id);
+        $data_values = array('accept_status'=>$status);
+        $this->set_relationship($this->rel_users_table, $relate_values, true, true,$data_values);
+        global $current_user;
 
-      if ( $this->update_vcal )
-      {
+        if ( $this->update_vcal )
+        {
         vCal::cache_sugar_vcal($user);
-      }
+        }
     }
     else if ( $user->object_name == 'Contact')
     {
-      $relate_values = array('contact_id'=>$user->id,'call_id'=>$this->id);
-      $data_values = array('accept_status'=>$status);
-      $this->set_relationship($this->rel_contacts_table, $relate_values, true, true,$data_values);
+        $relate_values = array('contact_id'=>$user->id,'call_id'=>$this->id);
+        $data_values = array('accept_status'=>$status);
+        $this->set_relationship($this->rel_contacts_table, $relate_values, true, true,$data_values);
     }
     else if ( $user->object_name == 'Lead')
     {
-      $relate_values = array('lead_id'=>$user->id,'call_id'=>$this->id);
-      $data_values = array('accept_status'=>$status);
-      $this->set_relationship($this->rel_leads_table, $relate_values, true, true,$data_values);
+        $relate_values = array('lead_id'=>$user->id,'call_id'=>$this->id);
+        $data_values = array('accept_status'=>$status);
+        $this->set_relationship($this->rel_leads_table, $relate_values, true, true,$data_values);
+    }
     }
-  }
 
 
 
-	function get_notification_recipients() {
-		if($this->special_notification) {
-			return parent::get_notification_recipients();
-		}
+    function get_notification_recipients() {
+        if($this->special_notification) {
+            return parent::get_notification_recipients();
+        }
 
 //		$GLOBALS['log']->debug('Call.php->get_notification_recipients():'.print_r($this,true));
-		$list = array();
+        $list = array();
         if(!is_array($this->contacts_arr)) {
-			$this->contacts_arr =	array();
-		}
+            $this->contacts_arr =	array();
+        }
 
-		if(!is_array($this->users_arr)) {
-			$this->users_arr =	array();
-		}
+        if(!is_array($this->users_arr)) {
+            $this->users_arr =	array();
+        }
 
         if(!is_array($this->leads_arr)) {
-			$this->leads_arr =	array();
-		}
-
-		foreach($this->users_arr as $user_id) {
-			$notify_user = new User();
-			$notify_user->retrieve($user_id);
-			$notify_user->new_assigned_user_name = $notify_user->full_name;
-			$GLOBALS['log']->info("Notifications: recipient is $notify_user->new_assigned_user_name");
-			$list[$notify_user->id] = $notify_user;
-		}
-
-		foreach($this->contacts_arr as $contact_id) {
-			$notify_user = new Contact();
-			$notify_user->retrieve($contact_id);
-			$notify_user->new_assigned_user_name = $notify_user->full_name;
-			$GLOBALS['log']->info("Notifications: recipient is $notify_user->new_assigned_user_name");
-			$list[$notify_user->id] = $notify_user;
-		}
+            $this->leads_arr =	array();
+        }
+
+        foreach($this->users_arr as $user_id) {
+            $notify_user = new User();
+            $notify_user->retrieve($user_id);
+            $notify_user->new_assigned_user_name = $notify_user->full_name;
+            $GLOBALS['log']->info("Notifications: recipient is $notify_user->new_assigned_user_name");
+            $list[$notify_user->id] = $notify_user;
+        }
+
+        foreach($this->contacts_arr as $contact_id) {
+            $notify_user = new Contact();
+            $notify_user->retrieve($contact_id);
+            $notify_user->new_assigned_user_name = $notify_user->full_name;
+            $GLOBALS['log']->info("Notifications: recipient is $notify_user->new_assigned_user_name");
+            $list[$notify_user->id] = $notify_user;
+        }
 
         foreach($this->leads_arr as $lead_id) {
-			$notify_user = new Lead();
-			$notify_user->retrieve($lead_id);
-			$notify_user->new_assigned_user_name = $notify_user->full_name;
-			$GLOBALS['log']->info("Notifications: recipient is $notify_user->new_assigned_user_name");
-			$list[$notify_user->id] = $notify_user;
-		}
-		global $sugar_config;
-		if(isset($sugar_config['disable_notify_current_user']) && $sugar_config['disable_notify_current_user']) {
-			global $current_user;
-			if(isset($list[$current_user->id]))
-				unset($list[$current_user->id]);
-		}
+            $notify_user = new Lead();
+            $notify_user->retrieve($lead_id);
+            $notify_user->new_assigned_user_name = $notify_user->full_name;
+            $GLOBALS['log']->info("Notifications: recipient is $notify_user->new_assigned_user_name");
+            $list[$notify_user->id] = $notify_user;
+        }
+        global $sugar_config;
+        if(isset($sugar_config['disable_notify_current_user']) && $sugar_config['disable_notify_current_user']) {
+            global $current_user;
+            if(isset($list[$current_user->id]))
+                unset($list[$current_user->id]);
+        }
 //		$GLOBALS['log']->debug('Call.php->get_notification_recipients():'.print_r($list,true));
-		return $list;
-	}
+        return $list;
+    }
 
     function bean_implements($interface){
-		switch($interface){
-			case 'ACL':return true;
-		}
-		return false;
-	}
-
-	function listviewACLHelper(){
-		$array_assign = parent::listviewACLHelper();
-		$is_owner = false;
-		$in_group = false; //SECURITY GROUPS
-		if(!empty($this->parent_name)){
-
-			if(!empty($this->parent_name_owner)){
-				global $current_user;
-				$is_owner = $current_user->id == $this->parent_name_owner;
-			}
-			/* BEGIN - SECURITY GROUPS */
-			//parent_name_owner not being set for whatever reason so we need to figure this out
-			else if(!empty($this->parent_type) && !empty($this->parent_id)) {
-				global $current_user;
+        switch($interface){
+            case 'ACL':return true;
+        }
+        return false;
+    }
+
+    function listviewACLHelper(){
+        $array_assign = parent::listviewACLHelper();
+        $is_owner = false;
+        $in_group = false; //SECURITY GROUPS
+        if(!empty($this->parent_name)){
+
+            if(!empty($this->parent_name_owner)){
+                global $current_user;
+                $is_owner = $current_user->id == $this->parent_name_owner;
+            }
+            /* BEGIN - SECURITY GROUPS */
+            //parent_name_owner not being set for whatever reason so we need to figure this out
+            else if(!empty($this->parent_type) && !empty($this->parent_id)) {
+                global $current_user;
                 $parent_bean = BeanFactory::getBean($this->parent_type,$this->parent_id);
                 if($parent_bean !== false) {
-                	$is_owner = $current_user->id == $parent_bean->assigned_user_id;
+                    $is_owner = $current_user->id == $parent_bean->assigned_user_id;
                 }
-			}
-			require_once("modules/SecurityGroups/SecurityGroup.php");
-			$in_group = SecurityGroup::groupHasAccess($this->parent_type, $this->parent_id, 'view'); 
-        	/* END - SECURITY GROUPS */
-		}
-
-			/* BEGIN - SECURITY GROUPS */
-			/**
+            }
+            require_once("modules/SecurityGroups/SecurityGroup.php");
+            $in_group = SecurityGroup::groupHasAccess($this->parent_type, $this->parent_id, 'view'); 
+            /* END - SECURITY GROUPS */
+        }
+
+            /* BEGIN - SECURITY GROUPS */
+            /**
 			if(!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner)){
-			*/
-			if(!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner, 'module', $in_group)){
-        	/* END - SECURITY GROUPS */
-				$array_assign['PARENT'] = 'a';
-			}else{
-				$array_assign['PARENT'] = 'span';
-			}
-		$is_owner = false;
-		$in_group = false; //SECURITY GROUPS
-		if(!empty($this->contact_name)){
-
-			if(!empty($this->contact_name_owner)){
-				global $current_user;
-				$is_owner = $current_user->id == $this->contact_name_owner;
-			}
-			/* BEGIN - SECURITY GROUPS */
-			//contact_name_owner not being set for whatever reason so we need to figure this out
-			else {
-				global $current_user;
+             */
+            if(!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner, 'module', $in_group)){
+            /* END - SECURITY GROUPS */
+                $array_assign['PARENT'] = 'a';
+            }else{
+                $array_assign['PARENT'] = 'span';
+            }
+        $is_owner = false;
+        $in_group = false; //SECURITY GROUPS
+        if(!empty($this->contact_name)){
+
+            if(!empty($this->contact_name_owner)){
+                global $current_user;
+                $is_owner = $current_user->id == $this->contact_name_owner;
+            }
+            /* BEGIN - SECURITY GROUPS */
+            //contact_name_owner not being set for whatever reason so we need to figure this out
+            else {
+                global $current_user;
                 $parent_bean = BeanFactory::getBean('Contacts',$this->contact_id);
                 if($parent_bean !== false) {
-                	$is_owner = $current_user->id == $parent_bean->assigned_user_id;
+                    $is_owner = $current_user->id == $parent_bean->assigned_user_id;
                 }
-			}
-			require_once("modules/SecurityGroups/SecurityGroup.php");
-			$in_group = SecurityGroup::groupHasAccess('Contacts', $this->contact_id, 'view'); 
-        	/* END - SECURITY GROUPS */
-		}
-			/* BEGIN - SECURITY GROUPS */
-			/**
+            }
+            require_once("modules/SecurityGroups/SecurityGroup.php");
+            $in_group = SecurityGroup::groupHasAccess('Contacts', $this->contact_id, 'view'); 
+            /* END - SECURITY GROUPS */
+        }
+            /* BEGIN - SECURITY GROUPS */
+            /**
 			if( ACLController::checkAccess('Contacts', 'view', $is_owner)){
-			*/
-			if( ACLController::checkAccess('Contacts', 'view', $is_owner, 'module', $in_group)){
-        	/* END - SECURITY GROUPS */
-				$array_assign['CONTACT'] = 'a';
-			}else{
-				$array_assign['CONTACT'] = 'span';
-			}
-
-		return $array_assign;
-	}
-
-	function save_relationship_changes($is_update, $exclude = array()) {
-		if(empty($this->in_workflow))
+             */
+            if( ACLController::checkAccess('Contacts', 'view', $is_owner, 'module', $in_group)){
+            /* END - SECURITY GROUPS */
+                $array_assign['CONTACT'] = 'a';
+            }else{
+                $array_assign['CONTACT'] = 'span';
+            }
+
+        return $array_assign;
+    }
+
+    function save_relationship_changes($is_update, $exclude = array()) {
+        if(empty($this->in_workflow))
         {
             if(empty($this->in_import))
             {
@@ -737,12 +737,12 @@ 
                 //add assigned_user_id to exclude list and let the logic from MeetingFormBase determine whether assigned user id gets added to the relationship
                 if(!empty($GLOBALS['soap_server_object']))
                 {
-           		    $exclude = array('lead_id', 'contact_id', 'user_id');
-           	    }
+                        $exclude = array('lead_id', 'contact_id', 'user_id');
+                    }
                 else
                 {
-	                $exclude = array('lead_id', 'contact_id', 'user_id', 'assigned_user_id');
-           	    }
+                    $exclude = array('lead_id', 'contact_id', 'user_id', 'assigned_user_id');
+                    }
             }
             else
             {
@@ -751,15 +751,15 @@ 
 
 
         }
-		parent::save_relationship_changes($is_update, $exclude);
-	}
+        parent::save_relationship_changes($is_update, $exclude);
+    }
 
     public function getDefaultStatus()
     {
-         $def = $this->field_defs['status'];
-         if (isset($def['default'])) {
-             return $def['default'];
-         } else {
+            $def = $this->field_defs['status'];
+            if (isset($def['default'])) {
+                return $def['default'];
+            } else {
             $app = return_app_list_strings_language($GLOBALS['current_language']);
             if (isset($def['options']) && isset($app[$def['options']])) {
                 $keys = array_keys($app[$def['options']]);

Spacing +104 added lines, -104 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -97,7 +97,7 @@ 
 	var $leads_arr;
 	var $default_call_name_values = array('Assemble catalogs', 'Make travel arrangements', 'Send a letter', 'Send contract', 'Send fax', 'Send a follow-up letter', 'Send literature', 'Send proposal', 'Send quote');
 	var $minutes_value_default = 15;
-	var $minutes_values = array('0'=>'00','15'=>'15','30'=>'30','45'=>'45');
+	var $minutes_values = array('0'=>'00', '15'=>'15', '30'=>'30', '45'=>'45');
 	var $table_name = "calls";
 	var $rel_users_table = "calls_users";
 	var $rel_contacts_table = "calls_contacts";
@@ -111,7 +111,7 @@ 
 
 	// This is used to retrieve related fields from form posts.
 	var $additional_column_fields = array('assigned_user_name', 'assigned_user_id', 'contact_id', 'user_id', 'contact_name');
-	var $relationship_fields = array(	'account_id'		=> 'accounts',
+	var $relationship_fields = array('account_id'		=> 'accounts',
 										'opportunity_id'	=> 'opportunities',
 										'contact_id'		=> 'contacts',
 										'case_id'			=> 'cases',
@@ -134,7 +134,7 @@ 
 
 
 
-         if(!empty($GLOBALS['app_list_strings']['duration_intervals']))
+         if (!empty($GLOBALS['app_list_strings']['duration_intervals']))
         	$this->minutes_values = $GLOBALS['app_list_strings']['duration_intervals'];
 	}
 
@@ -143,58 +143,58 @@ 
 	 * @param $view string
 	 * @param $is_owner bool
 	 */
-	function ACLAccess($view,$is_owner='not_set',$in_group='not_set'){
+	function ACLAccess($view, $is_owner = 'not_set', $in_group = 'not_set') {
 		// don't check if call is being synced from Outlook
-		if($this->syncing == false){
+		if ($this->syncing == false) {
 			$view = strtolower($view);
-			switch($view){
+			switch ($view) {
 				case 'edit':
 				case 'save':
 				case 'editview':
 				case 'delete':
-					if(!empty($this->recurring_source) && $this->recurring_source != "Sugar"){
+					if (!empty($this->recurring_source) && $this->recurring_source != "Sugar") {
 						return false;
 					}
 			}
 		}
-		return parent::ACLAccess($view,$is_owner,$in_group);
+		return parent::ACLAccess($view, $is_owner, $in_group);
 	}
     // save date_end by calculating user input
     // this is for calendar
 	function save($check_notify = FALSE) {
-		global $timedate,$current_user;
+		global $timedate, $current_user;
 
-	    if(isset($this->date_start) && isset($this->duration_hours) && isset($this->duration_minutes))
+	    if (isset($this->date_start) && isset($this->duration_hours) && isset($this->duration_minutes))
         {
     	    $td = $timedate->fromDb($this->date_start);
-    	    if($td)
+    	    if ($td)
     	    {
 	        	$this->date_end = $td->modify("+{$this->duration_hours} hours {$this->duration_minutes} mins")->asDb();
     	    }
         }
 
-		if(!empty($_REQUEST['send_invites']) && $_REQUEST['send_invites'] == '1') {
+		if (!empty($_REQUEST['send_invites']) && $_REQUEST['send_invites'] == '1') {
 			$check_notify = true;
         } else {
 			$check_notify = false;
 		}
-		if(empty($_REQUEST['send_invites'])) {
-			if(!empty($this->id)) {
+		if (empty($_REQUEST['send_invites'])) {
+			if (!empty($this->id)) {
 				$old_record = new Call();
 				$old_record->retrieve($this->id);
 				$old_assigned_user_id = $old_record->assigned_user_id;
 			}
-			if((empty($this->id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $GLOBALS['current_user']->id != $_REQUEST['assigned_user_id']) || (isset($old_assigned_user_id) && !empty($old_assigned_user_id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $old_assigned_user_id != $_REQUEST['assigned_user_id']) ){
+			if ((empty($this->id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $GLOBALS['current_user']->id != $_REQUEST['assigned_user_id']) || (isset($old_assigned_user_id) && !empty($old_assigned_user_id) && isset($_REQUEST['assigned_user_id']) && !empty($_REQUEST['assigned_user_id']) && $old_assigned_user_id != $_REQUEST['assigned_user_id'])) {
 				$this->special_notification = true;
-				if(!isset($GLOBALS['resavingRelatedBeans']) || $GLOBALS['resavingRelatedBeans'] == false) {
+				if (!isset($GLOBALS['resavingRelatedBeans']) || $GLOBALS['resavingRelatedBeans'] == false) {
 					$check_notify = true;
 				}
-                if(isset($_REQUEST['assigned_user_name'])) {
+                if (isset($_REQUEST['assigned_user_name'])) {
                     $this->new_assigned_user_name = $_REQUEST['assigned_user_name'];
                 }
 			}
 		}
-        if (empty($this->status) ) {
+        if (empty($this->status)) {
             $this->status = $this->getDefaultStatus();
         }
 
@@ -212,11 +212,11 @@ 
         global $current_user;
 
 
-        if($this->update_vcal) {
+        if ($this->update_vcal) {
 			vCal::cache_sugar_vcal($current_user);
         }
 
-		if(isset($_REQUEST['reminders_data'])) {
+		if (isset($_REQUEST['reminders_data'])) {
 			Reminder::saveRemindersDataJson('Calls', $return_id, html_entity_decode($_REQUEST['reminders_data']));
 		}
 
@@ -242,13 +242,13 @@ 
 		return "$this->name";
 	}
 
-	function create_list_query($order_by, $where, $show_deleted=0)
+	function create_list_query($order_by, $where, $show_deleted = 0)
 	{
         $custom_join = $this->getCustomJoin();
                 $query = "SELECT ";
 		$query .= "
 			calls.*,";
-			if ( preg_match("/calls_users\.user_id/",$where))
+			if (preg_match("/calls_users\.user_id/", $where))
 			{
 				$query .= "calls_users.required,
 				calls_users.accept_status,";
@@ -260,19 +260,19 @@ 
 
 			// this line will help generate a GMT-metric to compare to a locale's timezone
 
-			if ( preg_match("/contacts/",$where)){
+			if (preg_match("/contacts/", $where)) {
 				$query .= ", contacts.first_name, contacts.last_name";
 				$query .= ", contacts.assigned_user_id contact_name_owner";
 			}
 			$query .= " FROM calls ";
 
-			if ( preg_match("/contacts/",$where)){
-				$query .=	"LEFT JOIN calls_contacts
+			if (preg_match("/contacts/", $where)) {
+				$query .= "LEFT JOIN calls_contacts
 	                    ON calls.id=calls_contacts.call_id
 	                    LEFT JOIN contacts
 	                    ON calls_contacts.contact_id=contacts.id ";
 			}
-			if ( preg_match('/calls_users\.user_id/',$where))
+			if (preg_match('/calls_users\.user_id/', $where))
 			{
 		$query .= "LEFT JOIN calls_users
 			ON calls.id=calls_users.call_id and calls_users.deleted=0 ";
@@ -282,15 +282,15 @@ 
 			ON calls.assigned_user_id=users.id ";
         $query .= $custom_join['join'];
 			$where_auto = '1=1';
-       		 if($show_deleted == 0){
+       		 if ($show_deleted == 0) {
             	$where_auto = " $this->table_name.deleted=0  ";
-			}else if($show_deleted == 1){
+			} else if ($show_deleted == 1) {
 				$where_auto = " $this->table_name.deleted=1 ";
 			}
 
 			//$where_auto .= " GROUP BY calls.id";
 
-		if($where != "")
+		if ($where != "")
 			$query .= "where $where AND ".$where_auto;
 		else
 			$query .= "where ".$where_auto;
@@ -299,17 +299,17 @@ 
         if (empty($order_by)) {
             $order_by = 'calls.name';
         }
-        $query .= ' ORDER BY ' . $order_by;
+        $query .= ' ORDER BY '.$order_by;
 
 		return $query;
 	}
 
-        function create_export_query($order_by, $where, $relate_link_join='')
+        function create_export_query($order_by, $where, $relate_link_join = '')
         {
             $custom_join = $this->getCustomJoin(true, true, $where);
             $custom_join['join'] .= $relate_link_join;
 			$contact_required = stristr($where, "contacts");
-            if($contact_required)
+            if ($contact_required)
             {
                     $query = "SELECT calls.*, contacts.first_name, contacts.last_name, users.user_name as assigned_user_name ";
                     $query .= $custom_join['select'];
@@ -329,7 +329,7 @@ 
 
             $query .= $custom_join['join'];
 
-			if($where != "")
+			if ($where != "")
                     $query .= "where $where AND ".$where_auto;
             else
                     $query .= "where ".$where_auto;
@@ -338,7 +338,7 @@ 
         if (empty($order_by)) {
             $order_by = 'calls.name';
         }
-        $query .= ' ORDER BY ' . $order_by;
+        $query .= ' ORDER BY '.$order_by;
 
             return $query;
         }
@@ -354,12 +354,12 @@ 
 		if (!empty($this->contact_id)) {
 			$query  = "SELECT first_name, last_name FROM contacts ";
 			$query .= "WHERE id='$this->contact_id' AND deleted=0";
-			$result = $this->db->limitQuery($query,0,1,true," Error filling in additional detail fields: ");
+			$result = $this->db->limitQuery($query, 0, 1, true, " Error filling in additional detail fields: ");
 
 			// Get the contact name.
 			$row = $this->db->fetchByAssoc($result);
 			$GLOBALS['log']->info("additional call fields $query");
-			if($row != null)
+			if ($row != null)
 			{
 				$this->contact_name = $locale->getLocaleFormattedName($row['first_name'], $row['last_name'], '', '');
 				$GLOBALS['log']->debug("Call($this->id): contact_name = $this->contact_name");
@@ -385,9 +385,9 @@ 
 
 		global $app_list_strings;
 		$parent_types = $app_list_strings['record_type_display'];
-		$disabled_parent_types = ACLController::disabledModuleList($parent_types,false, 'list');
-		foreach($disabled_parent_types as $disabled_parent_type){
-			if($disabled_parent_type != $this->parent_type){
+		$disabled_parent_types = ACLController::disabledModuleList($parent_types, false, 'list');
+		foreach ($disabled_parent_types as $disabled_parent_type) {
+			if ($disabled_parent_type != $this->parent_type) {
 				unset($parent_types[$disabled_parent_type]);
 			}
 		}
@@ -398,9 +398,9 @@ 
 			$this->reminder_time = -1;
 		}
 
-		if ( empty($this->id) ) {
+		if (empty($this->id)) {
 		    $reminder_t = $GLOBALS['current_user']->getPreference('reminder_time');
-		    if ( isset($reminder_t) )
+		    if (isset($reminder_t))
 		        $this->reminder_time = $reminder_t;
 		}
 		$this->reminder_checked = $this->reminder_time == -1 ? false : true;
@@ -408,9 +408,9 @@ 
 		if (empty($this->email_reminder_time)) {
 			$this->email_reminder_time = -1;
 		}
-		if(empty($this->id)){
+		if (empty($this->id)) {
 			$reminder_t = $GLOBALS['current_user']->getPreference('email_reminder_time');
-			if(isset($reminder_t))
+			if (isset($reminder_t))
 		    		$this->email_reminder_time = $reminder_t;
 		}
 		$this->email_reminder_checked = $this->email_reminder_time == -1 ? false : true;
@@ -423,7 +423,7 @@ 
 	}
 
 
-	function get_list_view_data(){
+	function get_list_view_data() {
 		$call_fields = $this->get_list_view_array();
 		global $app_list_strings, $focus, $action, $currentModule;
 		if (isset($focus->id)) $id = $focus->id;
@@ -434,12 +434,12 @@ 
 		}
 		if ($this->status == "Planned") {
 			//cn: added this if() to deal with sequential Closes in Meetings.  this is a hack to a hack (formbase.php->handleRedirect)
-			if(empty($action))
+			if (empty($action))
 			    $action = "index";
 
             $setCompleteUrl = "<a id='{$this->id}' onclick='SUGAR.util.closeActivityPanel.show(\"{$this->module_dir}\",\"{$this->id}\",\"Held\",\"listview\",\"1\");'>";
 			if ($this->ACLAccess('edit')) {
-                $call_fields['SET_COMPLETE'] = $setCompleteUrl . SugarThemeRegistry::current()->getImage("close_inline"," border='0'",null,null,'.gif',translate('LBL_CLOSEINLINE'))."</a>";
+                $call_fields['SET_COMPLETE'] = $setCompleteUrl.SugarThemeRegistry::current()->getImage("close_inline", " border='0'", null, null, '.gif', translate('LBL_CLOSEINLINE'))."</a>";
             } else {
                 $call_fields['SET_COMPLETE'] = '';
             }
@@ -449,11 +449,11 @@ 
 		$nextday = $timedate->asDbDate($timedate->getNow()->modify("+1 day"));
 		$mergeTime = $call_fields['DATE_START']; //$timedate->merge_date_time($call_fields['DATE_START'], $call_fields['TIME_START']);
 		$date_db = $timedate->to_db($mergeTime);
-		if( $date_db	< $today){
-			$call_fields['DATE_START']= "<font class='overdueTask'>".$call_fields['DATE_START']."</font>";
-		}else if($date_db < $nextday){
+		if ($date_db < $today) {
+			$call_fields['DATE_START'] = "<font class='overdueTask'>".$call_fields['DATE_START']."</font>";
+		} else if ($date_db < $nextday) {
 			$call_fields['DATE_START'] = "<font class='todaysTask'>".$call_fields['DATE_START']."</font>";
-		}else{
+		} else {
 			$call_fields['DATE_START'] = "<font class='futureTask'>".$call_fields['DATE_START']."</font>";
 		}
 		$this->fill_in_additional_detail_fields();
@@ -462,7 +462,7 @@ 
 		if (!empty($this->contact_id)) {
            // Bug# 46125 - make first name, last name, salutation and title of Contacts respect field level ACLs
             $contact_temp = BeanFactory::getBean("Contacts", $this->contact_id);
-            if(!empty($contact_temp)) {
+            if (!empty($contact_temp)) {
                 $contact_temp->_create_proper_name_field();
                 $this->contact_name = $contact_temp->full_name;
             }
@@ -471,8 +471,8 @@ 
         $call_fields['CONTACT_ID'] = $this->contact_id;
         $call_fields['CONTACT_NAME'] = $this->contact_name;
 		$call_fields['PARENT_NAME'] = $this->parent_name;
-        $call_fields['REMINDER_CHECKED'] = $this->reminder_time==-1 ? false : true;
-	    $call_fields['EMAIL_REMINDER_CHECKED'] = $this->email_reminder_time==-1 ? false : true;
+        $call_fields['REMINDER_CHECKED'] = $this->reminder_time == -1 ? false : true;
+	    $call_fields['EMAIL_REMINDER_CHECKED'] = $this->email_reminder_time == -1 ? false : true;
 
 		return $call_fields;
 	}
@@ -485,17 +485,17 @@ 
 		global $timedate;
 
         // rrs: bug 42684 - passing a contact breaks this call
-		$notifyUser =($call->current_notify_user->object_name == 'User') ? $call->current_notify_user : $current_user;
+		$notifyUser = ($call->current_notify_user->object_name == 'User') ? $call->current_notify_user : $current_user;
 
 
 		// Assumes $call dates are in user format
 		$calldate = $timedate->fromDb($call->date_start);
 		$xOffset = $timedate->asUser($calldate, $notifyUser).' '.$timedate->userTimezoneSuffix($calldate, $notifyUser);
 
-		if ( strtolower(get_class($call->current_notify_user)) == 'contact' ) {
+		if (strtolower(get_class($call->current_notify_user)) == 'contact') {
 			$xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
 				  '/index.php?entryPoint=acceptDecline&module=Calls&contact_id='.$call->current_notify_user->id.'&record='.$call->id);
-		} elseif ( strtolower(get_class($call->current_notify_user)) == 'lead' ) {
+		} elseif (strtolower(get_class($call->current_notify_user)) == 'lead') {
 			$xtpl->assign("ACCEPT_URL", $sugar_config['site_url'].
 				  '/index.php?entryPoint=acceptDecline&module=Calls&lead_id='.$call->current_notify_user->id.'&record='.$call->id);
 		} else {
@@ -508,7 +508,7 @@ 
 		$xtpl->assign("CALL_STARTDATE", $xOffset);
 		$xtpl->assign("CALL_HOURS", $call->duration_hours);
 		$xtpl->assign("CALL_MINUTES", $call->duration_minutes);
-		$xtpl->assign("CALL_STATUS", ((isset($call->status))?$app_list_strings['call_status_dom'][$call->status] : ""));
+		$xtpl->assign("CALL_STATUS", ((isset($call->status)) ? $app_list_strings['call_status_dom'][$call->status] : ""));
 		$xtpl->assign("CALL_DESCRIPTION", $call->description);
 
 		return $xtpl;
@@ -523,13 +523,13 @@ 
 		$result = $this->db->query($query, true);
 		$list = Array();
 
-		while($row = $this->db->fetchByAssoc($result)) {
+		while ($row = $this->db->fetchByAssoc($result)) {
 			$template = new User(); // PHP 5 will retrieve by reference, always over-writing the "old" one
 			$record = $template->retrieve($row['user_id']);
 			$template->required = $row['required'];
 			$template->accept_status = $row['accept_status'];
 
-			if($record != null) {
+			if ($record != null) {
 			    // this copies the object into the array
 				$list[] = $template;
 			}
@@ -552,14 +552,14 @@ 
     $list = Array();
 
 
-    while($row = $this->db->fetchByAssoc($result))
+    while ($row = $this->db->fetchByAssoc($result))
     {
       $record = $template->retrieve($row['call_id']);
       $template->required = $row['required'];
       $template->accept_status = $row['accept_status'];
 
 
-      if($record != null)
+      if ($record != null)
       {
         // this copies the object into the array
         $list[] = $template;
@@ -570,56 +570,56 @@ 
   }
 
 
-  function set_accept_status(&$user,$status)
+  function set_accept_status(&$user, $status)
   {
-    if ( $user->object_name == 'User')
+    if ($user->object_name == 'User')
     {
-      $relate_values = array('user_id'=>$user->id,'call_id'=>$this->id);
+      $relate_values = array('user_id'=>$user->id, 'call_id'=>$this->id);
       $data_values = array('accept_status'=>$status);
-      $this->set_relationship($this->rel_users_table, $relate_values, true, true,$data_values);
+      $this->set_relationship($this->rel_users_table, $relate_values, true, true, $data_values);
       global $current_user;
 
-      if ( $this->update_vcal )
+      if ($this->update_vcal)
       {
         vCal::cache_sugar_vcal($user);
       }
     }
-    else if ( $user->object_name == 'Contact')
+    else if ($user->object_name == 'Contact')
     {
-      $relate_values = array('contact_id'=>$user->id,'call_id'=>$this->id);
+      $relate_values = array('contact_id'=>$user->id, 'call_id'=>$this->id);
       $data_values = array('accept_status'=>$status);
-      $this->set_relationship($this->rel_contacts_table, $relate_values, true, true,$data_values);
+      $this->set_relationship($this->rel_contacts_table, $relate_values, true, true, $data_values);
     }
-    else if ( $user->object_name == 'Lead')
+    else if ($user->object_name == 'Lead')
     {
-      $relate_values = array('lead_id'=>$user->id,'call_id'=>$this->id);
+      $relate_values = array('lead_id'=>$user->id, 'call_id'=>$this->id);
       $data_values = array('accept_status'=>$status);
-      $this->set_relationship($this->rel_leads_table, $relate_values, true, true,$data_values);
+      $this->set_relationship($this->rel_leads_table, $relate_values, true, true, $data_values);
     }
   }
 
 
 
 	function get_notification_recipients() {
-		if($this->special_notification) {
+		if ($this->special_notification) {
 			return parent::get_notification_recipients();
 		}
 
 //		$GLOBALS['log']->debug('Call.php->get_notification_recipients():'.print_r($this,true));
 		$list = array();
-        if(!is_array($this->contacts_arr)) {
-			$this->contacts_arr =	array();
+        if (!is_array($this->contacts_arr)) {
+			$this->contacts_arr = array();
 		}
 
-		if(!is_array($this->users_arr)) {
-			$this->users_arr =	array();
+		if (!is_array($this->users_arr)) {
+			$this->users_arr = array();
 		}
 
-        if(!is_array($this->leads_arr)) {
-			$this->leads_arr =	array();
+        if (!is_array($this->leads_arr)) {
+			$this->leads_arr = array();
 		}
 
-		foreach($this->users_arr as $user_id) {
+		foreach ($this->users_arr as $user_id) {
 			$notify_user = new User();
 			$notify_user->retrieve($user_id);
 			$notify_user->new_assigned_user_name = $notify_user->full_name;
@@ -627,7 +627,7 @@ 
 			$list[$notify_user->id] = $notify_user;
 		}
 
-		foreach($this->contacts_arr as $contact_id) {
+		foreach ($this->contacts_arr as $contact_id) {
 			$notify_user = new Contact();
 			$notify_user->retrieve($contact_id);
 			$notify_user->new_assigned_user_name = $notify_user->full_name;
@@ -635,7 +635,7 @@ 
 			$list[$notify_user->id] = $notify_user;
 		}
 
-        foreach($this->leads_arr as $lead_id) {
+        foreach ($this->leads_arr as $lead_id) {
 			$notify_user = new Lead();
 			$notify_user->retrieve($lead_id);
 			$notify_user->new_assigned_user_name = $notify_user->full_name;
@@ -643,38 +643,38 @@ 
 			$list[$notify_user->id] = $notify_user;
 		}
 		global $sugar_config;
-		if(isset($sugar_config['disable_notify_current_user']) && $sugar_config['disable_notify_current_user']) {
+		if (isset($sugar_config['disable_notify_current_user']) && $sugar_config['disable_notify_current_user']) {
 			global $current_user;
-			if(isset($list[$current_user->id]))
+			if (isset($list[$current_user->id]))
 				unset($list[$current_user->id]);
 		}
 //		$GLOBALS['log']->debug('Call.php->get_notification_recipients():'.print_r($list,true));
 		return $list;
 	}
 
-    function bean_implements($interface){
-		switch($interface){
+    function bean_implements($interface) {
+		switch ($interface) {
 			case 'ACL':return true;
 		}
 		return false;
 	}
 
-	function listviewACLHelper(){
+	function listviewACLHelper() {
 		$array_assign = parent::listviewACLHelper();
 		$is_owner = false;
 		$in_group = false; //SECURITY GROUPS
-		if(!empty($this->parent_name)){
+		if (!empty($this->parent_name)) {
 
-			if(!empty($this->parent_name_owner)){
+			if (!empty($this->parent_name_owner)) {
 				global $current_user;
 				$is_owner = $current_user->id == $this->parent_name_owner;
 			}
 			/* BEGIN - SECURITY GROUPS */
 			//parent_name_owner not being set for whatever reason so we need to figure this out
-			else if(!empty($this->parent_type) && !empty($this->parent_id)) {
+			else if (!empty($this->parent_type) && !empty($this->parent_id)) {
 				global $current_user;
-                $parent_bean = BeanFactory::getBean($this->parent_type,$this->parent_id);
-                if($parent_bean !== false) {
+                $parent_bean = BeanFactory::getBean($this->parent_type, $this->parent_id);
+                if ($parent_bean !== false) {
                 	$is_owner = $current_user->id == $parent_bean->assigned_user_id;
                 }
 			}
@@ -687,17 +687,17 @@ 
 			/**
 			if(!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner)){
 			*/
-			if(!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner, 'module', $in_group)){
+			if (!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner, 'module', $in_group)) {
         	/* END - SECURITY GROUPS */
 				$array_assign['PARENT'] = 'a';
-			}else{
+			} else {
 				$array_assign['PARENT'] = 'span';
 			}
 		$is_owner = false;
 		$in_group = false; //SECURITY GROUPS
-		if(!empty($this->contact_name)){
+		if (!empty($this->contact_name)) {
 
-			if(!empty($this->contact_name_owner)){
+			if (!empty($this->contact_name_owner)) {
 				global $current_user;
 				$is_owner = $current_user->id == $this->contact_name_owner;
 			}
@@ -705,8 +705,8 @@ 
 			//contact_name_owner not being set for whatever reason so we need to figure this out
 			else {
 				global $current_user;
-                $parent_bean = BeanFactory::getBean('Contacts',$this->contact_id);
-                if($parent_bean !== false) {
+                $parent_bean = BeanFactory::getBean('Contacts', $this->contact_id);
+                if ($parent_bean !== false) {
                 	$is_owner = $current_user->id == $parent_bean->assigned_user_id;
                 }
 			}
@@ -718,10 +718,10 @@ 
 			/**
 			if( ACLController::checkAccess('Contacts', 'view', $is_owner)){
 			*/
-			if( ACLController::checkAccess('Contacts', 'view', $is_owner, 'module', $in_group)){
+			if (ACLController::checkAccess('Contacts', 'view', $is_owner, 'module', $in_group)) {
         	/* END - SECURITY GROUPS */
 				$array_assign['CONTACT'] = 'a';
-			}else{
+			} else {
 				$array_assign['CONTACT'] = 'span';
 			}
 
@@ -729,13 +729,13 @@ 
 	}
 
 	function save_relationship_changes($is_update, $exclude = array()) {
-		if(empty($this->in_workflow))
+		if (empty($this->in_workflow))
         {
-            if(empty($this->in_import))
+            if (empty($this->in_import))
             {
                 //if the global soap_server_object variable is not empty (as in from a soap/OPI call), then process the assigned_user_id relationship, otherwise
                 //add assigned_user_id to exclude list and let the logic from MeetingFormBase determine whether assigned user id gets added to the relationship
-                if(!empty($GLOBALS['soap_server_object']))
+                if (!empty($GLOBALS['soap_server_object']))
                 {
            		    $exclude = array('lead_id', 'contact_id', 'user_id');
            	    }

Braces +49 added lines, -40 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -134,8 +136,9 @@ 
 
 
 
-         if(!empty($GLOBALS['app_list_strings']['duration_intervals']))
-        	$this->minutes_values = $GLOBALS['app_list_strings']['duration_intervals'];
+         if(!empty($GLOBALS['app_list_strings']['duration_intervals'])) {
+                 	$this->minutes_values = $GLOBALS['app_list_strings']['duration_intervals'];
+         }
 	}
 
 	/**
@@ -284,16 +287,17 @@ 
 			$where_auto = '1=1';
        		 if($show_deleted == 0){
             	$where_auto = " $this->table_name.deleted=0  ";
-			}else if($show_deleted == 1){
+			} else if($show_deleted == 1){
 				$where_auto = " $this->table_name.deleted=1 ";
 			}
 
 			//$where_auto .= " GROUP BY calls.id";
 
-		if($where != "")
-			$query .= "where $where AND ".$where_auto;
-		else
-			$query .= "where ".$where_auto;
+		if($where != "") {
+					$query .= "where $where AND ".$where_auto;
+		} else {
+					$query .= "where ".$where_auto;
+		}
 
         $order_by = $this->process_order_by($order_by);
         if (empty($order_by)) {
@@ -315,8 +319,7 @@ 
                     $query .= $custom_join['select'];
                     $query .= " FROM contacts, calls, calls_contacts ";
                     $where_auto = "calls_contacts.contact_id = contacts.id AND calls_contacts.call_id = calls.id AND calls.deleted=0 AND contacts.deleted=0";
-            }
-            else
+            } else
             {
                     $query = 'SELECT calls.*, users.user_name as assigned_user_name ';
                     $query .= $custom_join['select'];
@@ -329,10 +332,11 @@ 
 
             $query .= $custom_join['join'];
 
-			if($where != "")
-                    $query .= "where $where AND ".$where_auto;
-            else
-                    $query .= "where ".$where_auto;
+			if($where != "") {
+			                    $query .= "where $where AND ".$where_auto;
+			} else {
+                                $query .= "where ".$where_auto;
+            }
 
         $order_by = $this->process_order_by($order_by);
         if (empty($order_by)) {
@@ -376,10 +380,12 @@ 
 			$this->date_start = $timedate->now();
 		}
 
-		if (is_null($this->duration_hours))
-			$this->duration_hours = "0";
-		if (is_null($this->duration_minutes))
-			$this->duration_minutes = "1";
+		if (is_null($this->duration_hours)) {
+					$this->duration_hours = "0";
+		}
+		if (is_null($this->duration_minutes)) {
+					$this->duration_minutes = "1";
+		}
 
 		$this->fill_in_additional_parent_fields();
 
@@ -400,8 +406,9 @@ 
 
 		if ( empty($this->id) ) {
 		    $reminder_t = $GLOBALS['current_user']->getPreference('reminder_time');
-		    if ( isset($reminder_t) )
-		        $this->reminder_time = $reminder_t;
+		    if ( isset($reminder_t) ) {
+		    		        $this->reminder_time = $reminder_t;
+		    }
 		}
 		$this->reminder_checked = $this->reminder_time == -1 ? false : true;
 
@@ -410,8 +417,9 @@ 
 		}
 		if(empty($this->id)){
 			$reminder_t = $GLOBALS['current_user']->getPreference('email_reminder_time');
-			if(isset($reminder_t))
-		    		$this->email_reminder_time = $reminder_t;
+			if(isset($reminder_t)) {
+					    		$this->email_reminder_time = $reminder_t;
+			}
 		}
 		$this->email_reminder_checked = $this->email_reminder_time == -1 ? false : true;
 
@@ -426,16 +434,20 @@ 
 	function get_list_view_data(){
 		$call_fields = $this->get_list_view_array();
 		global $app_list_strings, $focus, $action, $currentModule;
-		if (isset($focus->id)) $id = $focus->id;
-		else $id = '';
+		if (isset($focus->id)) {
+		    $id = $focus->id;
+		} else {
+		    $id = '';
+		}
 		if (isset($this->parent_type) && $this->parent_type != null)
 		{
 			$call_fields['PARENT_MODULE'] = $this->parent_type;
 		}
 		if ($this->status == "Planned") {
 			//cn: added this if() to deal with sequential Closes in Meetings.  this is a hack to a hack (formbase.php->handleRedirect)
-			if(empty($action))
-			    $action = "index";
+			if(empty($action)) {
+						    $action = "index";
+			}
 
             $setCompleteUrl = "<a id='{$this->id}' onclick='SUGAR.util.closeActivityPanel.show(\"{$this->module_dir}\",\"{$this->id}\",\"Held\",\"listview\",\"1\");'>";
 			if ($this->ACLAccess('edit')) {
@@ -451,9 +463,9 @@ 
 		$date_db = $timedate->to_db($mergeTime);
 		if( $date_db	< $today){
 			$call_fields['DATE_START']= "<font class='overdueTask'>".$call_fields['DATE_START']."</font>";
-		}else if($date_db < $nextday){
+		} else if($date_db < $nextday){
 			$call_fields['DATE_START'] = "<font class='todaysTask'>".$call_fields['DATE_START']."</font>";
-		}else{
+		} else{
 			$call_fields['DATE_START'] = "<font class='futureTask'>".$call_fields['DATE_START']."</font>";
 		}
 		$this->fill_in_additional_detail_fields();
@@ -583,14 +595,12 @@ 
       {
         vCal::cache_sugar_vcal($user);
       }
-    }
-    else if ( $user->object_name == 'Contact')
+    } else if ( $user->object_name == 'Contact')
     {
       $relate_values = array('contact_id'=>$user->id,'call_id'=>$this->id);
       $data_values = array('accept_status'=>$status);
       $this->set_relationship($this->rel_contacts_table, $relate_values, true, true,$data_values);
-    }
-    else if ( $user->object_name == 'Lead')
+    } else if ( $user->object_name == 'Lead')
     {
       $relate_values = array('lead_id'=>$user->id,'call_id'=>$this->id);
       $data_values = array('accept_status'=>$status);
@@ -645,8 +655,9 @@ 
 		global $sugar_config;
 		if(isset($sugar_config['disable_notify_current_user']) && $sugar_config['disable_notify_current_user']) {
 			global $current_user;
-			if(isset($list[$current_user->id]))
-				unset($list[$current_user->id]);
+			if(isset($list[$current_user->id])) {
+							unset($list[$current_user->id]);
+			}
 		}
 //		$GLOBALS['log']->debug('Call.php->get_notification_recipients():'.print_r($list,true));
 		return $list;
@@ -690,7 +701,7 @@ 
 			if(!ACLController::moduleSupportsACL($this->parent_type) || ACLController::checkAccess($this->parent_type, 'view', $is_owner, 'module', $in_group)){
         	/* END - SECURITY GROUPS */
 				$array_assign['PARENT'] = 'a';
-			}else{
+			} else{
 				$array_assign['PARENT'] = 'span';
 			}
 		$is_owner = false;
@@ -721,7 +732,7 @@ 
 			if( ACLController::checkAccess('Contacts', 'view', $is_owner, 'module', $in_group)){
         	/* END - SECURITY GROUPS */
 				$array_assign['CONTACT'] = 'a';
-			}else{
+			} else{
 				$array_assign['CONTACT'] = 'span';
 			}
 
@@ -738,13 +749,11 @@ 
                 if(!empty($GLOBALS['soap_server_object']))
                 {
            		    $exclude = array('lead_id', 'contact_id', 'user_id');
-           	    }
-                else
+           	    } else
                 {
 	                $exclude = array('lead_id', 'contact_id', 'user_id', 'assigned_user_id');
            	    }
-            }
-            else
+            } else
             {
                 $exclude = array('user_id');
             }

Doc Comments +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
 
 	/**
 	 * Disable edit if call is recurring and source is not Sugar. It should be edited only from Outlook.
-	 * @param $view string
+	 * @param string $view string
 	 * @param $is_owner bool
 	 */
 	function ACLAccess($view,$is_owner='not_set',$in_group='not_set'){

modules/Calls/metadata/additionalDetails.php

Indentation +26 added lines, -26 removed lines

@@ -41,11 +41,11 @@ 
 
 function additionalDetailsCall($fields) {
     global $timedate;
-	static $mod_strings;
-	if(empty($mod_strings)) {
-		global $current_language;
-		$mod_strings = return_module_language($current_language, 'Calls');
-	}
+    static $mod_strings;
+    if(empty($mod_strings)) {
+        global $current_language;
+        $mod_strings = return_module_language($current_language, 'Calls');
+    }
     $overlib_string = '';
     $overlib_string .= '<input id="type" type="hidden" value="Call"/>';
 
@@ -56,20 +56,20 @@ 
 
     $overlib_string .= '<h2><img src="index.php?entryPoint=getImage&themeName=' . SugarThemeRegistry::current()->name .'&imageName=Calls.gif"/> '.$mod_strings['LBL_CALL'].'</h2>';
 
-   if(!empty($fields['NAME'])) {
-        	$overlib_string .= '<b>'. $mod_strings['LBL_SUBJECT'] . '</b> ';
+    if(!empty($fields['NAME'])) {
+            $overlib_string .= '<b>'. $mod_strings['LBL_SUBJECT'] . '</b> ';
             $url = 'index.php?action=DetailView&module=Calls&record='.$fields['ID'];
             $overlib_string .= '<a href="'.$url.'">' . $fields['NAME'] . '</a>';
-        	$overlib_string .= '<br>';
+            $overlib_string .= '<br>';
     }
-	if(!empty($fields['DATE_START'])) {
+    if(!empty($fields['DATE_START'])) {
         $data_date = $timedate->fromUser($fields['DATE_START'])->format('Y-m-d H:i:s');
         $overlib_string .= '<span data-field="DATE_START" data-date="' . $data_date . '">';
         $overlib_string .= '<b>' . $mod_strings['LBL_DATE_TIME'] . '</b> ' . $fields['DATE_START'] . ' <br>';
         $overlib_string .= '</span>';
     }
-	if(isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DURATION'] . '</b> ';
+    if(isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) {
+        $overlib_string .= '<b>'. $mod_strings['LBL_DURATION'] . '</b> ';
         if(isset($fields['DURATION_HOURS'])) {
             $overlib_string .= $fields['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'] . ' ';
         }
@@ -77,7 +77,7 @@ 
             $overlib_string .=  $fields['DURATION_MINUTES'] . $mod_strings['LBL_MINSS_ABBREV'];
         }
         $overlib_string .=  '<br>';
-	}
+    }
     if (!empty($fields['PARENT_ID']))
     {
             $overlib_string .= "<b>". $mod_strings['LBL_RELATED_TO'] . "</b> ".
@@ -86,21 +86,21 @@ 
             $overlib_string .= '<br>';
     }
     if(!empty($fields['STATUS'])) {
-      	$overlib_string .= '<b>'. $mod_strings['LBL_STATUS'] . '</b> ' . $fields['STATUS'];
-      	$overlib_string .= '<br>';
-      }
-	if(!empty($fields['DESCRIPTION'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
-		$overlib_string .= '<br>';
-	}
+            $overlib_string .= '<b>'. $mod_strings['LBL_STATUS'] . '</b> ' . $fields['STATUS'];
+            $overlib_string .= '<br>';
+        }
+    if(!empty($fields['DESCRIPTION'])) {
+        $overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
+        if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+        $overlib_string .= '<br>';
+    }
     $overlib_string .= '<br>';
-	$editLink = "index.php?action=EditView&module=Calls&record={$fields['ID']}";
-	$viewLink = "index.php?action=DetailView&module=Calls&record={$fields['ID']}";
+    $editLink = "index.php?action=EditView&module=Calls&record={$fields['ID']}";
+    $viewLink = "index.php?action=DetailView&module=Calls&record={$fields['ID']}";
 
-	return array('fieldToAddTo' => 'NAME',
-				 'string' => $overlib_string,
-				 'editLink' => $editLink,
-				 'viewLink' => $viewLink);
+    return array('fieldToAddTo' => 'NAME',
+                    'string' => $overlib_string,
+                    'editLink' => $editLink,
+                    'viewLink' => $viewLink);
 }
 

Spacing +25 added lines, -25 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -42,56 +42,56 @@ 
 function additionalDetailsCall($fields) {
     global $timedate;
 	static $mod_strings;
-	if(empty($mod_strings)) {
+	if (empty($mod_strings)) {
 		global $current_language;
 		$mod_strings = return_module_language($current_language, 'Calls');
 	}
     $overlib_string = '';
     $overlib_string .= '<input id="type" type="hidden" value="Call"/>';
 
-    if(!empty($fields['ID'])) {
-        $overlib_string .= '<input id="id" type="hidden" value="'. $fields['ID'];
+    if (!empty($fields['ID'])) {
+        $overlib_string .= '<input id="id" type="hidden" value="'.$fields['ID'];
         $overlib_string .= '"/>';
     }
 
-    $overlib_string .= '<h2><img src="index.php?entryPoint=getImage&themeName=' . SugarThemeRegistry::current()->name .'&imageName=Calls.gif"/> '.$mod_strings['LBL_CALL'].'</h2>';
+    $overlib_string .= '<h2><img src="index.php?entryPoint=getImage&themeName='.SugarThemeRegistry::current()->name.'&imageName=Calls.gif"/> '.$mod_strings['LBL_CALL'].'</h2>';
 
-   if(!empty($fields['NAME'])) {
-        	$overlib_string .= '<b>'. $mod_strings['LBL_SUBJECT'] . '</b> ';
+   if (!empty($fields['NAME'])) {
+        	$overlib_string .= '<b>'.$mod_strings['LBL_SUBJECT'].'</b> ';
             $url = 'index.php?action=DetailView&module=Calls&record='.$fields['ID'];
-            $overlib_string .= '<a href="'.$url.'">' . $fields['NAME'] . '</a>';
+            $overlib_string .= '<a href="'.$url.'">'.$fields['NAME'].'</a>';
         	$overlib_string .= '<br>';
     }
-	if(!empty($fields['DATE_START'])) {
+	if (!empty($fields['DATE_START'])) {
         $data_date = $timedate->fromUser($fields['DATE_START'])->format('Y-m-d H:i:s');
-        $overlib_string .= '<span data-field="DATE_START" data-date="' . $data_date . '">';
-        $overlib_string .= '<b>' . $mod_strings['LBL_DATE_TIME'] . '</b> ' . $fields['DATE_START'] . ' <br>';
+        $overlib_string .= '<span data-field="DATE_START" data-date="'.$data_date.'">';
+        $overlib_string .= '<b>'.$mod_strings['LBL_DATE_TIME'].'</b> '.$fields['DATE_START'].' <br>';
         $overlib_string .= '</span>';
     }
-	if(isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DURATION'] . '</b> ';
-        if(isset($fields['DURATION_HOURS'])) {
-            $overlib_string .= $fields['DURATION_HOURS'] . $mod_strings['LBL_HOURS_ABBREV'] . ' ';
+	if (isset($fields['DURATION_HOURS']) || isset($fields['DURATION_MINUTES'])) {
+		$overlib_string .= '<b>'.$mod_strings['LBL_DURATION'].'</b> ';
+        if (isset($fields['DURATION_HOURS'])) {
+            $overlib_string .= $fields['DURATION_HOURS'].$mod_strings['LBL_HOURS_ABBREV'].' ';
         }
-        if(isset($fields['DURATION_MINUTES'])) {
-            $overlib_string .=  $fields['DURATION_MINUTES'] . $mod_strings['LBL_MINSS_ABBREV'];
+        if (isset($fields['DURATION_MINUTES'])) {
+            $overlib_string .= $fields['DURATION_MINUTES'].$mod_strings['LBL_MINSS_ABBREV'];
         }
-        $overlib_string .=  '<br>';
+        $overlib_string .= '<br>';
 	}
     if (!empty($fields['PARENT_ID']))
     {
-            $overlib_string .= "<b>". $mod_strings['LBL_RELATED_TO'] . "</b> ".
+            $overlib_string .= "<b>".$mod_strings['LBL_RELATED_TO']."</b> ".
                     "<a href='index.php?module=".$fields['PARENT_TYPE']."&action=DetailView&record=".$fields['PARENT_ID']."'>".
-                    $fields['PARENT_NAME'] . "</a>";
+                    $fields['PARENT_NAME']."</a>";
             $overlib_string .= '<br>';
     }
-    if(!empty($fields['STATUS'])) {
-      	$overlib_string .= '<b>'. $mod_strings['LBL_STATUS'] . '</b> ' . $fields['STATUS'];
+    if (!empty($fields['STATUS'])) {
+      	$overlib_string .= '<b>'.$mod_strings['LBL_STATUS'].'</b> '.$fields['STATUS'];
       	$overlib_string .= '<br>';
       }
-	if(!empty($fields['DESCRIPTION'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+	if (!empty($fields['DESCRIPTION'])) {
+		$overlib_string .= '<b>'.$mod_strings['LBL_DESCRIPTION'].'</b> '.substr($fields['DESCRIPTION'], 0, 300);
+		if (strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
 		$overlib_string .= '<br>';
 	}
     $overlib_string .= '<br>';

Braces +6 added lines, -2 removed lines

@@ -1,5 +1,7 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -91,7 +93,9 @@ 
       }
 	if(!empty($fields['DESCRIPTION'])) {
 		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ' . substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['DESCRIPTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 		$overlib_string .= '<br>';
 	}
     $overlib_string .= '<br>';

modules/Calls/metadata/editviewdefs.php

Indentation +77 added lines, -77 removed lines

@@ -39,136 +39,136 @@ 
 
 $viewdefs ['Calls'] =
 array (
-  'EditView' => 
-  array (
+    'EditView' => 
+    array (
     'templateMeta' => 
     array (
         'includes' => array(
             array('file' => 'modules/Reminders/Reminders.js'),
         ),
-      'maxColumns' => '2',
-      'form' => 
-      array (
+        'maxColumns' => '2',
+        'form' => 
+        array (
         'hidden' => 
         array (
-          0 => '<input type="hidden" name="isSaveAndNew" value="false">',
-          1 => '<input type="hidden" name="send_invites">',
-          2 => '<input type="hidden" name="user_invitees">',
-          3 => '<input type="hidden" name="lead_invitees">',
-          4 => '<input type="hidden" name="contact_invitees">',
+            0 => '<input type="hidden" name="isSaveAndNew" value="false">',
+            1 => '<input type="hidden" name="send_invites">',
+            2 => '<input type="hidden" name="user_invitees">',
+            3 => '<input type="hidden" name="lead_invitees">',
+            4 => '<input type="hidden" name="contact_invitees">',
         ),
         'buttons' => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_HEADER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
-          ),
-          1 => 'CANCEL',
-          2 => 
-          array (
+            ),
+            1 => 'CANCEL',
+            2 => 
+            array (
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_HEADER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
-          ),
-          3 => 
-          array (
+            ),
+            3 => 
+            array (
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_HEADER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
-          ),
+            ),
         ),
         'buttons_footer' => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_FOOTER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
-          ),
-          1 => 'CANCEL',
-          2 => 
-          array (
+            ),
+            1 => 'CANCEL',
+            2 => 
+            array (
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_FOOTER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
-          ),
-          3 => 
-          array (
+            ),
+            3 => 
+            array (
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_FOOTER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
-          ),
+            ),
         ),
         'footerTpl' => 'modules/Calls/tpls/footer.tpl',
-      ),
-      'widths' => 
-      array (
+        ),
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
+        ),
         ),
-      ),
-      'javascript' => '{sugar_getscript file="cache/include/javascript/sugar_grp_jsolait.js"}
+        'javascript' => '{sugar_getscript file="cache/include/javascript/sugar_grp_jsolait.js"}
 <script type="text/javascript">{$JSON_CONFIG_JAVASCRIPT}</script>
 <script>toggle_portal_flag();function toggle_portal_flag()  {ldelim} {$TOGGLE_JS} {rdelim}
 function formSubmitCheck(){ldelim}var duration=true;if(typeof(isValidDuration)!="undefined"){ldelim}duration=isValidDuration();{rdelim}if(check_form(\'EditView\') && duration){ldelim}SUGAR.ajaxUI.submitForm("EditView");{rdelim}{rdelim}</script>',
-      'useTabs' => false,
-      'tabDefs' => 
-      array (
+        'useTabs' => false,
+        'tabDefs' => 
+        array (
         'LBL_CALL_INFORMATION' => 
         array (
-          'newTab' => false,
-          'panelDefault' => 'expanded',
+            'newTab' => false,
+            'panelDefault' => 'expanded',
+        ),
         ),
-      ),
     ),
     'panels' => 
     array (
-      'lbl_call_information' => 
-      array (
+        'lbl_call_information' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'name',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'status',
             'fields' => 
             array (
-              0 => 
-              array (
+                0 => 
+                array (
                 'name' => 'direction',
-              ),
-              1 => 
-              array (
+                ),
+                1 => 
+                array (
                 'name' => 'status',
-              ),
+                ),
+            ),
             ),
-          ),
         ),
         1 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'date_start',
             'displayParams' => 
             array (
-              'updateCallback' => 'SugarWidgetScheduler.update_time();',
+                'updateCallback' => 'SugarWidgetScheduler.update_time();',
             ),
             'label' => 'LBL_DATE_TIME',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'parent_name',
             'label' => 'LBL_LIST_RELATED_TO',
-          ),
+            ),
         ),
         2 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'duration_hours',
             'label' => 'LBL_DURATION',
             'customCode' => '{literal}<script type="text/javascript">function isValidDuration() { form = document.getElementById(\'EditView\'); if ( form.duration_hours.value + form.duration_minutes.value <= 0 ) { alert(\'{/literal}{$MOD.NOTICE_DURATION_TIME}{literal}\'); return false; } return true; }</script>{/literal}<input id="duration_hours" name="duration_hours" size="2" maxlength="2" type="text" value="{$fields.duration_hours.value}" onkeyup="SugarWidgetScheduler.update_time();"/>{$fields.duration_minutes.value}&nbsp;<span class="dateFormat">{$MOD.LBL_HOURS_MINUTES}</span>',
-          ),
+            ),
 //          1 =>
 //          array (
 //            'name' => 'reminder_time',
@@ -186,23 +186,23 @@ 
         ),
         4 =>
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',
-          ),
+            ),
         ),
         5 =>
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
-          ),
+            ),
         ),
-      ),
+        ),
+    ),
     ),
-  ),
 );
 ?>

Spacing +37 added lines, -37 removed lines

@@ -38,19 +38,19 @@ 
  ********************************************************************************/
 
 $viewdefs ['Calls'] =
-array (
+array(
   'EditView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
         'includes' => array(
             array('file' => 'modules/Reminders/Reminders.js'),
         ),
       'maxColumns' => '2',
       'form' => 
-      array (
+      array(
         'hidden' => 
-        array (
+        array(
           0 => '<input type="hidden" name="isSaveAndNew" value="false">',
           1 => '<input type="hidden" name="send_invites">',
           2 => '<input type="hidden" name="user_invitees">',
@@ -58,48 +58,48 @@ 
           4 => '<input type="hidden" name="contact_invitees">',
         ),
         'buttons' => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_HEADER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
           ),
           1 => 'CANCEL',
           2 => 
-          array (
+          array(
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_HEADER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
           ),
           3 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_HEADER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
           ),
         ),
         'buttons_footer' => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'customCode' => '<input title="{$APP.LBL_SAVE_BUTTON_TITLE}" id="SAVE_FOOTER" accessKey="{$APP.LBL_SAVE_BUTTON_KEY}" class="button primary" onclick="SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\'; document.EditView.return_action.value=\'DetailView\'; {if isset($smarty.request.isDuplicate) && $smarty.request.isDuplicate eq "true"}document.EditView.return_id.value=\'\'; {/if}formSubmitCheck();;" type="button" name="button" value="{$APP.LBL_SAVE_BUTTON_LABEL}">',
           ),
           1 => 'CANCEL',
           2 => 
-          array (
+          array(
             'customCode' => '<input title="{$MOD.LBL_SEND_BUTTON_TITLE}" id="SAVE_SEND_FOOTER" class="button" onclick="document.EditView.send_invites.value=\'1\';SUGAR.calls.fill_invitees();document.EditView.action.value=\'Save\';document.EditView.return_action.value=\'EditView\';document.EditView.return_module.value=\'{$smarty.request.return_module}\';formSubmitCheck();;" type="button" name="button" value="{$MOD.LBL_SEND_BUTTON_LABEL}">',
           ),
           3 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"}<input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}" id="CLOSE_CREATE_FOOTER" accessKey="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_KEY}" class="button" onclick="SUGAR.calls.fill_invitees(); document.EditView.status.value=\'Held\'; document.EditView.action.value=\'Save\'; document.EditView.return_module.value=\'Calls\'; document.EditView.isDuplicate.value=true; document.EditView.isSaveAndNew.value=true; document.EditView.return_action.value=\'EditView\'; document.EditView.return_id.value=\'{$fields.id.value}\'; formSubmitCheck();" type="button" name="button" value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_LABEL}">{/if}',
           ),
         ),
         'footerTpl' => 'modules/Calls/tpls/footer.tpl',
       ),
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
@@ -110,61 +110,61 @@ 
 function formSubmitCheck(){ldelim}var duration=true;if(typeof(isValidDuration)!="undefined"){ldelim}duration=isValidDuration();{rdelim}if(check_form(\'EditView\') && duration){ldelim}SUGAR.ajaxUI.submitForm("EditView");{rdelim}{rdelim}</script>',
       'useTabs' => false,
       'tabDefs' => 
-      array (
+      array(
         'LBL_CALL_INFORMATION' => 
-        array (
+        array(
           'newTab' => false,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'lbl_call_information' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'name',
           ),
           1 => 
-          array (
+          array(
             'name' => 'status',
             'fields' => 
-            array (
+            array(
               0 => 
-              array (
+              array(
                 'name' => 'direction',
               ),
               1 => 
-              array (
+              array(
                 'name' => 'status',
               ),
             ),
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_start',
             'displayParams' => 
-            array (
+            array(
               'updateCallback' => 'SugarWidgetScheduler.update_time();',
             ),
             'label' => 'LBL_DATE_TIME',
           ),
           1 => 
-          array (
+          array(
             'name' => 'parent_name',
             'label' => 'LBL_LIST_RELATED_TO',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration_hours',
             'label' => 'LBL_DURATION',
             'customCode' => '{literal}<script type="text/javascript">function isValidDuration() { form = document.getElementById(\'EditView\'); if ( form.duration_hours.value + form.duration_minutes.value <= 0 ) { alert(\'{/literal}{$MOD.NOTICE_DURATION_TIME}{literal}\'); return false; } return true; }</script>{/literal}<input id="duration_hours" name="duration_hours" size="2" maxlength="2" type="text" value="{$fields.duration_hours.value}" onkeyup="SugarWidgetScheduler.update_time();"/>{$fields.duration_minutes.value}&nbsp;<span class="dateFormat">{$MOD.LBL_HOURS_MINUTES}</span>',
@@ -178,25 +178,25 @@ 
         ),
         3 => array(
             0 =>
-                array (
+                array(
                     'name' => 'reminders',
                     'customCode' => '{include file="modules/Reminders/tpls/reminders.tpl"}',
                     'label' => 'LBL_REMINDERS',
                 ),
         ),
         4 =>
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',
           ),
         ),
         5 =>
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'label' => 'LBL_ASSIGNED_TO_NAME',
           ),

modules/Calls/metadata/SearchFields.php

Indentation +66 added lines, -66 removed lines

@@ -40,135 +40,135 @@
 global $current_user;
 $module_name = "Calls";
 $searchFields['Calls'] = array (
-  'name' =>
-  array (
+    'name' =>
+    array (
     'query_type' => 'default',
-  ),
-  'contact_name' => 
-  array (
+    ),
+    'contact_name' => 
+    array (
     'query_type' => 'default',
     'db_field' => 
     array (
-      0 => 'contacts.first_name',
-      1 => 'contacts.last_name',
+        0 => 'contacts.first_name',
+        1 => 'contacts.last_name',
     ),
-  ),
-  'date_start' => 
-  array (
+    ),
+    'date_start' => 
+    array (
     'query_type' => 'default',
-  ),
-  'location' => 
-  array (
+    ),
+    'location' => 
+    array (
     'query_type' => 'default',
-  ),
-  'current_user_only' => 
-  array (
+    ),
+    'current_user_only' => 
+    array (
     'query_type' => 'default',
     'db_field' => 
     array (
-      0 => 'assigned_user_id',
+        0 => 'assigned_user_id',
     ),
     'my_items' => true,
     'vname' => 'LBL_CURRENT_USER_FILTER',
     'type' => 'bool',
-  ),
-  'assigned_user_id' => 
-  array (
+    ),
+    'assigned_user_id' => 
+    array (
     'query_type' => 'default',
-  ),
-  'status' => 
-  array (
+    ),
+    'status' => 
+    array (
     'query_type' => 'default',
     'options' => 'call_status_dom',
     'template_var' => 'STATUS_FILTER',
-  ),
-  'open_only' => 
-  array (
+    ),
+    'open_only' => 
+    array (
     'query_type' => 'default',
     'db_field' => 
     array (
-      0 => 'status',
+        0 => 'status',
     ),
     'operator' => 'not in',
     'closed_values' => 
     array (
-      0 => 'Held',
-      1 => 'Not Held',
+        0 => 'Held',
+        1 => 'Not Held',
     ),
     'type' => 'bool',
-  ),
-  'range_date_entered' => 
-  array (
+    ),
+    'range_date_entered' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'start_range_date_entered' => 
-  array (
+    ),
+    'start_range_date_entered' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'end_range_date_entered' => 
-  array (
+    ),
+    'end_range_date_entered' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'range_date_modified' => 
-  array (
+    ),
+    'range_date_modified' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'start_range_date_modified' => 
-  array (
+    ),
+    'start_range_date_modified' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'end_range_date_modified' => 
-  array (
+    ),
+    'end_range_date_modified' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'range_date_start' => 
-  array (
+    ),
+    'range_date_start' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'start_range_date_start' => 
-  array (
+    ),
+    'start_range_date_start' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'end_range_date_start' => 
-  array (
+    ),
+    'end_range_date_start' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'range_date_end' => 
-  array (
+    ),
+    'range_date_end' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'start_range_date_end' => 
-  array (
+    ),
+    'start_range_date_end' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
-  'end_range_date_end' => 
-  array (
+    ),
+    'end_range_date_end' => 
+    array (
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
-  ),
+    ),
     'favorites_only' => array(
         'query_type'=>'format',
         'operator' => 'subquery',

Spacing +27 added lines, -27 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -39,33 +39,33 @@ 
  ********************************************************************************/
 global $current_user;
 $module_name = "Calls";
-$searchFields['Calls'] = array (
+$searchFields['Calls'] = array(
   'name' =>
-  array (
+  array(
     'query_type' => 'default',
   ),
   'contact_name' => 
-  array (
+  array(
     'query_type' => 'default',
     'db_field' => 
-    array (
+    array(
       0 => 'contacts.first_name',
       1 => 'contacts.last_name',
     ),
   ),
   'date_start' => 
-  array (
+  array(
     'query_type' => 'default',
   ),
   'location' => 
-  array (
+  array(
     'query_type' => 'default',
   ),
   'current_user_only' => 
-  array (
+  array(
     'query_type' => 'default',
     'db_field' => 
-    array (
+    array(
       0 => 'assigned_user_id',
     ),
     'my_items' => true,
@@ -73,98 +73,98 @@ 
     'type' => 'bool',
   ),
   'assigned_user_id' => 
-  array (
+  array(
     'query_type' => 'default',
   ),
   'status' => 
-  array (
+  array(
     'query_type' => 'default',
     'options' => 'call_status_dom',
     'template_var' => 'STATUS_FILTER',
   ),
   'open_only' => 
-  array (
+  array(
     'query_type' => 'default',
     'db_field' => 
-    array (
+    array(
       0 => 'status',
     ),
     'operator' => 'not in',
     'closed_values' => 
-    array (
+    array(
       0 => 'Held',
       1 => 'Not Held',
     ),
     'type' => 'bool',
   ),
   'range_date_entered' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_entered' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_entered' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'range_date_modified' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_modified' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_modified' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'range_date_start' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_start' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_start' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'range_date_end' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'start_range_date_end' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
   ),
   'end_range_date_end' => 
-  array (
+  array(
     'query_type' => 'default',
     'enable_range_search' => true,
     'is_date_field' => true,
@@ -175,6 +175,6 @@ 
         'subquery' => 'SELECT favorites.parent_id FROM favorites
 			                    WHERE favorites.deleted = 0
 			                        and favorites.parent_type = "'.$module_name.'"
-			                        and favorites.assigned_user_id = "' .$current_user->id . '") OR NOT ({0}',
+			                        and favorites.assigned_user_id = "' .$current_user->id.'") OR NOT ({0}',
         'db_field'=>array('id')),
 );
\ No newline at end of file

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

modules/Calls/metadata/detailviewdefs.php

Indentation +97 added lines, -97 removed lines

@@ -40,150 +40,150 @@ 
 
 $viewdefs ['Calls'] =
 array (
-  'DetailView' => 
-  array (
+    'DetailView' => 
+    array (
     'templateMeta' => 
     array (
-      'form' => 
-      array (
+        'form' => 
+        array (
         'buttons' => 
         array (
-          0 => 'EDIT',
-          1 => 'DUPLICATE',
-          2 => 'DELETE',
-          3 => 
-          array (
+            0 => 'EDIT',
+            1 => 'DUPLICATE',
+            2 => 'DELETE',
+            3 => 
+            array (
             'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSaveAndNew" value="false">  <input type="hidden" name="status" value="">  <input type="hidden" name="isSaveFromDetailView" value="true">  <input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}"   class="button"  onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_create_button" name="button"  value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}"  type="submit">{/if}',
             'sugar_html' => 
             array (
-              'type' => 'submit',
-              'value' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
-              'htmlOptions' => 
-              array (
+                'type' => 'submit',
+                'value' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
+                'htmlOptions' => 
+                array (
                 'title' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
                 'class' => 'button',
                 'onclick' => 'this.form.isSaveFromDetailView.value=true; this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'',
                 'name' => 'button',
                 'id' => 'close_create_button',
-              ),
-              'template' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")}[CONTENT]{/if}',
+                ),
+                'template' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")}[CONTENT]{/if}',
+            ),
             ),
-          ),
-          4 => 
-          array (
+            4 => 
+            array (
             'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSave" value="false">  <input title="{$APP.LBL_CLOSE_BUTTON_TITLE}"  accesskey="{$APP.LBL_CLOSE_BUTTON_KEY}"  class="button"  onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isSave.value=true;this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_button" name="button1"  value="{$APP.LBL_CLOSE_BUTTON_TITLE}"  type="submit">{/if}',
             'sugar_html' => 
             array (
-              'type' => 'submit',
-              'value' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
-              'htmlOptions' => 
-              array (
+                'type' => 'submit',
+                'value' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
+                'htmlOptions' => 
+                array (
                 'title' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
                 'accesskey' => '{$APP.LBL_CLOSE_BUTTON_KEY}',
                 'class' => 'button',
                 'onclick' => 'this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isSave.value=true;this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\';this.form.isSaveFromDetailView.value=true',
                 'name' => 'button1',
                 'id' => 'close_button',
-              ),
-              'template' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")}[CONTENT]{/if}',
+                ),
+                'template' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")}[CONTENT]{/if}',
+            ),
             ),
-          ),
-          'SA_RESCHEDULE' => 
-          array (
+            'SA_RESCHEDULE' => 
+            array (
             'customCode' => '{if $fields.status.value != "Held"} <input title="{$MOD.LBL_RESCHEDULE}" class="button" onclick="get_form();" name="Reschedule" id="reschedule_button" value="{$MOD.LBL_RESCHEDULE}" type="button">{/if}',
-          ),
+            ),
         ),
         'hidden' => 
         array (
-          0 => '<input type="hidden" name="isSaveAndNew">',
-          1 => '<input type="hidden" name="status">',
-          2 => '<input type="hidden" name="isSaveFromDetailView">',
-          3 => '<input type="hidden" name="isSave">',
+            0 => '<input type="hidden" name="isSaveAndNew">',
+            1 => '<input type="hidden" name="status">',
+            2 => '<input type="hidden" name="isSaveFromDetailView">',
+            3 => '<input type="hidden" name="isSave">',
         ),
         'headerTpl' => 'modules/Calls/tpls/detailHeader.tpl',
-      ),
-      'maxColumns' => '2',
-      'widths' => 
-      array (
+        ),
+        'maxColumns' => '2',
+        'widths' => 
+        array (
         0 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
         1 => 
         array (
-          'label' => '10',
-          'field' => '30',
+            'label' => '10',
+            'field' => '30',
         ),
-      ),
-      'useTabs' => true,
-      'includes' => 
-      array (
+        ),
+        'useTabs' => true,
+        'includes' => 
+        array (
         'SA_RESCHEDULE' => 
         array (
-          'file' => 'modules/Calls_Reschedule/reschedule_form.js',
+            'file' => 'modules/Calls_Reschedule/reschedule_form.js',
+        ),
+            array('file' => 'modules/Reminders/Reminders.js'),
         ),
-          array('file' => 'modules/Reminders/Reminders.js'),
-      ),
-      'tabDefs' => 
-      array (
+        'tabDefs' => 
+        array (
         'LBL_CALL_INFORMATION' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
         'LBL_RESCHEDULE_PANEL' => 
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' =>
         array (
-          'newTab' => true,
-          'panelDefault' => 'expanded',
+            'newTab' => true,
+            'panelDefault' => 'expanded',
+        ),
         ),
-      ),
     ),
     'panels' => 
     array (
-      'lbl_call_information' => 
-      array (
+        'lbl_call_information' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'name',
             'label' => 'LBL_SUBJECT',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'direction',
             'customCode' => '{$fields.direction.options[$fields.direction.value]} {$fields.status.options[$fields.status.value]}',
             'label' => 'LBL_STATUS',
-          ),
+            ),
         ),
         1 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'date_start',
             'customCode' => '{$fields.date_start.value} {$fields.time_start.value}&nbsp;',
             'label' => 'LBL_DATE_TIME',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'parent_name',
             'customLabel' => '{sugar_translate label=\'LBL_MODULE_NAME\' module=$fields.parent_type.value}',
-          ),
+            ),
         ),
         2 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'duration_hours',
             'customCode' => '{$fields.duration_hours.value}{$MOD.LBL_HOURS_ABBREV} {$fields.duration_minutes.value}{$MOD.LBL_MINSS_ABBREV}&nbsp;',
             'label' => 'LBL_DURATION',
-          ),
+            ),
 //          1 =>
 //          array (
 //            'name' => 'reminder_time',
@@ -197,55 +197,55 @@ 
         ),
         3 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',
-          ),
+            ),
         ),
         4 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'assigned_user_name',
             'customCode' => '{$fields.assigned_user_name.value}',
             'label' => 'LBL_ASSIGNED_TO',
-          ),
+            ),
         ),
-      ),
-      'lbl_reschedule_panel' => 
-      array (
+        ),
+        'lbl_reschedule_panel' => 
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'reschedule_history',
             'comment' => 'Call duration, minutes portion',
             'label' => 'LBL_RESCHEDULE_HISTORY',
-          ),
-          1 => '',
+            ),
+            1 => '',
+        ),
         ),
-      ),
-      'LBL_PANEL_ASSIGNMENT' =>
-      array (
+        'LBL_PANEL_ASSIGNMENT' =>
+        array (
         0 => 
         array (
-          0 => 
-          array (
+            0 => 
+            array (
             'name' => 'date_entered',
             'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_ENTERED',
-          ),
-          1 => 
-          array (
+            ),
+            1 => 
+            array (
             'name' => 'date_modified',
             'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_MODIFIED',
-          ),
+            ),
         ),
-      ),
+        ),
+    ),
     ),
-  ),
 );
 ?>

Spacing +43 added lines, -43 removed lines

@@ -39,27 +39,27 @@ 
 
 
 $viewdefs ['Calls'] =
-array (
+array(
   'DetailView' => 
-  array (
+  array(
     'templateMeta' => 
-    array (
+    array(
       'form' => 
-      array (
+      array(
         'buttons' => 
-        array (
+        array(
           0 => 'EDIT',
           1 => 'DUPLICATE',
           2 => 'DELETE',
           3 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSaveAndNew" value="false">  <input type="hidden" name="status" value="">  <input type="hidden" name="isSaveFromDetailView" value="true">  <input title="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}"   class="button"  onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_create_button" name="button"  value="{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}"  type="submit">{/if}',
             'sugar_html' => 
-            array (
+            array(
               'type' => 'submit',
               'value' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
               'htmlOptions' => 
-              array (
+              array(
                 'title' => '{$APP.LBL_CLOSE_AND_CREATE_BUTTON_TITLE}',
                 'class' => 'button',
                 'onclick' => 'this.form.isSaveFromDetailView.value=true; this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isDuplicate.value=true;this.form.isSaveAndNew.value=true;this.form.return_action.value=\'EditView\'; this.form.return_id.value=\'{$fields.id.value}\'',
@@ -70,14 +70,14 @@ 
             ),
           ),
           4 => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held" && $bean->aclAccess("edit")} <input type="hidden" name="isSave" value="false">  <input title="{$APP.LBL_CLOSE_BUTTON_TITLE}"  accesskey="{$APP.LBL_CLOSE_BUTTON_KEY}"  class="button"  onclick="this.form.status.value=\'Held\'; this.form.action.value=\'Save\';this.form.return_module.value=\'Calls\';this.form.isSave.value=true;this.form.return_action.value=\'DetailView\'; this.form.return_id.value=\'{$fields.id.value}\'" id="close_button" name="button1"  value="{$APP.LBL_CLOSE_BUTTON_TITLE}"  type="submit">{/if}',
             'sugar_html' => 
-            array (
+            array(
               'type' => 'submit',
               'value' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
               'htmlOptions' => 
-              array (
+              array(
                 'title' => '{$APP.LBL_CLOSE_BUTTON_TITLE}',
                 'accesskey' => '{$APP.LBL_CLOSE_BUTTON_KEY}',
                 'class' => 'button',
@@ -89,12 +89,12 @@ 
             ),
           ),
           'SA_RESCHEDULE' => 
-          array (
+          array(
             'customCode' => '{if $fields.status.value != "Held"} <input title="{$MOD.LBL_RESCHEDULE}" class="button" onclick="get_form();" name="Reschedule" id="reschedule_button" value="{$MOD.LBL_RESCHEDULE}" type="button">{/if}',
           ),
         ),
         'hidden' => 
-        array (
+        array(
           0 => '<input type="hidden" name="isSaveAndNew">',
           1 => '<input type="hidden" name="status">',
           2 => '<input type="hidden" name="isSaveFromDetailView">',
@@ -104,82 +104,82 @@ 
       ),
       'maxColumns' => '2',
       'widths' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
         1 => 
-        array (
+        array(
           'label' => '10',
           'field' => '30',
         ),
       ),
       'useTabs' => true,
       'includes' => 
-      array (
+      array(
         'SA_RESCHEDULE' => 
-        array (
+        array(
           'file' => 'modules/Calls_Reschedule/reschedule_form.js',
         ),
           array('file' => 'modules/Reminders/Reminders.js'),
       ),
       'tabDefs' => 
-      array (
+      array(
         'LBL_CALL_INFORMATION' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_RESCHEDULE_PANEL' => 
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
         'LBL_PANEL_ASSIGNMENT' =>
-        array (
+        array(
           'newTab' => true,
           'panelDefault' => 'expanded',
         ),
       ),
     ),
     'panels' => 
-    array (
+    array(
       'lbl_call_information' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'name',
             'label' => 'LBL_SUBJECT',
           ),
           1 => 
-          array (
+          array(
             'name' => 'direction',
             'customCode' => '{$fields.direction.options[$fields.direction.value]} {$fields.status.options[$fields.status.value]}',
             'label' => 'LBL_STATUS',
           ),
         ),
         1 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_start',
             'customCode' => '{$fields.date_start.value} {$fields.time_start.value}&nbsp;',
             'label' => 'LBL_DATE_TIME',
           ),
           1 => 
-          array (
+          array(
             'name' => 'parent_name',
             'customLabel' => '{sugar_translate label=\'LBL_MODULE_NAME\' module=$fields.parent_type.value}',
           ),
         ),
         2 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'duration_hours',
             'customCode' => '{$fields.duration_hours.value}{$MOD.LBL_HOURS_ABBREV} {$fields.duration_minutes.value}{$MOD.LBL_MINSS_ABBREV}&nbsp;',
             'label' => 'LBL_DURATION',
@@ -196,18 +196,18 @@ 
                 ),
         ),
         3 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'description',
             'comment' => 'Full text of the note',
             'label' => 'LBL_DESCRIPTION',
           ),
         ),
         4 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'assigned_user_name',
             'customCode' => '{$fields.assigned_user_name.value}',
             'label' => 'LBL_ASSIGNED_TO',
@@ -215,11 +215,11 @@ 
         ),
       ),
       'lbl_reschedule_panel' => 
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'reschedule_history',
             'comment' => 'Call duration, minutes portion',
             'label' => 'LBL_RESCHEDULE_HISTORY',
@@ -228,17 +228,17 @@ 
         ),
       ),
       'LBL_PANEL_ASSIGNMENT' =>
-      array (
+      array(
         0 => 
-        array (
+        array(
           0 => 
-          array (
+          array(
             'name' => 'date_entered',
             'customCode' => '{$fields.date_entered.value} {$APP.LBL_BY} {$fields.created_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_ENTERED',
           ),
           1 => 
-          array (
+          array(
             'name' => 'date_modified',
             'customCode' => '{$fields.date_modified.value} {$APP.LBL_BY} {$fields.modified_by_name.value}&nbsp;',
             'label' => 'LBL_DATE_MODIFIED',