Inspection of "setting up console installer - system checker" - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — CI ( 785a66...02428e )

by Adam

created 2016-03-08 16:55 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -14,13 +14,13 @@
 block discarded – undo
         global $app_strings;
 
         $script = "<a href='javascript:void(0)' id='export_listview_top' ".
-                "onclick=\"return sListView.send_form(true, '{$_REQUEST['module']}', " .
-                "'index.php?entryPoint=export', " .
-                "'{$app_strings['LBL_LISTVIEW_NO_SELECTED']}')\">{$app_strings['LBL_EXPORT']}</a>" .
-                "</li><li>". // List item hack
-                "<a href='javascript:void(0)' id='map_listview_top' " .
-                " onclick=\"return sListView.send_form(true, 'jjwg_Maps', " .
-                "'index.php?entryPoint=jjwg_Maps&display_module={$_REQUEST['module']}', " .
+                "onclick=\"return sListView.send_form(true, '{$_REQUEST['module']}', ".
+                "'index.php?entryPoint=export', ".
+                "'{$app_strings['LBL_LISTVIEW_NO_SELECTED']}')\">{$app_strings['LBL_EXPORT']}</a>".
+                "</li><li>".// List item hack
+                "<a href='javascript:void(0)' id='map_listview_top' ".
+                " onclick=\"return sListView.send_form(true, 'jjwg_Maps', ".
+                "'index.php?entryPoint=jjwg_Maps&display_module={$_REQUEST['module']}', ".
                 "'{$app_strings['LBL_LISTVIEW_NO_SELECTED']}')\">{$app_strings['LBL_MAP']}</a>";
 
         return $script;

Please login to merge, or discard this patch.

modules/Opportunities/SaveOverload.php 4 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -40,11 +40,11 @@
 block discarded – undo
 
 
 function perform_save(&$focus){
-	//US DOLLAR
-	if(isset($focus->amount) && !number_empty($focus->amount)){
-		$currency = new Currency();
-		$currency->retrieve($focus->currency_id);
-		$focus->amount_usdollar = $currency->convertToDollar(unformat_number($focus->amount));
-	}	
+    //US DOLLAR
+    if(isset($focus->amount) && !number_empty($focus->amount)){
+        $currency = new Currency();
+        $currency->retrieve($focus->currency_id);
+        $focus->amount_usdollar = $currency->convertToDollar(unformat_number($focus->amount));
+    }	
 }
 ?>
\ No newline at end of file

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
  ********************************************************************************/
 
 
-function perform_save(&$focus){
+function perform_save(&$focus) {
 	//US DOLLAR
-	if(isset($focus->amount) && !number_empty($focus->amount)){
+	if (isset($focus->amount) && !number_empty($focus->amount)) {
 		$currency = new Currency();
 		$currency->retrieve($focus->currency_id);
 		$focus->amount_usdollar = $currency->convertToDollar(unformat_number($focus->amount));

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,7 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

Doc Comments +3 added lines patch added patch discarded remove patch

		@@ -39,6 +39,9 @@
		block discarded – undo
39	39	********************************************************************************/
40	40
41	41
	42	+/**
	43	+ * @param Opportunity $focus
	44	+ */
42	45	function perform_save(&$focus){
43	46	//US DOLLAR
44	47	if(isset($focus->amount) && !number_empty($focus->amount)){

Please login to merge, or discard this patch.

modules/Opportunities/SubPanelView.php 3 patches

Indentation +39 added lines, -39 removed lines patch added patch discarded remove patch

@@ -71,8 +71,8 @@  discard block
 block discarded – undo
 $button .= "<input type='hidden' name='module' value='Opportunities'>\n";
 if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
 if ($currentModule == 'Contacts') {
-	$button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
-	$button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
+    $button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
+    $button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
 }
 $button .= "<input type='hidden' name='return_module' value='".$currentModule."'>\n";
 $button .= "<input type='hidden' name='return_action' value='".$action."'>\n";
@@ -82,60 +82,60 @@  discard block
 block discarded – undo
 $button .= "<input title='".$app_strings['LBL_NEW_BUTTON_TITLE']."' accessyKey='".$app_strings['LBL_NEW_BUTTON_KEY']."' class='button' onclick=\"this.form.action.value='EditView'\" type='submit' name='New' value='  ".$app_strings['LBL_NEW_BUTTON_LABEL']."  '>\n";
 if ($currentModule == 'Accounts')
 {
-	///////////////////////////////////////
-	///
-	/// SETUP PARENT POPUP
+    ///////////////////////////////////////
+    ///
+    /// SETUP PARENT POPUP
 	
-	$popup_request_data = array(
-		'call_back_function' => 'set_return_and_save',
-		'form_name' => 'DetailView',
-		'field_to_name_array' => array(
-			'id' => 'opportunity_id',
-			),
-		);
+    $popup_request_data = array(
+        'call_back_function' => 'set_return_and_save',
+        'form_name' => 'DetailView',
+        'field_to_name_array' => array(
+            'id' => 'opportunity_id',
+            ),
+        );
 	
-	$json = getJSONobj();
-	$encoded_popup_request_data = $json->encode($popup_request_data);
+    $json = getJSONobj();
+    $encoded_popup_request_data = $json->encode($popup_request_data);
 	
-	//
-	///////////////////////////////////////
+    //
+    ///////////////////////////////////////
 				
-	$button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
-		."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
-		."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
-		."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
+    $button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
+        ."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
+        ."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
+        ."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
 //		."  ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
 }
 else
 {
-	///////////////////////////////////////
-	///
-	/// SETUP PARENT POPUP
+    ///////////////////////////////////////
+    ///
+    /// SETUP PARENT POPUP
 	
-	$popup_request_data = array(
-		'call_back_function' => 'set_return_and_save',
-		'form_name' => 'DetailView',
-		'field_to_name_array' => array(
-			'id' => 'opportunity_id',
-			),
-		);
+    $popup_request_data = array(
+        'call_back_function' => 'set_return_and_save',
+        'form_name' => 'DetailView',
+        'field_to_name_array' => array(
+            'id' => 'opportunity_id',
+            ),
+        );
 	
-	$json = getJSONobj();
-	$encoded_popup_request_data = $json->encode($popup_request_data);
+    $json = getJSONobj();
+    $encoded_popup_request_data = $json->encode($popup_request_data);
 	
-	//
-	///////////////////////////////////////
+    //
+    ///////////////////////////////////////
 				
-	$button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
-		."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
-		."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
-		."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
+    $button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
+        ."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
+        ."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
+        ."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
 //		."  ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=ContactDetailView&form_submit=true&query=true&account_id=$focus->account_id&account_name=$focus->account_name\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
 }
 $button .= "</form>\n";
 $header_text = '';
 if(is_admin($current_user) && $_REQUEST['module'] != 'DynamicLayout' && !empty($_SESSION['editinplace'])){	
-		$header_text = "&nbsp;<a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=". $_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout","border='0' align='bottom'",null,null,'.gif',$mod_strings['LBL_EDITLAYOUT'])."</a>";
+        $header_text = "&nbsp;<a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=". $_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout","border='0' align='bottom'",null,null,'.gif',$mod_strings['LBL_EDITLAYOUT'])."</a>";
 }
 $ListView = new ListView();
 $ListView->initNewXTemplate( 'modules/Opportunities/SubPanelView.html',$current_module_strings);

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -134,14 +134,14 @@  discard block
 block discarded – undo
 }
 $button .= "</form>\n";
 $header_text = '';
-if(is_admin($current_user) && $_REQUEST['module'] != 'DynamicLayout' && !empty($_SESSION['editinplace'])){	
-		$header_text = "&nbsp;<a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=". $_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout","border='0' align='bottom'",null,null,'.gif',$mod_strings['LBL_EDITLAYOUT'])."</a>";
+if (is_admin($current_user) && $_REQUEST['module'] != 'DynamicLayout' && !empty($_SESSION['editinplace'])) {	
+		$header_text = "&nbsp;<a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=".$_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout", "border='0' align='bottom'", null, null, '.gif', $mod_strings['LBL_EDITLAYOUT'])."</a>";
 }
 $ListView = new ListView();
-$ListView->initNewXTemplate( 'modules/Opportunities/SubPanelView.html',$current_module_strings);
+$ListView->initNewXTemplate('modules/Opportunities/SubPanelView.html', $current_module_strings);
 $ListView->xTemplateAssign("RETURN_URL", "&return_module=".$currentModule."&return_action=DetailView&return_id={$_REQUEST['record']}");
-$ListView->xTemplateAssign("EDIT_INLINE_PNG",  SugarThemeRegistry::current()->getImage('edit_inline','align="absmiddle" border="0"',null,null,'.gif',$app_strings['LNK_EDIT']));
-$ListView->setHeaderTitle($current_module_strings['LBL_MODULE_NAME']. $header_text );
+$ListView->xTemplateAssign("EDIT_INLINE_PNG", SugarThemeRegistry::current()->getImage('edit_inline', 'align="absmiddle" border="0"', null, null, '.gif', $app_strings['LNK_EDIT']));
+$ListView->setHeaderTitle($current_module_strings['LBL_MODULE_NAME'].$header_text);
 $ListView->setHeaderText($button);
 $ListView->processListView($focus_list, "main", "OPPORTUNITY");
 

Please login to merge, or discard this patch.

Braces +7 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,5 +1,7 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -69,7 +71,9 @@  discard block
 block discarded – undo
 
 $button  = "<form action='index.php' method='post' name='form' id='form'>\n";
 $button .= "<input type='hidden' name='module' value='Opportunities'>\n";
-if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
+if ($currentModule == 'Accounts') {
+    $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
+}
 if ($currentModule == 'Contacts') {
 	$button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
 	$button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
@@ -105,8 +109,7 @@  discard block
 block discarded – undo
 		."' type='button' class='button' value='  ".$app_strings['LBL_SELECT_BUTTON_LABEL']
 		."  ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
 //		."  ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
-}
-else
+} else
 {
 	///////////////////////////////////////
 	///

Please login to merge, or discard this patch.

modules/Opportunities/metadata/additionalDetails.php 3 patches

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -41,26 +41,26 @@
 block discarded – undo
  
 
 function additionalDetailsOpportunity($fields) {
-	global $current_language;
-	$mod_strings = return_module_language($current_language, 'Opportunities');
-	$overlib_string = '';
+    global $current_language;
+    $mod_strings = return_module_language($current_language, 'Opportunities');
+    $overlib_string = '';
 	
-	if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
-	if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
-	if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
-	if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
+    if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
+    if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
+    if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
+    if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
 
-	if(!empty($fields['DESCRIPTION'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
-		$overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
-	}	
+    if(!empty($fields['DESCRIPTION'])) {
+        $overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
+        $overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
+        if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+    }	
 	
-	return array('fieldToAddTo' => 'NAME', 
-				 'string' => $overlib_string, 
-				 'editLink' => "index.php?action=EditView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}", 
-				 'viewLink' => "index.php?action=DetailView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}");
+    return array('fieldToAddTo' => 'NAME', 
+                    'string' => $overlib_string, 
+                    'editLink' => "index.php?action=EditView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}", 
+                    'viewLink' => "index.php?action=DetailView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}");
 }
  
- ?>
+    ?>
  

Please login to merge, or discard this patch.

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,15 +45,15 @@  discard block
 block discarded – undo
 	$mod_strings = return_module_language($current_language, 'Opportunities');
 	$overlib_string = '';
 	
-	if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
-	if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
-	if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
-	if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
+	if (!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'.$mod_strings['LBL_LEAD_SOURCE'].'</b> '.$fields['LEAD_SOURCE'].'<br>';
+	if (!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'.$mod_strings['LBL_PROBABILITY'].'</b> '.$fields['PROBABILITY'].'<br>';
+	if (!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'.$mod_strings['LBL_NEXT_STEP'].'</b> '.$fields['NEXT_STEP'].'<br>';
+	if (!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'.$mod_strings['LBL_TYPE'].'</b> '.$fields['OPPORTUNITY_TYPE'].'<br>';
 
-	if(!empty($fields['DESCRIPTION'])) {
-		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
+	if (!empty($fields['DESCRIPTION'])) {
+		$overlib_string .= '<b>'.$mod_strings['LBL_DESCRIPTION'].'</b> ';
 		$overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+		if (strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
 	}	
 	
 	return array('fieldToAddTo' => 'NAME', 

Please login to merge, or discard this patch.

Braces +18 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,5 +1,7 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -45,15 +47,25 @@  discard block
 block discarded – undo
 	$mod_strings = return_module_language($current_language, 'Opportunities');
 	$overlib_string = '';
 	
-	if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
-	if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
-	if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
-	if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
+	if(!empty($fields['LEAD_SOURCE'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
+	}
+	if(!empty($fields['PROBABILITY'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
+	}
+	if(!empty($fields['NEXT_STEP'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
+	}
+	if(!empty($fields['OPPORTUNITY_TYPE'])) {
+	    $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
+	}
 
 	if(!empty($fields['DESCRIPTION'])) {
 		$overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
 		$overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
-		if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
+		if(strlen($fields['DESCRIPTION']) > 300) {
+		    $overlib_string .= '...';
+		}
 	}	
 	
 	return array('fieldToAddTo' => 'NAME', 

Please login to merge, or discard this patch.

modules/Opportunities/metadata/acldefs.php 3 patches

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -40,25 +40,25 @@
 block discarded – undo
 
 // created: 2005-10-19 11:16:08
 $acldefs['Opportunities'] = array (
-  'forms' => 
-  array (
+    'forms' => 
+    array (
     'by_name' => 
     array (
-      'btn1' => 
-      array (
+        'btn1' => 
+        array (
         'display_option' => 'disabled',
         'action_option' => 'list',
         'app_action' => 'EditView',
         'module' => 'Accounts',
-      ),
+        ),
+    ),
     ),
-  ),
-  'form_names' => 
-  array (
+    'form_names' => 
+    array (
     'by_id' => 'by_id',
     'by_name' => 'by_name',
     'DetailView' => 'DetailView',
     'EditView' => 'EditView',
-  ),
+    ),
 );
 ?>

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
@@ -39,13 +39,13 @@  discard block
 block discarded – undo
  ********************************************************************************/
 
 // created: 2005-10-19 11:16:08
-$acldefs['Opportunities'] = array (
+$acldefs['Opportunities'] = array(
   'forms' => 
-  array (
+  array(
     'by_name' => 
-    array (
+    array(
       'btn1' => 
-      array (
+      array(
         'display_option' => 'disabled',
         'action_option' => 'list',
         'app_action' => 'EditView',
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
     ),
   ),
   'form_names' => 
-  array (
+  array(
     'by_id' => 'by_id',
     'by_name' => 'by_name',
     'DetailView' => 'DetailView',

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,7 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

modules/Opportunities/metadata/editviewdefs.php 2 patches

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -45,43 +45,43 @@
 block discarded – undo
                                             ),
     'javascript' => '{$PROBABILITY_SCRIPT}',
 ),
- 'panels' =>array (
-  'default' => 
-  array (
+    'panels' =>array (
+    'default' => 
+    array (
     
     array (
-      array('name'=>'name'),
-      'account_name',
+        array('name'=>'name'),
+        'account_name',
     ),
     array(
-    	array('name'=>'currency_id','label'=>'LBL_CURRENCY'),
-    	array('name'=>'date_closed'),
+        array('name'=>'currency_id','label'=>'LBL_CURRENCY'),
+        array('name'=>'date_closed'),
     ),
     array (
-      array( 'name'=>'amount'),
-      'opportunity_type',
+        array( 'name'=>'amount'),
+        'opportunity_type',
     ),
     array (
-      'sales_stage',
-      'lead_source',
+        'sales_stage',
+        'lead_source',
     ),
     array (      
-		'probability',
-      	'campaign_name',
+        'probability',
+            'campaign_name',
     ),
     array (
-      	'next_step',
+            'next_step',
     ),
     array (
-      'description',
+        'description',
+    ),
     ),
-  ),
   
-  'LBL_PANEL_ASSIGNMENT' => array(
+    'LBL_PANEL_ASSIGNMENT' => array(
     array(
-	    'assigned_user_name',
+        'assigned_user_name',
+    ),
     ),
-  ),
 )
 
 

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -45,34 +45,34 @@
 block discarded – undo
                                             ),
     'javascript' => '{$PROBABILITY_SCRIPT}',
 ),
- 'panels' =>array (
+ 'panels' =>array(
   'default' => 
-  array (
+  array(
     
-    array (
+    array(
       array('name'=>'name'),
       'account_name',
     ),
     array(
-    	array('name'=>'currency_id','label'=>'LBL_CURRENCY'),
+    	array('name'=>'currency_id', 'label'=>'LBL_CURRENCY'),
     	array('name'=>'date_closed'),
     ),
-    array (
-      array( 'name'=>'amount'),
+    array(
+      array('name'=>'amount'),
       'opportunity_type',
     ),
-    array (
+    array(
       'sales_stage',
       'lead_source',
     ),
-    array (      
+    array(      
 		'probability',
       	'campaign_name',
     ),
-    array (
+    array(
       	'next_step',
     ),
-    array (
+    array(
       'description',
     ),
   ),

Please login to merge, or discard this patch.

modules/Opportunities/metadata/popupdefs.php 3 patches

Indentation +42 added lines, -42 removed lines patch added patch discarded remove patch

@@ -42,48 +42,48 @@
 block discarded – undo
 global $mod_strings;
 
 $popupMeta = array('moduleMain' => 'Opportunity',
-						'varName' => 'OPPORTUNITY',
-						'orderBy' => 'name',
-						'whereClauses' => 
-							array('name' => 'opportunities.name', 
-									'account_name' => 'accounts.name'),
-						'searchInputs' =>
-							array('name', 'account_name'),
-						'listviewdefs' => array(
-											'NAME' => array(
-												'width'   => '30',  
-												'label'   => 'LBL_LIST_OPPORTUNITY_NAME', 
-												'link'    => true,
-										        'default' => true),
-											'ACCOUNT_NAME' => array(
-												'width'   => '20', 
-												'label'   => 'LBL_LIST_ACCOUNT_NAME', 
-												'id'      => 'ACCOUNT_ID',
-										        'module'  => 'Accounts',
-										        'default' => true,
-										        'sortable'=> true,
-										        'ACLTag' => 'ACCOUNT'),
-										    'OPPORTUNITY_TYPE' => array(
-										        'width' => '15', 
-										        'default' => true,
-										        'label' => 'LBL_TYPE'),
-											'SALES_STAGE' => array(
-												'width'   => '10',  
-												'label'   => 'LBL_LIST_SALES_STAGE',
-										        'default' => true), 
-										    'ASSIGNED_USER_NAME' => array(
-												'width' => '5', 
-												'label' => 'LBL_LIST_ASSIGNED_USER',
-										        'default' => true),
-											),
-						'searchdefs'   => array(
-										 	'name', 
-											array('name' => 'account_name', 'displayParams' => array('hideButtons'=>'true', 'size'=>30, 'class'=>'sqsEnabled sqsNoAutofill')), 
-											'opportunity_type',
-											'sales_stage',
-											array('name' => 'assigned_user_id', 'type' => 'enum', 'label' => 'LBL_ASSIGNED_TO', 'function' => array('name' => 'get_user_array', 'params' => array(false))),
-										  )
-						);
+                        'varName' => 'OPPORTUNITY',
+                        'orderBy' => 'name',
+                        'whereClauses' => 
+                            array('name' => 'opportunities.name', 
+                                    'account_name' => 'accounts.name'),
+                        'searchInputs' =>
+                            array('name', 'account_name'),
+                        'listviewdefs' => array(
+                                            'NAME' => array(
+                                                'width'   => '30',  
+                                                'label'   => 'LBL_LIST_OPPORTUNITY_NAME', 
+                                                'link'    => true,
+                                                'default' => true),
+                                            'ACCOUNT_NAME' => array(
+                                                'width'   => '20', 
+                                                'label'   => 'LBL_LIST_ACCOUNT_NAME', 
+                                                'id'      => 'ACCOUNT_ID',
+                                                'module'  => 'Accounts',
+                                                'default' => true,
+                                                'sortable'=> true,
+                                                'ACLTag' => 'ACCOUNT'),
+                                            'OPPORTUNITY_TYPE' => array(
+                                                'width' => '15', 
+                                                'default' => true,
+                                                'label' => 'LBL_TYPE'),
+                                            'SALES_STAGE' => array(
+                                                'width'   => '10',  
+                                                'label'   => 'LBL_LIST_SALES_STAGE',
+                                                'default' => true), 
+                                            'ASSIGNED_USER_NAME' => array(
+                                                'width' => '5', 
+                                                'label' => 'LBL_LIST_ASSIGNED_USER',
+                                                'default' => true),
+                                            ),
+                        'searchdefs'   => array(
+                                                'name', 
+                                            array('name' => 'account_name', 'displayParams' => array('hideButtons'=>'true', 'size'=>30, 'class'=>'sqsEnabled sqsNoAutofill')), 
+                                            'opportunity_type',
+                                            'sales_stage',
+                                            array('name' => 'assigned_user_id', 'type' => 'enum', 'label' => 'LBL_ASSIGNED_TO', 'function' => array('name' => 'get_user_array', 'params' => array(false))),
+                                            )
+                        );
 
 
 ?>
\ No newline at end of file

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,7 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

modules/Opportunities/metadata/searchdefs.php 2 patches

Indentation +44 added lines, -44 removed lines patch added patch discarded remove patch

@@ -38,102 +38,102 @@
 block discarded – undo
  ********************************************************************************/
 
 $searchdefs['Opportunities'] = array(
-  'templateMeta' => 
-  array (
+    'templateMeta' => 
+    array (
     'maxColumns' => '3',
     'maxColumnsBasic' => '4', 
     'widths' => 
     array (
-      'label' => '10',
-      'field' => '30',
+        'label' => '10',
+        'field' => '30',
+    ),
     ),
-  ),
-  'layout' => 
-  array (
+    'layout' => 
+    array (
     'basic_search' => 
     array (
-      'name' => 
-      array (
+        'name' => 
+        array (
         'name' => 'name',
         'default' => true,
         'width' => '10%',
-      ),
-      'current_user_only' => 
-      array (
+        ),
+        'current_user_only' => 
+        array (
         'name' => 'current_user_only',
         'label' => 'LBL_CURRENT_USER_FILTER',
         'type' => 'bool',
         'default' => true,
         'width' => '10%',
-      ),
-	  array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
-      array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
+        ),
+        array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
+        array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
 
     ),
     'advanced_search' => 
     array (
-      'name' => 
-      array (
+        'name' => 
+        array (
         'name' => 'name',
         'default' => true,
         'width' => '10%',
-      ),
-      'account_name' => 
-      array (
+        ),
+        'account_name' => 
+        array (
         'name' => 'account_name',
         'default' => true,
         'width' => '10%',
-      ),
-      'amount' => 
-      array (
+        ),
+        'amount' => 
+        array (
         'name' => 'amount',
         'default' => true,
         'width' => '10%',
-      ),
-      'assigned_user_id' => 
-      array (
+        ),
+        'assigned_user_id' => 
+        array (
         'name' => 'assigned_user_id',
         'type' => 'enum',
         'label' => 'LBL_ASSIGNED_TO',
         'function' => 
         array (
-          'name' => 'get_user_array',
-          'params' => 
-          array (
+            'name' => 'get_user_array',
+            'params' => 
+            array (
             0 => false,
-          ),
+            ),
         ),
         'default' => true,
         'width' => '10%',
-      ),
-      'sales_stage' => 
-      array (
+        ),
+        'sales_stage' => 
+        array (
         'name' => 'sales_stage',
         'default' => true,
         'width' => '10%',
-      ),
-      'lead_source' => 
-      array (
+        ),
+        'lead_source' => 
+        array (
         'name' => 'lead_source',
         'default' => true,
         'width' => '10%',
-      ),
-      'date_closed' => 
-      array (
+        ),
+        'date_closed' => 
+        array (
         'name' => 'date_closed',
         'default' => true,
         'width' => '10%',
-      ),
-      'next_step' => 
-      array (
+        ),
+        'next_step' => 
+        array (
         'type' => 'varchar',
         'label' => 'LBL_NEXT_STEP',
         'width' => '10%',
         'default' => true,
         'name' => 'next_step',
-      ),
+        ),
+    ),
     ),
-  ),
 					
 );
 ?>

Please login to merge, or discard this patch.

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -39,67 +39,67 @@  discard block
 block discarded – undo
 
 $searchdefs['Opportunities'] = array(
   'templateMeta' => 
-  array (
+  array(
     'maxColumns' => '3',
     'maxColumnsBasic' => '4', 
     'widths' => 
-    array (
+    array(
       'label' => '10',
       'field' => '30',
     ),
   ),
   'layout' => 
-  array (
+  array(
     'basic_search' => 
-    array (
+    array(
       'name' => 
-      array (
+      array(
         'name' => 'name',
         'default' => true,
         'width' => '10%',
       ),
       'current_user_only' => 
-      array (
+      array(
         'name' => 'current_user_only',
         'label' => 'LBL_CURRENT_USER_FILTER',
         'type' => 'bool',
         'default' => true,
         'width' => '10%',
       ),
-	  array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
-      array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
+	  array('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
+      array('name' => 'favorites_only', 'label' => 'LBL_FAVORITES_FILTER', 'type' => 'bool',),
 
     ),
     'advanced_search' => 
-    array (
+    array(
       'name' => 
-      array (
+      array(
         'name' => 'name',
         'default' => true,
         'width' => '10%',
       ),
       'account_name' => 
-      array (
+      array(
         'name' => 'account_name',
         'default' => true,
         'width' => '10%',
       ),
       'amount' => 
-      array (
+      array(
         'name' => 'amount',
         'default' => true,
         'width' => '10%',
       ),
       'assigned_user_id' => 
-      array (
+      array(
         'name' => 'assigned_user_id',
         'type' => 'enum',
         'label' => 'LBL_ASSIGNED_TO',
         'function' => 
-        array (
+        array(
           'name' => 'get_user_array',
           'params' => 
-          array (
+          array(
             0 => false,
           ),
         ),
@@ -107,25 +107,25 @@  discard block
 block discarded – undo
         'width' => '10%',
       ),
       'sales_stage' => 
-      array (
+      array(
         'name' => 'sales_stage',
         'default' => true,
         'width' => '10%',
       ),
       'lead_source' => 
-      array (
+      array(
         'name' => 'lead_source',
         'default' => true,
         'width' => '10%',
       ),
       'date_closed' => 
-      array (
+      array(
         'name' => 'date_closed',
         'default' => true,
         'width' => '10%',
       ),
       'next_step' => 
-      array (
+      array(
         'type' => 'varchar',
         'label' => 'LBL_NEXT_STEP',
         'width' => '10%',

Please login to merge, or discard this patch.

modules/Opportunities/metadata/studio.php 3 patches

Indentation +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -42,28 +42,28 @@
 block discarded – undo
 
 
 $GLOBALS['studioDefs']['Opportunities'] = array(
-	'LBL_DETAILVIEW'=>array(
-				'template'=>'xtpl',
-				'template_file'=>'modules/Opportunities/DetailView.html',
-				'php_file'=>'modules/Opportunities/DetailView.php',
-				'type'=>'DetailView',
-				),
-	'LBL_EDITVIEW'=>array(
-				'template'=>'xtpl',
-				'template_file'=>'modules/Opportunities/EditView.html',
-				'php_file'=>'modules/Opportunities/EditView.php',
-				'type'=>'EditView',
-				),
-	'LBL_LISTVIEW'=>array(
-				'template'=>'listview',
-				'meta_file'=>'modules/Opportunities/listviewdefs.php',
-				'type'=>'ListView',
-				),
-	'LBL_SEARCHFORM'=>array(
-				'template'=>'xtpl',
-				'template_file'=>'modules/Opportunities/SearchForm.html',
-				'php_file'=>'modules/Opportunities/ListView.php',
-				'type'=>'SearchForm',
-				),
+    'LBL_DETAILVIEW'=>array(
+                'template'=>'xtpl',
+                'template_file'=>'modules/Opportunities/DetailView.html',
+                'php_file'=>'modules/Opportunities/DetailView.php',
+                'type'=>'DetailView',
+                ),
+    'LBL_EDITVIEW'=>array(
+                'template'=>'xtpl',
+                'template_file'=>'modules/Opportunities/EditView.html',
+                'php_file'=>'modules/Opportunities/EditView.php',
+                'type'=>'EditView',
+                ),
+    'LBL_LISTVIEW'=>array(
+                'template'=>'listview',
+                'meta_file'=>'modules/Opportunities/listviewdefs.php',
+                'type'=>'ListView',
+                ),
+    'LBL_SEARCHFORM'=>array(
+                'template'=>'xtpl',
+                'template_file'=>'modules/Opportunities/SearchForm.html',
+                'php_file'=>'modules/Opportunities/ListView.php',
+                'type'=>'SearchForm',
+                ),
 
 );

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if (!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,5 +1,7 @@
 block discarded – undo
 <?php
-if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');
+if(!defined('sugarEntry') || !sugarEntry) {
+    die('Not A Valid Entry Point');
+}
 /*********************************************************************************
  * SugarCRM Community Edition is a customer relationship management program developed by
  * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

Please login to merge, or discard this patch.

		@@ -71,8 +71,8 @@ discard block
		block discarded – undo
71	71	$button .= "<input type='hidden' name='module' value='Opportunities'>\n";
72	72	if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
73	73	if ($currentModule == 'Contacts') {
74		- $button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
75		- $button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
	74	+ $button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
	75	+ $button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
76	76	}
77	77	$button .= "<input type='hidden' name='return_module' value='".$currentModule."'>\n";
78	78	$button .= "<input type='hidden' name='return_action' value='".$action."'>\n";
		@@ -82,60 +82,60 @@ discard block
		block discarded – undo
82	82	$button .= "<input title='".$app_strings['LBL_NEW_BUTTON_TITLE']."' accessyKey='".$app_strings['LBL_NEW_BUTTON_KEY']."' class='button' onclick=\"this.form.action.value='EditView'\" type='submit' name='New' value=' ".$app_strings['LBL_NEW_BUTTON_LABEL']." '>\n";
83	83	if ($currentModule == 'Accounts')
84	84	{
85		- ///////////////////////////////////////
86		- ///
87		- /// SETUP PARENT POPUP
	85	+ ///////////////////////////////////////
	86	+ ///
	87	+ /// SETUP PARENT POPUP
88	88
89		- $popup_request_data = array(
90		- 'call_back_function' => 'set_return_and_save',
91		- 'form_name' => 'DetailView',
92		- 'field_to_name_array' => array(
93		- 'id' => 'opportunity_id',
94		- ),
95		- );
	89	+ $popup_request_data = array(
	90	+ 'call_back_function' => 'set_return_and_save',
	91	+ 'form_name' => 'DetailView',
	92	+ 'field_to_name_array' => array(
	93	+ 'id' => 'opportunity_id',
	94	+ ),
	95	+ );
96	96
97		- $json = getJSONobj();
98		- $encoded_popup_request_data = $json->encode($popup_request_data);
	97	+ $json = getJSONobj();
	98	+ $encoded_popup_request_data = $json->encode($popup_request_data);
99	99
100		- //
101		- ///////////////////////////////////////
	100	+ //
	101	+ ///////////////////////////////////////
102	102
103		- $button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
104		- ."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
105		- ."' type='button' class='button' value=' ".$app_strings['LBL_SELECT_BUTTON_LABEL']
106		- ." ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
	103	+ $button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
	104	+ ."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
	105	+ ."' type='button' class='button' value=' ".$app_strings['LBL_SELECT_BUTTON_LABEL']
	106	+ ." ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
107	107	// ." ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
108	108	}
109	109	else
110	110	{
111		- ///////////////////////////////////////
112		- ///
113		- /// SETUP PARENT POPUP
	111	+ ///////////////////////////////////////
	112	+ ///
	113	+ /// SETUP PARENT POPUP
114	114
115		- $popup_request_data = array(
116		- 'call_back_function' => 'set_return_and_save',
117		- 'form_name' => 'DetailView',
118		- 'field_to_name_array' => array(
119		- 'id' => 'opportunity_id',
120		- ),
121		- );
	115	+ $popup_request_data = array(
	116	+ 'call_back_function' => 'set_return_and_save',
	117	+ 'form_name' => 'DetailView',
	118	+ 'field_to_name_array' => array(
	119	+ 'id' => 'opportunity_id',
	120	+ ),
	121	+ );
122	122
123		- $json = getJSONobj();
124		- $encoded_popup_request_data = $json->encode($popup_request_data);
	123	+ $json = getJSONobj();
	124	+ $encoded_popup_request_data = $json->encode($popup_request_data);
125	125
126		- //
127		- ///////////////////////////////////////
	126	+ //
	127	+ ///////////////////////////////////////
128	128
129		- $button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
130		- ."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
131		- ."' type='button' class='button' value=' ".$app_strings['LBL_SELECT_BUTTON_LABEL']
132		- ." ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
	129	+ $button .= "<input title='".$app_strings['LBL_SELECT_BUTTON_TITLE']
	130	+ ."' accessyKey='".$app_strings['LBL_SELECT_BUTTON_KEY']
	131	+ ."' type='button' class='button' value=' ".$app_strings['LBL_SELECT_BUTTON_LABEL']
	132	+ ." ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
133	133	// ." ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=ContactDetailView&form_submit=true&query=true&account_id=$focus->account_id&account_name=$focus->account_name\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
134	134	}
135	135	$button .= "</form>\n";
136	136	$header_text = '';
137	137	if(is_admin($current_user) && $_REQUEST['module'] != 'DynamicLayout' && !empty($_SESSION['editinplace'])){
138		- $header_text = " <a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=". $_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout","border='0' align='bottom'",null,null,'.gif',$mod_strings['LBL_EDITLAYOUT'])."</a>";
	138	+ $header_text = " <a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=". $_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout","border='0' align='bottom'",null,null,'.gif',$mod_strings['LBL_EDITLAYOUT'])."</a>";
139	139	}
140	140	$ListView = new ListView();
141	141	$ListView->initNewXTemplate( 'modules/Opportunities/SubPanelView.html',$current_module_strings);

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if (!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
3	3	/*********************************************************************************
4	4	* SugarCRM Community Edition is a customer relationship management program developed by
5	5	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
		@@ -134,14 +134,14 @@ discard block
		block discarded – undo
134	134	}
135	135	$button .= "</form>\n";
136	136	$header_text = '';
137		-if(is_admin($current_user) && $_REQUEST['module'] != 'DynamicLayout' && !empty($_SESSION['editinplace'])){
138		- $header_text = " <a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=". $_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout","border='0' align='bottom'",null,null,'.gif',$mod_strings['LBL_EDITLAYOUT'])."</a>";
	137	+if (is_admin($current_user) && $_REQUEST['module'] != 'DynamicLayout' && !empty($_SESSION['editinplace'])) {
	138	+ $header_text = " <a href='index.php?action=index&module=DynamicLayout&from_action=SubPanelView&from_module=Opportunities&record=".$_REQUEST['record']."'>".SugarThemeRegistry::current()->getImage("EditLayout", "border='0' align='bottom'", null, null, '.gif', $mod_strings['LBL_EDITLAYOUT'])."</a>";
139	139	}
140	140	$ListView = new ListView();
141		-$ListView->initNewXTemplate( 'modules/Opportunities/SubPanelView.html',$current_module_strings);
	141	+$ListView->initNewXTemplate('modules/Opportunities/SubPanelView.html', $current_module_strings);
142	142	$ListView->xTemplateAssign("RETURN_URL", "&return_module=".$currentModule."&return_action=DetailView&return_id={$_REQUEST['record']}");
143		-$ListView->xTemplateAssign("EDIT_INLINE_PNG", SugarThemeRegistry::current()->getImage('edit_inline','align="absmiddle" border="0"',null,null,'.gif',$app_strings['LNK_EDIT']));
144		-$ListView->setHeaderTitle($current_module_strings['LBL_MODULE_NAME']. $header_text );
	143	+$ListView->xTemplateAssign("EDIT_INLINE_PNG", SugarThemeRegistry::current()->getImage('edit_inline', 'align="absmiddle" border="0"', null, null, '.gif', $app_strings['LNK_EDIT']));
	144	+$ListView->setHeaderTitle($current_module_strings['LBL_MODULE_NAME'].$header_text);
145	145	$ListView->setHeaderText($button);
146	146	$ListView->processListView($focus_list, "main", "OPPORTUNITY");
147	147

		@@ -14,13 +14,13 @@
		block discarded – undo
14	14	global $app_strings;
15	15
16	16	$script = "<a href='javascript:void(0)' id='export_listview_top' ".
17		- "onclick=\"return sListView.send_form(true, '{$_REQUEST['module']}', " .
18		- "'index.php?entryPoint=export', " .
19		- "'{$app_strings['LBL_LISTVIEW_NO_SELECTED']}')\">{$app_strings['LBL_EXPORT']}</a>" .
20		- "</li><li>". // List item hack
21		- "<a href='javascript:void(0)' id='map_listview_top' " .
22		- " onclick=\"return sListView.send_form(true, 'jjwg_Maps', " .
23		- "'index.php?entryPoint=jjwg_Maps&display_module={$_REQUEST['module']}', " .
	17	+ "onclick=\"return sListView.send_form(true, '{$_REQUEST['module']}', ".
	18	+ "'index.php?entryPoint=export', ".
	19	+ "'{$app_strings['LBL_LISTVIEW_NO_SELECTED']}')\">{$app_strings['LBL_EXPORT']}</a>".
	20	+ "</li><li>".// List item hack
	21	+ "<a href='javascript:void(0)' id='map_listview_top' ".
	22	+ " onclick=\"return sListView.send_form(true, 'jjwg_Maps', ".
	23	+ "'index.php?entryPoint=jjwg_Maps&display_module={$_REQUEST['module']}', ".
24	24	"'{$app_strings['LBL_LISTVIEW_NO_SELECTED']}')\">{$app_strings['LBL_MAP']}</a>";
25	25
26	26	return $script;

		@@ -40,11 +40,11 @@
		block discarded – undo
40	40
41	41
42	42	function perform_save(&$focus){
43		- //US DOLLAR
44		- if(isset($focus->amount) && !number_empty($focus->amount)){
45		- $currency = new Currency();
46		- $currency->retrieve($focus->currency_id);
47		- $focus->amount_usdollar = $currency->convertToDollar(unformat_number($focus->amount));
48		- }
	43	+ //US DOLLAR
	44	+ if(isset($focus->amount) && !number_empty($focus->amount)){
	45	+ $currency = new Currency();
	46	+ $currency->retrieve($focus->currency_id);
	47	+ $focus->amount_usdollar = $currency->convertToDollar(unformat_number($focus->amount));
	48	+ }
49	49	}
50	50	?>
51	51	\ No newline at end of file

		@@ -1,5 +1,7 @@
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if(!defined('sugarEntry') \|\| !sugarEntry) {
	3	+ die('Not A Valid Entry Point');
	4	+}
3	5	/*********************************************************************************
4	6	* SugarCRM Community Edition is a customer relationship management program developed by
5	7	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

		@@ -1,5 +1,7 @@ discard block
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if(!defined('sugarEntry') \|\| !sugarEntry) {
	3	+ die('Not A Valid Entry Point');
	4	+}
3	5	/*********************************************************************************
4	6	* SugarCRM Community Edition is a customer relationship management program developed by
5	7	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.
		@@ -69,7 +71,9 @@ discard block
		block discarded – undo
69	71
70	72	$button = "<form action='index.php' method='post' name='form' id='form'>\n";
71	73	$button .= "<input type='hidden' name='module' value='Opportunities'>\n";
72		-if ($currentModule == 'Accounts') $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
	74	+if ($currentModule == 'Accounts') {
	75	+ $button .= "<input type='hidden' name='account_id' value='$focus->id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->name)."\">\n";
	76	+}
73	77	if ($currentModule == 'Contacts') {
74	78	$button .= "<input type='hidden' name='account_id' value='$focus->account_id'>\n<input type='hidden' name='account_name' value=\"".urlencode($focus->account_name)."\">\n";
75	79	$button .= "<input type='hidden' name='contact_id' value='$focus->id'>\n";
		@@ -105,8 +109,7 @@ discard block
		block discarded – undo
105	109	."' type='button' class='button' value=' ".$app_strings['LBL_SELECT_BUTTON_LABEL']
106	110	." ' name='button' onclick='open_popup(\"Opportunities\", 600, 400, \"\", false, true, {$encoded_popup_request_data});'>\n";
107	111	// ." ' name='button' onclick='window.open(\"index.php?module=Opportunities&action=Popup&html=Popup_picker&form=DetailView&form_submit=true\",\"new\",\"width=600,height=400,resizable=1,scrollbars=1\");'>\n";
108		-}
109		-else
	112	+} else
110	113	{
111	114	///////////////////////////////////////
112	115	///

		@@ -41,26 +41,26 @@
		block discarded – undo
41	41
42	42
43	43	function additionalDetailsOpportunity($fields) {
44		- global $current_language;
45		- $mod_strings = return_module_language($current_language, 'Opportunities');
46		- $overlib_string = '';
	44	+ global $current_language;
	45	+ $mod_strings = return_module_language($current_language, 'Opportunities');
	46	+ $overlib_string = '';
47	47
48		- if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
49		- if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
50		- if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
51		- if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
	48	+ if(!empty($fields['LEAD_SOURCE'])) $overlib_string .= '<b>'. $mod_strings['LBL_LEAD_SOURCE'] . '</b> ' . $fields['LEAD_SOURCE'] . '<br>';
	49	+ if(!empty($fields['PROBABILITY'])) $overlib_string .= '<b>'. $mod_strings['LBL_PROBABILITY'] . '</b> ' . $fields['PROBABILITY'] . '<br>';
	50	+ if(!empty($fields['NEXT_STEP'])) $overlib_string .= '<b>'. $mod_strings['LBL_NEXT_STEP'] . '</b> ' . $fields['NEXT_STEP'] . '<br>';
	51	+ if(!empty($fields['OPPORTUNITY_TYPE'])) $overlib_string .= '<b>'. $mod_strings['LBL_TYPE'] . '</b> ' . $fields['OPPORTUNITY_TYPE'] . '<br>';
52	52
53		- if(!empty($fields['DESCRIPTION'])) {
54		- $overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
55		- $overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
56		- if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
57		- }
	53	+ if(!empty($fields['DESCRIPTION'])) {
	54	+ $overlib_string .= '<b>'. $mod_strings['LBL_DESCRIPTION'] . '</b> ';
	55	+ $overlib_string .= substr($fields['DESCRIPTION'], 0, 300);
	56	+ if(strlen($fields['DESCRIPTION']) > 300) $overlib_string .= '...';
	57	+ }
58	58
59		- return array('fieldToAddTo' => 'NAME',
60		- 'string' => $overlib_string,
61		- 'editLink' => "index.php?action=EditView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}",
62		- 'viewLink' => "index.php?action=DetailView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}");
	59	+ return array('fieldToAddTo' => 'NAME',
	60	+ 'string' => $overlib_string,
	61	+ 'editLink' => "index.php?action=EditView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}",
	62	+ 'viewLink' => "index.php?action=DetailView&module=Opportunities&return_module=Opportunities&record={$fields['ID']}");
63	63	}
64	64
65		- ?>
	65	+ ?>
66	66

		@@ -40,25 +40,25 @@
		block discarded – undo
40	40
41	41	// created: 2005-10-19 11:16:08
42	42	$acldefs['Opportunities'] = array (
43		- 'forms' =>
44		- array (
	43	+ 'forms' =>
	44	+ array (
45	45	'by_name' =>
46	46	array (
47		- 'btn1' =>
48		- array (
	47	+ 'btn1' =>
	48	+ array (
49	49	'display_option' => 'disabled',
50	50	'action_option' => 'list',
51	51	'app_action' => 'EditView',
52	52	'module' => 'Accounts',
53		- ),
	53	+ ),
	54	+ ),
54	55	),
55		- ),
56		- 'form_names' =>
57		- array (
	56	+ 'form_names' =>
	57	+ array (
58	58	'by_id' => 'by_id',
59	59	'by_name' => 'by_name',
60	60	'DetailView' => 'DetailView',
61	61	'EditView' => 'EditView',
62		- ),
	62	+ ),
63	63	);
64	64	?>

		@@ -45,43 +45,43 @@
		block discarded – undo
45	45	),
46	46	'javascript' => '{$PROBABILITY_SCRIPT}',
47	47	),
48		- 'panels' =>array (
49		- 'default' =>
50		- array (
	48	+ 'panels' =>array (
	49	+ 'default' =>
	50	+ array (
51	51
52	52	array (
53		- array('name'=>'name'),
54		- 'account_name',
	53	+ array('name'=>'name'),
	54	+ 'account_name',
55	55	),
56	56	array(
57		- array('name'=>'currency_id','label'=>'LBL_CURRENCY'),
58		- array('name'=>'date_closed'),
	57	+ array('name'=>'currency_id','label'=>'LBL_CURRENCY'),
	58	+ array('name'=>'date_closed'),
59	59	),
60	60	array (
61		- array( 'name'=>'amount'),
62		- 'opportunity_type',
	61	+ array( 'name'=>'amount'),
	62	+ 'opportunity_type',
63	63	),
64	64	array (
65		- 'sales_stage',
66		- 'lead_source',
	65	+ 'sales_stage',
	66	+ 'lead_source',
67	67	),
68	68	array (
69		- 'probability',
70		- 'campaign_name',
	69	+ 'probability',
	70	+ 'campaign_name',
71	71	),
72	72	array (
73		- 'next_step',
	73	+ 'next_step',
74	74	),
75	75	array (
76		- 'description',
	76	+ 'description',
	77	+ ),
77	78	),
78		- ),
79	79
80		- 'LBL_PANEL_ASSIGNMENT' => array(
	80	+ 'LBL_PANEL_ASSIGNMENT' => array(
81	81	array(
82		- 'assigned_user_name',
	82	+ 'assigned_user_name',
	83	+ ),
83	84	),
84		- ),
85	85	)
86	86
87	87

		@@ -45,34 +45,34 @@
		block discarded – undo
45	45	),
46	46	'javascript' => '{$PROBABILITY_SCRIPT}',
47	47	),
48		- 'panels' =>array (
	48	+ 'panels' =>array(
49	49	'default' =>
50		- array (
	50	+ array(
51	51
52		- array (
	52	+ array(
53	53	array('name'=>'name'),
54	54	'account_name',
55	55	),
56	56	array(
57		- array('name'=>'currency_id','label'=>'LBL_CURRENCY'),
	57	+ array('name'=>'currency_id', 'label'=>'LBL_CURRENCY'),
58	58	array('name'=>'date_closed'),
59	59	),
60		- array (
61		- array( 'name'=>'amount'),
	60	+ array(
	61	+ array('name'=>'amount'),
62	62	'opportunity_type',
63	63	),
64		- array (
	64	+ array(
65	65	'sales_stage',
66	66	'lead_source',
67	67	),
68		- array (
	68	+ array(
69	69	'probability',
70	70	'campaign_name',
71	71	),
72		- array (
	72	+ array(
73	73	'next_step',
74	74	),
75		- array (
	75	+ array(
76	76	'description',
77	77	),
78	78	),

		@@ -42,48 +42,48 @@
		block discarded – undo
42	42	global $mod_strings;
43	43
44	44	$popupMeta = array('moduleMain' => 'Opportunity',
45		- 'varName' => 'OPPORTUNITY',
46		- 'orderBy' => 'name',
47		- 'whereClauses' =>
48		- array('name' => 'opportunities.name',
49		- 'account_name' => 'accounts.name'),
50		- 'searchInputs' =>
51		- array('name', 'account_name'),
52		- 'listviewdefs' => array(
53		- 'NAME' => array(
54		- 'width' => '30',
55		- 'label' => 'LBL_LIST_OPPORTUNITY_NAME',
56		- 'link' => true,
57		- 'default' => true),
58		- 'ACCOUNT_NAME' => array(
59		- 'width' => '20',
60		- 'label' => 'LBL_LIST_ACCOUNT_NAME',
61		- 'id' => 'ACCOUNT_ID',
62		- 'module' => 'Accounts',
63		- 'default' => true,
64		- 'sortable'=> true,
65		- 'ACLTag' => 'ACCOUNT'),
66		- 'OPPORTUNITY_TYPE' => array(
67		- 'width' => '15',
68		- 'default' => true,
69		- 'label' => 'LBL_TYPE'),
70		- 'SALES_STAGE' => array(
71		- 'width' => '10',
72		- 'label' => 'LBL_LIST_SALES_STAGE',
73		- 'default' => true),
74		- 'ASSIGNED_USER_NAME' => array(
75		- 'width' => '5',
76		- 'label' => 'LBL_LIST_ASSIGNED_USER',
77		- 'default' => true),
78		- ),
79		- 'searchdefs' => array(
80		- 'name',
81		- array('name' => 'account_name', 'displayParams' => array('hideButtons'=>'true', 'size'=>30, 'class'=>'sqsEnabled sqsNoAutofill')),
82		- 'opportunity_type',
83		- 'sales_stage',
84		- array('name' => 'assigned_user_id', 'type' => 'enum', 'label' => 'LBL_ASSIGNED_TO', 'function' => array('name' => 'get_user_array', 'params' => array(false))),
85		- )
86		- );
	45	+ 'varName' => 'OPPORTUNITY',
	46	+ 'orderBy' => 'name',
	47	+ 'whereClauses' =>
	48	+ array('name' => 'opportunities.name',
	49	+ 'account_name' => 'accounts.name'),
	50	+ 'searchInputs' =>
	51	+ array('name', 'account_name'),
	52	+ 'listviewdefs' => array(
	53	+ 'NAME' => array(
	54	+ 'width' => '30',
	55	+ 'label' => 'LBL_LIST_OPPORTUNITY_NAME',
	56	+ 'link' => true,
	57	+ 'default' => true),
	58	+ 'ACCOUNT_NAME' => array(
	59	+ 'width' => '20',
	60	+ 'label' => 'LBL_LIST_ACCOUNT_NAME',
	61	+ 'id' => 'ACCOUNT_ID',
	62	+ 'module' => 'Accounts',
	63	+ 'default' => true,
	64	+ 'sortable'=> true,
	65	+ 'ACLTag' => 'ACCOUNT'),
	66	+ 'OPPORTUNITY_TYPE' => array(
	67	+ 'width' => '15',
	68	+ 'default' => true,
	69	+ 'label' => 'LBL_TYPE'),
	70	+ 'SALES_STAGE' => array(
	71	+ 'width' => '10',
	72	+ 'label' => 'LBL_LIST_SALES_STAGE',
	73	+ 'default' => true),
	74	+ 'ASSIGNED_USER_NAME' => array(
	75	+ 'width' => '5',
	76	+ 'label' => 'LBL_LIST_ASSIGNED_USER',
	77	+ 'default' => true),
	78	+ ),
	79	+ 'searchdefs' => array(
	80	+ 'name',
	81	+ array('name' => 'account_name', 'displayParams' => array('hideButtons'=>'true', 'size'=>30, 'class'=>'sqsEnabled sqsNoAutofill')),
	82	+ 'opportunity_type',
	83	+ 'sales_stage',
	84	+ array('name' => 'assigned_user_id', 'type' => 'enum', 'label' => 'LBL_ASSIGNED_TO', 'function' => array('name' => 'get_user_array', 'params' => array(false))),
	85	+ )
	86	+ );
87	87
88	88
89	89	?>
90	90	\ No newline at end of file

		@@ -1,5 +1,5 @@
		block discarded – undo
1	1	<?php
2		-if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
	2	+if (!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');
3	3	/*********************************************************************************
4	4	* SugarCRM Community Edition is a customer relationship management program developed by
5	5	* SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.

		@@ -38,102 +38,102 @@
		block discarded – undo
38	38	********************************************************************************/
39	39
40	40	$searchdefs['Opportunities'] = array(
41		- 'templateMeta' =>
42		- array (
	41	+ 'templateMeta' =>
	42	+ array (
43	43	'maxColumns' => '3',
44	44	'maxColumnsBasic' => '4',
45	45	'widths' =>
46	46	array (
47		- 'label' => '10',
48		- 'field' => '30',
	47	+ 'label' => '10',
	48	+ 'field' => '30',
	49	+ ),
49	50	),
50		- ),
51		- 'layout' =>
52		- array (
	51	+ 'layout' =>
	52	+ array (
53	53	'basic_search' =>
54	54	array (
55		- 'name' =>
56		- array (
	55	+ 'name' =>
	56	+ array (
57	57	'name' => 'name',
58	58	'default' => true,
59	59	'width' => '10%',
60		- ),
61		- 'current_user_only' =>
62		- array (
	60	+ ),
	61	+ 'current_user_only' =>
	62	+ array (
63	63	'name' => 'current_user_only',
64	64	'label' => 'LBL_CURRENT_USER_FILTER',
65	65	'type' => 'bool',
66	66	'default' => true,
67	67	'width' => '10%',
68		- ),
69		- array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
70		- array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
	68	+ ),
	69	+ array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
	70	+ array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
71	71
72	72	),
73	73	'advanced_search' =>
74	74	array (
75		- 'name' =>
76		- array (
	75	+ 'name' =>
	76	+ array (
77	77	'name' => 'name',
78	78	'default' => true,
79	79	'width' => '10%',
80		- ),
81		- 'account_name' =>
82		- array (
	80	+ ),
	81	+ 'account_name' =>
	82	+ array (
83	83	'name' => 'account_name',
84	84	'default' => true,
85	85	'width' => '10%',
86		- ),
87		- 'amount' =>
88		- array (
	86	+ ),
	87	+ 'amount' =>
	88	+ array (
89	89	'name' => 'amount',
90	90	'default' => true,
91	91	'width' => '10%',
92		- ),
93		- 'assigned_user_id' =>
94		- array (
	92	+ ),
	93	+ 'assigned_user_id' =>
	94	+ array (
95	95	'name' => 'assigned_user_id',
96	96	'type' => 'enum',
97	97	'label' => 'LBL_ASSIGNED_TO',
98	98	'function' =>
99	99	array (
100		- 'name' => 'get_user_array',
101		- 'params' =>
102		- array (
	100	+ 'name' => 'get_user_array',
	101	+ 'params' =>
	102	+ array (
103	103	0 => false,
104		- ),
	104	+ ),
105	105	),
106	106	'default' => true,
107	107	'width' => '10%',
108		- ),
109		- 'sales_stage' =>
110		- array (
	108	+ ),
	109	+ 'sales_stage' =>
	110	+ array (
111	111	'name' => 'sales_stage',
112	112	'default' => true,
113	113	'width' => '10%',
114		- ),
115		- 'lead_source' =>
116		- array (
	114	+ ),
	115	+ 'lead_source' =>
	116	+ array (
117	117	'name' => 'lead_source',
118	118	'default' => true,
119	119	'width' => '10%',
120		- ),
121		- 'date_closed' =>
122		- array (
	120	+ ),
	121	+ 'date_closed' =>
	122	+ array (
123	123	'name' => 'date_closed',
124	124	'default' => true,
125	125	'width' => '10%',
126		- ),
127		- 'next_step' =>
128		- array (
	126	+ ),
	127	+ 'next_step' =>
	128	+ array (
129	129	'type' => 'varchar',
130	130	'label' => 'LBL_NEXT_STEP',
131	131	'width' => '10%',
132	132	'default' => true,
133	133	'name' => 'next_step',
134		- ),
	134	+ ),
	135	+ ),
135	136	),
136		- ),
137	137
138	138	);
139	139	?>

		@@ -39,67 +39,67 @@ discard block
		block discarded – undo
39	39
40	40	$searchdefs['Opportunities'] = array(
41	41	'templateMeta' =>
42		- array (
	42	+ array(
43	43	'maxColumns' => '3',
44	44	'maxColumnsBasic' => '4',
45	45	'widths' =>
46		- array (
	46	+ array(
47	47	'label' => '10',
48	48	'field' => '30',
49	49	),
50	50	),
51	51	'layout' =>
52		- array (
	52	+ array(
53	53	'basic_search' =>
54		- array (
	54	+ array(
55	55	'name' =>
56		- array (
	56	+ array(
57	57	'name' => 'name',
58	58	'default' => true,
59	59	'width' => '10%',
60	60	),
61	61	'current_user_only' =>
62		- array (
	62	+ array(
63	63	'name' => 'current_user_only',
64	64	'label' => 'LBL_CURRENT_USER_FILTER',
65	65	'type' => 'bool',
66	66	'default' => true,
67	67	'width' => '10%',
68	68	),
69		- array ('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
70		- array ('name' => 'favorites_only','label' => 'LBL_FAVORITES_FILTER','type' => 'bool',),
	69	+ array('name' => 'open_only', 'label' => 'LBL_OPEN_ITEMS', 'type' => 'bool', 'default' => false, 'width' => '10%'),
	70	+ array('name' => 'favorites_only', 'label' => 'LBL_FAVORITES_FILTER', 'type' => 'bool',),
71	71
72	72	),
73	73	'advanced_search' =>
74		- array (
	74	+ array(
75	75	'name' =>
76		- array (
	76	+ array(
77	77	'name' => 'name',
78	78	'default' => true,
79	79	'width' => '10%',
80	80	),
81	81	'account_name' =>
82		- array (
	82	+ array(
83	83	'name' => 'account_name',
84	84	'default' => true,
85	85	'width' => '10%',
86	86	),
87	87	'amount' =>
88		- array (
	88	+ array(
89	89	'name' => 'amount',
90	90	'default' => true,
91	91	'width' => '10%',
92	92	),
93	93	'assigned_user_id' =>
94		- array (
	94	+ array(
95	95	'name' => 'assigned_user_id',
96	96	'type' => 'enum',
97	97	'label' => 'LBL_ASSIGNED_TO',
98	98	'function' =>
99		- array (
	99	+ array(
100	100	'name' => 'get_user_array',
101	101	'params' =>
102		- array (
	102	+ array(
103	103	0 => false,
104	104	),
105	105	),
		@@ -107,25 +107,25 @@ discard block
		block discarded – undo
107	107	'width' => '10%',
108	108	),
109	109	'sales_stage' =>
110		- array (
	110	+ array(
111	111	'name' => 'sales_stage',
112	112	'default' => true,
113	113	'width' => '10%',
114	114	),
115	115	'lead_source' =>
116		- array (
	116	+ array(
117	117	'name' => 'lead_source',
118	118	'default' => true,
119	119	'width' => '10%',
120	120	),
121	121	'date_closed' =>
122		- array (
	122	+ array(
123	123	'name' => 'date_closed',
124	124	'default' => true,
125	125	'width' => '10%',
126	126	),
127	127	'next_step' =>
128		- array (
	128	+ array(
129	129	'type' => 'varchar',
130	130	'label' => 'LBL_NEXT_STEP',
131	131	'width' => '10%',

		@@ -42,28 +42,28 @@
		block discarded – undo
42	42
43	43
44	44	$GLOBALS['studioDefs']['Opportunities'] = array(
45		- 'LBL_DETAILVIEW'=>array(
46		- 'template'=>'xtpl',
47		- 'template_file'=>'modules/Opportunities/DetailView.html',
48		- 'php_file'=>'modules/Opportunities/DetailView.php',
49		- 'type'=>'DetailView',
50		- ),
51		- 'LBL_EDITVIEW'=>array(
52		- 'template'=>'xtpl',
53		- 'template_file'=>'modules/Opportunities/EditView.html',
54		- 'php_file'=>'modules/Opportunities/EditView.php',
55		- 'type'=>'EditView',
56		- ),
57		- 'LBL_LISTVIEW'=>array(
58		- 'template'=>'listview',
59		- 'meta_file'=>'modules/Opportunities/listviewdefs.php',
60		- 'type'=>'ListView',
61		- ),
62		- 'LBL_SEARCHFORM'=>array(
63		- 'template'=>'xtpl',
64		- 'template_file'=>'modules/Opportunities/SearchForm.html',
65		- 'php_file'=>'modules/Opportunities/ListView.php',
66		- 'type'=>'SearchForm',
67		- ),
	45	+ 'LBL_DETAILVIEW'=>array(
	46	+ 'template'=>'xtpl',
	47	+ 'template_file'=>'modules/Opportunities/DetailView.html',
	48	+ 'php_file'=>'modules/Opportunities/DetailView.php',
	49	+ 'type'=>'DetailView',
	50	+ ),
	51	+ 'LBL_EDITVIEW'=>array(
	52	+ 'template'=>'xtpl',
	53	+ 'template_file'=>'modules/Opportunities/EditView.html',
	54	+ 'php_file'=>'modules/Opportunities/EditView.php',
	55	+ 'type'=>'EditView',
	56	+ ),
	57	+ 'LBL_LISTVIEW'=>array(
	58	+ 'template'=>'listview',
	59	+ 'meta_file'=>'modules/Opportunities/listviewdefs.php',
	60	+ 'type'=>'ListView',
	61	+ ),
	62	+ 'LBL_SEARCHFORM'=>array(
	63	+ 'template'=>'xtpl',
	64	+ 'template_file'=>'modules/Opportunities/SearchForm.html',
	65	+ 'php_file'=>'modules/Opportunities/ListView.php',
	66	+ 'type'=>'SearchForm',
	67	+ ),
68	68
69	69	);

adamjakab / SuiteCRM

Push — CI ( 785a66...02428e )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Indentation +39 added lines, -39 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Braces +18 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +42 added lines, -42 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +44 added lines, -44 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Indentation +23 added lines, -23 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch