adamjakab / SuiteCRM

tests/tests/include/MVC/View/views/view.popupTest.php

Spacing +9 added lines, -9 removed lines

@@ -3,18 +3,18 @@ 
 class ViewPopupTest extends PHPUnit_Framework_TestCase
 {
 
-	public function testViewPopup(){
+	public function testViewPopup() {
 
 		//execute the contructor and check for the Object type and type attribute
 		$view = new ViewPopup();
-		$this->assertInstanceOf('ViewPopup',$view);
-		$this->assertInstanceOf('SugarView',$view);
-		$this->assertAttributeEquals('list','type', $view);
+		$this->assertInstanceOf('ViewPopup', $view);
+		$this->assertInstanceOf('SugarView', $view);
+		$this->assertAttributeEquals('list', 'type', $view);
 		
 		unset($view);
 	}
 
-	public function testdisplay(){
+	public function testdisplay() {
 		
 		//error_reporting(E_ERROR | E_PARSE |E_ALL);
 		
@@ -22,11 +22,11 @@ 
 		$view = new ViewPopup();
 		$view->module = "Accounts";
 		
-		try{
+		try {
 			$view->bean = new Account();
 		}
-		Catch(Exception $e){
-			$this->assertStringStartsWith('mysqli_query()',$e->getMessage());
+		Catch (Exception $e) {
+			$this->assertStringStartsWith('mysqli_query()', $e->getMessage());
 		}
 	
 		ob_start();
@@ -36,7 +36,7 @@ 
 		$renderedContent = ob_get_contents();
 		ob_end_clean();
 		
-		$this->assertGreaterThan(0,strlen($renderedContent));
+		$this->assertGreaterThan(0, strlen($renderedContent));
 		
 	}
 }

tests/tests/include/MVC/View/views/view.jsonTest.php

Spacing +5 added lines, -5 removed lines

@@ -2,17 +2,17 @@
 
 class ViewJsonTest extends PHPUnit_Framework_TestCase
 {
-	function testViewJson(){
+	function testViewJson() {
 
 		//execute the contructor and check for the Object type and type attribute
 		$view = new ViewJson();
-		$this->assertInstanceOf('ViewJson',$view);
-		$this->assertInstanceOf('SugarView',$view);
-		$this->assertAttributeEquals('detail','type', $view);		
+		$this->assertInstanceOf('ViewJson', $view);
+		$this->assertInstanceOf('SugarView', $view);
+		$this->assertAttributeEquals('detail', 'type', $view);		
  	}
 
  	//incomplete test. this method uses exit() so it cannot be tested.
-	function testdisplay(){
+	function testdisplay() {
 
 		/*
 		setup required paramerers and execute the method. 

tests/tests/include/MVC/View/views/view.htmlTest.php

Spacing +5 added lines, -5 removed lines

@@ -3,17 +3,17 @@ 
 class ViewHtmlTest extends PHPUnit_Framework_TestCase
 {
 
-	public function testViewHtml(){
+	public function testViewHtml() {
 		
 		//execute the contructor and check for the Object type
 		$view = new ViewHtml();
-		$this->assertInstanceOf('ViewHtml',$view);
-		$this->assertInstanceOf('SugarView',$view);
+		$this->assertInstanceOf('ViewHtml', $view);
+		$this->assertInstanceOf('SugarView', $view);
 
 		
  	}
  	
- 	public function testdisplay(){
+ 	public function testdisplay() {
  		
  		$view = new ViewHtml();
  		 
@@ -21,7 +21,7 @@ 
  		try {
  			$view->display();
  			 
- 		} catch (Exception $e) {
+ 		}catch (Exception $e) {
  			$this->fail();
  		}
  	}

tests/tests/include/MVC/View/views/view.sugarpdfTest.php

Spacing +12 added lines, -12 removed lines

@@ -1,21 +1,21 @@ 
 <?php
 
 
-class ViewSugarpdfTest extends PHPUnit_Framework_TestCase{
+class ViewSugarpdfTest extends PHPUnit_Framework_TestCase {
     
     
-     function testViewSugarpdf(){
+     function testViewSugarpdf() {
      	error_reporting(E_ERROR | E_WARNING | E_PARSE);
      	      	
      	//execute the method without request parameters and test if it works. it should output some headers and throw headers output exception.
      	try {
      		$view = new ViewSugarpdf();
      		 
-     	} catch (Exception $e) {
-     		$this->assertStringStartsWith('Cannot modify header information',$e->getMessage());
+     	}catch (Exception $e) {
+     		$this->assertStringStartsWith('Cannot modify header information', $e->getMessage());
      		
      	}
-     	$this->assertEquals(Null,$view);
+     	$this->assertEquals(Null, $view);
      	
      	
      	
@@ -23,22 +23,22 @@ 
      	$_REQUEST["sugarpdf"] = 'someValue'; 
      	$view = new ViewSugarpdf();
      	$view->module = "Users";
-     	$this->assertInstanceOf('ViewSugarpdf',$view);
-     	$this->assertInstanceOf('SugarView',$view);
-     	$this->assertAttributeEquals('sugarpdf','type', $view);
-     	$this->assertAttributeEquals('someValue','sugarpdf', $view);
-     	$this->assertAttributeEquals(NULL,'sugarpdfBean', $view);
+     	$this->assertInstanceOf('ViewSugarpdf', $view);
+     	$this->assertInstanceOf('SugarView', $view);
+     	$this->assertAttributeEquals('sugarpdf', 'type', $view);
+     	$this->assertAttributeEquals('someValue', 'sugarpdf', $view);
+     	$this->assertAttributeEquals(NULL, 'sugarpdfBean', $view);
      	
      }
 
    
     //Incomplete test. SugarpdfFactory::loadSugarpdf throws fatal error. error needs to be resolved before testing.     
-    function testpreDisplay(){
+    function testpreDisplay() {
     	$this->markTestIncomplete('Can Not be implemented');
      }
      
     //Incomplete test.  SugarpdfFactory::loadSugarpdf throws fatal error. error needs to be resolved before testing.
-    function testdisplay(){
+    function testdisplay() {
     	$this->markTestIncomplete('Can Not be implemented');
      }
 

tests/tests/include/MVC/View/views/view.importvcardTest.php

Spacing +4 added lines, -4 removed lines

@@ -7,9 +7,9 @@ 
     {
     	//execute the contructor and check for the Object type and type attribute
     	$view = new ViewImportvcard();
-    	$this->assertInstanceOf('ViewImportvcard',$view);
-    	$this->assertInstanceOf('SugarView',$view);
-    	$this->assertAttributeEquals('edit','type', $view);  	 
+    	$this->assertInstanceOf('ViewImportvcard', $view);
+    	$this->assertInstanceOf('SugarView', $view);
+    	$this->assertAttributeEquals('edit', 'type', $view);  	 
  	}
  	
 
@@ -25,7 +25,7 @@ 
     	$view->display();
     	$renderedContent = ob_get_contents();
     	ob_end_clean();
-    	$this->assertGreaterThan(0,strlen($renderedContent));
+    	$this->assertGreaterThan(0, strlen($renderedContent));
     	
  	}
 }

tests/tests/include/MVC/SugarModuleTest.php

Spacing +11 added lines, -11 removed lines

@@ -7,24 +7,24 @@ 
 	{
 		//test for invalid input
 		$sugarmodule = new SugarModule('');
-		$this->assertAttributeEquals(null,'_moduleName', $sugarmodule);
+		$this->assertAttributeEquals(null, '_moduleName', $sugarmodule);
 	
 		//test for valid input
 		$sugarmodule_user = SugarModule::get('User');
-		$this->assertAttributeEquals('User','_moduleName', $sugarmodule_user);
+		$this->assertAttributeEquals('User', '_moduleName', $sugarmodule_user);
 	}
 	
     public function testget()
     {
     	//test for invalid input
     	$sugarmodule = SugarModule::get('');
-    	$this->assertInstanceOf('SugarModule',$sugarmodule);
-    	$this->assertAttributeEquals(null,'_moduleName', $sugarmodule);
+    	$this->assertInstanceOf('SugarModule', $sugarmodule);
+    	$this->assertAttributeEquals(null, '_moduleName', $sugarmodule);
     	
     	//test for valid input
     	$sugarmodule_user = SugarModule::get('User');
-    	$this->assertInstanceOf('SugarModule',$sugarmodule_user);
-    	$this->assertAttributeEquals('User','_moduleName', $sugarmodule_user);
+    	$this->assertInstanceOf('SugarModule', $sugarmodule_user);
+    	$this->assertAttributeEquals('User', '_moduleName', $sugarmodule_user);
     	    	
     }
 
@@ -33,17 +33,17 @@ 
     	//test for invalid input
     	$sugarmodule = new SugarModule('');
     	$result = $sugarmodule->moduleImplements('Basic');
-    	$this->assertEquals( false, $result);
+    	$this->assertEquals(false, $result);
     	
     	//test for invalid input
     	$sugarmodule_user = new SugarModule('Users');
     	$result = $sugarmodule_user->moduleImplements('SugarModule');
-    	$this->assertFalse( $result);    	
+    	$this->assertFalse($result);    	
 
     	//test for valid input
     	$sugarmodule_user = new SugarModule('Users');
     	$result = $sugarmodule_user->moduleImplements('Basic');
-    	$this->assertEquals( true, $result);    	
+    	$this->assertEquals(true, $result);    	
     	
     }
 
@@ -53,12 +53,12 @@ 
     	//test for invalid input
     	$sugarmodule = new SugarModule('');
     	$result = $sugarmodule->loadBean();
-    	$this->assertFalse( $result);
+    	$this->assertFalse($result);
     	
     	//test for valid input
     	$sugarmodule_user = new SugarModule('Users');
     	$result = $sugarmodule_user->loadBean();
-    	$this->assertInstanceOf('User',$result);
+    	$this->assertInstanceOf('User', $result);
     	    	  	
     }
 }

tests/tests/include/MVC/Controller/ControllerFactoryTest.php

Spacing +4 added lines, -4 removed lines

@@ -4,16 +4,16 @@
 class ControllerFactoryTest  extends PHPUnit_Framework_TestCase
 {
 
-	public function testgetController(){
+	public function testgetController() {
 		
 		//execute the method with invalid input
 		$controller = ControllerFactory::getController('');
-		$this->assertInstanceOf('SugarController',$controller);
+		$this->assertInstanceOf('SugarController', $controller);
 
 		//execute the method with valid input and check if it returns correct instance
 		$controller = ControllerFactory::getController('Users');
-		$this->assertInstanceOf('UsersController',$controller);		
-		$this->assertInstanceOf('SugarController',$controller);
+		$this->assertInstanceOf('UsersController', $controller);		
+		$this->assertInstanceOf('SugarController', $controller);
 		
 	}
 

tests/tests/include/MVC/Controller/SugarControllerTest.php

Spacing +21 added lines, -21 removed lines

@@ -4,7 +4,7 @@ 
 class SugarControllerTest  extends PHPUnit_Framework_TestCase
 {
 
-	public function testsetup(){
+	public function testsetup() {
 		
 		
 		$SugarController = new SugarController();
@@ -12,27 +12,27 @@ 
 		
 		//first test with empty parameter and check for default values being used
 		$SugarController->setup('');
-		$this->assertAttributeEquals($default_module,'module', $SugarController);
-		$this->assertAttributeEquals(null,'target_module', $SugarController);
+		$this->assertAttributeEquals($default_module, 'module', $SugarController);
+		$this->assertAttributeEquals(null, 'target_module', $SugarController);
 
 		//secondly test with module name and check for correct assignment. 
 		$SugarController->setup('Users');
-		$this->assertAttributeEquals('Users','module', $SugarController);
-		$this->assertAttributeEquals(null,'target_module', $SugarController);
+		$this->assertAttributeEquals('Users', 'module', $SugarController);
+		$this->assertAttributeEquals(null, 'target_module', $SugarController);
 	
 	
 	}
 
-	public function testsetModule(){
+	public function testsetModule() {
 		$SugarController = new SugarController();
 		
 		//first test with empty parameter
 		$SugarController->setModule('');
-		$this->assertAttributeEquals('','module', $SugarController);
+		$this->assertAttributeEquals('', 'module', $SugarController);
 		
 		//secondly test with module name and check for correct assignment.
 		$SugarController->setModule('Users');
-		$this->assertAttributeEquals('Users','module', $SugarController);		
+		$this->assertAttributeEquals('Users', 'module', $SugarController);		
 	}
 
 
@@ -43,12 +43,12 @@ 
 		//first test with empty parameter and check for null. Default is Home but Home has no bean
 		$SugarController->setModule('');
 		$SugarController->loadBean();
-		$this->assertEquals(null,$SugarController->bean );
+		$this->assertEquals(null, $SugarController->bean);
 		
 		//secondly test with module name and check for correct bean class loaded.
 		$SugarController->setModule('Users');
 		$SugarController->loadBean();
-		$this->assertInstanceOf('User',$SugarController->bean);
+		$this->assertInstanceOf('User', $SugarController->bean);
 		
 	}
 
@@ -60,7 +60,7 @@ 
     	//execute the method and check if it works and doesn't throws an exception
     	try {
     		$SugarController->execute();
-    	} catch (Exception $e) {
+    	}catch (Exception $e) {
     		$this->fail();
     	}
     	
@@ -69,14 +69,14 @@ 
 	}
 
 
-	public function testprocess(){
+	public function testprocess() {
 
 		$SugarController = new SugarController();
 		 
 		//execute the method and check if it works and doesn't throws an exception
 		try {
 			$SugarController->process();
-		} catch (Exception $e) {
+		}catch (Exception $e) {
 			$this->fail();
 		}
 		 
@@ -85,7 +85,7 @@ 
 	}
 
 
-	public function testpre_save(){
+	public function testpre_save() {
 
 		$SugarController = new SugarController();
 		$SugarController->setModule('Users');
@@ -95,7 +95,7 @@ 
 		//Fail if it throws any other exception.
 		try {
 			$SugarController->pre_save();
-		} catch (Exception $e) {
+		}catch (Exception $e) {
 			$this->assertStringStartsWith('mysqli_query()', $e->getMessage());
 		}
 			
@@ -104,7 +104,7 @@ 
 	}
 
 
-	public function testaction_save(){
+	public function testaction_save() {
 		
 		$SugarController = new SugarController();
 		$SugarController->setModule('Users');
@@ -114,7 +114,7 @@ 
 		//Fail if it throws any other exception.
 		try {
 			$SugarController->action_save();
-		} catch (Exception $e) {
+		}catch (Exception $e) {
 			$this->assertStringStartsWith('mysqli_query()', $e->getMessage());
 		}
 			
@@ -128,11 +128,11 @@ 
     	$SugarController = new SugarController();
     	
     	//first check with default value of attribute
-    	$this->assertAttributeEquals('classic','view', $SugarController);
+    	$this->assertAttributeEquals('classic', 'view', $SugarController);
     	
     	//secondly check for attribute value change on method execution.
     	$SugarController->action_spot();
-    	$this->assertAttributeEquals('spot','view', $SugarController);
+    	$this->assertAttributeEquals('spot', 'view', $SugarController);
     }
 
 
@@ -140,11 +140,11 @@ 
 
 		//first check with a invalid value
 		$action = SugarController::getActionFilename('');
-		$this->assertEquals('',$action );
+		$this->assertEquals('', $action);
 		
 		//secondly check with a valid value
 		$action = SugarController::getActionFilename('editview');
-		$this->assertEquals('EditView',$action );
+		$this->assertEquals('EditView', $action);
 		
 	}
 

tests/tests/include/utils/securityUtilsTest.php

Spacing +14 added lines, -14 removed lines

@@ -10,7 +10,7 @@ 
 		//execute the method and test it it returns expected contents
 		
 		$user = new User('1');
-		$expected = array (
+		$expected = array(
 				'Home' => 'Home',
 				'Accounts' => 'Accounts',
 				'Contacts' => 'Contacts',
@@ -48,7 +48,7 @@ 
 		);		
 		
 		$actual = query_module_access_list($user);
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 				
 	}
@@ -61,7 +61,7 @@ 
 		
 		$expected = "0";
 		$actual = query_user_has_roles('1');
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}
 	
@@ -71,7 +71,7 @@ 
 		
 		$expected = Array();
 		$actual = get_user_allowed_modules('1');
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 	
 	}
 	
@@ -79,7 +79,7 @@ 
 	{
 		//execute the method and test it it returns expected contents
 		
-		$expected = array (
+		$expected = array(
 				'Bugs' => 'Bugs',
                 'Reminders' => 'Reminders',
                 'Reminders_Invitees' => 'Reminders_Invitees',
@@ -88,9 +88,9 @@ 
 		);
 		
 		$allowed = query_module_access_list(new User('1'));
-		$actual = get_user_disallowed_modules('1',$allowed);
+		$actual = get_user_disallowed_modules('1', $allowed);
 	
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 				
 	}
@@ -98,17 +98,17 @@ 
 	public function testquery_client_ip()
 	{
 		//test without setting any server parameters
-		$this->assertSame(Null,query_client_ip());
+		$this->assertSame(Null, query_client_ip());
 
 		//test with server params set
 		$_SERVER['REMOTE_ADDR'] = "1.1.1.3";
-		$this->assertSame("1.1.1.3",query_client_ip());
+		$this->assertSame("1.1.1.3", query_client_ip());
 		
 		$_SERVER['HTTP_FROM'] = "1.1.1.2";
-		$this->assertSame("1.1.1.2",query_client_ip());
+		$this->assertSame("1.1.1.2", query_client_ip());
 		
 		$_SERVER['HTTP_CLIENT_IP'] = "1.1.1.1";
-		$this->assertSame("1.1.1.1",query_client_ip());
+		$this->assertSame("1.1.1.1", query_client_ip());
 		
 	}
 	
@@ -116,10 +116,10 @@ 
 	public function testget_val_array()
 	{
 		//execute the method and test it it returns expected contents
-		$tempArray = Array("key1"=>"val1","key2"=>"val2","key3"=>"val3");
-		$expected = Array("key1"=>"key1","key2"=>"key2","key3"=>"key3");
+		$tempArray = Array("key1"=>"val1", "key2"=>"val2", "key3"=>"val3");
+		$expected = Array("key1"=>"key1", "key2"=>"key2", "key3"=>"key3");
 		$actual = get_val_array($tempArray);
-		$this->assertSame($expected,$actual);
+		$this->assertSame($expected, $actual);
 		
 	}